From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 10 08:01:12 2021 Received: (at submit) by debbugs.gnu.org; 10 Sep 2021 12:01:12 +0000 Received: from localhost ([127.0.0.1]:37141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfDU-0004lq-9E for submit@debbugs.gnu.org; Fri, 10 Sep 2021 08:01:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOdxL-0002BN-W7 for submit@debbugs.gnu.org; Fri, 10 Sep 2021 06:40:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOdxJ-0007f2-W8 for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 06:40:27 -0400 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]:39752) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOdx0-000345-MN for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 06:40:20 -0400 Received: by mail-lj1-x230.google.com with SMTP id q21so2468297ljj.6 for ; Fri, 10 Sep 2021 03:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=5TMYnE67bLNe3uTGgwCMaLFC4mDfVxn2u0HlpiYyv44=; b=L2UvZxro9GuLrmwMF5m7MBJ1C4HImWEIkEVpt7S2OiGCb9XfjhZUVVX4OuJuB6RwsU 9fpMKXcYLxDV/MJLAqQYqzDLotYmyY8MoWhVOuwqvT5lb1wNDPFJj2kDYnSFx/XrE0QA Ytkvl1ZzHXNT9bgY9nB9EbONbTHeydQiCxNNN5VLPLmIORkCHkWzXaGXo7fOnmnRKu3u jNQT02HZwfudi9Ln8/tdZgMr9+spmTqYGuhlmWxTsdaTwXxpxGuV+TwvCEDtWKW++iEy vE+eFmsyqIiY3tp3ln/NrjKBEkaeRzxdoa3UNIGxYUqa0q+Bb9ixmkOox/+5OJ+3PGeb GFFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=5TMYnE67bLNe3uTGgwCMaLFC4mDfVxn2u0HlpiYyv44=; b=5YPtqCgkcgkdoI7FAPqNhBHf5JYnIMjOMfRg7iFZZk1vigktvbeRLECG9AATzPWQ4C 1yUY/21t4mYWLPDI6IiJprzR7O9OhfaB4raqx48rrZroXmdwbFlQZzFX2vn2FwiVa8OJ TaNJBFygjUhior08UKKv8U6SFkKUO9+1ixeWSe/QgKmAcbpXvx4aRx1hAcIwTziDEo5j R7ycMkpVrd+cQUJhFHGFvG9UtGlF3agqJsA2841yAO3dGKxXuvoDoLyaaq+LAD+qYvjU SqeW7QGDTRYIUwBqpyHf5R7BPRfjpRCh52fvHJ9Kd0iUD7A2bG17qk6AFmuiuDgdpgdH clcg== X-Gm-Message-State: AOAM531VtFyEx7T8NBmuSPlKr7X5Iv/34XloXeWZ04NtoXGx9zM9Z6an WzB8A8KE2/EeS/TXrWopFADeu/nr4pwQAbyv2aVfbud5iZxkGA== X-Google-Smtp-Source: ABdhPJwU+SDaqH+gjLawCunL/iY9FJMg+swPNWQJc6DeEqb/rOu74FkzCFyWaRR+6g78vYZYDd9faASoWrsubUdalgY= X-Received: by 2002:a05:651c:10a:: with SMTP id a10mr3627996ljb.37.1631270403968; Fri, 10 Sep 2021 03:40:03 -0700 (PDT) MIME-Version: 1.0 From: Nikolaos Chatzikonstantinou Date: Fri, 10 Sep 2021 19:39:52 +0900 Message-ID: Subject: New function in Emacs GnuTLS implementation To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::230; envelope-from=nchatz314@gmail.com; helo=mail-lj1-x230.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 10 Sep 2021 08:01:08 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello bug-gnu-emacs, I am looking at the src/gnutls.c:gnutls-boot function for the purpose of modifying it to use the function gnutls_certificate_set_x509_key_file2 instead of gnutls_certificate_set_x509_key_file. (Note the missing `2') The reason for this addition would be to protect the key with a password. Note that the pass parameter may be NULL. Moreover, the Emacs functionality could do with more than just file access; users could provide their certificates and keys that lie in memory instead of a file. This may be useful. I am sending this e-mail to gauge interest in this as a proposal. It makes sense to me but I am not very experienced. How does one submit a patch for Emacs? Is it via the mailing lists by attaching a diff hunk? Thank you for your attention. Regards, Nikolaos Chatzikonstantinou -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHHHUCYKNdWl5h845DtNR6zceZEgFAmE7NYYACgkQDtNR6zce ZEgSjg//SDJzOtoYZBeGZ5FbXeR52Tt11+ztXlwFpgk+aIW5PNu+XzWMci7kp0BL vxYkXKaKINHC8FM393r2wFxWbBf+Jss1tqtATl56s3VWwowXU4X7II+qI5hkjJok jC6lRhxkPkhCNijDXBXxMTwGEoKo6/qiRzFCb46C5lGkYahsvNMZQGagadGV3tde JFKhBHIR6W6JGGqkKgXZ4CL1627elzUBooLA0QfY8jzM8JOErCRo5tgD/A6omE/K Uot9EMAOIAOID2XQQ8fPATSUxAqrlV9HvLW0fo+xE4jCraEhmhHNyFyWAnb3uCB9 LD9OOmN6xC9QeN6B0DVbv1VVYhCn78APEEXuglUv57LSkCGJteUh7zphwbKwwdbk 81ifniPlwnzjGIiq5B6dCYRQD2wCdVOczF7Nu8Zjoo9DQxUC/TiY3r5HnlSSUZVv Msqfd/kdCVv19+JhZe5CKcTTPjXgdeJLR442Q/WD101KPtvdIkoZjBzoSnbd7tcC qfj3X88xnVPJWmPViFNHVSD0EhCha6jCdLz0NF9ttacaoxrg5ocyg2itBLKTy7V9 excqFwCkxjfDMIOmMTES/a2TZ3bisJRc6XrGPgYYy7eAaXmLaynrxpqO7vOCGYiW kYtBR8dgPLU3UYivn0KKgbyDeZdSNNZ008/mmIwPHIEh6FOvFLk= =kjif -----END PGP SIGNATURE----- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 10 08:40:01 2021 Received: (at 50507) by debbugs.gnu.org; 10 Sep 2021 12:40:01 +0000 Received: from localhost ([127.0.0.1]:37187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfp2-0005hE-Rn for submit@debbugs.gnu.org; Fri, 10 Sep 2021 08:40:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOfp1-0005h1-Nt for 50507@debbugs.gnu.org; Fri, 10 Sep 2021 08:39:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41548) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOfow-00026N-7f; Fri, 10 Sep 2021 08:39:54 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOfov-0006UL-Q4; Fri, 10 Sep 2021 08:39:54 -0400 Date: Fri, 10 Sep 2021 15:39:35 +0300 Message-Id: <83ee9wiozc.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Fri, 10 Sep 2021 19:39:52 +0900) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Fri, 10 Sep 2021 19:39:52 +0900 > > I am looking at the src/gnutls.c:gnutls-boot function for the purpose of > modifying it to use the function gnutls_certificate_set_x509_key_file2 > instead of gnutls_certificate_set_x509_key_file. (Note the missing `2') > > The reason for this addition would be to protect the key with a > password. Note that the pass parameter may be NULL. Do you intend to make the change unconditionally, or do you intend to make it an optional feature? And what is the minimal GnuTLS version which provided this function? > I am sending this e-mail to gauge interest in this as a proposal. It > makes sense to me but I am not very experienced. How does one submit > a patch for Emacs? Is it via the mailing lists by attaching a diff > hunk? Yes, you provide a patch as an attachment, preferably in the "git format-patch" format. See the file CONTRIBUTE in the Emacs Git repository for more details. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 11 11:34:55 2021 Received: (at 50507) by debbugs.gnu.org; 11 Sep 2021 15:34:55 +0000 Received: from localhost ([127.0.0.1]:41243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP51q-0005Ez-U6 for submit@debbugs.gnu.org; Sat, 11 Sep 2021 11:34:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP51o-0005Ej-HC for 50507@debbugs.gnu.org; Sat, 11 Sep 2021 11:34:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35752) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mP51j-0005ot-A5; Sat, 11 Sep 2021 11:34:47 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2565 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mP51i-0003sd-Pr; Sat, 11 Sep 2021 11:34:47 -0400 Date: Sat, 11 Sep 2021 18:34:31 +0300 Message-Id: <83fsubgm7s.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Sun, 12 Sep 2021 00:28:33 +0900) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Sun, 12 Sep 2021 00:28:33 +0900 > Cc: 50507@debbugs.gnu.org > > > > The reason for this addition would be to protect the key with a > > > password. Note that the pass parameter may be NULL. > > > > Do you intend to make the change unconditionally, or do you intend to > > make it an optional feature? > > > > And what is the minimal GnuTLS version which provided this function? > > I intend to introduce new functions without changing any of the others. > The following functions were added at 2013-04-08: > > gnutls_certificate_set_x509_key_file2 > gnutls_certificate_set_x509_key_mem2 > > Versions after 3.2 and 3.1.11 include them. Although it appears > straightforward to introduce them, my plan is to spend some time > acclimating myself with GnuTLS and the Emacs implementation to ensure > that I did it right, and then I'll submit a patch. Does it sound good? Yes, SGTM. Thank you very much for working on this. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 11 11:52:37 2021 Received: (at 50507) by debbugs.gnu.org; 11 Sep 2021 15:52:38 +0000 Received: from localhost ([127.0.0.1]:41252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP5Iz-0005gE-Na for submit@debbugs.gnu.org; Sat, 11 Sep 2021 11:52:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP5Iy-0005fz-5W for 50507@debbugs.gnu.org; Sat, 11 Sep 2021 11:52:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35910) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mP5Is-00043b-Ma; Sat, 11 Sep 2021 11:52:30 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mP5Is-0006Ef-6g; Sat, 11 Sep 2021 11:52:30 -0400 Date: Sat, 11 Sep 2021 18:52:16 +0300 Message-Id: <83ee9vgle7.fsf@gnu.org> From: Eli Zaretskii To: nchatz314@gmail.com In-Reply-To: <83fsubgm7s.fsf@gnu.org> (message from Eli Zaretskii on Sat, 11 Sep 2021 18:34:31 +0300) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <83fsubgm7s.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 11 Sep 2021 18:34:31 +0300 > From: Eli Zaretskii > Cc: 50507@debbugs.gnu.org > > > Versions after 3.2 and 3.1.11 include them. Although it appears > > straightforward to introduce them, my plan is to spend some time > > acclimating myself with GnuTLS and the Emacs implementation to ensure > > that I did it right, and then I'll submit a patch. Does it sound good? > > Yes, SGTM. Thank you very much for working on this. And, of course, don't hesitate to ask questions if something in the existing implementation is unclear. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 11 11:58:09 2021 Received: (at 50507) by debbugs.gnu.org; 11 Sep 2021 15:58:09 +0000 Received: from localhost ([127.0.0.1]:41267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP5OL-0005u8-Ab for submit@debbugs.gnu.org; Sat, 11 Sep 2021 11:58:09 -0400 Received: from mail-lj1-f177.google.com ([209.85.208.177]:41887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mP4vz-00054X-91 for 50507@debbugs.gnu.org; Sat, 11 Sep 2021 11:28:51 -0400 Received: by mail-lj1-f177.google.com with SMTP id o11so1003295ljp.8 for <50507@debbugs.gnu.org>; Sat, 11 Sep 2021 08:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pEnl/ZcPPwYBeSMHrGg0peWDIZSWskknYCsDFBN70b8=; b=W22XAfAXvqfQxwTY9aT9S6iyJbcH1zBY+luwf+XW32B6avVkoqEKyuJM7kWi1NRx5Y +1robpd1BAsR4jXjoJmMQHgfqRiZIKbgIhVuePTJCsT+64KWn/oRh+jFyqOX3K9uMjxN P+9615IQtmZbWfkUnP1lT1SuQOa4V2Vl+8ywtqFpDMx+1mEyWzEuJE2LcJD+FBMCV+ay HiP/Wit95Uix7d0H2cwI5DHKbBpQg5RC3WwDeZBL5HUG5zksly8JkM753JP0e1ZfrdGX jQWVgyUavMDee3Wsfcbsc1Lpfe1RZzNlZF+NRwj3qigsZd0xdXIeF3bfkUm/HAa/7ZCe XL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pEnl/ZcPPwYBeSMHrGg0peWDIZSWskknYCsDFBN70b8=; b=SW+Lw3i4TBQM0V9UyEs2aVcdUJVlbI0Aoj+7sz+fSlpC8JBs7EF+mtHFUQPWNBysGb IVMP17DScePpobxLdaHoaF6aazqsH6jfZoY+1KmT4l49tXFb0bJaEo8St5DR+/Vlcx/c h/8ks4gZkad7vOdQt9dO2E7qT322sxVCBt8gWm+kJqkMqaunZvDs0JRLfQIp1rJwJR0e Tj5Yw2ccCRawgFMPF1lrV297WgTpUJ7BMnc+fnvoXINyDW6wmIYclX7vrNnfhpkxlFJP KULxV89qT+SSJ5xXG7VdLsaPYxks3ae4J3kGjDWoYUxDR270dYl/BpardWiPar12QDsQ kDQg== X-Gm-Message-State: AOAM533w0NwjkVkY4VvNfRsjG96gOaKFRojIeX6RjR31qsZncmn3/phh bAClHZbNo7/Mbv+OAw0UMhNQlKYZNNvlpfJoJ90XHxf8nE9UMp5E X-Google-Smtp-Source: ABdhPJxtHa0ul1wCjxFZqoVp+EVhGBXbwiM+RdgvWs2RbxvqIYmD9oLyWZ5w5VvJGp2MArGM2fLD9kSa12o/yypsB9k= X-Received: by 2002:a2e:a4ca:: with SMTP id p10mr2639377ljm.415.1631374125089; Sat, 11 Sep 2021 08:28:45 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> In-Reply-To: <83ee9wiozc.fsf@gnu.org> From: Nikolaos Chatzikonstantinou Date: Sun, 12 Sep 2021 00:28:33 +0900 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 X-Mailman-Approved-At: Sat, 11 Sep 2021 11:58:07 -0400 Cc: 50507@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 > From: Eli Zaretskii > Date: Fri, 10 Sep 2021 15:39:35 +0300 > > From: Nikolaos Chatzikonstantinou > > Date: Fri, 10 Sep 2021 19:39:52 +0900 > > > > I am looking at the src/gnutls.c:gnutls-boot function for the > > purpose of modifying it to use the function > > gnutls_certificate_set_x509_key_file2 > > instead of gnutls_certificate_set_x509_key_file. (Note the missing > > `2') > > > > The reason for this addition would be to protect the key with a > > password. Note that the pass parameter may be NULL. > > Do you intend to make the change unconditionally, or do you intend to > make it an optional feature? > > And what is the minimal GnuTLS version which provided this function? I intend to introduce new functions without changing any of the others. The following functions were added at 2013-04-08: gnutls_certificate_set_x509_key_file2 gnutls_certificate_set_x509_key_mem2 Versions after 3.2 and 3.1.11 include them. Although it appears straightforward to introduce them, my plan is to spend some time acclimating myself with GnuTLS and the Emacs implementation to ensure that I did it right, and then I'll submit a patch. Does it sound good? Regards, Nikolaos Chatzikonstantinou -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHHHUCYKNdWl5h845DtNR6zceZEgFAmE8yqkACgkQDtNR6zce ZEjF9hAAyoLaoIbMEmzaJ/TrzTyucic4L78LTYyoMMAB7UgNgWFwhRZ+6POUc2N2 UiIjuz5JBGtpUIBgQS/DOyzZppZxGyJMa+VeIu1rEypk6NYw4XVVgXgOg2kEpM5R WBgdFmafsyUmNWwr9xEs8QtfaXE0qVlQA4TIXNJSI7iZsgK6B/WZbez1TBbiOign Wydgzvvb9NcRRvMUV5BHxFMfTt7dDWiN2jpCx7mYizcjWnSiAwB/75H82YAGCIa+ vHKwGGX3Fl+k6bkd9dNeaNXX//seKecgOzipodu2KeahgY3AXSxL+t9jPIwRU0gp dfm/h6qc9189WZ1hvigFpEgvU44Uc2yUUyDFQ+Gp7dLAaLo1KHsD9jVnG7WFtMBw Owcz7CwD4nYHGBwqucijrtAjurclvus7Yuqh1aayMkYySjJCN0IoQOMmbpVYUbaZ lP83wooZ4C624x0hSMIQNtAoDSB5en05ny71DkPTTozDvkED5vxfZkoARaSnQFiO NeirllWwz07ZQck1PvoJXgOUvytUEf5OS4pJNvLX11/qGUzfwBWA1ZWO3mHAPHAx K3iMUxWtRF0VnpvS6X1dXj0MYIhhJ/aEpYh/IL4uPyQrfrWoMUEmDgw3LNPB01Er tqGpeSiWbQ/YSE6AERoYf+gsuaHnsOMWwxyznwvkWWfn12I4/34= =qL1/ -----END PGP SIGNATURE----- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 14:17:36 2021 Received: (at control) by debbugs.gnu.org; 25 Sep 2021 18:17:36 +0000 Received: from localhost ([127.0.0.1]:34669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCEy-0008Rq-6U for submit@debbugs.gnu.org; Sat, 25 Sep 2021 14:17:36 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:35613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCEr-0008RA-Ti for control@debbugs.gnu.org; Sat, 25 Sep 2021 14:17:30 -0400 Received: by mail-pg1-f173.google.com with SMTP id e7so13326873pgk.2 for ; Sat, 25 Sep 2021 11:17:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=tYz10Ezxb6w+tN1ra9LF/Evv79hRfhwDhGVZRMhJbss=; b=2TODZ1eNZOpHXYgeBRl2393jYgMKV0XqthN5jUiUhov3D+wZwnm9SXfhXxMryBuUHu l7Uec1zhsNVYd5P9AVr6SKoGM6yCj4Z99Mo1caKoVPMjAQi+f4v1rplTaJwFCGA6wSy7 3C0uDUnzU6/sw6zYs//uLxiS5Rk5LipwsO90jSm9z4vfz1rmhUQOnG2LcQ4CgbOKruMl GD52cmUmZZP9Y0ZQG4+YloNjIWYysdpwaUp5KbjAsRtcMjwLv0FQfGgdmOHKMn16hYBK ta83zKMaGns9OhmW9+fmXzJN87g3zeSJM3+30bo5xQU7gRjmNbRxTPIFvMmAVLz6eE2w IAow== X-Gm-Message-State: AOAM532lRRKNaRq8vGgM91a7VlmMS2SNRUJJb3tZP0BM70r68iuoqytg iluLhGekPLV5ffOjphAqXt/43XW9wmHlbTQWzj/ynuARBQk= X-Google-Smtp-Source: ABdhPJzGC6NCXjEDycSUEa4riQnL9d+7G/0NBK9VDV6u0WPcBXbmyGFFR8veEatf7/3L6qT6n140JvWjds01E/F/6ek= X-Received: by 2002:a63:4717:: with SMTP id u23mr9113907pga.359.1632593844364; Sat, 25 Sep 2021 11:17:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 25 Sep 2021 11:17:24 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Sat, 25 Sep 2021 11:17:24 -0700 Message-ID: Subject: control message for bug #50507 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 50507 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 11:08:02 2022 Received: (at 50507) by debbugs.gnu.org; 25 Aug 2022 15:08:03 +0000 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRESg-0004sr-K0 for submit@debbugs.gnu.org; Thu, 25 Aug 2022 11:08:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRESe-0004sF-OV for 50507@debbugs.gnu.org; Thu, 25 Aug 2022 11:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ii4ftesq1/SsBqrqczCTmenHAfJpuw1zMuT5pzfQTKc=; b=KlMy0naxLvLagfw/vCAJgXNLG1 46VpTi14n9waKy049LCTgQojmdLE7QfoRFzJQw6XjWhHvffRztAkF+q/EbmJQsA8HUIG/cIWVRVAG I8cIyS/QveQlR2bP4WL7Cv4+eeV6ScEMYfOPG668uveGmNz593SMbhuqlbig00KDeC7s=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRESV-0000U2-Gk; Thu, 25 Aug 2022 17:07:53 +0200 From: Lars Ingebrigtsen To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Sun, 12 Sep 2021 00:28:33 +0900") References: <83ee9wiozc.fsf@gnu.org> X-Now-Playing: The Notwist's _Neon Golden_: "Pilot" Date: Thu, 25 Aug 2022 17:07:50 +0200 Message-ID: <87sflkgy49.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Nikolaos Chatzikonstantinou writes: > Versions after 3.2 and 3.1.11 include them. Although it appears > straightforward to introduce them, my plan is to spend some time > acclimating myself with GnuTLS and the Emacs implementation to en [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Nikolaos Chatzikonstantinou writes: > Versions after 3.2 and 3.1.11 include them. Although it appears > straightforward to introduce them, my plan is to spend some time > acclimating myself with GnuTLS and the Emacs implementation to ensure > that I did it right, and then I'll submit a patch. Does it sound good? Sounds good to me. This was almost a year ago -- did you get any further with this? From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 11:08:08 2022 Received: (at control) by debbugs.gnu.org; 25 Aug 2022 15:08:08 +0000 Received: from localhost ([127.0.0.1]:51022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRESl-0004tG-T7 for submit@debbugs.gnu.org; Thu, 25 Aug 2022 11:08:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRESk-0004sQ-AZ for control@debbugs.gnu.org; Thu, 25 Aug 2022 11:08:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TmA5JvgA8hGP5EF5xcMIlreExIkjjq40Sz86UCpwUEs=; b=j/CUEInnqKsNOOmOnj9FX/JWmX pPmwtFkrLQp1g3Az/gw18RylpimgS+uci4B8Gngx46F+9ticUaEpZm5CvYzG671cTB3lNgIkZC0Nu xxlN9ctpKftXoHaPsYvcY/LT/0PI/1D3Dd/siwtRuoXmr9OCA/8sM9k3lGCTjcIarpTg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRESc-0000UB-Po for control@debbugs.gnu.org; Thu, 25 Aug 2022 17:08:00 +0200 Date: Thu, 25 Aug 2022 17:07:56 +0200 Message-Id: <87r114gy43.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50507 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 50507 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 50507 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 14 11:51:46 2022 Received: (at 50507) by debbugs.gnu.org; 14 Sep 2022 15:51:46 +0000 Received: from localhost ([127.0.0.1]:55832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYUfx-00046g-Rw for submit@debbugs.gnu.org; Wed, 14 Sep 2022 11:51:46 -0400 Received: from mail-yb1-f177.google.com ([209.85.219.177]:42885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYUfu-00046Q-H5 for 50507@debbugs.gnu.org; Wed, 14 Sep 2022 11:51:45 -0400 Received: by mail-yb1-f177.google.com with SMTP id 130so23398084ybz.9 for <50507@debbugs.gnu.org>; Wed, 14 Sep 2022 08:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=X7QreXQZSsry1vUwQ+FNb8RxVhxYydluwUjiAoYUbRI=; b=qtDTwuFR3RFDO9AN5p5jxCPSZufw0QCc7KFJpZ6AYyf25KOlksXujx+J9EwAzcSrG1 xMBMYcmy0+EbR7v8cU+HEjsrlX9k1QEQLKq0g1SwWd2pfa3dbNT2dXoFYC9yZhma+u9r 3ZBvboAwVVSFztkeHpYtREF29EmONBqJhLy+XQ074tpHHOyOUHcXSM4WXvR4n7fx4Hj7 Gve7qlTPhR702AtcMzjuLcjFV4AGEOgyernSARrJSdBAAJsF0jC66CuJ3dxNPXg66Lr5 hymZHj4Txb+w0hzhgGXv3oYymXYW76BHGsqD7xyzwoXZMLS2uxEVG9WkwvRGez+UFNhb axiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=X7QreXQZSsry1vUwQ+FNb8RxVhxYydluwUjiAoYUbRI=; b=QqGqbugU6PQwHk8x2CNZqL9z/ta95pjvvRA6ewCYgx9x1NbQOVz3HNEG/OkYHoVYV7 5REl/Iq+r1l2xJHGVlkRSnNZ1lY0lwtADMd++WFHEWfvfSrLCqJkD2jD2VLXjKLB38WS K23lxLk+sEJfvqVCBcF9S6pAk5Xc3kz9KS/t475jXSHETmAZPPrOvCfD3uN/9Xc44DF0 vE4/ApMCAvusl/j+xIlxQjU9XgV2bfSZpnoS7Ud3CTfwIsFmG4ModVNY0iqxq9AHu8Wv QRl1x/sLoR/zPkPVSZvblhhAv0TZ5z2Wex/w4k0+FeiGYru4LZaKAElUNCReCk8X34St wm+A== X-Gm-Message-State: ACgBeo1AjqpOEfrmJ0WNRLjxGRwkRa0UxjfN8+1XWcF1jVbT5f2qKZ0z W2NuHsnzgczRyaHDZy0qrIHGMon6akZ2wXeLTg4= X-Google-Smtp-Source: AA6agR7+rtL2J8pO8pv5iZNDfYTmDMyqMc9gKxw5cFlLzOiy0D1NqY5T/WbI3p88PqIpAE/tGp8E21fcn0ZZtDotuOw= X-Received: by 2002:a25:424f:0:b0:6ac:9f04:5cf with SMTP id p76-20020a25424f000000b006ac9f0405cfmr28758700yba.60.1663170696783; Wed, 14 Sep 2022 08:51:36 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> In-Reply-To: <87sflkgy49.fsf@gnus.org> From: Nikolaos Chatzikonstantinou Date: Wed, 14 Sep 2022 11:51:25 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Thu, Aug 25, 2022 at 11:07 AM Lars Ingebrigtsen wrote: > > Nikolaos Chatzikonstantinou writes: > > > Versions after 3.2 and 3.1.11 include them. Although it appears > > straightforward to introduce them, my plan is to spend some time > > acclimating myself with GnuTLS and the Emacs implementation to ensure > > that I did it right, and then I'll submit a patch. Does it sound good? > > Sounds good to me. > > This was almost a year ago -- did you get any further with this? Thanks for reminding me of this. I spent my time learning some cryptography and doing other things, unrelated to Emacs. I feel better equipped now to tackle this issue, but it will take some time, I expect a month or less. Luckily I have a lot of free time right now. My goal is to increase the completion of the Emacs wrapper of GnuTLS. Originally I cared only to add enough to implement encryption-at-rest for the circe IRC client. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 03:09:47 2022 Received: (at 50507) by debbugs.gnu.org; 15 Sep 2022 07:09:47 +0000 Received: from localhost ([127.0.0.1]:56852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYj0N-0001P5-1R for submit@debbugs.gnu.org; Thu, 15 Sep 2022 03:09:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYj0I-0001Of-4y for 50507@debbugs.gnu.org; Thu, 15 Sep 2022 03:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FeirN15avh6fzDRBZAxBFqj8HD9vy1nvuGMIehsD/qk=; b=J6BGgRGquvCgI+r04CTZO71eoE PtK5TfQxuDTN8ZevEFTaDgfNULSlqKScqmbmc9gSY3kvJhtru+8UG2ZTpGJEyyHa6vXR8wUtVcI6w q4uoJcNpfuAiq5UR7Cj6ehHgu6mWRmOfh9aUwzNrTg1QyQTFN+FNMCpHzguNIuBXrCw0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYj09-0007kQ-D1; Thu, 15 Sep 2022 09:09:35 +0200 From: Lars Ingebrigtsen To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Wed, 14 Sep 2022 11:51:25 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUhHB0oIyNYSEKT dmzjwrX////3c5ssAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJDwcDDH5uKXUAAAFFSURBVDjL7ZPh bcQwCIXNTQB0gfDcAXomG8T7z1Sw3bu0jdRK/VtOFyl8BgyPlHJlwuXaSMofTAFI2DdQ3f0SqAzj XyT/tx+ML710OfdYgXTnP8LOnEiWJlyIP503WDxSrdOarNOCIOf9mWmYxA3plJM/VDeOCLV0LL/O 3RmXUqOP4jRyR4DyAEyrUeJ05i+upYZIJLMBEpjFKlbPEmChBVQRx3MZ3SoQd5gg8uDFsPfevakA PCOyYByrPS2BzlneMi2g+wCe5SdQgjzB0eS2gJDlxzEzRa54m7PPHgBf/n4sMMYaAfsJTCGjmczU H2a2FA5Qqz/Bm+W1hh9fQCqQSg/wqNE3HaCMtmtbId59yxnLECmLj0aOBm+sdcgrCWq8x6c+RN1C A1iqB7Qo0kAcJ2L+CVA4tikmu+/Nt839db/fQ2boO+f/RiO2cVKPAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA5LTE1VDA3OjAzOjEyKzAwOjAwzAGIFgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w OS0xNVQwNzowMzoxMiswMDowML1cMKoAAAAASUVORK5CYII= X-Now-Playing: Console's _Herself_: "For Herself" Date: Thu, 15 Sep 2022 09:09:31 +0200 Message-ID: <87edwd15ck.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Nikolaos Chatzikonstantinou writes: > I spent my time learning some cryptography and doing other > things, unrelated to Emacs. I feel better equipped now to tackle > this issue, but it will take some time, I expect a month or > less. Lu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Nikolaos Chatzikonstantinou writes: > I spent my time learning some cryptography and doing other > things, unrelated to Emacs. I feel better equipped now to tackle > this issue, but it will take some time, I expect a month or > less. Luckily I have a lot of free time right now. > > My goal is to increase the completion of the Emacs wrapper of > GnuTLS. Originally I cared only to add enough to implement > encryption-at-rest for the circe IRC client. Great; looking forward to it. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 05:56:48 2022 Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 09:56:48 +0000 Received: from localhost ([127.0.0.1]:49312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ockr1-0003ix-ND for submit@debbugs.gnu.org; Mon, 26 Sep 2022 05:56:48 -0400 Received: from mail-yw1-f178.google.com ([209.85.128.178]:43944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ockqy-0003ii-Ir for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 05:56:45 -0400 Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-333a4a5d495so62632177b3.10 for <50507@debbugs.gnu.org>; Mon, 26 Sep 2022 02:56:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=d03G0jIFz6IGDOgNfDVEPr2s9/BcqrpOUmZU8D6KRMs=; b=KIqReZVQlHtU3wheyCF6wXT2qK2fnpSp//lJuBqJTIrMKL5/oUlqeqymG2iVhg80ve RryQO26OMBZnsWgJdA/mrDKpxz6hKM1rgDxn2u26bYjFYUlpMABFsRZvozDjNrXxvar3 fd7dVhXKhbNkuGSUqsmstA+XSeSmrgg8VNw5pFdnBp4HE7FqZDQk7L/O+H5QN5R4fLoq /ZLpwvphQdAxtV3Z3ZLMiDc6daSUeKwnivIe4DXyYKY1UTyvoV1Qt950JYTymmazVsqJ PUtbjR1NX+jRm8b9BNaiqMW3tHe8UErYwwspT9UtXeFUgbtjNnC6qben2vi2kO7oi1k8 WVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=d03G0jIFz6IGDOgNfDVEPr2s9/BcqrpOUmZU8D6KRMs=; b=6ivhUphYB9kHe2Zawgl7m4ac9QybMTQprmVTPSGwsrVp4R0dW4FVYbtAMCtPwUvv7c 5fwxgFpFnVLC/UTn1o87baYDFTsCAnpMxJ1lFmLtCNAGjVk7f1N1FTkrIc3YB2hdGoMs c0MCJ2swnWE2TWGcLD/Xk02210lUqHJM7NMmGdJslBqga9sqObgtggykYHG/pWW45lJn dHPdnYSPkaNv6fCjKK2QymAcIwUHSQf9qOlAY9F67594qnbY6xIGGiuFZYEl8NvHpWok 1Jy+mTPsbt4d1r079ZsETPSsgFT+ohBIpiIhYCQ4uN2aHaiMZe/5EnkQg04mFkBCh6Uf quIw== X-Gm-Message-State: ACrzQf1SuDEZAuWQ+AeTxhc7H+K/r7/2qzAJERKwfwh02ERvSOYXkBBc y+xoSdxkPu2sTY62Eo6DNsean1cd3qiuVX2q9D4= X-Google-Smtp-Source: AMsMyM60zcVzmlFLGw5lWtEo+YPAoFadkbfqaXNGbq/odzwEjpldZOmUuZ7/x024yWnqva/ZtkUHNLtyd3IAx0J+U4U= X-Received: by 2002:a81:8606:0:b0:349:17ad:6998 with SMTP id w6-20020a818606000000b0034917ad6998mr19428191ywf.409.1664186198095; Mon, 26 Sep 2022 02:56:38 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> In-Reply-To: <87edwd15ck.fsf@gnus.org> From: Nikolaos Chatzikonstantinou Date: Mon, 26 Sep 2022 05:56:27 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Thu, Sep 15, 2022 at 3:09 AM Lars Ingebrigtsen wrote: > > Nikolaos Chatzikonstantinou writes: > > > > My goal is to increase the completion of the Emacs wrapper of > > GnuTLS. Originally I cared only to add enough to implement > > encryption-at-rest for the circe IRC client. > > Great; looking forward to it. I have a small update. I looked into src/gnutls.c to see which functions are implemented. In total, there's 19 functions defined with DEFUN, gnutls-hash-digest gnutls-format-certificate gnutls-peer-status-warning-describe gnutls-peer-status gnutls-deinit gnutls-hash-mac gnutls-errorp gnutls-error-fatalp gnutls-error-string gnutls-macs gnutls-digests gnutls-ciphers gnutls-available-p gnutls-boot gnutls-bye gnutls-asynchronous-parameters gnutls-get-initstage gnutls-symmetric-encrypt gnutls-symmetric-decrypt However, I suspect that this API is not used by most packages. Instead, these functions are called from Emacs' make-network-process and friends in src/process.c. If I just dump new gnutls functions in src/gnutls.c, they might not be accessible for use, or I might duplicate functionality. Before I make sensible changes to src/gnutls.c, I would need to understand better how the functions are used in src/process.c. However, that file is lacking function comments. Therefore, since I'll be studying it anyhow, I suggest that my first patch will be C documentation for those functions in src/process.c. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 07:03:29 2022 Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 11:03:29 +0000 Received: from localhost ([127.0.0.1]:49406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocltY-0007nR-RE for submit@debbugs.gnu.org; Mon, 26 Sep 2022 07:03:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocltV-0007nD-RT for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 07:03:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5GsUKF/Sq6+YkN4NxI71XRp41N0K4kH7KwpL0xnt5fk=; b=ZFiSLL6JiJLdyLMI8/+tBcbjpD W4xBZJ7yLS3a2ERzY29pxSOQXagsR35a4otmhBejrLUp1OxLXAFvDBsUJH2E57NiS3ozHp6pK46jc A+94GHy7uFjXcZEsxTY2iAhnBNaVddQV1z+kHq3QM18RCEv9oiFF/qg2HyiWhNuIzUTs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocltN-0007G0-4h; Mon, 26 Sep 2022 13:03:19 +0200 From: Lars Ingebrigtsen To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Mon, 26 Sep 2022 05:56:27 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUiHy9ANEEaGDPL e0n///8Oec6aAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJGgoyLOxCOvEAAAGpSURBVDjLbZSJdcQw CEQBNwBSA1hpIIr77y0Durx5YS+vvmEAIROFsRneL1Om5u1fAyB6L7DJAGlywIVAJT2W66QXxOQA p/m/MZG3A4RV2UtqwNlYBnBhaeKKyy97oNLLBOSCe7mEh6l1m6G8Qfo2/c5orZWlAT0UZF352Vlm KpByLPbGtezKE4QEVxG6+yeI+kzDcQPKbNEwMnL19vjLw4VMHB7O0v2IO0n+qOAWe2sgEGo3C8wn lGTv+UG2Uf1LI7ekPiD4umb7EzhpgjCk8OnxLFNawP8CeQHmuVyPxxisCWrfIG1pdzYAmr3yCQzA qC4glP27sopvgDLFMyeuhrsxBnj90EgowzEcVK+I9pSI7u2A3vFBXqlBEaqdbAeIjY6B9jgfBxg8 IqNRi64eookx3kS7JYPEfI6aF7AM1iPrD7BUaoI2Qo2ErQ51Mx9jsFoZIIsfYE37FEG7dG1t+GAS cQZGrHliAHDYWQ0NzuoxW+s4axwh4+65WYZ2vA4nmoks7xqR9sA5ltijO3Kb7sdEAMRyWiYjQj5L cHfb6yspOhezRcOFfgEKDG6WHUUrNgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0yNlQxMDo1 MDo0NCswMDowMOd/rFEAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMjZUMTA6NTA6NDQrMDA6 MDCWIhTtAAAAAElFTkSuQmCC X-Now-Playing: Fire Escape's _Abandon Head_: "Getaway People" Date: Mon, 26 Sep 2022 13:03:16 +0200 Message-ID: <87tu4u8kjv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Nikolaos Chatzikonstantinou writes: > However, I suspect that this API is not used by most > packages. Instead, these functions are called from Emacs' > make-network-process and friends in src/process.c. If I just dump new > gnutls func [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Nikolaos Chatzikonstantinou writes: > However, I suspect that this API is not used by most > packages. Instead, these functions are called from Emacs' > make-network-process and friends in src/process.c. If I just dump new > gnutls functions in src/gnutls.c, they might not be accessible for > use, or I might duplicate functionality. I'm not sure I understand what you mean here. The point was to use gnutls_certificate_set_x509_key_file2 instead of gnutls_certificate_set_x509_key_file in gnutls.c -- so that should be an internal change in gnutls.c that nothing else should need to know about. > Before I make sensible changes to src/gnutls.c, I would need to > understand better how the functions are used in > src/process.c. However, that file is lacking function > comments. Therefore, since I'll be studying it anyhow, I suggest that > my first patch will be C documentation for those functions in > src/process.c. process.c has an abundance of comments already, but if there's further comments that would be helpful, that's welcome, of course. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 11:44:08 2022 Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 15:44:08 +0000 Received: from localhost ([127.0.0.1]:51404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocqH9-0003Tk-Nt for submit@debbugs.gnu.org; Mon, 26 Sep 2022 11:44:08 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocqGz-0003T0-Vf for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 11:44:06 -0400 Received: by mail-yb1-f170.google.com with SMTP id 4so736662ybe.2 for <50507@debbugs.gnu.org>; Mon, 26 Sep 2022 08:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=9XHn5i3VFl8o6/zelFDw1gSZqqWfKVg64w35DdJQfPs=; b=eAAEXLcMCXGT5Hslh5dEzkwSCpnngumfztib4Y01oldNNyDI7zVV1/h8MLk1aZOizS zLE3HpUGtLjoV+hyWSyD/n2c87aFIELV9GT8GAJ7gDAWXB5KWwXmtMzdwZLz4/1galjs nh2CG1gF40ebFA6Nzmn4JJdFCVU2EnsM1m5rwWrJ93HMbfpU7KtC5B3EvXKaDCtKFDOn txAOIoCKOWPl5vd2r3MzgQVVuecWMyTTBgPd1StHNAmDrvaijH6XXRZ9V+ZOqwSLKj9O KUcOcgCfpb42A3jwgJK61eKbu2XL2FrFyiXD+E6E4/Hzu441zvx9gCoYqpcgUcP4nqqJ Zxvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9XHn5i3VFl8o6/zelFDw1gSZqqWfKVg64w35DdJQfPs=; b=KcWKukGDdD42nzjz/fwr9L6dW27vGr1uXQCUddLE1HPqgKx3er/3wxI6IwBpk340C1 fA7HYnvodAyGsa2G1zA6s2wI89VALmX28PjCWKMwEy0c0KL6R2Efv/bTE0+oiz8KijCA a9/w/pr4tpjKlGfNYFbWtrnMmTp9ecsc94jX27NNaN95IPJFoB+pNv2qIvxOH5DM3xm+ mPLx4KE9yyPj+Rgwd88qGy0KbcoC8Fv65Bl9eIC4HupZVbmbB8Zea6EETX5DKpXOcqiA Pg3arnnxBkKYFum81FpJaxwBaKdpjyL+sE4EQYPJQoYjc2jJmVHZr0NzNSCojZzx96F3 zHvQ== X-Gm-Message-State: ACrzQf3r9fnB+9bfE3X8D1u0B9/YSU85DfuWqjh0QIJ408Re8uZDkXI4 ISQ0jvgCeJExDpfEGyKhwMwN7BT5QiCnMbsNozk= X-Google-Smtp-Source: AMsMyM4Alv5He3qwxbkUslJME+WYiKHZ69lJzV0pkzlFSRMRaxfRUwbulJgJfmbqOeyLzf95Q3Hmmml0elTa9Yh+4KU= X-Received: by 2002:a25:8b8b:0:b0:6af:93be:c53e with SMTP id j11-20020a258b8b000000b006af93bec53emr21602434ybl.338.1664207032155; Mon, 26 Sep 2022 08:43:52 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> In-Reply-To: <87tu4u8kjv.fsf@gnus.org> From: Nikolaos Chatzikonstantinou Date: Mon, 26 Sep 2022 11:43:41 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000fc7e1305e996646d" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000fc7e1305e996646d Content-Type: text/plain; charset="UTF-8" On Mon, Sep 26, 2022 at 7:03 AM Lars Ingebrigtsen wrote: > > Nikolaos Chatzikonstantinou writes: > > > However, I suspect that this API is not used by most > > packages. Instead, these functions are called from Emacs' > > make-network-process and friends in src/process.c. If I just dump new > > gnutls functions in src/gnutls.c, they might not be accessible for > > use, or I might duplicate functionality. > > I'm not sure I understand what you mean here. The point was to use > gnutls_certificate_set_x509_key_file2 instead of > gnutls_certificate_set_x509_key_file in gnutls.c -- so that should be an > internal change in gnutls.c that nothing else should need to know about. Ah yes, thanks for setting me straight. I should start with that. Actually, this is not too complicated, and I just prepared this patch save for one thing: how should the ORed values be passed in the last parameter? In C, it is an 'unsigned int' of ORed values of type 'gnutls_pkcs_encrypt_flags_t', whose enumeration constants are detailed here, See the patch attached (do not merge yet?). --000000000000fc7e1305e996646d Content-Type: application/pgp-signature; name="0001-fix-gnutls-add-possibility-of-password-for-key-file.patch.sig" Content-Disposition: attachment; filename="0001-fix-gnutls-add-possibility-of-password-for-key-file.patch.sig" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8ixvsee1 LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQpIYXNoOiBTSEE1MTIKCi0gRnJvbSA5 NGVlYzQzODQzZDVkMDIyNWEyOWQzNTc0Zjg3Mzg3MTlmOWU0MjM5IE1vbiBTZXAgMTcgMDA6MDA6 MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMxNEBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVjdDogW1BB VENIXSBmaXgoZ251dGxzKTogYWRkIHBvc3NpYmlsaXR5IG9mIHBhc3N3b3JkIGZvciBrZXktZmls ZQoKVGhlIEdudVRMUyBmdW5jdGlvbgoKICAgIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9r ZXlfZmlsZQoKaXMgcmVwbGFjZWQgYnkgaXRzIHNlY29uZCB2ZXJzaW9uCgogICAgZ251dGxzX2Nl cnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgoKYW5kIHRoZSBkZWZpbml0aW9ucyBvZiBnbnV0 bHMtYm9vdCBhbmQgZ251dGxzLWJvb3QtcGFyYW1ldGVycyBhcmUKbW9kaWZpZWQgdG8gaW5jbHVk ZSB0aGUgOnBhc3MgYW5kIDpmbGFncyBrZXlzLCB3aGljaCBhcmUgYWRkaXRpb25hbApwYXJhbWV0 ZXJzIGluIHRoZSBzZWNvbmQgdmVyc2lvbi4KClNpZ25lZC1vZmYtYnk6IE5pa29sYW9zIENoYXR6 aWtvbnN0YW50aW5vdSA8bmNoYXR6MzE0QGdtYWlsLmNvbT4KLSAtLS0KIGxpc3AvbmV0L2dudXRs cy5lbCB8ICA3ICsrKysrKysKIHNyYy9nbnV0bHMuYyAgICAgICB8IDE5ICsrKysrKysrKysrKysr KysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9saXNwL25ldC9nbnV0bHMuZWwgYi9saXNwL25ldC9nbnV0bHMuZWwKaW5k ZXggNmUzODQ1YWVjMS4uOWFhYjE4YjhmYiAxMDA2NDQKLSAtLS0gYS9saXNwL25ldC9nbnV0bHMu ZWwKKysrIGIvbGlzcC9uZXQvZ251dGxzLmVsCkBAIC0yNjUsNiArMjY1LDcgQEAgZ251dGxzLWJv b3QtcGFyYW1ldGVycwogICAgICAgICAgICAma2V5IHR5cGUgaG9zdG5hbWUgcHJpb3JpdHktc3Ry aW5nCiAgICAgICAgICAgIHRydXN0ZmlsZXMgY3JsZmlsZXMga2V5bGlzdCBtaW4tcHJpbWUtYml0 cwogICAgICAgICAgICB2ZXJpZnktZmxhZ3MgdmVyaWZ5LWVycm9yIHZlcmlmeS1ob3N0bmFtZS1l cnJvcgorICAgICAgICAgICBwYXNzIGZsYWdzCiAgICAgICAgICAgICZhbGxvdy1vdGhlci1rZXlz KQogICAiUmV0dXJuIGEga2V5d29yZCBsaXN0IG9mIHBhcmFtZXRlcnMgc3VpdGFibGUgZm9yIHBh c3NpbmcgdG8gYGdudXRscy1ib290Jy4KIApAQCAtMjgxLDYgKzI4MiwxMCBAQCBnbnV0bHMtYm9v dC1wYXJhbWV0ZXJzCiBWRVJJRlktSE9TVE5BTUUtRVJST1IgaXMgYSBiYWNrd2FyZHMgY29tcGF0 aWJpbGl0eSBvcHRpb24gZm9yCiBwdXR0aW5nIGA6aG9zdG5hbWUnIGluIFZFUklGWS1FUlJPUi4K IAorUEFTUyBpcyBhIHN0cmluZywgdGhlIHBhc3N3b3JkIG9mIHRoZSBrZXkuCisKK0ZMQUdTIGlz IGFuIE9SZWQgc2VxdWVuY2Ugb2YgZ251dGxzX3BrY3NfZW5jcnlwdF9mbGFnc190IHZhbHVlcy4K KwogV2hlbiBWRVJJRlktRVJST1IgaXMgdCBvciBhIGxpc3QgY29udGFpbmluZyBgOnRydXN0Zmls ZXMnLCBhbgogZXJyb3Igd2lsbCBiZSByYWlzZWQgd2hlbiB0aGUgcGVlciBjZXJ0aWZpY2F0ZSB2 ZXJpZmljYXRpb24gZmFpbHMKIGFzIHBlciBHbnVUTFMnIGdudXRsc19jZXJ0aWZpY2F0ZV92ZXJp ZnlfcGVlcnMyLiAgT3RoZXJ3aXNlLCBvbmx5CkBAIC0zNTgsNiArMzYzLDggQEAgZ251dGxzLWJv b3QtcGFyYW1ldGVycwogICAgICAgICAgICAgICAgIDprZXlsaXN0ICxrZXlsaXN0CiAgICAgICAg ICAgICAgICAgOnZlcmlmeS1mbGFncyAsdmVyaWZ5LWZsYWdzCiAgICAgICAgICAgICAgICAgOnZl cmlmeS1lcnJvciAsdmVyaWZ5LWVycm9yCisgICAgICAgICAgICAgICAgOnBhc3MgLHBhc3MKKyAg ICAgICAgICAgICAgICA6ZmxhZ3MgLGZsYWdzCiAgICAgICAgICAgICAgICAgOmNhbGxiYWNrcyBu aWwpKSkKIAogKGRlZnVuIGdudXRscy0tZ2V0LWZpbGVzIChmaWxlcykKZGlmZiAtLWdpdCBhL3Ny Yy9nbnV0bHMuYyBiL3NyYy9nbnV0bHMuYwppbmRleCBhMGRlMDIzOGM0Li5jNDU3NzFjNThkIDEw MDY0NAotIC0tLSBhL3NyYy9nbnV0bHMuYworKysgYi9zcmMvZ251dGxzLmMKQEAgLTEyMSw2ICsx MjEsOSBAQCBERUZfRExMX0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxf ZmlsZSwKIERFRl9ETExfRk4gKGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9m aWxlLAogCSAgICAoZ251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIg KiwgY29uc3QgY2hhciAqLAogCSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CitERUZfRExM X0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIsCisJICAgIChn bnV0bHNfY2VydGlmaWNhdGVfY3JlZGVudGlhbHNfdCwgY29uc3QgY2hhciAqLCBjb25zdCBjaGFy ICosCisJICAgICBnbnV0bHNfeDUwOV9jcnRfZm10X3QsIGNvbnN0IGNoYXIgKiwgdW5zaWduZWQg aW50KSk7CiAjICBpZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9G TiAoaW50LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAo Z251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMTcsNyBAQCBp bml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5 LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAo bGlicmFyeSwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyAgTE9BRF9E TExfRk4gKGxpYnJhcnksIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIpOwog IyAgaWZkZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxp YnJhcnksIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5k aWYKQEAgLTQ1NSw2ICs0NTksNyBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBk ZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRp ZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0 X3g1MDlfY3JsX2ZpbGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAj ICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19j ZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV9rZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9m aWxlMgogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3Qg Zm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X3N5c3RlbV90cnVzdAogIyAgZGVmaW5lIGdu dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV90cnVzdF9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV90cnVzdF9maWxlCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3R5cGVf Z2V0IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV90eXBlX2dldApAQCAtMTgxMyw2ICsxODE4LDEwIEBA IERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywg MCwKIDpjb21wbGV0ZS1uZWdvdGlhdGlvbiwgaWYgbm9uLW5pbCwgd2lsbCBtYWtlIG5lZ290aWF0 aW9uIGNvbXBsZXRlCiBiZWZvcmUgcmV0dXJuaW5nIGV2ZW4gb24gbm9uLWJsb2NraW5nIHNvY2tl dHMuCiAKKzpwYXNzLCB0aGUgcGFzc3dvcmQgb2YgdGhlIHByaXZhdGUga2V5LgorCis6ZmxhZ3Ms IGFuIE9SZWQgc2VxdWVuY2Ugb2YgZ251dGxzX3BrY3NfZW5jcnlwdF9mbGFnc190LgorCiBUaGUg ZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRoaXMgcHJvY2VzcyBBTkQgZ2xvYmFsbHkgZm9y IEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGlnaGVyIG9yIGxvd2VyIGF0IGFueSBwb2ludCwg aXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4KQEAgLTE4NDgsNiArMTg1Nyw4IEBAIERFRlVO ICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAg TGlzcF9PYmplY3QgdHJ1c3RmaWxlczsKICAgTGlzcF9PYmplY3QgY3JsZmlsZXM7CiAgIExpc3Bf T2JqZWN0IGtleWxpc3Q7CisgIExpc3BfT2JqZWN0IHBhc3M7CisgIExpc3BfT2JqZWN0IGZsYWdz OwogICAvKiBMaXNwX09iamVjdCBjYWxsYmFja3M7ICovCiAgIExpc3BfT2JqZWN0IGxvZ2xldmVs OwogICBMaXNwX09iamVjdCBob3N0bmFtZTsKQEAgLTE4NzcsNiArMTg4OCw4IEBAIERFRlVOICgi Z251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAgY3Js ZmlsZXMgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNjcmxmaWxlcyk7CiAg IGxvZ2xldmVsICAgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDbG9nbGV2ZWwp OwogICBwcmltZV9iaXRzICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ21pbl9w cmltZV9iaXRzKTsKKyAgcGFzcyAgICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlz dCwgUUNwYXNzKTsKKyAgZmxhZ3MgICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlz dCwgUUNmbGFncyk7CiAKICAgaWYgKCFTVFJJTkdQIChob3N0bmFtZSkpCiAgICAgewpAQCAtMjAz OCw4ICsyMDUxLDggQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRs c19ib290LCAzLCAzLCAwLAogCSAgICAgIGtleWZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAo a2V5ZmlsZSk7CiAJICAgICAgY2VydGZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoY2VydGZp bGUpOwogIyBlbmRpZgotIC0JICAgICAgcmV0ID0gZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5 X2tleV9maWxlCi0gLQkJKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5 ZmlsZSksIGZpbGVfZm9ybWF0KTsKKwkgICAgICByZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0 X3g1MDlfa2V5X2ZpbGUyCisJCSh4NTA5X2NyZWQsIFNTREFUQSAoY2VydGZpbGUpLCBTU0RBVEEg KGtleWZpbGUpLCBmaWxlX2Zvcm1hdCwgU1NEQVRBIChwYXNzKSwgWFVGSVhOVU0gKGZsYWdzKSk7 CiAKIAkgICAgICBpZiAocmV0IDwgR05VVExTX0VfU1VDQ0VTUykKIAkJcmV0dXJuIGdudXRsc19t YWtlX2Vycm9yIChyZXQpOwpAQCAtMjg2MCw2ICsyODczLDggQEAgc3ltc19vZl9nbnV0bHMgKHZv aWQpCiAgIERFRlNZTSAoUUNtaW5fcHJpbWVfYml0cywgIjptaW4tcHJpbWUtYml0cyIpOwogICBE RUZTWU0gKFFDbG9nbGV2ZWwsICI6bG9nbGV2ZWwiKTsKICAgREVGU1lNIChRQ2NvbXBsZXRlX25l Z290aWF0aW9uLCAiOmNvbXBsZXRlLW5lZ290aWF0aW9uIik7CisgIERFRlNZTSAoUUNwYXNzLCAi OnBhc3MiKTsKKyAgREVGU1lNIChRQ2ZsYWdzLCAiOmZsYWdzIik7CiAgIERFRlNZTSAoUUN2ZXJp ZnlfZmxhZ3MsICI6dmVyaWZ5LWZsYWdzIik7CiAgIERFRlNZTSAoUUN2ZXJpZnlfZXJyb3IsICI6 dmVyaWZ5LWVycm9yIik7CiAKLSAtLSAKMi4zNy4zCgotLS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUt LS0tLQoKaVFJekJBRUJDZ0FkRmlFRUhISFVDWUtOZFdsNWg4NDVEdE5SNnpjZVpFZ0ZBbU14eUY0 QUNna1FEdE5SNnpjZQpaRWhlYWhBQWx0WWpOeGNJWVVqQjlxdlhQVjQ1akE3eVdmR29nSHlhbThu WUUvTUZzWVNmOGUvOHBad1BPdXdLClh5QXcwM3J4eWdCbEdYWFpOQVVxVWJhOHd0VWV4TGNsV3k5 eW9nczV3NXI4c2tqTkpSYTRVYkxZWTBZVjhiL1IKbVR1a2J3cjh5WG9GbVF4d2p5UWl3VXJWZEZM UEJBM1MzalcxQ0xYUGRsZUI2Vjl6VEpMYXNRQ1pzc2g2TGVONQpuMzJRQ1BJamgwcGRkZWo5OHly R3ZhZTFxVHZwYzFYYklFRmtYY3pCUTNEaUZzK1hpbk5rZnRKUytGSG9FdWlUClVQWDdIWk1xN1lw RlFZa3M1ZWZyelpDWU8wMlhDWmJDcnNZN0tKamhJUVRiK0JiNDBBL3M0dmtHOW5obUN5QjAKMjFW L2FOWVErcVpROFh2VVF2bmFsNFcrRWdiRzh3VXh1R3E0OHp6NTJFazJwWS9leFIyMDhOUm5TRGc4 TE1lSgpScVhDRjd4SExoVkIva09tYmJHc1RUZTQ1d2p3cnNhMkN0NU1xR25FVHhYUkxZMVVhZnAv cHRBa1lrK29OMll6CjdTR3dya0hHTitjc283ZWpWUjhibWNEcmw3U1U1Smx6MXA5cnFpdlhaL0RN T1hrRCthR0hkWlliOUE4a0xmakcKVHBIeGpkVDRhNlFDZG5lOGJSRGkrUWltajFXK1hmcHdja01C ZWtyK3RaWFdCVS8yK0pNamlkcjV1UzdFNGlHTQo1MzNDSjJMR250L0RacjNXdXM3WDdSaUpSY3NZ Y29nN0s0Ui9OT3FndUl0ekpLYVBBUXQ5dU1rbjl2OEdwS0txCmw5MlRxaHlvTUdKV1grNWtuN0ly YzFmNnI0NGFuUmQrTHVjcHZxQVQraEUrbzEzRVc4VT0KPWl5TVAKLS0tLS1FTkQgUEdQIFNJR05B VFVSRS0tLS0tCg== --000000000000fc7e1305e996646d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-fix-gnutls-add-possibility-of-password-for-key-file.patch" Content-Disposition: attachment; filename="0001-fix-gnutls-add-possibility-of-password-for-key-file.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8ixvsdj0 RnJvbSA5NGVlYzQzODQzZDVkMDIyNWEyOWQzNTc0Zjg3Mzg3MTlmOWU0MjM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBmaXgoZ251dGxzKTogYWRkIHBvc3NpYmlsaXR5IG9mIHBhc3N3b3JkIGZvciBr ZXktZmlsZQoKVGhlIEdudVRMUyBmdW5jdGlvbgoKICAgIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRf eDUwOV9rZXlfZmlsZQoKaXMgcmVwbGFjZWQgYnkgaXRzIHNlY29uZCB2ZXJzaW9uCgogICAgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgoKYW5kIHRoZSBkZWZpbml0aW9ucyBv ZiBnbnV0bHMtYm9vdCBhbmQgZ251dGxzLWJvb3QtcGFyYW1ldGVycyBhcmUKbW9kaWZpZWQgdG8g aW5jbHVkZSB0aGUgOnBhc3MgYW5kIDpmbGFncyBrZXlzLCB3aGljaCBhcmUgYWRkaXRpb25hbApw YXJhbWV0ZXJzIGluIHRoZSBzZWNvbmQgdmVyc2lvbi4KClNpZ25lZC1vZmYtYnk6IE5pa29sYW9z IENoYXR6aWtvbnN0YW50aW5vdSA8bmNoYXR6MzE0QGdtYWlsLmNvbT4KLS0tCiBsaXNwL25ldC9n bnV0bHMuZWwgfCAgNyArKysrKysrCiBzcmMvZ251dGxzLmMgICAgICAgfCAxOSArKysrKysrKysr KysrKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9uZXQvZ251dGxzLmVsIGIvbGlzcC9uZXQvZ251dGxzLmVs CmluZGV4IDZlMzg0NWFlYzEuLjlhYWIxOGI4ZmIgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2dudXRs cy5lbAorKysgYi9saXNwL25ldC9nbnV0bHMuZWwKQEAgLTI2NSw2ICsyNjUsNyBAQCBnbnV0bHMt Ym9vdC1wYXJhbWV0ZXJzCiAgICAgICAgICAgICZrZXkgdHlwZSBob3N0bmFtZSBwcmlvcml0eS1z dHJpbmcKICAgICAgICAgICAgdHJ1c3RmaWxlcyBjcmxmaWxlcyBrZXlsaXN0IG1pbi1wcmltZS1i aXRzCiAgICAgICAgICAgIHZlcmlmeS1mbGFncyB2ZXJpZnktZXJyb3IgdmVyaWZ5LWhvc3RuYW1l LWVycm9yCisgICAgICAgICAgIHBhc3MgZmxhZ3MKICAgICAgICAgICAgJmFsbG93LW90aGVyLWtl eXMpCiAgICJSZXR1cm4gYSBrZXl3b3JkIGxpc3Qgb2YgcGFyYW1ldGVycyBzdWl0YWJsZSBmb3Ig cGFzc2luZyB0byBgZ251dGxzLWJvb3QnLgogCkBAIC0yODEsNiArMjgyLDEwIEBAIGdudXRscy1i b290LXBhcmFtZXRlcnMKIFZFUklGWS1IT1NUTkFNRS1FUlJPUiBpcyBhIGJhY2t3YXJkcyBjb21w YXRpYmlsaXR5IG9wdGlvbiBmb3IKIHB1dHRpbmcgYDpob3N0bmFtZScgaW4gVkVSSUZZLUVSUk9S LgogCitQQVNTIGlzIGEgc3RyaW5nLCB0aGUgcGFzc3dvcmQgb2YgdGhlIGtleS4KKworRkxBR1Mg aXMgYW4gT1JlZCBzZXF1ZW5jZSBvZiBnbnV0bHNfcGtjc19lbmNyeXB0X2ZsYWdzX3QgdmFsdWVz LgorCiBXaGVuIFZFUklGWS1FUlJPUiBpcyB0IG9yIGEgbGlzdCBjb250YWluaW5nIGA6dHJ1c3Rm aWxlcycsIGFuCiBlcnJvciB3aWxsIGJlIHJhaXNlZCB3aGVuIHRoZSBwZWVyIGNlcnRpZmljYXRl IHZlcmlmaWNhdGlvbiBmYWlscwogYXMgcGVyIEdudVRMUycgZ251dGxzX2NlcnRpZmljYXRlX3Zl cmlmeV9wZWVyczIuICBPdGhlcndpc2UsIG9ubHkKQEAgLTM1OCw2ICszNjMsOCBAQCBnbnV0bHMt Ym9vdC1wYXJhbWV0ZXJzCiAgICAgICAgICAgICAgICAgOmtleWxpc3QgLGtleWxpc3QKICAgICAg ICAgICAgICAgICA6dmVyaWZ5LWZsYWdzICx2ZXJpZnktZmxhZ3MKICAgICAgICAgICAgICAgICA6 dmVyaWZ5LWVycm9yICx2ZXJpZnktZXJyb3IKKyAgICAgICAgICAgICAgICA6cGFzcyAscGFzcwor ICAgICAgICAgICAgICAgIDpmbGFncyAsZmxhZ3MKICAgICAgICAgICAgICAgICA6Y2FsbGJhY2tz IG5pbCkpKQogCiAoZGVmdW4gZ251dGxzLS1nZXQtZmlsZXMgKGZpbGVzKQpkaWZmIC0tZ2l0IGEv c3JjL2dudXRscy5jIGIvc3JjL2dudXRscy5jCmluZGV4IGEwZGUwMjM4YzQuLmM0NTc3MWM1OGQg MTAwNjQ0Ci0tLSBhL3NyYy9nbnV0bHMuYworKysgYi9zcmMvZ251dGxzLmMKQEAgLTEyMSw2ICsx MjEsOSBAQCBERUZfRExMX0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxf ZmlsZSwKIERFRl9ETExfRk4gKGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9m aWxlLAogCSAgICAoZ251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIg KiwgY29uc3QgY2hhciAqLAogCSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CitERUZfRExM X0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIsCisJICAgIChn bnV0bHNfY2VydGlmaWNhdGVfY3JlZGVudGlhbHNfdCwgY29uc3QgY2hhciAqLCBjb25zdCBjaGFy ICosCisJICAgICBnbnV0bHNfeDUwOV9jcnRfZm10X3QsIGNvbnN0IGNoYXIgKiwgdW5zaWduZWQg aW50KSk7CiAjICBpZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9G TiAoaW50LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAo Z251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMTcsNyBAQCBp bml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5 LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAo bGlicmFyeSwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyAgTE9BRF9E TExfRk4gKGxpYnJhcnksIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIpOwog IyAgaWZkZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxp YnJhcnksIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5k aWYKQEAgLTQ1NSw2ICs0NTksNyBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBk ZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRp ZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0 X3g1MDlfY3JsX2ZpbGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAj ICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19j ZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV9rZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9m aWxlMgogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3Qg Zm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X3N5c3RlbV90cnVzdAogIyAgZGVmaW5lIGdu dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV90cnVzdF9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV90cnVzdF9maWxlCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3R5cGVf Z2V0IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV90eXBlX2dldApAQCAtMTgxMyw2ICsxODE4LDEwIEBA IERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywg MCwKIDpjb21wbGV0ZS1uZWdvdGlhdGlvbiwgaWYgbm9uLW5pbCwgd2lsbCBtYWtlIG5lZ290aWF0 aW9uIGNvbXBsZXRlCiBiZWZvcmUgcmV0dXJuaW5nIGV2ZW4gb24gbm9uLWJsb2NraW5nIHNvY2tl dHMuCiAKKzpwYXNzLCB0aGUgcGFzc3dvcmQgb2YgdGhlIHByaXZhdGUga2V5LgorCis6ZmxhZ3Ms IGFuIE9SZWQgc2VxdWVuY2Ugb2YgZ251dGxzX3BrY3NfZW5jcnlwdF9mbGFnc190LgorCiBUaGUg ZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRoaXMgcHJvY2VzcyBBTkQgZ2xvYmFsbHkgZm9y IEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGlnaGVyIG9yIGxvd2VyIGF0IGFueSBwb2ludCwg aXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4KQEAgLTE4NDgsNiArMTg1Nyw4IEBAIERFRlVO ICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAg TGlzcF9PYmplY3QgdHJ1c3RmaWxlczsKICAgTGlzcF9PYmplY3QgY3JsZmlsZXM7CiAgIExpc3Bf T2JqZWN0IGtleWxpc3Q7CisgIExpc3BfT2JqZWN0IHBhc3M7CisgIExpc3BfT2JqZWN0IGZsYWdz OwogICAvKiBMaXNwX09iamVjdCBjYWxsYmFja3M7ICovCiAgIExpc3BfT2JqZWN0IGxvZ2xldmVs OwogICBMaXNwX09iamVjdCBob3N0bmFtZTsKQEAgLTE4NzcsNiArMTg4OCw4IEBAIERFRlVOICgi Z251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAgY3Js ZmlsZXMgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNjcmxmaWxlcyk7CiAg IGxvZ2xldmVsICAgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDbG9nbGV2ZWwp OwogICBwcmltZV9iaXRzICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ21pbl9w cmltZV9iaXRzKTsKKyAgcGFzcyAgICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlz dCwgUUNwYXNzKTsKKyAgZmxhZ3MgICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlz dCwgUUNmbGFncyk7CiAKICAgaWYgKCFTVFJJTkdQIChob3N0bmFtZSkpCiAgICAgewpAQCAtMjAz OCw4ICsyMDUxLDggQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRs c19ib290LCAzLCAzLCAwLAogCSAgICAgIGtleWZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAo a2V5ZmlsZSk7CiAJICAgICAgY2VydGZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoY2VydGZp bGUpOwogIyBlbmRpZgotCSAgICAgIHJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9r ZXlfZmlsZQotCQkoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChrZXlmaWxl KSwgZmlsZV9mb3JtYXQpOworCSAgICAgIHJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUw OV9rZXlfZmlsZTIKKwkJKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5 ZmlsZSksIGZpbGVfZm9ybWF0LCBTU0RBVEEgKHBhc3MpLCBYVUZJWE5VTSAoZmxhZ3MpKTsKIAog CSAgICAgIGlmIChyZXQgPCBHTlVUTFNfRV9TVUNDRVNTKQogCQlyZXR1cm4gZ251dGxzX21ha2Vf ZXJyb3IgKHJldCk7CkBAIC0yODYwLDYgKzI4NzMsOCBAQCBzeW1zX29mX2dudXRscyAodm9pZCkK ICAgREVGU1lNIChRQ21pbl9wcmltZV9iaXRzLCAiOm1pbi1wcmltZS1iaXRzIik7CiAgIERFRlNZ TSAoUUNsb2dsZXZlbCwgIjpsb2dsZXZlbCIpOwogICBERUZTWU0gKFFDY29tcGxldGVfbmVnb3Rp YXRpb24sICI6Y29tcGxldGUtbmVnb3RpYXRpb24iKTsKKyAgREVGU1lNIChRQ3Bhc3MsICI6cGFz cyIpOworICBERUZTWU0gKFFDZmxhZ3MsICI6ZmxhZ3MiKTsKICAgREVGU1lNIChRQ3ZlcmlmeV9m bGFncywgIjp2ZXJpZnktZmxhZ3MiKTsKICAgREVGU1lNIChRQ3ZlcmlmeV9lcnJvciwgIjp2ZXJp ZnktZXJyb3IiKTsKIAotLSAKMi4zNy4zCgo= --000000000000fc7e1305e996646d-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 13:20:02 2022 Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 17:20:02 +0000 Received: from localhost ([127.0.0.1]:51687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocrlx-00025K-IY for submit@debbugs.gnu.org; Mon, 26 Sep 2022 13:20:02 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:42790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocrlv-000252-M8 for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 13:20:00 -0400 Received: by mail-wr1-f50.google.com with SMTP id n12so11260066wrx.9 for <50507@debbugs.gnu.org>; Mon, 26 Sep 2022 10:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=1nIDh3ihvt+AztMuNrVcPc4FIMwuvwbGnGhItUvxEJs=; b=fflewszTDWsc6ltoCbktF8TjZhZU4vfFoj8FUBaIgOGHLh9+mg0GBxbyjR9Ir/TwM7 qwdjicCOZxF1nF8uROx3EhPthR/S973KXgi1sszauOJQnlytC0wNhIyKFccN1riTccgd GRpSJiON2GJXcNvlfzEMCcBt4nZ8ue/Cesb2XaumooIVarzHIhmEd2jg04MKu6SWL1ky nmti5jJAD96tAlcWbz+/Q4IBDBkqb+F4/Vop7Z3+b0eg3ikJrpijNVnH6X05i1PBXCzE 8SyS8RUNj37yViDQIqTq7TRF6wVC8uc6thRHcIhpFy3f8B05qi76+v01gxSClVjAN0Sw UW9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=1nIDh3ihvt+AztMuNrVcPc4FIMwuvwbGnGhItUvxEJs=; b=ORhyPQnNLhmbd4EaUWRiFkVHes6wg3SCXWu71Q+WL8csTzrwVKFteJkqjy569w6Q4T wzKToB42KKdLG7z93CBvON0XYi4bDr1A1dM/sSPCccNE2zlf2Ns4jw+24u8gb+Hedbau mxjCfc9fOjVgjUv2yMj2R/jQy73Ag5QVvcOu5yiA3K/xl7CQYxxpV8i4f7nl405SbTgE McHdifyf0HnMeiYUrjBoZET7l2+g5SY0gheq6GQlibA1WpYkLlrgt7L0yTS31i+Mt+RJ xHqHbgespJCC1stcmWVPMzk2IjqqFDEaGHrsmvXruuURCZQ/goz6y6TaH9aQG2/5a9yk 9f2g== X-Gm-Message-State: ACrzQf16JDw1H/7NursvPGOvRvKAPOkPv9VqHrC/3Hcq4VnUfqU3AR0S agekDQFW0KmdlC+gkik8X0Y= X-Google-Smtp-Source: AMsMyM6xLK/xnjA+pNS3awH5zVhPHAeEm1YJdwbcj7MLIZqfQP52gn63qkukSRyU6wIbL6cKgMSreg== X-Received: by 2002:a5d:6485:0:b0:226:ecf9:359c with SMTP id o5-20020a5d6485000000b00226ecf9359cmr14830125wri.17.1664212793523; Mon, 26 Sep 2022 10:19:53 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:2e48:1c6b:2114:6f3b]) by smtp.gmail.com with ESMTPSA id e6-20020adff346000000b0022a53fe201fsm6991576wrp.68.2022.09.26.10.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 10:19:52 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Mon, 26 Sep 2022 11:43:41 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> Date: Mon, 26 Sep 2022 19:19:50 +0200 Message-ID: <878rm69hop.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 26 Sep 2022 11:43:41 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> Date: Mon, 26 Sep 2022 11:08:18 -0400 Nikolaos> Subject: [PATCH] fix(gnutls): add possibility of password for= key-file Nikolaos> The GnuTLS function Nikolaos> gnutls_certificate_set_x509_key_file Nikolaos> is replaced by its second version Nikolaos> gnutls_certificate_set_x509_key_file2 Nikolaos> and the definitions of gnutls-boot and gnutls-boot-parameters= are Nikolaos> modified to include the :pass and :flags keys, which are addi= tional Nikolaos> parameters in the second version. Nikolaos> Signed-off-by: Nikolaos Chatzikonstantinou Nikolaos> We don=CA=BCt use Signed-off-by, and the commit message has some rules which are described in CONTRIBUTE (start at "** Commit messages" and read up to and including "** Committing your changes") Nikolaos> +PASS is a string, the password of the key. Nikolaos> + Nikolaos> +FLAGS is an ORed sequence of gnutls_pkcs_encrypt_flags_t val= ues. Nikolaos> + You=CA=BCre at the lisp level here. Perhaps you could define a mapping from the C-level enum to lisp defconsts or similar? Or you could define it as taking a list of flags, and then the C-code can take care of ORing them. Nikolaos> + pass =3D plist_get (proplist, QCpass); Nikolaos> + flags =3D plist_get (proplist, QCflags); pass and flags will both be 'nil' here if they=CA=BCre not specified, so that.... Nikolaos> if (!STRINGP (hostname)) Nikolaos> { Nikolaos> @@ -2038,8 +2051,8 @@ DEFUN ("gnutls-boot", Fgnutls_boot, Sgn= utls_boot, 3, 3, 0, Nikolaos> keyfile =3D ansi_encode_filename (keyfile); Nikolaos> certfile =3D ansi_encode_filename (certfile); Nikolaos> # endif Nikolaos> - ret =3D gnutls_certificate_set_x509_key_file Nikolaos> - (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_form= at); Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_form= at, SSDATA (pass), XUFIXNUM (flags)); ...this is likely to fail in that case. Or maybe not, I haven=CA=BCt tested it, but XUFIXNUM(nil) in a build with asserts enabled will trigger an assert and exit, I think. In any case, if you=CA=BCre going to replace _file with _file2, you should describe the new constraints on the arguments. e.g. Maybe having pass as nil is OK, but then you need to say that, or maybe you need to fall back to _file if :pass is not specified. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 17:39:36 2022 Received: (at 50507) by debbugs.gnu.org; 26 Sep 2022 21:39:36 +0000 Received: from localhost ([127.0.0.1]:51964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocvp4-0002QJ-2t for submit@debbugs.gnu.org; Mon, 26 Sep 2022 17:39:36 -0400 Received: from mail-yw1-f179.google.com ([209.85.128.179]:35740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocvp0-0002Q6-Rb for 50507@debbugs.gnu.org; Mon, 26 Sep 2022 17:39:27 -0400 Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-3511e80f908so19452827b3.2 for <50507@debbugs.gnu.org>; Mon, 26 Sep 2022 14:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=5iRqShQAY6F+jyRBs/p0/rKAwH2iV+wmY4rC8kSfsGA=; b=O+GnsNM/b3hO3Av+0+rZ+Kez9z8MuQ4VX9CdSR+N7894T44JLdA8iBLD0SEMjxShVp F2skvUK+hDwmtQNAsGLlowGwlCaRAlQEqvCKKBeA0TawuEuZLaoo9waUwg+d4KB5LgPk ay8E2E//XqorEQd3OSbjgby9TjfWR8PCNicO5ifVYB7ozOUD5XBelmrL9A4K3IJvYHBT /Qy0tOdMpExu1hvW/VUh9sg/qtdc/YnSl0kKCN9lJQ4vGMVbVfKBX4dndiPGehjlczxn rllZ149nIjac+vEkgQBah6cYJluHfh3n/ZZn117HvnRrCgdR2fk+lf7CRC8a2NGAOFMz W8lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=5iRqShQAY6F+jyRBs/p0/rKAwH2iV+wmY4rC8kSfsGA=; b=TXatkonrsL0poCOTF+zz0VGOoYeWLdciyHCI4DP3P6v2hve9c6hWMqCXCmRp7SWHXC dAYEptEFmfOt/uDQ8cWdkAna6hRHYI+Pfvp9X6ro11dOws7Jc3u9Dr1DeZcvTQHPm+Kv +yfXpi51pnNVVnxm7JZ7tDdfeUMGZtM3sMHwrxYbBwfPg6giGKjvEqsuRyWcxYEov0/l 3o+KLH4/F0/L7X7Cvi507kQDlaPn1vK/AgO4pU/qNXCcLyfrqi97IqJeXNEklj1blGBS Fv6gpZ9t0A+1dvqeLYS05FV5fBzrwOKA9PhLz6+Yp9zFDvH2lxbZoOjcaK9I8QoyMy1J UWrQ== X-Gm-Message-State: ACrzQf3yLoTmbrl0jgjbl6Nm/YlKDv5d5kanl3QO+0OBtvYxBhFmZPEI DJgZTWvdqYU72wp5Nem+9DQ7hYkWsfDcUPYIcMs= X-Google-Smtp-Source: AMsMyM7nQQ+yrtVoAP7Dk9FzvfQw4/O8wYKbZjLx4rWrcuxYevy8s1dKIj7akzTx/vL2ltIov4HF74zOoKobVsfUyGw= X-Received: by 2002:a0d:e6cf:0:b0:349:ef2b:1940 with SMTP id p198-20020a0de6cf000000b00349ef2b1940mr22248896ywe.331.1664228360377; Mon, 26 Sep 2022 14:39:20 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> In-Reply-To: <878rm69hop.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Mon, 26 Sep 2022 17:39:09 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Mon, Sep 26, 2022 at 1:19 PM Robert Pluim wrote: > > >>>>> On Mon, 26 Sep 2022 11:43:41 -0400, Nikolaos Chatzikonstantinou said: > Nikolaos> Date: Mon, 26 Sep 2022 11:08:18 -0400 > Nikolaos> Subject: [PATCH] fix(gnutls): add possibility of password f= or key-file > > Nikolaos> The GnuTLS function > > Nikolaos> gnutls_certificate_set_x509_key_file > > Nikolaos> is replaced by its second version > > Nikolaos> gnutls_certificate_set_x509_key_file2 > > Nikolaos> and the definitions of gnutls-boot and gnutls-boot-paramete= rs are > Nikolaos> modified to include the :pass and :flags keys, which are ad= ditional > Nikolaos> parameters in the second version. > > Nikolaos> +PASS is a string, the password of the key. > Nikolaos> + > Nikolaos> +FLAGS is an ORed sequence of gnutls_pkcs_encrypt_flags_t v= alues. > Nikolaos> + > > You=CA=BCre at the lisp level here. Perhaps you could define a mapping fr= om > the C-level enum to lisp defconsts or similar? Or you could define it > as taking a list of flags, and then the C-code can take care of ORing > them. Does Emacs code have a way to signal this C-to-lisp enum-to-defconst map? Otherwise I will go with the keywords option. > Nikolaos> + pass =3D plist_get (proplist, QCpass); > Nikolaos> + flags =3D plist_get (proplist, QCflags); > > pass and flags will both be 'nil' here if they=CA=BCre not specified, so > that.... > > > > ...this is likely to fail in that case. Or maybe not, I haven=CA=BCt test= ed > it, but XUFIXNUM(nil) in a build with asserts enabled will trigger an > assert and exit, I think. Thanks, I will look into this. > In any case, if you=CA=BCre going to replace _file with _file2, you shoul= d > describe the new constraints on the arguments. e.g. Maybe having pass > as nil is OK, but then you need to say that, or maybe you need to fall > back to _file if :pass is not specified. Okay, will do. The first version of the function exists since 0.4.0 but the second appeared "recently" in 3.2.0 (released on June 2013). Should I put some preprocessor #if checks? How would the docstring be affected? Instead of duplicating the string (can't put #if inside its body, it's already in a macro), perhaps I should write that the feature is "only supported with GnuTLS 3.2.0 and above") From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 02:29:41 2022 Received: (at 50507) by debbugs.gnu.org; 27 Sep 2022 06:29:42 +0000 Received: from localhost ([127.0.0.1]:52266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od469-0007ZC-GU for submit@debbugs.gnu.org; Tue, 27 Sep 2022 02:29:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od467-0007Z0-TV for 50507@debbugs.gnu.org; Tue, 27 Sep 2022 02:29:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54582) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od462-0000vh-J6; Tue, 27 Sep 2022 02:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7gIQ1ZlhWkWLcfNvhvv8dSjX+h7syve42KiBUFCQUZs=; b=moZ6dM7fh+gUxb8S9Oqy k5BdegFrI0CYOZmUjSNemT38dbXCYEcIznWz6yxBXOBlKYQH8gEGACtJ9z38Rm4k8fE1B0ThUWvN0 UpmdplcBb0veJ/A/QpewQ7W+rE83KefYsOLHxpWCGsSK4LoHflQP5buSH7T1f0B9ikvNUbTc+5UHU zS1AJioxfQ18d4tojfuN90YQKxwpz7u2/TiQSuf0gTphuL/H+MBjd0QUU2i1IgM2fN/d1hACV5HEJ XBP2a+y3c6AdW2xiGIPizXTYeVnjXZHjfCOr/CGtxRfSvooBwHr/EiKBeBtm1ycPlBJoG4uPJcXEw GJSlnn7EHRWlqQ==; Received: from [87.69.77.57] (port=1642 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1od461-0006Fq-VC; Tue, 27 Sep 2022 02:29:34 -0400 Date: Tue, 27 Sep 2022 09:29:27 +0300 Message-Id: <83pmfhjpo8.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Mon, 26 Sep 2022 17:39:09 -0400) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Mon, 26 Sep 2022 17:39:09 -0400 > Cc: Lars Ingebrigtsen , 50507@debbugs.gnu.org, Eli Zaretskii > > > In any case, if youʼre going to replace _file with _file2, you should > > describe the new constraints on the arguments. e.g. Maybe having pass > > as nil is OK, but then you need to say that, or maybe you need to fall > > back to _file if :pass is not specified. > > Okay, will do. The first version of the function exists since 0.4.0 > but the second appeared "recently" in 3.2.0 (released on June > 2013). Should I put some preprocessor #if checks? Yes, we already have those in gnutls.c. Example: # if GNUTLS_VERSION_NUMBER >= 0x030014 # define HAVE_GNUTLS_X509_SYSTEM_TRUST # endif > How would the docstring be affected? Instead of duplicating the > string (can't put #if inside its body, it's already in a macro), > perhaps I should write that the feature is "only supported with > GnuTLS 3.2.0 and above") You don't have to mention the GnuTLS version explicitly, you can say something more vague, like "supported by recent enough GnuTLS". From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 08:15:49 2022 Received: (at 50507) by debbugs.gnu.org; 28 Sep 2022 12:15:50 +0000 Received: from localhost ([127.0.0.1]:60454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odVyf-0001hp-IC for submit@debbugs.gnu.org; Wed, 28 Sep 2022 08:15:49 -0400 Received: from mail-yb1-f178.google.com ([209.85.219.178]:46958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odVyZ-0001ha-Vr for 50507@debbugs.gnu.org; Wed, 28 Sep 2022 08:15:47 -0400 Received: by mail-yb1-f178.google.com with SMTP id e81so15659763ybb.13 for <50507@debbugs.gnu.org>; Wed, 28 Sep 2022 05:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=+uRCoyNHQ2K+zoY5gsmVEzUdHIvE3ESYj5J0IVChk/k=; b=d38qHrLLl3YqLdYx4rx+5SaHkLApLH0095SeblzQ3dM/xjsEKXlErRcga21YaZZKr0 PLBQh51VoJ8IJSqKSCIukoihVT/skqBBuXVhN1VNJd+OAOl/LeEfLWM74RrbspAkkN7j cN5Y9bxxmeP34X6gXSuH7C3rCbpfeB7KMp7188CPbW0dkXOkZJkSnrAJ2xExdD1ZcyU8 kMzDoX3EkI8QkFtXrALnbcVeFrg3WW0F+hTGzTgSCjL6rINrkmfBtAD/nLFeS95gIwY4 RHepRFwRBqLrZTm6KXiTK3T9DGdvZhu7BXxhyxOXzcC7n2Hp2hbgBJaCnIImU4tnNWwT CN5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=+uRCoyNHQ2K+zoY5gsmVEzUdHIvE3ESYj5J0IVChk/k=; b=cMCbaXlu6YTdba2CDeqWNGg5jsWDTSUpxaEAU7cfsCpuaGcPEy8FmoX72Rw7ZEuR7/ V/52sfO3FdoX7LoEThgeTvRxskmn5xGkfyeDNbZd4+Hy9P2KAtmAvPtKSWrEnNUTPvir gMQI9n19SazTxHiGk4COk3FoZ/mTdVbI6Zic7BJLRIGdziimI6Yf6S5D2e/PQ7JX2xtX 7/nKlXv6VyS2XXcxunaPVBmZEgSYoVCb4feyjw/9WC9CQp4yU9axqRF3VxPwkAoHvvNi XlWvI4L5G5ErahBWsDGUbznPpv189SYz59aSJC8BLvdPOE54SAX+MCh4SYBbroFW4sae +ypg== X-Gm-Message-State: ACrzQf3IqMTDpGNN0ffaetrU1ceIcg+svhZF4IcdE4LdQhfo0quYM0VN F6gWQ39JadrHG/Q/iXr2CtbC2oKdWX6/EAU5a0k= X-Google-Smtp-Source: AMsMyM46a3VyfLPTkSXwR7a1E9IsGbqu875+i4gcI7rGdudJncaOcvmaZVDaWxiliWSq/xWCqNKT6mWFzl7UBZZTfbw= X-Received: by 2002:a05:6902:8d:b0:6bc:47ea:42da with SMTP id h13-20020a056902008d00b006bc47ea42damr5087485ybs.529.1664367338217; Wed, 28 Sep 2022 05:15:38 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> In-Reply-To: <878rm69hop.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Wed, 28 Sep 2022 08:15:26 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: multipart/mixed; boundary="000000000000f8abbd05e9bbb77b" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000f8abbd05e9bbb77b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2022 at 1:19 PM Robert Pluim wrote: > > >>>>> On Mon, 26 Sep 2022 11:43:41 -0400, Nikolaos Chatzikonstantinou said: > Nikolaos> Date: Mon, 26 Sep 2022 11:08:18 -0400 > Nikolaos> Subject: [PATCH] fix(gnutls): add possibility of password f= or key-file > > Nikolaos> The GnuTLS function > > Nikolaos> gnutls_certificate_set_x509_key_file > > Nikolaos> is replaced by its second version > > Nikolaos> gnutls_certificate_set_x509_key_file2 > > Nikolaos> and the definitions of gnutls-boot and gnutls-boot-paramete= rs are > Nikolaos> modified to include the :pass and :flags keys, which are ad= ditional > Nikolaos> parameters in the second version. > > Nikolaos> Signed-off-by: Nikolaos Chatzikonstantinou > Nikolaos> > > We don=CA=BCt use Signed-off-by, and the commit message has some rules > which are described in CONTRIBUTE (start at "** Commit messages" and > read up to and including "** Committing your changes") Okay, I'm submitting this patch with corrections included, see attachment. --000000000000f8abbd05e9bbb77b Content-Type: application/pgp-signature; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch.sig" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch.sig" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8llbyad0 LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQpIYXNoOiBTSEE1MTIKCi0gRnJvbSAy NDY0NDFmNWM5OWZmMThhODhiY2YyN2E0ZjQ5NDhhMDg2YTc4YWM1IE1vbiBTZXAgMTcgMDA6MDA6 MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMxNEBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVjdDogW1BB VENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxpc3QKCiog bGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogYWRkIHRoZSBrZXlz IDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiogc3JjL2du dXRscy5jIChnbnV0bHMtYm9vdCk6IGFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdzLCBhbmQK dXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBhZGQgdGhlIHN5bWJv bHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0byB0aGUg ZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3BrY3NfZW5j cnlwdF9mbGFnc190YC4KOyAoa2V5X2ZpbGUyX2F1eCk6IHByaXZhdGUgZnVuY3Rpb24gdGhhdCB0 cmFuc2xhdGVzIGEgbGlzdCBvZiBzeW1ib2xzCjsgdG8gaXRzIGNvcnJlc3BvbmRpbmcgdW5zaWdu ZWQgaW50IHZhbHVlIG9mIHRoZSBHbnVUTFMgQyBlbnVtCjsgYGdudXRsc19wa2NzX2VuY3J5cHRf ZmxhZ3NfdGAuCi0gLS0tCiBsaXNwL25ldC9nbnV0bHMuZWwgfCAgIDcgKysrCiBzcmMvZ251dGxz LmMgICAgICAgfCAxMDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrCiAyIGZpbGVzIGNoYW5nZWQsIDExMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlz cC9uZXQvZ251dGxzLmVsIGIvbGlzcC9uZXQvZ251dGxzLmVsCmluZGV4IDZlMzg0NWFlYzEuLjlh YWIxOGI4ZmIgMTAwNjQ0Ci0gLS0tIGEvbGlzcC9uZXQvZ251dGxzLmVsCisrKyBiL2xpc3AvbmV0 L2dudXRscy5lbApAQCAtMjY1LDYgKzI2NSw3IEBAIGdudXRscy1ib290LXBhcmFtZXRlcnMKICAg ICAgICAgICAgJmtleSB0eXBlIGhvc3RuYW1lIHByaW9yaXR5LXN0cmluZwogICAgICAgICAgICB0 cnVzdGZpbGVzIGNybGZpbGVzIGtleWxpc3QgbWluLXByaW1lLWJpdHMKICAgICAgICAgICAgdmVy aWZ5LWZsYWdzIHZlcmlmeS1lcnJvciB2ZXJpZnktaG9zdG5hbWUtZXJyb3IKKyAgICAgICAgICAg cGFzcyBmbGFncwogICAgICAgICAgICAmYWxsb3ctb3RoZXIta2V5cykKICAgIlJldHVybiBhIGtl eXdvcmQgbGlzdCBvZiBwYXJhbWV0ZXJzIHN1aXRhYmxlIGZvciBwYXNzaW5nIHRvIGBnbnV0bHMt Ym9vdCcuCiAKQEAgLTI4MSw2ICsyODIsMTAgQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVycwogVkVS SUZZLUhPU1ROQU1FLUVSUk9SIGlzIGEgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgb3B0aW9uIGZv cgogcHV0dGluZyBgOmhvc3RuYW1lJyBpbiBWRVJJRlktRVJST1IuCiAKK1BBU1MgaXMgYSBzdHJp bmcsIHRoZSBwYXNzd29yZCBvZiB0aGUga2V5LgorCitGTEFHUyBpcyBhbiBPUmVkIHNlcXVlbmNl IG9mIGdudXRsc19wa2NzX2VuY3J5cHRfZmxhZ3NfdCB2YWx1ZXMuCisKIFdoZW4gVkVSSUZZLUVS Uk9SIGlzIHQgb3IgYSBsaXN0IGNvbnRhaW5pbmcgYDp0cnVzdGZpbGVzJywgYW4KIGVycm9yIHdp bGwgYmUgcmFpc2VkIHdoZW4gdGhlIHBlZXIgY2VydGlmaWNhdGUgdmVyaWZpY2F0aW9uIGZhaWxz CiBhcyBwZXIgR251VExTJyBnbnV0bHNfY2VydGlmaWNhdGVfdmVyaWZ5X3BlZXJzMi4gIE90aGVy d2lzZSwgb25seQpAQCAtMzU4LDYgKzM2Myw4IEBAIGdudXRscy1ib290LXBhcmFtZXRlcnMKICAg ICAgICAgICAgICAgICA6a2V5bGlzdCAsa2V5bGlzdAogICAgICAgICAgICAgICAgIDp2ZXJpZnkt ZmxhZ3MgLHZlcmlmeS1mbGFncwogICAgICAgICAgICAgICAgIDp2ZXJpZnktZXJyb3IgLHZlcmlm eS1lcnJvcgorICAgICAgICAgICAgICAgIDpwYXNzICxwYXNzCisgICAgICAgICAgICAgICAgOmZs YWdzICxmbGFncwogICAgICAgICAgICAgICAgIDpjYWxsYmFja3MgbmlsKSkpCiAKIChkZWZ1biBn bnV0bHMtLWdldC1maWxlcyAoZmlsZXMpCmRpZmYgLS1naXQgYS9zcmMvZ251dGxzLmMgYi9zcmMv Z251dGxzLmMKaW5kZXggYTBkZTAyMzhjNC4uZmY3YjFkNTkzMSAxMDA2NDQKLSAtLS0gYS9zcmMv Z251dGxzLmMKKysrIGIvc3JjL2dudXRscy5jCkBAIC0zNCw2ICszNCw3IEBACiAjIGVuZGlmCiAK ICMgaWYgR05VVExTX1ZFUlNJT05fTlVNQkVSID49IDB4MDMwMjAwCisjICBkZWZpbmUgSEFWRV9H TlVUTFNfQ0VSVElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJTEUyCiAjICBkZWZpbmUgSEFWRV9HTlVU TFNfQ0lQSEVSX0dFVF9JVl9TSVpFCiAjIGVuZGlmCiAKQEAgLTEyMSw2ICsxMjIsOSBAQCBERUZf RExMX0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZSwKIERFRl9E TExfRk4gKGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlLAogCSAgICAo Z251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIgKiwgY29uc3QgY2hh ciAqLAogCSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CitERUZfRExMX0ZOIChpbnQsIGdu dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIsCisJICAgIChnbnV0bHNfY2VydGlm aWNhdGVfY3JlZGVudGlhbHNfdCwgY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICosCisJICAgICBn bnV0bHNfeDUwOV9jcnRfZm10X3QsIGNvbnN0IGNoYXIgKiwgdW5zaWduZWQgaW50KSk7CiAjICBp ZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9GTiAoaW50LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAoZ251dGxzX2NlcnRp ZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMTgsNyBAQCBpbml0X2dudXRsc19m dW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNh dGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2Vy dGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyAgTE9BRF9ETExfRk4gKGxpYnJh cnksIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIpOwogIyAgaWZkZWYgSEFW RV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxpYnJhcnksIGdudXRs c19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5kaWYKQEAgLTQ1NSw2 ICs0NjAsNyBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBkZWZpbmUgZ251dGxz X2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF92 ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfY3JsX2Zp bGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAjICBkZWZpbmUgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9z ZXRfeDUwOV9rZXlfZmlsZQorIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9r ZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgogIyAgZGVm aW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QgZm5fZ251dGxzX2Nl cnRpZmljYXRlX3NldF94NTA5X3N5c3RlbV90cnVzdAogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZp Y2F0ZV9zZXRfeDUwOV90cnVzdF9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV90 cnVzdF9maWxlCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3R5cGVfZ2V0IGZuX2dudXRs c19jZXJ0aWZpY2F0ZV90eXBlX2dldApAQCAtMTc3NCw2ICsxNzgwLDU3IEBAIGdudXRsc192ZXJp ZnlfYm9vdCAoTGlzcF9PYmplY3QgcHJvYywgTGlzcF9PYmplY3QgcHJvcGxpc3QpCiAgIHJldHVy biBnbnV0bHNfbWFrZV9lcnJvciAocmV0KTsKIH0KIAorLyogSGVscGVyIGZ1bmN0aW9uIGZvciBn bnV0bHMtYm9vdC4KKworICAgVGhlIGtleSA6ZmxhZ3MgcmVjZWl2ZXMgYSBsaXNwIG9mIHN5bWJv bHMsIGVhY2ggb2Ygd2hpY2gKKyAgIGNvcnJlc3BvbmRzIHRvIGEgR251VExTIEMgZmxhZywgdGhl IE9SZWQgcmVzdWx0IGlzIHRvIGJlIHBhc3NlZCB0bworICAgdGhlIGZ1bmN0aW9uIGdudXRsc19j ZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIoKSBhcyBpdHMgbGFzdAorICAgYXJndW1lbnQu CisqLwordW5zaWduZWQgaW50CitrZXlfZmlsZTJfYXV4IChMaXNwX09iamVjdCBmbGFncykKK3sK KyAgdW5zaWduZWQgaW50IHJ2ID0gMDsKKyAgTGlzcF9PYmplY3QgdGFpbDsKKyAgZm9yICh0YWls ID0gZmxhZ3M7IENPTlNQICh0YWlsKTsgdGFpbCA9IFhDRFIgKHRhaWwpKQorICAgIHsKKyAgICAg IExpc3BfT2JqZWN0IGZsYWcgPSBYQ0FSKHRhaWwpOworICAgICAgaWYgKEVRKGZsYWcsIFFnbnV0 bHNfcGtjc19wbGFpbikpCisJcnYgfD0gR05VVExTX1BLQ1NfUExBSU47CisgICAgICBlbHNlIGlm KEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wa2NzMTJfM2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1Nf UEtDUzEyXzNERVM7CisgICAgICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wa2NzMTJf YXJjZm91cikpCisJcnYgfD0gR05VVExTX1BLQ1NfUEtDUzEyX0FSQ0ZPVVI7CisgICAgICBlbHNl IGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wa2NzMTJfcmMyXzQwKSkKKwlydiB8PSBHTlVUTFNf UEtDU19QS0NTMTJfUkMyXzQwOworICAgICAgZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3Nf cGJlczJfM2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfM0RFUzsKKyAgICAgIGVsc2Ug aWYoRVEoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18xMjgpKQorCXJ2IHw9IEdOVVRMU19Q S0NTX1BCRVMyX0FFU18xMjg7CisgICAgICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19w YmVzMl9hZXNfMTkyKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTkyOworICAgICAg ZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfYWVzXzI1NikpCisJcnYgfD0gR05V VExTX1BLQ1NfUEJFUzJfQUVTXzI1NjsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19w a2NzX251bGxfcGFzc3dvcmQpKQorCXJ2IHw9IEdOVVRMU19QS0NTX05VTExfUEFTU1dPUkQ7Cisg ICAgICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9kZXMpKQorCXJ2IHw9IEdO VVRMU19QS0NTX1BCRVMyX0RFUzsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19wa2Nz X3BiZXMxX2Rlc19tZDUpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMxX0RFU19NRDU7CisgICAg ICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X3RjMjZ6KSkKKwlydiB8 PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaOworICAgICAgZWxzZSBpZihFUShmbGFnLCBR Z251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGEpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dP U1RfQ1BBOworICAgICAgZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9j cGIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCOworICAgICAgZWxzZSBpZihF UShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGMpKQorCXJ2IHw9IEdOVVRMU19QS0NT X1BCRVMyX0dPU1RfQ1BDOworICAgICAgZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJl czJfZ29zdF9jcGQpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BEOworICAgIH0K KyAgcmV0dXJuIHJ2OworfQorCiBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19ib290LCBT Z251dGxzX2Jvb3QsIDMsIDMsIDAsCiAgICAgICAgZG9jOiAvKiBJbml0aWFsaXplIEdudVRMUyBj bGllbnQgZm9yIHByb2Nlc3MgUFJPQyB3aXRoIFRZUEUrUFJPUExJU1QuCiBDdXJyZW50bHkgb25s eSBjbGllbnQgbW9kZSBpcyBzdXBwb3J0ZWQuICBSZXR1cm4gYSBzdWNjZXNzL2ZhaWx1cmUKQEAg LTE4MTMsNiArMTg3MCwxOSBAQCBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19ib290LCBT Z251dGxzX2Jvb3QsIDMsIDMsIDAsCiA6Y29tcGxldGUtbmVnb3RpYXRpb24sIGlmIG5vbi1uaWws IHdpbGwgbWFrZSBuZWdvdGlhdGlvbiBjb21wbGV0ZQogYmVmb3JlIHJldHVybmluZyBldmVuIG9u IG5vbi1ibG9ja2luZyBzb2NrZXRzLgogCis6cGFzcywgdGhlIHBhc3N3b3JkIG9mIHRoZSBwcml2 YXRlIGtleSBhcyBwZXIgR251VExTJworZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9m aWxlMi4KKworOmZsYWdzLCBhIGxpc3Qgb2Ygc3ltYm9scyByZWxhdGluZyB0byA6cGFzcywgZWFj aCBzcGVjaWZ5aW5nIGEgZmxhZzoKK0dOVVRMU19QS0NTX1BMQUlOLCBHTlVUTFNfUEtDU19QS0NT MTJfM0RFUywKK0dOVVRMU19QS0NTX1BLQ1MxMl9BUkNGT1VSLCBHTlVUTFNfUEtDU19QS0NTMTJf UkMyXzQwLAorR05VVExTX1BLQ1NfUEJFUzJfM0RFUywgR05VVExTX1BLQ1NfUEJFUzJfQUVTXzEy OCwKK0dOVVRMU19QS0NTX1BCRVMyX0FFU18xOTIsIEdOVVRMU19QS0NTX1BCRVMyX0FFU18yNTYs CitHTlVUTFNfUEtDU19OVUxMX1BBU1NXT1JELCBHTlVUTFNfUEtDU19QQkVTMl9ERVMsCitHTlVU TFNfUEtDU19QQkVTMl9ERVNfTUQ1LCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaLAorR05V VExTX1BLQ1NfUEJFUzJfR09TVF9DUEEsIEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCLAorR05V VExTX1BLQ1NfUEJFUzJfR09TVF9DUEMsIEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BELgorCiBU aGUgZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRoaXMgcHJvY2VzcyBBTkQgZ2xvYmFsbHkg Zm9yIEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGlnaGVyIG9yIGxvd2VyIGF0IGFueSBwb2lu dCwgaXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4KQEAgLTE4MjUsNiArMTg5NSw5IEBAIERF RlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwK IGZ1bmN0aW9ucyBhcmUgdXNlZC4gIFRoaXMgZnVuY3Rpb24gYWxsb2NhdGVzIHJlc291cmNlcyB3 aGljaCBjYW4gb25seQogYmUgZGVhbGxvY2F0ZWQgYnkgY2FsbGluZyBgZ251dGxzLWRlaW5pdCcg b3IgYnkgY2FsbGluZyBpdCBhZ2Fpbi4KIAorVGhlIDpwYXNzIGFuZCA6ZmxhZ3Mga2V5cyBhcmUg aWdub3JlZCB3aXRoIG9sZCB2ZXJzaW9ucyBvZiBHbnVUTFMsIGFuZAorOmZsYWdzIGlzIGlnbm9y ZWQgaWYgOnBhc3MgaXMgbm90IHNwZWNpZmllZC4KKwogVGhlIGNhbGxiYWNrcyBhbGlzdCBjYW4g aGF2ZSBhIGB2ZXJpZnknIGtleSwgYXNzb2NpYXRlZCB3aXRoIGEKIHZlcmlmaWNhdGlvbiBmdW5j dGlvbiAoVU5VU0VEKS4KIApAQCAtMTg0OCw2ICsxOTIxLDggQEAgREVGVU4gKCJnbnV0bHMtYm9v dCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICBMaXNwX09iamVjdCB0 cnVzdGZpbGVzOwogICBMaXNwX09iamVjdCBjcmxmaWxlczsKICAgTGlzcF9PYmplY3Qga2V5bGlz dDsKKyAgTGlzcF9PYmplY3QgcGFzczsKKyAgTGlzcF9PYmplY3QgZmxhZ3M7CiAgIC8qIExpc3Bf T2JqZWN0IGNhbGxiYWNrczsgKi8KICAgTGlzcF9PYmplY3QgbG9nbGV2ZWw7CiAgIExpc3BfT2Jq ZWN0IGhvc3RuYW1lOwpAQCAtMTg3Nyw2ICsxOTUyLDggQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIs IEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICBjcmxmaWxlcyAgICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2NybGZpbGVzKTsKICAgbG9nbGV2ZWwgICAg ICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNsb2dsZXZlbCk7CiAgIHByaW1lX2Jp dHMgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDbWluX3ByaW1lX2JpdHMpOwor ICBwYXNzICAgICAgICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ3Bhc3MpOwor ICBmbGFncyAgICAgICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2ZsYWdzKTsK IAogICBpZiAoIVNUUklOR1AgKGhvc3RuYW1lKSkKICAgICB7CkBAIC0yMDM4LDggKzIxMTUsMTcg QEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAz LCAwLAogCSAgICAgIGtleWZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoa2V5ZmlsZSk7CiAJ ICAgICAgY2VydGZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoY2VydGZpbGUpOwogIyBlbmRp ZgorIyBpZmRlZiBIQVZFX0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKKwkg ICAgICBpZiAoU1RSSU5HUCAocGFzcykpCisJCXJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRf eDUwOV9rZXlfZmlsZTIKKwkJICAoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRB IChrZXlmaWxlKSwgZmlsZV9mb3JtYXQsIFNTREFUQSAocGFzcyksIGtleV9maWxlMl9hdXggKGZs YWdzKSk7CisJICAgICAgZWxzZQorCQlyZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlf a2V5X2ZpbGUKKwkJICAoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChrZXlm aWxlKSwgZmlsZV9mb3JtYXQpOworIyBlbHNlCiAJICAgICAgcmV0ID0gZ251dGxzX2NlcnRpZmlj YXRlX3NldF94NTA5X2tleV9maWxlCiAJCSh4NTA5X2NyZWQsIFNTREFUQSAoY2VydGZpbGUpLCBT U0RBVEEgKGtleWZpbGUpLCBmaWxlX2Zvcm1hdCk7CisjIGVuZGlmCiAKIAkgICAgICBpZiAocmV0 IDwgR05VVExTX0VfU1VDQ0VTUykKIAkJcmV0dXJuIGdudXRsc19tYWtlX2Vycm9yIChyZXQpOwpA QCAtMjg2MCw4ICsyOTQ2LDI2IEBAIHN5bXNfb2ZfZ251dGxzICh2b2lkKQogICBERUZTWU0gKFFD bWluX3ByaW1lX2JpdHMsICI6bWluLXByaW1lLWJpdHMiKTsKICAgREVGU1lNIChRQ2xvZ2xldmVs LCAiOmxvZ2xldmVsIik7CiAgIERFRlNZTSAoUUNjb21wbGV0ZV9uZWdvdGlhdGlvbiwgIjpjb21w bGV0ZS1uZWdvdGlhdGlvbiIpOworICBERUZTWU0gKFFDcGFzcywgIjpwYXNzIik7CisgIERFRlNZ TSAoUUNmbGFncywgIjpmbGFncyIpOwogICBERUZTWU0gKFFDdmVyaWZ5X2ZsYWdzLCAiOnZlcmlm eS1mbGFncyIpOwogICBERUZTWU0gKFFDdmVyaWZ5X2Vycm9yLCAiOnZlcmlmeS1lcnJvciIpOwor ICBERUZTWU0gKFFnbnV0bHNfcGtjc19wbGFpbiwgIkdOVVRMU19QS0NTX1BMQUlOIik7CisgIERF RlNZTSAoUWdudXRsc19wa2NzX3BrY3MxMl8zZGVzLCAiR05VVExTX1BLQ1NfUEtDUzEyXzNERVMi KTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGtjczEyX2FyY2ZvdXIsICJHTlVUTFNfUEtDU19Q S0NTMTJfQVJDRk9VUiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wa2NzMTJfcmMyXzQwLCAi R05VVExTX1BLQ1NfUEtDUzEyX1JDMl80MCIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVz Ml8zZGVzLCAiR05VVExTX1BLQ1NfUEJFUzJfM0RFUyIpOworICBERUZTWU0gKFFnbnV0bHNfcGtj c19wYmVzMl9hZXNfMTI4LCAiR05VVExTX1BLQ1NfUEJFUzJfQUVTXzEyOCIpOworICBERUZTWU0g KFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMTkyLCAiR05VVExTX1BLQ1NfUEJFUzJfQUVTXzE5MiIp OworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMjU2LCAiR05VVExTX1BLQ1NfUEJF UzJfQUVTXzI1NiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19udWxsX3Bhc3N3b3JkLCAiR05V VExTX1BLQ1NfTlVMTF9QQVNTV09SRCIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9k ZXMsICJHTlVUTFNfUEtDU19QQkVTMl9ERVMiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJl czFfZGVzX21kNSwgIkdOVVRMU19QS0NTX1BCRVMxX0RFU19NRDUiKTsKKyAgREVGU1lNIChRZ251 dGxzX3BrY3NfcGJlczJfZ29zdF90YzI2eiwgIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfVEMyNloi KTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGEsICJHTlVUTFNfUEtDU19Q QkVTMl9HT1NUX0NQQSIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwYiwg IkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3Bi ZXMyX2dvc3RfY3BjLCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEMiKTsKKyAgREVGU1lNIChR Z251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGQsICJHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQRCIp OwogCiAgIERFRlNZTSAoUUNjaXBoZXJfaWQsICI6Y2lwaGVyLWlkIik7CiAgIERFRlNZTSAoUUNj aXBoZXJfYWVhZF9jYXBhYmxlLCAiOmNpcGhlci1hZWFkLWNhcGFibGUiKTsKLSAtLSAKMi4zNy4z CgotLS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUtLS0tLQoKaVFJekJBRUJDZ0FkRmlFRUhISFVDWUtO ZFdsNWg4NDVEdE5SNnpjZVpFZ0ZBbU0wT1lnQUNna1FEdE5SNnpjZQpaRWhJbUJBQXkzbWFuVDlP cjd0Q20zaHJVN2xPSzJybUdnWmZxMi9UZmFJT0ZlU3p1YzdXZ2dyWWJuZ3lqbmNCCjFjN2hEUFZQ QWVMMVZZSVdQa3lsakpPSjEyRUlWQ0Q4R2lXNTg4YlNkNHBKd1VLREkzQU9RZUp1djU3dWdobVIK azhtK0RFNDFveVNaNXRmRlZ6b09QempUMWVSZzRDRjlwS1Z5Z0Z4R3RRNU1RMVBOOHdiNUppOVc2 ZVFtVWJ3Rwo3M3RNQlE4bENEZ0RBaWpKTnhLRWVBcFF2TnNQUkFMNytaeWxsV0hDMTVONzFwM3U2 ZlJxRVVRS3l5cStsUEVUCjR6VXcrd0Njc0RkTkxuTzZXRWhncHB5c3RQQlpENGE1VSsrL2YwV0NZ RllCWGlFT2pNN2xDQ0Z5eEozT3VWaFoKTitNMk80TkFxQ3BIZFpSdXdNa2Y5QzYvYjQwOWhSOGF2 aEd1aWRkbUNTZElqU1ZwQUV2WnBmbVVjenk3SlJaLwpIRGRSY1FRdlVzR2FSTWMxSzJkWG14Mkxz eUhMWks4emNwMWFqc1RGK0hFc2lTTEZmbmtqdW0xUmFVc3piWXlFCkI2OVVlSWp5M2F0QnJ6ZW1K d2Z6OTBmV3pRQXJvM0tVY1NZalFCbTMrcXNrMnU3cHA2bytaN0lTT0FSNTc4WkMKOHp5ZndvMTY1 UzZEaGx6TFJiZ1JRYm4xQ3E2cSthUG5XaHpTOS8zbVphWm9FaUpQY1EvaHdvckwyN3o5cGk5Vgp4 enY3a1hhTCt0QmNnS1FzN3BrOEMvNnVmZU9EdThuMzV3QkJ6bW5wK2VQaDhVemNNQmNNeUJHb2cx YzdjdzBsClhXR3c2MzJJLzhzWXNUU2FIcGYzeW1yRFdKaS9qU3JGQ204U21VSUhZdmpZRi9ETlg2 UT0KPXdIR2IKLS0tLS1FTkQgUEdQIFNJR05BVFVSRS0tLS0tCg== --000000000000f8abbd05e9bbb77b-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 09:11:43 2022 Received: (at 50507) by debbugs.gnu.org; 28 Sep 2022 13:11:43 +0000 Received: from localhost ([127.0.0.1]:60641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWqk-0003DB-Up for submit@debbugs.gnu.org; Wed, 28 Sep 2022 09:11:43 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:43976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odWqi-0003Cy-BE for 50507@debbugs.gnu.org; Wed, 28 Sep 2022 09:11:41 -0400 Received: by mail-wr1-f46.google.com with SMTP id h7so7331587wru.10 for <50507@debbugs.gnu.org>; Wed, 28 Sep 2022 06:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=KE+jnVy0bCPUJ1MYhscJWHJMOTGJE8BcYUCCsdQh+Co=; b=DgtJG9uyTiUl7rxiNWg5NpO0WoUHWHDb8+VpsImIFpRngLXQiZbTKLh9E5IcjvslrU oTz9UBMhONfIThcI7u+jJIwYD3qcgMD7tiS7PxL3AFjXwXWcW+kpHdtNXhamqfQBAHDR 6Rcgy3wZ38KoOXFYFPzDs2QVzfmKXoZRRZCWPh/u1I3VMdV5UiTnVW9sCaElDJ1ihL1y Kci53uUcNctZSswDmH0d1CynkKv+9RNa+gwT4gmVtHRyLQhpetq6rC5qtlf3WhsigC6d 4n4GSNwJ4JkmwYJS/b5mv6DVyt+eAyGbzTSQzJt1RQVxZEYpksOf4a7gnSZQ9B38TxSw F8dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=KE+jnVy0bCPUJ1MYhscJWHJMOTGJE8BcYUCCsdQh+Co=; b=Dxccv/m2GhWq7MwAA3T6XPA6HUqecfwc1WsxgmWYc6wwfmZTXxJbwvqgltyZA3zEV/ s4ImkymmDMykDq2ADKUuLqqhGyDdJvI2mruhkjK0n8xGYr0JruK327MIdCvnFuVkzeL+ shH6GSZWcFxiuIXKJ4tIPHxla3bGkgHEstiHx4jNjCctb9fEv7nL8TIwHyBYVakY3tCH 9NxL0QB4FI6lxZcEYC6LWKycRYqqt7WUSklqI+N6AMNDYfAI0BS7s0FNx//LREJ7818X 97cahQxYBe1tvQv5CFQaNPx1Vf7BOSuYz4LxZVZP77+/BdLwoy1iA9nrtWaTc3khk6G+ 3b2g== X-Gm-Message-State: ACrzQf05X96C/xN8gcBASkKPo97diPPUMBJn6CT8iAgbMstbO5D0KD7Z TTGCh06MkLncCzuqb+pYMAogPsRM9hs= X-Google-Smtp-Source: AMsMyM4cLLsRjQRqtoDVs4a6hWcK7UFMKVzTHz6B9JCxvsJc8qQdC5iCl0XJDeBaeMcIPmFIGAFLvA== X-Received: by 2002:adf:d209:0:b0:228:6298:f288 with SMTP id j9-20020adfd209000000b002286298f288mr20087502wrh.386.1664370694693; Wed, 28 Sep 2022 06:11:34 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:c58f:2b69:6813:6c0]) by smtp.gmail.com with ESMTPSA id m17-20020a05600c3b1100b003b476cabf1csm2425613wms.26.2022.09.28.06.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 06:11:33 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Wed, 28 Sep 2022 08:15:26 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> Date: Wed, 28 Sep 2022 15:11:33 +0200 Message-ID: <87v8p7d4oq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 28 Sep 2022 08:15:26 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> Okay, I'm submitting this patch with corrections included, se= e attachment. I see a .sig attachment, but no patch (we don=CA=BCt currently require signing of commits at all, but I guess there=CA=BCs nothing stopping people from doing it). Regards Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 23:10:06 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 03:10:06 +0000 Received: from localhost ([127.0.0.1]:35444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odjw5-00087g-KR for submit@debbugs.gnu.org; Wed, 28 Sep 2022 23:10:06 -0400 Received: from mail-yw1-f182.google.com ([209.85.128.182]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odjw3-000876-C9 for 50507@debbugs.gnu.org; Wed, 28 Sep 2022 23:10:04 -0400 Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-353fbfa727cso2021747b3.4 for <50507@debbugs.gnu.org>; Wed, 28 Sep 2022 20:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=1uZYVofOjx2qGSz5IXzNUaDfb7QIUx03U//pV+oLx7Y=; b=W8sxz5ef2qEPfXAsOMNKV2pfUs9j9yBxGinVrbXqgem0uih5LvrlTGxgjAJWmNybk8 8Qru9gBwLk+A3tqDUMkIbJo5e9hvoRmNHoakFZgpdCnEP/oRCROx9uUppF9QPrbxsIZ1 m9+TanlTOvs3DfEyC0oJHHGClbznRieisby0g05dIvPH5QwJl1ItMxl4SWOQlHVVT8jb lKHMuQpmRVDJ+7spf4330BgtVLvdQ7f74EULdoayJs+1RRgORSNsMHy1oWrkcIS/4fGx Ke0DqeJtFWw9IrU2N6IAVTepbpR1pWnswMHPdbonX6+g5av0HX+I9s8jEfBAMuNpuXBw MFCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1uZYVofOjx2qGSz5IXzNUaDfb7QIUx03U//pV+oLx7Y=; b=hSGdmJcCJCP4FEcP+e6nCH1qTfMjlUYB6Pz+at172ozoV1dfBMRnOpivIyMCXxZW3E qCFTr6mUbG/XUG8TgiKiFY9q+aakuCMM/pylMc1rD705FTPT95yWKmDUKrawOkyXpLN7 2Xg20Ecog7WuY8EV8YG3lxOKtdjhS+MPHBVzGPBnAU+uCStTUbOmYGOoVASTk8WsYzkr sTkNTqeOh91IuTKIOn2nMu2+1lfi9al5uJ/eKGMIo6+zEpDlSf1xl+dTiKdjgn2ZwZs3 MXJmNPxi6tpZMTWDHFGj8Z7Habm2zqz1IRPJ/p/RYP+FLlsYMwHsUY+yN3oCoLpUmJxB bCVw== X-Gm-Message-State: ACrzQf2fbr2PVelBD4YN16upauCSvDjunpYFTahvMEJjM4mG1xbCp/5R z1BpnzwRFOnlMXOgfmDHTPd9uKpeXjuvZ/khPtg= X-Google-Smtp-Source: AMsMyM6iwsFH62uANw9Bz7pM88oxgMYeaE/5EMAn5wIalFme72Rz1S9KAQYUpM1motDseHmV5AvI9hsgGx5Tge1TrIM= X-Received: by 2002:a0d:d6c9:0:b0:351:b421:c3ec with SMTP id y192-20020a0dd6c9000000b00351b421c3ecmr1064735ywd.67.1664420997814; Wed, 28 Sep 2022 20:09:57 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> In-Reply-To: <87v8p7d4oq.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Wed, 28 Sep 2022 23:09:46 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: multipart/mixed; boundary="00000000000055288e05e9c836f9" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --00000000000055288e05e9c836f9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 28, 2022 at 9:11 AM Robert Pluim wrote: > > >>>>> On Wed, 28 Sep 2022 08:15:26 -0400, Nikolaos Chatzikonstantinou said: > > > Nikolaos> Okay, I'm submitting this patch with corrections included, = see attachment. > > I see a .sig attachment, but no patch (we don=CA=BCt currently require > signing of commits at all, but I guess there=CA=BCs nothing stopping peop= le > from doing it). My bad, here it is. I also added "Copyright-paperwork-exempt: yes" (or will this require paperwork?) and gave the helper function static linkage in src/gnutls.c. --00000000000055288e05e9c836f9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8mh9zua0 RnJvbSBiMTE3MDdjNDIzNzczZjYyMzQ3NDY5OTEyMjJhY2Q4MGFiM2Y3MDhjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxp c3QKCiogbGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogYWRkIHRo ZSBrZXlzIDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiog c3JjL2dudXRscy5jIChnbnV0bHMtYm9vdCk6IGFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdz LCBhbmQKdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBhZGQgdGhl IHN5bWJvbHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0 byB0aGUgZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190YC4KOyAoa2V5X2ZpbGUyX2F1eCk6IHByaXZhdGUgaGVscGVyIGZ1 bmN0aW9uIHRoYXQgdHJhbnNsYXRlcyBhIGxpc3Qgb2YKOyBzeW1ib2xzIHRvIGl0cyBjb3JyZXNw b25kaW5nIGB1bnNpZ25lZCBpbnRgIHZhbHVlIG9mIHRoZSBHbnVUTFMgQwo7IGVudW0gYGdudXRs c19wa2NzX2VuY3J5cHRfZmxhZ3NfdGAuCgpDb3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVz Ci0tLQogbGlzcC9uZXQvZ251dGxzLmVsIHwgICA3ICsrKwogc3JjL2dudXRscy5jICAgICAgIHwg MTA0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxl cyBjaGFuZ2VkLCAxMTEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2dudXRs cy5lbCBiL2xpc3AvbmV0L2dudXRscy5lbAppbmRleCA2ZTM4NDVhZWMxLi45YWFiMThiOGZiIDEw MDY0NAotLS0gYS9saXNwL25ldC9nbnV0bHMuZWwKKysrIGIvbGlzcC9uZXQvZ251dGxzLmVsCkBA IC0yNjUsNiArMjY1LDcgQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVycwogICAgICAgICAgICAma2V5 IHR5cGUgaG9zdG5hbWUgcHJpb3JpdHktc3RyaW5nCiAgICAgICAgICAgIHRydXN0ZmlsZXMgY3Js ZmlsZXMga2V5bGlzdCBtaW4tcHJpbWUtYml0cwogICAgICAgICAgICB2ZXJpZnktZmxhZ3MgdmVy aWZ5LWVycm9yIHZlcmlmeS1ob3N0bmFtZS1lcnJvcgorICAgICAgICAgICBwYXNzIGZsYWdzCiAg ICAgICAgICAgICZhbGxvdy1vdGhlci1rZXlzKQogICAiUmV0dXJuIGEga2V5d29yZCBsaXN0IG9m IHBhcmFtZXRlcnMgc3VpdGFibGUgZm9yIHBhc3NpbmcgdG8gYGdudXRscy1ib290Jy4KIApAQCAt MjgxLDYgKzI4MiwxMCBAQCBnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzCiBWRVJJRlktSE9TVE5BTUUt RVJST1IgaXMgYSBiYWNrd2FyZHMgY29tcGF0aWJpbGl0eSBvcHRpb24gZm9yCiBwdXR0aW5nIGA6 aG9zdG5hbWUnIGluIFZFUklGWS1FUlJPUi4KIAorUEFTUyBpcyBhIHN0cmluZywgdGhlIHBhc3N3 b3JkIG9mIHRoZSBrZXkuCisKK0ZMQUdTIGlzIGFuIE9SZWQgc2VxdWVuY2Ugb2YgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190IHZhbHVlcy4KKwogV2hlbiBWRVJJRlktRVJST1IgaXMgdCBvciBh IGxpc3QgY29udGFpbmluZyBgOnRydXN0ZmlsZXMnLCBhbgogZXJyb3Igd2lsbCBiZSByYWlzZWQg d2hlbiB0aGUgcGVlciBjZXJ0aWZpY2F0ZSB2ZXJpZmljYXRpb24gZmFpbHMKIGFzIHBlciBHbnVU TFMnIGdudXRsc19jZXJ0aWZpY2F0ZV92ZXJpZnlfcGVlcnMyLiAgT3RoZXJ3aXNlLCBvbmx5CkBA IC0zNTgsNiArMzYzLDggQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVycwogICAgICAgICAgICAgICAg IDprZXlsaXN0ICxrZXlsaXN0CiAgICAgICAgICAgICAgICAgOnZlcmlmeS1mbGFncyAsdmVyaWZ5 LWZsYWdzCiAgICAgICAgICAgICAgICAgOnZlcmlmeS1lcnJvciAsdmVyaWZ5LWVycm9yCisgICAg ICAgICAgICAgICAgOnBhc3MgLHBhc3MKKyAgICAgICAgICAgICAgICA6ZmxhZ3MgLGZsYWdzCiAg ICAgICAgICAgICAgICAgOmNhbGxiYWNrcyBuaWwpKSkKIAogKGRlZnVuIGdudXRscy0tZ2V0LWZp bGVzIChmaWxlcykKZGlmZiAtLWdpdCBhL3NyYy9nbnV0bHMuYyBiL3NyYy9nbnV0bHMuYwppbmRl eCBhMGRlMDIzOGM0Li4yYTYwNjllNTQyIDEwMDY0NAotLS0gYS9zcmMvZ251dGxzLmMKKysrIGIv c3JjL2dudXRscy5jCkBAIC0zNCw2ICszNCw3IEBACiAjIGVuZGlmCiAKICMgaWYgR05VVExTX1ZF UlNJT05fTlVNQkVSID49IDB4MDMwMjAwCisjICBkZWZpbmUgSEFWRV9HTlVUTFNfQ0VSVElGSUNB VEVfU0VUX1g1MDlfS0VZX0ZJTEUyCiAjICBkZWZpbmUgSEFWRV9HTlVUTFNfQ0lQSEVSX0dFVF9J Vl9TSVpFCiAjIGVuZGlmCiAKQEAgLTEyMSw2ICsxMjIsOSBAQCBERUZfRExMX0ZOIChpbnQsIGdu dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZSwKIERFRl9ETExfRk4gKGludCwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlLAogCSAgICAoZ251dGxzX2NlcnRpZmlj YXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqLAogCSAgICAgZ251 dGxzX3g1MDlfY3J0X2ZtdF90KSk7CitERUZfRExMX0ZOIChpbnQsIGdudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV9rZXlfZmlsZTIsCisJICAgIChnbnV0bHNfY2VydGlmaWNhdGVfY3JlZGVudGlh bHNfdCwgY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICosCisJICAgICBnbnV0bHNfeDUwOV9jcnRf Zm10X3QsIGNvbnN0IGNoYXIgKiwgdW5zaWduZWQgaW50KSk7CiAjICBpZmRlZiBIQVZFX0dOVVRM U19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9GTiAoaW50LCBnbnV0bHNfY2VydGlmaWNhdGVf c2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAoZ251dGxzX2NlcnRpZmljYXRlX2NyZWRlbnRp YWxzX3QpKTsKQEAgLTMxNCw2ICszMTgsNyBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQp CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3ZlcmlmeV9m bGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1 MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251dGxzX2NlcnRpZmljYXRl X3NldF94NTA5X2tleV9maWxlKTsKKyAgTE9BRF9ETExfRk4gKGxpYnJhcnksIGdudXRsc19jZXJ0 aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIpOwogIyAgaWZkZWYgSEFWRV9HTlVUTFNfWDUwOV9T WVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxpYnJhcnksIGdudXRsc19jZXJ0aWZpY2F0ZV9z ZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5kaWYKQEAgLTQ1NSw2ICs0NjAsNyBAQCBpbml0 X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3Nl dF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MKICMg IGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUgZm5fZ251dGxzX2Nl cnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRl X3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmls ZQorIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIgZm5fZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgogIyAgZGVmaW5lIGdudXRsc19jZXJ0 aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94 NTA5X3N5c3RlbV90cnVzdAogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV90 cnVzdF9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV90cnVzdF9maWxlCiAjICBk ZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3R5cGVfZ2V0IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV90 eXBlX2dldApAQCAtMTc3NCw2ICsxNzgwLDU3IEBAIGdudXRsc192ZXJpZnlfYm9vdCAoTGlzcF9P YmplY3QgcHJvYywgTGlzcF9PYmplY3QgcHJvcGxpc3QpCiAgIHJldHVybiBnbnV0bHNfbWFrZV9l cnJvciAocmV0KTsKIH0KIAorLyogSGVscGVyIGZ1bmN0aW9uIGZvciBnbnV0bHMtYm9vdC4KKwor ICAgVGhlIGtleSA6ZmxhZ3MgcmVjZWl2ZXMgYSBsaXNwIG9mIHN5bWJvbHMsIGVhY2ggb2Ygd2hp Y2gKKyAgIGNvcnJlc3BvbmRzIHRvIGEgR251VExTIEMgZmxhZywgdGhlIE9SZWQgcmVzdWx0IGlz IHRvIGJlIHBhc3NlZCB0bworICAgdGhlIGZ1bmN0aW9uIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRf eDUwOV9rZXlfZmlsZTIoKSBhcyBpdHMgbGFzdAorICAgYXJndW1lbnQuCisqLworc3RhdGljIHVu c2lnbmVkIGludAora2V5X2ZpbGUyX2F1eCAoTGlzcF9PYmplY3QgZmxhZ3MpCit7CisgIHVuc2ln bmVkIGludCBydiA9IDA7CisgIExpc3BfT2JqZWN0IHRhaWw7CisgIGZvciAodGFpbCA9IGZsYWdz OyBDT05TUCAodGFpbCk7IHRhaWwgPSBYQ0RSICh0YWlsKSkKKyAgICB7CisgICAgICBMaXNwX09i amVjdCBmbGFnID0gWENBUih0YWlsKTsKKyAgICAgIGlmIChFUShmbGFnLCBRZ251dGxzX3BrY3Nf cGxhaW4pKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BMQUlOOworICAgICAgZWxzZSBpZihFUShmbGFn LCBRZ251dGxzX3BrY3NfcGtjczEyXzNkZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BLQ1MxMl8z REVTOworICAgICAgZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGtjczEyX2FyY2ZvdXIp KQorCXJ2IHw9IEdOVVRMU19QS0NTX1BLQ1MxMl9BUkNGT1VSOworICAgICAgZWxzZSBpZihFUShm bGFnLCBRZ251dGxzX3BrY3NfcGtjczEyX3JjMl80MCkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEtD UzEyX1JDMl80MDsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyXzNk ZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyXzNERVM7CisgICAgICBlbHNlIGlmKEVRKGZs YWcsIFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMTI4KSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVT Ml9BRVNfMTI4OworICAgICAgZWxzZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfYWVz XzE5MikpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfQUVTXzE5MjsKKyAgICAgIGVsc2UgaWYo RVEoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18yNTYpKQorCXJ2IHw9IEdOVVRMU19QS0NT X1BCRVMyX0FFU18yNTY7CisgICAgICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19udWxs X3Bhc3N3b3JkKSkKKwlydiB8PSBHTlVUTFNfUEtDU19OVUxMX1BBU1NXT1JEOworICAgICAgZWxz ZSBpZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZGVzKSkKKwlydiB8PSBHTlVUTFNfUEtD U19QQkVTMl9ERVM7CisgICAgICBlbHNlIGlmKEVRKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMV9k ZXNfbWQ1KSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMV9ERVNfTUQ1OworICAgICAgZWxzZSBp ZihFUShmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29zdF90YzI2eikpCisJcnYgfD0gR05VVExT X1BLQ1NfUEJFUzJfR09TVF9UQzI2WjsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19w a2NzX3BiZXMyX2dvc3RfY3BhKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQTsK KyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BiKSkKKwly diB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQjsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywg UWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BjKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9H T1NUX0NQQzsKKyAgICAgIGVsc2UgaWYoRVEoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2dvc3Rf Y3BkKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQRDsKKyAgICB9CisgIHJldHVy biBydjsKK30KKwogREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19i b290LCAzLCAzLCAwLAogICAgICAgIGRvYzogLyogSW5pdGlhbGl6ZSBHbnVUTFMgY2xpZW50IGZv ciBwcm9jZXNzIFBST0Mgd2l0aCBUWVBFK1BST1BMSVNULgogQ3VycmVudGx5IG9ubHkgY2xpZW50 IG1vZGUgaXMgc3VwcG9ydGVkLiAgUmV0dXJuIGEgc3VjY2Vzcy9mYWlsdXJlCkBAIC0xODEzLDYg KzE4NzAsMTkgQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19i b290LCAzLCAzLCAwLAogOmNvbXBsZXRlLW5lZ290aWF0aW9uLCBpZiBub24tbmlsLCB3aWxsIG1h a2UgbmVnb3RpYXRpb24gY29tcGxldGUKIGJlZm9yZSByZXR1cm5pbmcgZXZlbiBvbiBub24tYmxv Y2tpbmcgc29ja2V0cy4KIAorOnBhc3MsIHRoZSBwYXNzd29yZCBvZiB0aGUgcHJpdmF0ZSBrZXkg YXMgcGVyIEdudVRMUycKK2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIuCisK KzpmbGFncywgYSBsaXN0IG9mIHN5bWJvbHMgcmVsYXRpbmcgdG8gOnBhc3MsIGVhY2ggc3BlY2lm eWluZyBhIGZsYWc6CitHTlVUTFNfUEtDU19QTEFJTiwgR05VVExTX1BLQ1NfUEtDUzEyXzNERVMs CitHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiwgR05VVExTX1BLQ1NfUEtDUzEyX1JDMl80MCwK K0dOVVRMU19QS0NTX1BCRVMyXzNERVMsIEdOVVRMU19QS0NTX1BCRVMyX0FFU18xMjgsCitHTlVU TFNfUEtDU19QQkVTMl9BRVNfMTkyLCBHTlVUTFNfUEtDU19QQkVTMl9BRVNfMjU2LAorR05VVExT X1BLQ1NfTlVMTF9QQVNTV09SRCwgR05VVExTX1BLQ1NfUEJFUzJfREVTLAorR05VVExTX1BLQ1Nf UEJFUzJfREVTX01ENSwgR05VVExTX1BLQ1NfUEJFUzJfR09TVF9UQzI2WiwKK0dOVVRMU19QS0NT X1BCRVMyX0dPU1RfQ1BBLCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQiwKK0dOVVRMU19QS0NT X1BCRVMyX0dPU1RfQ1BDLCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQRC4KKwogVGhlIGRlYnVn IGxldmVsIHdpbGwgYmUgc2V0IGZvciB0aGlzIHByb2Nlc3MgQU5EIGdsb2JhbGx5IGZvciBHbnVU TFMuCiBTbyBpZiB5b3Ugc2V0IGl0IGhpZ2hlciBvciBsb3dlciBhdCBhbnkgcG9pbnQsIGl0IGFm ZmVjdHMgZ2xvYmFsCiBkZWJ1Z2dpbmcuCkBAIC0xODI1LDYgKzE4OTUsOSBAQCBERUZVTiAoImdu dXRscy1ib290IiwgRmdudXRsc19ib290LCBTZ251dGxzX2Jvb3QsIDMsIDMsIDAsCiBmdW5jdGlv bnMgYXJlIHVzZWQuICBUaGlzIGZ1bmN0aW9uIGFsbG9jYXRlcyByZXNvdXJjZXMgd2hpY2ggY2Fu IG9ubHkKIGJlIGRlYWxsb2NhdGVkIGJ5IGNhbGxpbmcgYGdudXRscy1kZWluaXQnIG9yIGJ5IGNh bGxpbmcgaXQgYWdhaW4uCiAKK1RoZSA6cGFzcyBhbmQgOmZsYWdzIGtleXMgYXJlIGlnbm9yZWQg d2l0aCBvbGQgdmVyc2lvbnMgb2YgR251VExTLCBhbmQKKzpmbGFncyBpcyBpZ25vcmVkIGlmIDpw YXNzIGlzIG5vdCBzcGVjaWZpZWQuCisKIFRoZSBjYWxsYmFja3MgYWxpc3QgY2FuIGhhdmUgYSBg dmVyaWZ5JyBrZXksIGFzc29jaWF0ZWQgd2l0aCBhCiB2ZXJpZmljYXRpb24gZnVuY3Rpb24gKFVO VVNFRCkuCiAKQEAgLTE4NDgsNiArMTkyMSw4IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251 dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAgTGlzcF9PYmplY3QgdHJ1c3RmaWxl czsKICAgTGlzcF9PYmplY3QgY3JsZmlsZXM7CiAgIExpc3BfT2JqZWN0IGtleWxpc3Q7CisgIExp c3BfT2JqZWN0IHBhc3M7CisgIExpc3BfT2JqZWN0IGZsYWdzOwogICAvKiBMaXNwX09iamVjdCBj YWxsYmFja3M7ICovCiAgIExpc3BfT2JqZWN0IGxvZ2xldmVsOwogICBMaXNwX09iamVjdCBob3N0 bmFtZTsKQEAgLTE4NzcsNiArMTk1Miw4IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxz X2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKICAgY3JsZmlsZXMgICAgICAgICAgICAgID0g cGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNjcmxmaWxlcyk7CiAgIGxvZ2xldmVsICAgICAgICAgICAg ICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDbG9nbGV2ZWwpOwogICBwcmltZV9iaXRzICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ21pbl9wcmltZV9iaXRzKTsKKyAgcGFzcyAg ICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNwYXNzKTsKKyAgZmxhZ3Mg ICAgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNmbGFncyk7CiAKICAgaWYg KCFTVFJJTkdQIChob3N0bmFtZSkpCiAgICAgewpAQCAtMjAzOCw4ICsyMTE1LDE3IEBAIERFRlVO ICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwgMywgMywgMCwKIAkg ICAgICBrZXlmaWxlID0gYW5zaV9lbmNvZGVfZmlsZW5hbWUgKGtleWZpbGUpOwogCSAgICAgIGNl cnRmaWxlID0gYW5zaV9lbmNvZGVfZmlsZW5hbWUgKGNlcnRmaWxlKTsKICMgZW5kaWYKKyMgaWZk ZWYgSEFWRV9HTlVUTFNfQ0VSVElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJTEUyCisJICAgICAgaWYg KFNUUklOR1AgKHBhc3MpKQorCQlyZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfa2V5 X2ZpbGUyCisJCSAgKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5Zmls ZSksIGZpbGVfZm9ybWF0LCBTU0RBVEEgKHBhc3MpLCBrZXlfZmlsZTJfYXV4IChmbGFncykpOwor CSAgICAgIGVsc2UKKwkJcmV0ID0gZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxl CisJCSAgKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5ZmlsZSksIGZp bGVfZm9ybWF0KTsKKyMgZWxzZQogCSAgICAgIHJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRf eDUwOV9rZXlfZmlsZQogCQkoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChr ZXlmaWxlKSwgZmlsZV9mb3JtYXQpOworIyBlbmRpZgogCiAJICAgICAgaWYgKHJldCA8IEdOVVRM U19FX1NVQ0NFU1MpCiAJCXJldHVybiBnbnV0bHNfbWFrZV9lcnJvciAocmV0KTsKQEAgLTI4NjAs OCArMjk0NiwyNiBAQCBzeW1zX29mX2dudXRscyAodm9pZCkKICAgREVGU1lNIChRQ21pbl9wcmlt ZV9iaXRzLCAiOm1pbi1wcmltZS1iaXRzIik7CiAgIERFRlNZTSAoUUNsb2dsZXZlbCwgIjpsb2ds ZXZlbCIpOwogICBERUZTWU0gKFFDY29tcGxldGVfbmVnb3RpYXRpb24sICI6Y29tcGxldGUtbmVn b3RpYXRpb24iKTsKKyAgREVGU1lNIChRQ3Bhc3MsICI6cGFzcyIpOworICBERUZTWU0gKFFDZmxh Z3MsICI6ZmxhZ3MiKTsKICAgREVGU1lNIChRQ3ZlcmlmeV9mbGFncywgIjp2ZXJpZnktZmxhZ3Mi KTsKICAgREVGU1lNIChRQ3ZlcmlmeV9lcnJvciwgIjp2ZXJpZnktZXJyb3IiKTsKKyAgREVGU1lN IChRZ251dGxzX3BrY3NfcGxhaW4sICJHTlVUTFNfUEtDU19QTEFJTiIpOworICBERUZTWU0gKFFn bnV0bHNfcGtjc19wa2NzMTJfM2RlcywgIkdOVVRMU19QS0NTX1BLQ1MxMl8zREVTIik7CisgIERF RlNZTSAoUWdudXRsc19wa2NzX3BrY3MxMl9hcmNmb3VyLCAiR05VVExTX1BLQ1NfUEtDUzEyX0FS Q0ZPVVIiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGtjczEyX3JjMl80MCwgIkdOVVRMU19Q S0NTX1BLQ1MxMl9SQzJfNDAiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfM2Rlcywg IkdOVVRMU19QS0NTX1BCRVMyXzNERVMiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJf YWVzXzEyOCwgIkdOVVRMU19QS0NTX1BCRVMyX0FFU18xMjgiKTsKKyAgREVGU1lNIChRZ251dGxz X3BrY3NfcGJlczJfYWVzXzE5MiwgIkdOVVRMU19QS0NTX1BCRVMyX0FFU18xOTIiKTsKKyAgREVG U1lNIChRZ251dGxzX3BrY3NfcGJlczJfYWVzXzI1NiwgIkdOVVRMU19QS0NTX1BCRVMyX0FFU18y NTYiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfbnVsbF9wYXNzd29yZCwgIkdOVVRMU19QS0NT X05VTExfUEFTU1dPUkQiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZGVzLCAiR05V VExTX1BLQ1NfUEJFUzJfREVTIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMxX2Rlc19t ZDUsICJHTlVUTFNfUEtDU19QQkVTMV9ERVNfTUQ1Iik7CisgIERFRlNZTSAoUWdudXRsc19wa2Nz X3BiZXMyX2dvc3RfdGMyNnosICJHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaIik7CisgIERF RlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BhLCAiR05VVExTX1BLQ1NfUEJFUzJfR09T VF9DUEEiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGIsICJHTlVUTFNf UEtDU19QQkVTMl9HT1NUX0NQQiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0 X2NwYywgIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDIik7CisgIERFRlNZTSAoUWdudXRsc19w a2NzX3BiZXMyX2dvc3RfY3BkLCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEQiKTsKIAogICBE RUZTWU0gKFFDY2lwaGVyX2lkLCAiOmNpcGhlci1pZCIpOwogICBERUZTWU0gKFFDY2lwaGVyX2Fl YWRfY2FwYWJsZSwgIjpjaXBoZXItYWVhZC1jYXBhYmxlIik7Ci0tIAoyLjM3LjMKCg== --00000000000055288e05e9c836f9-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 04:18:03 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 08:18:03 +0000 Received: from localhost ([127.0.0.1]:35862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odok7-0001ov-Gf for submit@debbugs.gnu.org; Thu, 29 Sep 2022 04:18:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odok5-0001oO-6J for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 04:18:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odojz-0004eA-Sq; Thu, 29 Sep 2022 04:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mqpX8CyXmMErGgYQB4nDszfMhmEPyUkVGzDJKr3UOmg=; b=DcMJyALMcD2r tOO8FGwxYOwus9pVElAm4jDeylMALGbVn9lQc8MTbILClxJ+XocHr+JC4Ao6sl0tTy3x/3Fht9XYy o4dOJVAtkGD4jq3a7oxEYtw4vR0SZhMN+8R+Ybcf3beq+ewel1+G+3rQD7lcUxQf7/1AxNF1OVB6P bpvLXSh18P1GbspMXy42IVVcu2Qik83U74U+3xLBJWGiY1rLomWSW2iOX9rYS4bq3Pi6cSS8bXN8d qLbQEqhZY66jiMoBgRaU3e6fDlrWv7i7jfkn7/WXg9Q68QzVOu7F9GqntauCKLIdDgAPAnuNFRi19 PpWo81pBFNptxvwNEupLtA==; Received: from [87.69.77.57] (port=1431 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odojy-0003g6-NU; Thu, 29 Sep 2022 04:17:55 -0400 Date: Thu, 29 Sep 2022 11:17:51 +0300 Message-Id: <83czbeh9w0.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Wed, 28 Sep 2022 23:09:46 -0400) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Wed, 28 Sep 2022 23:09:46 -0400 > Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii > > I also added "Copyright-paperwork-exempt: yes" (or will this require > paperwork?) The patch is large enough to require it, yes. Would you like me to send you the legal form to start the paperwork? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 05:02:59 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 09:02:59 +0000 Received: from localhost ([127.0.0.1]:35960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odpRa-00031G-UO for submit@debbugs.gnu.org; Thu, 29 Sep 2022 05:02:59 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:39886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odpRY-000312-LB for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 05:02:57 -0400 Received: by mail-wr1-f43.google.com with SMTP id cc5so1112137wrb.6 for <50507@debbugs.gnu.org>; Thu, 29 Sep 2022 02:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=JNsfWkZM99MqJ8sKmeqnYHH77uqHhllZfksAhOsS+zQ=; b=QPTTOw6BhuwZc1xZh1oZimWR276sKnhltIYVhl4N9xuK+SOm3fLA5sSw4tXwo4PDcX SBdTlKySaIcSaE/5r8w/RibWzgkiOUIhOJzWd+zRCQ2kVJNx1whT0kRZKvRZpvhyKlRA f4TVSnU8R7oCfqtk4BONSCAHJfJcxlH0dF2PZeAwDj/eFW33g1OzSbGw7yyyFCuGCXdD NAu3FfKijeF7GPGpJ05B7vqciozX/XQqfvJNtm4xn3EltgmqueNVi3w+HDViWio9uZrB F3bByz/l9qSa7W1/73yMSEVDTh6Vc1SMHKEMiuYu//0M1EsqKspZGdtV3ixqRYfqohCJ 6nZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=JNsfWkZM99MqJ8sKmeqnYHH77uqHhllZfksAhOsS+zQ=; b=X49a7i9SQh6QtDyFkvI5bG3PySQKJTuxPF49EyUR1/nuUxpsGzMGnirKKJ2h2nclqk P0PCndXh6/GHL+a6SXuD92AlhT9D0JzpqsnHE6KFyFXqhezhA7vIsVgblTYqe8Ts5WO0 jBbn3P6BLSaY+0GzZQIt5JD5vlepq0Xqd45Yv1NWkIVuKYZ3ugnDgz5uFD/EyEDEV191 JRnYd+p4JWOq3dnNLQ010cKXbVpNqb8+ETo8MSEDnUcdkx00f4gd5VVdpnf4JL0AfRwK YQNebfVSuNbM9sz3ONe69liCISPI3UAuzYKVxS0RM22nHXjJ3smASDir+cC/CdVOKU4U uG0w== X-Gm-Message-State: ACrzQf0kAGTecCvT432i8NEaZ5OW4LTEv2nV+hSNjE3bq0HrvPc+tsB8 oIytP+u/s/V95tW3+BzDHtI= X-Google-Smtp-Source: AMsMyM6H/ZIUszURJJjXC+fxR8QtqnzoCBeTw2uyQxo/Sv/B9LB4inHMbOHhen/eJdS9HLiVv5kcug== X-Received: by 2002:adf:cd10:0:b0:22c:a109:f51d with SMTP id w16-20020adfcd10000000b0022ca109f51dmr1414496wrm.238.1664442170585; Thu, 29 Sep 2022 02:02:50 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:8359:d07c:62db:a1ca]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c2cd200b003a63a3b55c3sm4120662wmc.14.2022.09.29.02.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 02:02:49 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Wed, 28 Sep 2022 23:09:46 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> Date: Thu, 29 Sep 2022 11:02:49 +0200 Message-ID: <87a66id03q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 28 Sep 2022 23:09:46 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> On Wed, Sep 28, 2022 at 9:11 AM Robert Pluim wrote: >>=20 >> >>>>> On Wed, 28 Sep 2022 08:15:26 -0400, Nikolaos Chatzikonstantino= u said: >>=20 >>=20 Nikolaos> Okay, I'm submitting this patch with corrections included, se= e attachment. >>=20 >> I see a .sig attachment, but no patch (we don=CA=BCt currently requi= re >> signing of commits at all, but I guess there=CA=BCs nothing stopping= people >> from doing it). Nikolaos> My bad, here it is. I also added "Copyright-paperwork-exempt:= yes" (or Nikolaos> will this require paperwork?) and gave the helper function st= atic Nikolaos> linkage in src/gnutls.c. Eli answered that. A few nits below Nikolaos> From b11707c423773f6234746991222acd80ab3f708c Mon Sep 17 00:0= 0:00 2001 Nikolaos> From: Nikolaos Chatzikonstantinou Nikolaos> Date: Mon, 26 Sep 2022 11:08:18 -0400 Nikolaos> Subject: [PATCH] add :pass and :flags to gnutls-boot for :key= list Nikolaos> * lisp/net/gnutls.el (gnutls-boot-parameters): add the keys := pass and Nikolaos> :flags, and update the documentation. Nikolaos> * src/gnutls.c (gnutls-boot): add the keys :pass and :flags, = and Nikolaos> update the documentation. Nikolaos> (syms_of_gnutls): add the symbols :pass, :flags, and the symb= ols that Nikolaos> correspond to the enumeration constants of the GnuTLS enum Nikolaos> `gnutls_pkcs_encrypt_flags_t`. Nikolaos> ; (key_file2_aux): private helper function that translates a = list of Nikolaos> ; symbols to its corresponding `unsigned int` value of the Gn= uTLS C Nikolaos> ; enum `gnutls_pkcs_encrypt_flags_t`. Each description of a change is a sentence, and should start with a capital letter. The lines starting with ';' should not start with ';' Nikolaos> +PASS is a string, the password of the key. Nikolaos> + Nikolaos> +FLAGS is an ORed sequence of gnutls_pkcs_encrypt_flags_t val= ues. Nikolaos> + This is now a list of symbols, so the docstring needs adjusting. Nikolaos> +/* Helper function for gnutls-boot. Nikolaos> + Nikolaos> + The key :flags receives a lisp of symbols, each of which s/lisp/list/ Nikolaos> + corresponds to a GnuTLS C flag, the ORed result is to be = passed to Nikolaos> + the function gnutls_certificate_set_x509_key_file2() as i= ts last Nikolaos> + argument. Nikolaos> +*/ Nikolaos> +static unsigned int Nikolaos> +key_file2_aux (Lisp_Object flags) Nikolaos> +{ Nikolaos> + unsigned int rv =3D 0; Nikolaos> + Lisp_Object tail; Nikolaos> + for (tail =3D flags; CONSP (tail); tail =3D XCDR (tail)) We have some convenience macros in lisp.h for traversing lists, one of which is FOR_EACH_TAIL. The reason to prefer it is that it will detect circular lists, which is good practice since this list will come from the user level, so it could be anything :-) Also, the function is only relevant if HAVE_GNUTLS_CERTIFICATE_SET_X509_KEY_FILE2 is defined, so you could wrap it in a #ifdef Nikolaos> +The :pass and :flags keys are ignored with old versions of G= nuTLS, and Nikolaos> +:flags is ignored if :pass is not specified. Nikolaos> + Maybe mention that not specifying :flags or passing :flags nil means passing '0' to the GnuTLS function? Nikolaos> +# ifdef HAVE_GNUTLS_CERTIFICATE_SET_X509_KEY_FILE2 Nikolaos> + if (STRINGP (pass)) Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_fo= rmat, SSDATA (pass), key_file2_aux (flags)); I think you should re-wrap this line. Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pkcs12_3des, "GNUTLS_PKCS_PKCS12_3DES= "); Nikolaos> + DEFSYM (Qgnutls_pkcs_pkcs12_arcfour, "GNUTLS_PKCS_PKCS12_A= RCFOUR"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pkcs12_rc2_40, "GNUTLS_PKCS_PKCS12_RC= 2_40"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_3des, "GNUTLS_PKCS_PBES2_3DES"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_aes_128, "GNUTLS_PKCS_PBES2_AES= _128"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_aes_192, "GNUTLS_PKCS_PBES2_AES= _192"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_aes_256, "GNUTLS_PKCS_PBES2_AES= _256"); Nikolaos> + DEFSYM (Qgnutls_pkcs_null_password, "GNUTLS_PKCS_NULL_PASS= WORD"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_des, "GNUTLS_PKCS_PBES2_DES"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes1_des_md5, "GNUTLS_PKCS_PBES1_DES= _MD5"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_tc26z, "GNUTLS_PKCS_PBES2_= GOST_TC26Z"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpa, "GNUTLS_PKCS_PBES2_GO= ST_CPA"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpb, "GNUTLS_PKCS_PBES2_GO= ST_CPB"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpc, "GNUTLS_PKCS_PBES2_GO= ST_CPC"); Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PBES2_GO= ST_CPD"); All this is kind of awkward, but apart from doing DEFVAR_LISP I=CA=BCm not aware of how to define a lisp level symbol with a value (it would allow you to simplify `key_file2_aux', since you could just extract the values directly from the symbols). Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 08:36:01 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 12:36:01 +0000 Received: from localhost ([127.0.0.1]:36524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odsll-0001Df-5D for submit@debbugs.gnu.org; Thu, 29 Sep 2022 08:36:01 -0400 Received: from mail-yw1-f171.google.com ([209.85.128.171]:33750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odslh-0001DN-GQ for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 08:36:00 -0400 Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-354c7abf786so13208807b3.0 for <50507@debbugs.gnu.org>; Thu, 29 Sep 2022 05:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=LbM2EY89Cp4mmBYCInLnDpPPltZwecZT1gjRh5CRI9w=; b=XjhGB8503k792FH3cj+88x2sDwsVGWeYi1u2nL7rrQN9lrPTdTTdWGWEJoPR+y/TtH nCcTniTjnSIWxGf6AwB4FKDaajDxznp+GpU3mi7dTMfFWKZY/gntG+r9u5KZY5q1mpf8 isf7rrjXdkOU+1Ndgt777qP2fcjydgQgANvJctF9v+twsOKqxsLYBqUplzIUUjA8R9FD 6r0D0Ga8BNaUVTWz84KHkZ0GXjfmDJ+RB/ZOBx/uzpDz7ooOedKdsIR6t727FMNlQran XlRLu38LN6zwNqjco+nEwxVq3Uh3OCN7Q4YRDB80fDAR2SjABk2f8KXe9SVVpL+gaHKT qPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=LbM2EY89Cp4mmBYCInLnDpPPltZwecZT1gjRh5CRI9w=; b=5/P9E4p3a0dKhmKcJfmwrTbowNzSqPToQ5nWX/y6FCAvFXHVcvWFCSJs3viGHwqn9s CAoK2ja3k7HBqIt5paB2e1nQZvRCVz44+2pWWJg+hsjZnKABrpoJ1MzkXhe5T/v840Gy gytEgdaQVTwa71mI8NZSA9vLeB1mn8pVZBXfoMxHuAKCSRPElMEzEFUhw1p4V1jyvLU+ 9qLM9c2BOLQD+sF40eLHomjJV0M4nJ07eplg3qePUFvmQ190tTdnUd7dlbS0RQdo9W9Y LaG7FZ3gxiQb2cJUMWauaXshrpD/PfGJjkWjdW8lMGr/qMPsSsGrMprzJR+HnOh3N1Ez 8e5Q== X-Gm-Message-State: ACrzQf2A4WVhwRqDs1DwUeieq1hVDUPdmen/Gd4JB9zrnC9Y8Ekv1gry seWj18wmiiAaWWyw9SOvAMSsNbl5pXuocLRYk8c= X-Google-Smtp-Source: AMsMyM7vr0aEkDbmxFLO/GAZbCC6q19ta9pI3oft/7miu27etwwLYGZ0kJChWbqvj+FIlehkwX61r8xWgbjjgxiujN0= X-Received: by 2002:a81:1455:0:b0:354:e564:214f with SMTP id 82-20020a811455000000b00354e564214fmr2570701ywu.297.1664454951828; Thu, 29 Sep 2022 05:35:51 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <83czbeh9w0.fsf@gnu.org> In-Reply-To: <83czbeh9w0.fsf@gnu.org> From: Nikolaos Chatzikonstantinou Date: Thu, 29 Sep 2022 08:35:40 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Thu, Sep 29, 2022 at 4:17 AM Eli Zaretskii wrote: > > > From: Nikolaos Chatzikonstantinou > > Date: Wed, 28 Sep 2022 23:09:46 -0400 > > Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii > > > > I also added "Copyright-paperwork-exempt: yes" (or will this require > > paperwork?) > > The patch is large enough to require it, yes. > > Would you like me to send you the legal form to start the paperwork? > > Thanks. Yes, please send me the legal form. Regards, Nikolaos Chatzikonstantinou From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 09:09:05 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 13:09:05 +0000 Received: from localhost ([127.0.0.1]:36595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odtHl-0004Jv-KE for submit@debbugs.gnu.org; Thu, 29 Sep 2022 09:09:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odtHh-0004JK-P7 for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 09:09:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odtHc-0000Oc-E6; Thu, 29 Sep 2022 09:08:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zCqx89caQwT6s2xxfgj7GnEh3vs9W/Kt9OCcR2GgEoQ=; b=Qc3gXOQblxOy xcYMjNS6AOWe4ta32b3vJDyFRoYSTHCgw0J7es/VLYOsi57tYrSkNYzVyAs45DLrGZPrICruz2m+i fBLyfzPBdljIn4mJGEnjLNMmW12KJsN9BXzc4ZckrQw+G9/jqYtuNKQcnIXhZjrTOqgNXm+E0Op5+ p6MyAufKyps3+q0OwOoLa9/uT94kWwnqbrjVyjGa8kKs0mEFpLY6AOVINt8tirUTaqtMWa3HNB6cY 0u7xLrMcpIVismK+uuQUeg++jLHL3HPYU/jJJW59iwZlIwN25yEn+peZEKwg9EQeQRjVEJdCgfhEO x/bXArXB++5gr9w4+TqM/Q==; Received: from [87.69.77.57] (port=3682 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odtHb-00061h-Lj; Thu, 29 Sep 2022 09:08:55 -0400 Date: Thu, 29 Sep 2022 16:08:50 +0300 Message-Id: <83r0zufhul.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Thu, 29 Sep 2022 08:35:40 -0400) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <83czbeh9w0.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Thu, 29 Sep 2022 08:35:40 -0400 > Cc: rpluim@gmail.com, 50507@debbugs.gnu.org, larsi@gnus.org > > On Thu, Sep 29, 2022 at 4:17 AM Eli Zaretskii wrote: > > > > > From: Nikolaos Chatzikonstantinou > > > Date: Wed, 28 Sep 2022 23:09:46 -0400 > > > Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii > > > > > > I also added "Copyright-paperwork-exempt: yes" (or will this require > > > paperwork?) > > > > The patch is large enough to require it, yes. > > > > Would you like me to send you the legal form to start the paperwork? > > > > Thanks. > > Yes, please send me the legal form. Form sent off-list. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 09:44:28 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 13:44:28 +0000 Received: from localhost ([127.0.0.1]:36691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odtq0-0005G4-Dt for submit@debbugs.gnu.org; Thu, 29 Sep 2022 09:44:28 -0400 Received: from mail-yw1-f179.google.com ([209.85.128.179]:45812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odtpy-0005Fq-7R for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 09:44:27 -0400 Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-3539c6f39d7so14656967b3.12 for <50507@debbugs.gnu.org>; Thu, 29 Sep 2022 06:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=USRXRTnSbfOxayigLekpF/21dVyRKh2lXazStoQghb0=; b=MZMpKF7By2dGW6dsyC6oo2fmqjQ5wIjsszTwfbXYu97iW+Is39ITb2Qwn5qf+PGN7h VviRyHnZoAnS3hIhghbZytNqFxg/YV42w4TG6CrZsDTMYVNCyrND8fZlBLE8n8U/kZhE qCPdBOJeR5zKcZhfcf35QeTWUJv97L7VBTfRJTbQQlgmBskZV8icXk+ZpxwDCSiGetpO 6gywRaZSLz9FylV4neZCleybrzwonDLE+CCzks091uqf1XCtEK1FTtReGvHFOjJtTgeu kq3S6BaQFYdBLJaOhAsE9VJdroF2tdpmpzh5qFqIvOXAiHKpqB0NT4+/ZG60O3L2jY21 uj6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=USRXRTnSbfOxayigLekpF/21dVyRKh2lXazStoQghb0=; b=LFoM/UgHA7zoi+gKVCJekGJJ6uepmSr5EynQ60WacNhRwhscH3Lm0wafu5bdi5OOKR SxCBzefQb7N5XZnah3cvVNUHLizozGxnMqbRmkQiWHs54Qekx1uaO/fcJCT20Gf5Pw/5 LgO9pVHxiPg7cNcE/EMPexsHPvSs1Osq+0PL4AhPuK2tvs/26u/h54FwZlyYw0aXVhTW WbVRDtWcI0nT0q0Dsh0KCqHd7g1ChCD7DypRV5/yK3kSfDWTcNtPKfdF1AkmbWTs8rpq S5B/Pqb9Awt+UCcKh1zM/C3+OMO9WUvaJxx1H5+t3BV3ZbdWAXFPjrkh7FpMe9zZ0soa os/Q== X-Gm-Message-State: ACrzQf1qvqv52NSP0hqhLrh3HILvHyQm+0f9iuEqc7+SIKfNjKF6fbId VE/qmG8NVpOqKQYwMgtDfeXnrCMtxrE5t1UnjwY= X-Google-Smtp-Source: AMsMyM5yaqGYulnrA9eKK0xVJSl97t6BwnNDbZxIO1D0DLCnyYhoaRZXw9CssE4h2Qt7g5K2YN4UWMEy7o811q3a5ek= X-Received: by 2002:a81:54c5:0:b0:353:889c:5ea1 with SMTP id i188-20020a8154c5000000b00353889c5ea1mr3240061ywb.331.1664459060610; Thu, 29 Sep 2022 06:44:20 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> In-Reply-To: <87a66id03q.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Thu, 29 Sep 2022 09:44:09 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Thu, Sep 29, 2022 at 5:02 AM Robert Pluim wrote: > > >>>>> On Wed, 28 Sep 2022 23:09:46 -0400, Nikolaos Chatzikonstantinou said: > > Nikolaos> From b11707c423773f6234746991222acd80ab3f708c Mon Sep 17 00= :00:00 2001 > Nikolaos> From: Nikolaos Chatzikonstantinou > Nikolaos> Date: Mon, 26 Sep 2022 11:08:18 -0400 > Nikolaos> Subject: [PATCH] add :pass and :flags to gnutls-boot for :k= eylist > > Nikolaos> + corresponds to a GnuTLS C flag, the ORed result is to b= e passed to > Nikolaos> + the function gnutls_certificate_set_x509_key_file2() as= its last > Nikolaos> + argument. > Nikolaos> +*/ > Nikolaos> +static unsigned int > Nikolaos> +key_file2_aux (Lisp_Object flags) > Nikolaos> +{ > Nikolaos> + unsigned int rv =3D 0; > Nikolaos> + Lisp_Object tail; > Nikolaos> + for (tail =3D flags; CONSP (tail); tail =3D XCDR (tail)) > > We have some convenience macros in lisp.h for traversing lists, one of > which is FOR_EACH_TAIL. The reason to prefer it is that it will detect > circular lists, which is good practice since this list will come from > the user level, so it could be anything :-) Good point. I opted for FOR_EACH_TAIL_SAFE, which seems even better for this case. As documented in ChangeLog.3, it's the right one when the operation is idempotent, which an OR of flags is. (repeated flags do not alter the result.) > Nikolaos> +The :pass and :flags keys are ignored with old versions of= GnuTLS, and > Nikolaos> +:flags is ignored if :pass is not specified. > Nikolaos> + > > Maybe mention that not specifying :flags or passing :flags nil means > passing '0' to the GnuTLS function? Yes, and on that note, I discovered two things. One, the value 0 is special; it has meaning but it is not an enumeration constant. I documented this appropriately. Two, the password may be NULL instead of a string. How can I differentiate between `:pass nil` and not specifying `:pass`? I would like to do this because in the former case I'm calling ...key_file2() and in the latter I'm calling the original ...key_file(). > Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); > Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PBES2_= GOST_CPD"); > > All this is kind of awkward, but apart from doing DEFVAR_LISP I=CA=BCm no= t > aware of how to define a lisp level symbol with a value (it would > allow you to simplify `key_file2_aux', since you could just extract > the values directly from the symbols). I am now comparing against intern("GNUTLS_PKCS_PLAIN") and so on. I will hold off the submission of the final patch until I figure out the :pass issue that I mentioned above. Regards, Nikolaos Chatzikonstantinou From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 29 10:08:46 2022 Received: (at 50507) by debbugs.gnu.org; 29 Sep 2022 14:08:46 +0000 Received: from localhost ([127.0.0.1]:39165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oduDW-0006WA-2m for submit@debbugs.gnu.org; Thu, 29 Sep 2022 10:08:46 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:42528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oduDT-0006Vn-M0 for 50507@debbugs.gnu.org; Thu, 29 Sep 2022 10:08:44 -0400 Received: by mail-wr1-f51.google.com with SMTP id l18so2376503wrw.9 for <50507@debbugs.gnu.org>; Thu, 29 Sep 2022 07:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=3/J1pOh2bVAaaz84KMSMYMTKKPHTI7iiv1bcCRZExhE=; b=SyasdLpBETnhIUgTUDTah0FSZ0IiBDUvsrash3olqS9oI5TCurLojWHCaINj9mU/gw 94D/5J2fE2pIETO+iBRjlBT5ean187ZSKmXKHiSzsVD+dhUG5puu0GI77Z7wV+RtMgWj JEiUfYMgvxwo3EykEainOj1xhQvO9YCW14cipIo7Lejw2bnsBzKh9rJuxWYkx6j4jxZz BwQoi/9ZEeQ5TvIGTYPXMc9C1OTYMsyacEmPxUO27pdc23yqHp/jF83RE0QNoiCxlY6f V1VL/kbSyFRor/GypmroNTQnPbjuMBdr5K8eVmkuCPnlKMiBZJWwRZR5nEkGfySLHs2h eDQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=3/J1pOh2bVAaaz84KMSMYMTKKPHTI7iiv1bcCRZExhE=; b=rOFxAvceXVEK9V3W1k5Ngm/ZSXq2DlQj11HbP0O9AduG/CQFT/ONnHIr69w4guyldR 4QKoqtR28Kb0g85pMSIDt7GnkEJ2bpM0XFL/kKmEeXkIDCEP7PyG6RKzQamn0yXC8/5Y Rq7GFS33mXtyWoW55bjAXU+ijgzRMcbWNOIIoCJXXKJ9jzW25AZtbtlZ3ZPS3Eok6f1r mKDr3Xe+S9/p+MA37pgfBIL/kpULanKaVnV6d7Fp93S0+1FHvgnM9l7GK+jBcoBl7Zlc LcWTBPMjizUR+peJNdAcK3JT2JhKCCRpN76jCX6y72HJBDVyOhcXjJinx7vjue4jL4nw NQug== X-Gm-Message-State: ACrzQf23dZ9BLnX4Id+8pZUxaGhg4mQ+AIBhlOZjoMKCR23It+flVGjw UwTW3vzNO47we9YQTX/gHKo= X-Google-Smtp-Source: AMsMyM5obn2Xg04UEMIOvSasrplbOCyGemR15GaxwAvv9rBOH/udlJWW98zrs/3FF8MrWERd5SRJng== X-Received: by 2002:a05:6000:154e:b0:22a:3177:1985 with SMTP id 14-20020a056000154e00b0022a31771985mr2541755wry.117.1664460516693; Thu, 29 Sep 2022 07:08:36 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:8359:d07c:62db:a1ca]) by smtp.gmail.com with ESMTPSA id q17-20020a05600c46d100b003b56be51138sm4374084wmo.31.2022.09.29.07.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Sep 2022 07:08:35 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Thu, 29 Sep 2022 09:44:09 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> Date: Thu, 29 Sep 2022 16:08:35 +0200 Message-ID: <875yh6cly4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 29 Sep 2022 09:44:09 -0400, Nikolaos Chatzikonstantinou said: >>=20 >> We have some convenience macros in lisp.h for traversing lists, one = of >> which is FOR_EACH_TAIL. The reason to prefer it is that it will dete= ct >> circular lists, which is good practice since this list will come from >> the user level, so it could be anything :-) Nikolaos> Good point. I opted for FOR_EACH_TAIL_SAFE, which seems even = better Nikolaos> for this case. As documented in ChangeLog.3, it's the right o= ne when Nikolaos> the operation is idempotent, which an OR of flags is. (repeat= ed flags Nikolaos> do not alter the result.) OK Nikolaos> +The :pass and :flags keys are ignored with old versions of G= nuTLS, and Nikolaos> +:flags is ignored if :pass is not specified. Nikolaos> + >>=20 >> Maybe mention that not specifying :flags or passing :flags nil means >> passing '0' to the GnuTLS function? Nikolaos> Yes, and on that note, I discovered two things. One, the valu= e 0 is Nikolaos> special; it has meaning but it is not an enumeration constant= . I Nikolaos> documented this appropriately. Two, the password may be NULL = instead Nikolaos> of a string. OK. I guess you=CA=BCre mapping ':pass nil' to that? Nikolaos> How can I differentiate between `:pass nil` and not specifying Nikolaos> `:pass`? I would like to do this because in the former case I= 'm Nikolaos> calling ...key_file2() and in the latter I'm calling the orig= inal Nikolaos> ...key_file(). You=CA=BCd do `plist-member' to check if there=CA=BCs a `:pass' in the plis= t at all, and then `plist-get' to extract the value. Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); Nikolaos> Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PBES2_GO= ST_CPD"); >>=20 >> All this is kind of awkward, but apart from doing DEFVAR_LISP I=CA= =BCm not >> aware of how to define a lisp level symbol with a value (it would >> allow you to simplify `key_file2_aux', since you could just extract >> the values directly from the symbols). Nikolaos> I am now comparing against intern("GNUTLS_PKCS_PLAIN") and so= on. I guess that=CA=BCs another option, but it=CA=BCs not the preferred solution. Anyway, let=CA=BCs not let the perfect be the enemy of the good. Thanks Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 06:04:52 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 10:04:52 +0000 Received: from localhost ([127.0.0.1]:40548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeCt1-0003V7-4w for submit@debbugs.gnu.org; Fri, 30 Sep 2022 06:04:51 -0400 Received: from mail-yw1-f175.google.com ([209.85.128.175]:34377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeCsx-0003Ut-Ji for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 06:04:49 -0400 Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-351cee25568so39812237b3.1 for <50507@debbugs.gnu.org>; Fri, 30 Sep 2022 03:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=WTGXiY3OPNXJdCfL1ijBOIqiey5A5QI1Z4xGeXekS3Y=; b=i/PMn0OV6n98LOHMXdYsHAIrQ8h/F1E/pl3MRDIK+9KdQyhz3o39UHMo34a/9qKEwb lrXwcVErS5oQsvbZqn+rENIa5ZBUU4D1l/3Y+TPO5o/U3Udc7AsRaIWLXlTvUsehOf7U sxCtUJqLtJwDlbrCR+9z9EXO0Msr6Nw+btoeZqXcBGE6jmNVeCFtHzwnt2SbV3CIQ4MV DxsNYwhzivzvQPqlKwSDZwwQ9G0KeexnRd/yWmErwBkrEUbVkzXrMLPjC/cdlGp1JP7b 531PLf7LROOLQwV9D+TwcHNgr7zw7EOkgXXg396Sal1pHYTpI4OvBngGjFhy9PC6r9uA EjkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=WTGXiY3OPNXJdCfL1ijBOIqiey5A5QI1Z4xGeXekS3Y=; b=ZLLelqtG46LHovrEanxAsXj6fdA6ndi3yvAYjuxJvveZ1gzBEl2mJYyygDMWCHvBwm dwmgw1SdLBF0qd3nfB8cZmB5JQtSb5PR0V9en4vYcyRLttklGUCgnNiHGzbwGrnprhdx Tp3jfVmHPapqgAosRxT7EHL4W2bwixJSsg7HspAxfj2YVME3z2qH59VGQcCIUD35crKq 0g5q74xMGK3OXI/VJgOteo4uBObqqbdfYVhgqQLT5klIdu2ZUI9ReKw4C01/7VEINJen kFD2z3CfWqei40ek6PoboIfxhpa52g/llrJZA95inulJi2HWym5NtgeOB10fxvVtR0gt FnjQ== X-Gm-Message-State: ACrzQf03YU73mVfB9f+/i0X9Ywjlwhsw6e7NOJe1lcCxzjH7kecwv/q2 62/dSHpWAHCy1MbPxK4yirPYDSycoH1k38HCIxk= X-Google-Smtp-Source: AMsMyM4dlYzk5MYJVZn8I6qD7UN6s5AyivD36jOLSSgESMLP1LylO830IF2gMTqTDaF53n4Ze1mRPI+D0d2LyYcLyBQ= X-Received: by 2002:a81:1455:0:b0:354:e564:214f with SMTP id 82-20020a811455000000b00354e564214fmr7307448ywu.297.1664532281950; Fri, 30 Sep 2022 03:04:41 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> In-Reply-To: <875yh6cly4.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Fri, 30 Sep 2022 06:04:30 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: multipart/mixed; boundary="0000000000006251dc05e9e21fe7" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000006251dc05e9e21fe7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 29, 2022 at 10:08 AM Robert Pluim wrote: > > >>>>> On Thu, 29 Sep 2022 09:44:09 -0400, Nikolaos Chatzikonstantinou said: > Nikolaos> +The :pass and :flags keys are ignored with old versions of= GnuTLS, and > Nikolaos> +:flags is ignored if :pass is not specified. > Nikolaos> + > >> > >> Maybe mention that not specifying :flags or passing :flags nil mea= ns > >> passing '0' to the GnuTLS function? > > Nikolaos> Yes, and on that note, I discovered two things. One, the va= lue 0 is > Nikolaos> special; it has meaning but it is not an enumeration consta= nt. I > Nikolaos> documented this appropriately. Two, the password may be NUL= L instead > Nikolaos> of a string. > > OK. I guess you=CA=BCre mapping ':pass nil' to that? Yes. > Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); > Nikolaos> > Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PBES2_= GOST_CPD"); > >> > >> All this is kind of awkward, but apart from doing DEFVAR_LISP I=CA= =BCm not > >> aware of how to define a lisp level symbol with a value (it would > >> allow you to simplify `key_file2_aux', since you could just extrac= t > >> the values directly from the symbols). > > Nikolaos> I am now comparing against intern("GNUTLS_PKCS_PLAIN") and = so on. > > I guess that=CA=BCs another option, but it=CA=BCs not the preferred > solution. Anyway, let=CA=BCs not let the perfect be the enemy of the good= . I went with intern. There were some additional #if checks to avoid dynamically loading the symbol on library Windows if it is not available. I used plist_member() to differentiate between `:pass nil` and not specifying `:pass`, and I documented this in the docstrings. Regards, Nikolaos Chatzikonstantinou --0000000000006251dc05e9e21fe7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8obiz6c0 RnJvbSAzMTAwYzE3Zjg0NTVhMzg5NGNhMjdjOTg3MjU0OGRhYTFhMWZiOTA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxp c3QKCiogbGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogQWRkIHRo ZSBrZXlzIDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiog c3JjL2dudXRscy5jIChnbnV0bHMtYm9vdCk6IEFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdz LCBhbmQKdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBBZGQgdGhl IHN5bWJvbHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0 byB0aGUgZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190YC4KKGtleV9maWxlMl9hdXgpOiBQcml2YXRlIGhlbHBlciBmdW5j dGlvbiB0aGF0IHRyYW5zbGF0ZXMgYSBsaXN0IG9mCnN5bWJvbHMgdG8gaXRzIGNvcnJlc3BvbmRp bmcgYHVuc2lnbmVkIGludGAgdmFsdWUgb2YgdGhlIEdudVRMUyBDIGVudW0KYGdudXRsc19wa2Nz X2VuY3J5cHRfZmxhZ3NfdGAuCi0tLQogbGlzcC9uZXQvZ251dGxzLmVsIHwgIDEwICsrKysrCiBz cmMvZ251dGxzLmMgICAgICAgfCAxMDUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDExNSBpbnNlcnRpb25zKCspCgpkaWZmIC0t Z2l0IGEvbGlzcC9uZXQvZ251dGxzLmVsIGIvbGlzcC9uZXQvZ251dGxzLmVsCmluZGV4IDZlMzg0 NWFlYzEuLmVlZjY1NTlhOTUgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2dudXRscy5lbAorKysgYi9s aXNwL25ldC9nbnV0bHMuZWwKQEAgLTI2NSw2ICsyNjUsNyBAQCBnbnV0bHMtYm9vdC1wYXJhbWV0 ZXJzCiAgICAgICAgICAgICZrZXkgdHlwZSBob3N0bmFtZSBwcmlvcml0eS1zdHJpbmcKICAgICAg ICAgICAgdHJ1c3RmaWxlcyBjcmxmaWxlcyBrZXlsaXN0IG1pbi1wcmltZS1iaXRzCiAgICAgICAg ICAgIHZlcmlmeS1mbGFncyB2ZXJpZnktZXJyb3IgdmVyaWZ5LWhvc3RuYW1lLWVycm9yCisgICAg ICAgICAgIHBhc3MgZmxhZ3MKICAgICAgICAgICAgJmFsbG93LW90aGVyLWtleXMpCiAgICJSZXR1 cm4gYSBrZXl3b3JkIGxpc3Qgb2YgcGFyYW1ldGVycyBzdWl0YWJsZSBmb3IgcGFzc2luZyB0byBg Z251dGxzLWJvb3QnLgogCkBAIC0yODEsNiArMjgyLDEzIEBAIGdudXRscy1ib290LXBhcmFtZXRl cnMKIFZFUklGWS1IT1NUTkFNRS1FUlJPUiBpcyBhIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5IG9w dGlvbiBmb3IKIHB1dHRpbmcgYDpob3N0bmFtZScgaW4gVkVSSUZZLUVSUk9SLgogCitQQVNTIGlz IGEgc3RyaW5nLCB0aGUgcGFzc3dvcmQgb2YgdGhlIGtleS4gIEl0IG1heSBhbHNvIGJlIG5pbCwK K2ZvciBhIE5VTEwgcGFzc3dvcmQuCisKK0ZMQUdTIGlzIGEgbGlzdCBvZiBzeW1ib2xzIGNvcnJl c3BvbmRpbmcgdG8gdGhlIGVxdWl2YWxlbnQgT1JlZAorYml0ZmxhZyBvZiB0aGUgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190IGVudW0gb2YgR251VExTLiAgVGhlCitlbXB0eSBsaXN0IGNvcnJl c3BvbmRzIHRvIHRoZSBiaXRmbGFnIHdpdGggdmFsdWUgMC4KKwogV2hlbiBWRVJJRlktRVJST1Ig aXMgdCBvciBhIGxpc3QgY29udGFpbmluZyBgOnRydXN0ZmlsZXMnLCBhbgogZXJyb3Igd2lsbCBi ZSByYWlzZWQgd2hlbiB0aGUgcGVlciBjZXJ0aWZpY2F0ZSB2ZXJpZmljYXRpb24gZmFpbHMKIGFz IHBlciBHbnVUTFMnIGdudXRsc19jZXJ0aWZpY2F0ZV92ZXJpZnlfcGVlcnMyLiAgT3RoZXJ3aXNl LCBvbmx5CkBAIC0zNTgsNiArMzY2LDggQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVycwogICAgICAg ICAgICAgICAgIDprZXlsaXN0ICxrZXlsaXN0CiAgICAgICAgICAgICAgICAgOnZlcmlmeS1mbGFn cyAsdmVyaWZ5LWZsYWdzCiAgICAgICAgICAgICAgICAgOnZlcmlmeS1lcnJvciAsdmVyaWZ5LWVy cm9yCisgICAgICAgICAgICAgICAgOnBhc3MgLHBhc3MKKyAgICAgICAgICAgICAgICA6ZmxhZ3Mg LGZsYWdzCiAgICAgICAgICAgICAgICAgOmNhbGxiYWNrcyBuaWwpKSkKIAogKGRlZnVuIGdudXRs cy0tZ2V0LWZpbGVzIChmaWxlcykKZGlmZiAtLWdpdCBhL3NyYy9nbnV0bHMuYyBiL3NyYy9nbnV0 bHMuYwppbmRleCBhMGRlMDIzOGM0Li5jY2ZiYjU4ODgxIDEwMDY0NAotLS0gYS9zcmMvZ251dGxz LmMKKysrIGIvc3JjL2dudXRscy5jCkBAIC0zNCw2ICszNCw3IEBACiAjIGVuZGlmCiAKICMgaWYg R05VVExTX1ZFUlNJT05fTlVNQkVSID49IDB4MDMwMjAwCisjICBkZWZpbmUgSEFWRV9HTlVUTFNf Q0VSVElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJTEUyCiAjICBkZWZpbmUgSEFWRV9HTlVUTFNfQ0lQ SEVSX0dFVF9JVl9TSVpFCiAjIGVuZGlmCiAKQEAgLTEyMSw2ICsxMjIsMTEgQEAgREVGX0RMTF9G TiAoaW50LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUsCiBERUZfRExMX0ZO IChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZSwKIAkgICAgKGdudXRs c19jZXJ0aWZpY2F0ZV9jcmVkZW50aWFsc190LCBjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKiwK IAkgICAgIGdudXRsc194NTA5X2NydF9mbXRfdCkpOworIyAgaWZkZWYgSEFWRV9HTlVUTFNfQ0VS VElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJTEUyCitERUZfRExMX0ZOIChpbnQsIGdudXRsc19jZXJ0 aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIsCisJICAgIChnbnV0bHNfY2VydGlmaWNhdGVfY3Jl ZGVudGlhbHNfdCwgY29uc3QgY2hhciAqLCBjb25zdCBjaGFyICosCisJICAgICBnbnV0bHNfeDUw OV9jcnRfZm10X3QsIGNvbnN0IGNoYXIgKiwgdW5zaWduZWQgaW50KSk7CisjICBlbmRpZgogIyAg aWZkZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKIERFRl9ETExfRk4gKGludCwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X3N5c3RlbV90cnVzdCwKIAkgICAgKGdudXRsc19jZXJ0 aWZpY2F0ZV9jcmVkZW50aWFsc190KSk7CkBAIC0zMTQsNiArMzIwLDkgQEAgaW5pdF9nbnV0bHNf ZnVuY3Rpb25zICh2b2lkKQogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251dGxzX2NlcnRpZmlj YXRlX3NldF92ZXJpZnlfZmxhZ3MpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251dGxzX2Nl cnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlKTsKICAgTE9BRF9ETExfRk4gKGxpYnJhcnksIGdu dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZSk7CisjICBpZmRlZiBIQVZFX0dOVVRM U19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKKyAgTE9BRF9ETExfRk4gKGxpYnJhcnks IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIpOworIyAgZW5kaWYKICMgIGlm ZGVmIEhBVkVfR05VVExTX1g1MDlfU1lTVEVNX1RSVVNUCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5 LCBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0KTsKICMgIGVuZGlmCkBA IC00NTUsNiArNDY0LDkgQEAgaW5pdF9nbnV0bHNfZnVuY3Rpb25zICh2b2lkKQogIyAgZGVmaW5l IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfdmVyaWZ5X2ZsYWdzIGZuX2dudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfdmVyaWZ5X2ZsYWdzCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5 X2NybF9maWxlIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZQogIyAgZGVm aW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZSBmbl9nbnV0bHNfY2VydGlm aWNhdGVfc2V0X3g1MDlfa2V5X2ZpbGUKKyMgIGlmZGVmIEhBVkVfR05VVExTX0NFUlRJRklDQVRF X1NFVF9YNTA5X0tFWV9GSUxFMgorIyAgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1 MDlfa2V5X2ZpbGUyIGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIKKyMg IGVuZGlmCiAjICBkZWZpbmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X3N5c3RlbV90cnVz dCBmbl9nbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0CiAjICBkZWZpbmUg Z251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X3RydXN0X2ZpbGUgZm5fZ251dGxzX2NlcnRpZmlj YXRlX3NldF94NTA5X3RydXN0X2ZpbGUKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfdHlw ZV9nZXQgZm5fZ251dGxzX2NlcnRpZmljYXRlX3R5cGVfZ2V0CkBAIC0xNzc0LDYgKzE3ODYsNjEg QEAgZ251dGxzX3ZlcmlmeV9ib290IChMaXNwX09iamVjdCBwcm9jLCBMaXNwX09iamVjdCBwcm9w bGlzdCkKICAgcmV0dXJuIGdudXRsc19tYWtlX2Vycm9yIChyZXQpOwogfQogCisjaWZkZWYgSEFW RV9HTlVUTFNfQ0VSVElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJTEUyCisKKy8qIEhlbHBlciBmdW5j dGlvbiBmb3IgZ251dGxzLWJvb3QuCisKKyAgIFRoZSBrZXkgOmZsYWdzIHJlY2VpdmVzIGEgbGlz dCBvZiBzeW1ib2xzLCBlYWNoIG9mIHdoaWNoCisgICBjb3JyZXNwb25kcyB0byBhIEdudVRMUyBD IGZsYWcsIHRoZSBPUmVkIHJlc3VsdCBpcyB0byBiZSBwYXNzZWQgdG8KKyAgIHRoZSBmdW5jdGlv biBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfa2V5X2ZpbGUyKCkgYXMgaXRzIGxhc3QKKyAg IGFyZ3VtZW50LgorKi8KK3N0YXRpYyB1bnNpZ25lZCBpbnQKK2tleV9maWxlMl9hdXggKExpc3Bf T2JqZWN0IGZsYWdzKQoreworICB1bnNpZ25lZCBpbnQgcnYgPSAwOworICBMaXNwX09iamVjdCB0 YWlsID0gZmxhZ3M7CisgIEZPUl9FQUNIX1RBSUxfU0FGRSAodGFpbCkKKyAgICB7CisgICAgICBM aXNwX09iamVjdCBmbGFnID0gWENBUiAodGFpbCk7CisgICAgICBpZiAoRVEgKGZsYWcsIGludGVy biAoIkdOVVRMU19QS0NTX1BMQUlOIikpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BMQUlOOworICAg ICAgZWxzZSBpZihFUSAoZmxhZywgaW50ZXJuICgiR05VVExTX1BLQ1NfUEtDUzEyXzNERVMiKSkp CisJcnYgfD0gR05VVExTX1BLQ1NfUEtDUzEyXzNERVM7CisgICAgICBlbHNlIGlmKEVRIChmbGFn LCBpbnRlcm4gKCJHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiIpKSkKKwlydiB8PSBHTlVUTFNf UEtDU19QS0NTMTJfQVJDRk9VUjsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIGludGVybiAoIkdO VVRMU19QS0NTX1BLQ1MxMl9SQzJfNDAiKSkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEtDUzEyX1JD Ml80MDsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIGludGVybiAoIkdOVVRMU19QS0NTX1BCRVMy XzNERVMiKSkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfM0RFUzsKKyAgICAgIGVsc2UgaWYo RVEgKGZsYWcsIGludGVybiAoIkdOVVRMU19QS0NTX1BCRVMyX0FFU18xMjgiKSkpCisJcnYgfD0g R05VVExTX1BLQ1NfUEJFUzJfQUVTXzEyODsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIGludGVy biAoIkdOVVRMU19QS0NTX1BCRVMyX0FFU18xOTIiKSkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJF UzJfQUVTXzE5MjsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIGludGVybiAoIkdOVVRMU19QS0NT X1BCRVMyX0FFU18yNTYiKSkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfQUVTXzI1NjsKKyAg ICAgIGVsc2UgaWYoRVEgKGZsYWcsIGludGVybiAoIkdOVVRMU19QS0NTX05VTExfUEFTU1dPUkQi KSkpCisJcnYgfD0gR05VVExTX1BLQ1NfTlVMTF9QQVNTV09SRDsKKyAgICAgIGVsc2UgaWYoRVEg KGZsYWcsIGludGVybiAoIkdOVVRMU19QS0NTX1BCRVMyX0RFUyIpKSkKKwlydiB8PSBHTlVUTFNf UEtDU19QQkVTMl9ERVM7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBpbnRlcm4gKCJHTlVUTFNf UEtDU19QQkVTMV9ERVNfTUQ1IikpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMxX0RFU19NRDU7 CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBpbnRlcm4gKCJnbnV0bHNfcGtjc19wYmVzMl9nb3N0 X1RDMjZaIikpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfVEMyNlo7CisgICAgICBl bHNlIGlmKEVRIChmbGFnLCBpbnRlcm4gKCJHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQSIpKSkK KwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQTsKKyAgICAgIGVsc2UgaWYoRVEgKGZs YWcsIGludGVybiAoIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCIikpKQorCXJ2IHw9IEdOVVRM U19QS0NTX1BCRVMyX0dPU1RfQ1BCOworICAgICAgZWxzZSBpZihFUSAoZmxhZywgaW50ZXJuICgi R05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEMiKSkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJf R09TVF9DUEM7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBpbnRlcm4gKCJHTlVUTFNfUEtDU19Q QkVTMl9HT1NUX0NQRCIpKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQRDsKKyAg ICB9CisgIHJldHVybiBydjsKK30KKworI2VuZGlmIC8qIEhBVkVfR05VVExTX0NFUlRJRklDQVRF X1NFVF9YNTA5X0tFWV9GSUxFMiAqLworCiBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19i b290LCBTZ251dGxzX2Jvb3QsIDMsIDMsIDAsCiAgICAgICAgZG9jOiAvKiBJbml0aWFsaXplIEdu dVRMUyBjbGllbnQgZm9yIHByb2Nlc3MgUFJPQyB3aXRoIFRZUEUrUFJPUExJU1QuCiBDdXJyZW50 bHkgb25seSBjbGllbnQgbW9kZSBpcyBzdXBwb3J0ZWQuICBSZXR1cm4gYSBzdWNjZXNzL2ZhaWx1 cmUKQEAgLTE4MTMsNiArMTg4MCwyMSBAQCBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19i b290LCBTZ251dGxzX2Jvb3QsIDMsIDMsIDAsCiA6Y29tcGxldGUtbmVnb3RpYXRpb24sIGlmIG5v bi1uaWwsIHdpbGwgbWFrZSBuZWdvdGlhdGlvbiBjb21wbGV0ZQogYmVmb3JlIHJldHVybmluZyBl dmVuIG9uIG5vbi1ibG9ja2luZyBzb2NrZXRzLgogCis6cGFzcywgdGhlIHBhc3N3b3JkIG9mIHRo ZSBwcml2YXRlIGtleSBhcyBwZXIgR251VExTJworZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5 X2tleV9maWxlMi4gIFNwZWNpZnkgYXMgbmlsIHRvIGhhdmUgYSBOVUxMCitwYXNzd29yZC4KKwor OmZsYWdzLCBhIGxpc3Qgb2Ygc3ltYm9scyByZWxhdGluZyB0byA6cGFzcywgZWFjaCBzcGVjaWZ5 aW5nIGEgZmxhZzoKK0dOVVRMU19QS0NTX1BMQUlOLCBHTlVUTFNfUEtDU19QS0NTMTJfM0RFUywK K0dOVVRMU19QS0NTX1BLQ1MxMl9BUkNGT1VSLCBHTlVUTFNfUEtDU19QS0NTMTJfUkMyXzQwLAor R05VVExTX1BLQ1NfUEJFUzJfM0RFUywgR05VVExTX1BLQ1NfUEJFUzJfQUVTXzEyOCwKK0dOVVRM U19QS0NTX1BCRVMyX0FFU18xOTIsIEdOVVRMU19QS0NTX1BCRVMyX0FFU18yNTYsCitHTlVUTFNf UEtDU19OVUxMX1BBU1NXT1JELCBHTlVUTFNfUEtDU19QQkVTMl9ERVMsCitHTlVUTFNfUEtDU19Q QkVTMl9ERVNfTUQ1LCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaLAorR05VVExTX1BLQ1Nf UEJFUzJfR09TVF9DUEEsIEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCLAorR05VVExTX1BLQ1Nf UEJFUzJfR09TVF9DUEMsIEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BELiAgSWYgbm90CitzcGVj aWZpZWQsIG9yIGlmIG5pbCwgdGhlIGJpdGZsYWcgd2l0aCB2YWx1ZSAwIGlzIHVzZWQuCisKIFRo ZSBkZWJ1ZyBsZXZlbCB3aWxsIGJlIHNldCBmb3IgdGhpcyBwcm9jZXNzIEFORCBnbG9iYWxseSBm b3IgR251VExTLgogU28gaWYgeW91IHNldCBpdCBoaWdoZXIgb3IgbG93ZXIgYXQgYW55IHBvaW50 LCBpdCBhZmZlY3RzIGdsb2JhbAogZGVidWdnaW5nLgpAQCAtMTgyNSw2ICsxOTA3LDkgQEAgREVG VU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAog ZnVuY3Rpb25zIGFyZSB1c2VkLiAgVGhpcyBmdW5jdGlvbiBhbGxvY2F0ZXMgcmVzb3VyY2VzIHdo aWNoIGNhbiBvbmx5CiBiZSBkZWFsbG9jYXRlZCBieSBjYWxsaW5nIGBnbnV0bHMtZGVpbml0JyBv ciBieSBjYWxsaW5nIGl0IGFnYWluLgogCitUaGUgOnBhc3MgYW5kIDpmbGFncyBrZXlzIGFyZSBp Z25vcmVkIHdpdGggb2xkIHZlcnNpb25zIG9mIEdudVRMUywgYW5kCis6ZmxhZ3MgaXMgaWdub3Jl ZCBpZiA6cGFzcyBpcyBub3Qgc3BlY2lmaWVkLgorCiBUaGUgY2FsbGJhY2tzIGFsaXN0IGNhbiBo YXZlIGEgYHZlcmlmeScga2V5LCBhc3NvY2lhdGVkIHdpdGggYQogdmVyaWZpY2F0aW9uIGZ1bmN0 aW9uIChVTlVTRUQpLgogCkBAIC0xODQ4LDYgKzE5MzMsOCBAQCBERUZVTiAoImdudXRscy1ib290 IiwgRmdudXRsc19ib290LCBTZ251dGxzX2Jvb3QsIDMsIDMsIDAsCiAgIExpc3BfT2JqZWN0IHRy dXN0ZmlsZXM7CiAgIExpc3BfT2JqZWN0IGNybGZpbGVzOwogICBMaXNwX09iamVjdCBrZXlsaXN0 OworICBMaXNwX09iamVjdCBwYXNzOworICBMaXNwX09iamVjdCBmbGFnczsKICAgLyogTGlzcF9P YmplY3QgY2FsbGJhY2tzOyAqLwogICBMaXNwX09iamVjdCBsb2dsZXZlbDsKICAgTGlzcF9PYmpl Y3QgaG9zdG5hbWU7CkBAIC0xODc3LDYgKzE5NjQsOCBAQCBERUZVTiAoImdudXRscy1ib290Iiwg RmdudXRsc19ib290LCBTZ251dGxzX2Jvb3QsIDMsIDMsIDAsCiAgIGNybGZpbGVzICAgICAgICAg ICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDY3JsZmlsZXMpOwogICBsb2dsZXZlbCAgICAg ICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2xvZ2xldmVsKTsKICAgcHJpbWVfYml0 cyAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNtaW5fcHJpbWVfYml0cyk7Cisg IHBhc3MgICAgICAgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDcGFzcyk7Cisg IGZsYWdzICAgICAgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDZmxhZ3MpOwog CiAgIGlmICghU1RSSU5HUCAoaG9zdG5hbWUpKQogICAgIHsKQEAgLTIwMzgsOCArMjEyNywyMiBA QCBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19ib290LCBTZ251dGxzX2Jvb3QsIDMsIDMs IDAsCiAJICAgICAga2V5ZmlsZSA9IGFuc2lfZW5jb2RlX2ZpbGVuYW1lIChrZXlmaWxlKTsKIAkg ICAgICBjZXJ0ZmlsZSA9IGFuc2lfZW5jb2RlX2ZpbGVuYW1lIChjZXJ0ZmlsZSk7CiAjIGVuZGlm CisjIGlmZGVmIEhBVkVfR05VVExTX0NFUlRJRklDQVRFX1NFVF9YNTA5X0tFWV9GSUxFMgorCSAg ICAgIGlmIChTVFJJTkdQIChwYXNzKSkKKwkJcmV0ID0gZ251dGxzX2NlcnRpZmljYXRlX3NldF94 NTA5X2tleV9maWxlMgorCQkgICh4NTA5X2NyZWQsIFNTREFUQSAoY2VydGZpbGUpLCBTU0RBVEEg KGtleWZpbGUpLCBmaWxlX2Zvcm1hdCwKKwkJICAgU1NEQVRBIChwYXNzKSwga2V5X2ZpbGUyX2F1 eCAoZmxhZ3MpKTsKKwkgICAgICBlbHNlIGlmIChOSUxQIChwYXNzKSAmJiBwbGlzdF9tZW1iZXIg KHByb3BsaXN0LCBRQ3Bhc3MpKQorCQlyZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlf a2V5X2ZpbGUyCisJCSAgKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5 ZmlsZSksIGZpbGVfZm9ybWF0LAorCQkgICBOVUxMLCBrZXlfZmlsZTJfYXV4IChmbGFncykpOwor CSAgICAgIGVsc2UKKwkJcmV0ID0gZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxl CisJCSAgKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5ZmlsZSksIGZp bGVfZm9ybWF0KTsKKyMgZWxzZQogCSAgICAgIHJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRf eDUwOV9rZXlfZmlsZQogCQkoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChr ZXlmaWxlKSwgZmlsZV9mb3JtYXQpOworIyBlbmRpZgogCiAJICAgICAgaWYgKHJldCA8IEdOVVRM U19FX1NVQ0NFU1MpCiAJCXJldHVybiBnbnV0bHNfbWFrZV9lcnJvciAocmV0KTsKQEAgLTI4NjAs NiArMjk2Myw4IEBAIHN5bXNfb2ZfZ251dGxzICh2b2lkKQogICBERUZTWU0gKFFDbWluX3ByaW1l X2JpdHMsICI6bWluLXByaW1lLWJpdHMiKTsKICAgREVGU1lNIChRQ2xvZ2xldmVsLCAiOmxvZ2xl dmVsIik7CiAgIERFRlNZTSAoUUNjb21wbGV0ZV9uZWdvdGlhdGlvbiwgIjpjb21wbGV0ZS1uZWdv dGlhdGlvbiIpOworICBERUZTWU0gKFFDcGFzcywgIjpwYXNzIik7CisgIERFRlNZTSAoUUNmbGFn cywgIjpmbGFncyIpOwogICBERUZTWU0gKFFDdmVyaWZ5X2ZsYWdzLCAiOnZlcmlmeS1mbGFncyIp OwogICBERUZTWU0gKFFDdmVyaWZ5X2Vycm9yLCAiOnZlcmlmeS1lcnJvciIpOwogCi0tIAoyLjM3 LjMKCg== --0000000000006251dc05e9e21fe7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 06:47:31 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 10:47:31 +0000 Received: from localhost ([127.0.0.1]:40604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeDYI-0004hU-Tp for submit@debbugs.gnu.org; Fri, 30 Sep 2022 06:47:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeDYE-0004hC-HP for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 06:47:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeDY9-0002Eu-8Z; Fri, 30 Sep 2022 06:47:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=BI0nSa8k8OHxvjtB5n+eO/3rVJj+VdfjCPiaWgUgRPA=; b=JynK9/nXmOpR9TrbIatC 3pS2G3scMo7GpMNyozx3Ml2zFJP+eVMB5wTIPMGQt0MJtLnfWYOPNMPRt4QCilpcHe9XfHoA6e2Nh NE7ZgvtsosHfIezX6khuzeDvaLJ1n7Qsz8Pqciogh9KZn5JK6U0IL9QshXwjwuZEia/rUCUiZoF4P xuoHf1+qF0SfeRN9QSWRQph1gcBCTnavaV9cv7SSljRcaaZqml7iQXz4z7Ah2ttu84Lne1tnwzg4p R0vkSqoZNih66am21Xzak+1fmPcyTTzX4Ht3Fu8ht3vRqKewdp2WzVPDzixGlZuTjD/lh5Wm8kYc6 B08TJtOIDK4ntw==; Received: from [87.69.77.57] (port=3488 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeDY8-0003zZ-3Q; Fri, 30 Sep 2022 06:47:20 -0400 Date: Fri, 30 Sep 2022 13:47:06 +0300 Message-Id: <83ill5dtqt.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Fri, 30 Sep 2022 06:04:30 -0400) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Fri, 30 Sep 2022 06:04:30 -0400 > Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zaretskii > > > On Thu, Sep 29, 2022 at 10:08 AM Robert Pluim wrote: > > > > >>>>> On Thu, 29 Sep 2022 09:44:09 -0400, Nikolaos Chatzikonstantinou said: > > Nikolaos> +The :pass and :flags keys are ignored with old versions of GnuTLS, and > > Nikolaos> +:flags is ignored if :pass is not specified. > > Nikolaos> + > > >> > > >> Maybe mention that not specifying :flags or passing :flags nil means > > >> passing '0' to the GnuTLS function? > > > > Nikolaos> Yes, and on that note, I discovered two things. One, the value 0 is > > Nikolaos> special; it has meaning but it is not an enumeration constant. I > > Nikolaos> documented this appropriately. Two, the password may be NULL instead > > Nikolaos> of a string. > > > > OK. I guess youʼre mapping ':pass nil' to that? > > Yes. > > > Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); > > Nikolaos> > > Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PBES2_GOST_CPD"); > > >> > > >> All this is kind of awkward, but apart from doing DEFVAR_LISP Iʼm not > > >> aware of how to define a lisp level symbol with a value (it would > > >> allow you to simplify `key_file2_aux', since you could just extract > > >> the values directly from the symbols). > > > > Nikolaos> I am now comparing against intern("GNUTLS_PKCS_PLAIN") and so on. > > > > I guess thatʼs another option, but itʼs not the preferred > > solution. Anyway, letʼs not let the perfect be the enemy of the good. > > I went with intern. Why not use DEFSYM and then compare against the static symbols? That is more efficient, since the intern call is avoided at run time. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 09:01:29 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 13:01:29 +0000 Received: from localhost ([127.0.0.1]:40760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeFdw-00049s-Sy for submit@debbugs.gnu.org; Fri, 30 Sep 2022 09:01:29 -0400 Received: from mail-yw1-f169.google.com ([209.85.128.169]:38524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeFdr-00049Z-Ba for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 09:01:27 -0400 Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-3321c2a8d4cso43514137b3.5 for <50507@debbugs.gnu.org>; Fri, 30 Sep 2022 06:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=9lXnK02lN3cK16XJ8yS6NljbDW0cuHSMmGyOMipKkBY=; b=i+pz9QLEodkcZeYNUIZY/9XDIIzAGqlMnunKWrEXTQeo/FBIlTDisOWgfxoetxlV6k dQgVq7qr2jkUym15K1u3VXnTTRKNiSa8vDBnDk9+rLY39On+cOpXnRkgzpmnGbtcoPMX CgL4ZklXDyNzOecSEtkrWfU0KlMXPIngC/ws74Aq/SX8y9YODVLZPFj2xJkXATzXz16X VvREwbDkGlJQO4XqcmSK4nCivGg7DLevCt7av0WTU3FD+a0IEf125CxNJ/QLqdJhPN2r cjPmG1wm73XYBcsK2LzNauhpWEPL4t3vMU9S4JTzg+74sE1ayYdFUspBMm/UuptAWaCS vX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=9lXnK02lN3cK16XJ8yS6NljbDW0cuHSMmGyOMipKkBY=; b=oMMem5NQziQxg6++cm6q0cgbZ3skY9hOufBAOPl22wg8IfNeFEAbsA+axthxSffNbv q04L1pJT8H1scxeGEDwNFt4pPjxJNGGci+BGDxe7A2n75lfcmKNE5StmEFePPKDk+lzr 5EP8AR2akLyAqodt/xwRrp7IV4iJaIc7gw+qPOp1Yv3SbGhAOpA2jwHRR33d3cxCFWch bdyXfZXNCIqLABqNT5y5Yoyq08R61+2EVa4ikpKfIE2Jht1CDkyBYaqQw0yXf/MhbkWh Bw8a1xJIFULKhM/4IRuG/dL9SrGDd/lnCWPYon97NRLYmZKgDlkmxg6sDgd/ozqa+ExD L6Hg== X-Gm-Message-State: ACrzQf3mGuBnaofZKci9uSS/4R+dTOebKjuInteYz/cObIB6+mQv/rEV qe3QyVHYHsLCHY/hrrU3/Mc4E0pjzXB8PceAuSg= X-Google-Smtp-Source: AMsMyM4B1aO9JJdbrJkjbqhRUjTC6WaImqmsYjDDJxRTV0swyNNuLhOO130yzFVoosyIiBd3wdmjzQdgkN+B37fIXzk= X-Received: by 2002:a81:5344:0:b0:350:a192:9fce with SMTP id h65-20020a815344000000b00350a1929fcemr8492794ywb.64.1664542877874; Fri, 30 Sep 2022 06:01:17 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> In-Reply-To: <83ill5dtqt.fsf@gnu.org> From: Nikolaos Chatzikonstantinou Date: Fri, 30 Sep 2022 09:01:06 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Fri, Sep 30, 2022 at 6:47 AM Eli Zaretskii wrote: > > > From: Nikolaos Chatzikonstantinou > > Date: Fri, 30 Sep 2022 06:04:30 -0400 > > Cc: 50507@debbugs.gnu.org, Lars Ingebrigtsen , Eli Zare= tskii > > > > > > On Thu, Sep 29, 2022 at 10:08 AM Robert Pluim wrote: > > > > > > >>>>> On Thu, 29 Sep 2022 09:44:09 -0400, Nikolaos Chatzikonstantinou= said: > > > Nikolaos> +The :pass and :flags keys are ignored with old version= s of GnuTLS, and > > > Nikolaos> +:flags is ignored if :pass is not specified. > > > Nikolaos> + > > > >> > > > >> Maybe mention that not specifying :flags or passing :flags nil= means > > > >> passing '0' to the GnuTLS function? > > > > > > Nikolaos> Yes, and on that note, I discovered two things. One, th= e value 0 is > > > Nikolaos> special; it has meaning but it is not an enumeration co= nstant. I > > > Nikolaos> documented this appropriately. Two, the password may be= NULL instead > > > Nikolaos> of a string. > > > > > > OK. I guess you=CA=BCre mapping ':pass nil' to that? > > > > Yes. > > > > > Nikolaos> + DEFSYM (Qgnutls_pkcs_plain, "GNUTLS_PKCS_PLAIN"); > > > Nikolaos> > > > Nikolaos> + DEFSYM (Qgnutls_pkcs_pbes2_gost_cpd, "GNUTLS_PKCS_PB= ES2_GOST_CPD"); > > > >> > > > >> All this is kind of awkward, but apart from doing DEFVAR_LISP = I=CA=BCm not > > > >> aware of how to define a lisp level symbol with a value (it wo= uld > > > >> allow you to simplify `key_file2_aux', since you could just ex= tract > > > >> the values directly from the symbols). > > > > > > Nikolaos> I am now comparing against intern("GNUTLS_PKCS_PLAIN") = and so on. > > > > > > I guess that=CA=BCs another option, but it=CA=BCs not the preferred > > > solution. Anyway, let=CA=BCs not let the perfect be the enemy of the = good. > > > > I went with intern. > > Why not use DEFSYM and then compare against the static symbols? That > is more efficient, since the intern call is avoided at run time. I did not understand the differences between DEFSYM() and intern(). Can DEFSYM() be used outside of syms_of_gnutls()? In particular can I (and, should I?) call it inside the key_file2_aux() function? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 09:37:53 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 13:37:53 +0000 Received: from localhost ([127.0.0.1]:40862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGDB-00011t-40 for submit@debbugs.gnu.org; Fri, 30 Sep 2022 09:37:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGD7-00011X-4H for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 09:37:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeGCz-0006uv-Ri; Fri, 30 Sep 2022 09:37:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HmNg+8usnBhJkzuTKaESe+Pei98MCRRYhNLgnJmu74s=; b=dXQOpo917Jlt 7BhPyROSV7dgvQOuWjfMRRShAxmc+70SMfTNsSaSpPqkjybXIaUe61cUp1e3cd4lG/cJqSvKRSeUv +x/KJlQgb3AqnMOtFmdiornCAXMPJxeecW7kDLX4r5gwy4qX4v5RQ/ejI6OKFspjlzs4nmV6OqyWf vh6pKO26FHMzlHr2Mq31gWU8t4l0KMWyF1NAOED/5wQIsc+Effn4Y2a5DZh7feGEG6G2bLgs//XdC N+ZBUhVZUlPxLtXKJPyI0aXG5wYHbh5RrkZjhLjpSQuhBZCfxr+WUgzJUU/GI7WcfhMj5LZPE3TGx c213lBuG7iFQiRWWV45ltA==; Received: from [87.69.77.57] (port=2037 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oeGCr-00043U-Fz; Fri, 30 Sep 2022 09:37:38 -0400 Date: Fri, 30 Sep 2022 16:37:20 +0300 Message-Id: <837d1ldlv3.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Fri, 30 Sep 2022 09:01:06 -0400) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Fri, 30 Sep 2022 09:01:06 -0400 > Cc: rpluim@gmail.com, 50507@debbugs.gnu.org, larsi@gnus.org > > On Fri, Sep 30, 2022 at 6:47 AM Eli Zaretskii wrote: > > > > > I went with intern. > > > > Why not use DEFSYM and then compare against the static symbols? That > > is more efficient, since the intern call is avoided at run time. > > I did not understand the differences between DEFSYM() and > intern(). Can DEFSYM() be used outside of syms_of_gnutls()? Why do you need to use DEFSYM outside of syms_of_gnutls? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 09:49:49 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 13:49:49 +0000 Received: from localhost ([127.0.0.1]:40892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGOi-0003YF-Or for submit@debbugs.gnu.org; Fri, 30 Sep 2022 09:49:49 -0400 Received: from mail-yw1-f177.google.com ([209.85.128.177]:42770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeGOg-0003Y1-UK for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 09:49:47 -0400 Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-3567dbf9ec3so14056507b3.9 for <50507@debbugs.gnu.org>; Fri, 30 Sep 2022 06:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=FwAlwopwfrRt2DyNDaUJCHvr/+++iIquifrfMJfAI8E=; b=lbx68C3E9PyRp8NLop5z55B/BDhq9TEvtT1P/G8JhxWtzxHyptuSDryjWdR7sDdoua JqdMp3kNS/whozarag0FUpRARvgWzb783oC/Ji0kio4/m8dByldBvki3mxsLbkYAwgk+ a7Jg4bYUKcLhR8SfN2CDHfR3NWkljOkHaEH/0eNX/8hFdWfrWZ0PkTUDj0Az3EnpGft0 nVgZmR+VkpdbB8Ad3a2xYbw7RLr8E8veMeTOOflMhvuUY1S/YWzNEGRljlfk0PDW1n0w USVbko5x1ha1yRLcHJuFB3FvkK51CsB6X35Bp2RT3HMWrT5LMts5k/mGbgwSbzJCFuYf 5UOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=FwAlwopwfrRt2DyNDaUJCHvr/+++iIquifrfMJfAI8E=; b=dDUCH5l3A5XLY15u8SwpqFCUvTq4O1AfIY9W0gC/LzM2asOG/Msj77JrU7Lhd8s1qD 0bZUYroIsZlMv2xM22Vc4rLSDfzwCfjB5t5vpDSZCmFC9c5SizGI+/XOYz9zwhkMEzzP kSMuDjCAYR4U7ZtjjwzU4mf/qndwUhKudjT8niVWi9S+8wX7d/eCxca/P0ewX8qYXfyM JZsj1QpamKzj7ofiXbOUkL8kFro2MW+e/s1FwbQ1jxsnteyVsxtiCrCROkNvpiZjOE+r sXLTE8tgzyR80tP256GeoD4nB4MdUlPf4D7EAI6FstH+mawoe+zksoqHScs0zHSxelKU yRnQ== X-Gm-Message-State: ACrzQf0n8JYvNs73o7b881co66noF0Eyb5s3blK8Kkz5nKCnND47UGWM SMycjFiijxTHr+EdTIJfbvGdbKJj0Qq3iUHO8Js= X-Google-Smtp-Source: AMsMyM5Uc5aI4KnnLTABNRsJFMPGOg5QQrYcWwH20zyH+R1/07T8S+nTrvEVmA3IxCu250kS4qdok55woLdfrJakI9I= X-Received: by 2002:a81:54c5:0:b0:353:889c:5ea1 with SMTP id i188-20020a8154c5000000b00353889c5ea1mr8385428ywb.331.1664545781320; Fri, 30 Sep 2022 06:49:41 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> In-Reply-To: <837d1ldlv3.fsf@gnu.org> From: Nikolaos Chatzikonstantinou Date: Fri, 30 Sep 2022 09:49:30 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Eli Zaretskii Content-Type: multipart/mixed; boundary="00000000000002483605e9e544e3" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, Sep 30, 2022 at 9:37 AM Eli Zaretskii wrote: > > > From: Nikolaos Chatzikonstantinou > > Date: Fri, 30 Sep 2022 09:01:06 -0400 > > Cc: rpluim@gmail.com, 50507@debbugs.gnu.org, larsi@gnus.o [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (nchatz314[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (nchatz314[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.177 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.177 listed in list.dnswl.org] 1.0 FREEMAIL_REPLY From and body contain different freemails X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --00000000000002483605e9e544e3 Content-Type: text/plain; charset="UTF-8" On Fri, Sep 30, 2022 at 9:37 AM Eli Zaretskii wrote: > > > From: Nikolaos Chatzikonstantinou > > Date: Fri, 30 Sep 2022 09:01:06 -0400 > > Cc: rpluim@gmail.com, 50507@debbugs.gnu.org, larsi@gnus.org > > > > On Fri, Sep 30, 2022 at 6:47 AM Eli Zaretskii wrote: > > > > > > > I went with intern. > > > > > > Why not use DEFSYM and then compare against the static symbols? That > > > is more efficient, since the intern call is avoided at run time. > > > > I did not understand the differences between DEFSYM() and > > intern(). Can DEFSYM() be used outside of syms_of_gnutls()? > > Why do you need to use DEFSYM outside of syms_of_gnutls? Nevermind, I had general confusion on how the internals work. Here is the update, using DEFSYM. --00000000000002483605e9e544e3 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8ojkdou0 RnJvbSA0OGVlYjE2YjcyMDZmZWRiZjJkMGNiOTJjNmZkN2FjZTZjYjJkZWRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxp c3QKCiogbGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogQWRkIHRo ZSBrZXlzIDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiog c3JjL2dudXRscy5jIChnbnV0bHMtYm9vdCk6IEFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdz LCBhbmQKdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBBZGQgdGhl IHN5bWJvbHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0 byB0aGUgZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190YC4KKGtleV9maWxlMl9hdXgpOiBQcml2YXRlIGhlbHBlciBmdW5j dGlvbiB0aGF0IHRyYW5zbGF0ZXMgYSBsaXN0IG9mCnN5bWJvbHMgdG8gaXRzIGNvcnJlc3BvbmRp bmcgYHVuc2lnbmVkIGludGAgdmFsdWUgb2YgdGhlIEdudVRMUyBDIGVudW0KYGdudXRsc19wa2Nz X2VuY3J5cHRfZmxhZ3NfdGAuCi0tLQogbGlzcC9uZXQvZ251dGxzLmVsIHwgIDEwICsrKysKIHNy Yy9nbnV0bHMuYyAgICAgICB8IDEyMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTMxIGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9saXNwL25ldC9nbnV0bHMuZWwgYi9saXNwL25ldC9nbnV0bHMuZWwKaW5kZXggNmUzODQ1 YWVjMS4uZWVmNjU1OWE5NSAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZ251dGxzLmVsCisrKyBiL2xp c3AvbmV0L2dudXRscy5lbApAQCAtMjY1LDYgKzI2NSw3IEBAIGdudXRscy1ib290LXBhcmFtZXRl cnMKICAgICAgICAgICAgJmtleSB0eXBlIGhvc3RuYW1lIHByaW9yaXR5LXN0cmluZwogICAgICAg ICAgICB0cnVzdGZpbGVzIGNybGZpbGVzIGtleWxpc3QgbWluLXByaW1lLWJpdHMKICAgICAgICAg ICAgdmVyaWZ5LWZsYWdzIHZlcmlmeS1lcnJvciB2ZXJpZnktaG9zdG5hbWUtZXJyb3IKKyAgICAg ICAgICAgcGFzcyBmbGFncwogICAgICAgICAgICAmYWxsb3ctb3RoZXIta2V5cykKICAgIlJldHVy biBhIGtleXdvcmQgbGlzdCBvZiBwYXJhbWV0ZXJzIHN1aXRhYmxlIGZvciBwYXNzaW5nIHRvIGBn bnV0bHMtYm9vdCcuCiAKQEAgLTI4MSw2ICsyODIsMTMgQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVy cwogVkVSSUZZLUhPU1ROQU1FLUVSUk9SIGlzIGEgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgb3B0 aW9uIGZvcgogcHV0dGluZyBgOmhvc3RuYW1lJyBpbiBWRVJJRlktRVJST1IuCiAKK1BBU1MgaXMg YSBzdHJpbmcsIHRoZSBwYXNzd29yZCBvZiB0aGUga2V5LiAgSXQgbWF5IGFsc28gYmUgbmlsLAor Zm9yIGEgTlVMTCBwYXNzd29yZC4KKworRkxBR1MgaXMgYSBsaXN0IG9mIHN5bWJvbHMgY29ycmVz cG9uZGluZyB0byB0aGUgZXF1aXZhbGVudCBPUmVkCitiaXRmbGFnIG9mIHRoZSBnbnV0bHNfcGtj c19lbmNyeXB0X2ZsYWdzX3QgZW51bSBvZiBHbnVUTFMuICBUaGUKK2VtcHR5IGxpc3QgY29ycmVz cG9uZHMgdG8gdGhlIGJpdGZsYWcgd2l0aCB2YWx1ZSAwLgorCiBXaGVuIFZFUklGWS1FUlJPUiBp cyB0IG9yIGEgbGlzdCBjb250YWluaW5nIGA6dHJ1c3RmaWxlcycsIGFuCiBlcnJvciB3aWxsIGJl IHJhaXNlZCB3aGVuIHRoZSBwZWVyIGNlcnRpZmljYXRlIHZlcmlmaWNhdGlvbiBmYWlscwogYXMg cGVyIEdudVRMUycgZ251dGxzX2NlcnRpZmljYXRlX3ZlcmlmeV9wZWVyczIuICBPdGhlcndpc2Us IG9ubHkKQEAgLTM1OCw2ICszNjYsOCBAQCBnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzCiAgICAgICAg ICAgICAgICAgOmtleWxpc3QgLGtleWxpc3QKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWZsYWdz ICx2ZXJpZnktZmxhZ3MKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWVycm9yICx2ZXJpZnktZXJy b3IKKyAgICAgICAgICAgICAgICA6cGFzcyAscGFzcworICAgICAgICAgICAgICAgIDpmbGFncyAs ZmxhZ3MKICAgICAgICAgICAgICAgICA6Y2FsbGJhY2tzIG5pbCkpKQogCiAoZGVmdW4gZ251dGxz LS1nZXQtZmlsZXMgKGZpbGVzKQpkaWZmIC0tZ2l0IGEvc3JjL2dudXRscy5jIGIvc3JjL2dudXRs cy5jCmluZGV4IGEwZGUwMjM4YzQuLmJjOWIxOTVjZGQgMTAwNjQ0Ci0tLSBhL3NyYy9nbnV0bHMu YworKysgYi9zcmMvZ251dGxzLmMKQEAgLTM0LDYgKzM0LDcgQEAKICMgZW5kaWYKIAogIyBpZiBH TlVUTFNfVkVSU0lPTl9OVU1CRVIgPj0gMHgwMzAyMDAKKyMgIGRlZmluZSBIQVZFX0dOVVRMU19D RVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKICMgIGRlZmluZSBIQVZFX0dOVVRMU19DSVBI RVJfR0VUX0lWX1NJWkUKICMgZW5kaWYKIApAQCAtMTIxLDYgKzEyMiwxMSBAQCBERUZfRExMX0ZO IChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZSwKIERFRl9ETExfRk4g KGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlLAogCSAgICAoZ251dGxz X2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqLAog CSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CisjICBpZmRlZiBIQVZFX0dOVVRMU19DRVJU SUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKK0RFRl9ETExfRk4gKGludCwgZ251dGxzX2NlcnRp ZmljYXRlX3NldF94NTA5X2tleV9maWxlMiwKKwkgICAgKGdudXRsc19jZXJ0aWZpY2F0ZV9jcmVk ZW50aWFsc190LCBjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKiwKKwkgICAgIGdudXRsc194NTA5 X2NydF9mbXRfdCwgY29uc3QgY2hhciAqLCB1bnNpZ25lZCBpbnQpKTsKKyMgIGVuZGlmCiAjICBp ZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9GTiAoaW50LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAoZ251dGxzX2NlcnRp ZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMjAsOSBAQCBpbml0X2dudXRsc19m dW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNh dGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2Vy dGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyMgIGlmZGVmIEhBVkVfR05VVExT X0NFUlRJRklDQVRFX1NFVF9YNTA5X0tFWV9GSUxFMgorICBMT0FEX0RMTF9GTiAobGlicmFyeSwg Z251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMik7CisjICBlbmRpZgogIyAgaWZk ZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxpYnJhcnks IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5kaWYKQEAg LTQ1NSw2ICs0NjQsOSBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBkZWZpbmUg Z251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRpZmljYXRl X3NldF92ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlf Y3JsX2ZpbGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAjICBkZWZp bmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19jZXJ0aWZp Y2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorIyAgaWZkZWYgSEFWRV9HTlVUTFNfQ0VSVElGSUNBVEVf U0VUX1g1MDlfS0VZX0ZJTEUyCisjICAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUw OV9rZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgorIyAg ZW5kaWYKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0 IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QKICMgIGRlZmluZSBn bnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfdHJ1c3RfZmlsZSBmbl9nbnV0bHNfY2VydGlmaWNh dGVfc2V0X3g1MDlfdHJ1c3RfZmlsZQogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV90eXBl X2dldCBmbl9nbnV0bHNfY2VydGlmaWNhdGVfdHlwZV9nZXQKQEAgLTE3NzQsNiArMTc4Niw2MSBA QCBnbnV0bHNfdmVyaWZ5X2Jvb3QgKExpc3BfT2JqZWN0IHByb2MsIExpc3BfT2JqZWN0IHByb3Bs aXN0KQogICByZXR1cm4gZ251dGxzX21ha2VfZXJyb3IgKHJldCk7CiB9CiAKKyNpZmRlZiBIQVZF X0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKKworLyogSGVscGVyIGZ1bmN0 aW9uIGZvciBnbnV0bHMtYm9vdC4KKworICAgVGhlIGtleSA6ZmxhZ3MgcmVjZWl2ZXMgYSBsaXN0 IG9mIHN5bWJvbHMsIGVhY2ggb2Ygd2hpY2gKKyAgIGNvcnJlc3BvbmRzIHRvIGEgR251VExTIEMg ZmxhZywgdGhlIE9SZWQgcmVzdWx0IGlzIHRvIGJlIHBhc3NlZCB0bworICAgdGhlIGZ1bmN0aW9u IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIoKSBhcyBpdHMgbGFzdAorICAg YXJndW1lbnQuCisqLworc3RhdGljIHVuc2lnbmVkIGludAora2V5X2ZpbGUyX2F1eCAoTGlzcF9P YmplY3QgZmxhZ3MpCit7CisgIHVuc2lnbmVkIGludCBydiA9IDA7CisgIExpc3BfT2JqZWN0IHRh aWwgPSBmbGFnczsKKyAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQorICAgIHsKKyAgICAgIExp c3BfT2JqZWN0IGZsYWcgPSBYQ0FSICh0YWlsKTsKKyAgICAgIGlmIChFUSAoZmxhZywgUWdudXRs c19wa2NzX3BsYWluKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QTEFJTjsKKyAgICAgIGVsc2UgaWYo RVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wa2NzMTJfM2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1Nf UEtDUzEyXzNERVM7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGtjczEy X2FyY2ZvdXIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BLQ1MxMl9BUkNGT1VSOworICAgICAgZWxz ZSBpZihFUSAoZmxhZywgUWdudXRsc19wa2NzX3BrY3MxMl9yYzJfNDApKQorCXJ2IHw9IEdOVVRM U19QS0NTX1BLQ1MxMl9SQzJfNDA7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBRZ251dGxzX3Br Y3NfcGJlczJfM2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfM0RFUzsKKyAgICAgIGVs c2UgaWYoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMTI4KSkKKwlydiB8PSBHTlVU TFNfUEtDU19QQkVTMl9BRVNfMTI4OworICAgICAgZWxzZSBpZihFUSAoZmxhZywgUWdudXRsc19w a2NzX3BiZXMyX2Flc18xOTIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0FFU18xOTI7Cisg ICAgICBlbHNlIGlmKEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfYWVzXzI1NikpCisJcnYg fD0gR05VVExTX1BLQ1NfUEJFUzJfQUVTXzI1NjsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIFFn bnV0bHNfcGtjc19udWxsX3Bhc3N3b3JkKSkKKwlydiB8PSBHTlVUTFNfUEtDU19OVUxMX1BBU1NX T1JEOworICAgICAgZWxzZSBpZihFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2RlcykpCisJ cnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfREVTOworICAgICAgZWxzZSBpZihFUSAoZmxhZywgUWdu dXRsc19wa2NzX3BiZXMxX2Rlc19tZDUpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMxX0RFU19N RDU7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29zdF90YzI2 eikpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfR09TVF9UQzI2WjsKKyAgICAgIGVsc2UgaWYo RVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwYSkpCisJcnYgfD0gR05VVExTX1BL Q1NfUEJFUzJfR09TVF9DUEE7CisgICAgICBlbHNlIGlmKEVRIChmbGFnLCBRZ251dGxzX3BrY3Nf cGJlczJfZ29zdF9jcGIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCOworICAg ICAgZWxzZSBpZihFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BjKSkKKwlydiB8 PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQzsKKyAgICAgIGVsc2UgaWYoRVEgKGZsYWcsIFFn bnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwZCkpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfR09T VF9DUEQ7CisgICAgfQorICByZXR1cm4gcnY7Cit9CisKKyNlbmRpZiAvKiBIQVZFX0dOVVRMU19D RVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIgKi8KKwogREVGVU4gKCJnbnV0bHMtYm9vdCIs IEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICAgICAgIGRvYzogLyogSW5p dGlhbGl6ZSBHbnVUTFMgY2xpZW50IGZvciBwcm9jZXNzIFBST0Mgd2l0aCBUWVBFK1BST1BMSVNU LgogQ3VycmVudGx5IG9ubHkgY2xpZW50IG1vZGUgaXMgc3VwcG9ydGVkLiAgUmV0dXJuIGEgc3Vj Y2Vzcy9mYWlsdXJlCkBAIC0xODEzLDYgKzE4ODAsMjEgQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIs IEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogOmNvbXBsZXRlLW5lZ290aWF0 aW9uLCBpZiBub24tbmlsLCB3aWxsIG1ha2UgbmVnb3RpYXRpb24gY29tcGxldGUKIGJlZm9yZSBy ZXR1cm5pbmcgZXZlbiBvbiBub24tYmxvY2tpbmcgc29ja2V0cy4KIAorOnBhc3MsIHRoZSBwYXNz d29yZCBvZiB0aGUgcHJpdmF0ZSBrZXkgYXMgcGVyIEdudVRMUycKK2dudXRsc19jZXJ0aWZpY2F0 ZV9zZXRfeDUwOV9rZXlfZmlsZTIuICBTcGVjaWZ5IGFzIG5pbCB0byBoYXZlIGEgTlVMTAorcGFz c3dvcmQuCisKKzpmbGFncywgYSBsaXN0IG9mIHN5bWJvbHMgcmVsYXRpbmcgdG8gOnBhc3MsIGVh Y2ggc3BlY2lmeWluZyBhIGZsYWc6CitHTlVUTFNfUEtDU19QTEFJTiwgR05VVExTX1BLQ1NfUEtD UzEyXzNERVMsCitHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiwgR05VVExTX1BLQ1NfUEtDUzEy X1JDMl80MCwKK0dOVVRMU19QS0NTX1BCRVMyXzNERVMsIEdOVVRMU19QS0NTX1BCRVMyX0FFU18x MjgsCitHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTkyLCBHTlVUTFNfUEtDU19QQkVTMl9BRVNfMjU2 LAorR05VVExTX1BLQ1NfTlVMTF9QQVNTV09SRCwgR05VVExTX1BLQ1NfUEJFUzJfREVTLAorR05V VExTX1BLQ1NfUEJFUzJfREVTX01ENSwgR05VVExTX1BLQ1NfUEJFUzJfR09TVF9UQzI2WiwKK0dO VVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BBLCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQiwKK0dO VVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDLCBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQRC4gIElm IG5vdAorc3BlY2lmaWVkLCBvciBpZiBuaWwsIHRoZSBiaXRmbGFnIHdpdGggdmFsdWUgMCBpcyB1 c2VkLgorCiBUaGUgZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRoaXMgcHJvY2VzcyBBTkQg Z2xvYmFsbHkgZm9yIEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGlnaGVyIG9yIGxvd2VyIGF0 IGFueSBwb2ludCwgaXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4KQEAgLTE4MjUsNiArMTkw Nyw5IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9vdCwg MywgMywgMCwKIGZ1bmN0aW9ucyBhcmUgdXNlZC4gIFRoaXMgZnVuY3Rpb24gYWxsb2NhdGVzIHJl c291cmNlcyB3aGljaCBjYW4gb25seQogYmUgZGVhbGxvY2F0ZWQgYnkgY2FsbGluZyBgZ251dGxz LWRlaW5pdCcgb3IgYnkgY2FsbGluZyBpdCBhZ2Fpbi4KIAorVGhlIDpwYXNzIGFuZCA6ZmxhZ3Mg a2V5cyBhcmUgaWdub3JlZCB3aXRoIG9sZCB2ZXJzaW9ucyBvZiBHbnVUTFMsIGFuZAorOmZsYWdz IGlzIGlnbm9yZWQgaWYgOnBhc3MgaXMgbm90IHNwZWNpZmllZC4KKwogVGhlIGNhbGxiYWNrcyBh bGlzdCBjYW4gaGF2ZSBhIGB2ZXJpZnknIGtleSwgYXNzb2NpYXRlZCB3aXRoIGEKIHZlcmlmaWNh dGlvbiBmdW5jdGlvbiAoVU5VU0VEKS4KIApAQCAtMTg0OCw2ICsxOTMzLDggQEAgREVGVU4gKCJn bnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICBMaXNw X09iamVjdCB0cnVzdGZpbGVzOwogICBMaXNwX09iamVjdCBjcmxmaWxlczsKICAgTGlzcF9PYmpl Y3Qga2V5bGlzdDsKKyAgTGlzcF9PYmplY3QgcGFzczsKKyAgTGlzcF9PYmplY3QgZmxhZ3M7CiAg IC8qIExpc3BfT2JqZWN0IGNhbGxiYWNrczsgKi8KICAgTGlzcF9PYmplY3QgbG9nbGV2ZWw7CiAg IExpc3BfT2JqZWN0IGhvc3RuYW1lOwpAQCAtMTg3Nyw2ICsxOTY0LDggQEAgREVGVU4gKCJnbnV0 bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICBjcmxmaWxl cyAgICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2NybGZpbGVzKTsKICAgbG9n bGV2ZWwgICAgICAgICAgICAgID0gcGxpc3RfZ2V0IChwcm9wbGlzdCwgUUNsb2dsZXZlbCk7CiAg IHByaW1lX2JpdHMgICAgICAgICAgICA9IHBsaXN0X2dldCAocHJvcGxpc3QsIFFDbWluX3ByaW1l X2JpdHMpOworICBwYXNzICAgICAgICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBR Q3Bhc3MpOworICBmbGFncyAgICAgICAgICAgICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBR Q2ZsYWdzKTsKIAogICBpZiAoIVNUUklOR1AgKGhvc3RuYW1lKSkKICAgICB7CkBAIC0yMDM4LDgg KzIxMjcsMjIgQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19i b290LCAzLCAzLCAwLAogCSAgICAgIGtleWZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoa2V5 ZmlsZSk7CiAJICAgICAgY2VydGZpbGUgPSBhbnNpX2VuY29kZV9maWxlbmFtZSAoY2VydGZpbGUp OwogIyBlbmRpZgorIyBpZmRlZiBIQVZFX0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlf RklMRTIKKwkgICAgICBpZiAoU1RSSU5HUCAocGFzcykpCisJCXJldCA9IGdudXRsc19jZXJ0aWZp Y2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIKKwkJICAoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxl KSwgU1NEQVRBIChrZXlmaWxlKSwgZmlsZV9mb3JtYXQsCisJCSAgIFNTREFUQSAocGFzcyksIGtl eV9maWxlMl9hdXggKGZsYWdzKSk7CisJICAgICAgZWxzZSBpZiAoTklMUCAocGFzcykgJiYgcGxp c3RfbWVtYmVyIChwcm9wbGlzdCwgUUNwYXNzKSkKKwkJcmV0ID0gZ251dGxzX2NlcnRpZmljYXRl X3NldF94NTA5X2tleV9maWxlMgorCQkgICh4NTA5X2NyZWQsIFNTREFUQSAoY2VydGZpbGUpLCBT U0RBVEEgKGtleWZpbGUpLCBmaWxlX2Zvcm1hdCwKKwkJICAgTlVMTCwga2V5X2ZpbGUyX2F1eCAo ZmxhZ3MpKTsKKwkgICAgICBlbHNlCisJCXJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUw OV9rZXlfZmlsZQorCQkgICh4NTA5X2NyZWQsIFNTREFUQSAoY2VydGZpbGUpLCBTU0RBVEEgKGtl eWZpbGUpLCBmaWxlX2Zvcm1hdCk7CisjIGVsc2UKIAkgICAgICByZXQgPSBnbnV0bHNfY2VydGlm aWNhdGVfc2V0X3g1MDlfa2V5X2ZpbGUKIAkJKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSks IFNTREFUQSAoa2V5ZmlsZSksIGZpbGVfZm9ybWF0KTsKKyMgZW5kaWYKIAogCSAgICAgIGlmIChy ZXQgPCBHTlVUTFNfRV9TVUNDRVNTKQogCQlyZXR1cm4gZ251dGxzX21ha2VfZXJyb3IgKHJldCk7 CkBAIC0yODYwLDggKzI5NjMsMjYgQEAgc3ltc19vZl9nbnV0bHMgKHZvaWQpCiAgIERFRlNZTSAo UUNtaW5fcHJpbWVfYml0cywgIjptaW4tcHJpbWUtYml0cyIpOwogICBERUZTWU0gKFFDbG9nbGV2 ZWwsICI6bG9nbGV2ZWwiKTsKICAgREVGU1lNIChRQ2NvbXBsZXRlX25lZ290aWF0aW9uLCAiOmNv bXBsZXRlLW5lZ290aWF0aW9uIik7CisgIERFRlNZTSAoUUNwYXNzLCAiOnBhc3MiKTsKKyAgREVG U1lNIChRQ2ZsYWdzLCAiOmZsYWdzIik7CiAgIERFRlNZTSAoUUN2ZXJpZnlfZmxhZ3MsICI6dmVy aWZ5LWZsYWdzIik7CiAgIERFRlNZTSAoUUN2ZXJpZnlfZXJyb3IsICI6dmVyaWZ5LWVycm9yIik7 CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BsYWluLCAiR05VVExTX1BLQ1NfUExBSU4iKTsKKyAg REVGU1lNIChRZ251dGxzX3BrY3NfcGtjczEyXzNkZXMsICJHTlVUTFNfUEtDU19QS0NTMTJfM0RF UyIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wa2NzMTJfYXJjZm91ciwgIkdOVVRMU19QS0NT X1BLQ1MxMl9BUkNGT1VSIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BrY3MxMl9yYzJfNDAs ICJHTlVUTFNfUEtDU19QS0NTMTJfUkMyXzQwIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3Bi ZXMyXzNkZXMsICJHTlVUTFNfUEtDU19QQkVTMl8zREVTIik7CisgIERFRlNZTSAoUWdudXRsc19w a2NzX3BiZXMyX2Flc18xMjgsICJHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTI4Iik7CisgIERFRlNZ TSAoUWdudXRsc19wa2NzX3BiZXMyX2Flc18xOTIsICJHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTky Iik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2Flc18yNTYsICJHTlVUTFNfUEtDU19Q QkVTMl9BRVNfMjU2Iik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX251bGxfcGFzc3dvcmQsICJH TlVUTFNfUEtDU19OVUxMX1BBU1NXT1JEIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMy X2RlcywgIkdOVVRMU19QS0NTX1BCRVMyX0RFUyIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19w YmVzMV9kZXNfbWQ1LCAiR05VVExTX1BLQ1NfUEJFUzFfREVTX01ENSIpOworICBERUZTWU0gKFFn bnV0bHNfcGtjc19wYmVzMl9nb3N0X3RjMjZ6LCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9UQzI2 WiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwYSwgIkdOVVRMU19QS0NT X1BCRVMyX0dPU1RfQ1BBIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3Bi LCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEIiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3Nf cGJlczJfZ29zdF9jcGMsICJHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQyIpOworICBERUZTWU0g KFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwZCwgIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BE Iik7CiAKICAgREVGU1lNIChRQ2NpcGhlcl9pZCwgIjpjaXBoZXItaWQiKTsKICAgREVGU1lNIChR Q2NpcGhlcl9hZWFkX2NhcGFibGUsICI6Y2lwaGVyLWFlYWQtY2FwYWJsZSIpOwotLSAKMi4zNy4z Cgo= --00000000000002483605e9e544e3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 10:32:28 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 14:32:28 +0000 Received: from localhost ([127.0.0.1]:42603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeH40-00015q-HS for submit@debbugs.gnu.org; Fri, 30 Sep 2022 10:32:28 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:38435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeH3w-00015Y-4W for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 10:32:27 -0400 Received: by mail-wm1-f41.google.com with SMTP id c192-20020a1c35c9000000b003b51339d350so5147131wma.3 for <50507@debbugs.gnu.org>; Fri, 30 Sep 2022 07:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=YuOXHEZ7xM9pvWQvlX5Bt3d0GPecRabWcWXrPm+5kYI=; b=JCZE7Jh3FONon2vUhauKaEGb+8yC+jUST/cAjTXLFm6EdROzqjGw2L98NfqUwIEupb 9D/1jadgkh7bqgE5nuBtyX+nr0EVmWvtosu1+BXs17nfZy6tW3kAdpR+RnPT4Hnu1fff uCF5rA3rp2055BpFyFN6nNBJtSWPLeqqp3RgsVKweQhDzDqGpRUhlMOhpfQ076LyJQil 07PsvRW8UauT/hG/3iwkhf6LaHWWkoUpYGcySqkDZbibNNDO8d7/jcKIc5GPUB2YcAam hVwtRMQlkzEGHgUzd44NtPOt6owCPxJq2lHdxK0+xGpjhYTgGFyEdjJBg846nUrOoP8W U5lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=YuOXHEZ7xM9pvWQvlX5Bt3d0GPecRabWcWXrPm+5kYI=; b=5k/EvenSJmc+9YU6GCBXTCPEcf0zWQnAuCwoPo4Ncq8fZXpFYVXKrSNecDN7XiOOYZ MNJ9jf2tO3JOeyJDbwG0bWqxxwke9Vthb8V23OFN9dPh4DIO1BXqOYAgzgUzlTOUlLYR 2cP+VGG+nTIwBOCLBYfygYdLMeVbxdyVmX6Yv092974CfjNZXT/5bN+UTREWky7HMYyK gRkDhhc/k/mejTJYT7bko4acTSdBO0/nQHrJnbHJSwOKqKn6tLAm8V7ko8NaL7T2o25h 6iTUmroHNy2LNFS0Q0n0b1nqx9s3Vn7vX+TtgUVXdL3kih7IIT89mTfv4LOxy5i8EgUr 5aIQ== X-Gm-Message-State: ACrzQf0pod/JdnaBcSioUZfLpQbm1Z/2wfVieXQuDMMnd3ahltdI4IWb pe9gkE3zBlAHYm8NLSDBVOI= X-Google-Smtp-Source: AMsMyM4eI+/O2fBt1HKj9KTXpzkuPGkA2bRAJmRc8VjhUsbBWOqTVEcxGu9TtzzR6ZTY0MU1Ly8FVA== X-Received: by 2002:a05:600c:3845:b0:3b4:b187:3d09 with SMTP id s5-20020a05600c384500b003b4b1873d09mr14402552wmr.96.1664548337991; Fri, 30 Sep 2022 07:32:17 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:2c11:2d7e:10f:9126]) by smtp.gmail.com with ESMTPSA id bg29-20020a05600c3c9d00b003b47a99d928sm2588339wmb.18.2022.09.30.07.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Sep 2022 07:32:17 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Fri, 30 Sep 2022 09:49:30 -0400") References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> Date: Fri, 30 Sep 2022 16:32:16 +0200 Message-ID: <87a66haq6n.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 30 Sep 2022 09:49:30 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> +static unsigned int Nikolaos> +key_file2_aux (Lisp_Object flags) Nikolaos> +{ Nikolaos> + unsigned int rv =3D 0; Nikolaos> + Lisp_Object tail =3D flags; Nikolaos> + FOR_EACH_TAIL_SAFE (tail) Nikolaos> + { Nikolaos> + Lisp_Object flag =3D XCAR (tail); Nikolaos> + if (EQ (flag, Qgnutls_pkcs_plain)) Nikolaos> + rv |=3D GNUTLS_PKCS_PLAIN; Nikolaos> + else if(EQ (flag, Qgnutls_pkcs_pkcs12_3des)) Space after 'if' here and in the rest of the function Nikolaos> +# ifdef HAVE_GNUTLS_CERTIFICATE_SET_X509_KEY_FILE2 Nikolaos> + if (STRINGP (pass)) Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_fo= rmat, Nikolaos> + SSDATA (pass), key_file2_aux (flags)); Nikolaos> + else if (NILP (pass) && plist_member (proplist, QCpas= s)) Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_fo= rmat, Nikolaos> + NULL, key_file2_aux (flags)); Nikolaos> + else Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_fo= rmat); Nikolaos> +# else Nikolaos> ret =3D gnutls_certificate_set_x509_key_file Nikolaos> (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_form= at); Nikolaos> +# endif 2 minor points: - If you use an intermediate variable for the C version of pass, you can set it correctly based on `plist_member' etc, and only have one call to _file2 (as it is it=CA=BCs kind of difficult to quickly see the difference between the two calls) - I think you can then rework the #else/#endif here to avoid repetition of the call to the _file variant Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 30 12:22:38 2022 Received: (at 50507) by debbugs.gnu.org; 30 Sep 2022 16:22:38 +0000 Received: from localhost ([127.0.0.1]:42768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeImb-0003ue-ND for submit@debbugs.gnu.org; Fri, 30 Sep 2022 12:22:38 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:36469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oeImY-0003uQ-Es for 50507@debbugs.gnu.org; Fri, 30 Sep 2022 12:22:36 -0400 Received: by mail-yb1-f170.google.com with SMTP id 126so5848471ybw.3 for <50507@debbugs.gnu.org>; Fri, 30 Sep 2022 09:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=p/Q6BSJTS5M4Nl6xPYOYKi6ObCFu0ezw/hDKxLvHcu0=; b=SQThMwp6bajoMz8brUQU37MH4EgGu+jN5qj8nVvqUsRhEIO0fcLF4CGbdmK3SW2EZL M5ZJtcis3yRwSHD7NWqTNqKdka2a/GZt77jM+NRK2lLQ28qwj5NHVb9KjXXW2TCSwyrY QA6E1ozpOrDv4BYvma3DuLW1YSIJEMbHPyNPnyRHPXKX90GrGm/d4onp6i4RdjEetrXm 0LHeBUP93ctspR7IapYwnVKs07IpVgw6vzoK4mnTmQDbDouMdBDxCjTtd7Z9CA1O6Rfz Zb6PXhxxQFLaylkep+WyX0E5UNA6KOghmFKPPJUxfmrHh0HBoTBmHiT6JxpaIhJBgUpy UX5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=p/Q6BSJTS5M4Nl6xPYOYKi6ObCFu0ezw/hDKxLvHcu0=; b=gwdJicfXtEGlIRtcJWvCOHv8LC+H39RKsvXILYGd7Duu4x160FqiIsJub8r1V6Meuh vhwEU8tFMlNOcDkk8eWu+aJdfRAW2HTfYUtISUAOA8+uHP92jwvk5RwXeWyulj53SHiV AZR0prf5ZkpA43dZiFhoqz0rQ+CwiB9bIGyli6CQTPckCiUKQaMOkmEA/H5sADgh/4Xo pEMWopl43dTGkCNCSIHPXK+q9WJHI63KpPOao4ybh0izlDwBpCMUSS7hGDFfK1kIvkOw 0qSPLgGe5+/cNRjOsLF9NflKbCx6GDblrZhtvFOqx0eub9GqXnC4aXlMfRhS8KAfIEq0 YJkg== X-Gm-Message-State: ACrzQf1KgBQdQDDK2t31lbiYZOeU5qmnuHRDYdotTnk7LjrskcltiFEB mTgh+dv/c2MlCFOAGqrcnUVA4a8RvqQJKSgNFx8= X-Google-Smtp-Source: AMsMyM6e7PyAqvhh8YqO6kOMZcZOIrrgSptKotOKfmvxARIF0bZeEecLUhJyydbNsPrJuhHhVZYMdR9qchfcZHcKklg= X-Received: by 2002:a05:6902:8d:b0:6bc:47ea:42da with SMTP id h13-20020a056902008d00b006bc47ea42damr8510163ybs.529.1664554948377; Fri, 30 Sep 2022 09:22:28 -0700 (PDT) MIME-Version: 1.0 References: <83ee9wiozc.fsf@gnu.org> <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> In-Reply-To: <87a66haq6n.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Fri, 30 Sep 2022 12:22:16 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: multipart/mixed; boundary="000000000000690b5e05e9e7660f" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000690b5e05e9e7660f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 30, 2022 at 10:32 AM Robert Pluim wrote: > > >>>>> On Fri, 30 Sep 2022 09:49:30 -0400, Nikolaos Chatzikonstantinou said: > Nikolaos> +static unsigned int > Nikolaos> +key_file2_aux (Lisp_Object flags) > Nikolaos> +{ > Nikolaos> + unsigned int rv =3D 0; > Nikolaos> + Lisp_Object tail =3D flags; > Nikolaos> + FOR_EACH_TAIL_SAFE (tail) > Nikolaos> + { > Nikolaos> + Lisp_Object flag =3D XCAR (tail); > Nikolaos> + if (EQ (flag, Qgnutls_pkcs_plain)) > Nikolaos> + rv |=3D GNUTLS_PKCS_PLAIN; > Nikolaos> + else if(EQ (flag, Qgnutls_pkcs_pkcs12_3des)) > > Space after 'if' here and in the rest of the function > > Nikolaos> +# ifdef HAVE_GNUTLS_CERTIFICATE_SET_X509_KEY_FILE2 > Nikolaos> + if (STRINGP (pass)) > Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 > Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile)= , file_format, > Nikolaos> + SSDATA (pass), key_file2_aux (flags)); > Nikolaos> + else if (NILP (pass) && plist_member (proplist, QCp= ass)) > Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file2 > Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile)= , file_format, > Nikolaos> + NULL, key_file2_aux (flags)); > Nikolaos> + else > Nikolaos> + ret =3D gnutls_certificate_set_x509_key_file > Nikolaos> + (x509_cred, SSDATA (certfile), SSDATA (keyfile)= , file_format); > Nikolaos> +# else > Nikolaos> ret =3D gnutls_certificate_set_x509_key_file > Nikolaos> (x509_cred, SSDATA (certfile), SSDATA (keyfile), = file_format); > Nikolaos> +# endif > > 2 minor points: > > - If you use an intermediate variable for > the C version of pass, you can set it correctly based on `plist_member' > etc, and only have one call to _file2 (as it is it=CA=BCs kind of > difficult to quickly see the difference between the two calls) > - I think you can then rework the #else/#endif here to avoid repetition o= f > the call to the _file variant Thanks, I worked those out too, save for the last point you made. Do you mean this sort of thing: #if COND if (something) foo(); else bar(); #else bar(); #endif To be rewritten as #if COND if (something) foo(); else #endif bar(); Because in this case, I don't trust that kind of code to survive the test of time. Someone may come along and break it by modifying the bar() line, and it might be a sneaky bug. It's not easy to tell. --000000000000690b5e05e9e7660f Content-Type: text/x-patch; charset="US-ASCII"; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8oovi730 RnJvbSA3OTY4MmRiNTJhODI1YzUyNDAzY2M2NzFjNWQ4NGEwYzY0NjBjZGY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxp c3QKCiogbGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogQWRkIHRo ZSBrZXlzIDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiog c3JjL2dudXRscy5jIChnbnV0bHMtYm9vdCk6IEFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdz LCBhbmQKdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBBZGQgdGhl IHN5bWJvbHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0 byB0aGUgZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190YC4KKGtleV9maWxlMl9hdXgpOiBQcml2YXRlIGhlbHBlciBmdW5j dGlvbiB0aGF0IHRyYW5zbGF0ZXMgYSBsaXN0IG9mCnN5bWJvbHMgdG8gaXRzIGNvcnJlc3BvbmRp bmcgYHVuc2lnbmVkIGludGAgdmFsdWUgb2YgdGhlIEdudVRMUyBDIGVudW0KYGdudXRsc19wa2Nz X2VuY3J5cHRfZmxhZ3NfdGAuCi0tLQogbGlzcC9uZXQvZ251dGxzLmVsIHwgIDEwICsrKysKIHNy Yy9nbnV0bHMuYyAgICAgICB8IDEyMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTMzIGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9saXNwL25ldC9nbnV0bHMuZWwgYi9saXNwL25ldC9nbnV0bHMuZWwKaW5kZXggNmUzODQ1 YWVjMS4uZWVmNjU1OWE5NSAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZ251dGxzLmVsCisrKyBiL2xp c3AvbmV0L2dudXRscy5lbApAQCAtMjY1LDYgKzI2NSw3IEBAIGdudXRscy1ib290LXBhcmFtZXRl cnMKICAgICAgICAgICAgJmtleSB0eXBlIGhvc3RuYW1lIHByaW9yaXR5LXN0cmluZwogICAgICAg ICAgICB0cnVzdGZpbGVzIGNybGZpbGVzIGtleWxpc3QgbWluLXByaW1lLWJpdHMKICAgICAgICAg ICAgdmVyaWZ5LWZsYWdzIHZlcmlmeS1lcnJvciB2ZXJpZnktaG9zdG5hbWUtZXJyb3IKKyAgICAg ICAgICAgcGFzcyBmbGFncwogICAgICAgICAgICAmYWxsb3ctb3RoZXIta2V5cykKICAgIlJldHVy biBhIGtleXdvcmQgbGlzdCBvZiBwYXJhbWV0ZXJzIHN1aXRhYmxlIGZvciBwYXNzaW5nIHRvIGBn bnV0bHMtYm9vdCcuCiAKQEAgLTI4MSw2ICsyODIsMTMgQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVy cwogVkVSSUZZLUhPU1ROQU1FLUVSUk9SIGlzIGEgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgb3B0 aW9uIGZvcgogcHV0dGluZyBgOmhvc3RuYW1lJyBpbiBWRVJJRlktRVJST1IuCiAKK1BBU1MgaXMg YSBzdHJpbmcsIHRoZSBwYXNzd29yZCBvZiB0aGUga2V5LiAgSXQgbWF5IGFsc28gYmUgbmlsLAor Zm9yIGEgTlVMTCBwYXNzd29yZC4KKworRkxBR1MgaXMgYSBsaXN0IG9mIHN5bWJvbHMgY29ycmVz cG9uZGluZyB0byB0aGUgZXF1aXZhbGVudCBPUmVkCitiaXRmbGFnIG9mIHRoZSBnbnV0bHNfcGtj c19lbmNyeXB0X2ZsYWdzX3QgZW51bSBvZiBHbnVUTFMuICBUaGUKK2VtcHR5IGxpc3QgY29ycmVz cG9uZHMgdG8gdGhlIGJpdGZsYWcgd2l0aCB2YWx1ZSAwLgorCiBXaGVuIFZFUklGWS1FUlJPUiBp cyB0IG9yIGEgbGlzdCBjb250YWluaW5nIGA6dHJ1c3RmaWxlcycsIGFuCiBlcnJvciB3aWxsIGJl IHJhaXNlZCB3aGVuIHRoZSBwZWVyIGNlcnRpZmljYXRlIHZlcmlmaWNhdGlvbiBmYWlscwogYXMg cGVyIEdudVRMUycgZ251dGxzX2NlcnRpZmljYXRlX3ZlcmlmeV9wZWVyczIuICBPdGhlcndpc2Us IG9ubHkKQEAgLTM1OCw2ICszNjYsOCBAQCBnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzCiAgICAgICAg ICAgICAgICAgOmtleWxpc3QgLGtleWxpc3QKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWZsYWdz ICx2ZXJpZnktZmxhZ3MKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWVycm9yICx2ZXJpZnktZXJy b3IKKyAgICAgICAgICAgICAgICA6cGFzcyAscGFzcworICAgICAgICAgICAgICAgIDpmbGFncyAs ZmxhZ3MKICAgICAgICAgICAgICAgICA6Y2FsbGJhY2tzIG5pbCkpKQogCiAoZGVmdW4gZ251dGxz LS1nZXQtZmlsZXMgKGZpbGVzKQpkaWZmIC0tZ2l0IGEvc3JjL2dudXRscy5jIGIvc3JjL2dudXRs cy5jCmluZGV4IGEwZGUwMjM4YzQuLjY2MWE0MmI4MjYgMTAwNjQ0Ci0tLSBhL3NyYy9nbnV0bHMu YworKysgYi9zcmMvZ251dGxzLmMKQEAgLTM0LDYgKzM0LDcgQEAKICMgZW5kaWYKIAogIyBpZiBH TlVUTFNfVkVSU0lPTl9OVU1CRVIgPj0gMHgwMzAyMDAKKyMgIGRlZmluZSBIQVZFX0dOVVRMU19D RVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKICMgIGRlZmluZSBIQVZFX0dOVVRMU19DSVBI RVJfR0VUX0lWX1NJWkUKICMgZW5kaWYKIApAQCAtMTIxLDYgKzEyMiwxMSBAQCBERUZfRExMX0ZO IChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZSwKIERFRl9ETExfRk4g KGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlLAogCSAgICAoZ251dGxz X2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqLAog CSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CisjICBpZmRlZiBIQVZFX0dOVVRMU19DRVJU SUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKK0RFRl9ETExfRk4gKGludCwgZ251dGxzX2NlcnRp ZmljYXRlX3NldF94NTA5X2tleV9maWxlMiwKKwkgICAgKGdudXRsc19jZXJ0aWZpY2F0ZV9jcmVk ZW50aWFsc190LCBjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKiwKKwkgICAgIGdudXRsc194NTA5 X2NydF9mbXRfdCwgY29uc3QgY2hhciAqLCB1bnNpZ25lZCBpbnQpKTsKKyMgIGVuZGlmCiAjICBp ZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9GTiAoaW50LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAoZ251dGxzX2NlcnRp ZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMjAsOSBAQCBpbml0X2dudXRsc19m dW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNh dGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2Vy dGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyMgIGlmZGVmIEhBVkVfR05VVExT X0NFUlRJRklDQVRFX1NFVF9YNTA5X0tFWV9GSUxFMgorICBMT0FEX0RMTF9GTiAobGlicmFyeSwg Z251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMik7CisjICBlbmRpZgogIyAgaWZk ZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxpYnJhcnks IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5kaWYKQEAg LTQ1NSw2ICs0NjQsOSBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBkZWZpbmUg Z251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRpZmljYXRl X3NldF92ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlf Y3JsX2ZpbGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAjICBkZWZp bmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19jZXJ0aWZp Y2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorIyAgaWZkZWYgSEFWRV9HTlVUTFNfQ0VSVElGSUNBVEVf U0VUX1g1MDlfS0VZX0ZJTEUyCisjICAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUw OV9rZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgorIyAg ZW5kaWYKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0 IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QKICMgIGRlZmluZSBn bnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfdHJ1c3RfZmlsZSBmbl9nbnV0bHNfY2VydGlmaWNh dGVfc2V0X3g1MDlfdHJ1c3RfZmlsZQogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV90eXBl X2dldCBmbl9nbnV0bHNfY2VydGlmaWNhdGVfdHlwZV9nZXQKQEAgLTE3NzQsNiArMTc4Niw2MSBA QCBnbnV0bHNfdmVyaWZ5X2Jvb3QgKExpc3BfT2JqZWN0IHByb2MsIExpc3BfT2JqZWN0IHByb3Bs aXN0KQogICByZXR1cm4gZ251dGxzX21ha2VfZXJyb3IgKHJldCk7CiB9CiAKKyNpZmRlZiBIQVZF X0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKKworLyogSGVscGVyIGZ1bmN0 aW9uIGZvciBnbnV0bHMtYm9vdC4KKworICAgVGhlIGtleSA6ZmxhZ3MgcmVjZWl2ZXMgYSBsaXN0 IG9mIHN5bWJvbHMsIGVhY2ggb2Ygd2hpY2gKKyAgIGNvcnJlc3BvbmRzIHRvIGEgR251VExTIEMg ZmxhZywgdGhlIE9SZWQgcmVzdWx0IGlzIHRvIGJlIHBhc3NlZCB0bworICAgdGhlIGZ1bmN0aW9u IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIoKSBhcyBpdHMgbGFzdAorICAg YXJndW1lbnQuCisqLworc3RhdGljIHVuc2lnbmVkIGludAora2V5X2ZpbGUyX2F1eCAoTGlzcF9P YmplY3QgZmxhZ3MpCit7CisgIHVuc2lnbmVkIGludCBydiA9IDA7CisgIExpc3BfT2JqZWN0IHRh aWwgPSBmbGFnczsKKyAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQorICAgIHsKKyAgICAgIExp c3BfT2JqZWN0IGZsYWcgPSBYQ0FSICh0YWlsKTsKKyAgICAgIGlmIChFUSAoZmxhZywgUWdudXRs c19wa2NzX3BsYWluKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QTEFJTjsKKyAgICAgIGVsc2UgaWYg KEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGtjczEyXzNkZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NT X1BLQ1MxMl8zREVTOworICAgICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wa2Nz MTJfYXJjZm91cikpCisJcnYgfD0gR05VVExTX1BLQ1NfUEtDUzEyX0FSQ0ZPVVI7CisgICAgICBl bHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BrY3MxMl9yYzJfNDApKQorCXJ2IHw9IEdO VVRMU19QS0NTX1BLQ1MxMl9SQzJfNDA7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRs c19wa2NzX3BiZXMyXzNkZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyXzNERVM7CisgICAg ICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18xMjgpKQorCXJ2IHw9 IEdOVVRMU19QS0NTX1BCRVMyX0FFU18xMjg7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdu dXRsc19wa2NzX3BiZXMyX2Flc18xOTIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0FFU18x OTI7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18yNTYp KQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0FFU18yNTY7CisgICAgICBlbHNlIGlmIChFUSAo ZmxhZywgUWdudXRsc19wa2NzX251bGxfcGFzc3dvcmQpKQorCXJ2IHw9IEdOVVRMU19QS0NTX05V TExfUEFTU1dPUkQ7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMy X2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfREVTOworICAgICAgZWxzZSBpZiAoRVEg KGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMV9kZXNfbWQ1KSkKKwlydiB8PSBHTlVUTFNfUEtDU19Q QkVTMV9ERVNfTUQ1OworICAgICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVz Ml9nb3N0X3RjMjZ6KSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaOworICAg ICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwYSkpCisJcnYg fD0gR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEE7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywg UWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BiKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9H T1NUX0NQQjsKKyAgICAgIGVsc2UgaWYgKEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29z dF9jcGMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDOworICAgICAgZWxzZSBp ZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwZCkpCisJcnYgfD0gR05VVExT X1BLQ1NfUEJFUzJfR09TVF9DUEQ7CisgICAgfQorICByZXR1cm4gcnY7Cit9CisKKyNlbmRpZiAv KiBIQVZFX0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIgKi8KKwogREVGVU4g KCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICAg ICAgIGRvYzogLyogSW5pdGlhbGl6ZSBHbnVUTFMgY2xpZW50IGZvciBwcm9jZXNzIFBST0Mgd2l0 aCBUWVBFK1BST1BMSVNULgogQ3VycmVudGx5IG9ubHkgY2xpZW50IG1vZGUgaXMgc3VwcG9ydGVk LiAgUmV0dXJuIGEgc3VjY2Vzcy9mYWlsdXJlCkBAIC0xODEzLDYgKzE4ODAsMjEgQEAgREVGVU4g KCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogOmNv bXBsZXRlLW5lZ290aWF0aW9uLCBpZiBub24tbmlsLCB3aWxsIG1ha2UgbmVnb3RpYXRpb24gY29t cGxldGUKIGJlZm9yZSByZXR1cm5pbmcgZXZlbiBvbiBub24tYmxvY2tpbmcgc29ja2V0cy4KIAor OnBhc3MsIHRoZSBwYXNzd29yZCBvZiB0aGUgcHJpdmF0ZSBrZXkgYXMgcGVyIEdudVRMUycKK2du dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIuICBTcGVjaWZ5IGFzIG5pbCB0byBo YXZlIGEgTlVMTAorcGFzc3dvcmQuCisKKzpmbGFncywgYSBsaXN0IG9mIHN5bWJvbHMgcmVsYXRp bmcgdG8gOnBhc3MsIGVhY2ggc3BlY2lmeWluZyBhIGZsYWc6CitHTlVUTFNfUEtDU19QTEFJTiwg R05VVExTX1BLQ1NfUEtDUzEyXzNERVMsCitHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiwgR05V VExTX1BLQ1NfUEtDUzEyX1JDMl80MCwKK0dOVVRMU19QS0NTX1BCRVMyXzNERVMsIEdOVVRMU19Q S0NTX1BCRVMyX0FFU18xMjgsCitHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTkyLCBHTlVUTFNfUEtD U19QQkVTMl9BRVNfMjU2LAorR05VVExTX1BLQ1NfTlVMTF9QQVNTV09SRCwgR05VVExTX1BLQ1Nf UEJFUzJfREVTLAorR05VVExTX1BLQ1NfUEJFUzJfREVTX01ENSwgR05VVExTX1BLQ1NfUEJFUzJf R09TVF9UQzI2WiwKK0dOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BBLCBHTlVUTFNfUEtDU19QQkVT Ml9HT1NUX0NQQiwKK0dOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDLCBHTlVUTFNfUEtDU19QQkVT Ml9HT1NUX0NQRC4gIElmIG5vdAorc3BlY2lmaWVkLCBvciBpZiBuaWwsIHRoZSBiaXRmbGFnIHdp dGggdmFsdWUgMCBpcyB1c2VkLgorCiBUaGUgZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRo aXMgcHJvY2VzcyBBTkQgZ2xvYmFsbHkgZm9yIEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGln aGVyIG9yIGxvd2VyIGF0IGFueSBwb2ludCwgaXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4K QEAgLTE4MjUsNiArMTkwNyw5IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3Qs IFNnbnV0bHNfYm9vdCwgMywgMywgMCwKIGZ1bmN0aW9ucyBhcmUgdXNlZC4gIFRoaXMgZnVuY3Rp b24gYWxsb2NhdGVzIHJlc291cmNlcyB3aGljaCBjYW4gb25seQogYmUgZGVhbGxvY2F0ZWQgYnkg Y2FsbGluZyBgZ251dGxzLWRlaW5pdCcgb3IgYnkgY2FsbGluZyBpdCBhZ2Fpbi4KIAorVGhlIDpw YXNzIGFuZCA6ZmxhZ3Mga2V5cyBhcmUgaWdub3JlZCB3aXRoIG9sZCB2ZXJzaW9ucyBvZiBHbnVU TFMsIGFuZAorOmZsYWdzIGlzIGlnbm9yZWQgaWYgOnBhc3MgaXMgbm90IHNwZWNpZmllZC4KKwog VGhlIGNhbGxiYWNrcyBhbGlzdCBjYW4gaGF2ZSBhIGB2ZXJpZnknIGtleSwgYXNzb2NpYXRlZCB3 aXRoIGEKIHZlcmlmaWNhdGlvbiBmdW5jdGlvbiAoVU5VU0VEKS4KIApAQCAtMTg0MiwxMiArMTky NywxNSBAQCBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19ib290LCBTZ251dGxzX2Jvb3Qs IDMsIDMsIDAsCiAgIExpc3BfT2JqZWN0IGdsb2JhbF9pbml0OwogICBjaGFyIGNvbnN0ICpwcmlv cml0eV9zdHJpbmdfcHRyID0gIk5PUk1BTCI7IC8qIGRlZmF1bHQgcHJpb3JpdHkgc3RyaW5nLiAg Ki8KICAgY2hhciAqY19ob3N0bmFtZTsKKyAgY29uc3QgY2hhciAqY19wYXNzOwogCiAgIC8qIFBs YWNlaG9sZGVycyBmb3IgdGhlIHByb3BlcnR5IGxpc3QgZWxlbWVudHMuICAqLwogICBMaXNwX09i amVjdCBwcmlvcml0eV9zdHJpbmc7CiAgIExpc3BfT2JqZWN0IHRydXN0ZmlsZXM7CiAgIExpc3Bf T2JqZWN0IGNybGZpbGVzOwogICBMaXNwX09iamVjdCBrZXlsaXN0OworICBMaXNwX09iamVjdCBw YXNzOworICBMaXNwX09iamVjdCBmbGFnczsKICAgLyogTGlzcF9PYmplY3QgY2FsbGJhY2tzOyAq LwogICBMaXNwX09iamVjdCBsb2dsZXZlbDsKICAgTGlzcF9PYmplY3QgaG9zdG5hbWU7CkBAIC0x ODc3LDYgKzE5NjUsMTMgQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2du dXRsc19ib290LCAzLCAzLCAwLAogICBjcmxmaWxlcyAgICAgICAgICAgICAgPSBwbGlzdF9nZXQg KHByb3BsaXN0LCBRQ2NybGZpbGVzKTsKICAgbG9nbGV2ZWwgICAgICAgICAgICAgID0gcGxpc3Rf Z2V0IChwcm9wbGlzdCwgUUNsb2dsZXZlbCk7CiAgIHByaW1lX2JpdHMgICAgICAgICAgICA9IHBs aXN0X2dldCAocHJvcGxpc3QsIFFDbWluX3ByaW1lX2JpdHMpOworICBwYXNzICAgICAgICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ3Bhc3MpOworICBmbGFncyAgICAgICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2ZsYWdzKTsKKworICBpZiAoU1RSSU5HUCAo cGFzcykpCisgICAgY19wYXNzID0gU1NEQVRBIChwYXNzKTsKKyAgZWxzZQorICAgIGNfcGFzcyA9 IE5VTEw7CiAKICAgaWYgKCFTVFJJTkdQIChob3N0bmFtZSkpCiAgICAgewpAQCAtMjAzOCw4ICsy MTMzLDE4IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9v dCwgMywgMywgMCwKIAkgICAgICBrZXlmaWxlID0gYW5zaV9lbmNvZGVfZmlsZW5hbWUgKGtleWZp bGUpOwogCSAgICAgIGNlcnRmaWxlID0gYW5zaV9lbmNvZGVfZmlsZW5hbWUgKGNlcnRmaWxlKTsK ICMgZW5kaWYKKyMgaWZkZWYgSEFWRV9HTlVUTFNfQ0VSVElGSUNBVEVfU0VUX1g1MDlfS0VZX0ZJ TEUyCisJICAgICAgaWYgKHBsaXN0X21lbWJlciAocHJvcGxpc3QsIFFDcGFzcykpCisJCXJldCA9 IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIKKwkJICAoeDUwOV9jcmVkLCBT U0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChrZXlmaWxlKSwgZmlsZV9mb3JtYXQsCisJCSAgIGNf cGFzcywga2V5X2ZpbGUyX2F1eCAoZmxhZ3MpKTsKKwkgICAgICBlbHNlCisJCXJldCA9IGdudXRs c19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorCQkgICh4NTA5X2NyZWQsIFNTREFUQSAo Y2VydGZpbGUpLCBTU0RBVEEgKGtleWZpbGUpLCBmaWxlX2Zvcm1hdCk7CisjIGVsc2UKIAkgICAg ICByZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfa2V5X2ZpbGUKIAkJKHg1MDlfY3Jl ZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5ZmlsZSksIGZpbGVfZm9ybWF0KTsKKyMg ZW5kaWYKIAogCSAgICAgIGlmIChyZXQgPCBHTlVUTFNfRV9TVUNDRVNTKQogCQlyZXR1cm4gZ251 dGxzX21ha2VfZXJyb3IgKHJldCk7CkBAIC0yODYwLDggKzI5NjUsMjYgQEAgc3ltc19vZl9nbnV0 bHMgKHZvaWQpCiAgIERFRlNZTSAoUUNtaW5fcHJpbWVfYml0cywgIjptaW4tcHJpbWUtYml0cyIp OwogICBERUZTWU0gKFFDbG9nbGV2ZWwsICI6bG9nbGV2ZWwiKTsKICAgREVGU1lNIChRQ2NvbXBs ZXRlX25lZ290aWF0aW9uLCAiOmNvbXBsZXRlLW5lZ290aWF0aW9uIik7CisgIERFRlNZTSAoUUNw YXNzLCAiOnBhc3MiKTsKKyAgREVGU1lNIChRQ2ZsYWdzLCAiOmZsYWdzIik7CiAgIERFRlNZTSAo UUN2ZXJpZnlfZmxhZ3MsICI6dmVyaWZ5LWZsYWdzIik7CiAgIERFRlNZTSAoUUN2ZXJpZnlfZXJy b3IsICI6dmVyaWZ5LWVycm9yIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BsYWluLCAiR05V VExTX1BLQ1NfUExBSU4iKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGtjczEyXzNkZXMsICJH TlVUTFNfUEtDU19QS0NTMTJfM0RFUyIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wa2NzMTJf YXJjZm91ciwgIkdOVVRMU19QS0NTX1BLQ1MxMl9BUkNGT1VSIik7CisgIERFRlNZTSAoUWdudXRs c19wa2NzX3BrY3MxMl9yYzJfNDAsICJHTlVUTFNfUEtDU19QS0NTMTJfUkMyXzQwIik7CisgIERF RlNZTSAoUWdudXRsc19wa2NzX3BiZXMyXzNkZXMsICJHTlVUTFNfUEtDU19QQkVTMl8zREVTIik7 CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2Flc18xMjgsICJHTlVUTFNfUEtDU19QQkVT Ml9BRVNfMTI4Iik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2Flc18xOTIsICJHTlVU TFNfUEtDU19QQkVTMl9BRVNfMTkyIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BiZXMyX2Fl c18yNTYsICJHTlVUTFNfUEtDU19QQkVTMl9BRVNfMjU2Iik7CisgIERFRlNZTSAoUWdudXRsc19w a2NzX251bGxfcGFzc3dvcmQsICJHTlVUTFNfUEtDU19OVUxMX1BBU1NXT1JEIik7CisgIERFRlNZ TSAoUWdudXRsc19wa2NzX3BiZXMyX2RlcywgIkdOVVRMU19QS0NTX1BCRVMyX0RFUyIpOworICBE RUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMV9kZXNfbWQ1LCAiR05VVExTX1BLQ1NfUEJFUzFfREVT X01ENSIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X3RjMjZ6LCAiR05VVExT X1BLQ1NfUEJFUzJfR09TVF9UQzI2WiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9n b3N0X2NwYSwgIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BBIik7CisgIERFRlNZTSAoUWdudXRs c19wa2NzX3BiZXMyX2dvc3RfY3BiLCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEIiKTsKKyAg REVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGMsICJHTlVUTFNfUEtDU19QQkVTMl9H T1NUX0NQQyIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwZCwgIkdOVVRM U19QS0NTX1BCRVMyX0dPU1RfQ1BEIik7CiAKICAgREVGU1lNIChRQ2NpcGhlcl9pZCwgIjpjaXBo ZXItaWQiKTsKICAgREVGU1lNIChRQ2NpcGhlcl9hZWFkX2NhcGFibGUsICI6Y2lwaGVyLWFlYWQt Y2FwYWJsZSIpOwotLSAKMi4zNy4zCgo= --000000000000690b5e05e9e7660f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 03:41:06 2022 Received: (at 50507) by debbugs.gnu.org; 3 Oct 2022 07:41:06 +0000 Received: from localhost ([127.0.0.1]:48834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofG4Y-0008O9-1B for submit@debbugs.gnu.org; Mon, 03 Oct 2022 03:41:06 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:36759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofG4W-0008NW-8X for 50507@debbugs.gnu.org; Mon, 03 Oct 2022 03:41:04 -0400 Received: by mail-wr1-f45.google.com with SMTP id j7so10023249wrr.3 for <50507@debbugs.gnu.org>; Mon, 03 Oct 2022 00:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=PxYhZecjzqB9ybYWt0Odnm/CeBHBp5omD0ztcZ/TmXw=; b=L/HIYnQqbySzS4KP8C9rr2ofPu2vwyNXYA+pu0Rge62oK3yuaJnU2spqEEasCBYyJc bWnpyZbqOrNz4lscXV+LYftEBara6aPJrmkGNWXl8vLuEdMQTivBd+ZuzjCPFwIM5nV3 pIiRPdxibEKcxaXyIU9z3fs4FOFFpn+L655g5z6ekt0+7L/4SH9/LRIPJZRMXSPHLo08 AwgJYM6LR1rFrwvilEw4Wx7+LW3PCzqcZgJMg4h4lxWf1ZoxXe0Us2ndOTqHJSS1fHrt v3/tgqil20IP/ckWQReUTeJLP+28YOePVsMyVuCDXsL53hD90raurkt8usGH28qEW7/m xe+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=PxYhZecjzqB9ybYWt0Odnm/CeBHBp5omD0ztcZ/TmXw=; b=bPTirlmEHTI2RupFzIkIQVz8k4gMpzgzLg2fVMmYWkj+SDrAfT71L8MmhQBd/WMlQV /tV2fjkeYlm3iDbpn068DyhcxPgXmu9SNvfrMe7KT8LMzRWZoFTXiygosID33DLKlN48 re6bfKAEf8F0LtD7X10r2RlVLYJw5ZQCk9KPtkIH6v61yeZjyasFd5oYuX6OyvjLYLKi YKOIyJUsO2TU7KoKamxBzYybMrq0gNi+tsJNFyVWCch0oy25VuF2hevMesyPP7a0LPaA yMTFJyQ//NlkQJxAMI0FK4jmeJ4HxOFp9S+zcWlsGu8xcn9beKccyUT/I2GeyWfX/BkO HEwA== X-Gm-Message-State: ACrzQf1VkXLOoyQDMfFTeBB/tjn3C0DoHAfQ9FYECmqzh2tgnYh4sN4H T8fDjSw2QT3Muzp/WWHJtqE= X-Google-Smtp-Source: AMsMyM5cqfP/zacVciJ3iDyhkzhG6ecNn/qXP10BgtgCD1EoM9by5/v5NBrV3q2oDwjFsKs0WVoMzA== X-Received: by 2002:a5d:64c7:0:b0:22e:43a6:2801 with SMTP id f7-20020a5d64c7000000b0022e43a62801mr807892wri.612.1664782858173; Mon, 03 Oct 2022 00:40:58 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:b0c6:e2e:8ddc:c47f]) by smtp.gmail.com with ESMTPSA id i13-20020a5d55cd000000b0022ae59d472esm8792157wrw.112.2022.10.03.00.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 00:40:56 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Fri, 30 Sep 2022 12:22:16 -0400") References: <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> Date: Mon, 03 Oct 2022 09:40:56 +0200 Message-ID: <8735c5bbhz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 30 Sep 2022 12:22:16 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> #if COND Nikolaos> if (something) Nikolaos> foo(); Nikolaos> else Nikolaos> bar(); Nikolaos> #else Nikolaos> bar(); Nikolaos> #endif Nikolaos> To be rewritten as Nikolaos> #if COND Nikolaos> if (something) Nikolaos> foo(); Nikolaos> else Nikolaos> #endif Nikolaos> bar(); Nikolaos> Because in this case, I don't trust that kind of code to surv= ive the Nikolaos> test of time. Someone may come along and break it by modifyin= g the Nikolaos> bar() line, and it might be a sneaky bug. It's not easy to te= ll. In the first version there=CA=BCs the risk that one of the calls to 'bar' will be changed and the other missed. In the second version there=CA=BCs only one 'bar' to change. If someone changes the 'bar' code so it doesn=CA=BCt compile under COND, that=CA=BCs immediately obvious. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 09:00:47 2022 Received: (at 50507) by debbugs.gnu.org; 3 Oct 2022 13:00:47 +0000 Received: from localhost ([127.0.0.1]:49323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofL3u-0005Cm-9w for submit@debbugs.gnu.org; Mon, 03 Oct 2022 09:00:47 -0400 Received: from mail-yb1-f180.google.com ([209.85.219.180]:37738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofL3s-0005CZ-Bt for 50507@debbugs.gnu.org; Mon, 03 Oct 2022 09:00:45 -0400 Received: by mail-yb1-f180.google.com with SMTP id 63so12932216ybq.4 for <50507@debbugs.gnu.org>; Mon, 03 Oct 2022 06:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=CdMQTQMFg67Bwjvwc2fdPNYQGh98ImiPcm7v/OBGzsk=; b=d9mxfYntkLZs/KYdcey8ti+VmDLJsf9sQ/FBJmhsGR77ZW2Vb03dd/yPeiXc+iIoOR P9TjmYmInbmyeBaxYVz7t2g81dif1YA4NVb8nG95kxbC/KmCzF2vs9Gk0UqDfwnBMCSY PvAcY8WuxYC0OzsXGLhDM+9LG+jPc/s5m5d57mym6EjIovnG9MTl+rAtsx9tdPFLXnNl v0lFsODLfpWG8rMJX/Cem4bTAj5BX+z5/U4wSRAYpjtHHzM6ovU0X/SQZRWKtLRK69Jh Et6uw7ZMQhTya2OBsFhozIuD9FoHQ9aJW/g+NNSSBaIGGkDPgHT5zDUyYQ7IPQx+xM2p pD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=CdMQTQMFg67Bwjvwc2fdPNYQGh98ImiPcm7v/OBGzsk=; b=XF3+GdZt+FPULa2ESEoL3RTLbXK6dPi82C0WlClWYmCze5XQwS4jG49D5bpHjNua73 rJ4QeU8sJ564EE8vXzIsHhaPieqDfbhMDaifCG06spXDpPy9dnCTvikRK6IIaM8ehuvH KQY81hs8QmyeqyRdIXMhEAI8Klm+YVNDUBKgN4+NMUpK53rA3pI+RrNbrn0qErRZAudy HxKapvodozjYkCCngtB85IN5ZnLSx0jgNUpc4tjIjUW0K2Pzv3kvtTxFC5z/tFM/DpL7 Ej46yhrWC2dMaJciwspuXMBqhsupubN9p8UWzPPx4KFAG6vDgSCDFcyBArSpM9l/KpPY qCiA== X-Gm-Message-State: ACrzQf1bQ2oxj8jHAV6hW8TN67twMGWaX6hhO7Hd3HxbQVydgWbEm52W EGUfQww7xM79KE7KTqnDBuO1Wd9S2lXmg3J9rBg= X-Google-Smtp-Source: AMsMyM57QhVDZ8BrG/q2enRg/NZqkrq1ZJVx2qoj5CKfbgzNjaFHVCd7bESTdkzD0X3v+BJ2Dkn16gUGP7nqNr8CGfk= X-Received: by 2002:a05:6902:92:b0:6b2:bed3:5eec with SMTP id h18-20020a056902009200b006b2bed35eecmr18405786ybs.60.1664802037917; Mon, 03 Oct 2022 06:00:37 -0700 (PDT) MIME-Version: 1.0 References: <87sflkgy49.fsf@gnus.org> <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> In-Reply-To: <8735c5bbhz.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Mon, 3 Oct 2022 09:00:26 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: multipart/mixed; boundary="000000000000180b1005ea20eea9" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000180b1005ea20eea9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 3, 2022 at 3:40 AM Robert Pluim wrote: > > >>>>> On Fri, 30 Sep 2022 12:22:16 -0400, Nikolaos Chatzikonstantinou said: > Nikolaos> #if COND > Nikolaos> if (something) > Nikolaos> foo(); > Nikolaos> else > Nikolaos> bar(); > Nikolaos> #else > Nikolaos> bar(); > Nikolaos> #endif > > Nikolaos> To be rewritten as > > Nikolaos> #if COND > Nikolaos> if (something) > Nikolaos> foo(); > Nikolaos> else > Nikolaos> #endif > Nikolaos> bar(); > > Nikolaos> Because in this case, I don't trust that kind of code to su= rvive the > Nikolaos> test of time. Someone may come along and break it by modify= ing the > Nikolaos> bar() line, and it might be a sneaky bug. It's not easy to = tell. > > In the first version there=CA=BCs the risk that one of the calls to 'bar' > will be changed and the other missed. > > In the second version there=CA=BCs only one 'bar' to change. If someone > changes the 'bar' code so it doesn=CA=BCt compile under COND, that=CA=BCs > immediately obvious. Okay then, I have the fixed patch here. --000000000000180b1005ea20eea9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Disposition: attachment; filename="0001-add-pass-and-flags-to-gnutls-boot-for-keylist.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l8ss52fp0 RnJvbSBlODY4ODYxNDI1NjE1YWNlOWJjNWVmYThjZjBhNTFjZmEyMTMwZDIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWtvbGFvcyBDaGF0emlrb25zdGFudGlub3UgPG5jaGF0ejMx NEBnbWFpbC5jb20+CkRhdGU6IE1vbiwgMjYgU2VwIDIwMjIgMTE6MDg6MTggLTA0MDAKU3ViamVj dDogW1BBVENIXSBhZGQgOnBhc3MgYW5kIDpmbGFncyB0byBnbnV0bHMtYm9vdCBmb3IgOmtleWxp c3QKCiogbGlzcC9uZXQvZ251dGxzLmVsIChnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzKTogQWRkIHRo ZSBrZXlzIDpwYXNzIGFuZAo6ZmxhZ3MsIGFuZCB1cGRhdGUgdGhlIGRvY3VtZW50YXRpb24uCiog c3JjL2dudXRscy5jIChnbnV0bHMtYm9vdCk6IEFkZCB0aGUga2V5cyA6cGFzcyBhbmQgOmZsYWdz LCBhbmQKdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uLgooc3ltc19vZl9nbnV0bHMpOiBBZGQgdGhl IHN5bWJvbHMgOnBhc3MsIDpmbGFncywgYW5kIHRoZSBzeW1ib2xzIHRoYXQKY29ycmVzcG9uZCB0 byB0aGUgZW51bWVyYXRpb24gY29uc3RhbnRzIG9mIHRoZSBHbnVUTFMgZW51bQpgZ251dGxzX3Br Y3NfZW5jcnlwdF9mbGFnc190YC4KKGtleV9maWxlMl9hdXgpOiBQcml2YXRlIGhlbHBlciBmdW5j dGlvbiB0aGF0IHRyYW5zbGF0ZXMgYSBsaXN0IG9mCnN5bWJvbHMgdG8gaXRzIGNvcnJlc3BvbmRp bmcgYHVuc2lnbmVkIGludGAgdmFsdWUgb2YgdGhlIEdudVRMUyBDIGVudW0KYGdudXRsc19wa2Nz X2VuY3J5cHRfZmxhZ3NfdGAuCi0tLQogbGlzcC9uZXQvZ251dGxzLmVsIHwgIDEwICsrKysKIHNy Yy9nbnV0bHMuYyAgICAgICB8IDEyMCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTMwIGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9saXNwL25ldC9nbnV0bHMuZWwgYi9saXNwL25ldC9nbnV0bHMuZWwKaW5kZXggNmUzODQ1 YWVjMS4uZWVmNjU1OWE5NSAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZ251dGxzLmVsCisrKyBiL2xp c3AvbmV0L2dudXRscy5lbApAQCAtMjY1LDYgKzI2NSw3IEBAIGdudXRscy1ib290LXBhcmFtZXRl cnMKICAgICAgICAgICAgJmtleSB0eXBlIGhvc3RuYW1lIHByaW9yaXR5LXN0cmluZwogICAgICAg ICAgICB0cnVzdGZpbGVzIGNybGZpbGVzIGtleWxpc3QgbWluLXByaW1lLWJpdHMKICAgICAgICAg ICAgdmVyaWZ5LWZsYWdzIHZlcmlmeS1lcnJvciB2ZXJpZnktaG9zdG5hbWUtZXJyb3IKKyAgICAg ICAgICAgcGFzcyBmbGFncwogICAgICAgICAgICAmYWxsb3ctb3RoZXIta2V5cykKICAgIlJldHVy biBhIGtleXdvcmQgbGlzdCBvZiBwYXJhbWV0ZXJzIHN1aXRhYmxlIGZvciBwYXNzaW5nIHRvIGBn bnV0bHMtYm9vdCcuCiAKQEAgLTI4MSw2ICsyODIsMTMgQEAgZ251dGxzLWJvb3QtcGFyYW1ldGVy cwogVkVSSUZZLUhPU1ROQU1FLUVSUk9SIGlzIGEgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgb3B0 aW9uIGZvcgogcHV0dGluZyBgOmhvc3RuYW1lJyBpbiBWRVJJRlktRVJST1IuCiAKK1BBU1MgaXMg YSBzdHJpbmcsIHRoZSBwYXNzd29yZCBvZiB0aGUga2V5LiAgSXQgbWF5IGFsc28gYmUgbmlsLAor Zm9yIGEgTlVMTCBwYXNzd29yZC4KKworRkxBR1MgaXMgYSBsaXN0IG9mIHN5bWJvbHMgY29ycmVz cG9uZGluZyB0byB0aGUgZXF1aXZhbGVudCBPUmVkCitiaXRmbGFnIG9mIHRoZSBnbnV0bHNfcGtj c19lbmNyeXB0X2ZsYWdzX3QgZW51bSBvZiBHbnVUTFMuICBUaGUKK2VtcHR5IGxpc3QgY29ycmVz cG9uZHMgdG8gdGhlIGJpdGZsYWcgd2l0aCB2YWx1ZSAwLgorCiBXaGVuIFZFUklGWS1FUlJPUiBp cyB0IG9yIGEgbGlzdCBjb250YWluaW5nIGA6dHJ1c3RmaWxlcycsIGFuCiBlcnJvciB3aWxsIGJl IHJhaXNlZCB3aGVuIHRoZSBwZWVyIGNlcnRpZmljYXRlIHZlcmlmaWNhdGlvbiBmYWlscwogYXMg cGVyIEdudVRMUycgZ251dGxzX2NlcnRpZmljYXRlX3ZlcmlmeV9wZWVyczIuICBPdGhlcndpc2Us IG9ubHkKQEAgLTM1OCw2ICszNjYsOCBAQCBnbnV0bHMtYm9vdC1wYXJhbWV0ZXJzCiAgICAgICAg ICAgICAgICAgOmtleWxpc3QgLGtleWxpc3QKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWZsYWdz ICx2ZXJpZnktZmxhZ3MKICAgICAgICAgICAgICAgICA6dmVyaWZ5LWVycm9yICx2ZXJpZnktZXJy b3IKKyAgICAgICAgICAgICAgICA6cGFzcyAscGFzcworICAgICAgICAgICAgICAgIDpmbGFncyAs ZmxhZ3MKICAgICAgICAgICAgICAgICA6Y2FsbGJhY2tzIG5pbCkpKQogCiAoZGVmdW4gZ251dGxz LS1nZXQtZmlsZXMgKGZpbGVzKQpkaWZmIC0tZ2l0IGEvc3JjL2dudXRscy5jIGIvc3JjL2dudXRs cy5jCmluZGV4IGEwZGUwMjM4YzQuLjE1MjJkYWMxYjggMTAwNjQ0Ci0tLSBhL3NyYy9nbnV0bHMu YworKysgYi9zcmMvZ251dGxzLmMKQEAgLTM0LDYgKzM0LDcgQEAKICMgZW5kaWYKIAogIyBpZiBH TlVUTFNfVkVSU0lPTl9OVU1CRVIgPj0gMHgwMzAyMDAKKyMgIGRlZmluZSBIQVZFX0dOVVRMU19D RVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKICMgIGRlZmluZSBIQVZFX0dOVVRMU19DSVBI RVJfR0VUX0lWX1NJWkUKICMgZW5kaWYKIApAQCAtMTIxLDYgKzEyMiwxMSBAQCBERUZfRExMX0ZO IChpbnQsIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9jcmxfZmlsZSwKIERFRl9ETExfRk4g KGludCwgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlLAogCSAgICAoZ251dGxz X2NlcnRpZmljYXRlX2NyZWRlbnRpYWxzX3QsIGNvbnN0IGNoYXIgKiwgY29uc3QgY2hhciAqLAog CSAgICAgZ251dGxzX3g1MDlfY3J0X2ZtdF90KSk7CisjICBpZmRlZiBIQVZFX0dOVVRMU19DRVJU SUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKK0RFRl9ETExfRk4gKGludCwgZ251dGxzX2NlcnRp ZmljYXRlX3NldF94NTA5X2tleV9maWxlMiwKKwkgICAgKGdudXRsc19jZXJ0aWZpY2F0ZV9jcmVk ZW50aWFsc190LCBjb25zdCBjaGFyICosIGNvbnN0IGNoYXIgKiwKKwkgICAgIGdudXRsc194NTA5 X2NydF9mbXRfdCwgY29uc3QgY2hhciAqLCB1bnNpZ25lZCBpbnQpKTsKKyMgIGVuZGlmCiAjICBp ZmRlZiBIQVZFX0dOVVRMU19YNTA5X1NZU1RFTV9UUlVTVAogREVGX0RMTF9GTiAoaW50LCBnbnV0 bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0LAogCSAgICAoZ251dGxzX2NlcnRp ZmljYXRlX2NyZWRlbnRpYWxzX3QpKTsKQEAgLTMxNCw2ICszMjAsOSBAQCBpbml0X2dudXRsc19m dW5jdGlvbnMgKHZvaWQpCiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2VydGlmaWNh dGVfc2V0X3ZlcmlmeV9mbGFncyk7CiAgIExPQURfRExMX0ZOIChsaWJyYXJ5LCBnbnV0bHNfY2Vy dGlmaWNhdGVfc2V0X3g1MDlfY3JsX2ZpbGUpOwogICBMT0FEX0RMTF9GTiAobGlicmFyeSwgZ251 dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlKTsKKyMgIGlmZGVmIEhBVkVfR05VVExT X0NFUlRJRklDQVRFX1NFVF9YNTA5X0tFWV9GSUxFMgorICBMT0FEX0RMTF9GTiAobGlicmFyeSwg Z251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMik7CisjICBlbmRpZgogIyAgaWZk ZWYgSEFWRV9HTlVUTFNfWDUwOV9TWVNURU1fVFJVU1QKICAgTE9BRF9ETExfRk4gKGxpYnJhcnks IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QpOwogIyAgZW5kaWYKQEAg LTQ1NSw2ICs0NjQsOSBAQCBpbml0X2dudXRsc19mdW5jdGlvbnMgKHZvaWQpCiAjICBkZWZpbmUg Z251dGxzX2NlcnRpZmljYXRlX3NldF92ZXJpZnlfZmxhZ3MgZm5fZ251dGxzX2NlcnRpZmljYXRl X3NldF92ZXJpZnlfZmxhZ3MKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlf Y3JsX2ZpbGUgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2NybF9maWxlCiAjICBkZWZp bmUgZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlIGZuX2dudXRsc19jZXJ0aWZp Y2F0ZV9zZXRfeDUwOV9rZXlfZmlsZQorIyAgaWZkZWYgSEFWRV9HTlVUTFNfQ0VSVElGSUNBVEVf U0VUX1g1MDlfS0VZX0ZJTEUyCisjICAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUw OV9rZXlfZmlsZTIgZm5fZ251dGxzX2NlcnRpZmljYXRlX3NldF94NTA5X2tleV9maWxlMgorIyAg ZW5kaWYKICMgIGRlZmluZSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfc3lzdGVtX3RydXN0 IGZuX2dudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9zeXN0ZW1fdHJ1c3QKICMgIGRlZmluZSBn bnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfdHJ1c3RfZmlsZSBmbl9nbnV0bHNfY2VydGlmaWNh dGVfc2V0X3g1MDlfdHJ1c3RfZmlsZQogIyAgZGVmaW5lIGdudXRsc19jZXJ0aWZpY2F0ZV90eXBl X2dldCBmbl9nbnV0bHNfY2VydGlmaWNhdGVfdHlwZV9nZXQKQEAgLTE3NzQsNiArMTc4Niw2MSBA QCBnbnV0bHNfdmVyaWZ5X2Jvb3QgKExpc3BfT2JqZWN0IHByb2MsIExpc3BfT2JqZWN0IHByb3Bs aXN0KQogICByZXR1cm4gZ251dGxzX21ha2VfZXJyb3IgKHJldCk7CiB9CiAKKyNpZmRlZiBIQVZF X0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIKKworLyogSGVscGVyIGZ1bmN0 aW9uIGZvciBnbnV0bHMtYm9vdC4KKworICAgVGhlIGtleSA6ZmxhZ3MgcmVjZWl2ZXMgYSBsaXN0 IG9mIHN5bWJvbHMsIGVhY2ggb2Ygd2hpY2gKKyAgIGNvcnJlc3BvbmRzIHRvIGEgR251VExTIEMg ZmxhZywgdGhlIE9SZWQgcmVzdWx0IGlzIHRvIGJlIHBhc3NlZCB0bworICAgdGhlIGZ1bmN0aW9u IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIoKSBhcyBpdHMgbGFzdAorICAg YXJndW1lbnQuCisqLworc3RhdGljIHVuc2lnbmVkIGludAora2V5X2ZpbGUyX2F1eCAoTGlzcF9P YmplY3QgZmxhZ3MpCit7CisgIHVuc2lnbmVkIGludCBydiA9IDA7CisgIExpc3BfT2JqZWN0IHRh aWwgPSBmbGFnczsKKyAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQorICAgIHsKKyAgICAgIExp c3BfT2JqZWN0IGZsYWcgPSBYQ0FSICh0YWlsKTsKKyAgICAgIGlmIChFUSAoZmxhZywgUWdudXRs c19wa2NzX3BsYWluKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QTEFJTjsKKyAgICAgIGVsc2UgaWYg KEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGtjczEyXzNkZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NT X1BLQ1MxMl8zREVTOworICAgICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wa2Nz MTJfYXJjZm91cikpCisJcnYgfD0gR05VVExTX1BLQ1NfUEtDUzEyX0FSQ0ZPVVI7CisgICAgICBl bHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BrY3MxMl9yYzJfNDApKQorCXJ2IHw9IEdO VVRMU19QS0NTX1BLQ1MxMl9SQzJfNDA7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRs c19wa2NzX3BiZXMyXzNkZXMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyXzNERVM7CisgICAg ICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18xMjgpKQorCXJ2IHw9 IEdOVVRMU19QS0NTX1BCRVMyX0FFU18xMjg7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdu dXRsc19wa2NzX3BiZXMyX2Flc18xOTIpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0FFU18x OTI7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMyX2Flc18yNTYp KQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0FFU18yNTY7CisgICAgICBlbHNlIGlmIChFUSAo ZmxhZywgUWdudXRsc19wa2NzX251bGxfcGFzc3dvcmQpKQorCXJ2IHw9IEdOVVRMU19QS0NTX05V TExfUEFTU1dPUkQ7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywgUWdudXRsc19wa2NzX3BiZXMy X2RlcykpCisJcnYgfD0gR05VVExTX1BLQ1NfUEJFUzJfREVTOworICAgICAgZWxzZSBpZiAoRVEg KGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMV9kZXNfbWQ1KSkKKwlydiB8PSBHTlVUTFNfUEtDU19Q QkVTMV9ERVNfTUQ1OworICAgICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVz Ml9nb3N0X3RjMjZ6KSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9HT1NUX1RDMjZaOworICAg ICAgZWxzZSBpZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwYSkpCisJcnYg fD0gR05VVExTX1BLQ1NfUEJFUzJfR09TVF9DUEE7CisgICAgICBlbHNlIGlmIChFUSAoZmxhZywg UWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BiKSkKKwlydiB8PSBHTlVUTFNfUEtDU19QQkVTMl9H T1NUX0NQQjsKKyAgICAgIGVsc2UgaWYgKEVRIChmbGFnLCBRZ251dGxzX3BrY3NfcGJlczJfZ29z dF9jcGMpKQorCXJ2IHw9IEdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDOworICAgICAgZWxzZSBp ZiAoRVEgKGZsYWcsIFFnbnV0bHNfcGtjc19wYmVzMl9nb3N0X2NwZCkpCisJcnYgfD0gR05VVExT X1BLQ1NfUEJFUzJfR09TVF9DUEQ7CisgICAgfQorICByZXR1cm4gcnY7Cit9CisKKyNlbmRpZiAv KiBIQVZFX0dOVVRMU19DRVJUSUZJQ0FURV9TRVRfWDUwOV9LRVlfRklMRTIgKi8KKwogREVGVU4g KCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogICAg ICAgIGRvYzogLyogSW5pdGlhbGl6ZSBHbnVUTFMgY2xpZW50IGZvciBwcm9jZXNzIFBST0Mgd2l0 aCBUWVBFK1BST1BMSVNULgogQ3VycmVudGx5IG9ubHkgY2xpZW50IG1vZGUgaXMgc3VwcG9ydGVk LiAgUmV0dXJuIGEgc3VjY2Vzcy9mYWlsdXJlCkBAIC0xODEzLDYgKzE4ODAsMjEgQEAgREVGVU4g KCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2dudXRsc19ib290LCAzLCAzLCAwLAogOmNv bXBsZXRlLW5lZ290aWF0aW9uLCBpZiBub24tbmlsLCB3aWxsIG1ha2UgbmVnb3RpYXRpb24gY29t cGxldGUKIGJlZm9yZSByZXR1cm5pbmcgZXZlbiBvbiBub24tYmxvY2tpbmcgc29ja2V0cy4KIAor OnBhc3MsIHRoZSBwYXNzd29yZCBvZiB0aGUgcHJpdmF0ZSBrZXkgYXMgcGVyIEdudVRMUycKK2du dXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9rZXlfZmlsZTIuICBTcGVjaWZ5IGFzIG5pbCB0byBo YXZlIGEgTlVMTAorcGFzc3dvcmQuCisKKzpmbGFncywgYSBsaXN0IG9mIHN5bWJvbHMgcmVsYXRp bmcgdG8gOnBhc3MsIGVhY2ggc3BlY2lmeWluZyBhIGZsYWc6CitHTlVUTFNfUEtDU19QTEFJTiwg R05VVExTX1BLQ1NfUEtDUzEyXzNERVMsCitHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiwgR05V VExTX1BLQ1NfUEtDUzEyX1JDMl80MCwKK0dOVVRMU19QS0NTX1BCRVMyXzNERVMsIEdOVVRMU19Q S0NTX1BCRVMyX0FFU18xMjgsCitHTlVUTFNfUEtDU19QQkVTMl9BRVNfMTkyLCBHTlVUTFNfUEtD U19QQkVTMl9BRVNfMjU2LAorR05VVExTX1BLQ1NfTlVMTF9QQVNTV09SRCwgR05VVExTX1BLQ1Nf UEJFUzJfREVTLAorR05VVExTX1BLQ1NfUEJFUzJfREVTX01ENSwgR05VVExTX1BLQ1NfUEJFUzJf R09TVF9UQzI2WiwKK0dOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BBLCBHTlVUTFNfUEtDU19QQkVT Ml9HT1NUX0NQQiwKK0dOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BDLCBHTlVUTFNfUEtDU19QQkVT Ml9HT1NUX0NQRC4gIElmIG5vdAorc3BlY2lmaWVkLCBvciBpZiBuaWwsIHRoZSBiaXRmbGFnIHdp dGggdmFsdWUgMCBpcyB1c2VkLgorCiBUaGUgZGVidWcgbGV2ZWwgd2lsbCBiZSBzZXQgZm9yIHRo aXMgcHJvY2VzcyBBTkQgZ2xvYmFsbHkgZm9yIEdudVRMUy4KIFNvIGlmIHlvdSBzZXQgaXQgaGln aGVyIG9yIGxvd2VyIGF0IGFueSBwb2ludCwgaXQgYWZmZWN0cyBnbG9iYWwKIGRlYnVnZ2luZy4K QEAgLTE4MjUsNiArMTkwNyw5IEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3Qs IFNnbnV0bHNfYm9vdCwgMywgMywgMCwKIGZ1bmN0aW9ucyBhcmUgdXNlZC4gIFRoaXMgZnVuY3Rp b24gYWxsb2NhdGVzIHJlc291cmNlcyB3aGljaCBjYW4gb25seQogYmUgZGVhbGxvY2F0ZWQgYnkg Y2FsbGluZyBgZ251dGxzLWRlaW5pdCcgb3IgYnkgY2FsbGluZyBpdCBhZ2Fpbi4KIAorVGhlIDpw YXNzIGFuZCA6ZmxhZ3Mga2V5cyBhcmUgaWdub3JlZCB3aXRoIG9sZCB2ZXJzaW9ucyBvZiBHbnVU TFMsIGFuZAorOmZsYWdzIGlzIGlnbm9yZWQgaWYgOnBhc3MgaXMgbm90IHNwZWNpZmllZC4KKwog VGhlIGNhbGxiYWNrcyBhbGlzdCBjYW4gaGF2ZSBhIGB2ZXJpZnknIGtleSwgYXNzb2NpYXRlZCB3 aXRoIGEKIHZlcmlmaWNhdGlvbiBmdW5jdGlvbiAoVU5VU0VEKS4KIApAQCAtMTg0MiwxMiArMTky NywxNSBAQCBERUZVTiAoImdudXRscy1ib290IiwgRmdudXRsc19ib290LCBTZ251dGxzX2Jvb3Qs IDMsIDMsIDAsCiAgIExpc3BfT2JqZWN0IGdsb2JhbF9pbml0OwogICBjaGFyIGNvbnN0ICpwcmlv cml0eV9zdHJpbmdfcHRyID0gIk5PUk1BTCI7IC8qIGRlZmF1bHQgcHJpb3JpdHkgc3RyaW5nLiAg Ki8KICAgY2hhciAqY19ob3N0bmFtZTsKKyAgY29uc3QgY2hhciAqY19wYXNzOwogCiAgIC8qIFBs YWNlaG9sZGVycyBmb3IgdGhlIHByb3BlcnR5IGxpc3QgZWxlbWVudHMuICAqLwogICBMaXNwX09i amVjdCBwcmlvcml0eV9zdHJpbmc7CiAgIExpc3BfT2JqZWN0IHRydXN0ZmlsZXM7CiAgIExpc3Bf T2JqZWN0IGNybGZpbGVzOwogICBMaXNwX09iamVjdCBrZXlsaXN0OworICBMaXNwX09iamVjdCBw YXNzOworICBMaXNwX09iamVjdCBmbGFnczsKICAgLyogTGlzcF9PYmplY3QgY2FsbGJhY2tzOyAq LwogICBMaXNwX09iamVjdCBsb2dsZXZlbDsKICAgTGlzcF9PYmplY3QgaG9zdG5hbWU7CkBAIC0x ODc3LDYgKzE5NjUsMTMgQEAgREVGVU4gKCJnbnV0bHMtYm9vdCIsIEZnbnV0bHNfYm9vdCwgU2du dXRsc19ib290LCAzLCAzLCAwLAogICBjcmxmaWxlcyAgICAgICAgICAgICAgPSBwbGlzdF9nZXQg KHByb3BsaXN0LCBRQ2NybGZpbGVzKTsKICAgbG9nbGV2ZWwgICAgICAgICAgICAgID0gcGxpc3Rf Z2V0IChwcm9wbGlzdCwgUUNsb2dsZXZlbCk7CiAgIHByaW1lX2JpdHMgICAgICAgICAgICA9IHBs aXN0X2dldCAocHJvcGxpc3QsIFFDbWluX3ByaW1lX2JpdHMpOworICBwYXNzICAgICAgICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ3Bhc3MpOworICBmbGFncyAgICAgICAgICAg ICAgICAgPSBwbGlzdF9nZXQgKHByb3BsaXN0LCBRQ2ZsYWdzKTsKKworICBpZiAoU1RSSU5HUCAo cGFzcykpCisgICAgY19wYXNzID0gU1NEQVRBIChwYXNzKTsKKyAgZWxzZQorICAgIGNfcGFzcyA9 IE5VTEw7CiAKICAgaWYgKCFTVFJJTkdQIChob3N0bmFtZSkpCiAgICAgewpAQCAtMjAzNyw2ICsy MTMyLDEzIEBAIERFRlVOICgiZ251dGxzLWJvb3QiLCBGZ251dGxzX2Jvb3QsIFNnbnV0bHNfYm9v dCwgMywgMywgMCwKICMgaWZkZWYgV0lORE9XU05UCiAJICAgICAga2V5ZmlsZSA9IGFuc2lfZW5j b2RlX2ZpbGVuYW1lIChrZXlmaWxlKTsKIAkgICAgICBjZXJ0ZmlsZSA9IGFuc2lfZW5jb2RlX2Zp bGVuYW1lIChjZXJ0ZmlsZSk7CisjIGVuZGlmCisjIGlmZGVmIEhBVkVfR05VVExTX0NFUlRJRklD QVRFX1NFVF9YNTA5X0tFWV9GSUxFMgorCSAgICAgIGlmIChwbGlzdF9tZW1iZXIgKHByb3BsaXN0 LCBRQ3Bhc3MpKQorCQlyZXQgPSBnbnV0bHNfY2VydGlmaWNhdGVfc2V0X3g1MDlfa2V5X2ZpbGUy CisJCSAgKHg1MDlfY3JlZCwgU1NEQVRBIChjZXJ0ZmlsZSksIFNTREFUQSAoa2V5ZmlsZSksIGZp bGVfZm9ybWF0LAorCQkgICBjX3Bhc3MsIGtleV9maWxlMl9hdXggKGZsYWdzKSk7CisJICAgICAg ZWxzZQogIyBlbmRpZgogCSAgICAgIHJldCA9IGdudXRsc19jZXJ0aWZpY2F0ZV9zZXRfeDUwOV9r ZXlfZmlsZQogCQkoeDUwOV9jcmVkLCBTU0RBVEEgKGNlcnRmaWxlKSwgU1NEQVRBIChrZXlmaWxl KSwgZmlsZV9mb3JtYXQpOwpAQCAtMjg2MCw4ICsyOTYyLDI2IEBAIHN5bXNfb2ZfZ251dGxzICh2 b2lkKQogICBERUZTWU0gKFFDbWluX3ByaW1lX2JpdHMsICI6bWluLXByaW1lLWJpdHMiKTsKICAg REVGU1lNIChRQ2xvZ2xldmVsLCAiOmxvZ2xldmVsIik7CiAgIERFRlNZTSAoUUNjb21wbGV0ZV9u ZWdvdGlhdGlvbiwgIjpjb21wbGV0ZS1uZWdvdGlhdGlvbiIpOworICBERUZTWU0gKFFDcGFzcywg IjpwYXNzIik7CisgIERFRlNZTSAoUUNmbGFncywgIjpmbGFncyIpOwogICBERUZTWU0gKFFDdmVy aWZ5X2ZsYWdzLCAiOnZlcmlmeS1mbGFncyIpOwogICBERUZTWU0gKFFDdmVyaWZ5X2Vycm9yLCAi OnZlcmlmeS1lcnJvciIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wbGFpbiwgIkdOVVRMU19Q S0NTX1BMQUlOIik7CisgIERFRlNZTSAoUWdudXRsc19wa2NzX3BrY3MxMl8zZGVzLCAiR05VVExT X1BLQ1NfUEtDUzEyXzNERVMiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGtjczEyX2FyY2Zv dXIsICJHTlVUTFNfUEtDU19QS0NTMTJfQVJDRk9VUiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtj c19wa2NzMTJfcmMyXzQwLCAiR05VVExTX1BLQ1NfUEtDUzEyX1JDMl80MCIpOworICBERUZTWU0g KFFnbnV0bHNfcGtjc19wYmVzMl8zZGVzLCAiR05VVExTX1BLQ1NfUEJFUzJfM0RFUyIpOworICBE RUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMTI4LCAiR05VVExTX1BLQ1NfUEJFUzJfQUVT XzEyOCIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMTkyLCAiR05VVExTX1BL Q1NfUEJFUzJfQUVTXzE5MiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19wYmVzMl9hZXNfMjU2 LCAiR05VVExTX1BLQ1NfUEJFUzJfQUVTXzI1NiIpOworICBERUZTWU0gKFFnbnV0bHNfcGtjc19u dWxsX3Bhc3N3b3JkLCAiR05VVExTX1BLQ1NfTlVMTF9QQVNTV09SRCIpOworICBERUZTWU0gKFFn bnV0bHNfcGtjc19wYmVzMl9kZXMsICJHTlVUTFNfUEtDU19QQkVTMl9ERVMiKTsKKyAgREVGU1lN IChRZ251dGxzX3BrY3NfcGJlczFfZGVzX21kNSwgIkdOVVRMU19QS0NTX1BCRVMxX0RFU19NRDUi KTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF90YzI2eiwgIkdOVVRMU19QS0NT X1BCRVMyX0dPU1RfVEMyNloiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9j cGEsICJHTlVUTFNfUEtDU19QQkVTMl9HT1NUX0NQQSIpOworICBERUZTWU0gKFFnbnV0bHNfcGtj c19wYmVzMl9nb3N0X2NwYiwgIkdOVVRMU19QS0NTX1BCRVMyX0dPU1RfQ1BCIik7CisgIERFRlNZ TSAoUWdudXRsc19wa2NzX3BiZXMyX2dvc3RfY3BjLCAiR05VVExTX1BLQ1NfUEJFUzJfR09TVF9D UEMiKTsKKyAgREVGU1lNIChRZ251dGxzX3BrY3NfcGJlczJfZ29zdF9jcGQsICJHTlVUTFNfUEtD U19QQkVTMl9HT1NUX0NQRCIpOwogCiAgIERFRlNZTSAoUUNjaXBoZXJfaWQsICI6Y2lwaGVyLWlk Iik7CiAgIERFRlNZTSAoUUNjaXBoZXJfYWVhZF9jYXBhYmxlLCAiOmNpcGhlci1hZWFkLWNhcGFi bGUiKTsKLS0gCjIuMzcuMwoK --000000000000180b1005ea20eea9-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 03 09:19:09 2022 Received: (at 50507) by debbugs.gnu.org; 3 Oct 2022 13:19:09 +0000 Received: from localhost ([127.0.0.1]:49350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofLLh-0005el-BS for submit@debbugs.gnu.org; Mon, 03 Oct 2022 09:19:09 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:44989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofLLf-0005eN-BO for 50507@debbugs.gnu.org; Mon, 03 Oct 2022 09:19:07 -0400 Received: by mail-wr1-f44.google.com with SMTP id c11so16712709wrp.11 for <50507@debbugs.gnu.org>; Mon, 03 Oct 2022 06:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+j5YWHDE7GjtG9d91AFBsSFxFSuQtrMmBGJJOhwFZw8=; b=L1LGyTlfdrXvKnReUdao0mTTpaANBe8r1gJoodm6HInm6q4v3egnGDQfRLtgSQ25Bi wYSc9F50AhsYv6aONF19YLzFgyChVvsxLbOkQev9an/hnCfGRhWRTaL4oKfRC7eV5RQ0 FGbLHcKYBqGA2mzoSNX/E4kBhd9gPF88S7YyUP0fkPDO9xz/2T2Sd+FDkYp2l3K9NWuO 8qKOH3cVUqKVk+35UwtsHadgG1TOULFASaZhYU0fhQscjdGPLjriw6KiUCKOX7srIHS/ vLUwU5+oMnhHAuY4m62SCH0SFrgzhCu4dGFo/v9iVuQ8TWdgKNAdduAkEk27269JGKrI /hhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+j5YWHDE7GjtG9d91AFBsSFxFSuQtrMmBGJJOhwFZw8=; b=dpnjNQQDpTor3Z7erf7hbe3jDSlPh0mIJsNJKK3Q1yeTRLpO96xLL0X36PSYTwIQ+X afjwtVGlaEhE/ZOGgv47TjDi1arqxwGm/3zuMAuX7u4iuGxgIGicab5Pbh/5e5E9yh7u vHtGkV6/LKOcr/V25gDBqMTIbDzPprNXFmb915Mp+qGxIUEuXOh2DynIf+NI9VE7wLuK CVrtAm3jRpz7nwfhgHpceOpebamzQqohXSnYLRi4OHOm+dYtYxLKfl+bmggZUbRjuaQd 7bDReSAFb578mAbJt1jf5ICuf4OGcx14FhR9DvGusKzV/mSuGwiDf2NfHiqwPmVPwL1B toRA== X-Gm-Message-State: ACrzQf0XW8BDr+Ey32IRZp4jb+8jC0EQ2q9ul6aD9IAZv3Kw8IO7oyGX /hfDf3Pc5DOIlGKo+HA4dCY= X-Google-Smtp-Source: AMsMyM5JT8P6mUC6QCr45LSyy4rl8B9Tw1fhDcOf2rMQJ/sTquPpyGffUAySNgVUb8Mzgw3xcW1sxw== X-Received: by 2002:adf:ebcf:0:b0:22c:9eb4:d6f6 with SMTP id v15-20020adfebcf000000b0022c9eb4d6f6mr13076954wrn.251.1664803141334; Mon, 03 Oct 2022 06:19:01 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:b0c6:e2e:8ddc:c47f]) by smtp.gmail.com with ESMTPSA id m3-20020a056000008300b0022afcc11f65sm8990923wrx.47.2022.10.03.06.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 06:19:00 -0700 (PDT) From: Robert Pluim To: Nikolaos Chatzikonstantinou Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: (Nikolaos Chatzikonstantinou's message of "Mon, 3 Oct 2022 09:00:26 -0400") References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> Date: Mon, 03 Oct 2022 15:19:00 +0200 Message-ID: <87y1tx9ha3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos Chatzikonstantinou said: Nikolaos> Okay then, I have the fixed patch here. Thanks, no further comment from me, I guess we=CA=BCre waiting on the paperwork now. Regards Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 05 10:21:00 2022 Received: (at 50507) by debbugs.gnu.org; 5 Oct 2022 14:21:00 +0000 Received: from localhost ([127.0.0.1]:57765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og5Ge-0001mF-5r for submit@debbugs.gnu.org; Wed, 05 Oct 2022 10:21:00 -0400 Received: from mail-yb1-f176.google.com ([209.85.219.176]:37866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1og5Gb-0001m1-AW for 50507@debbugs.gnu.org; Wed, 05 Oct 2022 10:20:59 -0400 Received: by mail-yb1-f176.google.com with SMTP id 63so20501233ybq.4 for <50507@debbugs.gnu.org>; Wed, 05 Oct 2022 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=ViiPhcSGkOmoxcyldPe2//HdXdMNH0hBJ3eb3Nu7564=; b=c2ilCh5qsGPzU8k9tdeizsX3IRPEHOAr9XqPR/ge9be02CI0UDXRkycKtuYdhTRU2K CaW3CZP+sA+OACjcjfOeQH0ZsXqo/+hIvk8Sr2wZR8rO4YLI/Mgngv/BteEesmTtFDSv BvmziU4TwHBaIKxyJXuF8+r0yZSS75hMPkj/aToM3Ha6qn77bYTLCczuzRxxW0HvgmFX DGIvmTwkxMTdBEpH2co9zqYQEiAI/uTlM2cwUJSpLkhxvTI1ZvlxFke3LqY5atqIvaLP qu4sBSIS6OW7lU1p2CGovEq3kMU13Vu/jLNF0J6SJvdsCa+MZ+JZsBbg9h8muKxd9Uuw xf6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=ViiPhcSGkOmoxcyldPe2//HdXdMNH0hBJ3eb3Nu7564=; b=iXpHC93kHoY8M3pYEb1jOX+cL3DJlggRsTFZttpoUxZBhGnvm2aDgM53vbmqov+SkQ 0uSgHFIyaC4nVrW7N2CkiqTB6Ao1S8rkefmv5kKvoceK5G4EJr/7cWdSU4p9klObzgRH 0ZdmfiN/KD00wenQZ3rFTdIGDMdZmHOheccWhpZvRKtLlhwZa1Qexq4WpmCuCW62HQyT qfOnb1HSaCeVqo0+xzP/DW9XStx91rldce2ttZ1u509486TLWonLJe1lCj637ovqP9JY gFqqRpUCc7zOPPRdgqI+4CRU/QQKc/1GpbXyyVWXyyq2hfnviFvhi3RT0jMNh40NJY2H jgTw== X-Gm-Message-State: ACrzQf1sNu+fX9mM49mIRTdQTMOzpwzR+P6os1w0jeqNyaNnTlWvIZPH afcUDy2+9dSHv5OW1sm3188Rt07Tni/VmLVb0XU= X-Google-Smtp-Source: AMsMyM6XvlCl2uFOKJ4klD0uT9Yv/XjiU8EGwg+LaTM7DMVPM/aEBC+ALC9hr4LrGm7PoqAi8Mm5n5fyFvMb9wTcSqs= X-Received: by 2002:a05:6902:92:b0:6b2:bed3:5eec with SMTP id h18-20020a056902009200b006b2bed35eecmr116846ybs.60.1664979651721; Wed, 05 Oct 2022 07:20:51 -0700 (PDT) MIME-Version: 1.0 References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> In-Reply-To: <87y1tx9ha3.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Wed, 5 Oct 2022 10:20:40 -0400 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Mon, Oct 3, 2022 at 9:19 AM Robert Pluim wrote: > > >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos Chatzikonstantinou said: > > Nikolaos> Okay then, I have the fixed patch here. > > Thanks, no further comment from me, I guess we=CA=BCre waiting on the > paperwork now. Alas I hit a snag with the paperwork, so it will have to wait a few months.= .. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 23 10:46:34 2022 Received: (at 50507) by debbugs.gnu.org; 23 Dec 2022 15:46:34 +0000 Received: from localhost ([127.0.0.1]:37445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8kFm-0006Z6-CK for submit@debbugs.gnu.org; Fri, 23 Dec 2022 10:46:34 -0500 Received: from mail-yb1-f178.google.com ([209.85.219.178]:34541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8kFk-0006Z0-Rw for 50507@debbugs.gnu.org; Fri, 23 Dec 2022 10:46:33 -0500 Received: by mail-yb1-f178.google.com with SMTP id j206so5673007ybj.1 for <50507@debbugs.gnu.org>; Fri, 23 Dec 2022 07:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NGM6QFDVimdmzOKdQIbTV5d0EAdZEhEdqK46UWSQeqc=; b=GcvZgrU/RV8BT6gHW2PtxECXMSFfwYrNgJ+76z3VSGdGmGCvkJPjauoPHGi3yIIpHj F64S5M1L0gBrn8fALPf7PcYxfItBBJHangauUdkhpwrMxcxOsAJMa6zENtIz2+BzHUT/ 22OrB24hF/xMuup/JQB4WOP37hm5xAqSBydrn+Ef8u2+U38fMh05/c1t4fs1kOH19CL6 QHqRC9et85aWKCpIuizwfxJYNOrm2Z4JR3q9ur4ukfgT8a7C3kiJcMlnU4/Hb+JaRjrg th7IkTQwyeOk2z2rC5zhAMVo1tJkgjao0WQcEIeTZx8/NGrkB3vVc+blU/jz9ZUbQ0Bl dt1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NGM6QFDVimdmzOKdQIbTV5d0EAdZEhEdqK46UWSQeqc=; b=5FwcYfcD9tCRDKnKmPxH2+qUmHcmOyGhOKMtiGliLUiF4KN8yQ7TVUubs6jnaORfsW Z7d3rOkpscdkVU5qnaWb0fWYzp7q5v+cChHH0M3ovcOrKBWAhChXrjFto65HXG5jPWMd QPVQAI/dg8QHrKs8122zeKZqLiHuZ23HvUDpU+ARZRq5MVMfWWjiX7phfgeHoXLQlfyt ikPr21EfwE4J1gM13uM3cJJmyrAmIsT/nEQlF0Vv7/nHpjq0j05ldFK+H5l1wFeJIKQd 2dFQ5MwAqHzg1L6OS+FTNLviuOuTxZmhXMOY+VzCOlqGzRrex36vH0HxkKGQ2QOl9Gtt whpg== X-Gm-Message-State: AFqh2kpw9tTf98sYuDnpqVGBSk0p6M1BsVSshB8Qff339PgpXn4aU4ym hWL5Z7FwXwwNYpImv+eSRePAxJdd5SG5PkSoAJM= X-Google-Smtp-Source: AMrXdXtztgLI7OUNTuP2JZO6dXqC6x8XnY+iXVDbz2Km1uWMW9BJQG6GI7Mi4pE1z4pR1DSw0u7tKjZB1Pq1hMnb3bg= X-Received: by 2002:a25:abb1:0:b0:701:c58:f01e with SMTP id v46-20020a25abb1000000b007010c58f01emr908056ybi.59.1671810387218; Fri, 23 Dec 2022 07:46:27 -0800 (PST) MIME-Version: 1.0 References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> In-Reply-To: <87y1tx9ha3.fsf@gmail.com> From: Nikolaos Chatzikonstantinou Date: Fri, 23 Dec 2022 17:46:15 +0200 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Mon, Oct 3, 2022 at 4:19 PM Robert Pluim wrote: > > >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos Chatzikonstantinou said: > > Nikolaos> Okay then, I have the fixed patch here. > > Thanks, no further comment from me, I guess we=CA=BCre waiting on the > paperwork now. The assignment was signed and accepted and now you can proceed with the pat= ch. Regards, Nikolaos Chatzikonstantinou From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 04:01:03 2022 Received: (at 50507) by debbugs.gnu.org; 29 Dec 2022 09:01:03 +0000 Received: from localhost ([127.0.0.1]:59225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAomd-0002Yd-FH for submit@debbugs.gnu.org; Thu, 29 Dec 2022 04:01:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAoma-0002Xj-R8 for 50507@debbugs.gnu.org; Thu, 29 Dec 2022 04:01:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAomV-0002DG-1O; Thu, 29 Dec 2022 04:00:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=B/T8QcxxDjf6hOcO9qzxZwez+Zsn1GBguX+3f71l6Vs=; b=rgvw1Zvbe6IBPbtVucOg wAhqbHouy8NvQ+mGVsytQ7vri7ltOK6KQOGpxLvCb1/BypYAk5btaHQHAFRq+ihLTKEiXNBbNPvXP Iv5jREaC3I08MACHKfdhCpFq0i+1J+hUlFQYDAmghROLXzohUoro/bsGJ7ZcWJkFwCwlBtG4rd7Ej Ce32+6T5cDnz0kimubB/KlHGEjTskk6xiqdJQeTH6tcwbcEiXCJX8DHUUFLlCQbvlOrVZIgD/B3mt LuLfX6xgFUvLGqJwZUi0dc/SNHMkIgqPKgQo6XRYw3dGwH5wYiDOlOyhF9lJ/id+FZa7MoS5hBNdt r5KHr1ttIDcMUw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAomS-0005Kg-FZ; Thu, 29 Dec 2022 04:00:53 -0500 Date: Thu, 29 Dec 2022 11:01:04 +0200 Message-Id: <83lemq8tyn.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: (message from Nikolaos Chatzikonstantinou on Fri, 23 Dec 2022 17:46:15 +0200) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, rpluim@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Fri, 23 Dec 2022 17:46:15 +0200 > Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org > > On Mon, Oct 3, 2022 at 4:19 PM Robert Pluim wrote: > > > > >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos Chatzikonstantinou said: > > > > Nikolaos> Okay then, I have the fixed patch here. > > > > Thanks, no further comment from me, I guess weʼre waiting on the > > paperwork now. > > The assignment was signed and accepted and now you can proceed with the patch. Robert, are you going to take care of this, or should I do it? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 12:03:43 2022 Received: (at 50507) by debbugs.gnu.org; 29 Dec 2022 17:03:43 +0000 Received: from localhost ([127.0.0.1]:60966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwJi-0003Hr-Qu for submit@debbugs.gnu.org; Thu, 29 Dec 2022 12:03:43 -0500 Received: from mail-lf1-f44.google.com ([209.85.167.44]:35757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwJh-0003Hb-2T for 50507@debbugs.gnu.org; Thu, 29 Dec 2022 12:03:41 -0500 Received: by mail-lf1-f44.google.com with SMTP id b3so28331829lfv.2 for <50507@debbugs.gnu.org>; Thu, 29 Dec 2022 09:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LAG8KskeE5i/eddHdt0CsHQirFHeK5QLeglgsB8zon8=; b=nI47EjRqYC45JZVzGZI9ILjdwt7tF+EKo0ew3RHvs9lQThw9BvFtj5OK9UmDr8ZvIr f8oLXZPbOUnzVSc9/oS0xuhbqyktb1HUpZitsFmg9J60kRqSpQitdZZ2JCQDxl2CL46w 5BqHAQsHqATXT3ab9o/Ft7NMoPRCETN6AC6AzzM/8ZCvUTiTQ778MdM/pGXXlV1vtPS6 wQu5FQDcIXs8vurZKtVYl0ZCYY4i4C38peFSjwNMXTJSxhWPf9mNzBxYj+4k3zElcyez 5Jj2VgPngu84hm37u2S8CUZlSsyMUsUIUSf49oOBjbq7alCWPbcalIOsD9t+SFL0hWv7 tFNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LAG8KskeE5i/eddHdt0CsHQirFHeK5QLeglgsB8zon8=; b=4D2bmkrmuc7LSs59m0V66NAUjNC1YDZWF6KJ2wJxrbf7qa7Ko6Iq66kbH0XpBQKtci I/PQ7SyObbib3/1O1+DwZGoryp2KVb3Ljaos6D7e4EcNrLzGwT7tUDvfwUMfRezj/uUs 2U3+4dhAhr/SjqMIEXGZMRP6B23bC7qLFMWX5xbPMrvW+5mxlQefAYFp1lk92OYioS9E eFnKWZpPNrK0yaTo3sLyLykKdHUNm867C21NI1JBsyRmg7Qj7yBNFsuhVXj3T39K/l6J O+Nay7NCyjdwmvM6vjTTdrEeISDmMVZzuXsNUlheT/PNiyNA5BSqEz9cPqoHxQGyGEIn C2Tg== X-Gm-Message-State: AFqh2kqHptfoHgAb0uxzhgvGM50YoL89/ovtW4c6INsVQETM+OaEEzOW fU4sZkPIQLBJkdrl135CchPISxxoausYw1NuIik= X-Google-Smtp-Source: AMrXdXvSLivlr0QGi9a/1RCDy5vhHOfobix6A9M26SPtlFJ29H2j2w1DGPmy1NOBaX92dhNzXaZa0LTxa2blITEwB9I= X-Received: by 2002:a05:6512:3986:b0:4cb:63b:897b with SMTP id j6-20020a056512398600b004cb063b897bmr595040lfu.289.1672333414798; Thu, 29 Dec 2022 09:03:34 -0800 (PST) MIME-Version: 1.0 References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> <83lemq8tyn.fsf@gnu.org> In-Reply-To: <83lemq8tyn.fsf@gnu.org> From: Robert Pluim Date: Thu, 29 Dec 2022 18:03:25 +0100 Message-ID: Subject: Re: bug#50507: New function in Emacs GnuTLS implementation To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000229a1e05f0fa772d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Nikolaos Chatzikonstantinou , Lars Magne Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000229a1e05f0fa772d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Dec 29, 2022, 10:00 Eli Zaretskii wrote: > > From: Nikolaos Chatzikonstantinou > > Date: Fri, 23 Dec 2022 17:46:15 +0200 > > Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org > > > > On Mon, Oct 3, 2022 at 4:19 PM Robert Pluim wrote: > > > > > > >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos Chatzikonstantinou = < > nchatz314@gmail.com> said: > > > > > > Nikolaos> Okay then, I have the fixed patch here. > > > > > > Thanks, no further comment from me, I guess we=CA=BCre waiting on the > > > paperwork now. > > > > The assignment was signed and accepted and now you can proceed with the > patch. > > Robert, are you going to take care of this, or should I do it? > > Thanks. > Hi Eli, I can get to it tomorrow. For master I presume? Thanks Robert > --000000000000229a1e05f0fa772d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Dec 29, 2022, 10:00 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Nikolaos Chatzikonstantinou <nchatz314@gmail.com>
> Date: Fri, 23 Dec 2022 17:46:15 +0200
> Cc: 50507@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>, larsi@= gnus.org
>
> On Mon, Oct 3, 2022 at 4:19 PM Robert Pluim <rpluim@gmail.com>= wrote:
> >
> > >>>>> On Mon, 3 Oct 2022 09:00:26 -0400, Nikolaos = Chatzikonstantinou <nchatz314@gmail.com> said:
> >
> >=C2=A0 =C2=A0 =C2=A0Nikolaos> Okay then, I have the fixed patch= here.
> >
> > Thanks, no further comment from me, I guess we=CA=BCre waiting on= the
> > paperwork now.
>
> The assignment was signed and accepted and now you can proceed with th= e patch.

Robert, are you going to take care of this, or should I do it?

Thanks.


Hi Eli,

I can get to it tomorrow. For master I presume?

Thanks
Robert
--000000000000229a1e05f0fa772d-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 12:18:00 2022 Received: (at 50507) by debbugs.gnu.org; 29 Dec 2022 17:18:00 +0000 Received: from localhost ([127.0.0.1]:60972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwXY-0003d5-Ay for submit@debbugs.gnu.org; Thu, 29 Dec 2022 12:18:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAwXW-0003cs-Q6 for 50507@debbugs.gnu.org; Thu, 29 Dec 2022 12:17:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAwXR-0000aG-Eg; Thu, 29 Dec 2022 12:17:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Nd2P5CMBflBsqUb45z9Iyma+0G8CKGKwgbobsxvJYFY=; b=aJEjAX5SVXUp LvOMYwCOfQBaj8fQcp2vH8AleqzzoUmaDBOyP5RMk0k82f2L5x2RLXkB1eCPswbZ1rmN/p1BRrTXH XfgR2mx+ubm5gkZjPdWN6wbDtts0JCN27XPNl+eAxr7UGK9pgdsLqah14uiAyDzu5DqkPPjR/iO3f kFkOuyqnkAQlGQ9Qqrbt8sMT7NaMGxOlOy1e9aWcHCbGq5YICDHfzc4QEIsZQ5RlqT1A0FLlO4mUy qZC2pze1Qpl/j2ths+LT+nACKVCyfRWmiceKTKc/qS/9xht3JjpOGbI6EmhUZA7UO9j1JgH7kaAhu LQPpzIIVk6vmzjnVhT4h1Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAwXQ-0001Dn-NP; Thu, 29 Dec 2022 12:17:53 -0500 Date: Thu, 29 Dec 2022 19:18:05 +0200 Message-Id: <834jte86ya.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: (message from Robert Pluim on Thu, 29 Dec 2022 18:03:25 +0100) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <87edwd15ck.fsf@gnus.org> <87tu4u8kjv.fsf@gnus.org> <878rm69hop.fsf@gmail.com> <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> <83lemq8tyn.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, nchatz314@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Date: Thu, 29 Dec 2022 18:03:25 +0100 > Cc: Nikolaos Chatzikonstantinou , 50507@debbugs.gnu.org, > Lars Magne Ingebrigtsen > > I can get to it tomorrow. Sure, there's no rush. > For master I presume? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 11:42:08 2022 Received: (at 50507) by debbugs.gnu.org; 30 Dec 2022 16:42:09 +0000 Received: from localhost ([127.0.0.1]:36021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBISO-0001nk-MI for submit@debbugs.gnu.org; Fri, 30 Dec 2022 11:42:08 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:33445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBISM-0001mR-6Z; Fri, 30 Dec 2022 11:42:07 -0500 Received: by mail-wr1-f45.google.com with SMTP id bn26so850621wrb.0; Fri, 30 Dec 2022 08:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lNj6AXuFq0VIa3ikuI1edo++sJdwBtN992aYuUzoyXM=; b=XxHmvoorSqCzVIZJYp7I8q55rxKvZg8h73imu3f5XoI1efIaHtkZd8zeQOxb4b+d8X 8swAc6MQqiEf6IEPflQwm2jEIuZTsWrwGSMVur30vCa5tCmaGjlrLNH3LWLV1paYOeSG wzlntEPScqEWSHT8p4iEvBjd09CIjy61MISAb5DzfJHv+M77b1kKldzvLlF6lu7IPWpG pSWutvSZIpkC2DQqcSGgyVBdkgla8uZAhPg5VZdLXwFjLwuAYfnK6JdNyxGNDFioZ6JZ 7ttPp1RIgTyP6ksxUIl9gNAAdbt9RPEUhLWBjqvQdIvnl8Re+jbYhoKd5NQMV8dqC6eS MS0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lNj6AXuFq0VIa3ikuI1edo++sJdwBtN992aYuUzoyXM=; b=TX3digVnRzLvFwyRRjCijWC+kP1NmzvWMWeFtUQlMVcIqHFwUarYeA4Lj9BUbVNmlm iyh6EdJbFD7sRfvOML9iVM0nvnECwGdi7s1xCpyEtFjU1tJNyRi0fvhvPwF5O+B1oB9Y L9qq1Mt9XfQfwu3SevHQJQXuwyTCUeuzOMDl14NfMdmiLK8IH2uroAFbCJ93Sy8vq1OL jTIn0+fZCHMCeijKkojxBtiuoaSqwnhFnGFOBqq2JFlXbuxBFuLDVoenurMge7huy5wg 03RQKocmmBw0U3PSnxhvbZ2lwSEiOm4TcOuvSqOmESD6sbLn72nhrBDjhEse/HHtrjWG ioSA== X-Gm-Message-State: AFqh2krPQbYHIIs4d6o/FZEkwKeYw6IuXY66uOVi9S6E+o+fs0sT+99O 9BxFkhUp6rDnR27avFX8UVfDlMuZE4Q= X-Google-Smtp-Source: AMrXdXtn0Cw+p6euApcYvQOaGfHSkARHDHz84Ho3wXA1lc2H/kTvuYx3wHzdXK3lw7bPU2eouPVVHg== X-Received: by 2002:adf:ed51:0:b0:242:659f:9411 with SMTP id u17-20020adfed51000000b00242659f9411mr24191420wro.9.1672418519909; Fri, 30 Dec 2022 08:41:59 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j13-20020a5d618d000000b002425dc49024sm20939412wru.43.2022.12.30.08.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Dec 2022 08:41:59 -0800 (PST) From: Robert Pluim To: nchatz314@gmail.com Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: <834jte86ya.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Dec 2022 19:18:05 +0200") References: <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> <83lemq8tyn.fsf@gnu.org> <834jte86ya.fsf@gnu.org> Date: Fri, 30 Dec 2022 17:41:58 +0100 Message-ID: <87fscwlu7d.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 50507 fixed close 50507 30.1 quit Done (with a very minor change to the commit message: I added the bug number). I tested with and without GnuTLS builds on GNU/Linux. The MS-Windows changes looked sane, but I didn=CA=BCt test those. Thanks for this. Closing. Committed as e9983b1b635 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 15:45:20 2022 Received: (at 50507) by debbugs.gnu.org; 30 Dec 2022 20:45:20 +0000 Received: from localhost ([127.0.0.1]:36157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBMFk-0002Py-DS for submit@debbugs.gnu.org; Fri, 30 Dec 2022 15:45:20 -0500 Received: from mail-lf1-f45.google.com ([209.85.167.45]:39933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBMFi-0002Pf-An for 50507@debbugs.gnu.org; Fri, 30 Dec 2022 15:45:19 -0500 Received: by mail-lf1-f45.google.com with SMTP id bf43so33027097lfb.6 for <50507@debbugs.gnu.org>; Fri, 30 Dec 2022 12:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=ySH52oeKyv/Kzmy2/S8DZLCCXe+Bgq5N2WgfdstdOOA=; b=arJGFn6FDAqG+Z9UkzOehyepG0WLlHBJ1hLUXWr2YKYEb/r6rnkiRMygcT3/AkpfUg GAArHd8IlwCrYIn2WvF20AfmqOjnWm+1UbPtvJ5THRPyyc65hIVVhxvTZrCiV5TCUXnE 441IPeNLo9h5C4GS8+x9MR26clOVLbMrquAzdlGXuMjoFfuIjc7feqt0JU0MDdoKpFoy ckcnUfoCFOB8JCX/yHemC1bi8ps9tbevqjhedvYV6iZ98zD85RCWpMuVLoIkWcVPxqec hdkObGjnsT1kOePzvCcMhRfDjxTzK4iOGXCcVcb9OSWHZXtBbIb5smdiG1MSQzmpzQSo W7+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ySH52oeKyv/Kzmy2/S8DZLCCXe+Bgq5N2WgfdstdOOA=; b=DsnCNLeb9bGMr3WsXtpj5pwwQVIxq1jzE9+RfQSJqaGP3OU/FaCukqXWPwJ+nJi9gh /rbk9oOgxqoE+ou0BZIy+L7kY7p1zYawie3gGrpfxeeeQ0G9AVnaMQ7M0tNE5+SIDeQT O4s4NA53OKBgzQwndLHNGyVUigcwbJ/n9w4TfDy8w4IdFg/+NDo9dfAsCAb4LVfl/3lH mbGZgXejDg/uR9evBBRE4/D1h/ntY2cg4zJLCjuxoMURtAUzartGGCzZO7k4Lwv1buoY SkOQTVHSTC2iZILQ7d37t6T5ZH/a4lmKb0Iz41ZrX3hfPxiLMkeuyzSIildLex1YnBVl f/uw== X-Gm-Message-State: AFqh2kryL+hbN3u/6vM0OS1R6/xCSFHHz+z2yj4I4dsCT54iFg8t+nxm DFpFd6/JcpPDkUeNHKbGlWk= X-Google-Smtp-Source: AMrXdXta1jgD0SiJC2rmmJ27NEZWcFfMjUGLPwuumueR1ZOnk2VwC4B6VpOCet6P9K0MprdYltI9cQ== X-Received: by 2002:a05:6512:340a:b0:4b5:6c00:429b with SMTP id i10-20020a056512340a00b004b56c00429bmr9812845lfr.26.1672433111939; Fri, 30 Dec 2022 12:45:11 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id p24-20020a056512139800b004b59067142bsm3569550lfa.8.2022.12.30.12.45.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Dec 2022 12:45:11 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: bug#50507: New function in Emacs GnuTLS implementation Message-Id: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> Date: Fri, 30 Dec 2022 21:45:10 +0100 To: Nikolaos Chatzikonstantinou X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Robert Pluim , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) After e9983b1b63, the build of master fails on emba.gnu.org which = perhaps uses a slightly older gnutls. Errors below. CC gnutls.o gnutls.c: In function 'key_file2_aux': gnutls.c:1829:8: error: 'GNUTLS_PKCS_PBES2_GOST_TC26Z' undeclared (first = use in this function) rv |=3D GNUTLS_PKCS_PBES2_GOST_TC26Z; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ gnutls.c:1829:8: note: each undeclared identifier is reported only once = for each function it appears in gnutls.c:1831:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPA' undeclared (first = use in this function) rv |=3D GNUTLS_PKCS_PBES2_GOST_CPA; ^~~~~~~~~~~~~~~~~~~~~~~~~~ gnutls.c:1833:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPB' undeclared (first = use in this function) rv |=3D GNUTLS_PKCS_PBES2_GOST_CPB; ^~~~~~~~~~~~~~~~~~~~~~~~~~ gnutls.c:1835:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPC' undeclared (first = use in this function) rv |=3D GNUTLS_PKCS_PBES2_GOST_CPC; ^~~~~~~~~~~~~~~~~~~~~~~~~~ gnutls.c:1837:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPD' undeclared (first = use in this function) rv |=3D GNUTLS_PKCS_PBES2_GOST_CPD; ^~~~~~~~~~~~~~~~~~~~~~~~~~ From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 17:59:31 2022 Received: (at 50507) by debbugs.gnu.org; 30 Dec 2022 22:59:31 +0000 Received: from localhost ([127.0.0.1]:36254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBOLa-0005y3-Ns for submit@debbugs.gnu.org; Fri, 30 Dec 2022 17:59:31 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:46609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBOLZ-0005xq-E1 for 50507@debbugs.gnu.org; Fri, 30 Dec 2022 17:59:29 -0500 Received: by mail-wm1-f42.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso9546123wms.5 for <50507@debbugs.gnu.org>; Fri, 30 Dec 2022 14:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=E8mtzhkdMaVUg6zpP++MK8SirI/cjf7SJccH3zH+B4Q=; b=gt0EcQHMkRX95V38aWj4yFq5ygLcr6QxRHLfwVuIGpF/n7aybiO+av60h59BdCyAKy BPtmblN7UDhXf+Aww4MVbmT1jIpUW7Ldg2fSHGjxkNOCPYMSAQe2TRCCcFZ4w0FFhYJn 7BqPj4L3U74AVE4BCNfW6BsIf5yMLbcg3S9DkwnZfOMJXHgP4BifeMrXjJNIFr+cJp1d i0P7gxGmNFKqq9ILElv1gkKqRjdrzo4NKjdQbBKmMmxFb9ae7sQJmehFi88I0pf9Td4x OiGeG8DmjinY3opRp23owI7JxcrmNvB9nnBYbbpnqD0bHUpeIdH4B0yN6q9qrZeOa+Eg R39w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E8mtzhkdMaVUg6zpP++MK8SirI/cjf7SJccH3zH+B4Q=; b=T7vsQ5e6NnWEG/FBISH6DwsnpBi6oay6ssbLQgXaT0fMWQQjBKIzABSyLbVH/ywlIu iiCDH5pYZXrQT8dUYLO1udq9IYkiWPD3U2kNZd4YZyFylYgU4LT5k7raP7X8qYEoEmLS Jz0lVMdeCq5z83EUan95wp9wlKjK5Lkehq4ulbi51MF6+IeK9QixOCCJ9OoyL6/HyBG3 meoHCY54IBQi5LGV9L61w+1fOY/LVUESoBgZ9MOwSg7Uq3+qvQJbQBQcmpXPD+6T6ZiV +479bKPRQNfb9udx4DCKwceREvgvf1iVy5O8nD/Obg9DSNvOOX6goC7p4C6rOQpa/kNp gaTQ== X-Gm-Message-State: AFqh2koMgZm40HCaRQh3PK7Y6VoOcCtaP6cI7Cwof4VBbw4FHCc1ruva kRHmi5yw3Mn7ixo7BL42aaI= X-Google-Smtp-Source: AMrXdXtD4puNfsMtyelrnHlauWN7LSy/W1aoY4YR4RszRClBTYiYJaIk/dKvOfATdG5bOH0CGrgF6A== X-Received: by 2002:a05:600c:2d85:b0:3d0:7d89:2256 with SMTP id i5-20020a05600c2d8500b003d07d892256mr23132823wmg.13.1672441163157; Fri, 30 Dec 2022 14:59:23 -0800 (PST) Received: from smtpclient.apple ([2a02:2149:8465:1f00:715b:3826:eb35:ec51]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c358d00b003d1f2c3e571sm38181361wmq.33.2022.12.30.14.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Dec 2022 14:59:22 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Nikolaos Chatzikonstantinou Mime-Version: 1.0 (1.0) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation Date: Sat, 31 Dec 2022 00:59:09 +0200 Message-Id: <71E45D6A-F805-4FA3-9A35-29D14B31B098@gmail.com> References: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> In-Reply-To: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= X-Mailer: iPhone Mail (20C65) X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Robert Pluim , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > On 30 Dec 2022, at 10:45 PM, Mattias Engdeg=C3=A5rd wrote: >=20 > =EF=BB=BFAfter e9983b1b63, the build of master fails on emba.gnu.org which= perhaps uses a slightly older gnutls. Errors below. >=20 > CC gnutls.o > gnutls.c: In function 'key_file2_aux': > gnutls.c:1829:8: error: 'GNUTLS_PKCS_PBES2_GOST_TC26Z' undeclared (first u= se in this function) > rv |=3D GNUTLS_PKCS_PBES2_GOST_TC26Z; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > gnutls.c:1829:8: note: each undeclared identifier is reported only once fo= r each function it appears in > gnutls.c:1831:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPA' undeclared (first use= in this function) > rv |=3D GNUTLS_PKCS_PBES2_GOST_CPA; > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > gnutls.c:1833:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPB' undeclared (first use= in this function) > rv |=3D GNUTLS_PKCS_PBES2_GOST_CPB; > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > gnutls.c:1835:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPC' undeclared (first use= in this function) > rv |=3D GNUTLS_PKCS_PBES2_GOST_CPC; > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > gnutls.c:1837:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPD' undeclared (first use= in this function) > rv |=3D GNUTLS_PKCS_PBES2_GOST_CPD; > ^~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 I can work on this tomorrow and fix it. I think it needs preprocessor guards= on the version. Regards, Nikolaos Chatzikonstantinou= From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 02:25:46 2022 Received: (at 50507) by debbugs.gnu.org; 31 Dec 2022 07:25:47 +0000 Received: from localhost ([127.0.0.1]:36453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWFW-0002V2-KA for submit@debbugs.gnu.org; Sat, 31 Dec 2022 02:25:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWFV-0002Un-A0 for 50507@debbugs.gnu.org; Sat, 31 Dec 2022 02:25:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWFP-0005Ad-RA; Sat, 31 Dec 2022 02:25:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S1KRhlGhF/mEP8FcqW8MWkIVih3QI66qdIFeZU/jb88=; b=nxKr8K/EHWpVBD+CuIaA 6xL2Gw6vzlMrdEO4C5yi1EJTeP+2mAe3IQKlp10c0Z7OUo4WPeXPv4LPzyAe6Zqg/CisUvwa5cGKl xhU3bFRxCq7d6FXEZaDdICFvsmN4GWb4Em1efuWKGJyPSpDnNi5ruo/LmQNzNBizn4HkuN1/bjZB9 RoJD4WZYf8g+vQURF+F9pn5fphEEY5eQlkoml6xfn2GcAdhXT+kFLZFFCgc5wMHt5gmgdjYmW0+Rw wTZPSGI20B0gqQz0PReMIHOmtCiTQZ1sm2I9DwMvu8EW05cSLsQLWodlUZ4TZbrnTtlzy3jI8Yded ag6AyZyDfwedWg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWFO-0004Nh-LO; Sat, 31 Dec 2022 02:25:39 -0500 Date: Sat, 31 Dec 2022 09:25:38 +0200 Message-Id: <837cy8591p.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Fri, 30 Dec 2022 21:45:10 +0100) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, nchatz314@gmail.com, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Fri, 30 Dec 2022 21:45:10 +0100 > Cc: 50507@debbugs.gnu.org, > Robert Pluim , > Eli Zaretskii > > After e9983b1b63, the build of master fails on emba.gnu.org which perhaps uses a slightly older gnutls. Errors below. Thanks, should be fixed now. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 02:28:17 2022 Received: (at 50507) by debbugs.gnu.org; 31 Dec 2022 07:28:17 +0000 Received: from localhost ([127.0.0.1]:36458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWHx-0002Zb-55 for submit@debbugs.gnu.org; Sat, 31 Dec 2022 02:28:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWHu-0002ZM-Os for 50507@debbugs.gnu.org; Sat, 31 Dec 2022 02:28:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWHp-000667-BI; Sat, 31 Dec 2022 02:28:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GYpq4tjZPGGwHWw20/t+EEoW7GMgN0ahb+U3EBGTuXk=; b=klCKSOq5SrN/ Ca19odGWcudQQQCeukmXOaIPyIIN2dU2xhvxCD/WvMaHQdtrebKiGWiWq0tm60juvo6YXIjtW6ft3 KyuAYj+HB687cj+ni3ctQzSzXArxkhaau/6mjRVVTHf/AjnWDKcQxQmdSD7gmhBfGt5CY57pUJttt bLjlKoZt+fh71ExUNmnL8KLjyetgKNE/q+xA460ndOa+TiJsYqVjcY6p5UvIXVWYpJcbgQQ2n1tRM YRoDqT73O7I39MyMWGeV2Y6PhbrXqsgsfoJkACMPd/sh/JqVpfkaXby8RmnC6ue1H6cVJ4Kk7EVP9 +T9Czh4T9KmWtu2z2GaHAQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWHo-0004q6-Fv; Sat, 31 Dec 2022 02:28:08 -0500 Date: Sat, 31 Dec 2022 09:28:10 +0200 Message-Id: <835yds58xh.fsf@gnu.org> From: Eli Zaretskii To: Nikolaos Chatzikonstantinou In-Reply-To: <71E45D6A-F805-4FA3-9A35-29D14B31B098@gmail.com> (message from Nikolaos Chatzikonstantinou on Sat, 31 Dec 2022 00:59:09 +0200) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> <71E45D6A-F805-4FA3-9A35-29D14B31B098@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, mattias.engdegard@gmail.com, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nikolaos Chatzikonstantinou > Date: Sat, 31 Dec 2022 00:59:09 +0200 > Cc: 50507@debbugs.gnu.org, Robert Pluim , > Eli Zaretskii > > > gnutls.c:1837:8: error: 'GNUTLS_PKCS_PBES2_GOST_CPD' undeclared (first use in this function) > > rv |= GNUTLS_PKCS_PBES2_GOST_CPD; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > I can work on this tomorrow and fix it. I think it needs preprocessor guards on the version. Since GnuTLS's documentation doesn't bother specifying when these constants were introduced (some in 3.5.x, some in 3.6.x), I preferred to condition the use of each constant by its being defined, instead of conditioning on versions. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 02:33:27 2022 Received: (at 50507) by debbugs.gnu.org; 31 Dec 2022 07:33:27 +0000 Received: from localhost ([127.0.0.1]:36471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWMx-0002kf-8i for submit@debbugs.gnu.org; Sat, 31 Dec 2022 02:33:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBWMv-0002kQ-JL for 50507@debbugs.gnu.org; Sat, 31 Dec 2022 02:33:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWMp-00006R-6k; Sat, 31 Dec 2022 02:33:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ELgyCe6mZO8LrBJKxXJKygu/6B3oRTUfFa+cc9XSVec=; b=Afvr7ipA4kX1DxyitSW9 NHM0IlJ8uUKccDPbfGpNybiIb+EFQ6UohUu2EmZCmcGFadlSFx8oDJvFOwO7RXxV5Iox8VuHotvu8 wU7YjJw1NEOd7WqMI7TGyk6SHIGWCYzZX0U8W6i6tgbzrUNh5SUswefy8PiDFGstHvar+a2CEABzm u0w3qOBdmKRp+GmsEcvcUL3ABFP+gtZzSS2MQLR9M9PkflQKwrbxqUMzEszqkLMfy2e5BUUVFWxdO 1m9alrabHMJEfl3mxCQbVMUMBoCRLpuMv7ZGCQOSnpibfMDG4SDxl6BDRLOls07k4XOFqP84zA09E Ee5cVA0StAPIYQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBWMo-0007mx-N6; Sat, 31 Dec 2022 02:33:19 -0500 Date: Sat, 31 Dec 2022 09:33:20 +0200 Message-Id: <83358w58ov.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87fscwlu7d.fsf@gmail.com> (message from Robert Pluim on Fri, 30 Dec 2022 17:41:58 +0100) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation References: <87v8p7d4oq.fsf@gmail.com> <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> <83lemq8tyn.fsf@gnu.org> <834jte86ya.fsf@gnu.org> <87fscwlu7d.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, nchatz314@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnus.org > Date: Fri, 30 Dec 2022 17:41:58 +0100 > > Done (with a very minor change to the commit message: I added the bug > number). > > I tested with and without GnuTLS builds on GNU/Linux. The MS-Windows > changes looked sane, but I didnʼt test those. Thanks, the basic HTTPS connectivity seems to work on MS-Windows after the change. Are there any special tests of the new functionality I should try? There aren't any tests for this in the test suite, AFAICT. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 03:58:52 2022 Received: (at 50507) by debbugs.gnu.org; 31 Dec 2022 08:58:52 +0000 Received: from localhost ([127.0.0.1]:36548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBXhb-0005CF-Oh for submit@debbugs.gnu.org; Sat, 31 Dec 2022 03:58:52 -0500 Received: from forward501a.mail.yandex.net ([178.154.239.81]:52342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBXhZ-0005C3-2q for 50507@debbugs.gnu.org; Sat, 31 Dec 2022 03:58:50 -0500 Received: from vla5-04fcbc3a0ab0.qloud-c.yandex.net (vla5-04fcbc3a0ab0.qloud-c.yandex.net [IPv6:2a02:6b8:c18:3484:0:640:4fc:bc3a]) by forward501a.mail.yandex.net (Yandex) with ESMTP id 79A0B5EAF1; Sat, 31 Dec 2022 11:58:46 +0300 (MSK) Received: by vla5-04fcbc3a0ab0.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id iwOILJUYHW21-fQEF1cCc; Sat, 31 Dec 2022 11:58:45 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1672477126; bh=1QtR+DuXvuzAWtgT9YwfF1/VV0EaKhmHJX/jCmj4XvA=; h=Message-ID:References:Date:Reply-To:Cc:In-Reply-To:Subject:To: From; b=ZFtQktCex6jKHfG8qy0dem5tpREHwNDywmsoH1650DPM2D6sEsegjCSsEQTejFC+n Q2+spVUKeFxT0NqPRkrI2hyDasmwATkNO2Hxh2cEZqanChYk7YypZmm63m5MyskzjS jYmjS+RA4Jy57U0ej01VaM7s8kJ24giC8lnWG9vo= Authentication-Results: vla5-04fcbc3a0ab0.qloud-c.yandex.net; dkim=pass header.i=@yandex.com From: Colin Baxter To: Eli Zaretskii Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: <837cy8591p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Dec 2022 09:25:38 +0200") References: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> <837cy8591p.fsf@gnu.org> X-Face: BHjiJOg/Qmj'BQgsAKL@])L)e62P)C"Y=6T Date: Sat, 31 Dec 2022 08:58:43 +0000 Message-ID: <87r0wg2blo.fsf@yandex.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAAEkAAAATAgMAAAChCMjeAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEX/zAABCWP///8I RHjYAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB+UFEAk5BvqS634A AAAbSURBVBjTY2BgCA1hYA0FAxDDgQEERsXoIAYA2F9Eb3cpB+AAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDUtMTZUMTA6NTY6MTcrMDE6MDCh/kkpAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1 LTE2VDA5OjU3OjA2KzAxOjAwTyZ6HwAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , nchatz314@gmail.com, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: m43cap@yandex.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> Eli Zaretskii writes: >> From: Mattias Engdeg=C3=A5rd Date: Fri, >> 30 Dec 2022 21:45:10 +0100 Cc: 50507@debbugs.gnu.org, Robert >> Pluim , Eli Zaretskii >>=20 >> After e9983b1b63, the build of master fails on emba.gnu.org which >> perhaps uses a slightly older gnutls. Errors below. > Thanks, should be fixed now. It is. Thank you. Best wishes, From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 04:44:21 2022 Received: (at 50507) by debbugs.gnu.org; 31 Dec 2022 09:44:21 +0000 Received: from localhost ([127.0.0.1]:36561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYPd-0006Zb-4y for submit@debbugs.gnu.org; Sat, 31 Dec 2022 04:44:21 -0500 Received: from mail-lf1-f52.google.com ([209.85.167.52]:36560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBYPb-0006ZK-Vv for 50507@debbugs.gnu.org; Sat, 31 Dec 2022 04:44:20 -0500 Received: by mail-lf1-f52.google.com with SMTP id j17so25266785lfr.3 for <50507@debbugs.gnu.org>; Sat, 31 Dec 2022 01:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=vh38KIktSqXUkbagZYtXEu0KgHAtFvk9YRCA4OqvQ8k=; b=mdMJUjrDynTeIiO9ls5NEPcaIxZZ+OCX/0uL8pzAop3phbI9gVGCSuTvgReiFtlroL 6KfGeOfnC/XfMYAt+xy4ecMeg7mu0Uy8Lk7ZBUoTBRJzvIww1Pv4PYxNKcnblwROTKpS HP/9RvR0isBpyYhMc5pr8kpSfhivQPYLECiCr/pEyNdvfy2T+6VOM5SHWzD1k7v54ws9 FbTb7iRT1kMuKWWxsY5IcPOwj0ASlT2TbWh0z+2wHWe9uUXVagh0pLRzWqjn1dRaK75v sQK44D8J3rNqSiFIvB1F5N+jRuLoBOL6wFn73ulADdm3X46i2npl4F+dHZyn7MVQ1Qe0 rtRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=vh38KIktSqXUkbagZYtXEu0KgHAtFvk9YRCA4OqvQ8k=; b=c+2CCfaS8ptZUR/o0sxxFOZaGw3KePnYPdJWLdQ5FOKpv5IRmvCbWgwORLDmZ+IPwB swpoGdHAcBYnLlcQi9qxuiyApgvZoC/3XmjheV0KSO4Ns/EDJoR+GQ9n5yHMQqWq/M7q y9hehv2sJwKOlhTpGan/mbYg6w6XC9R1Yuz1LRWLLfxYyAoSjognELvPbMwggmNce0FJ UpB0HnFWFuS3jzlpLRYIvjPaQE4m82wfI5GpxSp7AZ7VsG9XhTjoXBJNRq10tk5xMsrL 0G6RdBhcbVDbhHbXtgem4onFmerUQyH86HfYXkYQJ3smDHV7RTIdg52UT5WZ/HwcL59V 2QRA== X-Gm-Message-State: AFqh2kolcaiLOvfVMZQ2I5id2dOSlUa67QGsQ90B43ptfrpQcAOpBJxe hpJroSIWzIanmK2uVo5nIb4= X-Google-Smtp-Source: AMrXdXsvK2BTxFCU+Z9teIDTfqwDqp+Qim1uEl9IswlfJjRMC0kixfSxWmDA+WdCgQgWd3EOPQnycQ== X-Received: by 2002:ac2:4f13:0:b0:4b5:b22e:9653 with SMTP id k19-20020ac24f13000000b004b5b22e9653mr9036721lfr.18.1672479853715; Sat, 31 Dec 2022 01:44:13 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id s9-20020ac25fa9000000b004b6e9530900sm3771441lfe.110.2022.12.31.01.44.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Dec 2022 01:44:13 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#50507: New function in Emacs GnuTLS implementation From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <837cy8591p.fsf@gnu.org> Date: Sat, 31 Dec 2022 10:44:12 +0100 Content-Transfer-Encoding: 7bit Message-Id: References: <05BBDB95-154C-4334-8EB6-36276C4F56F7@gmail.com> <837cy8591p.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, nchatz314@gmail.com, rpluim@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 31 dec. 2022 kl. 08.25 skrev Eli Zaretskii : > Thanks, should be fixed now. Good -- emba.gnu.org seems happy. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 05:24:14 2023 Received: (at 50507) by debbugs.gnu.org; 2 Jan 2023 10:24:14 +0000 Received: from localhost ([127.0.0.1]:42530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHzK-0001j6-B5 for submit@debbugs.gnu.org; Mon, 02 Jan 2023 05:24:14 -0500 Received: from mail-wr1-f50.google.com ([209.85.221.50]:46842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCHzI-0001it-6Z for 50507@debbugs.gnu.org; Mon, 02 Jan 2023 05:24:12 -0500 Received: by mail-wr1-f50.google.com with SMTP id y8so25898734wrl.13 for <50507@debbugs.gnu.org>; Mon, 02 Jan 2023 02:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1g7Eu1EjST4f1VhBJaH4OxEqE0Pw3XKP/H8CIaCvyK4=; b=CVAQH1gDl1n4GvfVGOqv0MaY6778l3TLFkPXqbHZss2z2bwBAxWK4f+MVNRYdMdYGu xqBJhFRQGQl8pH5wA5FFf/up8WQkKu6RGpplAaEc7EAIy8o3Nuuxk/BJslgx7q/GkZf4 jPGVDpREHv1v2a6SvFawUbKfCcN8QK+9MDBUtj2DGmqoJG2Gt4cWZkepV2gdOYgMbjJn wboplcL3GHwJPbcb57UylpPNKHpD64AVFE4VbEK607j/icTYwhp+gksgqCdW4cwFKQU1 Ykv37hFoUyarB7RyY39DRvullSh4F2C+8TGGh0BM/7Sp1ShC9hSXx41rV7LU0yUBf6nm mN6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1g7Eu1EjST4f1VhBJaH4OxEqE0Pw3XKP/H8CIaCvyK4=; b=MQ9DUkpzGzqtzCzmSEPeRU4/4hy50Y4bcOhqA+np//cbeJPTTdHfdN6+zEYVPzxgfY SzslX7HAtSg2WEwMKjU3SIBWXBkh2FAsAiHA11uas+LOcWowUZel9xibKafOaCyCkugm 4GFjs/XApDHK5D7RlBF/hSRGC1ZYGQXqOBbwIYTCCgkVfLuADyXuWxoZxvaEWv0+XA7f WvygScDKCVe+8nyJaIttQyuHEsdCbppc7GTGvMaYiF3OfpafX3XWvVADuqfIyv7bHf5l 7PHfFW2ErX9WZkvf8zfqizeR1ie9IANPkr3Qh5q52P2uxaz9d8Te2iX+E/QiSUTWpB9n rvGA== X-Gm-Message-State: AFqh2koBIoS7mIKnChIdk5qa8iyksgEaQQxpw7/T4ZSbaZ8rHnGhgUDD EFanD09GwDTolSJX4pfME8U= X-Google-Smtp-Source: AMrXdXtY5Wx1BgTgxChqi2XT0gOKGU8ql/RY+f6128Iz4Ea/VOkaOcOjNLJtilpQh1MVLocdyQehEQ== X-Received: by 2002:adf:e703:0:b0:242:15af:27f with SMTP id c3-20020adfe703000000b0024215af027fmr26245118wrm.28.1672655046395; Mon, 02 Jan 2023 02:24:06 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id m16-20020adffe50000000b00241bd7a7165sm31160707wrs.82.2023.01.02.02.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 02:24:05 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#50507: New function in Emacs GnuTLS implementation In-Reply-To: <83358w58ov.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 Dec 2022 09:33:20 +0200") References: <87a66id03q.fsf@gmail.com> <875yh6cly4.fsf@gmail.com> <83ill5dtqt.fsf@gnu.org> <837d1ldlv3.fsf@gnu.org> <87a66haq6n.fsf@gmail.com> <8735c5bbhz.fsf@gmail.com> <87y1tx9ha3.fsf@gmail.com> <83lemq8tyn.fsf@gnu.org> <834jte86ya.fsf@gnu.org> <87fscwlu7d.fsf@gmail.com> <83358w58ov.fsf@gnu.org> Date: Mon, 02 Jan 2023 11:24:05 +0100 Message-ID: <87358tkzei.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50507 Cc: 50507@debbugs.gnu.org, nchatz314@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sat, 31 Dec 2022 09:33:20 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 50507@debbugs.gnu.org, Eli Zaretskii , larsi@gnu= s.org >> Date: Fri, 30 Dec 2022 17:41:58 +0100 >>=20 >> Done (with a very minor change to the commit message: I added the bug >> number). >>=20 >> I tested with and without GnuTLS builds on GNU/Linux. The MS-Windows >> changes looked sane, but I didn=CA=BCt test those. Eli> Thanks, the basic HTTPS connectivity seems to work on MS-Windows a= fter Eli> the change. Are there any special tests of the new functionality I Eli> should try? There aren't any tests for this in the test suite, Eli> AFAICT. There are no tests for TLS connections with client side certificates at all, let alone password protected ones. They must work, nobody has ever complained about them =F0=9F=98=BA Robert --=20 From unknown Sun Jun 22 08:05:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 30 Jan 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator