GNU bug report logs - #50504
[PATCH] home-services: Add Mcron.

Previous Next

Full log

Message #20 received at 50504 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Andrew Tropin <andrew <at> trop.in>, Oleg Pykhalov <go.wigust <at> gmail.com>,
 50504 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#50504] [PATCH] fixup! home-services: Add Mcron.
Date: Mon, 13 Sep 2021 18:17:21 +0200

[Message part 1 (text/plain, inline)]

On Mon, Sep 13 2021, Andrew Tropin wrote:

> Applied suggestions.
>
> From f93bb50483246e3c2c8df669231b13cb85578bfb Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Mon, 13 Sep 2021 09:39:18 +0300
> Subject: [PATCH] fixup! home-services: Add Mcron.
>
> ---
>  doc/guix.texi | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index a7eacad762..419d9429d6 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -16090,9 +16090,9 @@ This is the type of the @code{mcron} service, whose value is an
>  @code{mcron-configuration} object.
>  
>  This service type can be the target of a service extension that provides
> -it additional job specifications (@pxref{Service Composition}).  In
> -other words, it is possible to define services that provide additional
> -mcron jobs to run.
> +additional job specifications (@pxref{Service Composition}).  In other
> +words, it is possible to define services that provide additional mcron
> +jobs to run.
>  @end defvr
>  
>  @deftp {Data Type} mcron-configuration
> @@ -35689,17 +35689,19 @@ The @code{(gnu home-services mcron)} module provides an interface to
>  GNU <at> tie{}mcron, a daemon to run jobs at scheduled times (@pxref{Top,,,
>  mcron, GNU <at> tie{}mcron}).  The information about system's mcron is
>  applicable here (@pxref{Scheduled Job Execution}), the only difference
> -for home services is that they have to be declared in
> -@code{home-envirnoment} record instead of @code{operating-system}.
> +for home services is that they have to be declared in a
> +@code{home-envirnoment} record instead of an @code{operating-system}
> +record.
>  
>  @defvr {Scheme Variable} home-mcron-service-type
>  This is the type of the @code{mcron} home service, whose value is an
> -@code{home-mcron-configuration} object.  It allows to manage tasks
> +@code{home-mcron-configuration} object.  It allows to manage scheduled
> +tasks.
>  
>  This service type can be the target of a service extension that provides
> -it additional job specifications (@pxref{Service Composition}).  In
> -other words, it is possible to define services that provide additional
> -mcron jobs to run.
> +additional job specifications (@pxref{Service Composition}).  In other
> +words, it is possible to define services that provide additional mcron
> +jobs to run.
>  @end defvr
>  
>  @deftp {Data Type} home-mcron-configuration
> -- 
> 2.33.0

The updated patch LGTM!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.