GNU bug report logs - #50503
[PATCH] Properly encode all strings sent to the Python shell

Previous Next

Full log

Message #19 received at 50503 <at> debbugs.gnu.org (full text, mbox):

From: Augusto Stoffel <arstoffel <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 50503 <at> debbugs.gnu.org
Subject: Re: bug#50503: [PATCH] Properly encode all strings sent to the
 Python shell
Date: Sat, 11 Sep 2021 14:44:28 +0200

On Sat, 11 Sep 2021 at 14:38, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Augusto Stoffel <arstoffel <at> gmail.com> writes:
>
>> Thanks!  But note that there is at least one Emacs 28 dependency left,
>> namely `comint-max-line-length'.
>
> Perhaps there should be some compat code in that case?

If it is stylistically acceptable, I think

  (or (bound-and-true-p comint-max-line-length) 1024)

is the simplest solution.  One could also replace the mysterious 1024 by
0, which was more or less the previous situation anyway.

>
>> There's also a byte-compiler warning regarding
>> `comint-highlight-input' even on Emacs 27.
>
> Warnings are normal on older Emacs versions -- I mean, it'd be good to
> avoid them, but we're mainly worried about actual breakages.

All right then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.