GNU bug report logs - #5050
23.1; efiff: Displaying bytes instead of characters in messages

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: sebastian_rose <at> gmx.de, stephen.berman <at> gmx.net, 5050 <at> debbugs.gnu.org
Subject: bug#5050: 23.1; efiff: Displaying bytes instead of characters in messages
Date: Thu, 20 Aug 2020 22:50:16 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Thu, 20 Aug 2020 21:42:47 +0200
> Cc: Sebastian Rose <sebastian_rose <at> gmx.de>, 5050 <at> debbugs.gnu.org
> 
> (defun ediff-exec-process (program buffer synch options &rest files)
> 
> [...]
> 
> 	;; If this is a buffer job, we are diffing temporary files
> 	;; produced by Emacs with ediff-coding-system-for-write, so
> 	;; use the same encoding to read the results.
> 	(coding-system-for-read
> 	 (if (string-match "buffer" (symbol-name ediff-job-name))
> 	     ediff-coding-system-for-write
> 	   ediff-coding-system-for-read))
> 	args)
> 
> This is the problem: ediff-coding-system-for-read is raw-text, which
> gives us the binary data in the buffer instead of characters.

How else can you compare files which could have different encodings?

And anyway, Stephen just answered my question, and the diffs are
displayed correctly with non-ASCII characters, not as raw bytes.  So
there's more here than meets the eye.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.