Subject: Re: 23.0.60; Font for fixed-pitch not resolved

From: Michael Welsh Duggan <[email-masked]>
Date: Wed, 15 Oct 2008 17:16:36 -0400

Chong Yidong <[email-masked]> writes:

> Actually, the last patch I sent you is bad.  Could you try using this
> one instead, and see if the problem goes away?

It does not go away.  Before I added the patch I tried inserting a
breakpoint on the x_clear_errors line.  Emacs never reached that line.
I then made the patch and ran again, in case you were testing something
different.  In each case, the behavior is as I described in the bug
report.

> If the error disappears, we'll probably need to use gdb to find out what
> x_error_message is.  (The last patch I sent doesn't compile because
> x_error_message is static to xterm.c.)
>
> *** trunk/src/xfont.c.~1.20.~	2008-10-03 14:58:43.000000000 -0400
> --- trunk/src/xfont.c	2008-10-15 16:34:26.000000000 -0400
> ***************
> *** 561,573 ****
>   	  return Qnil;
>   	}
>         xfont = XLoadQueryFont (display, name);
> -       if (x_had_errors_p (display))
> - 	{
> - 	  /* This error is perhaps due to insufficient memory on X server.
> - 	     Let's just ignore it.  */
> - 	  x_clear_errors (display);
> - 	  xfont = NULL;
> - 	}
>       }
>     fullname = Qnil;
>     /* Try to get the full name of FONT.  */
> --- 561,566 ----

-- 
Michael Welsh Duggan
([email-masked])