From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:47:43 2021 Received: (at submit) by debbugs.gnu.org; 10 Sep 2021 00:47:43 +0000 Received: from localhost ([127.0.0.1]:36452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUhj-0005FQ-0o for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:47:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:33030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUhg-0005FH-UC for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:47:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOUhg-00031x-IX for guix-patches@gnu.org; Thu, 09 Sep 2021 20:47:40 -0400 Received: from out0.migadu.com ([94.23.1.103]:62495) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOUhd-0004Mt-Tr for guix-patches@gnu.org; Thu, 09 Sep 2021 20:47:40 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631234854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=aoU3r/VrtPoyTZwIcAds352BchgpDfpnV0Nf4kUwAl4=; b=hJL3cX7WV0yMjgYhpksUDuL2APe5VBXCg9cheFYGySAwGOrT1m+N2BBagz41rOuSM/H0tX xyYSzloOlL6vh5/DkeSbaXEtnr0DR+OuvYooRcsmSvZQDViBQY2krRuDWMRoZ7M2CMnLd7 zam1kpo64vjysrQmRqydpK3o9isHN48= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH 0/4] gnu: Fix some builds with go@1.17. Date: Thu, 9 Sep 2021 17:47:32 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=94.23.1.103; envelope-from=iskarian@mgsn.dev; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello Guix, These patches fix building four packages with go@1.17. They still build successfully with default go (on x86_64) and have a total of 9 dependents, so should be fine for master. (Three of them are just fixing tests, and the keybase patch doesn't actually change code, just a comment that tripped up Go.) -- Sarah Morgensen (4): gnu: go-github-com-keybase-go-ps: Patch for go@1.17. gnu: go-github-com-sevlyar-go-daemon: Fix tests for go@1.17. gnu: go-github-com-urfave-cli: Fix tests with go@1.17. gnu: go-github-com-urfave-cli-v2: Fix tests with go@1.17. gnu/local.mk | 2 + gnu/packages/golang.scm | 18 +++++++-- .../go-github-com-urfave-cli-fix-tests.patch | 28 ++++++++++++++ ...o-github-com-urfave-cli-v2-fix-tests.patch | 37 +++++++++++++++++++ 4 files changed, 82 insertions(+), 3 deletions(-) create mode 100644 gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch create mode 100644 gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch base-commit: 370d1cdb61e1b9b5467d2aed4cab89c2a8e2a491 -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:50:15 2021 Received: (at 50495) by debbugs.gnu.org; 10 Sep 2021 00:50:15 +0000 Received: from localhost ([127.0.0.1]:36463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkB-0005Js-LO for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:15 -0400 Received: from out0.migadu.com ([94.23.1.103]:63069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkA-0005Jj-Ah for 50495@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:14 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=35RIA4zOoenbIY91ooCSttJfd+aeBMON66S3Ng+bx7M=; b=MeI1sD4Q4MUm9kP5BWw5CB25n4D4fuYpVX7qHsy0JTlZT300JxPuYfMAN8/dEi7i0UZiy5 5HxQB3Re/buieNeENV/IQzZXI4chKI6tLhwB/E2ZzNA4/ZIurGwdaGxk+sox5qjgC9cQ91 lTc5xMAiIgixzG81fVgiGQjQSKfXqcU= From: Sarah Morgensen To: 50495@debbugs.gnu.org Subject: [PATCH 1/4] gnu: go-github-com-keybase-go-ps: Patch for go@1.17. Date: Thu, 9 Sep 2021 17:50:07 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/golang.scm (go-github-com-keybase-go-ps)[arguments] <#:phases>{fix-tests}: Remove extraneous build line to appease go@1.17. --- gnu/packages/golang.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 2dfd47d396..4577c49cba 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1597,7 +1597,9 @@ (define-public go-github-com-keybase-go-ps (("/bin/sleep" command) (string-append (assoc-ref (or native-inputs inputs) "coreutils") - command)))))))) + command))) + (substitute* "src/github.com/keybase/go-ps/process_openbsd.go" + (("^// \\+build ignore") ""))))))) (native-inputs `(("coreutils" ,coreutils) ("go-github-com-stretchr-testify" -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:50:19 2021 Received: (at 50495) by debbugs.gnu.org; 10 Sep 2021 00:50:19 +0000 Received: from localhost ([127.0.0.1]:36466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkE-0005KD-SK for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:19 -0400 Received: from out0.migadu.com ([94.23.1.103]:63078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkB-0005Jr-Dy for 50495@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:15 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8o/YpLGlv4//jseyWrAsczwaaTy/9Thf5/LtC42LhSw=; b=aetWPDxUn1nU1t8lvj/vUzTqDv2T+4VCKJ0oRQjbEKKrrUMOdMRkr9Ji4c8G/HT/Ob62XA A0mbbsb/aUNhuqi56DT5ukGIPo7YAGX9UyqYj3bW67MR+OH2AMRi2OOOc527TWKNHYnBid 5gibXESxGX1mlZl6v0PHTeGTqUsHGxQ= From: Sarah Morgensen To: 50495@debbugs.gnu.org Subject: [PATCH 2/4] gnu: go-github-com-sevlyar-go-daemon: Fix tests for go@1.17. Date: Thu, 9 Sep 2021 17:50:08 -0700 Message-Id: <4804d8146607ac2795118557ee2087c198bd6fa6.1631234078.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/golang.scm (go-github-com-sevlyar-go-daemon)[source]: Add snippet to fix tests for go@1.17. --- gnu/packages/golang.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 4577c49cba..b08796e22a 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -1558,6 +1558,12 @@ (define-public go-github-com-sevlyar-go-daemon (url "https://github.com/sevlyar/go-daemon") (commit (string-append "v" version)))) (file-name (git-file-name name version)) + (modules '((guix build utils))) + (snippet + ;; XXX: Remove when updating + '(begin + (substitute* "compilation_test.go" + ((".*\"darwin/386\".*") "")))) (sha256 (base32 "1y3gnxaifykcjcbzx91lz9bc93b95w3xj4rjxjbii26pm3j7gqyk")))) (build-system go-build-system) -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:50:19 2021 Received: (at 50495) by debbugs.gnu.org; 10 Sep 2021 00:50:19 +0000 Received: from localhost ([127.0.0.1]:36468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkF-0005KG-3o for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:19 -0400 Received: from out0.migadu.com ([94.23.1.103]:63091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkD-0005K5-8k for 50495@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:17 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GDxroX+waxxWBErB3OphsBJQwv1JzknxZUtJXIm39K4=; b=CUihANKoqUDPjh6wrG2sx/Wr1D64syswy7LfgCrDdeBvB+EeLpNRDFWegsFqSmUrH9S4ds RHUKU2LSHrKTNHNK7CMJ3MufDYtmWbktGpBszwB/RWPMelSMuhwq9SdsajN4moRyLsZ9iA WibDANRPAKmiXAICd1A5exIZj6RxnjM= From: Sarah Morgensen To: 50495@debbugs.gnu.org Subject: [PATCH 3/4] gnu: go-github-com-urfave-cli: Fix tests with go@1.17. Date: Thu, 9 Sep 2021 17:50:09 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/golang.scm (go-github-com-urfave-cli)[origin]: Apply it. --- gnu/local.mk | 1 + gnu/packages/golang.scm | 3 +- .../go-github-com-urfave-cli-fix-tests.patch | 28 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index 2a56c4a9e2..bd6e2e79d0 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1184,6 +1184,7 @@ dist_patch_DATA = \ %D%/packages/patches/gobject-introspection-cc.patch \ %D%/packages/patches/gobject-introspection-girepository.patch \ %D%/packages/patches/go-fix-script-tests.patch \ + %D%/packages/patches/go-github-com-urfave-cli-fix-tests.patch \ %D%/packages/patches/go-skip-gc-test.patch \ %D%/packages/patches/gpm-glibc-2.26.patch \ %D%/packages/patches/gpodder-disable-updater.patch \ diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b08796e22a..2d0bbdb30d 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -4976,7 +4976,8 @@ (define-public go-github-com-urfave-cli (file-name (git-file-name name version)) (sha256 (base32 - "10mcnvi5qmn00vpyk6si8gjka7p654wr9hac4zc9w5h3ickhvbdc")))) + "10mcnvi5qmn00vpyk6si8gjka7p654wr9hac4zc9w5h3ickhvbdc")) + (patches (search-patches "go-github-com-urfave-cli-fix-tests.patch")))) (build-system go-build-system) (arguments '(#:import-path "github.com/urfave/cli")) diff --git a/gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch b/gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch new file mode 100644 index 0000000000..7408d4ec16 --- /dev/null +++ b/gnu/packages/patches/go-github-com-urfave-cli-fix-tests.patch @@ -0,0 +1,28 @@ +Backported from upstream PR: https://github.com/urfave/cli/pull/1299 +--- +diff --git a/app_test.go b/app_test.go +index 33024ff..6b3aaa3 100644 +--- a/app_test.go ++++ b/app_test.go +@@ -513,18 +513,18 @@ func TestApp_RunAsSubcommandParseFlags(t *testing.T) { + func TestApp_RunAsSubCommandIncorrectUsage(t *testing.T) { + a := App{ + Flags: []Flag{ +- StringFlag{Name: "--foo"}, ++ StringFlag{Name: "foo"}, + }, + Writer: bytes.NewBufferString(""), + } + + set := flag.NewFlagSet("", flag.ContinueOnError) +- _ = set.Parse([]string{"", "---foo"}) ++ _ = set.Parse([]string{"", "-bar"}) + c := &Context{flagSet: set} + + err := a.RunAsSubcommand(c) + +- expect(t, err, errors.New("bad flag syntax: ---foo")) ++ expect(t, err.Error(), "flag provided but not defined: -bar") + } + + func TestApp_CommandWithFlagBeforeTerminator(t *testing.T) { -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:50:22 2021 Received: (at 50495) by debbugs.gnu.org; 10 Sep 2021 00:50:23 +0000 Received: from localhost ([127.0.0.1]:36471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkI-0005Kb-Hz for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:22 -0400 Received: from out0.migadu.com ([94.23.1.103]:63110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUkF-0005KE-9r for 50495@debbugs.gnu.org; Thu, 09 Sep 2021 20:50:19 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GLsFnlnUHfFSX7M84WJBsEChuilpCJU7+Y/4lr+uu0=; b=HO7/moPOw9TJL48x2sJ1a1q9tBPyn3vj00ETdpniwEzYiRsZSSLsu+ehgH8TNqDvCjbfDV 40tKxtyN9UmravafOtCIajL/cOinKtmWhmHemWcUTlvkQWHhYTNB0LOs2kSNBA88q0goZ3 GRCvGBp0BaiJbPzzzThiZZdfCqGcNWg= From: Sarah Morgensen To: 50495@debbugs.gnu.org Subject: [PATCH 4/4] gnu: go-github-com-urfave-cli-v2: Fix tests with go@1.17. Date: Thu, 9 Sep 2021 17:50:10 -0700 Message-Id: <4acdf53ef984f8726f85f0a135441daa4f02d19a.1631234078.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50495 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/golang.scm (go-github-com-urfave-cli-v2)[origin]: Apply it. --- gnu/local.mk | 1 + gnu/packages/golang.scm | 5 ++- ...o-github-com-urfave-cli-v2-fix-tests.patch | 37 +++++++++++++++++++ 3 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index bd6e2e79d0..c7fde5348f 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1185,6 +1185,7 @@ dist_patch_DATA = \ %D%/packages/patches/gobject-introspection-girepository.patch \ %D%/packages/patches/go-fix-script-tests.patch \ %D%/packages/patches/go-github-com-urfave-cli-fix-tests.patch \ + %D%/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch \ %D%/packages/patches/go-skip-gc-test.patch \ %D%/packages/patches/gpm-glibc-2.26.patch \ %D%/packages/patches/gpodder-disable-updater.patch \ diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 2d0bbdb30d..4c6b41e406 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -5003,7 +5003,10 @@ (define-public go-github-com-urfave-cli-v2 (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "08pvn7gyfznni72xrxfh2x6xxa8ykr7l1ka278js8g8qkh71bj8l")))) + (base32 "08pvn7gyfznni72xrxfh2x6xxa8ykr7l1ka278js8g8qkh71bj8l")) + ;; XXX: Remove patch when updating. + (patches + (search-patches "go-github-com-urfave-cli-v2-fix-tests.patch")))) (arguments '(#:import-path "github.com/urfave/cli/v2")))) diff --git a/gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch b/gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch new file mode 100644 index 0000000000..87ccc2b655 --- /dev/null +++ b/gnu/packages/patches/go-github-com-urfave-cli-v2-fix-tests.patch @@ -0,0 +1,37 @@ +From upstream PR: https://github.com/urfave/cli/pull/1299 + +From: William Wilson +Date: Tue, 31 Aug 2021 14:19:17 -0500 +Subject: Make test case compatible with Go 1.17 + +As of Go 1.17, the go flag package will panic if given a syntactically invalid +flag. This causes TestApp_RunAsSubCommandIncorrectUsage to panic and therefore +fail. See https://golang.org/doc/go1.17#flag for more information. + +--- +diff --git a/app_test.go b/app_test.go +index 7c38f6048..76e211d68 100644 +--- a/app_test.go ++++ b/app_test.go +@@ -476,18 +476,18 @@ func TestApp_RunAsSubCommandIncorrectUsage(t *testing.T) { + a := App{ + Name: "cmd", + Flags: []Flag{ +- &StringFlag{Name: "--foo"}, ++ &StringFlag{Name: "foo"}, + }, + Writer: bytes.NewBufferString(""), + } + + set := flag.NewFlagSet("", flag.ContinueOnError) +- _ = set.Parse([]string{"", "---foo"}) ++ _ = set.Parse([]string{"", "-bar"}) + c := &Context{flagSet: set} + + err := a.RunAsSubcommand(c) + +- expect(t, err, errors.New("bad flag syntax: ---foo")) ++ expect(t, err.Error(), "flag provided but not defined: -bar") + } + + func TestApp_CommandWithFlagBeforeTerminator(t *testing.T) { -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:51:57 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:51:57 +0000 Received: from localhost ([127.0.0.1]:36482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUlp-0005NO-92 for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:51:57 -0400 Received: from out1.migadu.com ([91.121.223.63]:65390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUlm-0005NF-Tm for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:51:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=zAEO++7D49NDFq4TBJ09R0JxGnU8yxGjg1FrQ6u1ubY=; b=Di5eYYy75CyP2hbb5pjf4c/pGJ260KQHJBJdpKq/0osfhxRSeXxrebSKlDz/ACIlHhTf7x eTjspcEIRiUL/J1aF0COTBdAQw8EdlI0HFO5FUnqEVDuLo3R2kmQpU23feJXtZ4GYrmP9R zQ/MxRBzwGxvy4eSdKkmEbHG5b3CMfg= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50348 Date: Thu, 09 Sep 2021 17:51:50 -0700 Message-ID: <8635qdmevt.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 50348 by 50227 49921 50495 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:55:22 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:55:22 +0000 Received: from localhost ([127.0.0.1]:36488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUp8-0005V0-Lz for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:55:22 -0400 Received: from out2.migadu.com ([188.165.223.204]:30124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUp6-0005Ur-Ni for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:55:21 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=B/qPrTcJOdY5legLYdOLc+SiXtSfsheZybOp/nl8IQg=; b=L9EbR01uvAtvDBDjOI8aPpdMq0n5enPSqXobUB46adEv31mBoMCWc9rZWKpEjS6MSA/wQu /npKmZ7MKHnWM9qCvC/B2LOo0SxvuWNeBFY4KXGh2bHlSWojknNtRwyRjfI8R/OkqEVXOv AChTTArTAm/MSfAlw4+L9Ewx09yRKjg= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50348 Date: Thu, 09 Sep 2021 17:55:17 -0700 Message-ID: <861r5xmeq2.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unblock 50348 by 50227 49921 50495 thanks Oops, wrong bug #. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:56:37 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:56:37 +0000 Received: from localhost ([127.0.0.1]:36493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUqK-0005XR-TO for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:56:37 -0400 Received: from out0.migadu.com ([94.23.1.103]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUqI-0005XI-TH for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:56:35 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=v4vDHhPH7N9GIAUIiyYpwKP8+7zTUYRqugxihRgahIM=; b=MolBqV/qij1PrDzD3YkAAedzAbe2HB+o2OcyCliHmYAxQwsrbPnUUH+PjakduCHwhm83dC JwOy6ENviBm9Smj0ZyRRQsGyLMPQt76GP2losYmvpbLWnUgVcWPHP1CUkMKksYtpkcn+nX 1EPeKToncJuXkeRZnKi5J6SyeF77tyw= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50493 Date: Thu, 09 Sep 2021 17:56:31 -0700 Message-ID: <86zgsll03k.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 50493 by 50495 49921 50227 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 21:42:02 2021 Received: (at 50495) by debbugs.gnu.org; 10 Sep 2021 01:42:02 +0000 Received: from localhost ([127.0.0.1]:36513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOVYI-0000LW-8U for submit@debbugs.gnu.org; Thu, 09 Sep 2021 21:42:02 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOVYF-0000L8-Nd for 50495@debbugs.gnu.org; Thu, 09 Sep 2021 21:42:00 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1FC255C00C5; Thu, 9 Sep 2021 21:41:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 09 Sep 2021 21:41:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=c0mJ65RfCpe73AYO/MTSXTAy 8HnVzQud8uva2WYnUCo=; b=HhSX4zywpgCOUWCNniohMGzt8HCV+yOIY8WvveFT zuhhJzaSvABwtYv3Bpn6MK0V35T4LpKD+kKUPGi9Cw/aKcLlt5iaVA17bYJzj5/g t7GKIiE1JGd//si3WNGTRP86QB+ylXdVAKgVUbI1SD71Epsr6TdlWr19GEnVbHAh 0Jo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=c0mJ65 RfCpe73AYO/MTSXTAy8HnVzQud8uva2WYnUCo=; b=wq+m7CqtkeUspz/a16iSzG DsoLnGhwps/V13emddBla3DVLl/7QoYjV/Yk0mJdvzvq710WWO3eMYXLT/xKCfNd yfgmTCn3XDikW7g8vIct8AuFaDEfBwyAdfdQVX4crbb2nYkIpQKVW28rKSNucyJY hXMTp4CWLP+ldN6n51nUNNAR53Sh0VD41FFqK8aPYQtVBEUz8iwGr3MyDgYqocfD W2qtCrEy/ORimOo30a2RVrHCkrey/Th79nDXoK33nRJcbtxTV4TgklUHkYDIvwZi J1vXq1glM4Z0ocXMYSlkyMLMRhwn/Ed0r9d/bbzxMq7q2tqkhVaCFKNbg6bUgXfg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegtddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepueekkedtffdvtddugeejgedtvefhue efiedvjeeitdeigedtveejvdejheffvefgnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 21:41:53 -0400 (EDT) Date: Thu, 9 Sep 2021 21:41:51 -0400 From: Leo Famulari To: Sarah Morgensen Subject: Re: [bug#50495] [PATCH 0/4] gnu: Fix some builds with go@1.17. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50495 Cc: 50495@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 09, 2021 at 05:47:32PM -0700, Sarah Morgensen wrote: > Hello Guix, > > These patches fix building four packages with go@1.17. They still build > successfully with default go (on x86_64) and have a total of 9 dependents, > so should be fine for master. (Three of them are just fixing tests, and the > keybase patch doesn't actually change code, just a comment that tripped up > Go.) Thanks for these patches! I tweaked the commit titles to make them a little more consistent and less idiomatic and pushed as 63cc4dd5793b62802354a31d8e6913f065d3bcec. I think that using plain and verbose English can help people coming from other languages. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 21:42:13 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 01:42:13 +0000 Received: from localhost ([127.0.0.1]:36517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOVYT-0000M2-Jd for submit@debbugs.gnu.org; Thu, 09 Sep 2021 21:42:13 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOVYR-0000Lp-7z for control@debbugs.gnu.org; Thu, 09 Sep 2021 21:42:11 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 22CF35C00C5; Thu, 9 Sep 2021 21:42:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 09 Sep 2021 21:42:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:message-id:mime-version:content-type; s=mesmtp; bh=AWX7voEJEygo2HBzWdzg1rZeDI1DVknPtr6kyQouJq8=; b=mac3lXOt1k6b HaaMpSdcScMQWlLuQxqbsDsIyrKZt3eAo3Z6bQPrJwX0gCENqY8YXOjA32jku8nY PSNDrsPv/j5TrgWr0ca176aMkD1FRq0FMJVMNPyR7w1TWTTq6coQXFgdbnkDOyk+ xjgJRGkSfgEl9IT7Uxg6n2DhXMDk8no= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=AWX7voEJEygo2HBzWdzg1rZeDI1DVknPtr6kyQouJ q8=; b=lvJxll3SIMhw/CHjowztEMxDO8F5yaviU2YQTXieXG3VSS0GqAoTIBlNf kb2m9BLpx4+qiz4ju0WieRD1daWuOW5EigAkgSQ7i9BqbIIAC6v2+nWseGoNuzdL xb7az7RBMjmKfjbqB5bgIph3nkX9j8MeoSR/+3tf3OghfRRQQO743ny5oPPZ7UQ8 whgUysJ+kJ04JWnyXe7LXBTxI2f/uQqTE/oA91/Ttpvz+cetlAlragTALp+EZUSp ECtuM+Ta0QYEU8s8Of6ngt5aAaQl7AJkF+zHIbEr7MrTasyVYjrhQRQXVmRFT5Tk 3mQTOpOQIcDv1zkcDYmYnx/v1u59Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegtddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpeffhffvkfggtggusehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhl rghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpe fhjeeigfefvedvfeetheegledtkeevuddtgedtudeiteehteegvdefffduffefffenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrg hmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Thu, 9 Sep 2021 21:42:05 -0400 (EDT) Date: Thu, 9 Sep 2021 21:42:04 -0400 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 50495 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [66.111.4.27 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.27 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) close 50495 From unknown Sat Sep 06 02:03:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Oct 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator