From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 18:15:07 2021 Received: (at submit) by debbugs.gnu.org; 9 Sep 2021 22:15:07 +0000 Received: from localhost ([127.0.0.1]:36385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSK3-0001Sj-1Q for submit@debbugs.gnu.org; Thu, 09 Sep 2021 18:15:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:35678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSK1-0001Sa-Im for submit@debbugs.gnu.org; Thu, 09 Sep 2021 18:15:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOSK1-0008Ii-Bz for bug-guix@gnu.org; Thu, 09 Sep 2021 18:15:05 -0400 Received: from out2.migadu.com ([188.165.223.204]:62880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOSJy-0001Mg-Uw for bug-guix@gnu.org; Thu, 09 Sep 2021 18:15:05 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631225699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=L9CHN/5FJXotSjfgjtHxbbq0I/HUr78AYTMqACApnAw=; b=AZ08EMt6vpMj0VYT5Ch7+k3X3uVZ1bOeBqKOpZK4ZB692T4RSjl/uFTTXG9tjTG96SXBj2 i/4piEDFjGYNIms7vPKTzfuOrDfqbOLKluirtPZli4eJWednXEGC4tiTJcXa3CUgODyCo5 9R3M32XJld8BGm0Oq63rzpCx3EkKC44= From: Sarah Morgensen To: bug-guix@gnu.org Subject: Update go-build-system to use Go 1.17. X-Debbugs-CC: Leo Famulari Date: Thu, 09 Sep 2021 15:14:57 -0700 Message-ID: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=188.165.223.204; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello Guix, This is intended to be a tracking issue for updating go-build-system to use Go 1.17 by default. The build system currently uses Go 1.14, which no longer receives security updates [0]. Here's what needs to be done: 1. Address the aarch64 bug [1], either by verifying that it only happens on emulated systems, or by fixing it if not. 2. Make some much-needed improvements to go-build-system [2]: * replace the *slow* phase 'remove-go-references with -trimpath option * avoid building a directory union of Go inputs (and then copying it!) * add a "go-std-cache-for-build" package (hidden; name to be bikeshedded), which will be an implicit input in go-build-system (needed since we removed the pre-built standard library in go-1.17) 3. Some/all Docker packages still require Go 1.14; make them use go-1.14 explicitly. Alternatively, update Docker (significant effort involved). 4. Update or patch broken packages. I've got patches for four so far: go-github-com-urfave-cli go-github-com-urfave-cli-v2 go-github-com-sevlyar-go-daemon go-github-com-keybase-go-ps I'll submit them as a separate patch and block this with it. If anyone else would like to see if their favorite package works with Go 1.17, you can build it with: go build --with-input=go@1.14=go@1.17 [0] https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance [1] https://issues.guix.gnu.org/49921 [2] https://issues.guix.gnu.org/50227#10 -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 18:37:51 2021 Received: (at 50493) by debbugs.gnu.org; 9 Sep 2021 22:37:51 +0000 Received: from localhost ([127.0.0.1]:36410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSg3-00024F-EV for submit@debbugs.gnu.org; Thu, 09 Sep 2021 18:37:51 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOSg1-00023v-I8 for 50493@debbugs.gnu.org; Thu, 09 Sep 2021 18:37:50 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DA3A05C006D; Thu, 9 Sep 2021 18:37:43 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 09 Sep 2021 18:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=GrMUsP1OEHuR4em7TzDSWHJl bmte+Id5jZjahvlZ7CY=; b=a4DkSSG13RxDwfOItE/GIockKTarz9fuInPQgXe3 DPN/W9A/c9jZAbVrdvd6nkmmY/i8FzjamxoAzl4atEgqcm9/zUoq1Z7ElxSF7uCl cJEUi7uPPP7fbJaj58VIHrkSvIi2W1CnO6dKG/a22yel0resxGwkBK4OEgBReTMt zz4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GrMUsP 1OEHuR4em7TzDSWHJlbmte+Id5jZjahvlZ7CY=; b=L9yqjwLcfETKwRyFkXrb69 wntb34A6PJC4vGK60nLUI617N8tg0FAoTHmJS205nP7YMeaRGiOM7J3Q2Hx+w60+ 7+bsZ6nA0STUjrZBnKcbI1zr2g12C3YTqjULhk+A6PtY6cfF8wG3ZXxMTh5w43k3 o9HZw38Rg4ywLkkqxDMNT0dIVebC2cLfW7efrgopeWWTSy5HJIe6o2L4TLb2X1Yb vaUtEhqC/3N2+49HPnnP31jZi7M6p9DnV2sHPkPHhmHNso30pMeX1IdjI/Qb9IJn tY4+KZ86cqlEQqxjACGzfluobAKnLr5Lx/WYykp33pjGsnYD0Lpsdpb6eEdqJ7Zw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegtddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhephefgleevhfdttdefheeitdfgheffff ffledvlefhgfektdethefguefgheegtefhnecuffhomhgrihhnpehgihhthhhusgdrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 18:37:43 -0400 (EDT) Date: Thu, 9 Sep 2021 18:37:37 -0400 From: Leo Famulari To: Sarah Morgensen Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <865yv9mm5a.fsf@mgsn.dev> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 09, 2021 at 03:14:57PM -0700, Sarah Morgensen wrote: > This is intended to be a tracking issue for updating go-build-system to > use Go 1.17 by default. The build system currently uses Go 1.14, which > no longer receives security updates [0]. Thanks for putting this together. > Here's what needs to be done: > > 1. Address the aarch64 bug [1], either by verifying that it only happens > on emulated systems, or by fixing it if not. It looks like there was a patch for this issue: https://github.com/golang/go/issues/20763#issuecomment-314627882 And it was apparently added to Go, but maybe it was not sufficient, did not make it into a release, or we are seeing a different bug. > 2. Make some much-needed improvements to go-build-system [2]: > > * replace the *slow* phase 'remove-go-references with -trimpath option > > * avoid building a directory union of Go inputs (and then copying it!) Are these required to use 1.17? I agree they are important problems to fix but we shouldn't let them block the upgrade. > * add a "go-std-cache-for-build" package (hidden; name to be > bikeshedded), which will be an implicit input in go-build-system (needed > since we removed the pre-built standard library in go-1.17) Okay. Feel free to choose the name. I think it's your shed. > 3. Some/all Docker packages still require Go 1.14; make them use go-1.14 > explicitly. Alternatively, update Docker (significant effort involved). Okay. > 4. Update or patch broken packages. I've got patches for four so far: > > go-github-com-urfave-cli > go-github-com-urfave-cli-v2 > go-github-com-sevlyar-go-daemon > go-github-com-keybase-go-ps > > I'll submit them as a separate patch and block this with it. If anyone > else would like to see if their favorite package works with Go 1.17, you > can build it with: Okay, great. > go build --with-input=go@1.14=go@1.17 Syncthing builds! That's great. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:56:37 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:56:37 +0000 Received: from localhost ([127.0.0.1]:36493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUqK-0005XR-TO for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:56:37 -0400 Received: from out0.migadu.com ([94.23.1.103]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUqI-0005XI-TH for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:56:35 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=v4vDHhPH7N9GIAUIiyYpwKP8+7zTUYRqugxihRgahIM=; b=MolBqV/qij1PrDzD3YkAAedzAbe2HB+o2OcyCliHmYAxQwsrbPnUUH+PjakduCHwhm83dC JwOy6ENviBm9Smj0ZyRRQsGyLMPQt76GP2losYmvpbLWnUgVcWPHP1CUkMKksYtpkcn+nX 1EPeKToncJuXkeRZnKi5J6SyeF77tyw= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50493 Date: Thu, 09 Sep 2021 17:56:31 -0700 Message-ID: <86zgsll03k.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 50493 by 50495 49921 50227 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 20:23:03 2021 Received: (at control) by debbugs.gnu.org; 20 Sep 2021 00:23:04 +0000 Received: from localhost ([127.0.0.1]:40313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS75L-0006Kz-MQ for submit@debbugs.gnu.org; Sun, 19 Sep 2021 20:23:03 -0400 Received: from out1.migadu.com ([91.121.223.63]:52316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS75I-0006KM-T9 for control@debbugs.gnu.org; Sun, 19 Sep 2021 20:23:02 -0400 Date: Sun, 19 Sep 2021 17:22:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632097378; h=from:from:reply-to:subject:subject:date:date:to:to:cc; bh=NylCCXOWP2Bpk0NN2hPFHTFtLdd58zyDb6tolAKkPt8=; b=PTXf5KuG11Yjbgx+BbRnEMiLdUuW4q01LkYJlx1gC6WD0dSHDOKS62HTQxUeTbHEUwQjUu N6H9HmSjDz2P5rliUBdHD6m1xjpncGuN20wsfibyjN2JUWyzkNLXYNjcgyVBcI2LUNrZDG X31nDuxTGoD9/r+jSYCIqL2FzAOkKuE= To: control@debbugs.gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sarah Morgensen Subject: control message for bug #50493 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -1.7 (-) block 50493 by 50688 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 20:23:43 2021 Received: (at control) by debbugs.gnu.org; 20 Sep 2021 00:23:43 +0000 Received: from localhost ([127.0.0.1]:40316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS75y-0006Lt-Ve for submit@debbugs.gnu.org; Sun, 19 Sep 2021 20:23:43 -0400 Received: from out0.migadu.com ([94.23.1.103]:36001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS75x-0006Lk-4T for control@debbugs.gnu.org; Sun, 19 Sep 2021 20:23:41 -0400 Date: Sun, 19 Sep 2021 17:23:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632097419; h=from:from:reply-to:subject:subject:date:date:to:to:cc; bh=vTPqJtxispkOAWMU6kZHXvrxr5Hz3qZSKVUL2HIxIvA=; b=Xk0ySjAfMMHNrPDNAGL/trw4K6tGbGe8bIt4UptSNIuMEANYkm//Gn/HDDMyZU3cZEZrsR loF5DwoWF/tPzaeO5D1LcG2rx6e46a1k6hnlCUSdyZfNLArc8djKo/vvk3nw1mIvjAlQVT ECjZiWdGYVmmEoPLTGMh/EeOnbxE4hE= To: control@debbugs.gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sarah Morgensen Subject: control message for bug #50493 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -1.7 (-) unblock 50493 by 50227 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:19:39 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:19:40 +0000 Received: from localhost ([127.0.0.1]:40569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBiN-0007TF-Lg for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:19:39 -0400 Received: from out0.migadu.com ([94.23.1.103]:19221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBiI-0007Sr-QP for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:19:36 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dDyUnt0a8QkynD+pKs9Nz0ouxlJz5vL8j03OxDqWwfI=; b=iktL3ZC4RJdFZDfF8fdMR4/T93ZPHsUy5hh3sATTG3kKpndLJz4+3EdrPEBiU3lecIgM9u CF5gZKPJ7qVeiYPgcPeaCRM+1AWtU+GWK8/ULVxHIc0jJ90sPLXGmKANQqqLHh1lRDg966 RMji9GtAHA2qXWvnl1hQzqiY+FKCtsQ= From: Sarah Morgensen To: 50493@debbugs.gnu.org Subject: [PATCH staging 0/4] build-system/go: Use go-1.17 by default. Date: Sun, 19 Sep 2021 22:19:30 -0700 Message-Id: In-Reply-To: <865yv9mm5a.fsf@mgsn.dev> References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Guix, This patch series updates the Go build system to use Go 1.17 by default. As a necessity, because go-1.17 no longer contains its own pre-compiled standard library, an implicit input is added to the build system which contains the build cache from building the standard library with the go-build-system. (This way, we can always guarantee that the cache is valid because it's built with the same flags as the build system.) The build system is also modified to make use of this cache. (We use the build cache rather than archives because the Go project is moving away from archives towards an authoritative build cache.) Three packages are modified to keep using an older Go: * docker now explicitly uses go-1.14 * go-ipfs and go-github-com-go-ipfs-cmdkit-files now explitly use go-1.16 (go-ipfs and gx badly need to be upgraded!) There are about 900 dependent packages according to `guix refresh -l go', but I don't know how many are leaf packages, so I marked this for staging. The actual series is based on master because go-1.17 is only present in master. I have built them all out successfully on x86_64. Sarah Morgensen (4): build-system/go: Add #:substitutable? argument. build-system/go: Initialize build cache from input packages. build-system/go: Add pre-built standard library as implicit input. build-system/go: Use go-1.17 by default. gnu/packages/docker.scm | 2 +- gnu/packages/golang.scm | 32 +++++++++++++++++++++++++++++++- gnu/packages/ipfs.scm | 6 ++++-- guix/build-system/go.scm | 24 ++++++++++++++++++++---- guix/build/go-build-system.scm | 26 +++++++++++++++++++++++--- 5 files changed, 79 insertions(+), 11 deletions(-) base-commit: a640ee7da3311e4fa560c7163d2dd7d24a25585a -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:20:56 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:20:56 +0000 Received: from localhost ([127.0.0.1]:40575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjc-0007VQ-08 for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:20:56 -0400 Received: from out2.migadu.com ([188.165.223.204]:41697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBja-0007VD-CH for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:20:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115252; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nMQlPJvjS2emZsZbcef7yAzP8j24x1MdddyrjNR17kQ=; b=XFAmua7rKqbxEYwgNbU71X6Zvl3qA00ID6zSjbld2rprnIQRxTMQ6AllRSfc8T3pVEul05 Ecx8lC8UQawGCZRbKajKWwScCk+wX5t9UCS7+U7Ktc6AQ3V1QDFLZokKnvWgZXn8t0uDN3 HCfRbF6SaBaNSzr90xtJ6m+tBUx55Is= From: Sarah Morgensen To: 50493@debbugs.gnu.org Subject: [PATCH 1/4] build-system/go: Add #:substitutable? argument. Date: Sun, 19 Sep 2021 22:20:48 -0700 Message-Id: <886cdf3621d5a9592e833be510d549484f558970.1632099301.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50493 Cc: leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/build-system/go.scm (go-build): Add 'substitutable?' argument. (go-cross-build): Likewise. --- guix/build-system/go.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index 4c1a732107..8aa065c4ff 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -169,7 +169,8 @@ (define* (go-build store name inputs (imported-modules %go-build-system-modules) (modules '((guix build go-build-system) (guix build union) - (guix build utils)))) + (guix build utils))) + (substitutable? #t)) (define builder `(begin (use-modules ,@modules) @@ -211,6 +212,7 @@ (define* (go-build store name inputs #:system system #:modules imported-modules #:outputs outputs + #:substitutable? substitutable? #:guile-for-build guile-for-build)) (define* (go-cross-build store name @@ -234,7 +236,8 @@ (define* (go-cross-build store name (imported-modules %go-build-system-modules) (modules '((guix build go-build-system) (guix build union) - (guix build utils)))) + (guix build utils))) + (substitutable? #t)) "Cross-build NAME using GO, where TARGET is a GNU triplet and with INPUTS." (define builder `(begin @@ -303,6 +306,7 @@ (define* (go-cross-build store name #:inputs (append native-drvs target-drvs) #:outputs outputs #:modules imported-modules + #:substitutable? substitutable? #:guile-for-build guile-for-build)) (define go-build-system -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:21:01 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:21:01 +0000 Received: from localhost ([127.0.0.1]:40579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjh-0007Vv-7E for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:21:01 -0400 Received: from out1.migadu.com ([91.121.223.63]:20574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBje-0007VY-Sr for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:20:59 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n1MhkWHxf2MGqQvKmtMdO7XKu38ptsalVmfg5r3MLa4=; b=fphj8nCZ1k7ZyFD3xzhMkyCVJUHmXRDo5UwDNl0tOERFvWGvypL0uEE8jkiT1A2NhQjZCA ZGNnQqItMnCUz/8RalZnlfP6Oidy97j+rGojlcmbt/35t9R7a/zWQLMEilWYjizhsfFeMg A27Ov4X4yiN2OGzsgF9aI6FViuLjBGg= From: Sarah Morgensen To: 50493@debbugs.gnu.org Subject: [PATCH 3/4] build-system/go: Add pre-built standard library as implicit input. Date: Sun, 19 Sep 2021 22:20:50 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/golang.scm (make-go-std): New procedure. * guix/build-system/go.scm (make-go-std): New procedure. (lower): Use it. Add pre-built standard library to inputs. --- gnu/packages/golang.scm | 30 ++++++++++++++++++++++++++++++ guix/build-system/go.scm | 16 ++++++++++++++-- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index f02d0aa9df..19f1ef37d5 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -792,6 +792,36 @@ (define-public go-1.17 (define-public go go-1.14) +(define-public (make-go-std go) + "Return a package which builds the standard library for Go compiler GO." + (package + (name (string-append (package-name go) "-std")) + (version (package-version go)) + (source #f) + (build-system go-build-system) + (arguments + `(#:import-path "std" + #:build-flags `("-pkgdir" "pkg") ; "Install" to build directory. + #:allow-go-reference? #t + #:substitutable? #f ; Faster to build than download. + #:tests? #f ; Already tested in the main Go build. + #:go ,go + #:phases + (modify-phases %standard-phases + (delete 'unpack) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (out-cache (string-append out "/var/cache/go/build"))) + (copy-recursively (getenv "GOCACHE") out-cache) + (delete-file (string-append out-cache "/trim.txt")) + (delete-file (string-append out-cache "/README"))))) + (delete 'install-license-files)))) + (home-page (package-home-page go)) + (synopsis "Cached standard library build for Go") + (description (package-description go)) + (license (package-license go)))) + (define-public go-0xacab-org-leap-shapeshifter (let ((commit "0aa6226582efb8e563540ec1d3c5cfcd19200474") (revision "12")) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index 8aa065c4ff..a579477500 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2017 Leo Famulari ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2021 Efraim Flashner +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -109,6 +110,9 @@ (define (default-go) (let ((go (resolve-interface '(gnu packages golang)))) (module-ref go 'go))) +(define (make-go-std) + (module-ref (resolve-interface '(gnu packages golang)) 'make-go-std)) + (define* (lower name #:key source inputs native-inputs outputs system target (go (default-go)) @@ -118,6 +122,14 @@ (define* (lower name (define private-keywords '(#:source #:target #:go #:inputs #:native-inputs)) + (define inputs-with-cache + ;; XXX: Avoid a circular dependency. This should be rewritten with + ;; 'package-mapping' or similar. + (let ((go-std-name (string-append (package-name go) "-std"))) + (if (string-prefix? go-std-name name) + inputs + (cons `(,go-std-name ,((make-go-std) go)) inputs)))) + (bag (name name) (system system) @@ -127,7 +139,7 @@ (define* (lower name '()) ,@`(("go" ,go)) ,@native-inputs - ,@(if target '() inputs) + ,@(if target '() inputs-with-cache) ,@(if target ;; Use the standard cross inputs of ;; 'gnu-build-system'. @@ -135,7 +147,7 @@ (define* (lower name '()) ;; Keep the standard inputs of 'gnu-build-system'. ,@(standard-packages))) - (host-inputs (if target inputs '())) + (host-inputs (if target inputs-with-cache '())) ;; The cross-libc is really a target package, but for bootstrapping ;; reasons, we can't put it in 'host-inputs'. Namely, 'cross-gcc' is a -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:21:02 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:21:02 +0000 Received: from localhost ([127.0.0.1]:40581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjh-0007W7-Kh for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:21:02 -0400 Received: from out0.migadu.com ([94.23.1.103]:19597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjf-0007Vb-Jy for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:21:00 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ywqrWM6o0T01lBOE4Gy7ZDiHUUkTzfN5szsLxX791nI=; b=N9EhDRxuNXNMqBBjfsEH6iV2Rbie4bXm25CB/Pw1zFmsgnYD/v+xo4XO3raIYg9cLSpe2f FSW2uHxcxq/tm+F/uo8XLDJ+Fz7h+Cz8GrTfCYE7Gfk0CzjgCq+NC1YfikIoX75ysOnkLi UFEF6ceLshBplbAuPTJGvGW5ksgsRa0= From: Sarah Morgensen To: 50493@debbugs.gnu.org Subject: [PATCH 4/4] build-system/go: Use go-1.17 by default. Date: Sun, 19 Sep 2021 22:20:51 -0700 Message-Id: <2db7749e36277825f029a3b059ca8d4daaa82cbc.1632099301.git.iskarian@mgsn.dev> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Build all Go packages with go-1.17 by default. Explicitly specify an older Go version in packages which cannot build with go-1.17. * gnu/packages/golang.scm (go): Update from 'go-1.14' to 'go-1.17'. * gnu/packages/docker.scm (docker)[native-inputs]: Explicitly use 'go-1.14'. * gnu/packages/ipfs.scm (go-ipfs)[arguments]: Set #:go to 'go-1.16'. (go-github-com-ipfs-go-ipfs-cmdkit-files)[arguments]: Likewise. --- gnu/packages/docker.scm | 2 +- gnu/packages/golang.scm | 2 +- gnu/packages/ipfs.scm | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm index 8bac1b89ce..fa666cbb04 100644 --- a/gnu/packages/docker.scm +++ b/gnu/packages/docker.scm @@ -594,7 +594,7 @@ (define-public docker ("xz" ,xz))) (native-inputs `(("eudev" ,eudev) ; TODO: Should be propagated by lvm2 (.pc -> .pc) - ("go" ,go) + ("go" ,go-1.14) ("gotestsum" ,gotestsum) ("pkg-config" ,pkg-config))) (synopsis "Docker container component library, and daemon") diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 19f1ef37d5..d1ed30455c 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -790,7 +790,7 @@ (define-public go-1.17 "README.md" "SECURITY.md")))))))) (inputs (alist-delete "gcc:lib" (package-inputs go-1.16))))) -(define-public go go-1.14) +(define-public go go-1.17) (define-public (make-go-std go) "Return a package which builds the standard library for Go compiler GO." diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm index 57701991e3..8d5b4f1767 100644 --- a/gnu/packages/ipfs.scm +++ b/gnu/packages/ipfs.scm @@ -46,7 +46,8 @@ (define-public go-github-com-ipfs-go-ipfs-cmdkit-files "0qk6fshgdmhp8dip2ksm13j6nywi41m9mn0czkvmw6b697z85l2r")))) (build-system go-build-system) (arguments - '(#:unpack-path "github.com/ipfs/go-ipfs-cmdkit" + `(#:go ,go-1.16 + #:unpack-path "github.com/ipfs/go-ipfs-cmdkit" #:import-path "github.com/ipfs/go-ipfs-cmdkit/files")) (home-page "https://github.com/ipfs/go-ipfs-cmdkit") (synopsis "Shared types, functions and values for go-ipfs") @@ -226,7 +227,8 @@ (define-public go-ipfs (file-name (string-append name "-" version "-source")))) (build-system go-build-system) (arguments - '(#:unpack-path "github.com/ipfs/go-ipfs" + `(#:go ,go-1.16 + #:unpack-path "github.com/ipfs/go-ipfs" #:import-path "github.com/ipfs/go-ipfs/cmd/ipfs" #:phases (modify-phases %standard-phases (add-before 'reset-gzip-timestamps 'make-files-writable -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:21:03 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:21:03 +0000 Received: from localhost ([127.0.0.1]:40583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjj-0007WO-1F for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:21:03 -0400 Received: from out2.migadu.com ([188.165.223.204]:41712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBjb-0007VH-70 for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:21:00 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GZ5iPxFRLyQRvT+3cDSGw0gcN+tlNQkzqXDpVDuawZY=; b=NCH4WtlvGy0FITnjxq+MZaqp5h0zS9lefCR6AtHTEJN09xWCJ23St3+t0X67zkFrZ+soW7 FUKeqmXaAhcNdpnMwLL8eX1chDFeodSokTJIsXhb6OPu3PYH2EZ5nmftZUtVpZUsGXHoew QqqPpkMh73Bz7XKueAzR9MK+KFO7+Is= From: Sarah Morgensen To: 50493@debbugs.gnu.org Subject: [PATCH 2/4] build-system/go: Initialize build cache from input packages. Date: Sun, 19 Sep 2021 22:20:49 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50493 Cc: leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/build/go-build-system.com (setup-go-environment): Set GOCACHE to a location within the build directory. Union "/var/cache/go/build" input directories to initialize the cache. Generate "trim.txt" within the cache, with the current time. --- guix/build/go-build-system.scm | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 645d2fe680..9f249b0777 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2020 Jack Hill ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2020, 2021 Efraim Flashner +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -138,9 +139,28 @@ (define* (setup-go-environment #:key inputs outputs goos goarch #:allow-other-ke where executables (\"commands\") are installed to. This phase is sometimes used by packages that use (guix build-system gnu) but have a handful of Go dependencies, so it should be self-contained." - ;; The Go cache is required starting in Go 1.12. We don't actually use it but - ;; we need it to be a writable directory. - (setenv "GOCACHE" "/tmp/go-cache") + (define (search-input-directories dir) + (filter directory-exists? + (map (match-lambda + ((name . directory) + (string-append directory "/" dir))) + inputs))) + + ;; Seed the Go build cache with the build caches from input packages. + (let ((cache (string-append (getcwd) "/go-build"))) + (setenv "GOCACHE" cache) + (union-build cache + (search-input-directories "/var/cache/go/build") + ;; Creating all directories isn't that bad, because there are + ;; only ever 256 of them. + #:create-all-directories? #t + #:log-port (%make-void-port "w")) + + ;; Tell Go that the cache was recently trimmed, so it doesn't try to. + (call-with-output-file (string-append cache "/trim.txt") + (lambda (port) + (format port "~a" (current-time))))) + ;; Using the current working directory as GOPATH makes it easier for packagers ;; who need to manipulate the unpacked source code. (setenv "GOPATH" (getcwd)) -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:28:40 2021 Received: (at 50493) by debbugs.gnu.org; 20 Sep 2021 05:28:40 +0000 Received: from localhost ([127.0.0.1]:40590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBr5-0007hh-Vj for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:28:40 -0400 Received: from out1.migadu.com ([91.121.223.63]:22572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBr4-0007ha-Md for 50493@debbugs.gnu.org; Mon, 20 Sep 2021 01:28:39 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FohsNRAknG1yE9U6VKykheS6z0vK/BRPlJxQH0TajFw=; b=dqN43KoIwmBQ8+nQfBfphoLFYnTZqy9T1bakhjdPVjzZM7e4xno3ahYjcM1i0al6iBDG3O lTiKca9LEJIVAB9swc+WFGt/OvFbMB6Xvr/4vO1UT7MsyIiEC7eymxYDIe52hNcn43ino0 LyUvzZzC9PIAL+1Zeioqi92qPOhsUdQ= From: Sarah Morgensen To: Leo Famulari Subject: Re: bug#50493: Update go-build-system to use Go 1.17. References: <865yv9mm5a.fsf@mgsn.dev> Date: Sun, 19 Sep 2021 22:28:33 -0700 In-Reply-To: (Leo Famulari's message of "Thu, 9 Sep 2021 18:37:37 -0400 (1 week, 3 days, 6 hours ago)") Message-ID: <86bl4nhl32.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Apologies it's taken so long for a proper response! >> 2. Make some much-needed improvements to go-build-system [2]: >> >> * replace the *slow* phase 'remove-go-references with -trimpath option >> >> * avoid building a directory union of Go inputs (and then copying it!) > > Are these required to use 1.17? I agree they are important problems to > fix but we shouldn't let them block the upgrade. You're right. I've gone ahead and sent a patch series to this bug which rolls the cache, docker, and the update all together. I've added one more blocker: #50688 [0], which is a dependency of chezmoi. This should just leave #49921, the aarch64 issue, then this is patch is ready to go. With the patch from #50688, I was to build out all dependents listed by `guix refresh -l go' (about 900). Thanks for sticking with this! :) [0] https://issues.guix.gnu.org/50688 -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 01:32:03 2021 Received: (at control) by debbugs.gnu.org; 20 Sep 2021 05:32:03 +0000 Received: from localhost ([127.0.0.1]:40606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBuN-0007tv-6Y for submit@debbugs.gnu.org; Mon, 20 Sep 2021 01:32:03 -0400 Received: from out2.migadu.com ([188.165.223.204]:44580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSBuJ-0007tD-8m for control@debbugs.gnu.org; Mon, 20 Sep 2021 01:31:59 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632115918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=LxjmmKw6aQebAdANxy8B8pcB5LKr7oIR0IegktM916s=; b=WMU9j08QeeHwVCmZCoaGTae09pEcVUEvJzZx1WehUrNfQ7Pu0nx5AA5XfHEodakk9hUQt/ XeFT6yLb6QVGI2lmYsJYAppoqXB2TKqXuzU12X6FHS6TKSXYKzq3yaFXMSWT1fnrHUaWq8 kypUIAKL7dlk4fBw0yG1T+jniXWKhJg= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50493 Date: Sun, 19 Sep 2021 22:31:56 -0700 Message-ID: <86a6k7hkxf.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 50493 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 14 15:11:15 2021 Received: (at 50493) by debbugs.gnu.org; 14 Dec 2021 20:11:15 +0000 Received: from localhost ([127.0.0.1]:59699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxE8o-0006Sj-Vd for submit@debbugs.gnu.org; Tue, 14 Dec 2021 15:11:15 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:36455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxE8n-0006SU-AZ for 50493@debbugs.gnu.org; Tue, 14 Dec 2021 15:11:13 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 75AAB3201905; Tue, 14 Dec 2021 15:11:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 14 Dec 2021 15:11:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=CJG6EtoxOPnFnUucfHmUmvfl BmyG7fbK8yZvR4kDnvQ=; b=R0LAZgB7KOqR14vK0MwFeQ1Tv0QtVNBk9A89MJGE qyp39quTtGsayyHm9RjTSe4mbwYV+NZNwy1GI9WqTeLRrSWkamRte9XmZgpuezh/ MzckJaMLkmMKN6NDCZ9wAbMpTgj+qYhCqGUg1nTVKvoBWeE7Jl2qDg7CaDx64e+M 0CM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CJG6Et oxOPnFnUucfHmUmvflBmyG7fbK8yZvR4kDnvQ=; b=GPILNxq6Ux4lbcP1/ZklKU RyH0f9jfOtMhymtxzeSLEOXYYKBXYMlZnWpPCM9yuvugTbzipltkE4Fx+ugtok9W oFC927Wf93hnAEYy5+2QBaS0w3iOAZJfCo528t8L8Zm+O9u5mmNRWE3hIvA+VBqm y8WPuEFXLNT1iZZXzYlULW2WDHNz7w6Xs1y9xWZ3/poW3r5u2VUdvZJ8OB2W1OCt Vt3xSxky4t/R6D6Oow60HK4e9IjJq54HJ/fkzPoLucv35HkkskDkt7BbDpOzdHe7 +BgTqcROHcctb/4dCH5TIHRPuXPAY1LuybJdgS5YVnxih7cqpQbx5ef3UsytN2wA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledtgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfh grmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Dec 2021 15:11:06 -0500 (EST) Date: Tue, 14 Dec 2021 15:11:04 -0500 From: Leo Famulari To: Sarah Morgensen Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Alright, it's time to land these patches. I tested with a handful of packages on x86_64 and it seems fine. I can test every package before pushing. However, Go 1.17.4 doesn't build for us on aarch64. I tried building the derivation for this scheduled CI job: https://ci.guix.gnu.org/build/1952348/details /gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv And it fails the test suite due to missing libgcc (I think), or maybe something related to 'hello.exe', which seems weird: ------ $ guix build /gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv [...] --- FAIL: TestTrampolineCgo (78.58s) link_test.go:739: executable failed to run: exit status 127 /tmp/guix-build-go-1.17.4.drv-0/TestTrampolineCgo602252092/001/hello.exe: error while loading shared libraries: libgcc_s.so.1: cannot open shared object file: No such file or directory link_test.go:742: unexpected output: /tmp/guix-build-go-1.17.4.drv-0/TestTrampolineCgo602252092/001/hello.exe: error while loading shared libraries: libgcc_s.so.1: cannot open shared object file: No such file or directory FAIL FAIL cmd/link 425.553s ok cmd/link/internal/benchmark 0.449s ok cmd/link/internal/ld 84.727s ok cmd/link/internal/loader 0.366s ok cmd/nm 73.342s ok cmd/objdump 96.072s ok cmd/pack 77.197s ok cmd/pprof 155.165s ok cmd/trace 2.437s ok cmd/vet 318.126s FAIL go tool dist: Failed: exit status 1 command "sh" "run.bash" "--no-rebuild" failed with status 1 builder for `/gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv' failed with exit code 1 ------ I notice that we remove libgcc from the dependencies of go-1.17: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/golang.scm?id=b484301f529e246df80380a641822f09a8775755#n799 Anyways, any ideas? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 05:40:47 2021 Received: (at 50493) by debbugs.gnu.org; 15 Dec 2021 10:40:47 +0000 Received: from localhost ([127.0.0.1]:60329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRiJ-0000m3-5q for submit@debbugs.gnu.org; Wed, 15 Dec 2021 05:40:47 -0500 Received: from flashner.co.il ([178.62.234.194]:55002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxRiH-0000lr-KS for 50493@debbugs.gnu.org; Wed, 15 Dec 2021 05:40:46 -0500 Received: from localhost (unknown [94.230.83.253]) by flashner.co.il (Postfix) with ESMTPSA id 9A1864018B; Wed, 15 Dec 2021 10:40:39 +0000 (UTC) Date: Wed, 15 Dec 2021 12:40:07 +0200 From: Efraim Flashner To: Leo Famulari Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: Mail-Followup-To: Efraim Flashner , Leo Famulari , Sarah Morgensen , 50493@debbugs.gnu.org References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OodJCZvQTwVHrakc" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org, Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --OodJCZvQTwVHrakc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 14, 2021 at 03:11:04PM -0500, Leo Famulari wrote: > Alright, it's time to land these patches. I tested with a handful of > packages on x86_64 and it seems fine. I can test every package before > pushing. >=20 > However, Go 1.17.4 doesn't build for us on aarch64. I tried building the > derivation for this scheduled CI job: >=20 > https://ci.guix.gnu.org/build/1952348/details > /gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv The link shows problems with the armhf portion of the bootstrap. > And it fails the test suite due to missing libgcc (I think), or maybe > something related to 'hello.exe', which seems weird: >=20 > ------ > $ guix build /gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv > [...] > --- FAIL: TestTrampolineCgo (78.58s) > link_test.go:739: executable failed to run: exit status 127 > /tmp/guix-build-go-1.17.4.drv-0/TestTrampolineCgo602252092/001/he= llo.exe: error while loading shared libraries: libgcc_s.so.1: cannot open s= hared object file: No such file or directory > link_test.go:742: unexpected output: > /tmp/guix-build-go-1.17.4.drv-0/TestTrampolineCgo602252092/001/he= llo.exe: error while loading shared libraries: libgcc_s.so.1: cannot open s= hared object file: No such file or directory > FAIL > FAIL cmd/link 425.553s > ok cmd/link/internal/benchmark 0.449s > ok cmd/link/internal/ld 84.727s > ok cmd/link/internal/loader 0.366s > ok cmd/nm 73.342s > ok cmd/objdump 96.072s > ok cmd/pack 77.197s > ok cmd/pprof 155.165s > ok cmd/trace 2.437s > ok cmd/vet 318.126s > FAIL > go tool dist: Failed: exit status 1 > command "sh" "run.bash" "--no-rebuild" failed with status 1 > builder for `/gnu/store/bldlnwxjwbi1iidm6cdw20kkpgy5gk09-go-1.17.4.drv' f= ailed with exit code 1 > ------ >=20 > I notice that we remove libgcc from the dependencies of go-1.17: >=20 > https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/golang.scm?i= d=3Db484301f529e246df80380a641822f09a8775755#n799 >=20 > Anyways, any ideas? I'll try poking it a bit with my aarch64 board. We can also switch the aarch64 go builds to bootstrap from gccgo, that might make a difference too. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --OodJCZvQTwVHrakc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmG5xgcACgkQQarn3Mo9 g1FtARAAqMHgLYVqEJV+x0n3QnhCyzVBVZgXrFniiH7vuBxTuZjTBXtRReFWQlBD UvhzndxkAzEbba7zDfpnbGmRZbIZRfDrAVS5ZM539D+yBKHfrX8X5inEUZulnn4M CiSkBOLwXOmfZ8gARFAagFIMXa5mNw5ODfwVia+CrbXsc5rGOCBAWUlWNy73V39U ZriMbNnc7ueO3aFrwf17D+DyXS2/wMP7FNwjgxGULyP9UmFXKdF/U5FZzOqXGA63 Aup2aj/BIy4FGO+lnc3e1D0bYvnNxkkYbG6Dy7JfELbUJqbkPyyqSVGqqEACPoeN 0ueLJ9rwNGZTl2Hy/UWy00ACiyKPo1wRthpoLLIQxD/ZMnohtFP8ZdNbE7V862l+ R9CkqZCuGKKN46E3zS7DrZUDsVzYCvd1PynR08OfgKDMvyNopJwHnD7AGMSc/8t9 apL3jtrF6ACGr3YYhiPJuBNfDmLOX9DNUI+Ri42AawSPR1ci5xVLQhxjdUDD0bfE ir+b0G09s3+zk4QKpOTf4Nc3ymb1Ot8du8qf3GijdQhBUw+jmORiIugmjtR4l2T8 s1JHQ8ULBMIozlsaRN6JnhLarlggxMUIXmGBnR2euR5bMwUDERaLxLpX+GjXx7UJ UBKmjDwUOIie77czsagyXUkhBKZIlpkqegeJfMAWn5h/6GBS5ho= =bKOe -----END PGP SIGNATURE----- --OodJCZvQTwVHrakc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 12:44:14 2021 Received: (at 50493) by debbugs.gnu.org; 15 Dec 2021 17:44:14 +0000 Received: from localhost ([127.0.0.1]:33603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYK5-0004MP-Vw for submit@debbugs.gnu.org; Wed, 15 Dec 2021 12:44:14 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYK4-0004MD-Ea for 50493@debbugs.gnu.org; Wed, 15 Dec 2021 12:44:12 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 55EE15C0337; Wed, 15 Dec 2021 12:44:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 15 Dec 2021 12:44:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=SeSm9Ol5skfM4Q3nLZQk2JCX iiJ7jSDm4YM+E2xRjRg=; b=aAdJy/lg2AwVgCgzrLjKzsGwb2EEatkkMnvJ4a49 cRqFhYPRSxHn1Qxh4g9ZcIMYUgLI8tcaotDhmtCxTpoWkAOPY0esibXTBqp4So5f 1b3DzqhaHnXkwf/Ubx3Y3HSTfWLNrX/gdzdf9hFTFiYg8IEFxwuwGW/o5ihyjsm4 /EA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SeSm9O l5skfM4Q3nLZQk2JCXiiJ7jSDm4YM+E2xRjRg=; b=JO90vhrBAgS3xHZb02+dg5 metKAJZLxtospH0lEnlJ5h0LTWfYSwpisyJfYUMZ3cg9H190gIZsi/glnUjmc8Nq dt2+MKf4pxTwFc3r9GugzhuMj/qewZjIA/e9o6yC/F92hatY4OtegA3i/2YNWeQs oB15CCzEmceDtaP7hLR6ZaqB9/uqBFGHHDerXiOD+4qHkSNbv45umrdM/PGXzZBA lM3mn3AgXFhFmlJ8HlOiAaHRc91escWcf1OxskswnihebborLMLHHLIHAGoOF3KG VXxlZGh24nyXXlskJ4lhWHrw/eEV+VTt2ZvN1rJU8uCO7+JWSv18nnCPgXkkMIlQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledvgddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Dec 2021 12:44:06 -0500 (EST) Date: Wed, 15 Dec 2021 12:44:05 -0500 From: Leo Famulari To: Efraim Flashner , Sarah Morgensen , 50493@debbugs.gnu.org Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FC5R3WHJ1ykNPB/9" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --FC5R3WHJ1ykNPB/9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 15, 2021 at 12:40:07PM +0200, Efraim Flashner wrote: > I'll try poking it a bit with my aarch64 board. We can also switch the > aarch64 go builds to bootstrap from gccgo, that might make a difference > too. Thanks, let us know how it goes. I tried building go-1.17.4 for aarch64 with libgcc as an input, but it failed in another way. So any progress you can make would be helpful. --FC5R3WHJ1ykNPB/9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmG6KWUACgkQJkb6MLrK fwh17w//ciGmVkH4vTGwAXmEn+zgrRXWO+AHgO++9jHgEdCnaYjCGuMfKl4c7sQw ohl6zBQADqtBGQJA03F6S1gNpwcI4llmjddDRfN4y3fRXuaulc6nWKdM75Fz6QqM iD/59HV+Zd/h5ZZluZ0IZM31Z6fFpq4e/73RAZXqp/qyaN9qGrTkxisvs5CPBkjF OXZJzbHqj7IrHtc1EGlsYdjA/8xOm8ZO3Yee6oWhhl7po4M4Kua4aa0YerpWgkHw AUL38D/B0R+mBH33HMnQFth1T2zCvHUgyMx49HN5XD9DNU7ZCmjt6rump7kXZrGi bh8a7ynJA62lKWabg9AOsGBTwd4uBfsX4R3eO3Y79c1Cu/mP8jFMb6n6wKi4m6XC gW0VdQhVXIqDzvPdxQ5CUkR2vJJGe1pczs/H5/ldcaFNBx7J/gZxvvbeBJkoJc90 n2D5zyc8PkZqYju/ZAVWsqismhGDaHV716FgySo2oTIJXJszs2f+B2wsyvcfvjc8 fxIbYF1/CeLz7nPnvCnweis4fh16OrCVA8fqDvAUVokFLB459r1EqnKx+mnwgsyK AqEK2YVP1x/Ig/C9UnQy3GsOhRg70dTN30lm6qKl5Ckay7c6foGnIumu5CYvX0cJ 2nDrL8stHsHa27VSdf4sMjhMuE9lGCmDPsUObbwOzP2H2WMLjas= =mx1K -----END PGP SIGNATURE----- --FC5R3WHJ1ykNPB/9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 15 13:04:17 2021 Received: (at 50493) by debbugs.gnu.org; 15 Dec 2021 18:04:17 +0000 Received: from localhost ([127.0.0.1]:33636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYdV-0004tj-HD for submit@debbugs.gnu.org; Wed, 15 Dec 2021 13:04:17 -0500 Received: from flashner.co.il ([178.62.234.194]:33186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxYdU-0004tX-4H for 50493@debbugs.gnu.org; Wed, 15 Dec 2021 13:04:16 -0500 Received: from localhost (unknown [94.230.83.253]) by flashner.co.il (Postfix) with ESMTPSA id 5B9A94022E; Wed, 15 Dec 2021 18:04:09 +0000 (UTC) Date: Wed, 15 Dec 2021 20:03:32 +0200 From: Efraim Flashner To: Leo Famulari Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: Mail-Followup-To: Efraim Flashner , Leo Famulari , Sarah Morgensen , 50493@debbugs.gnu.org References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ziAr5NZol2VJQk/U" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org, Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ziAr5NZol2VJQk/U Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 15, 2021 at 12:44:05PM -0500, Leo Famulari wrote: > On Wed, Dec 15, 2021 at 12:40:07PM +0200, Efraim Flashner wrote: > > I'll try poking it a bit with my aarch64 board. We can also switch the > > aarch64 go builds to bootstrap from gccgo, that might make a difference > > too. >=20 > Thanks, let us know how it goes. >=20 > I tried building go-1.17.4 for aarch64 with libgcc as an input, but it > failed in another way. So any progress you can make would be helpful. I got pretty far commenting out binutils-gold and adding back in gcc:lib and the substitute snippets. Then I started failing tests requiring the linker, so it looks like I'll actually have to troubleshoot binutils-gold. I thought about trying gccgo in place of go-1.4 for the bootstrap, but I'm pretty sure I'd still need binutils-gold. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ziAr5NZol2VJQk/U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmG6LfAACgkQQarn3Mo9 g1H2hBAAk/CLa8UUlPwrAJWFy269nxYOJ6Ok7EufxhWsMDIBEd9EYV27Z+Qe+SAz c4af4SEbQXsOKD38E81Qwwu4w1eVgIZgTslait+akWEFYjUi3P1KDb+XYHA6ktQg Nfw33FD3vkbIQBIn9a8K0BfYk84vXKzcQklvfdMr0lNpHv0SHakGZLxozS3KMjDD sL2IFOXdiwn6Gu9QmztSnMStW42xj7vO8UzF2pDhtyWnTjXLmigxZRR/6QgppLXv yQIo60rtWS5Et0YHiS6pFI433ygNNEYO/+G7BHcB06KyMup/xBljdNXqstUA+0rg IafqqvAeLiomMic9r7sYbyDdmTDIOmRvS0LPUS7KdS5wuZ4LhfMuQDTbO5cylIAP Z/JXT5es2GbC5sfinZnyMx1/AI+09p5e8f+b385KrT2INsO37sr3vqjPyycc5yTw pQPeKeinadJAjKMCjx1GNJLgBvG2B/R2CgS069+mL6wSoHHV0tg0idtUE2eFleCE ApsbFc/IZtOi9TurjWLOywWzI8MBlpoJLM6G9fd+6dg2M0Q9ZbQkl/5HdGDmU9xY g14xw6GpUuTv+YbTiSB3Lx8xfMGU4oHiblHnNhK85nUF8rj03XAm6/KRp5dpVrPF MtiEV+fxTlj2kzIXGUzxBw5VQYCtJivm/krIS04flh+dZ+L2fF0= =TvIw -----END PGP SIGNATURE----- --ziAr5NZol2VJQk/U-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 17 17:09:13 2021 Received: (at 50493) by debbugs.gnu.org; 17 Dec 2021 22:09:13 +0000 Received: from localhost ([127.0.0.1]:40796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLPd-0002Bs-2M for submit@debbugs.gnu.org; Fri, 17 Dec 2021 17:09:13 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myLPa-0002BX-I1 for 50493@debbugs.gnu.org; Fri, 17 Dec 2021 17:09:11 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1DF265C023A; Fri, 17 Dec 2021 17:09:04 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 17 Dec 2021 17:09:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=n6FKi6/Xz1HYdxXwS51CaGNQ gimeePFKl33UmwPhDmM=; b=b10r19W0aL8xbwyqEWXV4ievff+6DFpQuu4Wjgqm R7sCsCzP/7eW9YgJlRO5jajbg+1b3LVQmY1KcstlQxQu3/uSBMXOffShgbtyIW1+ qeFBKpUPHtQa+liT+qFuw6HC52FFxP2WVHtgSI6WvsqjJKOMKBRDUhFFlbgbv56n S4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=n6FKi6 /Xz1HYdxXwS51CaGNQgimeePFKl33UmwPhDmM=; b=deJmaEHxrojO+AaTUe8A6P sgdRIGtsrSSqzGRDlRrgA0xTfFOZQjBHUC5Tqn0O1ON+9hN01wmWhDGUvH7PCBe/ X+aQsg9Oa8M5eGB1eDTugzb2mpMhyAYtYTdix9/AsTKxURdxsUVeX9KeuI/badNk pbT+Hc5DbkVJkR7OTLfWGDPAB5Uh/+JFFMsj1go7qpuGlEQ6qzSEKo0996ubV4Dz RUBJi1uTAY6QvajU64E176ldZ7cckRrq0BVw85upbJFV17/8/zVUlArp4MCURfA4 XMo5leqongxIRRPWB4GGJd+kwLhvlxgwawJGbjFc92yAnAAxT2ZCIKrwB+xDtsYQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrleeigdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Dec 2021 17:09:03 -0500 (EST) Date: Fri, 17 Dec 2021 17:09:01 -0500 From: Leo Famulari To: Efraim Flashner , Sarah Morgensen , 50493@debbugs.gnu.org Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Dec 15, 2021 at 08:03:32PM +0200, Efraim Flashner wrote: > I got pretty far commenting out binutils-gold and adding back in gcc:lib > and the substitute snippets. Then I started failing tests requiring the > linker, so it looks like I'll actually have to troubleshoot > binutils-gold. > > I thought about trying gccgo in place of go-1.4 for the bootstrap, but > I'm pretty sure I'd still need binutils-gold. Maybe, in the meantime, we could update go-build-system to use go-1.16, which does at least build on aarch64. This Go release is still supported, at least for a little while longer. It would be nice to not be using Go 1.14 by default in the upcoming release. What do people think about that idea? From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 03:19:48 2021 Received: (at 50493) by debbugs.gnu.org; 19 Dec 2021 08:19:48 +0000 Received: from localhost ([127.0.0.1]:44766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myrQ4-0007e4-3E for submit@debbugs.gnu.org; Sun, 19 Dec 2021 03:19:48 -0500 Received: from flashner.co.il ([178.62.234.194]:49308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myrQ2-0007dq-Na for 50493@debbugs.gnu.org; Sun, 19 Dec 2021 03:19:47 -0500 Received: from localhost (unknown [141.226.169.99]) by flashner.co.il (Postfix) with ESMTPSA id 3C59C4004A; Sun, 19 Dec 2021 08:19:40 +0000 (UTC) Date: Sun, 19 Dec 2021 10:19:02 +0200 From: Efraim Flashner To: Leo Famulari Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: Mail-Followup-To: Efraim Flashner , Leo Famulari , Sarah Morgensen , 50493@debbugs.gnu.org References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KLL/NymohbJ+sQ4g" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50493 Cc: 50493@debbugs.gnu.org, Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --KLL/NymohbJ+sQ4g Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 17, 2021 at 05:09:01PM -0500, Leo Famulari wrote: > On Wed, Dec 15, 2021 at 08:03:32PM +0200, Efraim Flashner wrote: > > I got pretty far commenting out binutils-gold and adding back in gcc:lib > > and the substitute snippets. Then I started failing tests requiring the > > linker, so it looks like I'll actually have to troubleshoot > > binutils-gold. > >=20 > > I thought about trying gccgo in place of go-1.4 for the bootstrap, but > > I'm pretty sure I'd still need binutils-gold. >=20 > Maybe, in the meantime, we could update go-build-system to use go-1.16, > which does at least build on aarch64. This Go release is still > supported, at least for a little while longer. >=20 > It would be nice to not be using Go 1.14 by default in the upcoming > release. >=20 > What do people think about that idea? All of go is blocked on aarch64 with binutils-gold not compiling. I have a patch locally to add gcc:lib for (target-arm?) to go-1.17 which I'll push after testing with binutils-gold. I think going straight to 1.17 is fine, there's no regression against the current support for aarch64. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --KLL/NymohbJ+sQ4g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmG+6vMACgkQQarn3Mo9 g1HJiQ//blUr5ypEIIZr6b7bS+8iFVOm1jec/j727KMB4ff7gudEiC0YEhEPFSJ1 9lc/zUCkpo0ULotPpCBi37kE6eampQinuYjLR/hsQ2wv8cUF1pXKOz7Vb6+//Qun 3m1HIJpq2OEuAvPd13Qa9mtOZENBF9hD5dQcBdefjeT44sgR3YVB37jv5HjR6ALb 9a4blt+UAvRrUpsHP/fHejKSNp4Vgnkb3lTRKELM3Dy+HxzbYSj58PprtdPT4WsB MnpiRh7Knlbi5zlABmMv8z2bn48dG+NcRaSa7i1pLFl62LNfz2m3t4LLpFM7GoD/ KofTJ4pM37ltXz6zxDrGf2vTqagzGDWTFsnMpiKKn441aIC3somx0bRqPr4qXAq5 3yZTD6K0wbx1JRGGIjgvxE0cPTjkmvZhlKx/2HD2HCEAhZdU+QiHTHfd/qNyNmIe sk35BegvsriqdC2aOYXC+LLDRRXb+3R/r7pBhToc60GVgSAbY8dt3o+mDjqEU4kb KQ/qeLxai04LeqhBVxTke7cqByEEb9Y4NyJxLLyn32b0bGtNlZNLPYEK4spOUY1c ng52uipN7sOUeYnP3h6sPaawzBDJzSYKThiCt5m1Se4uQEodey0aXzmHStAUW0a6 uv0HafskS5HnJHO1z7ufzu3Nkwb4nGo7NTOsmsytcJPooOwWoxA= =wxIl -----END PGP SIGNATURE----- --KLL/NymohbJ+sQ4g-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 20:30:39 2021 Received: (at 50493) by debbugs.gnu.org; 20 Dec 2021 01:30:39 +0000 Received: from localhost ([127.0.0.1]:48553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz7VZ-0007CI-43 for submit@debbugs.gnu.org; Sun, 19 Dec 2021 20:30:39 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:48933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz7VT-0007C2-Hr for 50493@debbugs.gnu.org; Sun, 19 Dec 2021 20:30:32 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id DF9383200A5F; Sun, 19 Dec 2021 20:30:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 19 Dec 2021 20:30:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=YDROeNeytcn+iPn7XpqPz7Dy IblodJvLDegmQ5ZOvIc=; b=Fz3cAIIFBKbW9JKxOu745c6xjCnw2KpWV+KGiUFx Qw6Qtr+5FlXUOgyX1JexNrOY8q46wVKanZBanO/2WYeZHxmbR7Wsdd2d7RDgnahO vvIJqUgU1F+ySWVO/Zbqx1iNPkVsTgZ03FumeNUIzLy9puznQLVaNDLhnd1RpsAa hY8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YDROeN eytcn+iPn7XpqPz7DyIblodJvLDegmQ5ZOvIc=; b=DuuDPQVC4JN+o9ZqnTEa4d ifHRYQthWE0YvHidPhI5cFtQEDwWqQVlhmYiNl1e8q0Q4345jKx5bC5Sj2dfDKi3 YGOOAeC+H9iWEu+xxuBVySEJoqitjNNsCdcGTVpEKGUIi7UKRsuVgU9Zqq0mEu5l k6Vn/1vE2bW7hRpQoUecat/7cPY7SOMmJLbd42bzwGTcrpmF8PH16/ipqDzx0SwA jmRjp5Cvl4v+CCGdaSy5L++/dpktudi77UUwZIHjk3xROgvyUitNh2fvn92OHoru JW/xLl9NZlO2RDygfqzndNAFAabVdzFpG4AE/zn3aD/YElMy268znRRuwk5t7Jwg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtuddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Dec 2021 20:30:19 -0500 (EST) Date: Sun, 19 Dec 2021 20:30:18 -0500 From: Leo Famulari To: Efraim Flashner , Sarah Morgensen , 50493@debbugs.gnu.org Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gpV3NMKFTru/XBzk" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --gpV3NMKFTru/XBzk Content-Type: multipart/mixed; boundary="MDsJqkBh4GPaKhdB" Content-Disposition: inline --MDsJqkBh4GPaKhdB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 19, 2021 at 10:19:02AM +0200, Efraim Flashner wrote: > All of go is blocked on aarch64 with binutils-gold not compiling. I have > a patch locally to add gcc:lib for (target-arm?) to go-1.17 which I'll > push after testing with binutils-gold. I think going straight to 1.17 is > fine, there's no regression against the current support for aarch64. Oh, good point. Based on the attached patches (rebased / adjusted for current master), I'll proceed with testing the build of all Go packages on x86_64-linux. --MDsJqkBh4GPaKhdB Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-build-system-go-Add-substitutable-argument.patch" Content-Transfer-Encoding: quoted-printable =46rom f26d2b8b30867d23a417af2c40ba8062adb87bd7 Mon Sep 17 00:00:00 2001 =46rom: Sarah Morgensen Date: Mon, 13 Dec 2021 20:11:47 -0500 Subject: [PATCH 1/4] build-system/go: Add #:substitutable? argument. * guix/build-system/go.scm (go-build): Add 'substitutable?' argument. (go-cross-build): Likewise. Signed-off-by: Leo Famulari --- guix/build-system/go.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index 18824c79d9..0b2bf1c11b 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -172,7 +172,8 @@ (define* (go-build name inputs (imported-modules %go-build-system-modules) (modules '((guix build go-build-system) (guix build union) - (guix build utils)))) + (guix build utils))) + (substitutable? #t)) (define builder (with-imported-modules imported-modules #~(begin @@ -182,6 +183,7 @@ (define builder #:system #$system #:phases #$phases #:outputs #$(outputs->gexp outputs) + #:substitutable? #$substitutable? #:goarch #$goarch #:goos #$goos #:search-paths '#$(sexp->gexp @@ -222,7 +224,8 @@ (define* (go-cross-build name (imported-modules %go-build-system-modules) (modules '((guix build go-build-system) (guix build union) - (guix build utils)))) + (guix build utils))) + (substitutable? #t)) "Cross-build NAME using GO, where TARGET is a GNU triplet and with INPUT= S." (define builder #~(begin base-commit: 99f290bf5ba59e3218b95d7505ac27f989250aad --=20 2.34.0 --MDsJqkBh4GPaKhdB Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0002-build-system-go-Initialize-build-cache-from-input-pa.patch" Content-Transfer-Encoding: quoted-printable =46rom a437f30bfaa4965cb42acb37f387e2c8106c7884 Mon Sep 17 00:00:00 2001 =46rom: Sarah Morgensen Date: Sun, 19 Sep 2021 22:20:49 -0700 Subject: [PATCH 2/4] build-system/go: Initialize build cache from input packages. * guix/build/go-build-system.com (setup-go-environment): Set GOCACHE to a location within the build directory. Union "/var/cache/go/build" input directories to initialize the cache. Generate "trim.txt" within the cache, with the current time. Signed-off-by: Leo Famulari --- guix/build/go-build-system.scm | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/guix/build/go-build-system.scm b/guix/build/go-build-system.scm index 4768ee8562..7f25e05d0d 100644 --- a/guix/build/go-build-system.scm +++ b/guix/build/go-build-system.scm @@ -5,6 +5,7 @@ ;;; Copyright =C2=A9 2020 Jack Hill ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka ;;; Copyright =C2=A9 2020, 2021 Efraim Flashner +;;; Copyright =C2=A9 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -138,9 +139,28 @@ (define* (setup-go-environment #:key inputs outputs go= os goarch #:allow-other-ke where executables (\"commands\") are installed to. This phase is sometime= s used by packages that use (guix build-system gnu) but have a handful of Go dependencies, so it should be self-contained." - ;; The Go cache is required starting in Go 1.12. We don't actually use = it but - ;; we need it to be a writable directory. - (setenv "GOCACHE" "/tmp/go-cache") + (define (search-input-directories dir) + (filter directory-exists? + (map (match-lambda + ((name . directory) + (string-append directory "/" dir))) + inputs))) + + ;; Seed the Go build cache with the build caches from input packages. + (let ((cache (string-append (getcwd) "/go-build"))) + (setenv "GOCACHE" cache) + (union-build cache + (search-input-directories "/var/cache/go/build") + ;; Creating all directories isn't that bad, because there= are + ;; only ever 256 of them. + #:create-all-directories? #t + #:log-port (%make-void-port "w")) + + ;; Tell Go that the cache was recently trimmed, so it doesn't try to. + (call-with-output-file (string-append cache "/trim.txt") + (lambda (port) + (format port "~a" (current-time))))) + ;; Using the current working directory as GOPATH makes it easier for pac= kagers ;; who need to manipulate the unpacked source code. (setenv "GOPATH" (getcwd)) --=20 2.34.0 --MDsJqkBh4GPaKhdB Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0003-build-system-go-Add-pre-built-standard-library-as-im.patch" Content-Transfer-Encoding: quoted-printable =46rom cddf7d95c9134075aec45e2f2e49073f92aadfcb Mon Sep 17 00:00:00 2001 =46rom: Sarah Morgensen Date: Sun, 19 Sep 2021 22:20:50 -0700 Subject: [PATCH 3/4] build-system/go: Add pre-built standard library as implicit input. * gnu/packages/golang.scm (make-go-std): New procedure. * guix/build-system/go.scm (make-go-std): New procedure. (lower): Use it. Add pre-built standard library to inputs. Signed-off-by: Leo Famulari --- gnu/packages/golang.scm | 30 ++++++++++++++++++++++++++++++ guix/build-system/go.scm | 16 ++++++++++++++-- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index c863388475..7989a3a138 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -806,6 +806,36 @@ (define-public go-1.17 =20 (define-public go go-1.14) =20 +(define-public (make-go-std go) + "Return a package which builds the standard library for Go compiler GO." + (package + (name (string-append (package-name go) "-std")) + (version (package-version go)) + (source #f) + (build-system go-build-system) + (arguments + `(#:import-path "std" + #:build-flags `("-pkgdir" "pkg") ; "Install" to build directory. + #:allow-go-reference? #t + #:substitutable? #f ; Faster to build than download. + #:tests? #f ; Already tested in the main Go build. + #:go ,go + #:phases + (modify-phases %standard-phases + (delete 'unpack) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (out-cache (string-append out "/var/cache/go/build"))) + (copy-recursively (getenv "GOCACHE") out-cache) + (delete-file (string-append out-cache "/trim.txt")) + (delete-file (string-append out-cache "/README"))))) + (delete 'install-license-files)))) + (home-page (package-home-page go)) + (synopsis "Cached standard library build for Go") + (description (package-description go)) + (license (package-license go)))) + (define-public go-0xacab-org-leap-shapeshifter (let ((commit "0aa6226582efb8e563540ec1d3c5cfcd19200474") (revision "12")) diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index 0b2bf1c11b..09148f8730 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2020 Jakub K=C4=85dzio=C5=82ka ;;; Copyright =C2=A9 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2021 Efraim Flashner +;;; Copyright =C2=A9 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -112,6 +113,9 @@ (define (default-go) (let ((go (resolve-interface '(gnu packages golang)))) (module-ref go 'go))) =20 +(define (make-go-std) + (module-ref (resolve-interface '(gnu packages golang)) 'make-go-std)) + (define* (lower name #:key source inputs native-inputs outputs system target (go (default-go)) @@ -121,6 +125,14 @@ (define* (lower name (define private-keywords '(#:target #:go #:inputs #:native-inputs)) =20 + (define inputs-with-cache + ;; XXX: Avoid a circular dependency. This should be rewritten with + ;; 'package-mapping' or similar. + (let ((go-std-name (string-append (package-name go) "-std"))) + (if (string-prefix? go-std-name name) + inputs + (cons `(,go-std-name ,((make-go-std) go)) inputs)))) + (bag (name name) (system system) @@ -130,7 +142,7 @@ (define private-keywords '()) ,@`(("go" ,go)) ,@native-inputs - ,@(if target '() inputs) + ,@(if target '() inputs-with-cache) ,@(if target ;; Use the standard cross inputs of ;; 'gnu-build-system'. @@ -138,7 +150,7 @@ (define private-keywords '()) ;; Keep the standard inputs of 'gnu-build-system'. ,@(standard-packages))) - (host-inputs (if target inputs '())) + (host-inputs (if target inputs-with-cache '())) =20 ;; The cross-libc is really a target package, but for bootstrapping ;; reasons, we can't put it in 'host-inputs'. Namely, 'cross-gcc' is a --=20 2.34.0 --MDsJqkBh4GPaKhdB Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0004-build-system-go-Use-go-1.17-by-default.patch" Content-Transfer-Encoding: quoted-printable =46rom 6f9d52c1117279be567e2ee9f56f88e470867e92 Mon Sep 17 00:00:00 2001 =46rom: Sarah Morgensen Date: Sun, 19 Sep 2021 22:20:51 -0700 Subject: [PATCH 4/4] build-system/go: Use go-1.17 by default. Build all Go packages with go-1.17 by default. Explicitly specify an older Go version in packages which cannot build with go-1.17. * gnu/packages/golang.scm (go): Update from 'go-1.14' to 'go-1.17'. * gnu/packages/docker.scm (docker)[native-inputs]: Explicitly use 'go-1.14'. * gnu/packages/ipfs.scm (go-github-com-ipfs-go-ipfs-cmdkit-files)[arguments= ]: Set #:go to 'go-1.16'. Signed-off-by: Leo Famulari --- gnu/packages/docker.scm | 2 +- gnu/packages/golang.scm | 2 +- gnu/packages/ipfs.scm | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/packages/docker.scm b/gnu/packages/docker.scm index cdf62f5e9a..d012ed43c6 100644 --- a/gnu/packages/docker.scm +++ b/gnu/packages/docker.scm @@ -585,7 +585,7 @@ (define-public docker ("xz" ,xz))) (native-inputs (list eudev ; TODO: Should be propagated by lvm2 (.pc -> .pc) - go gotestsum pkg-config)) + go-1.14 gotestsum pkg-config)) (synopsis "Docker container component library, and daemon") (description "This package provides a framework to assemble specialized container systems. It includes components for orchestration, image diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index 7989a3a138..1ac6c81900 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -804,7 +804,7 @@ (define-public go-1.17 (alist-replace "go" (list go-1.16) (package-native-inputs go-1.= 16)) (package-native-inputs go-1.16)))))) =20 -(define-public go go-1.14) +(define-public go go-1.17) =20 (define-public (make-go-std go) "Return a package which builds the standard library for Go compiler GO." diff --git a/gnu/packages/ipfs.scm b/gnu/packages/ipfs.scm index f566b850aa..b567b23353 100644 --- a/gnu/packages/ipfs.scm +++ b/gnu/packages/ipfs.scm @@ -48,7 +48,8 @@ (define-public go-github-com-ipfs-go-ipfs-cmdkit-files "0qk6fshgdmhp8dip2ksm13j6nywi41m9mn0czkvmw6b697z85l2r")))) (build-system go-build-system) (arguments - '(#:unpack-path "github.com/ipfs/go-ipfs-cmdkit" + `(#:go ,go-1.16 + #:unpack-path "github.com/ipfs/go-ipfs-cmdkit" #:import-path "github.com/ipfs/go-ipfs-cmdkit/files")) (home-page "https://github.com/ipfs/go-ipfs-cmdkit") (synopsis "Shared types, functions and values for go-ipfs") --=20 2.34.0 --MDsJqkBh4GPaKhdB-- --gpV3NMKFTru/XBzk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmG/3KkACgkQJkb6MLrK fwjtXQ/9FIi/NrdS5jiGvBKJsyiHeOAE4Bsfdb0b6LOXK73T9s89W3IIsrLmDtmS fSfMSX6xwyZOy5gyWYQwudyYHYWY9PORc9BkXjkHMqGT1jiHo0svjSQ8UEnCDlff vkA2nb+L6TMiQ8WWPZshaSAWgj0/tVAo0oo/5L0zsP8VuNewtZNO2jQRN2zEi/G8 RS/STXDWyyEldQikNAeHuiy8QzPFAYV7V8/8yfPMoClgWtM8rXFEz2HfcBFFAisN rYnteR98m+pQxgMqbV4iWsSSzDybiHKpMBvdC8Wdgi0VH2KP0k/6v9mgeu+glLxV vbCj1A3lU/qHfgeV+JFk7F7XyxZRL9HJa+50S6uqPnyK2OLwsAHiFHKubSOYI3Nx KwVtKXmvcHIat7V3ywiZrDTYvzw5ceHo814zgkT1vCVtEufPWIGQIIRdG6HS4u0f rfCEClANFIfRc8KfqlsLAIYCiWO2N8CmLmtrbtcqubKa0zXH8MhEiFYtX62pD5rw tPXpbKpk1FSeqtT+u/9Bi22x7V0+mPDn5cyx4LLCAxjfdWarJZP1vkDLOkEGPhWj O+tGxm8tDCc1x2SwTWgYFRgp00+OYIxA43uzh5Q1WMuTvoHgMmqqov0fKNkdRSAt wCuyFAeba7K2Mq9r+DgYE1ppt0TaoItIIP+YHa3J4ry0sCcv0EA= =SVRu -----END PGP SIGNATURE----- --gpV3NMKFTru/XBzk-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 19 21:32:01 2021 Received: (at 50493) by debbugs.gnu.org; 20 Dec 2021 02:32:01 +0000 Received: from localhost ([127.0.0.1]:48584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz8T3-0000Dw-Ae for submit@debbugs.gnu.org; Sun, 19 Dec 2021 21:32:01 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:41059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz8T1-0000Di-4Z for 50493@debbugs.gnu.org; Sun, 19 Dec 2021 21:31:59 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7DC433200564; Sun, 19 Dec 2021 21:31:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 19 Dec 2021 21:31:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=nJ0KgMLpKThTplzN32Zcfx3j w2DL16I9IFzISL+uD7E=; b=BUCCEU8wIC8WCoU+P2H7uFCbBkVgYr7dQ7+yB8bE 7CAhzIOa3e426UJHBUtbWjdkJP1P4tSsgWSEcLZgOkSxlgtr5Quyku+tTRl/kIuL Tj5W4mhXEHh7Bd5x6K3GaT7VejJzlmrxLwsSWg6kd8uyUIOLKIqj8fBe+WI0tfIE heQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nJ0KgM LpKThTplzN32Zcfx3jw2DL16I9IFzISL+uD7E=; b=JbU1n+y3H+XcJmZ0Mq8boK ZLBVm30sBCXlW3BNqZ+bFxHqpY1OFjhxDfoXJy+/3Rg8FZMi0hQZ/8MGTWEccg7P 3EA4mJiLZfnk/JfYX4XwwHYdwTwMNKY15TzdUyRvXvkDGdTwudHt6A/4xuLUOoJi 9BcIQWwcVIoq8vRbmuaC985UMsOQgqEiKBbHTwDioLKlHFNJCYgjFf4FFJY+GS40 qwsEfcY3yyk1N7Od12bQW88xlWJ4itwEkl8ideNqIPAk4VWCfYYhPFkOTXpz1wCs chDQBEzBPawulqUe3+BB7RlqhnXabM+qvwu78bOsJMu/Pds/TDvEUJVJ/9mzULQA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddtuddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff teenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg hosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Dec 2021 21:31:51 -0500 (EST) Date: Sun, 19 Dec 2021 21:31:46 -0500 From: Leo Famulari To: Efraim Flashner , Sarah Morgensen , 50493@debbugs.gnu.org Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cb7raHd3jZU5AjB7" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Cb7raHd3jZU5AjB7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 19, 2021 at 08:30:18PM -0500, Leo Famulari wrote: > Based on the attached patches (rebased / adjusted for current master), > I'll proceed with testing the build of all Go packages on x86_64-linux. Well, Go builds are very fast. There are no new failures of packages using go-build-system with these patches, assuming I accurately collected all of them. So, I invite people to apply these patches and try *using* their favorite Go programs, and hopefully we can push these patches in the coming days. --Cb7raHd3jZU5AjB7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmG/6xIACgkQJkb6MLrK fwii3g//X7qr1F2bBG3UV2lwY9GO/eDjaY4/vM2FBvpfrByPM0/w3TgJ/jMbSCuu QPH0bGrky+FyoDGMNeUfb5tdOTYedCjYQWS/BifWgLfwR0i24EYrwsAd/hIrUBY2 A45/Hg92mPUPLNMlcaXGsHqadQnagudjzCccj6PBMgV1v8LjZ4IKSPLCoUUpxqrj AiPK4umytbu+fFP02zUvNv/W5oMdc9dciP8fSITeptpQJYYKz3E6i2/rpTQatM24 zOEy2hQdImIhkkGwulQOcPQVvGgQNeHzucQA40gY5ejiJBBNvtKQoWF1TP6VLSX3 76r2pPwUL0z1f1okwyazQnakuYqQq2UyyYimHzOARghQBojOUjnNQDPAxz9auduQ Y3tRhhE+G4+4Sw/Mhd1K+Gg9UTj3xvWiy/CuqN3eCXAPivdq2e68vX1d6npS22aU hX76t1vIdB5xylsdTqG/a4Fy+HRLEy3cqSNRzMyQiwpwG2XAlCGpTiNVMQZYz38u 3kjiR0xQcQ4T7+q5ZCjwzAW0aCjCDbvxvJZO+abLC2zbchQQR/VYI1xfUfuTlvzU iMBAHqPZ+a/3HH69JHBYNYra9N+gSaIaxFSulVswkjnxQYAjSrCDYQnxQOqePZUs CqSvTWMUfy+KcwuY4vc5Omxvq2/FhNuEussht622j5NbqxQwptM= =hpxH -----END PGP SIGNATURE----- --Cb7raHd3jZU5AjB7-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 24 16:35:12 2021 Received: (at 50493-done) by debbugs.gnu.org; 24 Dec 2021 21:35:13 +0000 Received: from localhost ([127.0.0.1]:38195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0sDY-0002rH-NQ for submit@debbugs.gnu.org; Fri, 24 Dec 2021 16:35:12 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:57555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0sDV-0002qv-Oj for 50493-done@debbugs.gnu.org; Fri, 24 Dec 2021 16:35:11 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 558133200A3E; Fri, 24 Dec 2021 16:35:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 24 Dec 2021 16:35:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=8f3spw2K1fJIMdOSipGR084F Yubrk84LSg3z1U3BpmQ=; b=S97WI31UjRrL37QgDQ/NxeZRXDl0P9Z7fPISK+tI ITDPAy7bATPLEg0MxsC3hV1aD8sGrYaM0kXtsh1udsppnH+fqZBlVyE6wWVXro3x Lov09EqWSOHBN2Ni1wyiej0zwbCJYNq8SLp3+VH5Ve09cMtS+LoOPmtLEIIzn4em olI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8f3spw 2K1fJIMdOSipGR084FYubrk84LSg3z1U3BpmQ=; b=HcqN6OW62AeiJl9rNzUdAn q17njP6i4rrQxO6SrsUOnSDZLHcYscxvIRVuo6YJe4ki8ZIlczWUVqL6x8jES1lO I4jwRYewbH/PxL7K2hIN1IYblwEpNKh/SzB/9aRCN8CpXpg3Qrvl5ErKaGvPwRtJ TD+Yopt8CdWerAQpQo+tkQzdNewlGu3npaVGPUi6xKWIj+GPk4hFCpKWdiaoeufH ZhE5KbRCPUm42/UvIMuyFVP7ow2BgAHpxPPbNAQz52mI+ZtaPyaHXPaNSl3uCXWL epnKPVHAOOyzH0IWJhLSUzSOE4bwv4pSnRUK586i9JJ7fH602VSHIoMGhX273LPg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddruddutddgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudekveegteekleetgfeitdejgfejkeffudethedvhfeukeduleeikeejfeeh ffetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Dec 2021 16:35:02 -0500 (EST) Date: Fri, 24 Dec 2021 16:35:00 -0500 From: Leo Famulari To: Efraim Flashner , Sarah Morgensen , 50493-done@debbugs.gnu.org Subject: Re: bug#50493: Update go-build-system to use Go 1.17. Message-ID: References: <865yv9mm5a.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uZy6sFVFyh15kL8N" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50493-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --uZy6sFVFyh15kL8N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Dec 19, 2021 at 09:31:46PM -0500, Leo Famulari wrote: > So, I invite people to apply these patches and try *using* their > favorite Go programs, and hopefully we can push these patches in the > coming days. Pushed as 717be95339c953f53a22b9d98378c76025263737 --uZy6sFVFyh15kL8N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmHGPQQACgkQJkb6MLrK fwh8cRAAopYlh3o90zaKrErgbGP43F+e67gEon+jKIf+YNN/V7ZiJXatdsLHdzRu d3LpLStuhP4o6DzJvLT7NupyWTGEcscKmn6cmur0Hid0ZP7waHixnc/6JjOkBNmW ZlNaWBmbwz/fz/vjmR2ZbiEmd2rONOahwIeHM3yLN4UBltDnWgLh6b8FM/Qy2Euy J0ZzoHVRI/64s7IyRGZvtETYmS65n/W7osfQc1IDNf6RSp+UDsQcCr0ZmQ600EEb tWtJ/VGHwrL5p/eyq1x0deA8QRV1dH87YkOvCdNZZFlxwgB5wFRQzzTfZS9+KONk XLmbje/1eGBBdnRkNgQfaVwYkB+z9iZ0O3AaFdGTjotCQhZD4jEwF59Rp5AJRr9M awZ0MxREwo0HSaINbgxALd4ZJrAwxTMJ/2uubJXjMIA7tIyovIaJzrfaqTW+PGxm 2yPTYmmyyiLFved2B/4Z0aw8cXjECZhRFzZkSggILB3p6TAEVv+ElT5e05ehUIqM Ksi6GHt2ASLmulrpC6MdmKs3WoFhh3ftdbCMS7g6HToeEzPQtz5GSux6vNRjhNDx 7wj0m+yUKIqHd1wNM9Pj7p9UypmpP4rCf6w+DWpaP0HMgHa0mb1db4EdP48cCMUC DsI8lvvxaX5fn+r6V/RqYPG5vBNqVFD3ZhFWuUOJeudpvExeS6Y= =NHSK -----END PGP SIGNATURE----- --uZy6sFVFyh15kL8N-- From unknown Sat Sep 06 09:27:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Jan 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator