Subject: Re: bug#50490: [PATCH 0/5] Some julia packages

From: zimoun <[email-masked]>
Date: Mon, 27 Sep 2021 19:03:06 +0200

Hi Efraim,

On mar., 14 sept. 2021 at 21:19, Efraim Flashner <[email-masked]> wrote:
> * gnu/packages/julia-xyz.scm (julia-sass): New variable.
> ---
>  gnu/packages/julia-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
> index a80964c2b0..2f953a33b7 100644
> --- a/gnu/packages/julia-xyz.scm
> +++ b/gnu/packages/julia-xyz.scm
> @@ -3403,6 +3403,28 @@ (define-public julia-safetestsets
>  a loadable module.")
>        (license license:expat))))
>
> +(define-public julia-sass
> +  (package
> +    (name "julia-sass")
> +    (version "0.2.0")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/piever/Sass.jl")
> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32 "0y7kkkj717h5cj659ssry89i5r64symr6pvhr6vv4qmaxrnjxj92"))))
> +    (build-system julia-build-system)
> +    (propagated-inputs
> +     `(("julia-libsass-jll" ,julia-libsass-jll)))
> +    (home-page "https://github.com/piever/Sass.jl")
> +    (synopsis "Compile scss and sass file to css in Julia")

Again, I would remove «in Julia>..

> +    (description "This library provides a simple Julian API to use
> the

I would write «This package provides…»

> +@code{libsass} library to compile scss and sass files to css.")
> +    (license license:expat)))

LGTM.

Cheers,
simon