Subject: bug#50483: [R] Package r-shiny: Shiny server logic inactive

From: zimoun <[email-masked]>
Date: Mon, 20 Sep 2021 21:03:25 +0200

Hi Charles,

Thanks for the patch.

On Sat, 18 Sep 2021 at 05:14, Charles <[email-masked]> wrote:

> Here is a patch to update the packages to use the up to date
> minifier. Is the the correct thread to put this or should I start a
> new thread in the patches mailing list?

I think the bestis to send this patch to [email-masked].  See
commit message and suggestions below.

> From 57c3801034e77120e4030d0e5421a02343e9280c Mon Sep 17 00:00:00 2001
> From: Charles <[email-masked]>
> Date: Sat, 18 Sep 2021 00:05:55 -0500
> Subject: [PATCH] gnu: Update some packages using old JavaScript minifier.

Subject: [PATCH] gnu: Switch to (gnu package uglifyjs) minifier.

Fixes <https://bugs.gnu.org/50483>

> * gnu/packages/minetest.scm (minetest-basic-trains): New variable.
> * gnu/packages/bioinformatics.scm (bismark): Update uglifyjs input.
> * gnu/packages/ci.scm (laminar): Update uglifyjs input.
> * gnu/packages/cran.scm (r-shiny r-shinytree r-shinydashboard r-colourpicker
> r-threejs r-flexdashboard r-networkd3 r-dygraphs): Update uglifyjs input.
> * gnu/packages/javascript.scm (): Update uglifyjs input.

Missing package               --^

I have not compiled, so I assume this removal:

> -  #:use-module (gnu packages lisp-xyz)

does not trigger warning when compiling Guix, right?

> diff --git a/gnu/packages/ci.scm b/gnu/packages/ci.scm
> index b7ea77ca31..a6d296923f 100644
> --- a/gnu/packages/ci.scm
> +++ b/gnu/packages/ci.scm
> @@ -38,7 +38,7 @@
>    #:use-module (gnu packages guile)
>    #:use-module (gnu packages guile-xyz)
>    #:use-module (gnu packages gnupg)
> -  #:use-module (gnu packages lisp-xyz)
> +  #:use-module (gnu packages uglifyjs)

It seems the module are sorted by alphabetic order.

> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index f80256c901..81dd78ac94 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -84,7 +84,7 @@
>    #:use-module (gnu packages java)
>    #:use-module (gnu packages javascript)
>    #:use-module (gnu packages libevent)
> -  #:use-module (gnu packages lisp-xyz)
> +  #:use-module (gnu packages uglifyjs)

Idem.

> diff --git a/gnu/packages/javascript.scm b/gnu/packages/javascript.scm
> index 81de5b67a6..e107dd6126 100644
> --- a/gnu/packages/javascript.scm
> +++ b/gnu/packages/javascript.scm
> @@ -26,7 +26,7 @@
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages compression)
> -  #:use-module (gnu packages lisp-xyz)
> +  #:use-module (gnu packages uglifyjs)

Idem.

Otherwise, LGTM. Thanks.

Cheers,
simon