From unknown Fri Jun 20 05:26:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50470 <50470@debbugs.gnu.org> To: bug#50470 <50470@debbugs.gnu.org> Subject: Status: 27.1; 'company-mode' 'eshell' Reply-To: bug#50470 <50470@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:26:25 +0000 retitle 50470 27.1; 'company-mode' 'eshell' reassign 50470 emacs submitter 50470 Christophe severity 50470 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 02:24:06 2021 Received: (at submit) by debbugs.gnu.org; 8 Sep 2021 06:24:06 +0000 Received: from localhost ([127.0.0.1]:58301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNr09-0001CK-Lv for submit@debbugs.gnu.org; Wed, 08 Sep 2021 02:24:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:51704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNr08-0001CD-BN for submit@debbugs.gnu.org; Wed, 08 Sep 2021 02:24:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNr08-00058M-1R for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 02:24:04 -0400 Received: from smtp-outgoing-1901.laposte.net ([160.92.124.105]:47021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNr04-0003CY-VD for bug-gnu-emacs@gnu.org; Wed, 08 Sep 2021 02:24:03 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Bt13wWGz1GBvy", "contextId":"9573e31b-1ce2-426a-b5ca-fd98b0048547"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0114.laposte.net (SMTP Server) with ESMTP id 4H4Bt13wWGz1GBvy for ; Wed, 8 Sep 2021 08:23:53 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Bt12PvRz1GBvw", "contextId":"8f3adfec-1686-471f-8aef-76af2aae6e3b"} X-lpn-mailing: LEGIT X-lpn-spamrating: 50 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (0)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudefiedguddtfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfntefrqffuvffgpdfqfgfvpdggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddtnecunecujfgurhepfffkhffvufggtgfgsehtkeertddttdejnecuhfhrohhmpeevhhhrihhsthhophhhvgcuoegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvtheqnecuggftrfgrthhtvghrnhepvdegiedtfeegteehjefggeffjeelleehieejfeejvdelheekjeekfeevhfejhfevnecukfhppeekkedruddvhedrudeikedrieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeekkedruddvhedrudeikedriedphhgvlhhopehkrghmvghhohhushgvpdhmrghilhhfrhhomheptghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtpdhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrgh Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0114.laposte.net (SMTP Server) with ESMTPSA id 4H4Bt12PvRz1GBvw for ; Wed, 8 Sep 2021 08:23:53 +0200 (CEST) Date: Wed, 08 Sep 2021 08:23:52 +0200 Message-Id: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: bug-gnu-emacs@gnu.org Subject: 27.1; 'company-mode' 'eshell' MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631082235; bh=1EZ0zbhtgvcjJXsoNHukGsdzzJT7reiOf79neof7A8A=; h=Date:Message-Id:From:To:Subject:MIME-version:Content-type:Content-Transfer-Encoding; b=KCkrXa4Cjs2pEJloc/F8Yyl2UDzFYWrlVzL5iSKNKHgPuz4Vrcu+wPJnNQi8E2cqf0vnvNtuTZMevez6ykCYMCH7jc6hwq0t+a6/sygnQT/7kQ3UTqYOHTfDThYjyHVzq3IEKt71pqQ4zv+LMwjrNDmMEOR+yix5uhk5h5qSyUDhDeojGvSzO/NYdMJukC1QaVqVO4aregqRn9MzE/GaBNdppYnudhef89D477S/32xDeuQQbTKg5Calxtgtomo0tzy2E3vNM8navsayFylth+P5Qhn/zkexk8JM0bQyJc7uKctTNVycNG1wZhT5v0eDUgSwVCQpuS/n5zitVFwgIg==; Received-SPF: pass client-ip=160.92.124.105; envelope-from=ch.bollard@laposte.net; helo=smtp-outgoing-1901.laposte.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, when company-mode is activate: (use-package company :ensure t :init (global-company-mode t) ) there are some weird things: - when you type something, if you enter a single quote a blank space is a= dded. ex: $ ls Images/' - and it's impossible to use a wildcad (*) if you want for example copy a= ll .txt file from a directory. And the C-q not working, I have dot do M-x quoted-insert to insert '*'. With the 26.1 version of emacs there was a workarround that worked (deact= ivate completion at point) but in this actual version that remove all autocompl= etion in eshell. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, ca= iro version 1.16.0) of 2021-03-28, modified by Debian built on x86-conova-01 Windowing system distributor 'The X.Org Foundation', version 11.0.1201100= 0 System Description: Debian GNU/Linux 11 (bullseye) Recent messages: Making completion list... You can run the command =E2=80=98dired=E2=80=99 with C-x d Mark saved where search started Mark set Making completion list... [3 times] Quit [2 times] Making completion list... Complete, but not unique Quit Making completion list... Configured using: 'configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/= var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/shar= e/info --mandir=3D/usr/share/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/27.1/site-lis= p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/s= hare/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --build x86_64-linu= x-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/s= hare/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/27.1/site-lis= p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/27.1/site-lisp:/usr/s= hare/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-cairo --with= -x=3Dyes --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 -ffile-prefix-map=3D/build/emacs-LlFm6W/emacs-27.1+1=3D. -fstack-protect= or-strong -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INO= TIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDU= MPER LCMS2 GMP Important settings: value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: pyvenv-mode: t shell-dirtrack-mode: t show-paren-mode: t global-flycheck-mode: t global-company-mode: t company-mode: t xclip-mode: t global-subword-mode: t subword-mode: t display-time-mode: t display-battery-mode: t electric-pair-mode: t server-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-site hides /usr/share/= emacs/site-lisp/tex-site /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/auctex hides /usr/share/em= acs/site-lisp/auctex /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/preview hides /usr/share/a= uctex/preview /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/font-latex hides /usr/shar= e/auctex/font-latex /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-buf hides /usr/share/a= uctex/tex-buf /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex hides /usr/share/aucte= x/tex /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-style hides /usr/share= /auctex/tex-style /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/bib-cite hides /usr/share/= auctex/bib-cite /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/multi-prompt hides /usr/sh= are/auctex/multi-prompt /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/context hides /usr/share/a= uctex/context /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/context-nl hides /usr/shar= e/auctex/context-nl /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-mik hides /usr/share/a= uctex/tex-mik /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-bar hides /usr/share/a= uctex/tex-bar /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-font hides /usr/share/= auctex/tex-font /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/latex hides /usr/share/auc= tex/latex /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-fold hides /usr/share/= auctex/tex-fold /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/latex-flymake hides /usr/s= hare/auctex/latex-flymake /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-jp hides /usr/share/au= ctex/tex-jp /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/plain-tex hides /usr/share= /auctex/plain-tex /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-ispell hides /usr/shar= e/auctex/tex-ispell /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/texmathp hides /usr/share/= auctex/texmathp /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/toolbar-x hides /usr/share= /auctex/toolbar-x /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/context-en hides /usr/shar= e/auctex/context-en /home/mutenroshii/.emacs.d/elpa/auctex-13.0.14/tex-info hides /usr/share/= auctex/tex-info Features: (shadow mailalias emacsbug sendmail misearch multi-isearch dired-aux em-u= nix em-script em-prompt em-ls em-hist em-pred em-glob em-dirs esh-var em-cmpl em-basic em-banner em-alias esh-mode flyspell ispell .emacs programmation ac-geiser geiser-guile info-look geiser geiser-repl geiser-image geiser-c= ompany geiser-doc geiser-menu geiser-edit geiser-completion geiser-autodoc geise= r-eval geiser-connection tq geiser-syntax scheme geiser-log geiser-popup view py-autopep8 yasnippet highlight-indentation flymake-proc flymake warnings= elpy elpy-rpc pyvenv elpy-shell elpy-profile elpy-django s elpy-refactor diff-= mode easy-mmode python tramp-sh tramp tramp-loaddefs trampver tramp-integratio= n tramp-compat shell pcomplete parse-time iso8601 ls-lisp grep files-x blac= ken jedi jedi-core python-environment epc ctable concurrent deferred auto-com= plete popup virtualenv ada-mode align ada-skel wisi-skel ada-process wisi-process-parse ada-indent-user-options ada-core wisi-prj wisi wisi-fr= inge wisi-parse-common semantic/lex semantic/fw mode-local uniquify-files find= -file compile skeleton paren flycheck find-func rx dash elfeed-show elfeed-sear= ch bookmark pp shr svg dom elfeed-csv elfeed elfeed-curl elfeed-log elfeed-d= b elfeed-lib thingatpt avl-tree url-queue xml-query xml em-term eshell esh-= cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util company-oddmuse company-keywords company-etags etags fileloop generator x= ref project company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-templat= e company-bbdb company pcase ido cus-edit cus-start cus-load wid-edit xclip= linum cap-words superword subword time battery sr-speedbar speedbar sb-image ez= image dframe elec-pair multi-term advice term disp-table comint ansi-color ehel= p edmacro kmacro akira-theme exec-path-from-shell cl-extra use-package-ensu= re use-package-core server mm-archive message dired dired-loaddefs format-sp= ec rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs text-property-search time-date mailabbrev gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils gnutls network-stream url-http mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm rmc puny url-cache url-auth url url-proxy url-privacy url-expand url-methods url-h= istory url-cookie url-domsuf url-util mailcap epg epg-config finder-inf preview-= latex tex-site geiser-impl help-fns radix-tree help-mode geiser-custom geiser-b= ase ring info package easymenu browse-url url-handlers url-parse auth-source = cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map ur= l-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip el= doc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x= -win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mod= e register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-ba= r mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibet= an thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian = slovak czech european ethiopic indian cyrillic chinese composite charscript char= prop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties ove= rlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolba= r gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 497748 27141) (symbols 48 32295 1) (strings 32 157981 6846) (string-bytes 1 4388026) (vectors 16 49196) (vector-slots 8 578680 43664) (floats 8 193 258) (intervals 56 551 184) (buffers 1000 13)) --=20 Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 12:01:03 2021 Received: (at 50470) by debbugs.gnu.org; 8 Sep 2021 16:01:03 +0000 Received: from localhost ([127.0.0.1]:33373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO00V-0001tn-GE for submit@debbugs.gnu.org; Wed, 08 Sep 2021 12:01:03 -0400 Received: from smtp-outgoing-1903.laposte.net ([160.92.124.107]:35011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO00T-0001t7-2w for 50470@debbugs.gnu.org; Wed, 08 Sep 2021 12:01:02 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Rgn0c8jzjWvv", "contextId":"80349b20-da51-4dc5-a6db-f0aef59ec9a2"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0116.laposte.net (SMTP Server) with ESMTP id 4H4Rgn0c8jzjWvv for <50470@debbugs.gnu.org>; Wed, 8 Sep 2021 18:00:53 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Rgm6mq0zjWvq", "contextId":"beee4d84-e6b9-4edc-aa95-07d758d8c682"} X-lpn-mailing: LEGIT X-lpn-spamrating: 50 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (0)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudefjedgleegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecunfetrffquffvgfdpqfgfvfdpggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffkffhvffusedttdertddttddtnecuhfhrohhmpeevhhhrihhsthhophhhvgcuoegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvtheqnecuggftrfgrthhtvghrnheptdettdejheffteellefgfeeuudekiedutdeiteelfeetjeekhffhteettefgieejnecukfhppeekkedruddvhedrudeikedrieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeekkedruddvhedrudeikedriedphhgvlhhopehkrghmvghhohhushgvpdhmrghilhhfrhhomheptghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtpdhrtghpthhtohephedtgeejtdesuggvsggsuhhgshdrghhnuhdrohhrgh Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0116.laposte.net (SMTP Server) with ESMTPSA id 4H4Rgm6mq0zjWvq for <50470@debbugs.gnu.org>; Wed, 8 Sep 2021 18:00:52 +0200 (CEST) Date: Wed, 08 Sep 2021 18:00:52 +0200 Message-Id: <8735qfgiq3.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: 50470@debbugs.gnu.org Subject: eshell DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631116853; bh=sCS7UI+7Z5hGC1Ja8/2XW4KVW9K57vpvXfNQ7CGR2E4=; h=Date:Message-Id:From:To:Subject; b=nU/QhyS6rXRL/Iz2EdrFXOlIeJSv43dgv5SJOobeAT32mGPwKSnJE+tu1/exHsHQpf+k7mAoAF0DYBgWxLAigZxiOOR/EKUayiYu7Hf4YoPwy3BqOzU67U3ekmd/2YdKptb6iufTQ12WQI2mr38txVA1LTcfFugWJMvQcqvXhuiC5qw1BdugrXzA55uri2b357hqkHYr+Gh7Nw04VpWhP4fSIprZdebTEqKb62DhE5ExJX3KnraTJMd+I9z25gDZYsGjPd+F99KHjAYVjvaS5vFhixEFtFwjG6vBnHePEI4d8EwdD3Sr3ZKvhXmosCePAcKIj7QbUrJqnhViC1UfzQ==; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, in fact when I run emacs -Q there is the '*' issue. It's impossible to type the wikdcard character after a directory's name, so it -- Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 12:07:49 2021 Received: (at 50470) by debbugs.gnu.org; 8 Sep 2021 16:07:49 +0000 Received: from localhost ([127.0.0.1]:33392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO073-00026o-H2 for submit@debbugs.gnu.org; Wed, 08 Sep 2021 12:07:49 -0400 Received: from smtp-outgoing-1602.laposte.net ([160.92.124.97]:49993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO072-00026Z-7w for 50470@debbugs.gnu.org; Wed, 08 Sep 2021 12:07:49 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Rqb33TFzjWvt", "contextId":"a8e02619-ad03-4e87-a93f-22dd94e3d5e4"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0116.laposte.net (SMTP Server) with ESMTP id 4H4Rqb33TFzjWvt for <50470@debbugs.gnu.org>; Wed, 8 Sep 2021 18:07:39 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H4Rqb2MS0zjWvW", "contextId":"784f91e5-5851-41a8-88ce-a9cb563457e1"} X-lpn-mailing: LEGIT X-lpn-spamrating: 50 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (0)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudefjedgleehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecunfetrffquffvgfdpqfgfvfdpggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffkffhvffusedttdertddttddtnecuhfhrohhmpeevhhhrihhsthhophhhvgcuoegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvtheqnecuggftrfgrthhtvghrnheptdettdejheffteellefgfeeuudekiedutdeiteelfeetjeekhffhteettefgieejnecukfhppeekkedruddvhedrudeikedrieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeekkedruddvhedrudeikedriedphhgvlhhopehkrghmvghhohhushgvpdhmrghilhhfrhhomheptghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtpdhrtghpthhtohephedtgeejtdesuggvsggsuhhgshdrghhnuhdrohhrgh Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0116.laposte.net (SMTP Server) with ESMTPSA id 4H4Rqb2MS0zjWvW for <50470@debbugs.gnu.org>; Wed, 8 Sep 2021 18:07:39 +0200 (CEST) Date: Wed, 08 Sep 2021 18:07:39 +0200 Message-Id: <87lf47125w.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: 50470@debbugs.gnu.org Subject: eshell DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631117261; bh=yfZEWTW0aRKwXJoXwfjn+QI4dzvzjWJ4f2qDkYfbOPc=; h=Date:Message-Id:From:To:Subject; b=Flr1P3JfN3kjfUB4JO98kQmAm32XGBE/gKry2NUXfwFvJ/oV1kQpNUPp+gWML1IJgn9hQsQMuyggoI+Sv+Z8xjnHJGTMqPIZUida/XQH3h16wdaabm0lIe1n3WhEYp1SL/XX89cGwGLRkN/hp2G1o9u8CY5AWi+84QgjlkB8XFK7UvgNHFlgbTXgcvMIy/lxPQGXB5shUeqsvgnsx4pJMtiAa8HlmFMphCi4MA+QXC+QoYoK8Ml8iMwHnPl2jnVpbx3wgkT9sCJp0AXZRgolOuG4A6Ys3UPUtcfzz58ELIazmzhu2k0l+3EmcwFKY4BhN0jbRAkjocZDT5uGrgw4zg==; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Sorry I made a mistake with the last message. I said, even while running emacs with the -Q argument, it's impossible to type the wildcard character (following a directory's name) -- Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 08 21:57:12 2021 Received: (at 50470) by debbugs.gnu.org; 9 Sep 2021 01:57:12 +0000 Received: from localhost ([127.0.0.1]:33804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO9JQ-0002eA-F9 for submit@debbugs.gnu.org; Wed, 08 Sep 2021 21:57:12 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:56025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mO9JM-0002dv-VJ for 50470@debbugs.gnu.org; Wed, 08 Sep 2021 21:57:11 -0400 Received: by mail-wm1-f51.google.com with SMTP id g74so187351wmg.5 for <50470@debbugs.gnu.org>; Wed, 08 Sep 2021 18:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lKP2rDqwBXNaQWgn3ONQNwsTGcD1qru2/Qj9Sr+zrWg=; b=jMSzy7mXeTdgSbV43upb/EkKLvRb7T42rgRpMliAj9rxyVtmrlkkT5oU5GyTXhcyLy Wr04d0lG0qdNHPSxNDeyUwlSaMn/YN+L2tWGvwTFxJVMAU1ijtdCsVCLF1a4bLvNLVC9 BiS2iPT/oKxYxxmVKq4kk6T3KFwMesApDhEakRsItk30vYcI1wjARkUmEYX3aEOCnQAH +HAuj97vuUKP2oco9dkRUfSRhumHqVEqJML4ozUE4Z0yQCIjaigP9cto8FujxlIC/lmt oK5L10p4hyfNMDcgh+E6sHA84fCv5o+b/ObonN2gzIdFWwB1peM3Su0oZUGtcvqKBFoZ YQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lKP2rDqwBXNaQWgn3ONQNwsTGcD1qru2/Qj9Sr+zrWg=; b=wBqX86xhTGWQIaUNdvQ/ZWYDoOck6HTiWMJvd32s52eNd5TsxzWoN5yMdxf0WjOsk+ PGjoKjUdSzafM2Ti2TDrff81bdiunNu8RjNSm1OCB05CZrssoaCbkFZanOJF/yBXaZyd MWuPyQjLkr7DQnvZcxBF7AavLP8bItyaOutQ8Ox8ALPybcAyQRJ0kTYtGm5xnFRfR4Ni e6/2/wHVpthVnsfZB6R7NkGYp1gX1aBiBz8bRbLu6ScUlkGpFgr3zPQp3O2u9PzC0IRk kvY07vq+iMsYwEDTFlicwJqMrZCKEDr9wVFpeMlMe/QjdHDwhiwUeSKcXMDqfF8xDNHy oFGA== X-Gm-Message-State: AOAM533aVwJBlx61ELAdqaGvD2HbjertlZGFj2KHuxIANlmwRWpxsHvV Fay0AFESlz2G8rKUrUBTq+Sl4ywETSE= X-Google-Smtp-Source: ABdhPJz6EUMNHrDTrShEf2zqEJyggABGsNcyspP71ofpF1bo2oAUCQqKYLnzheBa2YQVEHZwpLR0/w== X-Received: by 2002:a05:600c:1d27:: with SMTP id l39mr323560wms.146.1631152623107; Wed, 08 Sep 2021 18:57:03 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m3sm320774wrg.45.2021.09.08.18.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Sep 2021 18:57:02 -0700 (PDT) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' To: Christophe , 50470@debbugs.gnu.org References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> From: Dmitry Gutov Message-ID: <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> Date: Thu, 9 Sep 2021 04:57:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi! On 08.09.2021 09:23, Christophe via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Hello, > when company-mode is activate: > (use-package company > :ensure t > :init > (global-company-mode t) > ) > there are some weird things: > - when you type something, if you enter a single quote a blank space is added. > ex: $ ls Images/' This is unfortunately an old problem. I though there was already a bug report for it, but couldn't find it. Hope someone will find time to dig in through the leaky abstraction of c-a-p-f -> pcomplete. > - and it's impossible to use a wildcad (*) if you want for example copy all > .txt file from a directory. And the C-q not working, I have dot do M-x > quoted-insert to insert '*'. That sounds like bug#18951. But it was fixed, though. Maybe some minor variation of it? > With the 26.1 version of emacs there was a workarround that worked (deactivate > completion at point) but in this actual version that remove all autocompletion > in eshell. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 01:48:43 2021 Received: (at 50470) by debbugs.gnu.org; 9 Sep 2021 05:48:44 +0000 Received: from localhost ([127.0.0.1]:33948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOCvT-0008UA-Me for submit@debbugs.gnu.org; Thu, 09 Sep 2021 01:48:43 -0400 Received: from smtp-outgoing-1701.laposte.net ([160.92.124.99]:50055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOCvO-0008Tn-4f for 50470@debbugs.gnu.org; Thu, 09 Sep 2021 01:48:42 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H4p2j06kbzFpTt", "contextId":"1fc4c911-097a-427e-8b62-8051f0b5ec0c"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0101.laposte.net (SMTP Server) with ESMTP id 4H4p2j06kbzFpTt; Thu, 9 Sep 2021 07:48:29 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H4p2h5MZTzFpTZ", "contextId":"5df2a454-c51d-412f-b5aa-15db98705bf4"} X-lpn-mailing: LEGIT X-lpn-spamrating: 46 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (-100)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudefkedgleelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecunfetrffquffvgfdpqfgfvfdpggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffkhffvjgfufhestddtredttddttdenucfhrhhomhepvehhrhhishhtohhphhgvuceotghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtqeenucggtffrrghtthgvrhhnpeeutdejleefleeujeeiffefteehtddvudekleeuteehfffggeegueelfeetvdfhveenucfkphepkeekrdduvdehrdduieekrdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkeekrdduvdehrdduieekrdeipdhhvghlohepkhgrmhgvhhhouhhsvgdpmhgrihhlfhhrohhmpegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopeehtdegjedtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0101.laposte.net (SMTP Server) with ESMTPSA id 4H4p2h5MZTzFpTZ; Thu, 9 Sep 2021 07:48:28 +0200 (CEST) Date: Thu, 09 Sep 2021 07:48:28 +0200 Message-Id: <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: Dmitry Gutov In-Reply-To: <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> (message from Dmitry Gutov on Thu, 9 Sep 2021 04:57:01 +0300) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631166510; bh=SQjc4sHYf1wly2KSP9CxsqCE3eGvXFJdtoS7Pz2vlFs=; h=Date:Message-Id:From:To:Cc:In-Reply-To:Subject:References; b=X5u+dQHzqkEK8uuAm6trsScCHotgyU0Wbwkv7LLRM6hvjcIzy+CYui2mL67VplTrZJa5eQuTSlafUj4RBsiEw/v4L/0yd6hzrymz5ZCMhkRTOcKCC5SkyZNSvAzHCSm74QYw8ANMnawcQASkI8Lqol4m32gUu2o2b1bRScWB+zkoa51cSnpieqrvaHIuWP0ChaE9lLwEjOOp/cDI2SPMl0DL7i3tSdmBnonRz8jG7RKuq5/X1fXHUoPwrJ4qf/wEsqRrEczRx8O89Lb3RNLDjiM2Wa3FHYZuDdisQEDnel2d8gGZ9J4CF8urcJHtnyQ0SE7NfVvXbfWZJon/cePxvA==; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Maybe the debian version was frozen befor the fix then. -- Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 08:06:38 2021 Received: (at 50470) by debbugs.gnu.org; 9 Sep 2021 12:06:38 +0000 Received: from localhost ([127.0.0.1]:34315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOIpC-0003bc-Kq for submit@debbugs.gnu.org; Thu, 09 Sep 2021 08:06:38 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:55213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOIp9-0003bM-Cc for 50470@debbugs.gnu.org; Thu, 09 Sep 2021 08:06:36 -0400 Received: by mail-wm1-f51.google.com with SMTP id s24so1175969wmh.4 for <50470@debbugs.gnu.org>; Thu, 09 Sep 2021 05:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jqvgL9HoFv03RZ8g04ArxncIpBjZROSrtH1VGewORMc=; b=iFLBT6lpAubcEQDwloTCqdiGhATqce+Bj2MjvfwVYXlq45QTjk2JqHDwCGP9EAaj+0 IEozOqND6ow+N5ENENoseiwiieBkYsK/r4cvdu2t5WE2a/WshVrrT+Kg3/PIs/3SOcnz TJswMNm+/jUNgV6ZtS+Gt7XhLmvS4wf1jYWVyC7bRuJhCYFCiUOKvXhfu7KZwSv2y4Jo Wf1neobBW8TJvDVPN3pC/SZOvQoK1hNalJ9eyR7J/k/Zpnk4/Zp8omeBI5RfjJUJkKoO igNi8+kSReak10jTEOt0kYLaIWHujX3Lr1oww0xaXBwd7q4XepO59KmFRallPry1QHqv M73w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jqvgL9HoFv03RZ8g04ArxncIpBjZROSrtH1VGewORMc=; b=j7sizVWtmvHeoWXRNBs9AN90FOX15wtqaEAM3CE08sRMKLWIc4Sp/U4z3iGRxkXNyU /yYjykyZCKjkAbQDESjxpDAMjzVWUKHmfMCF0ec4IzbIUfn1seRxPZnmtIpmLOgXgIK0 Hlq5nRQyyhpMqQTuW0IsWAmIsIJDSuodEwNOAFYiMek/slvpIPho4GudvE1ILRdZ1RZU TUJMbij+hGXg38glPrGp5+E2QbEsk2MXaq1oHRc+EryvG8wi9R/sowYtnMKLoVfGN8MD lyPMgN+j5JXL6HlMkIAwHkg9bG+16u8alElE0ASTyJwWz+ge0Mkm0V/UDtcIRgDXtKur gOmw== X-Gm-Message-State: AOAM533imrYyQK6R6JSD5sSdGxModVvuE2rnvnGZZKzwXFeal/q8u1dY kT5KyZKeEdnJ8SwdWJV9GLvpZyKK3Zc= X-Google-Smtp-Source: ABdhPJyCM/HjqtcUAjhQupnjIBW1DetsEV5pdLWam+TDH6CFarUVAJ3ZWwrJgy7gIrlwxHCp+Y/1GQ== X-Received: by 2002:a1c:234a:: with SMTP id j71mr2578547wmj.11.1631189189427; Thu, 09 Sep 2021 05:06:29 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l7sm1597719wmj.9.2021.09.09.05.06.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 05:06:28 -0700 (PDT) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' To: Christophe References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> From: Dmitry Gutov Message-ID: <0479d79f-651a-d1d6-428a-9ca9d71a64ba@yandex.ru> Date: Thu, 9 Sep 2021 15:06:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 09.09.2021 08:48, Christophe wrote: > Maybe the debian version was frozen befor the fix then. That's very unlikely. And the fix was in 26.1 even, not 27. You can jump to your sources and see whether the commit (https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d744e032fee9ce60446a3cc0cf7c2e681ace465) it applied anyway. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 09:09:23 2021 Received: (at 50470) by debbugs.gnu.org; 9 Sep 2021 13:09:23 +0000 Received: from localhost ([127.0.0.1]:34388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOJnv-0005Ik-He for submit@debbugs.gnu.org; Thu, 09 Sep 2021 09:09:23 -0400 Received: from smtp-outgoing-1802.laposte.net ([160.92.124.103]:35902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOJnt-0005IS-HT for 50470@debbugs.gnu.org; Thu, 09 Sep 2021 09:09:22 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H4zqB75C2z1GBvn", "contextId":"3f666bf9-de9a-407a-b476-10d94da28489"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0114.laposte.net (SMTP Server) with ESMTP id 4H4zqB75C2z1GBvn; Thu, 9 Sep 2021 15:09:10 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H4zqB5wgdz1GBvt", "contextId":"b837a957-fb0f-4774-9297-2b98e374dfec"} X-lpn-mailing: LEGIT X-lpn-spamrating: 46 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (-100)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgieduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecunfetrffquffvgfdpqfgfvfdpggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffkhffvjgfufhestddtredttddttdenucfhrhhomhepvehhrhhishhtohhphhgvuceotghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtqeenucggtffrrghtthgvrhhnpeeutdejleefleeujeeiffefteehtddvudekleeuteehfffggeegueelfeetvdfhveenucfkphepkeekrdduvdehrdduieekrdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkeekrdduvdehrdduieekrdeipdhhvghlohepkhgrmhgvhhhouhhsvgdpmhgrihhlfhhrohhmpegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopeehtdegjedtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0114.laposte.net (SMTP Server) with ESMTPSA id 4H4zqB5wgdz1GBvt; Thu, 9 Sep 2021 15:09:10 +0200 (CEST) Date: Thu, 09 Sep 2021 15:09:10 +0200 Message-Id: <87tuitzyix.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: Dmitry Gutov In-Reply-To: <0479d79f-651a-d1d6-428a-9ca9d71a64ba@yandex.ru> (message from Dmitry Gutov on Thu, 9 Sep 2021 15:06:27 +0300) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> <0479d79f-651a-d1d6-428a-9ca9d71a64ba@yandex.ru> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631192954; bh=M+0bP0PO6ncZy8INQr4AMuhzLCiC0KyLEykRBp1KYsk=; h=Date:Message-Id:From:To:Cc:In-Reply-To:Subject:References; b=hY38BfTmcTl/Q79lV8PWrDnYCYdaAZPACHk3hsqYymxdMHJwp5T1Ctqc5Uk/QIjDFzpEAPDIF3la/a64fw9sqPiWYA0sL0GcoeAgUErevU+VL3Mx+DGdpI0iPAFQCyE/07tM+QfFw/+rlojPPiY1NmxCa1ZhjMYrXgs6YvvzRW56DGssgo7rsy3a3n/cyb7SHaCXh124fdTlj7P9DWfoRTfDPRFMzWpKlucbXnvLYJ0vuyqk+ckNhQZHcLybZ2aWPrkSoZ4lGvLxfoPFL1V8eWH7VTxjFya79oqD0PkQHmY7Kbp0UBUnaHfPb96Uixx77pkad0NcQK3I/PGZRm4pGQ==; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Exact. So I don't know why I cannot use the wildcards without that is replace by pcomplete. I'll going on searching a solution, I can't give up eshell like this. -- Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 19:30:29 2021 Received: (at 50470) by debbugs.gnu.org; 9 Sep 2021 23:30:29 +0000 Received: from localhost ([127.0.0.1]:36427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOTUz-0003N5-Mx for submit@debbugs.gnu.org; Thu, 09 Sep 2021 19:30:29 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:35571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOTUx-0003Ms-Nm for 50470@debbugs.gnu.org; Thu, 09 Sep 2021 19:30:28 -0400 Received: by mail-wr1-f54.google.com with SMTP id i23so7673wrb.2 for <50470@debbugs.gnu.org>; Thu, 09 Sep 2021 16:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aje9WMpR8cIQLYPGxDT5rSEg6ARK8xU5RY/rMFg8yMY=; b=h+7+BKRjM1B/m4lsfjODAZ8s0s/hINga6SYkvataQHAaHJnagH/GD4RKFgcePnA1/s YL/KcUpAl05Qbhwlu3tOGQx8PfcZZNKKXUQIbOVd61AZhjTTYJv8hxHqIUvaeNaHKqZO 9Vnr4qyyl/kSQZE+lEcgIJvlHtubafvSsUsI0NHTY459vYr6IMR2t1nXsaG4EQeUecjt p5dEiRMV5jvs90rTo2m/mjFF+ZNMVMYwh98C5WaXju8xG27C7wEHlyRmSVhpL0DwBcxe EyhZYS2nZiqGlMKQ12f3986pGyaZYKYlusCXJIZ1YwymXYrWIr2rm5hKwJgxufqORrlC P2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aje9WMpR8cIQLYPGxDT5rSEg6ARK8xU5RY/rMFg8yMY=; b=Lx4eIFgJyjhqAQc+3l2WFAYvm4q/GvDqF9Foae9+O8DQpdr+sia0DpYA4r913r4jN6 onUxrU2ISpjnm9tP15m7fGlKWKe/b/0qW8eKTZUdiRckiL3EsNFX+prgCJeD+4/0kzI4 wSqvb7LMJG0O7tMW9JE1jYw2UNTfjdCkVzDBUCM5bJ6aMkbu29v6on0w+U1r1RUVfd0M WtIluRNKApv+gmi6T9jZSOrKDfBJritwkHcJadYw87SD3z6bTSjwfMiglEU61s9J5xTP xs6p58kSqo5tk7FpwTwbr7UmFIXIWSh6dlhrOA8qxwYYEdx8AKwOIBx0FVW/30PgQ9lA I8kw== X-Gm-Message-State: AOAM530WEF7w3QOoHYkvpB0CeBb6MX/aunj+hkxxU1+ViA1obpe/WQ+D 7IOE7LF7ifCj2MZmoUdgcY2YQvGtbhM= X-Google-Smtp-Source: ABdhPJyVA4nlurBrt54TwdNIYhlrKcJm++FxSwzD0Tyz9o+QPSRlpnP2tkfTpz/pGqvTex+VaBAyrw== X-Received: by 2002:adf:8144:: with SMTP id 62mr6488062wrm.144.1631230220944; Thu, 09 Sep 2021 16:30:20 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c7sm2722277wmq.13.2021.09.09.16.30.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 16:30:20 -0700 (PDT) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' To: Christophe References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> <0479d79f-651a-d1d6-428a-9ca9d71a64ba@yandex.ru> <87tuitzyix.fsf@debian-BULLSEYE-live-builder-AMD64> From: Dmitry Gutov Message-ID: Date: Fri, 10 Sep 2021 02:30:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87tuitzyix.fsf@debian-BULLSEYE-live-builder-AMD64> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 09.09.2021 16:09, Christophe wrote: > Exact. So I don't know why I cannot use the wildcards without that is replace > by pcomplete. > I'll going on searching a solution, I can't give up eshell like this. Until this is fixed, you can disable pcomplete <-> capf intergration in eshell like this: (defun my/disable-pcomplete-capf () (remove-hook 'completion-at-point-functions #'pcomplete-completions-at-point t)) (add-hook 'eshell-mode-hook #'my/disable-pcomplete-capf) From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 10 01:12:05 2021 Received: (at 50470) by debbugs.gnu.org; 10 Sep 2021 05:12:05 +0000 Received: from localhost ([127.0.0.1]:36659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOYpZ-0007m0-Fc for submit@debbugs.gnu.org; Fri, 10 Sep 2021 01:12:05 -0400 Received: from smtp-outgoing-1803.laposte.net ([160.92.124.104]:40349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOYpX-0007lU-9f for 50470@debbugs.gnu.org; Fri, 10 Sep 2021 01:12:04 -0400 X-mail-filterd: {"version":"1.3.1", "queueID":"4H5PB10msfz1qqhq", "contextId":"189f37a4-f562-48a7-82e1-8e30f19d2540"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0119.laposte.net (SMTP Server) with ESMTP id 4H5PB10msfz1qqhq; Fri, 10 Sep 2021 07:11:53 +0200 (CEST) X-mail-filterd: {"version":"1.3.1", "queueID":"4H5PB064MMz1qqhn", "contextId":"e13ab5fe-f803-4212-b99f-8d02af2c0909"} X-lpn-mailing: LEGIT X-lpn-spamrating: 46 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (-100)(0000)gggruggvucftvghtrhhoucdtuddrgedvtddrudegtddgkeelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecunfetrffquffvgfdpqfgfvfdpggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffkhffvjgfufhestddtredttddttdenucfhrhhomhepvehhrhhishhtohhphhgvuceotghhrdgsohhllhgrrhgusehlrghpohhsthgvrdhnvghtqeenucggtffrrghtthgvrhhnpeeutdejleefleeujeeiffefteehtddvudekleeuteehfffggeegueelfeetvdfhveenucfkphepkeekrdduvdehrdduieekrdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkeekrdduvdehrdduieekrdeipdhhvghlohepkhgrmhgvhhhouhhsvgdpmhgrihhlfhhrohhmpegthhdrsgholhhlrghrugeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopeehtdegjedtseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhu Received: from kamehouse (unknown [88.125.168.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0119.laposte.net (SMTP Server) with ESMTPSA id 4H5PB064MMz1qqhn; Fri, 10 Sep 2021 07:11:52 +0200 (CEST) Date: Fri, 10 Sep 2021 07:11:52 +0200 Message-Id: <87h7etvwtj.fsf@debian-BULLSEYE-live-builder-AMD64> From: Christophe To: Dmitry Gutov In-Reply-To: (message from Dmitry Gutov on Fri, 10 Sep 2021 02:30:19 +0300) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <87wnnq47v7.fsf@debian-BULLSEYE-live-builder-AMD64> <0479d79f-651a-d1d6-428a-9ca9d71a64ba@yandex.ru> <87tuitzyix.fsf@debian-BULLSEYE-live-builder-AMD64> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1631250716; bh=19H3scx4/TKSZ79EldMZujTWL0ywHV7gf4QqysrEjLw=; h=Date:Message-Id:From:To:Cc:In-Reply-To:Subject:References; b=ifM5NZ9NOcy++4/aXxH1/VPEEuxEm8ZQ8oAJi9ICDxrAtvUqsIhF2Cr8KnVAq0bbYWuis8S6VKBAFsMySInmkg8WTXd1ve0xoQTqjzvgLGjd/sUHzrCvpzTx9N3PI3Ur8liuaErIZnGhcumpDGlkfeMN86pV36Q2YtC4YWVwgLssp93K0KOv3z6T0qK/WwRWuRa11Tiaen3f/+FlZPT48fZn3NBoDgyB31pMdUY5pJkYupnn2IqAiXL0swmd+ahc21mbTvHvyTZnRgdYIcPXfYXOfuDKDq7PjZkRSGBUAFmCp+4/dBVsEPPfIgemJqYk2/vZQKM9/jEAQPCQd22lDw==; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I used something like this in the 26.1 (I've found in a site stackoverflow or stackexchange): (defun my-eshell-remove-pcomplete () "Remove anoying tab insert when no completion found by company." (remove-hook 'completion-at-point-functions #'pcomplete-completions-at-point t)) (add-hook 'eshell-mode-hook #'my-eshell-remove-pcomplete) And like yours, actually if I use this I have no more autocompletion in eshell. (Except fore the path if that start by ./) So I have to add this now: (add-hook 'eshell-mode-hook (lambda () (define-key eshell-mode-map (kbd "") (lambda () (interactive) (pcomplete-std-complete))))) But that's less efficient. (except for the wildcards and the blank spaces that's appears after single and double quotes) Thanks for the time spent on this, at least I have no more blank spaces/wildcards issues and I can use the tab for the autocompletion. -- Christophe BOLLARD From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 05 17:07:15 2021 Received: (at 50470) by debbugs.gnu.org; 5 Dec 2021 22:07:15 +0000 Received: from localhost ([127.0.0.1]:59906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtzf9-00019T-Bi for submit@debbugs.gnu.org; Sun, 05 Dec 2021 17:07:15 -0500 Received: from mail-lj1-f178.google.com ([209.85.208.178]:37460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtzf8-00019G-9R for 50470@debbugs.gnu.org; Sun, 05 Dec 2021 17:07:14 -0500 Received: by mail-lj1-f178.google.com with SMTP id k2so17378582lji.4 for <50470@debbugs.gnu.org>; Sun, 05 Dec 2021 14:07:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:from:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=egtKcAA6zPIrnEiG2P1T2cOBNzhVT8Ar0NrdC2cZ0pQ=; b=BvTyaX2TQqij43s3Dq174Y0E1P2aToMS6vCrTYpVXjgGWFaWb37lSoZoTLTB71lMZ8 /rq/tYZjphaktkexJNrkBsFAmL7nWxHhjiqodNYo0RwvNSlwZUEgtu3DmOIlOddlTpss t7WWAejO9hU8IUshQ8IcGU1nI1Iaju1ZtgoDJMwOn6QYPr0U1h+WkKnkK6BTcK4BGolG FuU/e5Zx+plCVPUvjKPGJAKC+6G/gxUqZP84BQ88Plv5hkqrjUV8HuLv9NXfG1CGvdkW QKs1gDPB+TRp34oM+hkRd51UE4/0rp6ZshZ38NzaDm7+VSnYQa7odjFrvUs5VWCZ745k kYYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:from:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=egtKcAA6zPIrnEiG2P1T2cOBNzhVT8Ar0NrdC2cZ0pQ=; b=r1BgXFIX+/UB/o4PbwyywkfPMDqmLh7NEwwXCpTVmxS1tZg8iIY+BjUcXSJuGvPKpb xMnh35d9TXrbgKuoPWaQV9JuxSquT2fp2EQZ2mGP6839JiQbT8yeTt3sbHhR/ztcqho7 C11ERMjShExsdInBtpSHdL5wOy1jGXbay/4//ACR2SIsCjgn85u+R6wYdb/TKj3zXBSI oRID1c9MXrhbATBi1nVk32D21PdB6n9cqpP4hIViwLMwuGwvmHg6aqZsJ8fejyrUbYuP S+JB7PNLVhLVR454PpUtzu7km050OlEy3TbizrHTP/iR4x/VWJLJgn89wD3n11sNDSH/ Ag5Q== X-Gm-Message-State: AOAM533IKN1lJT6P/mod6w5M1PKnlS8VPTTkBTWoCVrjI5fBJKYTczqg Jx2u8619QsUztSJ6oeHOmgI= X-Google-Smtp-Source: ABdhPJxK4j5u/nnKzGL43TEEizF4KFk2DNMEzuhmJkuJRjwnBY46puVFv4fOPajf054mJ6Q/RCwX6Q== X-Received: by 2002:a2e:3009:: with SMTP id w9mr31862413ljw.71.1638742028220; Sun, 05 Dec 2021 14:07:08 -0800 (PST) Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id l12sm1178556lfe.81.2021.12.05.14.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Dec 2021 14:07:07 -0800 (PST) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' From: Dmitry Gutov To: Christophe , 50470@debbugs.gnu.org, Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> Message-ID: <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> Date: Mon, 6 Dec 2021 01:06:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 09.09.2021 04:57, Dmitry Gutov wrote: > Hi! > > On 08.09.2021 09:23, Christophe via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: >> Hello, >> when company-mode is activate: >> (use-package company >>    :ensure t >>    :init >>    (global-company-mode t) >>    ) >> there are some weird things: >> - when you type something, if you enter a single quote a blank space >> is added. >> ex: $ ls Images/' > > This is unfortunately an old problem. I though there was already a bug > report for it, but couldn't find it. Hope someone will find time to dig > in through the leaky abstraction of c-a-p-f -> pcomplete. Some new details, from https://github.com/company-mode/company-mode/discussions/1276: When this happens (the user types a quote character and the tab character is inserted), there is a message in the echo area: Completion function pcomplete-completions-at-point uses a deprecated calling convention I'm going to add Stefan to Cc in case maybe he had a quick fix in mind, since I saw him reply to a similar-ish bug report about pcomplete integration. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 05:45:04 2021 Received: (at 50470) by debbugs.gnu.org; 10 Dec 2021 10:45:05 +0000 Received: from localhost ([127.0.0.1]:45603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvdOi-0000Ov-Lu for submit@debbugs.gnu.org; Fri, 10 Dec 2021 05:45:04 -0500 Received: from kamnitnik.top ([209.250.245.214]:54902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvdOf-0000OE-QE for 50470@debbugs.gnu.org; Fri, 10 Dec 2021 05:45:03 -0500 Received: from localhost (BSN-77-156-43.static.siol.net [193.77.156.43]) by kamnitnik.top (Postfix) with ESMTPSA id E00E79C719; Fri, 10 Dec 2021 10:44:59 +0000 (UTC) From: To: Dmitry Gutov , Christophe , 50470@debbugs.gnu.org, Stefan Monnier Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' In-Reply-To: <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> Date: Fri, 10 Dec 2021 11:50:09 +0100 Message-ID: <87wnkc3fa6.fsf@miha-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 09.09.2021 04:57, Dmitry Gutov wrote: >> Hi! >>=20 >> On 08.09.2021 09:23, Christophe via Bug reports for GNU Emacs, the Swiss= =20 >> army knife of text editors wrote: >>> Hello, >>> when company-mode is activate: >>> (use-package company >>> =C2=A0=C2=A0 :ensure t >>> =C2=A0=C2=A0 :init >>> =C2=A0=C2=A0 (global-company-mode t) >>> =C2=A0=C2=A0 ) >>> there are some weird things: >>> - when you type something, if you enter a single quote a blank space=20 >>> is added. >>> ex: $ ls Images/' >>=20 >> This is unfortunately an old problem. I though there was already a bug=20 >> report for it, but couldn't find it. Hope someone will find time to dig= =20 >> in through the leaky abstraction of c-a-p-f -> pcomplete. > > Some new details, from=20 > https://github.com/company-mode/company-mode/discussions/1276: > > When this happens (the user types a quote character and the tab=20 > character is inserted), In my package capf-autosuggest, I run completion-at-point-functions somewhat like this: (let (;; `pcomplete-completions-at-point' may illegally use ;; `completion-in-region' itself instead of returning a collectio= n. ;; Let's try to outsmart it. (completion-in-region-function (lambda (start end collection predicate) (throw 'illegal-comp-in-region (list start end collection :predicate predicate)))) ;; Prevent `pcomplete-completions-at-point' from inserting a TAB (buffer-read-only t)) ;; `ielm-complete-filename' may illegaly move point (save-excursion (condition-case nil (catch 'illegal-comp-in-region (run-hook-wrapped 'completion-at-point-functions ...)) (buffer-read-only nil)))) This way, old style capf functions are prevented from inserting a TAB or moving point. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 10 08:10:54 2021 Received: (at 50470) by debbugs.gnu.org; 10 Dec 2021 13:10:54 +0000 Received: from localhost ([127.0.0.1]:45872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvffq-00052F-6c for submit@debbugs.gnu.org; Fri, 10 Dec 2021 08:10:54 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mvffo-000520-F6 for 50470@debbugs.gnu.org; Fri, 10 Dec 2021 08:10:53 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id ECF6F805D6; Fri, 10 Dec 2021 08:10:45 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 56CCE8044E; Fri, 10 Dec 2021 08:10:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1639141844; bh=3Pxb2B6k9JX/d6x0Qu/JqvG+4pjCXG6mmda1DatTmSQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YLS9mwedBKH20o1slVCRYzeUdt4n5rgNXv+o5BCImJfoZomb44UeWTxF0laT9IJwg ZRqLgegSHs5031zHuwfgpAXYLDCkVrIyLBUfD/5QTf6YAunZ75CVTKO2d7nHZdk5RX MGORHuxg+Rk2OrfM62a3QaAQ2EwZi/HcwpzobCc+zirRTLbZwnSRIdIFt/zuAH77X4 Yw9RKCYwhK+4ynN184+7GlzvJswsVIbgBekm+/uLPb6huLvktguSdpFR2BzZLXqF2v sUUJQMc9z+n1gaqswlTqaZyW+H1/t7/PPI2w0kMjhEl4oKaJYgNwuZjs0ioviy42R/ KSdw8uepKzfLA== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2957B1207BE; Fri, 10 Dec 2021 08:10:44 -0500 (EST) From: Stefan Monnier To: Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <87wnkc3fa6.fsf@miha-pc> Date: Fri, 10 Dec 2021 08:10:43 -0500 In-Reply-To: <87wnkc3fa6.fsf@miha-pc> (jakanakaevangeli@chiru.no's message of "Fri, 10 Dec 2021 11:50:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > In my package capf-autosuggest, I run completion-at-point-functions > somewhat like this: > > (let (;; `pcomplete-completions-at-point' may illegally use > ;; `completion-in-region' itself instead of returning a collection. > ;; Let's try to outsmart it. > (completion-in-region-function > (lambda (start end collection predicate) > (throw 'illegal-comp-in-region > (list start end collection :predicate predicate)))) > ;; Prevent `pcomplete-completions-at-point' from inserting a TAB > (buffer-read-only t)) > ;; `ielm-complete-filename' may illegaly move point > (save-excursion > (condition-case nil > (catch 'illegal-comp-in-region > (run-hook-wrapped 'completion-at-point-functions ...)) > (buffer-read-only nil)))) > > This way, old style capf functions are prevented from inserting a TAB or > moving point. Hmm... capf itself tries to "solve" that problem in the following way: (defvar completion--capf-misbehave-funs nil "List of functions found on `completion-at-point-functions' that misbehave. These are functions that neither return completion data nor a completion function but instead perform completion right away.") (defvar completion--capf-safe-funs nil "List of well-behaved functions found on `completion-at-point-functions'. These are functions which return proper completion data rather than a completion function or god knows what else.") (defun completion--capf-wrapper (fun which) ;; FIXME: The safe/misbehave handling assumes that a given function will ;; always return the same kind of data, but this breaks down with functions ;; like comint-completion-at-point or mh-letter-completion-at-point, which ;; could be sometimes safe and sometimes misbehaving (and sometimes neither). (if (pcase which ('all t) ('safe (member fun completion--capf-safe-funs)) ('optimist (not (member fun completion--capf-misbehave-funs)))) (let ((res (funcall fun))) (cond ((and (consp res) (not (functionp res))) (unless (member fun completion--capf-safe-funs) (push fun completion--capf-safe-funs)) (and (eq 'no (plist-get (nthcdr 3 res) :exclusive)) ;; FIXME: Here we'd need to decide whether there are ;; valid completions against the current text. But this depends ;; on the actual completion UI (e.g. with the default completion ;; it depends on completion-style) ;-( ;; We approximate this result by checking whether prefix ;; completion might work, which means that non-prefix completion ;; will not work (or not right) for completion functions that ;; are non-exclusive. (null (try-completion (buffer-substring-no-properties (car res) (point)) (nth 2 res) (plist-get (nthcdr 3 res) :predicate))) (setq res nil))) ((not (or (listp res) (functionp res))) (unless (member fun completion--capf-misbehave-funs) (message "Completion function %S uses a deprecated calling convention" fun) (push fun completion--capf-misbehave-funs)))) (if res (cons fun res))))) (defun completion-at-point () "Perform completion on the text around point. The completion method is determined by `completion-at-point-functions'." (interactive) (let ((res (run-hook-wrapped 'completion-at-point-functions #'completion--capf-wrapper 'all))) ...)) Maybe this should be improved/refined? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 21:46:11 2021 Received: (at 50470) by debbugs.gnu.org; 13 Dec 2021 02:46:11 +0000 Received: from localhost ([127.0.0.1]:53544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbLv-0003Jg-HN for submit@debbugs.gnu.org; Sun, 12 Dec 2021 21:46:11 -0500 Received: from mail-lj1-f179.google.com ([209.85.208.179]:39470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbLp-0003Iu-6h for 50470@debbugs.gnu.org; Sun, 12 Dec 2021 21:46:09 -0500 Received: by mail-lj1-f179.google.com with SMTP id m12so21759627ljj.6 for <50470@debbugs.gnu.org>; Sun, 12 Dec 2021 18:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ckXPC4hQMYhBIYDJ5HnqKL40fcElM2M4Ksdf/g8+ML4=; b=Gjf+s9RvJBE2UPKFK3CnsUR/9pX+OBYua8U+mQFkjqkt5bOudxBtSkKqQFkQwhb5Hg jk9h1/K5xNmVV9fAvFZ4jDBB8CUZ6hKdbgIVSiDzRd1zV9D7/t/bUPKB3ztnO081cG+g bPlljGduVu7m+PoC+HirivkUt/kd6a+ZOGnMKCuNb42XC1NbK65Rr9p0VspxdsdDocZ6 jt3T5zDnnSO2+iyDRhMaK2UOWNMxT2+BxbA3Q6kMKS640iEg6UczMyM0S/s8iF4XrcCz QdfXm/E9ZukPfzwOsbnug9RS2foorPJzYn447N/+fqSS9Jq1D88jLN9+SbzztA2jgyQO eJzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ckXPC4hQMYhBIYDJ5HnqKL40fcElM2M4Ksdf/g8+ML4=; b=5ghfNizWi9DdgmHlOXBj7dGSdheJPg4D3Lcth8igQVvyH9JDYPSBGnvnf863mzG1DH up2RW/wsS3ImgFiUgScZMRbIseGUHbImyD0m/y3ktt4BrhhxGOynko/g2ReYxaOJU+Gf KLVCkdKSPCaC89FopymWwHVq4V5C3ejd7XBjJWv7DYulrAxoL5JHGcTTB06DbAlyxiiL QN2v4Edawje07XvHJU81QAxjtYWAbe8HAGWVSHhGQ3aWHvuQKR10p9GpaqpuUM8Visf2 G16f93N619UsBq5iuA1K0y3PpObjkG8UgMlYyBoLlcb8JHHUJFLczK2f+RE48H1oYcVq KkKg== X-Gm-Message-State: AOAM53306jlvjh6NavBLtGX9Bvr4psmDJS8Qvvo5IR/EB7mdvTWU4ASY v1qBINzEuZJwd2lHIEJiMf6ePZAb6MhHig== X-Google-Smtp-Source: ABdhPJwDizd54afIcWTZL7F1EwmmoLnCnm2vYQBSCRrngEJTOt/LmhndIPV4bSHAmYgD1BZYuVFk3g== X-Received: by 2002:a2e:5712:: with SMTP id l18mr25959722ljb.268.1639363559136; Sun, 12 Dec 2021 18:45:59 -0800 (PST) Received: from [192.168.0.103] ([5.18.233.185]) by smtp.googlemail.com with ESMTPSA id bj11sm1246310ljb.62.2021.12.12.18.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 18:45:58 -0800 (PST) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' To: Stefan Monnier , jakanakaevangeli@chiru.no References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <87wnkc3fa6.fsf@miha-pc> From: Dmitry Gutov Message-ID: Date: Mon, 13 Dec 2021 05:45:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) On 10.12.2021 16:10, Stefan Monnier wrote: > Hmm... capf itself tries to "solve" that problem in the following way: The problem with this approach is that pcomplete-completion-at-point behaves properly most of the time, and only "misbehaves" after some particular inputs. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 12 22:15:02 2021 Received: (at 50470) by debbugs.gnu.org; 13 Dec 2021 03:15:02 +0000 Received: from localhost ([127.0.0.1]:53549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbnp-00040D-Sh for submit@debbugs.gnu.org; Sun, 12 Dec 2021 22:15:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwbnn-0003zm-3O for 50470@debbugs.gnu.org; Sun, 12 Dec 2021 22:14:59 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2E4EB442371; Sun, 12 Dec 2021 22:14:53 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C1144441303; Sun, 12 Dec 2021 22:14:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1639365291; bh=g5V6x3oyZARiO64ox6FI4GgHMjILskczsqqefGeNd5U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Q/8iuTnGZnQxMqAZLcUH47hjh0JpcvsHZdDGu/wJjj7zMU0wUjEPycb1+O+3+MQr4 TrFGebJs1vIFcykmK6dxpg+xKmzGVCTdp/bZ+2h5EeZzdmls3XDOzMNWUhXgcdH43m 1bS0up/Y1ZayUvGCM3ORv5KRpnqLwKYs1yBdWq9WelbZKu4YH5XNzGswlfIABvyj8p E0pHWDZHgeqzimWHmkwmZQxcSf1KorekldPy3tX0zI4+3ggkHF9YPjdsZYOq//9Cat FIlTrXO7r9A4BvDMYwh8qRjua60uPBb3gVT5E8MArbJ2NenmMmPBPqb+OruH/HWNJA AZ1IWHE8Q6S1g== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 608DB1207D4; Sun, 12 Dec 2021 22:14:51 -0500 (EST) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <87wnkc3fa6.fsf@miha-pc> Date: Sun, 12 Dec 2021 22:14:49 -0500 In-Reply-To: (Dmitry Gutov's message of "Mon, 13 Dec 2021 05:45:01 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, jakanakaevangeli@chiru.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov [2021-12-13 05:45:01] wrote: > On 10.12.2021 16:10, Stefan Monnier wrote: >> Hmm... capf itself tries to "solve" that problem in the following way: > The problem with this approach is that pcomplete-completion-at-point behaves > properly most of the time, and only "misbehaves" after some > particular inputs. The quotes around "solve" intended to say that I'm quite aware it's not a full solution. But it's also not cast in stone. So whichever better/additional workaround you come up with might be welcome in `minibuffer.el`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 22 22:23:55 2022 Received: (at 50470) by debbugs.gnu.org; 23 Jan 2022 03:23:55 +0000 Received: from localhost ([127.0.0.1]:38339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBTTu-0007me-Nj for submit@debbugs.gnu.org; Sat, 22 Jan 2022 22:23:55 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBTTs-0007m9-Oo for 50470@debbugs.gnu.org; Sat, 22 Jan 2022 22:23:53 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3920E100189; Sat, 22 Jan 2022 22:23:46 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 6FD83100134; Sat, 22 Jan 2022 22:23:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1642908224; bh=HZuJvKD3Dtw4TxQZr6P3GMw9DuzhCNI1ixYRGmwZ+Nw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mJJuX/SwsCziNuOzPtq6ZBxjaWjNId4snT0UNEt/tE8ESfVVH0vymo03Whhfms05+ 36necgjxrTQThq8EK1Q6ovlDDS+WQAl1L7pwFN2pDZzeaMZIgn3ZDGjRxbZ7hxg1Dp pxd3axsEQJu5yRcYv1fLH/LMzfR49SUr08p8rZLZD2FaMp0mAagPlxU1RQR+oKysp0 JXLfITB/L+p4cvE/MCL5TDeq8mGIeoyXmPctWDVeTObjdQJTsqVvEosG3xdKwSYBdP Ok+8YJAAVGKpcvyzXuaz7FFnSOgPKa9KQVAHYVGf1O8/BRJUBo2yb/ogy5Uuj85D9n TF16P4UgvDeng== Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1B8AC1206A6; Sat, 22 Jan 2022 22:23:44 -0500 (EST) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> Date: Sat, 22 Jan 2022 22:23:42 -0500 In-Reply-To: <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Dec 2021 01:06:33 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Some new details, from > https://github.com/company-mode/company-mode/discussions/1276: > > When this happens (the user types a quote character and the tab character is > inserted), there is a message in the echo area: > > Completion function pcomplete-completions-at-point uses a deprecated > calling convention > > I'm going to add Stefan to Cc in case maybe he had a quick fix in mind, > since I saw him reply to a similar-ish bug report about > pcomplete integration. I think I managed to reproduce the problem and get a good backtrace for the above with: src/emacs -Q -l .../company/company-autoloads.el \ -f eshell -f company-mode \ --eval '(advice-add `pcomplete-completions-at-point :around (lambda (orig-fun &rest args) (let ((buffer-read-only t) (debug-on-signal t)) (apply orig-fun args))))' \ --eval '(setq debug-on-error t debug-on-signal nil debug-ignored-errors nil)' \ -l company.el \ --eval "(progn (sit-for 1) (insert \"echo '\") \ (company-idle-begin (current-buffer) \ (selected-window)\ (buffer-chars-modified-tick)\ (point)))" And the 100% untested patch below is a suggestion for how to try and fix those kinds of bugs. Can someone try and maybe make it work? Stefan diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index c6a51b1793..bc35c92493 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -311,18 +311,24 @@ eshell-completion-help (describe-prefix-bindings) (call-interactively 'pcomplete-help))) +(defun eshell--pcomplete-insert-tab () + (if (not pcomplete-allow-modifications) + (throw 'pcompleted nil) + (insert-and-inherit "\t") + (throw 'pcompleted t))) + (defun eshell-complete-parse-arguments () "Parse the command line arguments for `pcomplete-argument'." (when (and eshell-no-completion-during-jobs (eshell-interactive-process)) - (insert-and-inherit "\t") - (throw 'pcompleted t)) + (eshell--pcomplete-insert-tab)) (let ((end (point-marker)) (begin (save-excursion (eshell-bol) (point))) (posns (list t)) args delim) - (when (memq this-command '(pcomplete-expand - pcomplete-expand-and-complete)) + (when (and pcomplete-allow-modifications + (memq this-command '(pcomplete-expand + pcomplete-expand-and-complete))) (run-hook-with-args 'eshell-expand-input-functions begin end) (if (= begin end) (end-of-line)) @@ -335,14 +341,11 @@ eshell-complete-parse-arguments (setq begin (1+ (cadr delim)) args (eshell-parse-arguments begin end))) ((eq (car delim) ?\() - (eshell-complete-lisp-symbol) - (throw 'pcompleted t)) + (throw 'pcompleted (elisp-completion-at-point))) (t - (insert-and-inherit "\t") - (throw 'pcompleted t)))) + (eshell--pcomplete-insert-tab)))) (when (get-text-property (1- end) 'comment) - (insert-and-inherit "\t") - (throw 'pcompleted t)) + (eshell--pcomplete-insert-tab)) (let ((pos begin)) (while (< pos end) (if (get-text-property pos 'arg-begin) diff --git a/lisp/pcomplete.el b/lisp/pcomplete.el index 289312e0bb..f9c5b00719 100644 --- a/lisp/pcomplete.el +++ b/lisp/pcomplete.el @@ -189,6 +189,16 @@ pcomplete-expand-before-complete `pcomplete-parse-arguments-function'." :type 'boolean) +(defvar pcomplete-allow-modifications nil + "If non-nil, allow effects in `pcomplete-parse-arguments-function'. +For the `pcomplete' command, it was common for functions in +`pcomplete-parse-arguments-function' to make modifications to the +buffer, like expanding variables are such. +For `completion-at-point-functions', this is not an option any more, so +this variable is used to tell `pcomplete-parse-arguments-function' +whether it can do the modifications like it used to, or whether +it should refrain from doing so.") + (defcustom pcomplete-parse-arguments-function #'pcomplete-parse-buffer-arguments "A function to call to parse the current line's arguments. @@ -392,6 +402,9 @@ pcomplete-completions-at-point ;; imposing the pcomplete UI over the standard UI. (catch 'pcompleted (let* ((pcomplete-stub) + (buffer-read-only + ;; Make sure the function obeys `pcomplete-allow-modifications'. + (if pcomplete-allow-modifications buffer-read-only t)) pcomplete-seen pcomplete-norm-func pcomplete-args pcomplete-last pcomplete-index (pcomplete-autolist pcomplete-autolist) @@ -526,6 +539,7 @@ pcomplete pcomplete-last-completion-raw nil) (catch 'pcompleted (let* ((pcomplete-stub) + (pcomplete-allow-modifications t) pcomplete-seen pcomplete-norm-func pcomplete-args pcomplete-last pcomplete-index (pcomplete-autolist pcomplete-autolist) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 23 20:51:11 2022 Received: (at 50470) by debbugs.gnu.org; 24 Jan 2022 01:51:12 +0000 Received: from localhost ([127.0.0.1]:41576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBoVj-0003KL-Is for submit@debbugs.gnu.org; Sun, 23 Jan 2022 20:51:11 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:43864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBoVg-0003Jz-0V for 50470@debbugs.gnu.org; Sun, 23 Jan 2022 20:51:10 -0500 Received: by mail-ej1-f50.google.com with SMTP id d10so17169466eje.10 for <50470@debbugs.gnu.org>; Sun, 23 Jan 2022 17:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zYRChrpv1Bl/uxyhuo63qlE00b6K8fT7EgtEiJ4OTBM=; b=i8k/AjAFosFn5sIsu/iA9Sd5T0aS8imOTupzsTQyUQ3hBHSXTUKpg0frjlt/DrEIvJ Hw8NZUX5tCuPURnVU6cmTph0kuUnatC/JDwysrpbMP+ebYihBY4ZrHHYyWcSHpAx45WB Zl2Hh9O2P7PZA9a6EWhAE3zwLr6doDFvZOgHRoIJTvjMSH0jwhbw+s0tIQc40tRIGma4 P5oVS3yqvIqIy0WjnhJerrJTLvPbuZfmFb96i7/Uwk/ql+nw7m8uwlKWPESEQt/jlPbu /kPPL5HIA6O1glWf42OwNk+xj00UUvwFhkBbkBUwsjuZHyrbKm4QyN9S1p/o4pmiFliu zdRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zYRChrpv1Bl/uxyhuo63qlE00b6K8fT7EgtEiJ4OTBM=; b=ZvLBoKhk4TGBjXzb8qvLIZ+EcnTmeB4Afv7BPQbDHp9r9H3AZeP21S2duz8pg7wGuQ iZxRxLo0faMBksEGIGNhvzdiAtz9FRFqhdJhlVNIyjC73vZ8XEHQtwPkqLRPjju2K8Kf DjkAeHXxF2DFon5+a9PjVr6noXVBusOk+OpHDlbntsQP8vWAhIvRuF5jQapy1zuD6+TO 9+LrgLEK0/lM1CDZv5jv0n0waTAQSCA34hkTDhKn63R1BI4WXO9ecWvJmfVy3v/IhKtK 4VxGngz+GDybJ7E9+ewYaRZ32Q6jZIx5pMuNGIYtAHBmWL8KwoX7WYBMs0g06MNlywVv gswg== X-Gm-Message-State: AOAM533maF2kx5aOIr9/0oqiUqK478+YszfMAjGanWiavtXLdwN40bTc 9mg/dyhM/ZIGDBKeG+UhI7CDs2Htbs023A== X-Google-Smtp-Source: ABdhPJzjvojCEy73p5lzWllUdXs9dEUt0wSdV55ZC5a9xFKB8gOr0juK8KCwB6CPWHM8fRCGnZQ6qw== X-Received: by 2002:a17:907:e8d:: with SMTP id ho13mr20569ejc.169.1642989061892; Sun, 23 Jan 2022 17:51:01 -0800 (PST) Received: from [10.111.160.185] ([185.213.155.232]) by smtp.googlemail.com with ESMTPSA id bm13sm5708383edb.67.2022.01.23.17.51.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jan 2022 17:51:01 -0800 (PST) Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> From: Dmitry Gutov Message-ID: <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> Date: Mon, 24 Jan 2022 03:50:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) Hi Stefan, On 23.01.2022 05:23, Stefan Monnier wrote: > And the 100% untested patch below is a suggestion for how to try and fix > those kinds of bugs. > Can someone try and maybe make it work? I've tried the patch, and it seems to work already, as well as fix this particular scenario. (Thanks!) Might as well install it, I think. There is a scenario that is more noticeably broken (yet actually better with this patch): a modification of bug#18951. Instead of ls * try ls ~/Docu* ...and [on master] the result is that the asterisk is replaced with the "common part" of the possible completions automatically. If there is nothing to expand with, the asterisk is similarly deleted. With your patch, we get the "Buffer is read-only" error in *Messages* instead, which is probably an improvement. Because it doesn't modify the input, nor break Company completions long-term (after the asterisk is removed). The offending functions is pcomplete-parse-arguments. There is some complex global state going on there, but the following addition seems to fix the problem: @@ -790,6 +804,9 @@ pcomplete-parse-arguments (common-stub (car completions)) (c completions) (len (length common-stub))) + (unless pcomplete-allow-modifications + (setq pcomplete-stub (buffer-substring begin (point))) + (throw 'pcomplete-completions completions)) (while (and c (> len 0)) (while (and (> len 0) (not (string= Not sure if this new value of pcomplete-stub is always TRT, but it has passed a bunch of my experiments successfully. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 25 18:06:13 2022 Received: (at 50470) by debbugs.gnu.org; 25 Jan 2022 23:06:13 +0000 Received: from localhost ([127.0.0.1]:50472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCUtA-0005X0-Ux for submit@debbugs.gnu.org; Tue, 25 Jan 2022 18:06:13 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCUt7-0005Wk-E2 for 50470@debbugs.gnu.org; Tue, 25 Jan 2022 18:06:11 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 64EC2805EF; Tue, 25 Jan 2022 18:06:03 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A8576804FC; Tue, 25 Jan 2022 18:06:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1643151961; bh=4sLLr668qOsoqYYc/n9LhyOh7vWa70pr7c6tT+LUJLk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GuJecvtSvTjHBQN2H7kXZKyGzVOlWWTl4CdQeUAfnt2apBRvEpEo6XcqrDh5AzOth NIaJ1msZLV5sAdTXHtCHxT9UM2D/Lzp78ad3h110oMa8sypMVrZ7C1eG6hbn0NZA3V vemiy7J6Dn+bsyMhvH39+GaMtLgjB8QT2w7SaMKYtE3oROelIGXxjUumHVBac/Vryf nlHiPYpQciX03qEvKjPg4HEHQZ7+FZkRXBTy4zMkDXEZqi4XI07kqGsmsicxNhP3j5 knhAI9/2lOTn5hYJDKAQ9eBgC0/2rlJBwt6FpVm8m7cJSOpZ3TuQYL7QoFrcV5WASn 2Wf1DK1h7ZbYg== Received: from pastel (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5872A1204D4; Tue, 25 Jan 2022 18:06:01 -0500 (EST) From: Stefan Monnier To: John Wiegley Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> Date: Tue, 25 Jan 2022 18:05:59 -0500 In-Reply-To: <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> (Dmitry Gutov's message of "Mon, 24 Jan 2022 03:50:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.139 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi John, Could you explain to me some of the code of `pcomplete-parse-arguments`? I know that was many years ago but hopefully there's still some fond memories of how you designed it. To be honest, the only part I sort-of understand are the first 5-6 lines. Then comes the `(let ((begin (pcomplete-begin 'last)))` and after that I'm lost: it doesn't look like we're parsing arguments any more. E.g. Why/when would pcomplete-stub contain a list rather than a string? Stefan Dmitry Gutov [2022-01-24 03:50:59] wrote: > Hi Stefan, > > On 23.01.2022 05:23, Stefan Monnier wrote: >> And the 100% untested patch below is a suggestion for how to try and fix >> those kinds of bugs. >> Can someone try and maybe make it work? > > I've tried the patch, and it seems to work already, as well as fix this > particular scenario. (Thanks!) > > Might as well install it, I think. > > There is a scenario that is more noticeably broken (yet actually better with > this patch): a modification of bug#18951. Instead of > > ls * > > try > > ls ~/Docu* > > ...and [on master] the result is that the asterisk is replaced with the > "common part" of the possible completions automatically. If there is > nothing to expand with, the asterisk is similarly deleted. > > With your patch, we get the "Buffer is read-only" error in *Messages* > instead, which is probably an improvement. Because it doesn't modify the > input, nor break Company completions long-term (after the asterisk is > removed). > > The offending functions is pcomplete-parse-arguments. There is some complex > global state going on there, but the following addition seems to fix the > problem: > > @@ -790,6 +804,9 @@ pcomplete-parse-arguments > (common-stub (car completions)) > (c completions) > (len (length common-stub))) > + (unless pcomplete-allow-modifications > + (setq pcomplete-stub (buffer-substring begin (point))) > + (throw 'pcomplete-completions completions)) > (while (and c (> len 0)) > (while (and (> len 0) > (not (string= > > > Not sure if this new value of pcomplete-stub is always TRT, but it has > passed a bunch of my experiments successfully. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 18:29:22 2022 Received: (at 50470) by debbugs.gnu.org; 4 Jun 2022 22:29:22 +0000 Received: from localhost ([127.0.0.1]:59749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxcGo-0006DQ-DF for submit@debbugs.gnu.org; Sat, 04 Jun 2022 18:29:22 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:41910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxcGm-0006DD-74 for 50470@debbugs.gnu.org; Sat, 04 Jun 2022 18:29:20 -0400 Received: by mail-wr1-f48.google.com with SMTP id k19so14857160wrd.8 for <50470@debbugs.gnu.org>; Sat, 04 Jun 2022 15:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+b54Yd9DH0OuaK/zRUMHB1mCbqHgp4eniccymX4Zlf4=; b=kibhVVcV47f8FFti5eDesSR2tRSzaj3xNBdcriohxrFO3tUjYsW5kyX/t1SSATvYnZ WPl5mq8W6uOt+uNtnarqdLZcLuSwO4sJH8qjA/x4pZpfL+rQufFA8+EKmDIif3Eieetz q0q5dynAvzJjEd4q5hXMZOi0zf1EKG7wOJMdTqRFseYJNp0eS3HeLCO0qV4SaXjP/cqR hfLnEs8V2fsGq4g19sYG0PD6WQ3/qIwi9NQdrP0sFM8PHcz4MS5nolvqv1fOZi7emsZ2 /S3NzvS5sYaz5ecFYcsDUUcHE+djHMAS9Z5VvvMxa6LGGrAWj4xFcPGT4IVdQX0zkF9t Uo+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+b54Yd9DH0OuaK/zRUMHB1mCbqHgp4eniccymX4Zlf4=; b=eRMXTX7Lfza/LYjpfmfklATNsGuGwAyfL2FAJ471zV66wfk9UzDBTeC7G+9AHYBvDL jBYLI8RrriFLGd5BmwQBJZ1vQKlpZ8WGvJe9/PVOysa4ANkNvrFHOljXO/2DI0lbpeGl WnyxHrKpnHLM1yp0r3uNWyBXzwbqXsH5/mWcgEW2Tg8RPbLC4SFoq6e0WJ+pUfV52f6H D2JPY3v7PJiyyfVxWlu2agGSpvkIpb1BFm8plH35SMD2FU4gH2UYhtbJg+Og6s8HsrGt NXSiyMd/3GznX/uhIzdkRDvk+c+KcGQDqtUw+5NzrHvpi5J2cdRSySwfxzlCcfcw9F7l fehg== X-Gm-Message-State: AOAM530fwFsT8fzTzYdaakhCa01KtcKZ08X9y3KUG15+dy16MITUCr6D QGtWHoYO18ApxEFSjR2D6nY= X-Google-Smtp-Source: ABdhPJwyR0hx3quH/iYbVBrvv0rm9OsSeaLGhyOhajvOPEC1PmIzuz24Ge/KTchdoulWrynl+WSLRQ== X-Received: by 2002:a05:6000:2a2:b0:20f:d7ca:47b with SMTP id l2-20020a05600002a200b0020fd7ca047bmr14450733wry.298.1654381754108; Sat, 04 Jun 2022 15:29:14 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id d14-20020a5d6dce000000b0020c5253d927sm11292650wrz.115.2022.06.04.15.29.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jun 2022 15:29:13 -0700 (PDT) Message-ID: Date: Sun, 5 Jun 2022 01:29:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier , John Wiegley References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) It seems like this bug was fixed in bug#55204? Or at least the problems scenarios are not reproducible anymore. The downside compared to my latest patch is that it actually expanded ~/Downl* into a bunch of completions (and the current behavior is "no completions"), but that seems minor. It might be considered a regression, though. On 26.01.2022 01:05, Stefan Monnier wrote: > Hi John, > > Could you explain to me some of the code of `pcomplete-parse-arguments`? > I know that was many years ago but hopefully there's still some fond > memories of how you designed it. > > To be honest, the only part I sort-of understand are the first > 5-6 lines. Then comes the `(let ((begin (pcomplete-begin 'last)))` and > after that I'm lost: it doesn't look like we're parsing arguments > any more. > > E.g. Why/when would pcomplete-stub contain a list rather than a string? > > > Stefan > > > Dmitry Gutov [2022-01-24 03:50:59] wrote: > >> Hi Stefan, >> >> On 23.01.2022 05:23, Stefan Monnier wrote: >>> And the 100% untested patch below is a suggestion for how to try and fix >>> those kinds of bugs. >>> Can someone try and maybe make it work? >> >> I've tried the patch, and it seems to work already, as well as fix this >> particular scenario. (Thanks!) >> >> Might as well install it, I think. >> >> There is a scenario that is more noticeably broken (yet actually better with >> this patch): a modification of bug#18951. Instead of >> >> ls * >> >> try >> >> ls ~/Docu* >> >> ...and [on master] the result is that the asterisk is replaced with the >> "common part" of the possible completions automatically. If there is >> nothing to expand with, the asterisk is similarly deleted. >> >> With your patch, we get the "Buffer is read-only" error in *Messages* >> instead, which is probably an improvement. Because it doesn't modify the >> input, nor break Company completions long-term (after the asterisk is >> removed). >> >> The offending functions is pcomplete-parse-arguments. There is some complex >> global state going on there, but the following addition seems to fix the >> problem: >> >> @@ -790,6 +804,9 @@ pcomplete-parse-arguments >> (common-stub (car completions)) >> (c completions) >> (len (length common-stub))) >> + (unless pcomplete-allow-modifications >> + (setq pcomplete-stub (buffer-substring begin (point))) >> + (throw 'pcomplete-completions completions)) >> (while (and c (> len 0)) >> (while (and (> len 0) >> (not (string= >> >> >> Not sure if this new value of pcomplete-stub is always TRT, but it has >> passed a bunch of my experiments successfully. > From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 20:17:18 2022 Received: (at 50470) by debbugs.gnu.org; 5 Jun 2022 00:17:18 +0000 Received: from localhost ([127.0.0.1]:59790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxdxG-0001Eu-4B for submit@debbugs.gnu.org; Sat, 04 Jun 2022 20:17:18 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxdxE-0001EU-7g for 50470@debbugs.gnu.org; Sat, 04 Jun 2022 20:17:16 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7AA02810AF; Sat, 4 Jun 2022 20:17:10 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 82F79804E6; Sat, 4 Jun 2022 20:17:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654388228; bh=aU1p6JOh6VnEl0EwyiGlCvPR+YXZl3KpBwEBmnb/kAo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=APxipzOR4ZFpwAF32TRb9dP4FDNxAc8WUahxc6+5k2a6mgNOYIM3GY9FUA01YvrDR qM+Z9AqOqvMmw0TGvt902luf3xuVNO1aIzRgicuQOPpbeW4fHu6O6FwuZQMjNUN1le 3uvE7lLO5aILCJ7oj5ARxQsMXnFGfw/OJbfVPUs6OJBYNlW1AAl366IvyFEuvPe+Xa EbAuyPJIyVLWgGbOi6Z5rAg57IBxdcKpfk2xp44Sk8q0YGN6jKUheGP9Up1/RvexPp Dc0cTi09J6YQt/eansuwicXEHzwgIm3Mapq7qV6mFGjkeihcoRA0d5hhnf5Xhes440 gBiKlbYWiSydQ== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id F22C3120513; Sat, 4 Jun 2022 20:17:07 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> Date: Sat, 04 Jun 2022 20:17:07 -0400 In-Reply-To: (Dmitry Gutov's message of "Sun, 5 Jun 2022 01:29:11 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org, Christophe , John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The downside compared to my latest patch is that it actually expanded > ~/Downl* into a bunch of completions (and the current behavior is "no > completions"), but that seems minor. > > It might be considered a regression, though. AFAIK it is a regression, indeed. I thought you'd install your patch on top. Any reason why you refrained from doing so? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 20:36:42 2022 Received: (at 50470) by debbugs.gnu.org; 5 Jun 2022 00:36:42 +0000 Received: from localhost ([127.0.0.1]:59804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxeG2-0001qu-H1 for submit@debbugs.gnu.org; Sat, 04 Jun 2022 20:36:42 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxeFw-0001qb-S9 for 50470@debbugs.gnu.org; Sat, 04 Jun 2022 20:36:41 -0400 Received: by mail-wr1-f44.google.com with SMTP id x17so15080341wrg.6 for <50470@debbugs.gnu.org>; Sat, 04 Jun 2022 17:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=B11vNmljeao0rjPzlk3B5lneApF2u6tOU8m74upbqTk=; b=ZlPWx4kwHgEznIpiuJj3lW9W7MdU/l/RV07fp17ZAxbSzSIqejMZFzSCj2L6kh1qD9 P3LJhav+CNO87zM8T8tlu4TVCty5foNpwwIkDH3nmp359gbnGYMlxYc+IqiDiemgCGI1 FX5Joc9zGkAiUV4VQZcWLc7cDBUkGROu/IyZlolmd2oVOzV0Mphf1uHxPjJ4eZM3lGxo 9Zw+6qUCCsOI1ik7NrIfN/YumTP/itJsR9zxntAfTpe0NAtiSypE2rdEvpY5GZSNmxIt NUdZ9MQj6d8ucpSkGdoibnMCGKOtsbce8z5mkDSfVOoI89XlgYZ0zieNKgO7AF+Jmgko ERlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=B11vNmljeao0rjPzlk3B5lneApF2u6tOU8m74upbqTk=; b=0x9AasUTnNaWPpGTZUMQycNQdJ+LNXRCJ2cuHn2UdlaM1GIUlzTi0ZYLB5X5AkK+zM vIu0Sr1fso1Y0ZWDNnXEXXHAJ8ztyIL2rvev5aMX0Wymx727sEEXBPKribZsuaqrjzoN iRf+M+7Yd07qDHaFrGVwaAf0xPwhtquVZkJmwfC/1UniDYyX2RYm48NEunfgKWxomvLF sIM/0fkqASM0hsJGnALk5AcFsy22HrRUE8jlUBucm62Kt1LNL0sIAzPZPT/lCojy+oAO PygjzY3U/V5cuK67Se5v46/sbssWGG/Jf/ewNRPm4kS1Z3jFoqrRvfT/4XfQjLQ2Xjh4 e7Dg== X-Gm-Message-State: AOAM530oOYHATIoCteEJ6MuhVWA1EDXGNZxa2oAZK1nVkAbas9lfWBgH tZGn4/PWty/l3xGGnTrA5Gs= X-Google-Smtp-Source: ABdhPJxGrpHjyzv0YherT0wkuX9Y7doOkKY3L9VJI+nA4vVjiSDP6N6jC15fPXcnhF/tqWZOAjI8dw== X-Received: by 2002:a05:6000:1142:b0:216:a390:8616 with SMTP id d2-20020a056000114200b00216a3908616mr3815319wrx.206.1654389390692; Sat, 04 Jun 2022 17:36:30 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f6-20020a05600c154600b00397402ae674sm18618062wmg.11.2022.06.04.17.36.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Jun 2022 17:36:29 -0700 (PDT) Message-ID: <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> Date: Sun, 5 Jun 2022 03:36:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org, Christophe , John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05.06.2022 03:17, Stefan Monnier wrote: >> The downside compared to my latest patch is that it actually expanded >> ~/Downl* into a bunch of completions (and the current behavior is "no >> completions"), but that seems minor. >> >> It might be considered a regression, though. > AFAIK it is a regression, indeed. I thought you'd install your patch > on top. Any reason why you refrained from doing so? Erm, I missed the time when you installed yours: you never wrote about it here, and my "Emacs Diffs" folder still has 738 unread messages. So I figured the fix is due to another bug report and patch. :-/ My patch doesn't help with the 'cd ~/Down*' behavior, though: when I worked on it, pressing C-M-i did expand it as expected, it was mostly problematic with company-mode (and other similar frontends). But now C-M-i results in "No match" as well, with or without my patch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 20:53:28 2022 Received: (at 50470) by debbugs.gnu.org; 5 Jun 2022 00:53:28 +0000 Received: from localhost ([127.0.0.1]:59824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxeWG-0002K0-8X for submit@debbugs.gnu.org; Sat, 04 Jun 2022 20:53:28 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxeWD-0002Jn-Gi for 50470@debbugs.gnu.org; Sat, 04 Jun 2022 20:53:26 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D1CCD807CB; Sat, 4 Jun 2022 20:53:19 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 65BBC8004C; Sat, 4 Jun 2022 20:53:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654390394; bh=c/vhiNkIBjWtChd8UZ7HW2DmTxXh/h8fiYZGQWy/1jE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=I/9aNGq7BFHInnrfutF+hscFBLkCk594sUIJaM8BYT2rXCoGU38dd7bKChG9wYyKO fS20pe+jHPFcxUOzKx3yLGt/lgX+Yff1paKDlhwXAeuHyIBMs0iXmEs/xDNMwx0fn9 OQrb13InFDML6+yUbyVmqwpppNfg1gv+le9DGzVLiluVNcoPAbbIn9oXzM+T7BbE7N rRN0eJvIRF3QQVgzqAIuyRIM4ZlIhX9gptCCK6Zm1QlyXTU9xYlM1uL1Wf6cCG3WKY z9sf5SvrAO2tZm6nK8JR6poN+HbAO1txcRNf8k18WdcQvcCyb1NyeivN7BqZiJl5j8 aobnA9ujwkc+A== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2B563120255; Sat, 4 Jun 2022 20:53:14 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> Date: Sat, 04 Jun 2022 20:53:12 -0400 In-Reply-To: <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> (Dmitry Gutov's message of "Sun, 5 Jun 2022 03:36:27 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: 50470@debbugs.gnu.org, Christophe , John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Erm, I missed the time when you installed yours: you never wrote about > it here, Indeed, I had lost track of this bug (and couldn't find your patch when I looked for it, probably for the same reason). > and my "Emacs Diffs" folder still has 738 unread messages. And you're still here chatting? Kids these days! > My patch doesn't help with the 'cd ~/Down*' behavior, though: when I worked > on it, pressing C-M-i did expand it as expected, it was mostly problematic > with company-mode (and other similar frontends). > > But now C-M-i results in "No match" as well, with or without my patch. Hmm... looks like my lack of understanding of this pcomplete code strikes again. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 19:45:33 2022 Received: (at 50470) by debbugs.gnu.org; 5 Jun 2022 23:45:33 +0000 Received: from localhost ([127.0.0.1]:33713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxzw5-0006ix-84 for submit@debbugs.gnu.org; Sun, 05 Jun 2022 19:45:33 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:39639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxzw3-0006ij-3a for 50470@debbugs.gnu.org; Sun, 05 Jun 2022 19:45:32 -0400 Received: by mail-wm1-f50.google.com with SMTP id l2-20020a05600c1d0200b0039c35ef94c4so4967223wms.4 for <50470@debbugs.gnu.org>; Sun, 05 Jun 2022 16:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WTc1ocos412IOX0Ci4uk/v2jyXisOX0dnMA/6muvqV0=; b=m1wj3dze7ZcKWZBu2268HsAtND1gJA1UHC8nQGoNgz7FRwiQ4eYzsD8nhd+1cct8iU eIG8MuTjSlM+Z1sG9DvwcYDObNMSeAZS0x8kiYL8tIoMNqF9YdO01Y5hZ1pFymxL+ub7 lDxqX8VyDwlQrFw/2X1nZ76/kvq3iJALYvczg6pTvEG6/YNfb533ODlRt83leRm5ou5R z6KLD/AfMxmcs15Xy8pgsbQAxmJIBCKQyuVDrPyK3186O+bN3hMwn6SCyE2r7/JdYM7o Svq7bfHOK1rl+HEZIuFwU1EnxHv7OwX2j8Ea0j+axnkXzaYcueyh9nuTBr/NSUG/U0iE psLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=WTc1ocos412IOX0Ci4uk/v2jyXisOX0dnMA/6muvqV0=; b=MUWf19SKxMFmDC6aaIgftPVAgh6TQWDdumqRWWUEzjYIUml4eZaeyD5gQF0hckeKsS MD5VEor8qzsigLMuiZg55AP3KMBMc2ZO9cze59z/SLcssJXNoYgnHjeTmDeQfkEtlrEX zgXVPn4OrP1UllPYcjAJ3N4JxZ+0gXPKOOfFnXQ/XI4sJIRY0SGUL6qLQn2mpazyjvWL zS6nsp3w1nymhPtQ9HS/D13392Fjzb3u/WqM8ioJM67XgvKS+WVe+Qkmgz1/ZpppukSw 9E+ww5+hLQl3J+E4z1NZ905jDou8WzfiiHtFEhZmkr6Fe99EOYaB7v8lonxE0OmPEaB4 1dKA== X-Gm-Message-State: AOAM531dOAxKQXR9s6hu70nSilxezE9ciLIsq9l7zxplvXGkeHwTdLc2 3Dp+aZLnhCY1sMdHmWng8fk= X-Google-Smtp-Source: ABdhPJzzW5+BG1GAfuU9JToxBJNei6/p1T1IBE/n+m48BMv8uS7F3+7Gbn60NmEZIu0+bXPAeC9uRA== X-Received: by 2002:a05:600c:1d99:b0:397:482b:429 with SMTP id p25-20020a05600c1d9900b00397482b0429mr48363700wms.130.1654472725123; Sun, 05 Jun 2022 16:45:25 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h1-20020a5d4fc1000000b0020fc4cd81f6sm13544174wrw.60.2022.06.05.16.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jun 2022 16:45:24 -0700 (PDT) Message-ID: <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> Date: Mon, 6 Jun 2022 02:45:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 05.06.2022 03:53, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> Erm, I missed the time when you installed yours: you never wrote about >> it here, > > Indeed, I had lost track of this bug (and couldn't find your patch when > I looked for it, probably for the same reason). > >> and my "Emacs Diffs" folder still has 738 unread messages. > > And you're still here chatting? > Kids these days! Aye-aye, cap'n! >> My patch doesn't help with the 'cd ~/Down*' behavior, though: when I worked >> on it, pressing C-M-i did expand it as expected, it was mostly problematic >> with company-mode (and other similar frontends). >> >> But now C-M-i results in "No match" as well, with or without my patch. > > Hmm... looks like my lack of understanding of this pcomplete code > strikes again. Debugging shows that COMPLETIONS just before the bit of code I added gets set to absolute file names. E.g. if I'm typing cd ~/Do* COMPLETIONS is '("/home/dgutov/Documents" "/home/dgutov/Downloads"), which fails to match "~/Do" because we do prefix-matching by default. I suppose whatever code does the expansion here, shouldn't dis-abbreviate the file name (or resolve symlinks, etc). I could find where that logic resides, though. Another issue which made investigating this harder, is that eshell-mode (and only it) has 'C-M-i' bound to eshell-complete-lisp-symbol. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 19:53:07 2022 Received: (at 50470) by debbugs.gnu.org; 5 Jun 2022 23:53:07 +0000 Received: from localhost ([127.0.0.1]:33718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny03P-0006wA-23 for submit@debbugs.gnu.org; Sun, 05 Jun 2022 19:53:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny03L-0006vE-SC for 50470@debbugs.gnu.org; Sun, 05 Jun 2022 19:53:05 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3EB251007FD; Sun, 5 Jun 2022 19:52:58 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8F9B110022E; Sun, 5 Jun 2022 19:52:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654473172; bh=XUjf3FcC6ZTKNaJGlg3bIV95ohUsl5CC+psNrvF0muU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ngH2IZtGm9XtW9O6rDkadyz59ozwlap7F7e2Py3Jtvnsdk9I0JOxAthyv1fo/yy0+ OA4ZjbXEysHSGCh7hRO31T9bVDueTe44x781rwzWaX7EXeXQ6UhStLjmbS6IVTE3s3 +WkdxmBwRYp3w8RW81/bo3kh4XtlGiuGQKbFaseUPD+cZ/+eS7Wbq8KxPPboRtPNQR gskJ0OFoC3rliHH3KmS4I+dDMuqdOHITPot5DaaBOLL4vYJ0uEoPtbfysm3BqOWPAo ooCrJh7G3Pmh43XBro5Ye/Z46Pawq3pG1U4d5mu8huSPoCTOp6jarLaUS6q/0QkaHv Qb/vx1Ig6mGpw== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 48071120225; Sun, 5 Jun 2022 19:52:52 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> Date: Sun, 05 Jun 2022 19:52:51 -0400 In-Reply-To: <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> (Dmitry Gutov's message of "Sun, 5 Jun 2022 03:36:27 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > My patch doesn't help with the 'cd ~/Down*' behavior, though: when I worked > on it, pressing C-M-i did expand it as expected, it was mostly problematic > with company-mode (and other similar frontends). > > But now C-M-i results in "No match" as well, with or without my patch. AFAICT the "no match" is because we have "~/Down*" as the pattern and "/home//Downloads" as one of the proposed completions, and the completion style has no idea how the two can match since it doesn't know we're dealing with files. In any case, I think your change is going in the right direction, so I installed a patch which does basically the same. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 21:34:28 2022 Received: (at 50470) by debbugs.gnu.org; 6 Jun 2022 01:34:28 +0000 Received: from localhost ([127.0.0.1]:33878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny1dU-0000xi-Iq for submit@debbugs.gnu.org; Sun, 05 Jun 2022 21:34:28 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny1dR-0000xS-Ck for 50470@debbugs.gnu.org; Sun, 05 Jun 2022 21:34:27 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B8A8880931; Sun, 5 Jun 2022 21:34:19 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9218080436; Sun, 5 Jun 2022 21:34:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654479258; bh=hqfkb9qFXQdCXH/de3BSJIXuogt2SHha6geDTWhFvcs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=oNo+qX6IYBJYWfNC7DP9CQGzhn+5NMBJLSsbovHH/MmO5vRA3PQ7EBjW5dkNXcIXA 01wFnWRp8BVKncO14ffuJcDdPYwoyAjSxGYIxqPEySoufIIW0iXc5BwHusVnCDFBv0 a4UkyPdpH3ITBsq3JZj5++09SpLyHEMxxIr6ut8T8b8RzXjdEAEclDiKuCJVzt0zI9 6/eQh4/VO/IJr6HJDNNW4GtJDLECwBj6uq3+oEtpu7ZldzD0TzY/t8xa90ta/1h41Z vv1JBS6IE4INrRzgqOYSfX5baipImSsNjKb3SgeRmo218Vfid90dlaZX4nLMV7Q6Jd QkPLlZAuCU31A== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4E7F512049B; Sun, 5 Jun 2022 21:34:18 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> Date: Sun, 05 Jun 2022 21:34:16 -0400 In-Reply-To: <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Jun 2022 02:45:22 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Debugging shows that COMPLETIONS just before the bit of code I added gets > set to absolute file names. E.g. if I'm typing [ I see we got back to this issue at the very same time :-) ] > cd ~/Do* > > COMPLETIONS is '("/home/dgutov/Documents" "/home/dgutov/Downloads"), which > fails to match "~/Do" because we do prefix-matching by default. Yup. We could try and handle this with a `completion-table-subvert` hack like we do in `pcomplete-completions-at-point`. Still, if you remove the ~/ the behavior is still not great: it seems I get "Do*" completed to "Documents/ " where the SPC might not be what I want. Maybe we should return a special completion-table which implements the `backend` style. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 05:08:14 2022 Received: (at 50470) by debbugs.gnu.org; 6 Jun 2022 09:08:14 +0000 Received: from localhost ([127.0.0.1]:34364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny8ib-00047W-RL for submit@debbugs.gnu.org; Mon, 06 Jun 2022 05:08:14 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:55885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny8iV-00047A-Ia for 50470@debbugs.gnu.org; Mon, 06 Jun 2022 05:08:12 -0400 Received: by mail-wm1-f49.google.com with SMTP id a10so4775357wmj.5 for <50470@debbugs.gnu.org>; Mon, 06 Jun 2022 02:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0hbvzzqlrNK5qBaekNgyRttypwY8SfArElfUW4VXudU=; b=TaYJ+6QtzOcMdK9pVQKpHUlOPU33wTNlFsb6iJnjqXAt/ptBTUyKxZFCFRIdQw11U6 hhX9DQnxhZyzN6WGMRi13qCcMlqKEWd/HU3r6xRKlXErV4OYzMAzVofS/BNQvkEGTRu/ 1XzaT5I+vBa4ZS97kQyxC+REQzp210k9yQXXDBwRZpuHRYGvAspGhYcSIFHlMbWpzZwI ipDkfh/u0s42JBcy/pF+EpE+6kPabdPkuhEOe7zUBmQ/fWPlnK1isjwPONetZLI5FQyn hKoICXLyfHqOwyoh50PTYYwPTjmychdZVJ7Qh1xB9Oqfqg5cl6Zdv13bB+bEjwj48q0M xy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0hbvzzqlrNK5qBaekNgyRttypwY8SfArElfUW4VXudU=; b=ZIQdx21KueRyO9am7oBI1x6Q1VkH8HWTqbKPrvxITZI7mguQUsDkbaEVQDXmQXt2/A gN399MaGRVEfdw7377WIKjJz6xxtaI5U6b5hmqpbbsbSwGE0O1ACz1Ev2G95Z3ZylY1u 064lJkGLjKhrFdQWF41jJGpl8iqaedb50PiWV5/8hzr8N27oed2g6dvE8ivv/lG0ejzD xRHvR97HuvYVNDQhPzrRF/Z66sbMgIDBKhxkxh8L/nKgrUvJ8nDSR1Umt1RoAAhxCQu9 NZ6MjUsV2bKFFaE+HBMSk1PPG2RqLVM/95dBTqI5Cbmx77Dq8PJfdmyqXYrXKVqUSrmG TzCg== X-Gm-Message-State: AOAM531Qx18eytvGzK9mhQpa6qQiDkxdfRN3W//wfuHekTCyf/JhMcXS qMM/BcVUSgiSs1FypZT++Ds= X-Google-Smtp-Source: ABdhPJzTt8gp0yI+MhYJN4f0hpmbAbfzWM7J/wZW1ObZYw9pr+K6V2NreABlViCOXHRpnBVp5PgVGw== X-Received: by 2002:a05:600c:19cb:b0:397:51db:446f with SMTP id u11-20020a05600c19cb00b0039751db446fmr51043907wmq.182.1654506481524; Mon, 06 Jun 2022 02:08:01 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u10-20020adfdd4a000000b002102cc4d63asm17197268wrm.81.2022.06.06.02.07.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jun 2022 02:08:00 -0700 (PDT) Message-ID: <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> Date: Mon, 6 Jun 2022 12:07:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06.06.2022 04:34, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Still, if you remove the ~/ the behavior is still not great: it seems I get > "Do*" completed to "Documents/ " where the SPC might not be what I want. I think that space comes from exit-function (defined at the end of pcomplete-completions-at-point). So it should be orthogonal to the contents of the completion table. The file names in COMPLETIONS inside pcomplete-parse-arguments come without trailing space. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 11:53:00 2022 Received: (at 50470) by debbugs.gnu.org; 7 Jun 2022 15:53:00 +0000 Received: from localhost ([127.0.0.1]:41197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nybVq-0005Wo-6p for submit@debbugs.gnu.org; Tue, 07 Jun 2022 11:53:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nybVc-0005WL-MB for 50470@debbugs.gnu.org; Tue, 07 Jun 2022 11:52:56 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 192F6101045; Tue, 7 Jun 2022 11:52:39 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8E59410022E; Tue, 7 Jun 2022 11:52:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654617157; bh=trQNF7lC3dPoWIUh+c5NiAqM9tiEP455EKFTS52b5cw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=avLX+973biHRfY9i7hjdMTKXJmz5YQJTcTsu92daWOoGwiUnMQZaEsswpqHkUuASX V0UXhbvoT8rX7A4S8JKhXAxBLgn5s2axYfkQgJWAUbLxMlw00WtNyGl8xsFa76TBCs aBW5v3+CsPKtLqBaWWNxfa99CzuB7TB3tac2JWPg/40lFKb+NJtidD2aSTdhb/Lom7 3frVXVWBTplYykMWwm7EPTVNMxqhM7JD2apED6Xwe6ISctXNv1rgD+1dVieJ9vlpK6 bP0Hs6RD1yb2JpIJNxXwZ6GulQtZZVAgrVKRnug9Ue4vs3kQiegeDYSQW+oI0fVm7h 1fvTU13RzG6Fg== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5DBBD12049B; Tue, 7 Jun 2022 11:52:37 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> Date: Tue, 07 Jun 2022 11:52:36 -0400 In-Reply-To: <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> (Dmitry Gutov's message of "Mon, 6 Jun 2022 12:07:58 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dmitry Gutov [2022-06-06 12:07:58] wrote: > On 06.06.2022 04:34, Stefan Monnier via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: >> Still, if you remove the ~/ the behavior is still not great: it seems I get >> "Do*" completed to "Documents/ " where the SPC might not be what I want. > > I think that space comes from exit-function (defined at the end of > pcomplete-completions-at-point). > So it should be orthogonal to the contents of the completion table. Right, but when we complete file names in Eshell, the behavior is better, because the exit-function is different. I don't think there's much we can do about it within `pcomplete.el`, tho. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 18:10:48 2022 Received: (at 50470) by debbugs.gnu.org; 7 Jun 2022 22:10:48 +0000 Received: from localhost ([127.0.0.1]:41833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyhPT-0000jx-Th for submit@debbugs.gnu.org; Tue, 07 Jun 2022 18:10:48 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:46647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyhPR-0000jU-9Z for 50470@debbugs.gnu.org; Tue, 07 Jun 2022 18:10:46 -0400 Received: by mail-wr1-f48.google.com with SMTP id u8so21579615wrm.13 for <50470@debbugs.gnu.org>; Tue, 07 Jun 2022 15:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hUq8OcPhv3jFHfnI4Ger+VbaYiE63WAzHH4VwZmoxqw=; b=A8R86aDkHyvqN82CO4pmGBZTBcgxY7GpfnyPCDoMNlqUbv8dordEwiqm87S2UMfrtO RU39hdqHsrp6EaGJDkbnBGufsB2MNK7FuvGwV/J/9THMO3Gh4XbH3xtGG0JuYW6KLpvr OZLCepxTx3HiMQKi4X/5tmH0fLAmCXObISuEtD+ZuF9JSEwsP2Qv437yM7iPfswdNSkf JdyDsLNLItmD9uV7/8PN+QcsD1LEX2h6eRJXFyRFEkGziRBx7Php6V7y3n4tXuVDFVyq Of4shEbz+sqUkqeYABFAKEum2GIi7hwzO2KYrsaB0KZ388e0HcJUgvbK/mE2H7Ojx3q8 YXtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hUq8OcPhv3jFHfnI4Ger+VbaYiE63WAzHH4VwZmoxqw=; b=4psQA0bp9G9YoYAVe1LuYIjETc9oRWoOwe9yqjWrFcG9tbt14aypvGNb7cBYdFWsMg v5cQ6ICMWR2e6hb0fdtIUz55wlF9PqtJbJlY8CSZBlVgKv5ncmf53a2trc94WMaWXS7z et4UKB2kh7c9ngGbeRsoricw+EgeA5F6JB9opy1pgTztGPImm5Qc0ilY5A5ZgFCR1w5R tNE8Hp2uAMkZIVMsYUamgRdRkElvDlmxwDs3e8+EVyyEVq+ug8aAR0zv1H//ycKhUzJU R3gQmOl6UVdflVbJdNrRHSHP/pM60VaiSlaTieEyF308x0qholweMzlLtBzxCfuIWcw/ ZMkQ== X-Gm-Message-State: AOAM532bZDbOluA5HmHor0hFndczurFDj6n3WGXSBk55E/Xw1M7Y1VbV o/yly1oQAc3fVH7BIMyfblc= X-Google-Smtp-Source: ABdhPJyTyCkAWs91QBWNTn5Uv1wSOBMP0pyMlcwaFKCJzKafGAPil9HJnxFB4DbtOKyPHbUCRTfzQg== X-Received: by 2002:a05:6000:1445:b0:20f:e3f6:ee34 with SMTP id v5-20020a056000144500b0020fe3f6ee34mr29515030wrx.270.1654639839403; Tue, 07 Jun 2022 15:10:39 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h13-20020a5d430d000000b002130f1dfe0bsm17095596wrq.74.2022.06.07.15.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 15:10:38 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 01:10:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06.06.2022 02:52, Stefan Monnier wrote: > In any case, I think your change is going in the right direction, so > I installed a patch which does basically the same. I've pushed a fix for that ('pcomplete-completions needs to be a list of completions AFAICT). From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 18:39:16 2022 Received: (at 50470) by debbugs.gnu.org; 7 Jun 2022 22:39:16 +0000 Received: from localhost ([127.0.0.1]:41885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyhr2-0003cJ-Ek for submit@debbugs.gnu.org; Tue, 07 Jun 2022 18:39:16 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:36704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyhqy-0003c4-3V for 50470@debbugs.gnu.org; Tue, 07 Jun 2022 18:39:14 -0400 Received: by mail-wm1-f44.google.com with SMTP id h62-20020a1c2141000000b0039aa4d054e2so12459979wmh.1 for <50470@debbugs.gnu.org>; Tue, 07 Jun 2022 15:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z6Fnm0Y8jk84qXKR9lh16XC9DaQitoUyfCdFTezOUio=; b=NbIKesoGFG8JqBT5pQ8ZZJvSR2eWrrQqY8F2aNnheH/n13CcyBLojV5Qlh29OWbm7B CcTXOmRCY8Es9vS9TSQzfOoEQ6BlMyJeEAPaSEIVRXvoH/YRFkJjpBJjJ0mMVTO7+bz5 HjvYm2kzh3CqGrcwqnN/B6cAh+1vRljZ4UTaIlT5BIZZo961fhBvNHMBNh2zJUXoOMhm NGBwPcz6ccanISy3FcSnGm+pKCIEcF44saOCGIrZyql5i08jxQdUOvghKH2zJpMbpXAO na3TV4epIHGp75bVYPLKvzlishdJkBfpl4il2C/UkZsxYntNRJPabve+7lHnK6+hykvi /aJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z6Fnm0Y8jk84qXKR9lh16XC9DaQitoUyfCdFTezOUio=; b=jbJJ14TnI/14SGIleHCwQrakg1iRzyI2DCG3eNKSYffCFflB82SQ4wJARPRgTUr4lS WAZ8vK3tOniULE5Gy5nDan42UB745/FAPworgRpLac1X9oB+q372WHopjlspIg1JIgUU Ut9lcZQqzWQ+0HMQ9ysIQYTKncGVT8ZAa6Vxu+AiwNOIBr/a4JajmCUYrqt1yJZD7V6B kZpl6NsLnCdxynZtDgnO7Y7wFKMOeuobh6MTr4kYdbSezY39V+TT4dnVOHeUNepmq+hL dQu2Kjbuvd7+oh52JmfIQPgBUaM8sZTVzgRCVO30uXj4zwY53moQt6vALZJPNdWsqQ33 EwEg== X-Gm-Message-State: AOAM530A8QL8t685YHmBFutb2seAL54LZGMzPIaWpGGPNweNclrU7tkl 9VUwWjgpwfAb4Jh9vekPoKM= X-Google-Smtp-Source: ABdhPJyZYmohm8NGzDa5EBdBTsjxAhrTrSE13M1rjZPluTqotZSftzIl0c+hSj9TZXFDV6E6ra8kgQ== X-Received: by 2002:a05:600c:34cf:b0:39c:4dfb:1398 with SMTP id d15-20020a05600c34cf00b0039c4dfb1398mr14929682wmq.133.1654641546152; Tue, 07 Jun 2022 15:39:06 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w25-20020a7bc759000000b0039c5645c60fsm4854657wmk.3.2022.06.07.15.39.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 15:39:05 -0700 (PDT) Message-ID: Date: Wed, 8 Jun 2022 01:39:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 07.06.2022 18:52, Stefan Monnier wrote: > Dmitry Gutov [2022-06-06 12:07:58] wrote: >> On 06.06.2022 04:34, Stefan Monnier via Bug reports for GNU Emacs, the Swiss >> army knife of text editors wrote: >>> Still, if you remove the ~/ the behavior is still not great: it seems I get >>> "Do*" completed to "Documents/ " where the SPC might not be what I want. >> I think that space comes from exit-function (defined at the end of >> pcomplete-completions-at-point). >> So it should be orthogonal to the contents of the completion table. > Right, but when we complete file names in Eshell, the behavior is > better, because the exit-function is different. I don't think there's > much we can do about it within `pcomplete.el`, tho. I'm sorry, I don't understand. pcomplete-completions-at-point is the completion function used for Eshell, and the exit-function it defines at the end is the one that inserts the spaces. So... which behaviors are you comparing? Speaking of trying to use completion-table-subvert, it doesn't seem obvious which value to use as S2. What we have is a list of strings, and the common prefix isn't going to always match the (unexpanded) input. pcomplete-completions-at-point somehow has pcomplete-stub pointing to the necessary value (e.g. "/home/dgutov/Do") in the asterisk-less cases (due to some other code path being taken), but not in this specific one. Conceptually, it seems easier and cleaner to avoid expansion in the first place. The patch below does that, though I'm not sure what unwanted side-effects it might have ('cd' still works). In any case, supporting completion with asterisk doesn't seem very useful, given that the user might as well omit that char and get the same list of completions, and typing asterisk in the middle of a work doesn't work. That's where the 'backend' style could help indeed. diff --git a/lisp/eshell/em-dirs.el b/lisp/eshell/em-dirs.el index 5396044d8c..fa504bb618 100644 --- a/lisp/eshell/em-dirs.el +++ b/lisp/eshell/em-dirs.el @@ -204,8 +204,8 @@ eshell-dirs-initialize 'eshell-dirs-substitute-cd) eshell-interpreter-alist))) - (add-hook 'eshell-parse-argument-hook - #'eshell-parse-user-reference nil t) + ;; (add-hook 'eshell-parse-argument-hook + ;; #'eshell-parse-user-reference nil t) (if (eshell-under-windows-p) (add-hook 'eshell-parse-argument-hook #'eshell-parse-drive-letter nil t)) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 02:26:53 2023 Received: (at 50470) by debbugs.gnu.org; 17 Mar 2023 06:26:53 +0000 Received: from localhost ([127.0.0.1]:43476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd3YD-0004VA-Fj for submit@debbugs.gnu.org; Fri, 17 Mar 2023 02:26:53 -0400 Received: from mail-pg1-f177.google.com ([209.85.215.177]:41475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd3YB-0004Uv-27 for 50470@debbugs.gnu.org; Fri, 17 Mar 2023 02:26:51 -0400 Received: by mail-pg1-f177.google.com with SMTP id z10so2304142pgr.8 for <50470@debbugs.gnu.org>; Thu, 16 Mar 2023 23:26:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679034405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=wLV/Qv93LMzBskZJQ5vNkPxAjrKPMhq6VpELTQwjPNs=; b=lNIOjLd7fe/xlLnqqR2mxhSupC7kEbPhxv4RLEZ0iUcWQ7yr2Mw048aQ2sIg0OJbjE q50VV6xnpcGYef446SJEP0MjQlvsnT5dj4PZpbYxpaKse+RK8EP0rwNKndACNTzHDOgA ajL6o1U6heDsM/3mv/YQCAuehkgxvpWuwI+Yqtx0/OfbCpPkfNkCnogqkfIojBieeAJN tX/uApvSI7yrk9EugaD/UCRyL1Z+DuXUTjAZw9JdOxFgn5JDvDdh/264O+0iabDIInH5 guLyKODGEvidiO1eTictIqUKgNmU9/ax8cdhUdoTA+80bjoLZzMW2sYMiWgFbe3WF77x 6g3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679034405; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wLV/Qv93LMzBskZJQ5vNkPxAjrKPMhq6VpELTQwjPNs=; b=C4UkDPVnGSunn0Zs3GAED6KrtTVthdXxUzl1wdHumHHYO7/+HWVe12Dp5bo68DH7xK bHi0WLZptfAj1cHl8FRcVtW4hdmwGJg2Ygty8QRAi38BFuomQt7JItsFQy9l0HoIz30a FNaACjjkAvPfTnHcNq561AFiHDZ221fH8AbRHiUphYvIacFbE9nk23I8War2O4N/eay/ eYzvtIXB04e+ucfrHdv0BM5HWA30d8ic5Z12FeOFRKpH7LVCWeyR+tu0RiprsCOroJ5l JkGXj94Fm/KZFW0t6fsOBcn+hHvKRMY3+rtyOa9jn/CAOfLUCxerRYP/t9JJobN6Iw8S QyCA== X-Gm-Message-State: AO0yUKW3px8c1hxfp0nCA/xM899N0BIhCTWxJgMokzJvYUII/CeGMs0q k19X978UCMUEy5AwbYk1BMM= X-Google-Smtp-Source: AK7set+MVNHcM1Xlk5ZIKQKgnyh348iFAc0AFaxvuceOvZIdYgrBm2BhYatStz9p+RnnDVWHEQ5C0w== X-Received: by 2002:a62:4d41:0:b0:625:e1a3:1323 with SMTP id a62-20020a624d41000000b00625e1a31323mr5056310pfb.14.1679034405122; Thu, 16 Mar 2023 23:26:45 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a6-20020aa780c6000000b005a9ea5d43ddsm741591pfn.174.2023.03.16.23.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 23:26:44 -0700 (PDT) Message-ID: <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> Date: Thu, 16 Mar 2023 23:26:44 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Dmitry Gutov , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I've recently been digging through how Eshell and Pcomplete interact, so I think I understand what's happening here. On 6/7/2022 3:39 PM, Dmitry Gutov wrote: > pcomplete-completions-at-point somehow has pcomplete-stub pointing to > the necessary value (e.g. "/home/dgutov/Do") in the asterisk-less cases > (due to some other code path being taken), but not in this specific one. I believe the problem is that when Eshell parses the command line to figure out what to give Pcomplete, it expands the globs itself, so things get messed up. So we want to prevent glob-expansion before passing to Pcomplete. The below patch does this, but it's probably not the right way to do it. However, it's a simple change, and before I go through the larger effort of a proper patch, I want to be sure I'm actually solving the right thing. For some background/explanation of how I'm thinking we should solve this: in Emacs 30, while fixing some other completion issues, I added 'eshell-complete--eval-argument-form' (Emacs 29 does a similar thing, but the code is in 'eshell-complete-parse-arguments'). We probably want to enhance this function so that it only evaluates Eshell arguments forms that we know are ok. For a fun example of why the current behavior is wrong, try pressing TAB at the end of this command: "cd ${sleep 5; echo Doc}". Yes, it actually *runs* that subcommand before passing it to Pcomplete. :/ -------------------------------------------------- diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index b65652019d4..7168f91d774 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -325,6 +325,10 @@ eshell-complete-parse-arguments (if (= begin end) (end-of-line)) (setq end (point-marker))) + ;; Don't expand globs when parsing arguments; we want to pass any + ;; globs to Pcomplete unaltered. + (let ((eshell-parse-argument-hook (remq #'eshell-parse-glob-chars + eshell-parse-argument-hook))) (if (setq delim (catch 'eshell-incomplete (ignore @@ -341,7 +345,7 @@ eshell-complete-parse-arguments ((member (car delim) '("(" "$(")) (throw 'pcompleted (elisp-completion-at-point))) (t - (eshell--pcomplete-insert-tab)))) + (eshell--pcomplete-insert-tab))))) (when (get-text-property (1- end) 'comment) (eshell--pcomplete-insert-tab)) (let ((pos (1- end))) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 21:01:22 2023 Received: (at 50470) by debbugs.gnu.org; 18 Mar 2023 01:01:22 +0000 Received: from localhost ([127.0.0.1]:45912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdKwj-0007ES-MX for submit@debbugs.gnu.org; Fri, 17 Mar 2023 21:01:21 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:50990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdKwi-0007EF-57 for 50470@debbugs.gnu.org; Fri, 17 Mar 2023 21:01:20 -0400 Received: by mail-wm1-f41.google.com with SMTP id g18so4335828wmk.0 for <50470@debbugs.gnu.org>; Fri, 17 Mar 2023 18:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679101274; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=RSdFIUctdPIL3GiOKhDWpkCgI6ys04ALQxhZx4EWUL0=; b=X2ufl6dqkeA0K+TKaLs7yXKSnskh87zVss50QzDmOsb+lMIeS/7q2RH2kwxFYAzioq m13tuPY09VsjACtzKbllYTfkwGvnaS1jzy/DRk4zVG//P807xdBS94fz/+xBrkoqfOaU 7sM4739oqWq9IVTxrhJ5HFQf1sVNdMZB5wURgwIoZ0M5Debnur89kWrMh/mtdZyTZnd0 U14pKCOXwdMxR+58YI7F0URYC06XNUaNGkoCU5PeW6gK6QE33bdrthaJ8bNnBqN7lkfK qYsZX1vK3YS+2UE5kcTlLe/nK4j5pN6A8tu1YHlHimEjdQ0of0g8z3iHb490PEDWf4vO FAdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679101274; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RSdFIUctdPIL3GiOKhDWpkCgI6ys04ALQxhZx4EWUL0=; b=VkV8Jsj2d4CZYYPHLVBKS7cRzx8i99uLWYaI1TDrXSjY+KBnvZRa/DxMCQJdVRLbwU G2zh92okpuXO2N1zkI67bRA62qR/yG4CWRTL+++bdxzYzM8OqsUullnCZ6kPxrP9vxsf IieWk/jhR8YtsMDKcvLyfdNLq5DLRGn4M4mXkqE9VV8gbTxzOmPOWPx7GnJOJN8cqSIE BKCgtlrexRad9kjYnrmZUmbEbDqpz1VBsvAN+PiOif1wl6wtvv6f4l7CT4Q3PAGB+rh+ lp1emovvFwAio6aVteWRaQV2nzSkdr4ztKyn+036FjYrvXPRLUfaATWHEc2EeqMkweKn yMVg== X-Gm-Message-State: AO0yUKUdTkwNsVspn3Q0yhUU6SuhDK5thP5USs+9QAcfFB2UYelvrCBO Slb3fqJGrvMpG8W1lM9uy24= X-Google-Smtp-Source: AK7set9QnUR7p9wZkOFd6ztD4zRlgisUqkllVrWDNK5EEE3asp1Mu24BlCkcGfA5LrjP+KgCQpWpaA== X-Received: by 2002:a05:600c:4f07:b0:3ed:3cec:d2fc with SMTP id l7-20020a05600c4f0700b003ed3cecd2fcmr9261237wmq.37.1679101273964; Fri, 17 Mar 2023 18:01:13 -0700 (PDT) Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id j8-20020a05600c1c0800b003ebf73acf9asm17091774wms.3.2023.03.17.18.01.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 18:01:13 -0700 (PDT) Message-ID: <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> Date: Sat, 18 Mar 2023 03:01:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Jim Porter , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> From: Dmitry Gutov In-Reply-To: <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 17/03/2023 08:26, Jim Porter wrote: > I've recently been digging through how Eshell and Pcomplete interact, so > I think I understand what's happening here. Thanks! > On 6/7/2022 3:39 PM, Dmitry Gutov wrote: >> pcomplete-completions-at-point somehow has pcomplete-stub pointing to >> the necessary value (e.g. "/home/dgutov/Do") in the asterisk-less >> cases (due to some other code path being taken), but not in this >> specific one. > > I believe the problem is that when Eshell parses the command line to > figure out what to give Pcomplete, it expands the globs itself, so > things get messed up. So we want to prevent glob-expansion before > passing to Pcomplete. > > The below patch does this, but it's probably not the right way to do it. >  However, it's a simple change, and before I go through the larger > effort of a proper patch, I want to be sure I'm actually solving the > right thing. I can't comment on the exact right way to implement this, but the patch does seem to solve the remaining problem here. Which is completion for inputs containing *. The result looks rather nice. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 18 02:37:04 2023 Received: (at 50470) by debbugs.gnu.org; 18 Mar 2023 06:37:04 +0000 Received: from localhost ([127.0.0.1]:46012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdQBc-0007qd-7I for submit@debbugs.gnu.org; Sat, 18 Mar 2023 02:37:04 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:41538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdQBZ-0007q8-TX for 50470@debbugs.gnu.org; Sat, 18 Mar 2023 02:37:02 -0400 Received: by mail-pg1-f175.google.com with SMTP id z10so4054986pgr.8 for <50470@debbugs.gnu.org>; Fri, 17 Mar 2023 23:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679121416; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=YPgxlQHDAYMbnqpmh6Qs2KgItY06VpQbRhkOT74EnAE=; b=JpbxMuTU+685wmaQFpNUNcFWxMl+Q4djsBkNIOmuzyZsirEQt7t+PJD9GBdIUj8O4N /alzhypEjLZyUeqyqnf/TUYkChQE7IUtPNN8SKmOmoDOnWVdYHV28gUH7qZyxvbm6FiK AcJB6edxNt/SpkdRfyzLCnbNw/bGSES2wWhHeJB4l71fig5qA8VmZvhgPgLmDKJLdm6R oBzHNbaWFXHjs0hKDWSxF1ts9cjlRxFV6AfYB8YXm4PuuwZrsuMql25VxnhNquvY2nfn LIrtoaJaynguYzLNE7hwgX89Nc1p/CIGBEllMt2RPIqIbBMk2f90abQY5CK10fsTfeNc VbVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679121416; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YPgxlQHDAYMbnqpmh6Qs2KgItY06VpQbRhkOT74EnAE=; b=evGx+QfViwSyKXt9MW85XEaQPqGImVxgFGYKzZJBZgAqCVJ6roile6FhhUvbAXrXFq FC+LuZ72ENMO6uwcmxHS0BjzCcuRY90oDQGHiK9rjIvoQwKmpwGNjY417n9t/Onq1y9S iSnxLgnOGZPO1Ok4A3BxVeoSQGOewo/xi38sDOQk4my/qlz0UBifX9uCSIZY2vayVGk/ k4dQw/CWq8vY70AVKYfVtFVzgKdiXLnYoE7trPCOxsc4VXUdW12GiUYlbc9AzASUyX0F S/parT6JEOskJRMUlKQLd1JYb6cc5rLoILa9JWzNvvBkkkE3Xu5AQq9nCIBLdT4UUq2i a8XQ== X-Gm-Message-State: AO0yUKX/e3tONc/kZLE9W93tqtGyfPANlNd9qXtDPkwcQxewRwW6S/v1 qrtLmVEkJCtz8DzUur/HdiQ= X-Google-Smtp-Source: AK7set+JFJv9JmdMMx0j0c/1oXob3A63FhYB55vjd3Xy+5a7LynGLXiN84D92SzbZxEKJeoW4eD5OA== X-Received: by 2002:a62:7bd6:0:b0:625:c7ca:d82f with SMTP id w205-20020a627bd6000000b00625c7cad82fmr9102993pfc.18.1679121416049; Fri, 17 Mar 2023 23:36:56 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d19-20020aa78693000000b0061ddff8c53dsm2517472pfo.151.2023.03.17.23.36.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 23:36:55 -0700 (PDT) Message-ID: <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> Date: Fri, 17 Mar 2023 23:36:55 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Dmitry Gutov , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> From: Jim Porter In-Reply-To: <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/17/2023 6:01 PM, Dmitry Gutov wrote: > On 17/03/2023 08:26, Jim Porter wrote: >> The below patch does this, but it's probably not the right way to do >> it.   However, it's a simple change, and before I go through the >> larger effort of a proper patch, I want to be sure I'm actually >> solving the right thing. > > I can't comment on the exact right way to implement this, but the patch > does seem to solve the remaining problem here. Which is completion for > inputs containing *. The result looks rather nice. Excellent. I'll get to work on a final patch then. I have a pretty good idea of some ways to implement it, but it'll definitely need some regression tests to go with it. Hopefully I can get it finished up over the weekend. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 14:39:46 2023 Received: (at 50470) by debbugs.gnu.org; 19 Mar 2023 18:39:46 +0000 Received: from localhost ([127.0.0.1]:52748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxwX-0003nu-MB for submit@debbugs.gnu.org; Sun, 19 Mar 2023 14:39:46 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:46028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxwV-0003nh-CA for 50470@debbugs.gnu.org; Sun, 19 Mar 2023 14:39:44 -0400 Received: by mail-pl1-f169.google.com with SMTP id le6so10328340plb.12 for <50470@debbugs.gnu.org>; Sun, 19 Mar 2023 11:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679251177; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=74wIVpb3o/xobhevhmgD1tZh+1PjIcFA0QgMFElCupY=; b=Uaba5ZUDuRv53cuUfVoeeipqVRr3JlYrnWraG8V2Gz7MD1RvMDjsVhESCFPz5nQsOG tNomSdL/Eowd8hS5+UYqiVT1gqasikkZ+YHTrQYQFqzl90UT8YyulVrTc8iZ3BrEKp3y ndPGVrNUxZPDbsByxjZjNbl1yX8rFi5Bu/O0hlVkPop9QfZLvYNy5cB13kFskDdfrzh+ OPj+Za+MNct9WPgl72mN/tdo4VeRht/FqYxpBqulYDPvK710iCYxuFDwhSc8LkEfd8J6 LbKRoHusK5HFkuATlZ8ino63cKnx0mD3Mr4X4a8/Abv+8DytZqynevU/VsJDDxesPZ8E kafg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679251177; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=74wIVpb3o/xobhevhmgD1tZh+1PjIcFA0QgMFElCupY=; b=y3nJMytk4rOVfKqeXJ8XqwgMiqLcoxzgeEHBONWbloWn9Jq/y6ca49kqfJfbVRtpTO fMCgwv5PFircJTjgl9AuUlz4Ckt+dpy9Pq+bweAAkjkJ8az3LykFSIlomsHmmzCiDo+b 1/5Vmct36q2xinxmuDyAqLI0lBwfDyEoUhc2lJCnikouNyQFZYdKtFEC3RP8zv3WrRfB ZRIa/V3gIOVicNNHA8bNTnfNkvIZeB0l8NutZXzhhEvULwVKgJ0CrORwYylUIUfUtltc NAYCdDDLry1y7DPXAGj/71dwIPLZyBq/cCWZw0PUYNhVN3hxErkREurPLVpfEEAMNw8Z kZow== X-Gm-Message-State: AO0yUKW1XH9JtCyT5vIrjoOLr9m8hMqtLowPHTgalP+5PoHs/mYc5+uL wnPeFh3xPl90gbzwXjmHgk8= X-Google-Smtp-Source: AK7set+FV5sMB9rcIYhNUZWy3Br5bNie2MAVE5tYfuvm7H/6Sq6qUuUwOME7JkNGBtqAK1Rhnjjt0A== X-Received: by 2002:a05:6a20:24a6:b0:d9:3750:3a64 with SMTP id m38-20020a056a2024a600b000d937503a64mr2389515pzd.8.1679251177216; Sun, 19 Mar 2023 11:39:37 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b2-20020a63d802000000b004f2c088328bsm4693178pgh.43.2023.03.19.11.39.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 11:39:36 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------OB0edvFTbjz0HGkd0d0IrHz0" Message-ID: Date: Sun, 19 Mar 2023 11:39:35 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US From: Jim Porter To: Dmitry Gutov , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> In-Reply-To: <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------OB0edvFTbjz0HGkd0d0IrHz0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/17/2023 11:36 PM, Jim Porter wrote: > Hopefully I can get it finished up over the weekend. Ok, here we are. This adds a new defvar called 'eshell-parse-for-completion-p', which Eshell argument parsers can consult to adjust their behavior. In particular, when that variable is true, it means a) don't expand globs (let Pcomplete handle that), and b) return a stub for subcommands and Lisp function forms (we don't want to execute these inadvertently). --------------OB0edvFTbjz0HGkd0d0IrHz0 Content-Type: text/plain; charset=UTF-8; name="0001-Avoid-parsing-some-Eshell-forms-when-performing-comp.patch" Content-Disposition: attachment; filename*0="0001-Avoid-parsing-some-Eshell-forms-when-performing-comp.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3ZjFiY2UxNzY4ZjAwNzJkZDQ2OWY5MDQ3YTU5ZmZkMWZkZThiNGY0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTggTWFyIDIwMjMgMTU6Mzk6NTcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBBdm9pZCBwYXJzaW5nIHNvbWUgRXNoZWxsIGZvcm1zIHdoZW4gcGVyZm9ybWluZyBj b21wbGV0aW9uCgpEdXJpbmcgY29tcGxldGlvbiwgd2Ugd2FudCB0byBldmFsdWF0ZSBtb3N0 IEVzaGVsbCBmb3JtcwooZS5nLiB2YXJpYWJsZSByZWZlcmVuY2VzKSwgYnV0IHNraXAgb3Ro ZXJzIChlLmcuIGdsb2JiaW5nLApzdWJjb21tYW5kcywgTGlzcCBmb3JtcykuICBGb3IgZ2xv YmJpbmcsIHdlIHdhbnQgdG8gcGFzcyB0aGUgbGl0ZXJhbApnbG9iIHRvIFBjb21wbGV0ZSBz byBpdCBjYW4gdXNlIHRoZSBnbG9iIGZvciBzZWxlY3RpbmcgY29tcGxldGlvbgpjYW5kaWRh dGVzLiAgRm9yIHN1YmNvbW1hbmRzIGFuZCBMaXNwIGZvcm1zIGluIHBhcnRpY3VsYXIsIHdl CmVzcGVjaWFsbHkgd2FudCB0byBhdm9pZCBldmFsdWF0aW9uLCBzaW5jZSB0aGV5IGNhbiBw cm9kdWNlIGFyYml0YXJ5CnNpZGUgZWZmZWN0cyEgIChCdWcjNTA0NzApCgoqIGxpc3AvZXNo ZWxsL2VtLWNtcGwuZWwgKGVzaGVsbC1wYXJzZS1mb3ItY29tcGxldGlvbi1wKTogTmV3CnZh cmlhYmxlLi4uCihlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzKTogLi4uIGxldC1i aW5kIGl0IHRvICd0Jy4KCiogbGlzcC9lc2hlbGwvZW0tZ2xvYi5lbCAoZXNoZWxsLXBhcnNl LWdsb2ItY2hhcnMpOgoqIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgKGVzaGVsbC1wYXJzZS12 YXJpYWJsZS1yZWYpOgoqIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgKGVzaGVsbC1wYXJzZS1z dWJjb21tYW5kLWFyZ3VtZW50KQooZXNoZWxsLXBhcnNlLWxpc3AtYXJndW1lbnQpOiBDaGVj ayAnZXNoZWxsLXBhcnNlLWZvci1jb21wbGV0aW9uLXAnLgooZXNoZWxsLWRvLWV2YWwpOiBV c2UgJ2Nhci1zYWZlJyB3aGVuIGNoZWNraW5nIHRoZSBib2R5IG9mIGEgJ2xldCcKZm9ybS4K CiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCihlbS1jbXBsLXRlc3QvcGFy c2UtYXJndW1lbnRzL3VuZXZhbHVhdGVkLXN1YmNvbW1hbmQpCihlbS1jbXBsLXRlc3QvcGFy c2UtYXJndW1lbnRzL3VuZXZhbHVhdGVkLWxpc3AtZm9ybSkKKGVtLWNtcGwtdGVzdC9maWxl LWNvbXBsZXRpb24vZ2xvYiwgZW0tY21wbC10ZXN0L2NvbW1hbmQtY29tcGxldGlvbikKKGVt LWNtcGwtdGVzdC9zdWJjb21tYW5kLWNvbXBsZXRpb24pOiBOZXcgdGVzdHMuCihlbS1jbXBs LXRlc3QvbGlzcC1mdW5jdGlvbi1jb21wbGV0aW9uKTogQ2hlY2sgIiQoZnVuYykiIHN5bnRh eC4KLS0tCiBsaXNwL2VzaGVsbC9lbS1jbXBsLmVsICAgICAgICAgICAgfCAxMyArKysrKy0K IGxpc3AvZXNoZWxsL2VtLWdsb2IuZWwgICAgICAgICAgICB8ICAzICstCiBsaXNwL2VzaGVs bC9lc2gtY21kLmVsICAgICAgICAgICAgfCAyNyArKysrKystLS0tLQogbGlzcC9lc2hlbGwv ZXNoLXZhci5lbCAgICAgICAgICAgIHwgNzggKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLQogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsIHwgNTYgKysrKysrKysr KysrKysrKysrKysrLQogNSBmaWxlcyBjaGFuZ2VkLCAxMjYgaW5zZXJ0aW9ucygrKSwgNTEg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZW0tY21wbC5lbCBiL2xp c3AvZXNoZWxsL2VtLWNtcGwuZWwKaW5kZXggYjY1NjUyMDE5ZDQuLjU3MTRhZWFhYmZiIDEw MDY0NAotLS0gYS9saXNwL2VzaGVsbC9lbS1jbXBsLmVsCisrKyBiL2xpc3AvZXNoZWxsL2Vt LWNtcGwuZWwKQEAgLTg1LDYgKzg1LDE2IEBAIGVzaGVsbC1jbXBsCiAgIDp0YWcgIkFyZ3Vt ZW50IGNvbXBsZXRpb24iCiAgIDpncm91cCAnZXNoZWxsLW1vZHVsZSkpCiAKKzs7OyBJbnRl cm5hbCB2YXJpYWJsZXM6CisKKyhkZWZ2YXIgZXNoZWxsLXBhcnNlLWZvci1jb21wbGV0aW9u LXAgbmlsCisgICJUaGlzIGlzIHNldCB0byB0IGJlZm9yZSBjYWxsaW5nIGBlc2hlbGwtcGFy c2UtYXJndW1lbnRzJyBmb3IgY29tcGxldGlvbi4KK0hvb2tzIGZvciBgZXNoZWxsLXBhcnNl LWFyZ3VtZW50LWhvb2snIHNob3VsZCBjb25zdWx0IHRoaXMgdG8KK2FkanVzdCB0aGVpciBi ZWhhdmlvciB3aGVuIHBhcnNpbmcgYSBjb21tYW5kIGZvciBjb21wbGV0aW9uLCBpZgorbmVj ZXNzYXJ5LiAgRm9yIGV4YW1wbGUsIHN1YmNvbW1hbmRzIHNob3VsZCByZXR1cm4gc29tZSBz dHViCit2YWx1ZSB3aGVuIHRoaXMgaXMgc2V0IHNvIHRoYXQgdGhlIGNvbXBsZXRpb24gY29k ZSBkb2Vzbid0IHRyeSB0bworaW52b2tlIHRoZSBzdWJjb21tYW5kLiIpCisKIDs7OyBVc2Vy IFZhcmlhYmxlczoKIAogKGRlZmN1c3RvbSBlc2hlbGwtY21wbC1sb2FkLWhvb2sgbmlsCkBA IC0zMjgsNyArMzM4LDggQEAgZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cwogICAg IChpZiAoc2V0cSBkZWxpbQogCSAgICAgIChjYXRjaCAnZXNoZWxsLWluY29tcGxldGUKIAkJ KGlnbm9yZQotCQkgKHNldHEgYXJncyAoZXNoZWxsLXBhcnNlLWFyZ3VtZW50cyBiZWdpbiBl bmQpKSkpKQorICAgICAgICAgICAgICAgICAoc2V0cSBhcmdzIChsZXQgKChlc2hlbGwtcGFy c2UtZm9yLWNvbXBsZXRpb24tcCB0KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChlc2hlbGwtcGFyc2UtYXJndW1lbnRzIGJlZ2luIGVuZCkpKSkpKQogICAgICAgICAoY29u ZCAoKG1lbWJlciAoY2FyIGRlbGltKSAnKCJ7IiAiJHsiICIkPCIpKQogCSAgICAgICAoc2V0 cSBiZWdpbiAoMSsgKGNhZHIgZGVsaW0pKQogCQkgICAgIGFyZ3MgKGVzaGVsbC1wYXJzZS1h cmd1bWVudHMgYmVnaW4gZW5kKSkpCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1nbG9i LmVsIGIvbGlzcC9lc2hlbGwvZW0tZ2xvYi5lbAppbmRleCA4YTJiYTEzYjJhZC4uNzUxN2Vl NTc4MzMgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWdsb2IuZWwKKysrIGIvbGlzcC9l c2hlbGwvZW0tZ2xvYi5lbApAQCAtMTYyLDcgKzE2Miw4IEBAIGVzaGVsbC1wYXJzZS1nbG9i LWNoYXJzCiBUaGUgY2hhcmFjdGVyIGlzIG5vdCBhZHZhbmNlZCBmb3Igb3JkaW5hcnkgZ2xv YmJpbmcgY2hhcmFjdGVycywgc28KIHRoYXQgb3RoZXIgZnVuY3Rpb24gbWF5IGhhdmUgYSBj aGFuY2UgdG8gb3ZlcnJpZGUgdGhlIGdsb2JiaW5nCiBpbnRlcnByZXRhdGlvbi4iCi0gICh3 aGVuIChtZW1xIChjaGFyLWFmdGVyKSBlc2hlbGwtZ2xvYi1jaGFycy1saXN0KQorICAod2hl biAoYW5kIChub3QgKGJvdW5kLWFuZC10cnVlLXAgZXNoZWxsLXBhcnNlLWZvci1jb21wbGV0 aW9uLXApKQorICAgICAgICAgICAgIChtZW1xIChjaGFyLWFmdGVyKSBlc2hlbGwtZ2xvYi1j aGFycy1saXN0KSkKICAgICAoaWYgKG5vdCAobWVtcSAoY2hhci1hZnRlcikgJyg/XCggP1xb KSkpCiAJKGlnbm9yZSAoZXNoZWxsLWFkZC1nbG9iLW1vZGlmaWVyKSkKICAgICAgIChsZXQg KChoZXJlIChwb2ludCkpKQpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBi L2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5kZXggOTNmMjYxNjAyMGMuLjljYTNkMDZmYzIy IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxs L2VzaC1jbWQuZWwKQEAgLTY3NSwxMyArNjc1LDE1IEBAIGVzaGVsbC1wYXJzZS1zdWJjb21t YW5kLWFyZ3VtZW50CiAJICAgKG9yICg9IChwb2ludC1tYXgpICgxKyAocG9pbnQpKSkKIAkg ICAgICAgKG5vdCAoZXEgKGNoYXItYWZ0ZXIgKDErIChwb2ludCkpKSA/XH0pKSkpCiAgICAg ICAobGV0ICgoZW5kIChlc2hlbGwtZmluZC1kZWxpbWl0ZXIgP1x7ID9cfSkpKQotCShpZiAo bm90IGVuZCkKLSAgICAgICAgICAgICh0aHJvdyAnZXNoZWxsLWluY29tcGxldGUgInsiKQot CSAgKHdoZW4gKGVzaGVsbC1hcmctZGVsaW1pdGVyICgxKyBlbmQpKQotCSAgICAocHJvZzEK KyAgICAgICAgKHVubGVzcyBlbmQKKyAgICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBs ZXRlICJ7IikpCisgICAgICAgICh3aGVuIChlc2hlbGwtYXJnLWRlbGltaXRlciAoMSsgZW5k KSkKKyAgICAgICAgICAocHJvZzEKKyAgICAgICAgICAgICAgKGlmIChib3VuZC1hbmQtdHJ1 ZS1wIGVzaGVsbC1wYXJzZS1mb3ItY29tcGxldGlvbi1wKQorICAgICAgICAgICAgICAgICAg Iih1bmV2YWx1YXRlZCBzdWJjb21tYW5kKSIKIAkJYChlc2hlbGwtYXMtc3ViY29tbWFuZAot ICAgICAgICAgICAgICAgICAgLChlc2hlbGwtcGFyc2UtY29tbWFuZCAoY29ucyAoMSsgKHBv aW50KSkgZW5kKSkpCi0JICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKSkKKyAgICAg ICAgICAgICAgICAgICwoZXNoZWxsLXBhcnNlLWNvbW1hbmQgKGNvbnMgKDErIChwb2ludCkp IGVuZCkpKSkKKyAgICAgICAgICAgIChnb3RvLWNoYXIgKDErIGVuZCkpKSkpKSkKIAogKGRl ZnVuIGVzaGVsbC1wYXJzZS1saXNwLWFyZ3VtZW50ICgpCiAgICJQYXJzZSBhIExpc3AgZXhw cmVzc2lvbiB3aGljaCBpcyBzcGVjaWZpZWQgYXMgYW4gYXJndW1lbnQuIgpAQCAtNjg5LDE0 ICs2OTEsMTUgQEAgZXNoZWxsLXBhcnNlLWxpc3AtYXJndW1lbnQKIAkgICAobm90IGVzaGVs bC1jdXJyZW50LXF1b3RlZCkKIAkgICAobG9va2luZy1hdCBlc2hlbGwtbGlzcC1yZWdleHAp KQogICAgICAgKGxldCogKChoZXJlIChwb2ludCkpCi0JICAgICAob2JqCisgICAgICAgICAg ICAgKGxpc3AtZm9ybQogCSAgICAgIChjb25kaXRpb24tY2FzZSBuaWwKIAkJICAocmVhZCAo Y3VycmVudC1idWZmZXIpKQotCQkoZW5kLW9mLWZpbGUKLSAgICAgICAgICAgICAgICAgKHRo cm93ICdlc2hlbGwtaW5jb21wbGV0ZSAiKCIpKSkpKQorICAgICAgICAgICAgICAgIChlbmQt b2YtZmlsZSAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRlICIoIikpKSkpCiAJKGlmIChlc2hl bGwtYXJnLWRlbGltaXRlcikKLQkgICAgYChlc2hlbGwtY29tbWFuZC10by12YWx1ZQotICAg ICAgICAgICAgICAoZXNoZWxsLWxpc3AtY29tbWFuZCAocXVvdGUgLG9iaikpKQorICAgICAg ICAgICAgKGlmIChib3VuZC1hbmQtdHJ1ZS1wIGVzaGVsbC1wYXJzZS1mb3ItY29tcGxldGlv bi1wKQorICAgICAgICAgICAgICAgICIodW5ldmFsdWF0ZWQgbGlzcCBmb3JtKSIKKyAgICAg ICAgICAgICAgYChlc2hlbGwtY29tbWFuZC10by12YWx1ZQorICAgICAgICAgICAgICAgIChl c2hlbGwtbGlzcC1jb21tYW5kICcsbGlzcC1mb3JtKSkpCiAJICAoaWdub3JlIChnb3RvLWNo YXIgaGVyZSkpKSkpKQogCiAoZGVmdW4gZXNoZWxsLXNlcGFyYXRlLWNvbW1hbmRzICh0ZXJt cyBzZXBhcmF0b3IgJm9wdGlvbmFsCkBAIC0xMTY4LDcgKzExNzEsNyBAQCBlc2hlbGwtZG8t ZXZhbAogCShzZXRjYXIgKGNkciBhcmdzKSAoZXNoZWxsLWRvLWV2YWwgKGNhZHIgYXJncykg c3luY2hyb25vdXMtcCkpCiAJKGV2YWwgZm9ybSkpCiAgICAgICAgKChlcSAoY2FyIGZvcm0p ICdsZXQpCi0gICAgICAgICh3aGVuIChub3QgKGVxIChjYXIgKGNhZHIgYXJncykpICdlc2hl bGwtZG8tZXZhbCkpCisgICAgICAgICh1bmxlc3MgKGVxIChjYXItc2FmZSAoY2FkciBhcmdz KSkgJ2VzaGVsbC1kby1ldmFsKQogICAgICAgICAgIChlc2hlbGwtbWFuaXB1bGF0ZSAiZXZh bHVhdGluZyBsZXQgYXJncyIKICAgICAgICAgICAgIChkb2xpc3QgKGxldGFyZyAoY2FyIGFy Z3MpKQogICAgICAgICAgICAgICAod2hlbiAoYW5kIChsaXN0cCBsZXRhcmcpCmRpZmYgLS1n aXQgYS9saXNwL2VzaGVsbC9lc2gtdmFyLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApp bmRleCA1ZDYyOTlhZjU2NC4uYjc0MjBmMjQzN2IgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxs L2VzaC12YXIuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApAQCAtNTA3LDEwICs1 MDcsMTIgQEAgZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgogICAoY29uZAogICAgKChlcSAo Y2hhci1hZnRlcikgP3spCiAgICAgKGxldCAoKGVuZCAoZXNoZWxsLWZpbmQtZGVsaW1pdGVy ID9ceyA/XH0pKSkKLSAgICAgIChpZiAobm90IGVuZCkKLSAgICAgICAgICAodGhyb3cgJ2Vz aGVsbC1pbmNvbXBsZXRlICIkeyIpCi0gICAgICAgIChmb3J3YXJkLWNoYXIpCi0gICAgICAg IChwcm9nMQorICAgICAgKHVubGVzcyBlbmQKKyAgICAgICAgKHRocm93ICdlc2hlbGwtaW5j b21wbGV0ZSAiJHsiKSkKKyAgICAgIChmb3J3YXJkLWNoYXIpCisgICAgICAocHJvZzEKKyAg ICAgICAgICAoaWYgKGJvdW5kLWFuZC10cnVlLXAgZXNoZWxsLXBhcnNlLWZvci1jb21wbGV0 aW9uLXApCisgICAgICAgICAgICAgICIodW5ldmFsdWF0ZWQgc3ViY29tbWFuZCkiCiAgICAg ICAgICAgICBgKGVzaGVsbC1hcHBseS1pbmRpY2VzCiAgICAgICAgICAgICAgIChlc2hlbGwt Y29udmVydAogICAgICAgICAgICAgICAgKGVzaGVsbC1jb21tYW5kLXRvLXZhbHVlCkBAIC01 MjcsNDUgKzUyOSw0OSBAQCBlc2hlbGwtcGFyc2UtdmFyaWFibGUtcmVmCiAgICAgICAgICAg ICAgICA7OyBqdXN0IGJlIGpvaW5lZCBiYWNrIHRvZ2V0aGVyIGFmdGVyd2FyZHMuCiAgICAg ICAgICAgICAgICAsKHdoZW4gKGFuZCAobm90IG1vZGlmaWVyLXApIGVzaGVsbC1jdXJyZW50 LXF1b3RlZCkKICAgICAgICAgICAgICAgICAgICcobm90IGluZGljZXMpKSkKLSAgICAgICAg ICAgICAgaW5kaWNlcyAsZXNoZWxsLWN1cnJlbnQtcXVvdGVkKQotICAgICAgICAgIChnb3Rv LWNoYXIgKDErIGVuZCkpKSkpKQorICAgICAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3Vy cmVudC1xdW90ZWQpKQorICAgICAgICAoZ290by1jaGFyICgxKyBlbmQpKSkpKQogICAgKChl cSAoY2hhci1hZnRlcikgP1w8KQogICAgIChsZXQgKChlbmQgKGVzaGVsbC1maW5kLWRlbGlt aXRlciA/XDwgP1w+KSkpCi0gICAgICAoaWYgKG5vdCBlbmQpCi0gICAgICAgICAgKHRocm93 ICdlc2hlbGwtaW5jb21wbGV0ZSAiJDwiKQotICAgICAgICAobGV0KiAoKHRlbXAgKG1ha2Ut dGVtcC1maWxlIHRlbXBvcmFyeS1maWxlLWRpcmVjdG9yeSkpCi0gICAgICAgICAgICAgICAo Y21kIChjb25jYXQgKGJ1ZmZlci1zdWJzdHJpbmcgKDErIChwb2ludCkpIGVuZCkKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiID4gIiB0ZW1wKSkpCi0gICAgICAgICAgKHByb2cx CisgICAgICAodW5sZXNzIGVuZAorICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRl ICIkPCIpKQorICAgICAgKGxldCogKCh0ZW1wIChtYWtlLXRlbXAtZmlsZSB0ZW1wb3Jhcnkt ZmlsZS1kaXJlY3RvcnkpKQorICAgICAgICAgICAgIChjbWQgKGNvbmNhdCAoYnVmZmVyLXN1 YnN0cmluZyAoMSsgKHBvaW50KSkgZW5kKQorICAgICAgICAgICAgICAgICAgICAgICAgICAi ID4gIiB0ZW1wKSkpCisgICAgICAgIChwcm9nMQorICAgICAgICAgICAgKGlmIChib3VuZC1h bmQtdHJ1ZS1wIGVzaGVsbC1wYXJzZS1mb3ItY29tcGxldGlvbi1wKQorICAgICAgICAgICAg ICAgICIodW5ldmFsdWF0ZWQgc3ViY29tbWFuZCkiCiAgICAgICAgICAgICAgIGAobGV0ICgo ZXNoZWxsLWN1cnJlbnQtaGFuZGxlcwogICAgICAgICAgICAgICAgICAgICAgIChlc2hlbGwt Y3JlYXRlLWhhbmRsZXMgLHRlbXAgJ292ZXJ3cml0ZSkpKQotICAgICAgICAgICAgICAgICAo cHJvZ24KLSAgICAgICAgICAgICAgICAgICAoZXNoZWxsLWFzLXN1YmNvbW1hbmQKLSAgICAg ICAgICAgICAgICAgICAgLChsZXQgKChlc2hlbGwtY3VycmVudC1xdW90ZWQgbmlsKSkKLSAg ICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1wYXJzZS1jb21tYW5kIGNtZCkpKQotICAg ICAgICAgICAgICAgICAgIChpZ25vcmUKLSAgICAgICAgICAgICAgICAgICAgKG5jb25jIGVz aGVsbC10aGlzLWNvbW1hbmQtaG9vawotICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsg UXVvdGUgdGhpcyBsYW1iZGE7IGl0IHdpbGwgYmUgZXZhbHVhdGVkCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICA7OyBieSBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJlcyB2 ZXJ5Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBwYXJ0aWN1bGFyIGZvcm1zIGlu IG9yZGVyIHRvIHdvcmsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHByb3Blcmx5 LiAgU2VlIGJ1ZyM1NDE5MC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChm dW5jdGlvbgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsYW1iZGEgKCkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUtZmlsZSAsdGVt cCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aGVuLWxldCAoKGJ1 ZmZlciAoZ2V0LWZpbGUtYnVmZmVyICx0ZW1wKSkpCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChraWxsLWJ1ZmZlciBidWZmZXIpKSkpKSkpCi0gICAgICAgICAg ICAgICAgICAgKGVzaGVsbC1hcHBseS1pbmRpY2VzICx0ZW1wIGluZGljZXMgLGVzaGVsbC1j dXJyZW50LXF1b3RlZCkpKQotICAgICAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkp KQorICAgICAgICAgICAgICAgICAoZXNoZWxsLWFzLXN1YmNvbW1hbmQKKyAgICAgICAgICAg ICAgICAgICwobGV0ICgoZXNoZWxsLWN1cnJlbnQtcXVvdGVkIG5pbCkpCisgICAgICAgICAg ICAgICAgICAgICAoZXNoZWxsLXBhcnNlLWNvbW1hbmQgY21kKSkpCisgICAgICAgICAgICAg ICAgIChpZ25vcmUKKyAgICAgICAgICAgICAgICAgIChuY29uYyBlc2hlbGwtdGhpcy1jb21t YW5kLWhvb2sKKyAgICAgICAgICAgICAgICAgICAgICAgICA7OyBRdW90ZSB0aGlzIGxhbWJk YTsgaXQgd2lsbCBiZSBldmFsdWF0ZWQgYnkKKyAgICAgICAgICAgICAgICAgICAgICAgICA7 OyBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJlcyB2ZXJ5CisgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgcGFydGljdWxhciBmb3JtcyBpbiBvcmRlciB0byB3b3JrCisgICAg ICAgICAgICAgICAgICAgICAgICAgOzsgcHJvcGVybHkuICBTZWUgYnVnIzU0MTkwLgorICAg ICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChmdW5jdGlvbgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAobGFtYmRhICgpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGRlbGV0ZS1maWxlICx0ZW1wKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICh3aGVuLWxldCAoKGJ1ZmZlciAoZ2V0LWZpbGUtYnVmZmVyICx0ZW1wKSkp CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoa2lsbC1idWZmZXIgYnVm ZmVyKSkpKSkpKQorICAgICAgICAgICAgICAgICAoZXNoZWxsLWFwcGx5LWluZGljZXMgLHRl bXAgaW5kaWNlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLGVz aGVsbC1jdXJyZW50LXF1b3RlZCkpKQorICAgICAgICAgIChnb3RvLWNoYXIgKDErIGVuZCkp KSkpKQogICAgKChlcSAoY2hhci1hZnRlcikgP1woKQotICAgIChjb25kaXRpb24tY2FzZSBu aWwKKyAgICAobGV0ICgobGlzcC1mb3JtCisgICAgICAgICAgIChjb25kaXRpb24tY2FzZSBu aWwKKyAgICAgICAgICAgICAgIChyZWFkIChvciAoZXNoZWxsLXVuZXNjYXBlLWlubmVyLWRv dWJsZS1xdW90ZSAocG9pbnQtbWF4KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAoY3Vy cmVudC1idWZmZXIpKSkKKyAgICAgICAgICAgICAoZW5kLW9mLWZpbGUgKHRocm93ICdlc2hl bGwtaW5jb21wbGV0ZSAiJCgiKSkpKSkKKyAgICAgIChpZiAoYm91bmQtYW5kLXRydWUtcCBl c2hlbGwtcGFyc2UtZm9yLWNvbXBsZXRpb24tcCkKKyAgICAgICAgICAiKHVuZXZhbHVhdGVk IGxpc3AgZm9ybSkiCiAgICAgICAgIGAoZXNoZWxsLWFwcGx5LWluZGljZXMKICAgICAgICAg ICAoZXNoZWxsLWNvbW1hbmQtdG8tdmFsdWUKLSAgICAgICAgICAgKGVzaGVsbC1saXNwLWNv bW1hbmQKLSAgICAgICAgICAgICcsKHJlYWQgKG9yIChlc2hlbGwtdW5lc2NhcGUtaW5uZXIt ZG91YmxlLXF1b3RlIChwb2ludC1tYXgpKQotICAgICAgICAgICAgICAgICAgICAgICAgKGN1 cnJlbnQtYnVmZmVyKSkpKSkKLSAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3VycmVudC1x dW90ZWQpCi0gICAgICAoZW5kLW9mLWZpbGUKLSAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNv bXBsZXRlICIkKCIpKSkpCisgICAgICAgICAgIChlc2hlbGwtbGlzcC1jb21tYW5kICcsbGlz cC1mb3JtKSkKKyAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3VycmVudC1xdW90ZWQpKSkp CiAgICAoKGxvb2tpbmctYXQgKHJ4LXRvLXN0cmluZwogICAgICAgICAgICAgICAgICBgKG9y ICInIiAsKGlmIGVzaGVsbC1jdXJyZW50LXF1b3RlZCAiXFxcIiIgIlwiIikpKSkKICAgICAo ZXNoZWxsLXdpdGgtdGVtcC1jb21tYW5kCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxs L2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwK aW5kZXggZWE5MDdmMTk0NWQuLmUwOTc2YzM4MGNiIDEwMDY0NAotLS0gYS90ZXN0L2xpc3Av ZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBs LXRlc3RzLmVsCkBAIC0xMjMsNiArMTIzLDMzIEBAIGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1 bWVudHMvdmFyaWFibGUvc3BsaWNlCiAgICAgICAgICAgICAgIChjYXIgKGVzaGVsbC1jb21w bGV0ZS1wYXJzZS1hcmd1bWVudHMpKQogICAgICAgICAgICAgICAnKCJlY2hvIiAiZm9vIiAi YmFyIikpKSkpKQogCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50 cy91bmV2YWx1YXRlZC1zdWJjb21tYW5kICgpCisgICJUZXN0IHRoYXQgc3ViY29tbWFuZHMg cmV0dXJuIGEgc3R1YiB3aGVuIHBhcnNpbmcgZm9yIGNvbXBsZXRpb24uIgorICAod2l0aC10 ZW1wLWVzaGVsbAorICAgKGluc2VydCAiZWNobyB7ZWNobyBoaX0iKQorICAgKHNob3VsZCAo ZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAgICAgICAgICAgKGNhciAoZXNoZWxsLWNvbXBs ZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICAnKCJlY2hvIiAiKHVuZXZhbHVh dGVkIHN1YmNvbW1hbmQpIikpKSkKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChpbnNlcnQg ImVjaG8gJHtlY2hvIGhpfSIpCisgICAoc2hvdWxkIChlc2hlbGwtYXJndW1lbnRzLWVxdWFs CisgICAgICAgICAgICAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzKSkK KyAgICAgICAgICAgIGAoImVjaG8iICwocHJvcGVydGl6ZSAiKHVuZXZhbHVhdGVkIHN1YmNv bW1hbmQpIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdlc2NhcGVkIHQp KSkpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvdW5l dmFsdWF0ZWQtbGlzcC1mb3JtICgpCisgICJUZXN0IHRoYXQgTGlzcCBmb3JtcyByZXR1cm4g YSBzdHViIHdoZW4gcGFyc2luZyBmb3IgY29tcGxldGlvbi4iCisgICh3aXRoLXRlbXAtZXNo ZWxsCisgICAoaW5zZXJ0ICJlY2hvIChjb25jYXQgXCJoaVwiKSIpCisgICAoc2hvdWxkIChl c2hlbGwtYXJndW1lbnRzLWVxdWFsCisgICAgICAgICAgICAoY2FyIChlc2hlbGwtY29tcGxl dGUtcGFyc2UtYXJndW1lbnRzKSkKKyAgICAgICAgICAgICcoImVjaG8iICIodW5ldmFsdWF0 ZWQgbGlzcCBmb3JtKSIpKSkpCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoaW5zZXJ0ICJl Y2hvIChjb25jYXQgXCJoaVwiKSIpCisgICAoc2hvdWxkIChlc2hlbGwtYXJndW1lbnRzLWVx dWFsCisgICAgICAgICAgICAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRz KSkKKyAgICAgICAgICAgICcoImVjaG8iICIodW5ldmFsdWF0ZWQgbGlzcCBmb3JtKSIpKSkp KQorCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxldGlvbi91bmlxdWUg KCkKICAgIlRlc3QgY29tcGxldGlvbiBvZiBmaWxlIG5hbWVzIHdoZW4gdGhlcmUncyBhIHVu aXF1ZSByZXN1bHQuIgogICAod2l0aC10ZW1wLWVzaGVsbApAQCAtMTUwLDYgKzE3NywxNSBA QCBlbS1jbXBsLXRlc3QvZmlsZS1jb21wbGV0aW9uL25vbi11bmlxdWUKICAgICAgICAgIChm b3J3YXJkLWxpbmUgLTEpCiAgICAgICAgICAoc2hvdWxkIChsb29raW5nLWF0ICJDb21wbGV0 ZSwgYnV0IG5vdCB1bmlxdWUiKSkpKSkpKQogCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0 L2ZpbGUtY29tcGxldGlvbi9nbG9iICgpCisgICJUZXN0IGNvbXBsZXRpb24gb2YgZmlsZSBu YW1lcyB1c2luZyBhIGdsb2IuIgorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGVydC13aXRo LXRlbXAtZGlyZWN0b3J5IGRlZmF1bHQtZGlyZWN0b3J5CisgICAgICh3cml0ZS1yZWdpb24g bmlsIG5pbCAoZXhwYW5kLWZpbGUtbmFtZSAiZmlsZS50eHQiKSkKKyAgICAgKHdyaXRlLXJl Z2lvbiBuaWwgbmlsIChleHBhbmQtZmlsZS1uYW1lICJmaWxlLmVsIikpCisgICAgIChzaG91 bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyBmaSouZWwiKQor ICAgICAgICAgICAgICAgICAgICAiZWNobyBmaWxlLmVsICIpKSkpKQorCiAoZXJ0LWRlZnRl c3QgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxldGlvbi9hZnRlci1saXN0ICgpCiAgICJUZXN0 IGNvbXBsZXRpb24gb2YgZmlsZSBuYW1lcyBhZnRlciBwcmV2aW91cyBsaXN0IGFyZ3VtZW50 cy4KIFNlZSBidWcjNTk5NTYuIgpAQCAtMTU5LDYgKzE5NSwyMSBAQCBlbS1jbXBsLXRlc3Qv ZmlsZS1jb21wbGV0aW9uL2FmdGVyLWxpc3QKICAgICAgKHNob3VsZCAoZXF1YWwgKGVzaGVs bC1pbnNlcnQtYW5kLWNvbXBsZXRlICJlY2hvIChsaXN0IDEgMikgZmkiKQogICAgICAgICAg ICAgICAgICAgICAiZWNobyAobGlzdCAxIDIpIGZpbGUudHh0ICIpKSkpKQogCisoZXJ0LWRl ZnRlc3QgZW0tY21wbC10ZXN0L2NvbW1hbmQtY29tcGxldGlvbiAoKQorICAiVGVzdCBjb21w bGV0aW9uIG9mIGNvbW1hbmQgbmFtZXMgbGlrZSBcImNvbW1hbmRcIi4iCisgICh3aXRoLXRl bXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxl dGUgImxpc3RpZiIpCisgICAgICAgICAgICAgICAgICAibGlzdGlmeSAiKSkpKQorCisoZXJ0 LWRlZnRlc3QgZW0tY21wbC10ZXN0L3N1YmNvbW1hbmQtY29tcGxldGlvbiAoKQorICAiVGVz dCBjb21wbGV0aW9uIG9mIGNvbW1hbmQgbmFtZXMgbGlrZSBcIntjb21tYW5kfVwiLiIKKyAg KHdpdGgtdGVtcC1lc2hlbGwKKyAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFu ZC1jb21wbGV0ZSAieyBsaXN0aWYiKQorICAgICAgICAgICAgICAgICAgInsgbGlzdGlmeSAi KSkpCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWlu c2VydC1hbmQtY29tcGxldGUgImVjaG8gJHsgbGlzdGlmIikKKyAgICAgICAgICAgICAgICAg ICJlY2hvICR7IGxpc3RpZnkgIikpKSkKKwogKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9s aXNwLXN5bWJvbC1jb21wbGV0aW9uICgpCiAgICJUZXN0IGNvbXBsZXRpb24gb2YgTGlzcCBm b3JtcyBsaWtlIFwiIydzeW1ib2xcIiBhbmQgXCJgc3ltYm9sXCIuCiBTZWUgPGxpc3AvZXNo ZWxsL2VzaC1jbWQuZWw+LiIKQEAgLTE3NCw3ICsyMjUsMTAgQEAgZW0tY21wbC10ZXN0L2xp c3AtZnVuY3Rpb24tY29tcGxldGlvbgogU2VlIDxsaXNwL2VzaGVsbC9lc2gtY21kLmVsPi4i CiAgICh3aXRoLXRlbXAtZXNoZWxsCiAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2Vy dC1hbmQtY29tcGxldGUgImVjaG8gKGVzaGVsbC9lY2giKQotICAgICAgICAgICAgICAgICAg ImVjaG8gKGVzaGVsbC9lY2hvIikpKSkKKyAgICAgICAgICAgICAgICAgICJlY2hvIChlc2hl bGwvZWNobyIpKSkKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChzaG91bGQgKGVxdWFsIChl c2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAiZWNobyAkKGVzaGVsbC9lY2giKQorICAgICAg ICAgICAgICAgICAgImVjaG8gJChlc2hlbGwvZWNobyIpKSkpCiAKIChlcnQtZGVmdGVzdCBl bS1jbXBsLXRlc3Qvc3BlY2lhbC1yZWYtY29tcGxldGlvbi90eXBlICgpCiAgICJUZXN0IGNv bXBsZXRpb24gb2YgdGhlIHN0YXJ0IG9mIHNwZWNpYWwgcmVmZXJlbmNlcyBsaWtlIFwiIzxi dWZmZXJcIi4KLS0gCjIuMjUuMQoK --------------OB0edvFTbjz0HGkd0d0IrHz0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 20:31:07 2023 Received: (at 50470) by debbugs.gnu.org; 20 Mar 2023 00:31:07 +0000 Received: from localhost ([127.0.0.1]:53316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe3QY-0000q8-WF for submit@debbugs.gnu.org; Sun, 19 Mar 2023 20:31:07 -0400 Received: from mail-pj1-f42.google.com ([209.85.216.42]:33488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe3QW-0000pb-Hc for 50470@debbugs.gnu.org; Sun, 19 Mar 2023 20:31:05 -0400 Received: by mail-pj1-f42.google.com with SMTP id p13-20020a17090a284d00b0023d2e945aebso12271532pjf.0 for <50470@debbugs.gnu.org>; Sun, 19 Mar 2023 17:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679272258; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=1FuHYcK+MfntQCaNmGcc39hIw+lpFsFTkDTtXHOg0js=; b=bomfTU0LgZWAhes4+dgTJO+0ZM/bHXtFb41IFNO7kySBjw5TYm6A4/66+60x3C9AEK n+XG4dBV5I0fIkeMfwI25Hwzm7Q1k4g3er1NOn6vBnYax/uXSrBMIIVpPAhXfMOuTK2V gOC0S7+YaCNm7s7NWH/fxvXSfxj3IMvUcPHyovDHzmed0lgHNnHjckIX9vGbJxLa7Ajw Bws9btMQdT/vajbyU7jCIauC9Hj7C19JAN3t70AUSc/X5jii4aDg6bb5Aur1oB+Kpd+z +FjgRksv/mA20bdPg+18M7UgAn2UeL3vhvOJEOaHWRKps9XtHr3S5gyOkOw35rluZvaL NaGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679272258; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1FuHYcK+MfntQCaNmGcc39hIw+lpFsFTkDTtXHOg0js=; b=fTEA9UZezY+/ZWO+b5/5a4tiFleyLm2ZPxS5YIFtmueF2FwF+IciX1vjOTBzMXfFSt 6QEzOKvO6QeA18Ur/GJi7B+yNJUj9wduV/nc3pUbJ6DdrmCQjygQr1sDGgrCBe7oCXjS /BGn8bDxdIexG56J6/jMyOMKkV3fvR4PomMcaoXDKd04dWHDMrcmfo3slAmryLGo5lba NY5/qM4k0v0cKHYaZinQtry3LCtOvy09wR9l33Ap227AdQAIvvEj1y7fJy2t7r+9pGTt CFY8wLzS/yHSB61CIwf866GP5H3Lf/GMt6fHD6ZD0A7mHnKSPCKVDKI9MokrpKOYwDGE 2K/g== X-Gm-Message-State: AO0yUKU9ZwLuQa4zep+onGI+eeZjH88d2YCoNM468Y94zNEZNyhrjSAL JSXAyox5tIioLHfEyJRZo7A= X-Google-Smtp-Source: AK7set+DtaCF2TMbl7Ub3ReBPZ5lZcKN3berWPRCnDh28DVq6/31UvqEJjP24nO/iWelI6Altm7BTw== X-Received: by 2002:a05:6a20:4f85:b0:d9:82ac:403b with SMTP id gh5-20020a056a204f8500b000d982ac403bmr1902913pzb.41.1679272258289; Sun, 19 Mar 2023 17:30:58 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x3-20020a62fb03000000b006237b9c1f14sm5086355pfm.121.2023.03.19.17.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Mar 2023 17:30:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------UersodUaJpXhW00Py9QeaF2b" Message-ID: Date: Sun, 19 Mar 2023 17:30:56 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US From: Jim Porter To: Dmitry Gutov , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------UersodUaJpXhW00Py9QeaF2b Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/19/2023 11:39 AM, Jim Porter wrote: > Ok, here we are. Here's an updated patch based on some off-list comments from Stefan. Most of them are just small doc/naming tweaks, but a couple are worth mentioning here, I think: On 3/19/2023 12:15 PM, Stefan Monnier wrote: >> - (when (memq (char-after) eshell-glob-chars-list) >> + (when (and (not (bound-and-true-p eshell-parse-for-completion-p)) > > Can we (cheaply) arrange so that the var is always defined at this > point (same for the other uses further down in the patch)? > Maybe by moving the `defvar` elsewhere (e.g. next to > `eshell-parse-argument-hook`)? It's a bit ugly, but I'm trying to follow the conventions in Eshell: since completion is an optional extension module for Eshell, other modules jump through hoops like this to allow the module to be not-loaded. Another way to do this (arguably more Eshell-y) would be: (when (and (eshell-using-module 'eshell-cmpl) eshell-parsing-for-completion) But that seemed a little overly-verbose for this... >> + (if (bound-and-true-p eshell-parse-for-completion-p) >> + "(unevaluated subcommand)" > > Any reason we don't return the actual string that we're trying to > parse instead (i.e. here, the subcommand)? I wanted something where we could be pretty sure that Pcomplete wouldn't treat it specially, since it should be "opaque" to Pcomplete. I changed this to be a propertized string with just the NUL character: (propertize "\0" 'eshell-argument-stub TYPE) That should be pretty unlikely to trigger anything in Pcomplete. (Arguably, Pcomplete should have some way of marking an argument as "not real", but I'm not sure anything outside of Eshell would need that...) --------------UersodUaJpXhW00Py9QeaF2b Content-Type: text/plain; charset=UTF-8; name="0001-Avoid-parsing-some-Eshell-forms-when-performing-comp.patch" Content-Disposition: attachment; filename*0="0001-Avoid-parsing-some-Eshell-forms-when-performing-comp.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyZTgyYzM1NmQ1MmRlZjMzZjEyY2ZkOTcxOGE0NmJlNTM4Y2YzMDA2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTggTWFyIDIwMjMgMTU6Mzk6NTcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBBdm9pZCBwYXJzaW5nIHNvbWUgRXNoZWxsIGZvcm1zIHdoZW4gcGVyZm9ybWluZyBj b21wbGV0aW9uCgpEdXJpbmcgY29tcGxldGlvbiwgd2Ugd2FudCB0byBldmFsdWF0ZSBtb3N0 IEVzaGVsbCBmb3JtcwooZS5nLiB2YXJpYWJsZSByZWZlcmVuY2VzKSwgYnV0IHNraXAgb3Ro ZXJzIChlLmcuIGdsb2JiaW5nLApzdWJjb21tYW5kcywgTGlzcCBmb3JtcykuICBGb3IgZ2xv YmJpbmcsIHdlIHdhbnQgdG8gcGFzcyB0aGUgbGl0ZXJhbApnbG9iIHRvIFBjb21wbGV0ZSBz byBpdCBjYW4gdXNlIHRoZSBnbG9iIGZvciBzZWxlY3RpbmcgY29tcGxldGlvbgpjYW5kaWRh dGVzLiAgRm9yIHN1YmNvbW1hbmRzIGFuZCBMaXNwIGZvcm1zIGluIHBhcnRpY3VsYXIsIHdl CmVzcGVjaWFsbHkgd2FudCB0byBhdm9pZCBldmFsdWF0aW9uLCBzaW5jZSB0aGV5IGNhbiBw cm9kdWNlIGFyYml0YXJ5CnNpZGUgZWZmZWN0cyEgIChCdWcjNTA0NzApCgoqIGxpc3AvZXNo ZWxsL2VzaC1hcmcuZWwgKGVzaGVsbC1hcmd1bWVudC1zdHViKTogTmV3IGZ1bmN0aW9uLgoK KiBsaXNwL2VzaGVsbC9lbS1jbXBsLmVsIChlc2hlbGwtcGFyc2luZy1mb3ItY29tcGxldGlv bik6IE5ldwp2YXJpYWJsZS4uLgooZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cyk6 IC4uLiBsZXQtYmluZCBpdCB0byAndCcuCgoqIGxpc3AvZXNoZWxsL2VtLWdsb2IuZWwgKGVz aGVsbC1wYXJzZS1nbG9iLWNoYXJzKToKKiBsaXNwL2VzaGVsbC9lc2gtdmFyLmVsIChlc2hl bGwtcGFyc2UtdmFyaWFibGUtcmVmKToKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hl bGwtcGFyc2Utc3ViY29tbWFuZC1hcmd1bWVudCkKKGVzaGVsbC1wYXJzZS1saXNwLWFyZ3Vt ZW50KTogQ2hlY2sgJ2VzaGVsbC1wYXJzaW5nLWZvci1jb21wbGV0aW9uJy4KKGVzaGVsbC1k by1ldmFsKTogVXNlICdjYXItc2FmZScgd2hlbiBjaGVja2luZyB0aGUgYm9keSBvZiBhICds ZXQnCmZvcm0uCgoqIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbAooZW0tY21w bC10ZXN0L3BhcnNlLWFyZ3VtZW50cy91bmV2YWx1YXRlZC1zdWJjb21tYW5kKQooZW0tY21w bC10ZXN0L3BhcnNlLWFyZ3VtZW50cy91bmV2YWx1YXRlZC1saXNwLWZvcm0pCihlbS1jbXBs LXRlc3QvZmlsZS1jb21wbGV0aW9uL2dsb2IsIGVtLWNtcGwtdGVzdC9jb21tYW5kLWNvbXBs ZXRpb24pCihlbS1jbXBsLXRlc3Qvc3ViY29tbWFuZC1jb21wbGV0aW9uKTogTmV3IHRlc3Rz LgooZW0tY21wbC10ZXN0L2xpc3AtZnVuY3Rpb24tY29tcGxldGlvbik6IENoZWNrICIkKGZ1 bmMpIiBzeW50YXguCi0tLQogbGlzcC9lc2hlbGwvZW0tY21wbC5lbCAgICAgICAgICAgIHwg MjEgKysrKysrKystCiBsaXNwL2VzaGVsbC9lbS1nbG9iLmVsICAgICAgICAgICAgfCAgMyAr LQogbGlzcC9lc2hlbGwvZXNoLWFyZy5lbCAgICAgICAgICAgIHwgIDggKysrKwogbGlzcC9l c2hlbGwvZXNoLWNtZC5lbCAgICAgICAgICAgIHwgMjcgKysrKysrLS0tLS0KIGxpc3AvZXNo ZWxsL2VzaC12YXIuZWwgICAgICAgICAgICB8IDc4ICsrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZW0tY21wbC10ZXN0cy5lbCB8IDU3ICsrKysr KysrKysrKysrKysrKysrKy0KIDYgZmlsZXMgY2hhbmdlZCwgMTQzIGluc2VydGlvbnMoKyks IDUxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWNtcGwuZWwg Yi9saXNwL2VzaGVsbC9lbS1jbXBsLmVsCmluZGV4IGI2NTY1MjAxOWQ0Li4xNDc4MWZiMGVl OCAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZW0tY21wbC5lbAorKysgYi9saXNwL2VzaGVs bC9lbS1jbXBsLmVsCkBAIC04NSw2ICs4NSwyNCBAQCBlc2hlbGwtY21wbAogICA6dGFnICJB cmd1bWVudCBjb21wbGV0aW9uIgogICA6Z3JvdXAgJ2VzaGVsbC1tb2R1bGUpKQogCis7Ozsg SW50ZXJuYWwgdmFyaWFibGVzOgorCis7OyBGSVhNRTogSW5zdGVhZCBvZiB1c2luZyBhIGR5 bmFtaWMgdmFyaWFibGUgZm9yIHRoaXMsIGl0IG1pZ2h0IGJlCis7OyBiZXR0ZXIgdG8gcGFz cyBgZXNoZWxsLXBhcnNlLWFyZ3VtZW50LWhvb2snIGZ1bmN0aW9ucyBhIHBhcnNpbmcKKzs7 IGNvbnRleHQuICBUaGlzIGNvdWxkIGFsc28gYmUgdXNlZnVsIGZvciByZXN0cnVjdHVyaW5n IHBhcnNpbmcgbW9yZQorOzsgZ2VuZXJhbGx5LCBlLmcuIHRvIGZpeCBidWcjNTk3NTIuCiso ZGVmdmFyIGVzaGVsbC1wYXJzaW5nLWZvci1jb21wbGV0aW9uIG5pbAorICAiVGhpcyBpcyBi b3VuZCB0byB0IHdoZW4gY2FsbGluZyBgZXNoZWxsLXBhcnNlLWFyZ3VtZW50cycgZm9yIGNv bXBsZXRpb24uCitGdW5jdGlvbnMgYWRkZWQgdG8gYGVzaGVsbC1wYXJzZS1hcmd1bWVudC1o b29rJyBzaG91bGQgY29uc3VsdCB0aGlzIHRvCithZGp1c3QgdGhlaXIgYmVoYXZpb3Igd2hl biBwYXJzaW5nIGEgY29tbWFuZCBmb3IgY29tcGxldGlvbiwgaWYKK25lY2Vzc2FyeS4KKwor V2hlbiBwYXJzaW5nIGZvciBjb21wbGV0aW9uLCB3ZSBuZWVkIHRvIGVuc3VyZSB0aGF0IHRo ZSByZXN1bHRpbmcKK0xpc3AgZm9ybSBoYXMgbm8gc2lkZSBlZmZlY3RzLCBhbmQgcmV0dXJu cyBxdWlja2x5LiAgRm9yIGV4YW1wbGUsCit0aGlzIG1lYW5zIHRoYXQgRXNoZWxsIHN1YmNv bW1hbmRzIHNob3VsZCByZXR1cm4gc29tZSBzdHViIHZhbHVlCit3aGVuIHRoaXMgaXMgc2V0 IHNvIHRoYXQgdGhlIGNvbXBsZXRpb24gY29kZSBkb2Vzbid0IHRyeSB0bworaW52b2tlIHRo ZSBzdWJjb21tYW5kIChzZWUgYGVzaGVsbC1wYXJzZS1zdWJjb21tYW5kLWFyZ3VtZW50Jyku IikKKwogOzs7IFVzZXIgVmFyaWFibGVzOgogCiAoZGVmY3VzdG9tIGVzaGVsbC1jbXBsLWxv YWQtaG9vayBuaWwKQEAgLTMyOCw3ICszNDYsOCBAQCBlc2hlbGwtY29tcGxldGUtcGFyc2Ut YXJndW1lbnRzCiAgICAgKGlmIChzZXRxIGRlbGltCiAJICAgICAgKGNhdGNoICdlc2hlbGwt aW5jb21wbGV0ZQogCQkoaWdub3JlCi0JCSAoc2V0cSBhcmdzIChlc2hlbGwtcGFyc2UtYXJn dW1lbnRzIGJlZ2luIGVuZCkpKSkpCisgICAgICAgICAgICAgICAgIChzZXRxIGFyZ3MgKGxl dCAoKGVzaGVsbC1wYXJzaW5nLWZvci1jb21wbGV0aW9uIHQpKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGVzaGVsbC1wYXJzZS1hcmd1bWVudHMgYmVnaW4gZW5kKSkpKSkp CiAgICAgICAgIChjb25kICgobWVtYmVyIChjYXIgZGVsaW0pICcoInsiICIkeyIgIiQ8Iikp CiAJICAgICAgIChzZXRxIGJlZ2luICgxKyAoY2FkciBkZWxpbSkpCiAJCSAgICAgYXJncyAo ZXNoZWxsLXBhcnNlLWFyZ3VtZW50cyBiZWdpbiBlbmQpKSkKZGlmZiAtLWdpdCBhL2xpc3Av ZXNoZWxsL2VtLWdsb2IuZWwgYi9saXNwL2VzaGVsbC9lbS1nbG9iLmVsCmluZGV4IDhhMmJh MTNiMmFkLi5kNjM3MmJjMzBhNiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZW0tZ2xvYi5l bAorKysgYi9saXNwL2VzaGVsbC9lbS1nbG9iLmVsCkBAIC0xNjIsNyArMTYyLDggQEAgZXNo ZWxsLXBhcnNlLWdsb2ItY2hhcnMKIFRoZSBjaGFyYWN0ZXIgaXMgbm90IGFkdmFuY2VkIGZv ciBvcmRpbmFyeSBnbG9iYmluZyBjaGFyYWN0ZXJzLCBzbwogdGhhdCBvdGhlciBmdW5jdGlv biBtYXkgaGF2ZSBhIGNoYW5jZSB0byBvdmVycmlkZSB0aGUgZ2xvYmJpbmcKIGludGVycHJl dGF0aW9uLiIKLSAgKHdoZW4gKG1lbXEgKGNoYXItYWZ0ZXIpIGVzaGVsbC1nbG9iLWNoYXJz LWxpc3QpCisgICh3aGVuIChhbmQgKG5vdCAoYm91bmQtYW5kLXRydWUtcCBlc2hlbGwtcGFy c2luZy1mb3ItY29tcGxldGlvbikpCisgICAgICAgICAgICAgKG1lbXEgKGNoYXItYWZ0ZXIp IGVzaGVsbC1nbG9iLWNoYXJzLWxpc3QpKQogICAgIChpZiAobm90IChtZW1xIChjaGFyLWFm dGVyKSAnKD9cKCA/XFspKSkKIAkoaWdub3JlIChlc2hlbGwtYWRkLWdsb2ItbW9kaWZpZXIp KQogICAgICAgKGxldCAoKGhlcmUgKHBvaW50KSkpCmRpZmYgLS1naXQgYS9saXNwL2VzaGVs bC9lc2gtYXJnLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWFyZy5lbAppbmRleCBhYTFlOGY3N2Vh NS4uZTI5YTU3YzlmNDYgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1hcmcuZWwKKysr IGIvbGlzcC9lc2hlbGwvZXNoLWFyZy5lbApAQCAtMTg5LDYgKzE4OSwxNCBAQCBlc2hlbGwt aW5zZXJ0LWJ1ZmZlci1uYW1lCiAgIChpbnRlcmFjdGl2ZSAiQk5hbWUgb2YgYnVmZmVyOiAi KQogICAoaW5zZXJ0LWFuZC1pbmhlcml0ICIjPGJ1ZmZlciAiIGJ1ZmZlci1uYW1lICI+Iikp CiAKKyhkZWZzdWJzdCBlc2hlbGwtYXJndW1lbnQtc3R1YiAodHlwZSkKKyAgIlJldHVybiBh biBhcmd1bWVudCBzdHViIGZvciBUWVBFLgorVGhpcyBpcyBqdXN0IGEgc3RyaW5nIGNvbnRh aW5pbmcgdGhlIE5VTCBjaGFyYWN0ZXIsIHdpdGggdGhlCitgZXNoZWxsLWFyZ3VtZW50LXN0 dWInIHByb3BlcnR5IHNldCB0byBUWVBFLiAgVGhpcyBpcyB1c2VmdWwgZm9yCittYXJraW5n IHRoYXQgYW4gYXJndW1lbnQgd2Fzbid0IGZ1bGx5IHBhcnNlZCAoZS5nLiB3aGVuCitgZXNo ZWxsLXBhcnNpbmctZm9yLWNvbXBsZXRpb24nIGlzIG5vbi1uaWwpLiIKKyAgKHByb3BlcnRp emUgIlwwIiAnZXNoZWxsLWFyZ3VtZW50LXN0dWIgdHlwZSkpCisKIChkZWZzdWJzdCBlc2hl bGwtZXNjYXBlLWFyZyAoc3RyaW5nKQogICAiUmV0dXJuIFNUUklORyB3aXRoIHRoZSBgZXNj YXBlZCcgcHJvcGVydHkgb24gaXQuIgogICAoaWYgKHN0cmluZ3Agc3RyaW5nKQpkaWZmIC0t Z2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwK aW5kZXggOTNmMjYxNjAyMGMuLjEyODQzYWJjNzc3IDEwMDY0NAotLS0gYS9saXNwL2VzaGVs bC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTY3NSwxMyAr Njc1LDE1IEBAIGVzaGVsbC1wYXJzZS1zdWJjb21tYW5kLWFyZ3VtZW50CiAJICAgKG9yICg9 IChwb2ludC1tYXgpICgxKyAocG9pbnQpKSkKIAkgICAgICAgKG5vdCAoZXEgKGNoYXItYWZ0 ZXIgKDErIChwb2ludCkpKSA/XH0pKSkpCiAgICAgICAobGV0ICgoZW5kIChlc2hlbGwtZmlu ZC1kZWxpbWl0ZXIgP1x7ID9cfSkpKQotCShpZiAobm90IGVuZCkKLSAgICAgICAgICAgICh0 aHJvdyAnZXNoZWxsLWluY29tcGxldGUgInsiKQotCSAgKHdoZW4gKGVzaGVsbC1hcmctZGVs aW1pdGVyICgxKyBlbmQpKQotCSAgICAocHJvZzEKKyAgICAgICAgKHVubGVzcyBlbmQKKyAg ICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRlICJ7IikpCisgICAgICAgICh3aGVu IChlc2hlbGwtYXJnLWRlbGltaXRlciAoMSsgZW5kKSkKKyAgICAgICAgICAocHJvZzEKKyAg ICAgICAgICAgICAgKGlmIChib3VuZC1hbmQtdHJ1ZS1wIGVzaGVsbC1wYXJzaW5nLWZvci1j b21wbGV0aW9uKQorICAgICAgICAgICAgICAgICAgKGVzaGVsbC1hcmd1bWVudC1zdHViICdz dWJjb21tYW5kKQogCQlgKGVzaGVsbC1hcy1zdWJjb21tYW5kCi0gICAgICAgICAgICAgICAg ICAsKGVzaGVsbC1wYXJzZS1jb21tYW5kIChjb25zICgxKyAocG9pbnQpKSBlbmQpKSkKLQkg ICAgICAoZ290by1jaGFyICgxKyBlbmQpKSkpKSkpKQorICAgICAgICAgICAgICAgICAgLChl c2hlbGwtcGFyc2UtY29tbWFuZCAoY29ucyAoMSsgKHBvaW50KSkgZW5kKSkpKQorICAgICAg ICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKQogCiAoZGVmdW4gZXNoZWxsLXBhcnNl LWxpc3AtYXJndW1lbnQgKCkKICAgIlBhcnNlIGEgTGlzcCBleHByZXNzaW9uIHdoaWNoIGlz IHNwZWNpZmllZCBhcyBhbiBhcmd1bWVudC4iCkBAIC02ODksMTQgKzY5MSwxNSBAQCBlc2hl bGwtcGFyc2UtbGlzcC1hcmd1bWVudAogCSAgIChub3QgZXNoZWxsLWN1cnJlbnQtcXVvdGVk KQogCSAgIChsb29raW5nLWF0IGVzaGVsbC1saXNwLXJlZ2V4cCkpCiAgICAgICAobGV0KiAo KGhlcmUgKHBvaW50KSkKLQkgICAgIChvYmoKKyAgICAgICAgICAgICAobGlzcC1mb3JtCiAJ ICAgICAgKGNvbmRpdGlvbi1jYXNlIG5pbAogCQkgIChyZWFkIChjdXJyZW50LWJ1ZmZlcikp Ci0JCShlbmQtb2YtZmlsZQotICAgICAgICAgICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNv bXBsZXRlICIoIikpKSkpCisgICAgICAgICAgICAgICAgKGVuZC1vZi1maWxlICh0aHJvdyAn ZXNoZWxsLWluY29tcGxldGUgIigiKSkpKSkKIAkoaWYgKGVzaGVsbC1hcmctZGVsaW1pdGVy KQotCSAgICBgKGVzaGVsbC1jb21tYW5kLXRvLXZhbHVlCi0gICAgICAgICAgICAgIChlc2hl bGwtbGlzcC1jb21tYW5kIChxdW90ZSAsb2JqKSkpCisgICAgICAgICAgICAoaWYgKGJvdW5k LWFuZC10cnVlLXAgZXNoZWxsLXBhcnNpbmctZm9yLWNvbXBsZXRpb24pCisgICAgICAgICAg ICAgICAgKGVzaGVsbC1hcmd1bWVudC1zdHViICdsaXNwKQorICAgICAgICAgICAgICBgKGVz aGVsbC1jb21tYW5kLXRvLXZhbHVlCisgICAgICAgICAgICAgICAgKGVzaGVsbC1saXNwLWNv bW1hbmQgJyxsaXNwLWZvcm0pKSkKIAkgIChpZ25vcmUgKGdvdG8tY2hhciBoZXJlKSkpKSkp CiAKIChkZWZ1biBlc2hlbGwtc2VwYXJhdGUtY29tbWFuZHMgKHRlcm1zIHNlcGFyYXRvciAm b3B0aW9uYWwKQEAgLTExNjgsNyArMTE3MSw3IEBAIGVzaGVsbC1kby1ldmFsCiAJKHNldGNh ciAoY2RyIGFyZ3MpIChlc2hlbGwtZG8tZXZhbCAoY2FkciBhcmdzKSBzeW5jaHJvbm91cy1w KSkKIAkoZXZhbCBmb3JtKSkKICAgICAgICAoKGVxIChjYXIgZm9ybSkgJ2xldCkKLSAgICAg ICAgKHdoZW4gKG5vdCAoZXEgKGNhciAoY2FkciBhcmdzKSkgJ2VzaGVsbC1kby1ldmFsKSkK KyAgICAgICAgKHVubGVzcyAoZXEgKGNhci1zYWZlIChjYWRyIGFyZ3MpKSAnZXNoZWxsLWRv LWV2YWwpCiAgICAgICAgICAgKGVzaGVsbC1tYW5pcHVsYXRlICJldmFsdWF0aW5nIGxldCBh cmdzIgogICAgICAgICAgICAgKGRvbGlzdCAobGV0YXJnIChjYXIgYXJncykpCiAgICAgICAg ICAgICAgICh3aGVuIChhbmQgKGxpc3RwIGxldGFyZykKZGlmZiAtLWdpdCBhL2xpc3AvZXNo ZWxsL2VzaC12YXIuZWwgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCmluZGV4IDVkNjI5OWFm NTY0Li4wYzMzODE4MzlmNCAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXZhci5lbAor KysgYi9saXNwL2VzaGVsbC9lc2gtdmFyLmVsCkBAIC01MDcsMTAgKzUwNywxMiBAQCBlc2hl bGwtcGFyc2UtdmFyaWFibGUtcmVmCiAgIChjb25kCiAgICAoKGVxIChjaGFyLWFmdGVyKSA/ eykKICAgICAobGV0ICgoZW5kIChlc2hlbGwtZmluZC1kZWxpbWl0ZXIgP1x7ID9cfSkpKQot ICAgICAgKGlmIChub3QgZW5kKQotICAgICAgICAgICh0aHJvdyAnZXNoZWxsLWluY29tcGxl dGUgIiR7IikKLSAgICAgICAgKGZvcndhcmQtY2hhcikKLSAgICAgICAgKHByb2cxCisgICAg ICAodW5sZXNzIGVuZAorICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRlICIkeyIp KQorICAgICAgKGZvcndhcmQtY2hhcikKKyAgICAgIChwcm9nMQorICAgICAgICAgIChpZiAo Ym91bmQtYW5kLXRydWUtcCBlc2hlbGwtcGFyc2luZy1mb3ItY29tcGxldGlvbikKKyAgICAg ICAgICAgICAgKGVzaGVsbC1hcmd1bWVudC1zdHViICdzdWJjb21tYW5kKQogICAgICAgICAg ICAgYChlc2hlbGwtYXBwbHktaW5kaWNlcwogICAgICAgICAgICAgICAoZXNoZWxsLWNvbnZl cnQKICAgICAgICAgICAgICAgIChlc2hlbGwtY29tbWFuZC10by12YWx1ZQpAQCAtNTI3LDQ1 ICs1MjksNDkgQEAgZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgogICAgICAgICAgICAgICAg OzsganVzdCBiZSBqb2luZWQgYmFjayB0b2dldGhlciBhZnRlcndhcmRzLgogICAgICAgICAg ICAgICAgLCh3aGVuIChhbmQgKG5vdCBtb2RpZmllci1wKSBlc2hlbGwtY3VycmVudC1xdW90 ZWQpCiAgICAgICAgICAgICAgICAgICAnKG5vdCBpbmRpY2VzKSkpCi0gICAgICAgICAgICAg IGluZGljZXMgLGVzaGVsbC1jdXJyZW50LXF1b3RlZCkKLSAgICAgICAgICAoZ290by1jaGFy ICgxKyBlbmQpKSkpKSkKKyAgICAgICAgICAgICAgaW5kaWNlcyAsZXNoZWxsLWN1cnJlbnQt cXVvdGVkKSkKKyAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkKICAgICgoZXEgKGNo YXItYWZ0ZXIpID9cPCkKICAgICAobGV0ICgoZW5kIChlc2hlbGwtZmluZC1kZWxpbWl0ZXIg P1w8ID9cPikpKQotICAgICAgKGlmIChub3QgZW5kKQotICAgICAgICAgICh0aHJvdyAnZXNo ZWxsLWluY29tcGxldGUgIiQ8IikKLSAgICAgICAgKGxldCogKCh0ZW1wIChtYWtlLXRlbXAt ZmlsZSB0ZW1wb3JhcnktZmlsZS1kaXJlY3RvcnkpKQotICAgICAgICAgICAgICAgKGNtZCAo Y29uY2F0IChidWZmZXItc3Vic3RyaW5nICgxKyAocG9pbnQpKSBlbmQpCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgIiA+ICIgdGVtcCkpKQotICAgICAgICAgIChwcm9nMQorICAg ICAgKHVubGVzcyBlbmQKKyAgICAgICAgKHRocm93ICdlc2hlbGwtaW5jb21wbGV0ZSAiJDwi KSkKKyAgICAgIChsZXQqICgodGVtcCAobWFrZS10ZW1wLWZpbGUgdGVtcG9yYXJ5LWZpbGUt ZGlyZWN0b3J5KSkKKyAgICAgICAgICAgICAoY21kIChjb25jYXQgKGJ1ZmZlci1zdWJzdHJp bmcgKDErIChwb2ludCkpIGVuZCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIiA+ICIg dGVtcCkpKQorICAgICAgICAocHJvZzEKKyAgICAgICAgICAgIChpZiAoYm91bmQtYW5kLXRy dWUtcCBlc2hlbGwtcGFyc2luZy1mb3ItY29tcGxldGlvbikKKyAgICAgICAgICAgICAgICAo ZXNoZWxsLWFyZ3VtZW50LXN0dWIgJ3N1YmNvbW1hbmQpCiAgICAgICAgICAgICAgIGAobGV0 ICgoZXNoZWxsLWN1cnJlbnQtaGFuZGxlcwogICAgICAgICAgICAgICAgICAgICAgIChlc2hl bGwtY3JlYXRlLWhhbmRsZXMgLHRlbXAgJ292ZXJ3cml0ZSkpKQotICAgICAgICAgICAgICAg ICAocHJvZ24KLSAgICAgICAgICAgICAgICAgICAoZXNoZWxsLWFzLXN1YmNvbW1hbmQKLSAg ICAgICAgICAgICAgICAgICAgLChsZXQgKChlc2hlbGwtY3VycmVudC1xdW90ZWQgbmlsKSkK LSAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1wYXJzZS1jb21tYW5kIGNtZCkpKQot ICAgICAgICAgICAgICAgICAgIChpZ25vcmUKLSAgICAgICAgICAgICAgICAgICAgKG5jb25j IGVzaGVsbC10aGlzLWNvbW1hbmQtaG9vawotICAgICAgICAgICAgICAgICAgICAgICAgICAg OzsgUXVvdGUgdGhpcyBsYW1iZGE7IGl0IHdpbGwgYmUgZXZhbHVhdGVkCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICA7OyBieSBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJl cyB2ZXJ5Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBwYXJ0aWN1bGFyIGZvcm1z IGluIG9yZGVyIHRvIHdvcmsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHByb3Bl cmx5LiAgU2VlIGJ1ZyM1NDE5MC4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0 IChmdW5jdGlvbgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsYW1iZGEg KCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUtZmlsZSAs dGVtcCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICh3aGVuLWxldCAo KGJ1ZmZlciAoZ2V0LWZpbGUtYnVmZmVyICx0ZW1wKSkpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChraWxsLWJ1ZmZlciBidWZmZXIpKSkpKSkpCi0gICAgICAg ICAgICAgICAgICAgKGVzaGVsbC1hcHBseS1pbmRpY2VzICx0ZW1wIGluZGljZXMgLGVzaGVs bC1jdXJyZW50LXF1b3RlZCkpKQotICAgICAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkp KSkpKQorICAgICAgICAgICAgICAgICAoZXNoZWxsLWFzLXN1YmNvbW1hbmQKKyAgICAgICAg ICAgICAgICAgICwobGV0ICgoZXNoZWxsLWN1cnJlbnQtcXVvdGVkIG5pbCkpCisgICAgICAg ICAgICAgICAgICAgICAoZXNoZWxsLXBhcnNlLWNvbW1hbmQgY21kKSkpCisgICAgICAgICAg ICAgICAgIChpZ25vcmUKKyAgICAgICAgICAgICAgICAgIChuY29uYyBlc2hlbGwtdGhpcy1j b21tYW5kLWhvb2sKKyAgICAgICAgICAgICAgICAgICAgICAgICA7OyBRdW90ZSB0aGlzIGxh bWJkYTsgaXQgd2lsbCBiZSBldmFsdWF0ZWQgYnkKKyAgICAgICAgICAgICAgICAgICAgICAg ICA7OyBgZXNoZWxsLWRvLWV2YWwnLCB3aGljaCByZXF1aXJlcyB2ZXJ5CisgICAgICAgICAg ICAgICAgICAgICAgICAgOzsgcGFydGljdWxhciBmb3JtcyBpbiBvcmRlciB0byB3b3JrCisg ICAgICAgICAgICAgICAgICAgICAgICAgOzsgcHJvcGVybHkuICBTZWUgYnVnIzU0MTkwLgor ICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0IChmdW5jdGlvbgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAobGFtYmRhICgpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGRlbGV0ZS1maWxlICx0ZW1wKQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICh3aGVuLWxldCAoKGJ1ZmZlciAoZ2V0LWZpbGUtYnVmZmVyICx0ZW1w KSkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoa2lsbC1idWZmZXIg YnVmZmVyKSkpKSkpKQorICAgICAgICAgICAgICAgICAoZXNoZWxsLWFwcGx5LWluZGljZXMg LHRlbXAgaW5kaWNlcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LGVzaGVsbC1jdXJyZW50LXF1b3RlZCkpKQorICAgICAgICAgIChnb3RvLWNoYXIgKDErIGVu ZCkpKSkpKQogICAgKChlcSAoY2hhci1hZnRlcikgP1woKQotICAgIChjb25kaXRpb24tY2Fz ZSBuaWwKKyAgICAobGV0ICgobGlzcC1mb3JtCisgICAgICAgICAgIChjb25kaXRpb24tY2Fz ZSBuaWwKKyAgICAgICAgICAgICAgIChyZWFkIChvciAoZXNoZWxsLXVuZXNjYXBlLWlubmVy LWRvdWJsZS1xdW90ZSAocG9pbnQtbWF4KSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAo Y3VycmVudC1idWZmZXIpKSkKKyAgICAgICAgICAgICAoZW5kLW9mLWZpbGUgKHRocm93ICdl c2hlbGwtaW5jb21wbGV0ZSAiJCgiKSkpKSkKKyAgICAgIChpZiAoYm91bmQtYW5kLXRydWUt cCBlc2hlbGwtcGFyc2luZy1mb3ItY29tcGxldGlvbikKKyAgICAgICAgICAoZXNoZWxsLWFy Z3VtZW50LXN0dWIgJ2xpc3ApCiAgICAgICAgIGAoZXNoZWxsLWFwcGx5LWluZGljZXMKICAg ICAgICAgICAoZXNoZWxsLWNvbW1hbmQtdG8tdmFsdWUKLSAgICAgICAgICAgKGVzaGVsbC1s aXNwLWNvbW1hbmQKLSAgICAgICAgICAgICcsKHJlYWQgKG9yIChlc2hlbGwtdW5lc2NhcGUt aW5uZXItZG91YmxlLXF1b3RlIChwb2ludC1tYXgpKQotICAgICAgICAgICAgICAgICAgICAg ICAgKGN1cnJlbnQtYnVmZmVyKSkpKSkKLSAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3Vy cmVudC1xdW90ZWQpCi0gICAgICAoZW5kLW9mLWZpbGUKLSAgICAgICAodGhyb3cgJ2VzaGVs bC1pbmNvbXBsZXRlICIkKCIpKSkpCisgICAgICAgICAgIChlc2hlbGwtbGlzcC1jb21tYW5k ICcsbGlzcC1mb3JtKSkKKyAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3VycmVudC1xdW90 ZWQpKSkpCiAgICAoKGxvb2tpbmctYXQgKHJ4LXRvLXN0cmluZwogICAgICAgICAgICAgICAg ICBgKG9yICInIiAsKGlmIGVzaGVsbC1jdXJyZW50LXF1b3RlZCAiXFxcIiIgIlwiIikpKSkK ICAgICAoZXNoZWxsLXdpdGgtdGVtcC1jb21tYW5kCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Av ZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVz dHMuZWwKaW5kZXggZWE5MDdmMTk0NWQuLmZlYTMzNjY5ZjA4IDEwMDY0NAotLS0gYS90ZXN0 L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9l bS1jbXBsLXRlc3RzLmVsCkBAIC0xMjMsNiArMTIzLDM0IEBAIGVtLWNtcGwtdGVzdC9wYXJz ZS1hcmd1bWVudHMvdmFyaWFibGUvc3BsaWNlCiAgICAgICAgICAgICAgIChjYXIgKGVzaGVs bC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQogICAgICAgICAgICAgICAnKCJlY2hvIiAi Zm9vIiAiYmFyIikpKSkpKQogCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFy Z3VtZW50cy91bmV2YWx1YXRlZC1zdWJjb21tYW5kICgpCisgICJUZXN0IHRoYXQgc3ViY29t bWFuZHMgcmV0dXJuIGEgc3R1YiB3aGVuIHBhcnNpbmcgZm9yIGNvbXBsZXRpb24uIgorICAo d2l0aC10ZW1wLWVzaGVsbAorICAgKGluc2VydCAiZWNobyB7ZWNobyBoaX0iKQorICAgKHNo b3VsZCAoZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAgICAgICAgICAgKGNhciAoZXNoZWxs LWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICBgKCJlY2hvIiAsKGVz aGVsbC1hcmd1bWVudC1zdHViICdzdWJjb21tYW5kKSkpKSkKKyAgKHdpdGgtdGVtcC1lc2hl bGwKKyAgIChpbnNlcnQgImVjaG8gJHtlY2hvIGhpfSIpCisgICAoc2hvdWxkIChlc2hlbGwt YXJndW1lbnRzLWVxdWFsCisgICAgICAgICAgICAoY2FyIChlc2hlbGwtY29tcGxldGUtcGFy c2UtYXJndW1lbnRzKSkKKyAgICAgICAgICAgIGAoImVjaG8iICwocHJvcGVydGl6ZSAoZXNo ZWxsLWFyZ3VtZW50LXN0dWIgJ3N1YmNvbW1hbmQpCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ2VzY2FwZWQgdCkpKSkpKQorCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10 ZXN0L3BhcnNlLWFyZ3VtZW50cy91bmV2YWx1YXRlZC1saXNwLWZvcm0gKCkKKyAgIlRlc3Qg dGhhdCBMaXNwIGZvcm1zIHJldHVybiBhIHN0dWIgd2hlbiBwYXJzaW5nIGZvciBjb21wbGV0 aW9uLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChpbnNlcnQgImVjaG8gKGNvbmNhdCBc ImhpXCIpIikKKyAgIChzaG91bGQgKGVzaGVsbC1hcmd1bWVudHMtZXF1YWwKKyAgICAgICAg ICAgIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAg ICAgYCgiZWNobyIgLChlc2hlbGwtYXJndW1lbnQtc3R1YiAnbGlzcCkpKSkpCisgICh3aXRo LXRlbXAtZXNoZWxsCisgICAoaW5zZXJ0ICJlY2hvICQoY29uY2F0IFwiaGlcIikiKQorICAg KHNob3VsZCAoZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAgICAgICAgICAgKGNhciAoZXNo ZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICBgKCJlY2hvIiAs KHByb3BlcnRpemUgKGVzaGVsbC1hcmd1bWVudC1zdHViICdsaXNwKQorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdlc2NhcGVkIHQpKSkpKSkKKwogKGVydC1kZWZ0ZXN0 IGVtLWNtcGwtdGVzdC9maWxlLWNvbXBsZXRpb24vdW5pcXVlICgpCiAgICJUZXN0IGNvbXBs ZXRpb24gb2YgZmlsZSBuYW1lcyB3aGVuIHRoZXJlJ3MgYSB1bmlxdWUgcmVzdWx0LiIKICAg KHdpdGgtdGVtcC1lc2hlbGwKQEAgLTE1MCw2ICsxNzgsMTUgQEAgZW0tY21wbC10ZXN0L2Zp bGUtY29tcGxldGlvbi9ub24tdW5pcXVlCiAgICAgICAgICAoZm9yd2FyZC1saW5lIC0xKQog ICAgICAgICAgKHNob3VsZCAobG9va2luZy1hdCAiQ29tcGxldGUsIGJ1dCBub3QgdW5pcXVl IikpKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9maWxlLWNvbXBsZXRpb24v Z2xvYiAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGZpbGUgbmFtZXMgdXNpbmcgYSBnbG9i LiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChlcnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBk ZWZhdWx0LWRpcmVjdG9yeQorICAgICAod3JpdGUtcmVnaW9uIG5pbCBuaWwgKGV4cGFuZC1m aWxlLW5hbWUgImZpbGUudHh0IikpCisgICAgICh3cml0ZS1yZWdpb24gbmlsIG5pbCAoZXhw YW5kLWZpbGUtbmFtZSAiZmlsZS5lbCIpKQorICAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxs LWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gZmkqLmVsIikKKyAgICAgICAgICAgICAgICAg ICAgImVjaG8gZmlsZS5lbCAiKSkpKSkKKwogKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9m aWxlLWNvbXBsZXRpb24vYWZ0ZXItbGlzdCAoKQogICAiVGVzdCBjb21wbGV0aW9uIG9mIGZp bGUgbmFtZXMgYWZ0ZXIgcHJldmlvdXMgbGlzdCBhcmd1bWVudHMuCiBTZWUgYnVnIzU5OTU2 LiIKQEAgLTE1OSw2ICsxOTYsMjEgQEAgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxldGlvbi9h ZnRlci1saXN0CiAgICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21w bGV0ZSAiZWNobyAobGlzdCAxIDIpIGZpIikKICAgICAgICAgICAgICAgICAgICAgImVjaG8g KGxpc3QgMSAyKSBmaWxlLnR4dCAiKSkpKSkKIAorKGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVz dC9jb21tYW5kLWNvbXBsZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGlvbiBvZiBjb21tYW5k IG5hbWVzIGxpa2UgXCJjb21tYW5kXCIuIgorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKHNo b3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlICJsaXN0aWYiKQorICAg ICAgICAgICAgICAgICAgImxpc3RpZnkgIikpKSkKKworKGVydC1kZWZ0ZXN0IGVtLWNtcGwt dGVzdC9zdWJjb21tYW5kLWNvbXBsZXRpb24gKCkKKyAgIlRlc3QgY29tcGxldGlvbiBvZiBj b21tYW5kIG5hbWVzIGxpa2UgXCJ7Y29tbWFuZH1cIi4iCisgICh3aXRoLXRlbXAtZXNoZWxs CisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgInsgbGlz dGlmIikKKyAgICAgICAgICAgICAgICAgICJ7IGxpc3RpZnkgIikpKQorICAod2l0aC10ZW1w LWVzaGVsbAorICAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRl ICJlY2hvICR7IGxpc3RpZiIpCisgICAgICAgICAgICAgICAgICAiZWNobyAkeyBsaXN0aWZ5 ICIpKSkpCisKIChlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3QvbGlzcC1zeW1ib2wtY29tcGxl dGlvbiAoKQogICAiVGVzdCBjb21wbGV0aW9uIG9mIExpc3AgZm9ybXMgbGlrZSBcIiMnc3lt Ym9sXCIgYW5kIFwiYHN5bWJvbFwiLgogU2VlIDxsaXNwL2VzaGVsbC9lc2gtY21kLmVsPi4i CkBAIC0xNzQsNyArMjI2LDEwIEBAIGVtLWNtcGwtdGVzdC9saXNwLWZ1bmN0aW9uLWNvbXBs ZXRpb24KIFNlZSA8bGlzcC9lc2hlbGwvZXNoLWNtZC5lbD4uIgogICAod2l0aC10ZW1wLWVz aGVsbAogICAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlICJl Y2hvIChlc2hlbGwvZWNoIikKLSAgICAgICAgICAgICAgICAgICJlY2hvIChlc2hlbGwvZWNo byIpKSkpCisgICAgICAgICAgICAgICAgICAiZWNobyAoZXNoZWxsL2VjaG8iKSkpCisgICh3 aXRoLXRlbXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQt Y29tcGxldGUgImVjaG8gJChlc2hlbGwvZWNoIikKKyAgICAgICAgICAgICAgICAgICJlY2hv ICQoZXNoZWxsL2VjaG8iKSkpKQogCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3NwZWNp YWwtcmVmLWNvbXBsZXRpb24vdHlwZSAoKQogICAiVGVzdCBjb21wbGV0aW9uIG9mIHRoZSBz dGFydCBvZiBzcGVjaWFsIHJlZmVyZW5jZXMgbGlrZSBcIiM8YnVmZmVyXCIuCi0tIAoyLjI1 LjEKCg== --------------UersodUaJpXhW00Py9QeaF2b-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 19 21:35:06 2023 Received: (at 50470) by debbugs.gnu.org; 20 Mar 2023 01:35:06 +0000 Received: from localhost ([127.0.0.1]:53333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe4QT-0002PV-VO for submit@debbugs.gnu.org; Sun, 19 Mar 2023 21:35:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe4QP-0002Ot-35 for 50470@debbugs.gnu.org; Sun, 19 Mar 2023 21:35:05 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A2F281000BE; Sun, 19 Mar 2023 21:34:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 46C4010008C; Sun, 19 Mar 2023 21:34:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679276094; bh=nGoh0aBhmbZoQLevRTcBRmTu0wqjx4bI1pSbIyd6pRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jfAEIeNRAYh3/ygRxRDpbKT6EVtbd3+gW2UlFm772DBpnl8lCZY7vXSTrzs3Z/++F gcSykOmYdWOCVJ2q2+JfnNZQlOQUMdJsUn8UppKbJd2Zcs/pBC1fKlT+sbca6sB9PL Csp/T7qGb6pKSMBV3eI/rznAXBDboikrC7REQdNSZkiHONNpUd1QW64U3DcI8Igsg5 CZxcZOHuRFuBqcao1ebTjcz8CRwQ8xeJv+55ThpU+dE5WtFoOLLGVx97XMHzChwi6m /ud0Sd6R45g0lKJg+osjjKu0uQwg0MadPUf+ob+HKVUUdvKDhlec7ggRDL+MEB3yXc brr4mqxsWTP2A== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0C7F31232E5; Sun, 19 Mar 2023 21:34:54 -0400 (EDT) From: Stefan Monnier To: Jim Porter Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' In-Reply-To: (Jim Porter's message of "Sun, 19 Mar 2023 17:30:56 -0700") Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> Date: Sun, 19 Mar 2023 21:34:52 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Ok, here we are. >>> - (when (memq (char-after) eshell-glob-chars-list) >>> + (when (and (not (bound-and-true-p eshell-parse-for-completion-p)) >> >> Can we (cheaply) arrange so that the var is always defined at this >> point (same for the other uses further down in the patch)? >> Maybe by moving the `defvar` elsewhere (e.g. next to >> `eshell-parse-argument-hook`)? > > It's a bit ugly, but I'm trying to follow the conventions in Eshell: since > completion is an optional extension module for Eshell, other modules jump > through hoops like this to allow the module to be not-loaded. I definitely don't want to force preloading that module. But maybe that var could have a meaning that's independent from completion, thus justifying to move it out of the completion extension module? E.g. something like "keep parsing free of side effects"? This would also have the benefit of clarifying the actual meaning of this var: defining a var based on who uses it or how it's used is always a source of trouble. > Another way to do this (arguably more Eshell-y) would be: > > (when (and (eshell-using-module 'eshell-cmpl) > eshell-parsing-for-completion) `boundp` is definitely much better. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 22:30:49 2023 Received: (at 50470) by debbugs.gnu.org; 21 Mar 2023 02:30:49 +0000 Received: from localhost ([127.0.0.1]:57249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peRlw-00088E-9C for submit@debbugs.gnu.org; Mon, 20 Mar 2023 22:30:49 -0400 Received: from mail-pj1-f50.google.com ([209.85.216.50]:35644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peRlt-000880-Dj for 50470@debbugs.gnu.org; Mon, 20 Mar 2023 22:30:46 -0400 Received: by mail-pj1-f50.google.com with SMTP id gp15-20020a17090adf0f00b0023d1bbd9f9eso18706033pjb.0 for <50470@debbugs.gnu.org>; Mon, 20 Mar 2023 19:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679365839; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=SO9nn/bCst5Ei+M3qmwEjgmOdMH1zIti5eTMqkDudWE=; b=jmG5W+k/ryqG+CPGf991d83ZbKqXlBz5IORrvWDg/cMd80if7bunWU+zTh8BxA5DVP d2d3rU2KEUuK88QE/eB/B3x3hFKwvn+MUNWZWFXtF3zQuI5tm6onsylFNu+IVLIYylWf Hvu0k/RbutB8H0NFWH+m/60kcTMv67Yfi4oRJhwzL//kolCm4vTed3yP2FWVnUX3unqN mkAmwpsBZ6LGCYgLahFb1r6gLz/tJ8aHFDdmPaKzZY7298m1hKLUeIyejLYcNPT539gB yGUxBKyOgx+4WOW0VGrPd3UhPPK5UjavaQOBoNhPqMTYrZn6EcLW3M2FAttMAttGjpHF NBYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679365839; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SO9nn/bCst5Ei+M3qmwEjgmOdMH1zIti5eTMqkDudWE=; b=NivrYgcuTboQkRjxem2/P45uk0Zhpyn2F3xfSpEp8pYboj8YRLQ5DaFwCyzi8hQ6P/ 0I523/q2IfxGV3WyrNXr9ebNHLV8E0DeDYVupz0OsDGhjUs9a8g3r8hCmgYp85R2szzz RM8yPWs4eBz+0KahHCx0mxaYsgVOiqtohfDEX4mkYAcoP8v6EGcSZ2YyRRZtP2gXFR0A yTaCvw42iFGs4E0Bk/bPCjZu9QvcdbIpWsJbgZtvJYNrEvH100ceebiM/RopLn4kVCV4 nEDXmUCqX5lZ6DxWMFotnKybLTmufARGLRpLSl4PpbaI0qGsyBs/8YPNSVZOEpFfaOP/ HPvw== X-Gm-Message-State: AO0yUKXlG/8e9NRpDF+SpSIYA5lxwHg7YDGBp+KiSdtn3+B3ZX2ITnSY jqTK3m2l5kRko3WObQ47ocY= X-Google-Smtp-Source: AK7set+sXlCjYusJUrXykr08BcUEl4vhrZ0H3Cy6wyqqZLIQsY0Q5IySc2AXhCCoiH8TTncxaLa63Q== X-Received: by 2002:a05:6a20:b915:b0:d6:b03d:a612 with SMTP id fe21-20020a056a20b91500b000d6b03da612mr562036pzb.23.1679365839313; Mon, 20 Mar 2023 19:30:39 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c15-20020aa78c0f000000b005a7c892b435sm7017068pfd.25.2023.03.20.19.30.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 19:30:38 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------R0Zdqj8iNhyQh6Tpl6FLdJDT" Message-ID: <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> Date: Mon, 20 Mar 2023 19:30:38 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <154bd0e9-2779-5a28-5587-a845a982e39f@yandex.ru> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> From: Jim Porter In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------R0Zdqj8iNhyQh6Tpl6FLdJDT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/19/2023 6:34 PM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > I definitely don't want to force preloading that module. > But maybe that var could have a meaning that's independent > from completion, thus justifying to move it out of the completion > extension module? Well, luckily(?) it turns out my patch wasn't quite right anyway, so I completely rewrote it. (In particular, it didn't correctly generate a top-level stub if there was a subcommand nested somewhere *inside* an argument.) With this change, we now have a more-general way of preventing commands that can cause side effects: 'eshell-allow-commands'. We can let-bind that to nil, and then any commands within an argument will signal an error. Then we just need to disable globbing via a different method (using the patch I originally posted), and all is well for this bug. I also added a couple preliminary patches to fix some semi-related issues I discovered while working on this. These could probably go in a separate bug, but I'm lazy. ;) The real meat of this change is patch 0003. --------------R0Zdqj8iNhyQh6Tpl6FLdJDT Content-Type: text/plain; charset=UTF-8; name="0001-Fix-an-edge-case-in-how-eshell-do-eval-handles-let-b.patch" Content-Disposition: attachment; filename*0="0001-Fix-an-edge-case-in-how-eshell-do-eval-handles-let-b.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0OTlkZDU3OGQ4MDcyZTU2ZDEyNjg3OTdkNTQwN2QwMjFjNGYxZDkzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjAgTWFyIDIwMjMgMTc6MjQ6MjggLTA3MDAKU3ViamVjdDogW1BB VENIIDEvM10gOyBGaXggYW4gZWRnZSBjYXNlIGluIGhvdyAnZXNoZWxsLWRvLWV2YWwnIGhh bmRsZXMgJ2xldCcKIGJvZGllcwoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlaGVsbC1k by1ldmFsKTogVXNlICdjYXItc2FmZSc7IHRoZSBvYmplY3QKaW4gcXVlc3Rpb24gbWlnaHQg bm90IGJlIGEgY29ucyBjZWxsLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgfCAyICst CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5l bAppbmRleCA5M2YyNjE2MDIwYy4uZTA2NTFiNzYyNDkgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNo ZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbApAQCAtMTE2OCw3 ICsxMTY4LDcgQEAgZXNoZWxsLWRvLWV2YWwKIAkoc2V0Y2FyIChjZHIgYXJncykgKGVzaGVs bC1kby1ldmFsIChjYWRyIGFyZ3MpIHN5bmNocm9ub3VzLXApKQogCShldmFsIGZvcm0pKQog ICAgICAgICgoZXEgKGNhciBmb3JtKSAnbGV0KQotICAgICAgICAod2hlbiAobm90IChlcSAo Y2FyIChjYWRyIGFyZ3MpKSAnZXNoZWxsLWRvLWV2YWwpKQorICAgICAgICAodW5sZXNzIChl cSAoY2FyLXNhZmUgKGNhZHIgYXJncykpICdlc2hlbGwtZG8tZXZhbCkKICAgICAgICAgICAo ZXNoZWxsLW1hbmlwdWxhdGUgImV2YWx1YXRpbmcgbGV0IGFyZ3MiCiAgICAgICAgICAgICAo ZG9saXN0IChsZXRhcmcgKGNhciBhcmdzKSkKICAgICAgICAgICAgICAgKHdoZW4gKGFuZCAo bGlzdHAgbGV0YXJnKQotLSAKMi4yNS4xCgo= --------------R0Zdqj8iNhyQh6Tpl6FLdJDT Content-Type: text/plain; charset=UTF-8; name="0002-Simplify-parsing-subcommands-slightly.patch" Content-Disposition: attachment; filename="0002-Simplify-parsing-subcommands-slightly.patch" Content-Transfer-Encoding: base64 RnJvbSAxYjZjOTg4ZWQ2OTdkZTljMzA2OTBhYTY5YzNmYzVhNWYzMDVhMzQyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjAgTWFyIDIwMjMgMTc6MjU6MjQgLTA3MDAKU3ViamVjdDogW1BB VENIIDIvM10gU2ltcGxpZnkgcGFyc2luZyBzdWJjb21tYW5kcyBzbGlnaHRseQoKVGhpcyBt YWlubHkgcmVkdWNlcyBzb21lIG92ZXJseS1kZWVwIGluZGVudGF0aW9uLCBidXQgYWxzbyBm aXhlcyBzb21lCm1pbm9yIGlzc3VlcyB3aXRoIHRoZSAiJDxzdWJjbWQ+IiBmb3JtOiBpdCB1 bm5lY2Vzc2FyaWx5IGFkZGVkICIgPgpURU1QIiAod2UgYWxyZWFkeSBzZXQgdGhpcyBsYXRl ciB2aWEgJ2VzaGVsbC1jcmVhdGUtaGFuZGxlcycpLCBhbmQgaXQKZGlkbid0IHByb3Blcmx5 IHVuZXNjYXBlIGlubmVyIGRvdWJsZSBxdW90ZXMuCgoqIGxpc3AvZXNoZWxsL2VzaC1jbWQu ZWwgKGVzaGVsbC1wYXJzZS1zdWJjb21tYW5kLWFyZ3VtZW50KTogU2ltcGxpZnkuCgoqIGxp c3AvZXNoZWxsL2VzaC12YXIuZWwgKGVzaGVsbC1wYXJzZS12YXJpYWJsZS1yZWYpOiBTaW1w bGlmeSBhbmQKZml4IGVkZ2UgY2FzZXMgaW4gIiQ8c3ViY21kPiIuCi0tLQogbGlzcC9lc2hl bGwvZXNoLWNtZC5lbCB8IDE0ICsrKy0tLS0KIGxpc3AvZXNoZWxsL2VzaC12YXIuZWwgfCA5 NSArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMg Y2hhbmdlZCwgNTUgaW5zZXJ0aW9ucygrKSwgNTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5k ZXggZTA2NTFiNzYyNDkuLjFhNDU4MjkwZGZlIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9l c2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTY3NSwxMyArNjc1 LDEzIEBAIGVzaGVsbC1wYXJzZS1zdWJjb21tYW5kLWFyZ3VtZW50CiAJICAgKG9yICg9IChw b2ludC1tYXgpICgxKyAocG9pbnQpKSkKIAkgICAgICAgKG5vdCAoZXEgKGNoYXItYWZ0ZXIg KDErIChwb2ludCkpKSA/XH0pKSkpCiAgICAgICAobGV0ICgoZW5kIChlc2hlbGwtZmluZC1k ZWxpbWl0ZXIgP1x7ID9cfSkpKQotCShpZiAobm90IGVuZCkKLSAgICAgICAgICAgICh0aHJv dyAnZXNoZWxsLWluY29tcGxldGUgInsiKQotCSAgKHdoZW4gKGVzaGVsbC1hcmctZGVsaW1p dGVyICgxKyBlbmQpKQotCSAgICAocHJvZzEKLQkJYChlc2hlbGwtYXMtc3ViY29tbWFuZAot ICAgICAgICAgICAgICAgICAgLChlc2hlbGwtcGFyc2UtY29tbWFuZCAoY29ucyAoMSsgKHBv aW50KSkgZW5kKSkpCi0JICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKSkKKyAgICAg ICAgKHVubGVzcyBlbmQKKyAgICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRlICJ7 IikpCisgICAgICAgICh3aGVuIChlc2hlbGwtYXJnLWRlbGltaXRlciAoMSsgZW5kKSkKKyAg ICAgICAgICAocHJvZzEKKyAgICAgICAgICAgICAgYChlc2hlbGwtYXMtc3ViY29tbWFuZAor ICAgICAgICAgICAgICAgICwoZXNoZWxsLXBhcnNlLWNvbW1hbmQgKGNvbnMgKDErIChwb2lu dCkpIGVuZCkpKQorICAgICAgICAgICAgKGdvdG8tY2hhciAoMSsgZW5kKSkpKSkpKQogCiAo ZGVmdW4gZXNoZWxsLXBhcnNlLWxpc3AtYXJndW1lbnQgKCkKICAgIlBhcnNlIGEgTGlzcCBl eHByZXNzaW9uIHdoaWNoIGlzIHNwZWNpZmllZCBhcyBhbiBhcmd1bWVudC4iCmRpZmYgLS1n aXQgYS9saXNwL2VzaGVsbC9lc2gtdmFyLmVsIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApp bmRleCA1ZDYyOTlhZjU2NC4uN2RjYWZmMWUyNGYgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxs L2VzaC12YXIuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXZhci5lbApAQCAtNTA3LDU1ICs1 MDcsNTYgQEAgZXNoZWxsLXBhcnNlLXZhcmlhYmxlLXJlZgogICAoY29uZAogICAgKChlcSAo Y2hhci1hZnRlcikgP3spCiAgICAgKGxldCAoKGVuZCAoZXNoZWxsLWZpbmQtZGVsaW1pdGVy ID9ceyA/XH0pKSkKLSAgICAgIChpZiAobm90IGVuZCkKLSAgICAgICAgICAodGhyb3cgJ2Vz aGVsbC1pbmNvbXBsZXRlICIkeyIpCi0gICAgICAgIChmb3J3YXJkLWNoYXIpCi0gICAgICAg IChwcm9nMQotICAgICAgICAgICAgYChlc2hlbGwtYXBwbHktaW5kaWNlcwotICAgICAgICAg ICAgICAoZXNoZWxsLWNvbnZlcnQKLSAgICAgICAgICAgICAgIChlc2hlbGwtY29tbWFuZC10 by12YWx1ZQotICAgICAgICAgICAgICAgIChlc2hlbGwtYXMtc3ViY29tbWFuZAotICAgICAg ICAgICAgICAgICAsKGxldCAoKHN1YmNtZCAob3IgKGVzaGVsbC11bmVzY2FwZS1pbm5lci1k b3VibGUtcXVvdGUgZW5kKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGNvbnMgKHBvaW50KSBlbmQpKSkKLSAgICAgICAgICAgICAgICAgICAgICAgIChlc2hlbGwt Y3VycmVudC1xdW90ZWQgbmlsKSkKLSAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1wYXJz ZS1jb21tYW5kIHN1YmNtZCkpKSkKLSAgICAgICAgICAgICAgIDs7IElmIHRoaXMgaXMgYSBz aW1wbGUgZG91YmxlLXF1b3RlZCBmb3JtIGxpa2UKLSAgICAgICAgICAgICAgIDs7ICIke0NP TU1BTkR9IiAoaS5lLiBubyBpbmRpY2VzIGFmdGVyIHRoZSBzdWJjb21tYW5kCi0gICAgICAg ICAgICAgICA7OyBhbmQgbm8gYCMnIG1vZGlmaWVyIGJlZm9yZSksIGVuc3VyZSB3ZSBjb252 ZXJ0IHRvIGEKLSAgICAgICAgICAgICAgIDs7IHNpbmdsZSBzdHJpbmcuICBUaGlzIGF2b2lk cyB1bm5lY2Vzc2FyeSB3b3JrCi0gICAgICAgICAgICAgICA7OyAoZS5nLiBzcGxpdHRpbmcg dGhlIG91dHB1dCBieSBsaW5lcykgd2hlbiBpdCB3b3VsZAotICAgICAgICAgICAgICAgOzsg anVzdCBiZSBqb2luZWQgYmFjayB0b2dldGhlciBhZnRlcndhcmRzLgotICAgICAgICAgICAg ICAgLCh3aGVuIChhbmQgKG5vdCBtb2RpZmllci1wKSBlc2hlbGwtY3VycmVudC1xdW90ZWQp Ci0gICAgICAgICAgICAgICAgICAnKG5vdCBpbmRpY2VzKSkpCi0gICAgICAgICAgICAgIGlu ZGljZXMgLGVzaGVsbC1jdXJyZW50LXF1b3RlZCkKLSAgICAgICAgICAoZ290by1jaGFyICgx KyBlbmQpKSkpKSkKKyAgICAgICh1bmxlc3MgZW5kCisgICAgICAgICh0aHJvdyAnZXNoZWxs LWluY29tcGxldGUgIiR7IikpCisgICAgICAoZm9yd2FyZC1jaGFyKQorICAgICAgKHByb2cx CisgICAgICAgICAgYChlc2hlbGwtYXBwbHktaW5kaWNlcworICAgICAgICAgICAgKGVzaGVs bC1jb252ZXJ0CisgICAgICAgICAgICAgKGVzaGVsbC1jb21tYW5kLXRvLXZhbHVlCisgICAg ICAgICAgICAgIChlc2hlbGwtYXMtc3ViY29tbWFuZAorICAgICAgICAgICAgICAgLChsZXQg KChzdWJjbWQgKG9yIChlc2hlbGwtdW5lc2NhcGUtaW5uZXItZG91YmxlLXF1b3RlIGVuZCkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29ucyAocG9pbnQpIGVuZCkp KQorICAgICAgICAgICAgICAgICAgICAgIChlc2hlbGwtY3VycmVudC1xdW90ZWQgbmlsKSkK KyAgICAgICAgICAgICAgICAgIChlc2hlbGwtcGFyc2UtY29tbWFuZCBzdWJjbWQpKSkpCisg ICAgICAgICAgICAgOzsgSWYgdGhpcyBpcyBhIHNpbXBsZSBkb3VibGUtcXVvdGVkIGZvcm0g bGlrZQorICAgICAgICAgICAgIDs7ICIke0NPTU1BTkR9IiAoaS5lLiBubyBpbmRpY2VzIGFm dGVyIHRoZSBzdWJjb21tYW5kIGFuZAorICAgICAgICAgICAgIDs7IG5vIGAjJyBtb2RpZmll ciBiZWZvcmUpLCBlbnN1cmUgd2UgY29udmVydCB0byBhIHNpbmdsZQorICAgICAgICAgICAg IDs7IHN0cmluZy4gIFRoaXMgYXZvaWRzIHVubmVjZXNzYXJ5IHdvcmsgKGUuZy4gc3BsaXR0 aW5nCisgICAgICAgICAgICAgOzsgdGhlIG91dHB1dCBieSBsaW5lcykgd2hlbiBpdCB3b3Vs ZCBqdXN0IGJlIGpvaW5lZCBiYWNrCisgICAgICAgICAgICAgOzsgdG9nZXRoZXIgYWZ0ZXJ3 YXJkcy4KKyAgICAgICAgICAgICAsKHdoZW4gKGFuZCAobm90IG1vZGlmaWVyLXApIGVzaGVs bC1jdXJyZW50LXF1b3RlZCkKKyAgICAgICAgICAgICAgICAnKG5vdCBpbmRpY2VzKSkpCisg ICAgICAgICAgICBpbmRpY2VzICxlc2hlbGwtY3VycmVudC1xdW90ZWQpCisgICAgICAgIChn b3RvLWNoYXIgKDErIGVuZCkpKSkpCiAgICAoKGVxIChjaGFyLWFmdGVyKSA/XDwpCiAgICAg KGxldCAoKGVuZCAoZXNoZWxsLWZpbmQtZGVsaW1pdGVyID9cPCA/XD4pKSkKLSAgICAgIChp ZiAobm90IGVuZCkKLSAgICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRlICIkPCIp Ci0gICAgICAgIChsZXQqICgodGVtcCAobWFrZS10ZW1wLWZpbGUgdGVtcG9yYXJ5LWZpbGUt ZGlyZWN0b3J5KSkKLSAgICAgICAgICAgICAgIChjbWQgKGNvbmNhdCAoYnVmZmVyLXN1YnN0 cmluZyAoMSsgKHBvaW50KSkgZW5kKQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICIg PiAiIHRlbXApKSkKLSAgICAgICAgICAocHJvZzEKLSAgICAgICAgICAgICAgYChsZXQgKChl c2hlbGwtY3VycmVudC1oYW5kbGVzCi0gICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1j cmVhdGUtaGFuZGxlcyAsdGVtcCAnb3ZlcndyaXRlKSkpCi0gICAgICAgICAgICAgICAgIChw cm9nbgotICAgICAgICAgICAgICAgICAgIChlc2hlbGwtYXMtc3ViY29tbWFuZAotICAgICAg ICAgICAgICAgICAgICAsKGxldCAoKGVzaGVsbC1jdXJyZW50LXF1b3RlZCBuaWwpKQotICAg ICAgICAgICAgICAgICAgICAgICAoZXNoZWxsLXBhcnNlLWNvbW1hbmQgY21kKSkpCi0gICAg ICAgICAgICAgICAgICAgKGlnbm9yZQotICAgICAgICAgICAgICAgICAgICAobmNvbmMgZXNo ZWxsLXRoaXMtY29tbWFuZC1ob29rCi0gICAgICAgICAgICAgICAgICAgICAgICAgICA7OyBR dW90ZSB0aGlzIGxhbWJkYTsgaXQgd2lsbCBiZSBldmFsdWF0ZWQKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgIDs7IGJ5IGBlc2hlbGwtZG8tZXZhbCcsIHdoaWNoIHJlcXVpcmVzIHZl cnkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHBhcnRpY3VsYXIgZm9ybXMgaW4g b3JkZXIgdG8gd29yawotICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgcHJvcGVybHku ICBTZWUgYnVnIzU0MTkwLgotICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgKGZ1 bmN0aW9uCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSAoKQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZS1maWxlICx0ZW1w KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdoZW4tbGV0ICgoYnVm ZmVyIChnZXQtZmlsZS1idWZmZXIgLHRlbXApKSkKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgKGtpbGwtYnVmZmVyIGJ1ZmZlcikpKSkpKSkKLSAgICAgICAgICAg ICAgICAgICAoZXNoZWxsLWFwcGx5LWluZGljZXMgLHRlbXAgaW5kaWNlcyAsZXNoZWxsLWN1 cnJlbnQtcXVvdGVkKSkpCi0gICAgICAgICAgICAoZ290by1jaGFyICgxKyBlbmQpKSkpKSkp CisgICAgICAodW5sZXNzIGVuZAorICAgICAgICAodGhyb3cgJ2VzaGVsbC1pbmNvbXBsZXRl ICIkPCIpKQorICAgICAgKGZvcndhcmQtY2hhcikKKyAgICAgIChsZXQqICgodGVtcCAobWFr ZS10ZW1wLWZpbGUgdGVtcG9yYXJ5LWZpbGUtZGlyZWN0b3J5KSkKKyAgICAgICAgICAgICAo c3ViY21kIChvciAoZXNoZWxsLXVuZXNjYXBlLWlubmVyLWRvdWJsZS1xdW90ZSBlbmQpCisg ICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnMgKHBvaW50KSBlbmQpKSkpCisgICAgICAg IChwcm9nMQorICAgICAgICAgICAgYChsZXQgKChlc2hlbGwtY3VycmVudC1oYW5kbGVzCisg ICAgICAgICAgICAgICAgICAgIChlc2hlbGwtY3JlYXRlLWhhbmRsZXMgLHRlbXAgJ292ZXJ3 cml0ZSkpKQorICAgICAgICAgICAgICAgKHByb2duCisgICAgICAgICAgICAgICAgIChlc2hl bGwtYXMtc3ViY29tbWFuZAorICAgICAgICAgICAgICAgICAgLChsZXQgKChlc2hlbGwtY3Vy cmVudC1xdW90ZWQgbmlsKSkKKyAgICAgICAgICAgICAgICAgICAgIChlc2hlbGwtcGFyc2Ut Y29tbWFuZCBzdWJjbWQpKSkKKyAgICAgICAgICAgICAgICAgKGlnbm9yZQorICAgICAgICAg ICAgICAgICAgKG5jb25jIGVzaGVsbC10aGlzLWNvbW1hbmQtaG9vaworICAgICAgICAgICAg ICAgICAgICAgICAgIDs7IFF1b3RlIHRoaXMgbGFtYmRhOyBpdCB3aWxsIGJlIGV2YWx1YXRl ZCBieQorICAgICAgICAgICAgICAgICAgICAgICAgIDs7IGBlc2hlbGwtZG8tZXZhbCcsIHdo aWNoIHJlcXVpcmVzIHZlcnkKKyAgICAgICAgICAgICAgICAgICAgICAgICA7OyBwYXJ0aWN1 bGFyIGZvcm1zIGluIG9yZGVyIHRvIHdvcmsKKyAgICAgICAgICAgICAgICAgICAgICAgICA7 OyBwcm9wZXJseS4gIFNlZSBidWcjNTQxOTAuCisgICAgICAgICAgICAgICAgICAgICAgICAg KGxpc3QgKGZ1bmN0aW9uCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChsYW1i ZGEgKCkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUg LHRlbXApCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHdoZW4tbGV0ICgo YnVmZmVyIChnZXQtZmlsZS1idWZmZXIgLHRlbXApKSkKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChraWxsLWJ1ZmZlciBidWZmZXIpKSkpKSkpCisgICAgICAgICAg ICAgICAgIChlc2hlbGwtYXBwbHktaW5kaWNlcyAsdGVtcCBpbmRpY2VzICxlc2hlbGwtY3Vy cmVudC1xdW90ZWQpKSkKKyAgICAgICAgICAoZ290by1jaGFyICgxKyBlbmQpKSkpKSkKICAg ICgoZXEgKGNoYXItYWZ0ZXIpID9cKCkKICAgICAoY29uZGl0aW9uLWNhc2UgbmlsCiAgICAg ICAgIGAoZXNoZWxsLWFwcGx5LWluZGljZXMKLS0gCjIuMjUuMQoK --------------R0Zdqj8iNhyQh6Tpl6FLdJDT Content-Type: text/plain; charset=UTF-8; name="0003-Avoid-parsing-some-Eshell-forms-when-performing-comp.patch" Content-Disposition: attachment; filename*0="0003-Avoid-parsing-some-Eshell-forms-when-performing-comp.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwYTA2YzFlNDFiY2MxMTlkYTI5ZjQ2ZTJmOWUxZTg1ZGEwNmRjNWIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjAgTWFyIDIwMjMgMTc6MjU6NTQgLTA3MDAKU3ViamVjdDogW1BB VENIIDMvM10gQXZvaWQgcGFyc2luZyBzb21lIEVzaGVsbCBmb3JtcyB3aGVuIHBlcmZvcm1p bmcKIGNvbXBsZXRpb24KCkR1cmluZyBjb21wbGV0aW9uLCB3ZSB3YW50IHRvIGV2YWx1YXRl IG1vc3QgRXNoZWxsIGZvcm1zCihlLmcuIHZhcmlhYmxlIHJlZmVyZW5jZXMpLCBidXQgc2tp cCBvdGhlcnMgKGUuZy4gZ2xvYmJpbmcsCnN1YmNvbW1hbmRzKS4gIEZvciBnbG9iYmluZywg d2Ugd2FudCB0byBwYXNzIHRoZSBsaXRlcmFsIGdsb2IgdG8KUGNvbXBsZXRlIHNvIGl0IGNh biB1c2UgdGhlIGdsb2IgZm9yIHNlbGVjdGluZyBjb21wbGV0aW9uIGNhbmRpZGF0ZXMuCkZv ciBzdWJjb21tYW5kcyAoaW5jbHVkaW5nIExpc3AgZm9ybXMpLCB3ZSBlc3BlY2lhbGx5IHdh bnQgdG8gYXZvaWQKZXZhbHVhdGlvbiwgc2luY2UgdGhleSBjYW4gcHJvZHVjZSBhcmJpdGFy eSBzaWRlIGVmZmVjdHMhICAoQnVnIzUwNDcwKQoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVs IChlc2hlbGwtYWxsb3ctY29tbWFuZHMpOiBOZXcgdmFyaWFibGUuLi4KKGVzaGVsbC1jb21t YW5kcy1mb3JiaWRkZW4pOiBOZXcgZXJyb3IuLi4KKGVzaGVsbC1uYW1lZC1jb21tYW5kLCBl c2hlbGwtbGlzcC1jb21tYW5kKTogLi4uIHVzZSB0aGVtLgoKKiBsaXNwL2VzaGVsbC9lbS1j bXBsLmVsIChlc2hlbGwtY29tcGxldGUtLWV2YWwtYXJndW1lbnQtZm9ybSk6CkRpc2FsbG93 IGNvbW1hbmQgZm9ybXMgYW5kIGhhbmRsZSBlcnJvcnMgb3Vyc2VsdmVzLgooZXNoZWxsLWNv bXBsZXRlLXBhcnNlLWFyZ3VtZW50cyk6IERvbid0IHBhcnNlIGdsb2IgY2hhcmFjdGVycy4K CiogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCihlbS1jbXBsLXRlc3QvcGFy c2UtYXJndW1lbnRzL3VuZXZhbHVhdGVkLXN1YmNvbW1hbmQpCihlbS1jbXBsLXRlc3QvcGFy c2UtYXJndW1lbnRzL3VuZXZhbHVhdGVkLWxpc3AtZm9ybSkKKGVtLWNtcGwtdGVzdC9maWxl LWNvbXBsZXRpb24vZ2xvYiwgZW0tY21wbC10ZXN0L2NvbW1hbmQtY29tcGxldGlvbikKKGVt LWNtcGwtdGVzdC9zdWJjb21tYW5kLWNvbXBsZXRpb24pOiBOZXcgdGVzdHMuCihlbS1jbXBs LXRlc3QvbGlzcC1mdW5jdGlvbi1jb21wbGV0aW9uKTogQ2hlY2sgIiQoZnVuYykiIHN5bnRh eC4KLS0tCiBsaXNwL2VzaGVsbC9lbS1jbXBsLmVsICAgICAgICAgICAgfCA2MCArKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAg ICAgICAgfCAxNSArKysrKysrKwogdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVs IHwgNTkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCiAzIGZpbGVzIGNoYW5nZWQs IDExMyBpbnNlcnRpb25zKCspLCAyMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNw L2VzaGVsbC9lbS1jbXBsLmVsIGIvbGlzcC9lc2hlbGwvZW0tY21wbC5lbAppbmRleCBiNjU2 NTIwMTlkNC4uNzMyYmJiM2YxZmEgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWNtcGwu ZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0tY21wbC5lbApAQCAtMzA2LDkgKzMwNiwyNCBAQCBl c2hlbGwtLXBjb21wbGV0ZS1pbnNlcnQtdGFiCiAKIChkZWZ1biBlc2hlbGwtY29tcGxldGUt LWV2YWwtYXJndW1lbnQtZm9ybSAoYXJnKQogICAiRXZhbHVhdGUgYSBzaW5nbGUgRXNoZWxs IGFyZ3VtZW50IGZvcm0gQVJHIGZvciB0aGUgcHVycG9zZXMgb2YgY29tcGxldGlvbi4iCi0g IChsZXQgKChyZXN1bHQgKGVzaGVsbC1kby1ldmFsIGAoZXNoZWxsLWNvbW1hbmRzICxhcmcp IHQpKSkKLSAgICAoY2wtYXNzZXJ0IChlcSAoY2FyIHJlc3VsdCkgJ3F1b3RlKSkKLSAgICAo Y2FkciByZXN1bHQpKSkKKyAgKGNvbmRpdGlvbi1jYXNlIGVycgorICAgICAgKGxldCogKDs7 IERvbid0IGFsbG93IHJ1bm5pbmcgY29tbWFuZHM7IHRoZXkgY291bGQgaGF2ZQorICAgICAg ICAgICAgIDs7IGFyYml0cmFyeSBzaWRlIGVmZmVjdHMsIHdoaWNoIHdlIGRvbid0IHdhbnQg d2hlbiB3ZSdyZQorICAgICAgICAgICAgIDs7IGp1c3QgcGVyZm9ybWluZyBjb21wbGV0aW9u cyEKKyAgICAgICAgICAgICAoZXNoZWxsLWFsbG93LWNvbW1hbmRzKQorICAgICAgICAgICAg IDs7IEhhbmRsZSBlcnJvcnMgb3Vyc2VsdmVzIHNvIHRoYXQgd2UgY2FuIHByb3Blcmx5IGNh dGNoCisgICAgICAgICAgICAgOzsgYGVzaGVsbC1jb21tYW5kcy1mb3JiaWRkZW4nLgorICAg ICAgICAgICAgIChlc2hlbGwtaGFuZGxlLWVycm9ycykKKyAgICAgICAgICAgICAocmVzdWx0 IChlc2hlbGwtZG8tZXZhbCBgKGVzaGVsbC1jb21tYW5kcyAsYXJnKSB0KSkpCisgICAgICAg IChjbC1hc3NlcnQgKGVxIChjYXIgcmVzdWx0KSAncXVvdGUpKQorICAgICAgICAoY2FkciBy ZXN1bHQpKQorICAgIChlc2hlbGwtY29tbWFuZHMtZm9yYmlkZGVuCisgICAgIChwcm9wZXJ0 aXplICJcMCIgJ2VzaGVsbC1hcmd1bWVudC1zdHViCisgICAgICAgICAgICAgICAgIChpbnRl cm4gKGZvcm1hdCAiJXMtY29tbWFuZCIgKGNhZHIgZXJyKSkpKSkKKyAgICAoZXJyb3IKKyAg ICAgKGx3YXJuICdlc2hlbGwgOmVycm9yCisgICAgICAgICAgICAiRmFpbGVkIHRvIGV2YWx1 YXRlIGFyZ3VtZW50IGZvcm0gZHVyaW5nIGNvbXBsZXRpb246ICVTIiBhcmcpCisgICAgIChw cm9wZXJ0aXplICJcMCIgJ2VzaGVsbC1hcmd1bWVudC1zdHViICdlcnJvcikpKSkKIAogKGRl ZnVuIGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMgKCkKICAgIlBhcnNlIHRoZSBj b21tYW5kIGxpbmUgYXJndW1lbnRzIGZvciBgcGNvbXBsZXRlLWFyZ3VtZW50Jy4iCkBAIC0z MjUsMjMgKzM0MCwyOCBAQCBlc2hlbGwtY29tcGxldGUtcGFyc2UtYXJndW1lbnRzCiAgICAg ICAoaWYgKD0gYmVnaW4gZW5kKQogCSAgKGVuZC1vZi1saW5lKSkKICAgICAgIChzZXRxIGVu ZCAocG9pbnQtbWFya2VyKSkpCi0gICAgKGlmIChzZXRxIGRlbGltCi0JICAgICAgKGNhdGNo ICdlc2hlbGwtaW5jb21wbGV0ZQotCQkoaWdub3JlCi0JCSAoc2V0cSBhcmdzIChlc2hlbGwt cGFyc2UtYXJndW1lbnRzIGJlZ2luIGVuZCkpKSkpCi0gICAgICAgIChjb25kICgobWVtYmVy IChjYXIgZGVsaW0pICcoInsiICIkeyIgIiQ8IikpCi0JICAgICAgIChzZXRxIGJlZ2luICgx KyAoY2FkciBkZWxpbSkpCi0JCSAgICAgYXJncyAoZXNoZWxsLXBhcnNlLWFyZ3VtZW50cyBi ZWdpbiBlbmQpKSkKLSAgICAgICAgICAgICAgKChtZW1iZXIgKGNhciBkZWxpbSkgJygiJCci ICIkXCIiICIjPCIpKQotICAgICAgICAgICAgICAgOzsgQWRkIHRoZSAoaW5jb21wbGV0ZSkg YXJndW1lbnQgdG8gb3VyIGFyZ3VtZW50cywgYW5kCi0gICAgICAgICAgICAgICA7OyBub3Rl IGl0cyBwb3NpdGlvbi4KLSAgICAgICAgICAgICAgIChzZXRxIGFyZ3MgKGFwcGVuZCAobnRo IDIgZGVsaW0pIChsaXN0IChjYXIgZGVsaW0pKSkKLSAgICAgICAgICAgICAgICAgICAgIGlu Y29tcGxldGUtYXJnIHQpCi0gICAgICAgICAgICAgICAocHVzaCAoLSAobnRoIDEgZGVsaW0p IDIpIHBvc25zKSkKLSAgICAgICAgICAgICAgKChtZW1iZXIgKGNhciBkZWxpbSkgJygiKCIg IiQoIikpCi0JICAgICAgICh0aHJvdyAncGNvbXBsZXRlZCAoZWxpc3AtY29tcGxldGlvbi1h dC1wb2ludCkpKQotCSAgICAgICh0Ci0JICAgICAgIChlc2hlbGwtLXBjb21wbGV0ZS1pbnNl cnQtdGFiKSkpKQorICAgIDs7IERvbid0IGV4cGFuZCBnbG9icyB3aGVuIHBhcnNpbmcgYXJn dW1lbnRzOyB3ZSB3YW50IHRvIHBhc3MgYW55CisgICAgOzsgZ2xvYnMgdG8gUGNvbXBsZXRl IHVuYWx0ZXJlZC4KKyAgICAoZGVjbGFyZS1mdW5jdGlvbiBlc2hlbGwtcGFyc2UtZ2xvYi1j aGFycyAiZW0tZ2xvYiIgKCkpCisgICAgKGxldCAoKGVzaGVsbC1wYXJzZS1hcmd1bWVudC1o b29rIChyZW1xICMnZXNoZWxsLXBhcnNlLWdsb2ItY2hhcnMKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZXNoZWxsLXBhcnNlLWFyZ3VtZW50LWhvb2sp KSkKKyAgICAgIChpZiAoc2V0cSBkZWxpbQorCSAgICAgICAgKGNhdGNoICdlc2hlbGwtaW5j b21wbGV0ZQorCQkgIChpZ25vcmUKKwkJICAgKHNldHEgYXJncyAoZXNoZWxsLXBhcnNlLWFy Z3VtZW50cyBiZWdpbiBlbmQpKSkpKQorICAgICAgICAgIChjb25kICgobWVtYmVyIChjYXIg ZGVsaW0pICcoInsiICIkeyIgIiQ8IikpCisJICAgICAgICAgKHNldHEgYmVnaW4gKDErIChj YWRyIGRlbGltKSkKKwkJICAgICAgIGFyZ3MgKGVzaGVsbC1wYXJzZS1hcmd1bWVudHMgYmVn aW4gZW5kKSkpCisgICAgICAgICAgICAgICAgKChtZW1iZXIgKGNhciBkZWxpbSkgJygiJCci ICIkXCIiICIjPCIpKQorICAgICAgICAgICAgICAgICA7OyBBZGQgdGhlIChpbmNvbXBsZXRl KSBhcmd1bWVudCB0byBvdXIgYXJndW1lbnRzLCBhbmQKKyAgICAgICAgICAgICAgICAgOzsg bm90ZSBpdHMgcG9zaXRpb24uCisgICAgICAgICAgICAgICAgIChzZXRxIGFyZ3MgKGFwcGVu ZCAobnRoIDIgZGVsaW0pIChsaXN0IChjYXIgZGVsaW0pKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgaW5jb21wbGV0ZS1hcmcgdCkKKyAgICAgICAgICAgICAgICAgKHB1c2ggKC0gKG50 aCAxIGRlbGltKSAyKSBwb3NucykpCisgICAgICAgICAgICAgICAgKChtZW1iZXIgKGNhciBk ZWxpbSkgJygiKCIgIiQoIikpCisJICAgICAgICAgKHRocm93ICdwY29tcGxldGVkIChlbGlz cC1jb21wbGV0aW9uLWF0LXBvaW50KSkpCisJICAgICAgICAodAorCSAgICAgICAgIChlc2hl bGwtLXBjb21wbGV0ZS1pbnNlcnQtdGFiKSkpKSkKICAgICAod2hlbiAoZ2V0LXRleHQtcHJv cGVydHkgKDEtIGVuZCkgJ2NvbW1lbnQpCiAgICAgICAoZXNoZWxsLS1wY29tcGxldGUtaW5z ZXJ0LXRhYikpCiAgICAgKGxldCAoKHBvcyAoMS0gZW5kKSkpCmRpZmYgLS1naXQgYS9saXNw L2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbAppbmRleCAxYTQ1 ODI5MGRmZS4uZDUyMzdlZTFmMDQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQu ZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbApAQCAtMjkzLDYgKzI5MywxNyBAQCBl c2hlbGwtbGFzdC1hc3luYy1wcm9jcwogCiBXaGVuIHRoZSBwcm9jZXNzIGluIHRoZSBDRFIg Y29tcGxldGVzLCByZXN1bWUgY29tbWFuZCBldmFsdWF0aW9uLiIpCiAKKyhkZWZ2YXIgZXNo ZWxsLWFsbG93LWNvbW1hbmRzIHQKKyAgIklmIG5vbi1uaWwsIGFsbG93IGV2YWx1YXRpbmcg Y29tbWFuZCBmb3JtcyAoaW5jbHVkaW5nIExpc3AgZm9ybXMpLgorSWYgeW91IHdhbnQgdG8g Zm9yYmlkIGNvbW1hbmQgZm9ybXMsIHlvdSBjYW4gbGV0LWJpbmQgdGhpcyB0byBhCitub24t bmlsIHZhbHVlIGJlZm9yZSBjYWxsaW5nIGBlc2hlbGwtZG8tZXZhbCcuICBUaGVuLCBhbnkg Y29tbWFuZAorZm9ybXMgd2lsbCBzaWduYWwgYGVzaGVsbC1jb21tYW5kcy1mb3JiaWRkZW4n LiAgVGhpcyBpcyB1c2VmdWwKK2lmLCBmb3IgZXhhbXBsZSwgeW91IHdhbnQgdG8gZXZhbHVh dGUgc2ltcGxlIGV4cHJlc3Npb25zIGxpa2UKK3ZhcmlhYmxlIGV4cGFuc2lvbnMsIGJ1dCBu b3QgZnVsbHktZXZhbHVhdGUgdGhlIGNvbW1hbmQuICBTZWUKK2Fsc28gYGVzaGVsbC1jb21w bGV0ZS1wYXJzZS1hcmd1bWVudHMnLiIpCisKKyhkZWZpbmUtZXJyb3IgJ2VzaGVsbC1jb21t YW5kcy1mb3JiaWRkZW4gIkNvbW1hbmRzIGZvcmJpZGRlbiIpCisKIDs7OyBGdW5jdGlvbnM6 CiAKIChkZWZzdWJzdCBlc2hlbGwtaW50ZXJhY3RpdmUtcHJvY2Vzcy1wICgpCkBAIC0xMzI4 LDYgKzEzMzksOCBAQCBlc2hlbGwvd2hpY2gKIChkZWZ1biBlc2hlbGwtbmFtZWQtY29tbWFu ZCAoY29tbWFuZCAmb3B0aW9uYWwgYXJncykKICAgIkluc2VydCBvdXRwdXQgZnJvbSBhIHBs YWluIENPTU1BTkQsIHVzaW5nIEFSR1MuCiBDT01NQU5EIG1heSByZXN1bHQgaW4gYW4gYWxp YXMgYmVpbmcgZXhlY3V0ZWQsIG9yIGEgcGxhaW4gY29tbWFuZC4iCisgICh1bmxlc3MgZXNo ZWxsLWFsbG93LWNvbW1hbmRzCisgICAgKHNpZ25hbCAnZXNoZWxsLWNvbW1hbmRzLWZvcmJp ZGRlbiAnKG5hbWVkKSkpCiAgIChzZXRxIGVzaGVsbC1sYXN0LWFyZ3VtZW50cyBhcmdzCiAJ ZXNoZWxsLWxhc3QtY29tbWFuZC1uYW1lIChlc2hlbGwtc3RyaW5naWZ5IGNvbW1hbmQpKQog ICAocnVuLWhvb2std2l0aC1hcmdzICdlc2hlbGwtcHJlcGFyZS1jb21tYW5kLWhvb2spCkBA IC0xNDY1LDYgKzE0NzgsOCBAQCBlc2hlbGwtbGFzdC1vdXRwdXQtZW5kCiAKIChkZWZ1biBl c2hlbGwtbGlzcC1jb21tYW5kIChvYmplY3QgJm9wdGlvbmFsIGFyZ3MpCiAgICJJbnNlcnQg TGlzcCBPQkpFQ1QsIHVzaW5nIEFSR1MgaWYgYSBmdW5jdGlvbi4iCisgICh1bmxlc3MgZXNo ZWxsLWFsbG93LWNvbW1hbmRzCisgICAgKHNpZ25hbCAnZXNoZWxsLWNvbW1hbmRzLWZvcmJp ZGRlbiAnKGxpc3ApKSkKICAgKGNhdGNoICdlc2hlbGwtZXh0ZXJuYWwgICAgICAgICAgICAg ICA7IGRlZmVycmVkIHRvIGFuIGV4dGVybmFsIGNvbW1hbmQKICAgICAoc2V0cSBlc2hlbGwt bGFzdC1jb21tYW5kLXN0YXR1cyAwCiAgICAgICAgICAgZXNoZWxsLWxhc3QtYXJndW1lbnRz IGFyZ3MpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwg Yi90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVzdHMuZWwKaW5kZXggZWE5MDdmMTk0NWQu LjFmNzcxMmUyM2QxIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWNtcGwtdGVz dHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1jbXBsLXRlc3RzLmVsCkBAIC0xMjMs NiArMTIzLDM2IEBAIGVtLWNtcGwtdGVzdC9wYXJzZS1hcmd1bWVudHMvdmFyaWFibGUvc3Bs aWNlCiAgICAgICAgICAgICAgIChjYXIgKGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVu dHMpKQogICAgICAgICAgICAgICAnKCJlY2hvIiAiZm9vIiAiYmFyIikpKSkpKQogCisoZXJ0 LWRlZnRlc3QgZW0tY21wbC10ZXN0L3BhcnNlLWFyZ3VtZW50cy91bmV2YWx1YXRlZC1zdWJj b21tYW5kICgpCisgICJUZXN0IHRoYXQgc3ViY29tbWFuZHMgcmV0dXJuIGEgc3R1YiB3aGVu IHBhcnNpbmcgZm9yIGNvbXBsZXRpb24uIgorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGlu c2VydCAiZWNobyB7ZWNobyBoaX0iKQorICAgKHNob3VsZCAoZXNoZWxsLWFyZ3VtZW50cy1l cXVhbAorICAgICAgICAgICAgKGNhciAoZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50 cykpCisgICAgICAgICAgICBgKCJlY2hvIiAsKHByb3BlcnRpemUKKyAgICAgICAgICAgICAg ICAgICAgICAgIlwwIiAnZXNoZWxsLWFyZ3VtZW50LXN0dWIgJ25hbWVkLWNvbW1hbmQpKSkp KQorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGluc2VydCAiZWNobyAke2VjaG8gaGl9IikK KyAgIChzaG91bGQgKGVzaGVsbC1hcmd1bWVudHMtZXF1YWwKKyAgICAgICAgICAgIChjYXIg KGVzaGVsbC1jb21wbGV0ZS1wYXJzZS1hcmd1bWVudHMpKQorICAgICAgICAgICAgYCgiZWNo byIgLChwcm9wZXJ0aXplCisgICAgICAgICAgICAgICAgICAgICAgICJcMCIgJ2VzaGVsbC1h cmd1bWVudC1zdHViICduYW1lZC1jb21tYW5kKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlbS1j bXBsLXRlc3QvcGFyc2UtYXJndW1lbnRzL3VuZXZhbHVhdGVkLWxpc3AtZm9ybSAoKQorICAi VGVzdCB0aGF0IExpc3AgZm9ybXMgcmV0dXJuIGEgc3R1YiB3aGVuIHBhcnNpbmcgZm9yIGNv bXBsZXRpb24uIgorICAod2l0aC10ZW1wLWVzaGVsbAorICAgKGluc2VydCAiZWNobyAoY29u Y2F0IFwiaGlcIikiKQorICAgKHNob3VsZCAoZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAg ICAgICAgICAgKGNhciAoZXNoZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAg ICAgICAgICBgKCJlY2hvIiAsKHByb3BlcnRpemUKKyAgICAgICAgICAgICAgICAgICAgICAg IlwwIiAnZXNoZWxsLWFyZ3VtZW50LXN0dWIgJ2xpc3AtY29tbWFuZCkpKSkpCisgICh3aXRo LXRlbXAtZXNoZWxsCisgICAoaW5zZXJ0ICJlY2hvICQoY29uY2F0IFwiaGlcIikiKQorICAg KHNob3VsZCAoZXNoZWxsLWFyZ3VtZW50cy1lcXVhbAorICAgICAgICAgICAgKGNhciAoZXNo ZWxsLWNvbXBsZXRlLXBhcnNlLWFyZ3VtZW50cykpCisgICAgICAgICAgICBgKCJlY2hvIiAs KHByb3BlcnRpemUKKyAgICAgICAgICAgICAgICAgICAgICAgIlwwIiAnZXNoZWxsLWFyZ3Vt ZW50LXN0dWIgJ2xpc3AtY29tbWFuZCkpKSkpKQorCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10 ZXN0L2ZpbGUtY29tcGxldGlvbi91bmlxdWUgKCkKICAgIlRlc3QgY29tcGxldGlvbiBvZiBm aWxlIG5hbWVzIHdoZW4gdGhlcmUncyBhIHVuaXF1ZSByZXN1bHQuIgogICAod2l0aC10ZW1w LWVzaGVsbApAQCAtMTUwLDYgKzE4MCwxNSBAQCBlbS1jbXBsLXRlc3QvZmlsZS1jb21wbGV0 aW9uL25vbi11bmlxdWUKICAgICAgICAgIChmb3J3YXJkLWxpbmUgLTEpCiAgICAgICAgICAo c2hvdWxkIChsb29raW5nLWF0ICJDb21wbGV0ZSwgYnV0IG5vdCB1bmlxdWUiKSkpKSkpKQog CisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxldGlvbi9nbG9iICgpCisg ICJUZXN0IGNvbXBsZXRpb24gb2YgZmlsZSBuYW1lcyB1c2luZyBhIGdsb2IuIgorICAod2l0 aC10ZW1wLWVzaGVsbAorICAgKGVydC13aXRoLXRlbXAtZGlyZWN0b3J5IGRlZmF1bHQtZGly ZWN0b3J5CisgICAgICh3cml0ZS1yZWdpb24gbmlsIG5pbCAoZXhwYW5kLWZpbGUtbmFtZSAi ZmlsZS50eHQiKSkKKyAgICAgKHdyaXRlLXJlZ2lvbiBuaWwgbmlsIChleHBhbmQtZmlsZS1u YW1lICJmaWxlLmVsIikpCisgICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFu ZC1jb21wbGV0ZSAiZWNobyBmaSouZWwiKQorICAgICAgICAgICAgICAgICAgICAiZWNobyBm aWxlLmVsICIpKSkpKQorCiAoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L2ZpbGUtY29tcGxl dGlvbi9hZnRlci1saXN0ICgpCiAgICJUZXN0IGNvbXBsZXRpb24gb2YgZmlsZSBuYW1lcyBh ZnRlciBwcmV2aW91cyBsaXN0IGFyZ3VtZW50cy4KIFNlZSBidWcjNTk5NTYuIgpAQCAtMTU5 LDYgKzE5OCwyMSBAQCBlbS1jbXBsLXRlc3QvZmlsZS1jb21wbGV0aW9uL2FmdGVyLWxpc3QK ICAgICAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1pbnNlcnQtYW5kLWNvbXBsZXRlICJlY2hv IChsaXN0IDEgMikgZmkiKQogICAgICAgICAgICAgICAgICAgICAiZWNobyAobGlzdCAxIDIp IGZpbGUudHh0ICIpKSkpKQogCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L2NvbW1hbmQt Y29tcGxldGlvbiAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGNvbW1hbmQgbmFtZXMgbGlr ZSBcImNvbW1hbmRcIi4iCisgICh3aXRoLXRlbXAtZXNoZWxsCisgICAoc2hvdWxkIChlcXVh bCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImxpc3RpZiIpCisgICAgICAgICAgICAg ICAgICAibGlzdGlmeSAiKSkpKQorCisoZXJ0LWRlZnRlc3QgZW0tY21wbC10ZXN0L3N1YmNv bW1hbmQtY29tcGxldGlvbiAoKQorICAiVGVzdCBjb21wbGV0aW9uIG9mIGNvbW1hbmQgbmFt ZXMgbGlrZSBcIntjb21tYW5kfVwiLiIKKyAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgIChzaG91 bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAieyBsaXN0aWYiKQorICAg ICAgICAgICAgICAgICAgInsgbGlzdGlmeSAiKSkpCisgICh3aXRoLXRlbXAtZXNoZWxsCisg ICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gJHsg bGlzdGlmIikKKyAgICAgICAgICAgICAgICAgICJlY2hvICR7IGxpc3RpZnkgIikpKSkKKwog KGVydC1kZWZ0ZXN0IGVtLWNtcGwtdGVzdC9saXNwLXN5bWJvbC1jb21wbGV0aW9uICgpCiAg ICJUZXN0IGNvbXBsZXRpb24gb2YgTGlzcCBmb3JtcyBsaWtlIFwiIydzeW1ib2xcIiBhbmQg XCJgc3ltYm9sXCIuCiBTZWUgPGxpc3AvZXNoZWxsL2VzaC1jbWQuZWw+LiIKQEAgLTE3NCw3 ICsyMjgsMTAgQEAgZW0tY21wbC10ZXN0L2xpc3AtZnVuY3Rpb24tY29tcGxldGlvbgogU2Vl IDxsaXNwL2VzaGVsbC9lc2gtY21kLmVsPi4iCiAgICh3aXRoLXRlbXAtZXNoZWxsCiAgICAo c2hvdWxkIChlcXVhbCAoZXNoZWxsLWluc2VydC1hbmQtY29tcGxldGUgImVjaG8gKGVzaGVs bC9lY2giKQotICAgICAgICAgICAgICAgICAgImVjaG8gKGVzaGVsbC9lY2hvIikpKSkKKyAg ICAgICAgICAgICAgICAgICJlY2hvIChlc2hlbGwvZWNobyIpKSkKKyAgKHdpdGgtdGVtcC1l c2hlbGwKKyAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtaW5zZXJ0LWFuZC1jb21wbGV0ZSAi ZWNobyAkKGVzaGVsbC9lY2giKQorICAgICAgICAgICAgICAgICAgImVjaG8gJChlc2hlbGwv ZWNobyIpKSkpCiAKIChlcnQtZGVmdGVzdCBlbS1jbXBsLXRlc3Qvc3BlY2lhbC1yZWYtY29t cGxldGlvbi90eXBlICgpCiAgICJUZXN0IGNvbXBsZXRpb24gb2YgdGhlIHN0YXJ0IG9mIHNw ZWNpYWwgcmVmZXJlbmNlcyBsaWtlIFwiIzxidWZmZXJcIi4KLS0gCjIuMjUuMQoK --------------R0Zdqj8iNhyQh6Tpl6FLdJDT-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 27 20:42:01 2023 Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 00:42:01 +0000 Received: from localhost ([127.0.0.1]:48600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgxPV-0000Dy-Fd for submit@debbugs.gnu.org; Mon, 27 Mar 2023 20:42:01 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:42525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgxPT-0000Dl-LH for 50470@debbugs.gnu.org; Mon, 27 Mar 2023 20:42:00 -0400 Received: by mail-wm1-f52.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so6361581wms.1 for <50470@debbugs.gnu.org>; Mon, 27 Mar 2023 17:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679964114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=WlET1RecoDW2EdDAs/X4h5DZA/RU8J60paJGyKfCpuc=; b=SbeUWinySiZ9GIvnoWhR7qVzFKw4QaWninibIKr6EysIql/FY0At3cpwBiW86yCVpM f6cwH9BMqHirrSc6sCX+8ull/oJDZsYbpi4w7M/ZENqz19ixVoX1LV5v5Ke+VHpMpFZl wc4DYdA2FbdvlSoFZ0sX59RFEaAXzgH40U7pJqY9FrCvAihmSi44GNo68kciRzGvk7OS SxC61mMTzbwztbD1hLsXvO0QNGs9IU49DutK/YKYqGIonKRTJsJhVPfjeFbL82Ufnd3z Eqt4+fV+yj80mBBeO+Lw4k3V+67dIduhWFqiwHFoXz5a44byABDHeB+YlRwSwvl/+mvw 55Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679964114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WlET1RecoDW2EdDAs/X4h5DZA/RU8J60paJGyKfCpuc=; b=SsyMXNSWo7iWTIcaQoQ11uldDtcXJxA1UtuZSEwo5ESGhqU9HjC+UH6Dshmaijn3kH Y4s4HmFGgq24c0cPoHiPfaQw6uObBGlFFqpxk+eMxyD/p81O08z1p8HCMSX3/RLdcJHh czlXk01gd+of8Nw4jsKJocSH1ON94L7NdeMVDi7SUaMVVqoGvGT7kmJKFqG6Qr9LIMCE IuuNG4NI787OsTRTgHSPNcMcUQOrONhyWmJPQbqiHt+VH8B8Q+v8DV9BywmbXGDo32RC ZO5sLRbdUJ2NMeu4F7v/r+HJj/dY4+tJqBgn35NPFH23eyHawPObiRpS+I4bRPyIM4f4 byzA== X-Gm-Message-State: AO0yUKVnuo3OTW+eIIKTbRdzWmE+14REP6qOHoQeEt9zpE5p9XmWqr3x DwxWLXJY44i7hzJ09AwSapM= X-Google-Smtp-Source: AK7set8d8v0z/Sjisp9qqSOc679CXFp9HAW6yDFtQsOSFRaJroLLQz0sPGiyRdUnBOV5/7rhHAksUw== X-Received: by 2002:a05:600c:ac3:b0:3ed:af6b:7faa with SMTP id c3-20020a05600c0ac300b003edaf6b7faamr10386869wmr.17.1679964113431; Mon, 27 Mar 2023 17:41:53 -0700 (PDT) Received: from [192.168.1.2] ([31.216.80.60]) by smtp.googlemail.com with ESMTPSA id s17-20020a7bc391000000b003ed2987690dsm15178355wmj.26.2023.03.27.17.41.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 17:41:52 -0700 (PDT) Message-ID: Date: Tue, 28 Mar 2023 03:41:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Jim Porter , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <815516d6-262b-4ef1-786e-ec5b4199847c@yandex.ru> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> From: Dmitry Gutov In-Reply-To: <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 21/03/2023 04:30, Jim Porter wrote: > On 3/19/2023 6:34 PM, Stefan Monnier via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> I definitely don't want to force preloading that module. >> But maybe that var could have a meaning that's independent >> from completion, thus justifying to move it out of the completion >> extension module? > > Well, luckily(?) it turns out my patch wasn't quite right anyway, so I > completely rewrote it. (In particular, it didn't correctly generate a > top-level stub if there was a subcommand nested somewhere *inside* an > argument.) > > With this change, we now have a more-general way of preventing commands > that can cause side effects: 'eshell-allow-commands'. We can let-bind > that to nil, and then any commands within an argument will signal an error. > > Then we just need to disable globbing via a different method (using the > patch I originally posted), and all is well for this bug. > > I also added a couple preliminary patches to fix some semi-related > issues I discovered while working on this. These could probably go in a > separate bug, but I'm lazy. 😉 The real meat of this change is patch 0003. Again, no proper review from me, but I've tried the patches. Completion looks good, just like with the previous one. But here's an error I encountered when trying to call a command with asterisks without expanding them with completion: $ ls ~/Documents/Sp* Wrong type argument: stringp, ("~/Documents/Spain/") This issue is present in master (without the patches applied), but not in emacs-29. The patch(es) fix a similar error in company-mode completion -- hopefully the straight evaluation could be fixed as easily. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 00:06:48 2023 Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 04:06:48 +0000 Received: from localhost ([127.0.0.1]:48646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph0bg-0005ch-5k for submit@debbugs.gnu.org; Tue, 28 Mar 2023 00:06:48 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:41488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph0be-0005cT-AW for 50470@debbugs.gnu.org; Tue, 28 Mar 2023 00:06:46 -0400 Received: by mail-pl1-f173.google.com with SMTP id k2so10442123pll.8 for <50470@debbugs.gnu.org>; Mon, 27 Mar 2023 21:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679976400; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=xKDE+7dluF+BQl/46hys4fyf7EO2qls8WYCgUobHDg8=; b=aXHP9gCQdQGkhrnvIq0VVypCJoI03NXKCWON8IUQw3zf2VQfGBl5qHT4HaCGhDhflt qMWSXHIcAWJs/IqMHy5/EjH2s4C0E9sLwZ5ufZ7HYkhL0B71jBQkbo7D/SKrnBr5GHNP ECl2OfJWWtOPQ00Qxcr2q0T4eofxzKkirCdHFkWMs7xnLWXVA2ohc+kBMqK1lF3E39vc DyuUA4dF8XZzL8O8ywN59RrtEcMkVcHVy7VmvyhxvKNxHrjPnVP2mbypWTrUG9DN/sXz CoQFqLUCHzebp35fLAj5pbvScMP9eckkcptO9RnAMesBYcdv8bauUpU/kR6UpqiweZim I43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679976400; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xKDE+7dluF+BQl/46hys4fyf7EO2qls8WYCgUobHDg8=; b=UqsDzEDHI+QlQtg7k+91E6msHS5wIDu7+ezTx82gqHHNGOB93Aj56HH4DaCgJfqVFs OwC9FrSQ3Kmq0iHDCooAGkLvBhEnEYvXxQsrPyvojDN37KJ/gA/QEYTPu1UfRjPMBeGu PkXMk8Kp/O+heYGS30jqVstrW2nke6YC3so819Gbtm2K0H4I1A4nR/QaxJVWGM+xgz/L XnlU8z+WjqQkGLa5bEWVvzoC3I1flKt1xytidrl/vXOECXIrrPub4Qilp9MH7lCD/5Pl 8i4bLgy6mwrV3bYDSOUd5zWxBfS9dUPdZAouQ5KhumA16CyRzfiFWm0hWNVoKU6FTPpz 0+kQ== X-Gm-Message-State: AAQBX9cNs3575bSWcXb48uOTt88P2QYELxISZFwLI1urin92s+CxSqAY hqtHGY5JDSrn6Fo5HoVm37U= X-Google-Smtp-Source: AKy350Z+S99uaQQ2Sk6f7aG+zuIEakBmuM+nQeHQoXfVRtl+NuEz/aDk+IJ+VcWSm8C+qyQwoH7obQ== X-Received: by 2002:a17:903:27c8:b0:19c:ca14:59ef with SMTP id km8-20020a17090327c800b0019cca1459efmr10941276plb.34.1679976400258; Mon, 27 Mar 2023 21:06:40 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k11-20020a170902760b00b001a2104d706fsm7954321pll.225.2023.03.27.21.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 21:06:39 -0700 (PDT) Message-ID: Date: Mon, 27 Mar 2023 21:06:39 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Dmitry Gutov , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/27/2023 5:41 PM, Dmitry Gutov wrote: > Again, no proper review from me, but I've tried the patches. Thanks for taking a look. I'll give it a couple more days in case Stefan has any thoughts, and if not, I'll merge the patches. > Completion looks good, just like with the previous one. > > But here's an error I encountered when trying to call a command with > asterisks without expanding them with completion: > > $ ls ~/Documents/Sp* > Wrong type argument: stringp, ("~/Documents/Spain/") And thanks for catching this. It was fallout from my fix to bug#28064. I've pushed a fix to master as 28a9438169. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 02:10:48 2023 Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 06:10:48 +0000 Received: from localhost ([127.0.0.1]:48717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph2Xg-0000eb-Hj for submit@debbugs.gnu.org; Tue, 28 Mar 2023 02:10:48 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:57464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph2Xe-0000eP-VJ for 50470@debbugs.gnu.org; Tue, 28 Mar 2023 02:10:47 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 41E3B80234; Tue, 28 Mar 2023 02:10:41 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E50698004C; Tue, 28 Mar 2023 02:10:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679983835; bh=Cw+eT5pzdYEzwhMWYIjDzk5Gv5pqjpBmS5BfVGees1Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=enT0NBEx825zWqgPaRYosclXAThcKiDgi5RTpupJyTy9IzIiDMojN10KDSbh305JT HuIhd1abqgJFw2F8dDzmTMN9QD0nhV9kWxCfUuMuaakGUVw6amfJZ+f2I8CvdBOjSm TwibvagWtLQP+tsFmccQ9XxXhQ5xosF+ZQozsvOxsSuSFu3nj1nLa5WZ3nHWAEg8OQ NVk+wh6H5XNZBMg5ImHwPTYZDLjH1Ud5l47cOPU0mJuAFGPqVjWlJcxUZyliLVDLwP QhPqhKJMYACsRUDmYNYqmhzsA93TCDH9m4XRJrniVuc9+Ful6y2BuaEpVwhGGdAOkb wZjH5Z47eazvQ== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A258F12326D; Tue, 28 Mar 2023 02:10:35 -0400 (EDT) From: Stefan Monnier To: Jim Porter Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' In-Reply-To: (Jim Porter's message of "Mon, 27 Mar 2023 21:06:39 -0700") Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> Date: Tue, 28 Mar 2023 02:10:34 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Thanks for taking a look. I'll give it a couple more days in case Stefan has > any thoughts, and if not, I'll merge the patches. Sorry, my thoughts have left the building, so just go ahead. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 13:43:58 2023 Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 17:43:58 +0000 Received: from localhost ([127.0.0.1]:50663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phDMU-0001xx-6e for submit@debbugs.gnu.org; Tue, 28 Mar 2023 13:43:58 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:60304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phDMR-0001xp-Lb for 50470@debbugs.gnu.org; Tue, 28 Mar 2023 13:43:57 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32SHZBj3003819; Tue, 28 Mar 2023 17:43:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=7G+C/lYyPDUPEumS39DW3m/7aq+pwzcI0kNP/qmsZEo=; b=JD8dXNSmsoq2JK0n1tjGzEVqXX7CMNkqlDwPhG0D1zNTpQ5G2bJkTqYkJpLhFWZObTJH azwPRInIDC6iyK6ASexvZ1EcKR4NKpgy95RYUt6H8xlbYHQbWAvvCyfJn4o58pqaz1qr YpFjQsbo3ySpdNnRAIKWuLIKPd+5SD/qX1dxf/BVO+xR+0TBFtD+E/sk2/Rd/93ANZ+a K9IU9/jp35qB0pXn+ShoDAcPycqnGlT3fnOlQfgSI+xr9fyqdX+nSDdE2T2aW37DbEvk V/F3NuDGzNms7k4h2WB95kWlaVqhBqTNkdJdrTvoGEyyKFJy5KVc97wsi62TyYYTCCiD 5g== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3pm4rgg0t3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Mar 2023 17:43:54 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32SGlJAD008677; Tue, 28 Mar 2023 17:43:41 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3phqdd8pjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Mar 2023 17:43:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i10RE5i5dMyVcctNMtPShGEr+O9Pdw7CuDgXXEoMg68AEh6jNH0iSHTr2zrIX1UFPlCZ+sbQUsQO9aGGgZje4ABpDzezJ8Kal/DDvFac7oh7EkJd+LFNQB/eu++DkDp3XTOu3KhpzGREH6uZ2kh1z0LTcn8MB5TISPBiZ3IyNgtAOx5cd+XtCYtLcN5ADdgU7UgKhwOxRlE7UOqn9wYXXUTWmu0/sqDlTV2By02Xw4H3cwPxUbnzW5pppFDEiC459DvOImH6SbkuuPgY7yOjo2R67H9Rh6gAe1I3z24RtQ1LWb7m+/YHKU2E21PQajv33n8Fnlx9PIh3QfDTAC5TOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7G+C/lYyPDUPEumS39DW3m/7aq+pwzcI0kNP/qmsZEo=; b=kAbZxHoTdAJZ+JDKJYhI6J5+bqRR2jF3S98c4b3+QUI6BCqTtqMDnTVjIuaq4UdJaMfxOMKPtriWEn9LmJtpE50Fxetr3fsRthl/PrpqhY3CgfGhqFq/99wI4Og2Lqydb8laovEJ9/sjzaqeuawJxa07JzGT81/X7rGeR/fPYNwXrKCYxXXGeJxq5lBd95xaEkl9zrF4Fb4EtjPyREMMMCqAVIvOmrBMl7Bi/B9bYWWLTtGL06G4hJn/H5GV+kUN+++XhRyfEYioMVUTg3R1W3VtXMEZFqTvJzvH2nJIVrID+1j2YQUr643zJ77eM+MR3KbReX8EfAZqNM2rroa76g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7G+C/lYyPDUPEumS39DW3m/7aq+pwzcI0kNP/qmsZEo=; b=u6F49Lx2sncZfjK4VfOCDQy5VKWjl2ngU1TCktGv8gRS/qyQzBK40k9om8ZvXO6WDluU42sxWhXkbbtW5Lbzm22YkJs7ZYil9Jjt47O8XOuN1hRubjT4DEz6oxSiymxvxeMIJQVyjeJJ2OYagJS+YtrS5YVFe6uVGP5s9Jmsjzc= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by SA2PR10MB4635.namprd10.prod.outlook.com (2603:10b6:806:fb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.32; Tue, 28 Mar 2023 17:43:37 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a995:2ae5:2745:24ff]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::a995:2ae5:2745:24ff%5]) with mapi id 15.20.6222.030; Tue, 28 Mar 2023 17:43:37 +0000 From: Drew Adams To: Stefan Monnier , Jim Porter Subject: RE: [External] : bug#50470: 27.1; 'company-mode' 'eshell' Thread-Topic: [External] : bug#50470: 27.1; 'company-mode' 'eshell' Thread-Index: AQHZYTwgDiJgg6fSUEa5L93ms0w2ua8QdsMw Date: Tue, 28 Mar 2023 17:43:37 +0000 Message-ID: References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <01845bee-7637-76f6-2e86-2e2de91f6f6e@yandex.ru> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|SA2PR10MB4635:EE_ x-ms-office365-filtering-correlation-id: 40d3c68f-afd0-4624-03e2-08db2fb3f5d6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cvi4tmtiGC5cmHeeE+ecGkgv997qjFItEiEumY+bW7nsF9iLc3errbDsQzBaGmm920AM69GJez6FEOfsr0ZG6hEYdob/PjvNE9+7IsgOA4eAWlDc22D3D2E/CqefbmO4tjOPvc2p3W3NUxPBykG/Fd7xRRqkMbCw6Es0XwLf6fpIY2a2PNhZsxFuh5R5kgjuLqyvQSgFP1b0EIQtYgYnKbsrXTTBL20EIDvBhw8Wqd8yL8+Ovs/zmlWwVN4dF73jixFfjzlVWWb1qjVhv3p4s+bQUE0LKlzTktENv+S+LtC260uo8iNRJr5FSGiIk6H+sFfZnmWVkRqtjBA4XklY9zKHFJrIMVvLRC24NznJz16qmvB2S3KFWNMRGwgfmvm8wlHB2UJqBZkeLNT4wMqx1gyAHSMglIu49mIfalk65MLA2Hf9Is4v1aaOdgNgaBJRNwiQqgrHO1yU5fRDIz8Kt+udrzXry8PrKx90sOeiA1rglTUQ4ouoHKl+lIS7haOVfJ7tIiy4voW/M6xAJLO3ECIeq0o9RtU96FOwNNf8JdPLKyVSZsSUNlOVk3S7pbDbhuMVjHgtn80Ifhxaa6ljNHE01R9f69bEA6dk9UR++0s= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(346002)(376002)(136003)(39860400002)(396003)(451199021)(478600001)(64756008)(122000001)(66556008)(41300700001)(296002)(66446008)(4326008)(66946007)(8676002)(66476007)(316002)(5660300002)(8936002)(44832011)(54906003)(186003)(76116006)(52536014)(26005)(6506007)(7696005)(9686003)(55016003)(71200400001)(110136005)(38100700002)(38070700005)(86362001)(2906002)(33656002)(558084003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yowKAmbJ5aZn/dwL5bn9XmdpDmJYAENc10AYIQVr9DecfGYg1tDYtgMijuI/?= =?us-ascii?Q?KC+fcM+qN/XawqSyqyvWykcFEEcXfQ/FalcMRijn2KYZpBZfCUIYHedLWi5A?= =?us-ascii?Q?ftXkctbJUgoTwRF6pfZ71VMwkebQIOByLy2IV1b/lLqepRNyQIzSmsyFRtap?= =?us-ascii?Q?KbZjxsyry+oy4vozk7ERz6xHgFv0aF9eDTAw4MDOreBdVIhEo6q+uQsZPlyW?= =?us-ascii?Q?71r+tu7j7EJLLGBUW9isCci7q0wmBku6fKKZB2Hufftc1jNv2nrcAeS2bb60?= =?us-ascii?Q?I8CE8z1CN6NY2M9p0bllmpkvgSaNfgtsKi9zto2BPceqhzZ9SV6lYLa1WTEz?= =?us-ascii?Q?C0JzqymYdR3ytnW/MlCg/yuVUxoyKn3+sENTXPuB0QHNnjs8gg/pkH7haNNc?= =?us-ascii?Q?7aa4q1HAVaP0UG8R4vzJsV6eBQUemdEyGfhGiCHGXifXwkUUkdaXmUe3ffKB?= =?us-ascii?Q?Ge/m1nWmRXnxoNwcLhBF1gMEUDoAxgb+vIpjp8kTiJFUfCmfcOVvIk6PGzQA?= =?us-ascii?Q?g+wlR+eLyMioSHKd3zHJPkbDxW2BxmcA5+AE8U8x1erJg64zLGNM73O+F7/Q?= =?us-ascii?Q?R0GX6Y8arJNdCdhuFLWPsqbfDPL/8lmLBvwBv4epUYC25xwC2KPKeUGipXM2?= =?us-ascii?Q?GXECC7jgCldlNbZzpMjGy+6sRM21OLZUnfF5hUxO8dkRQUZvKPTeLcaENMgC?= =?us-ascii?Q?7f5RGtsNSPVBgvQfbhn5fNoYgUHUpX8DClsf0XdHMCDAnj88FAhbXUOPovGB?= =?us-ascii?Q?5GH4I5MdmBNBrW8VeN1BkukfILbUmmEESCGAh8kvcl+BmHGj8ZXaDGbNHyCg?= =?us-ascii?Q?n0jBXqeWqTRsiPL8TUyfJfdZJEP+mbJHQUox25sWP/h0W1IauvC8p/WjzX0v?= =?us-ascii?Q?nvK8531w/jFM6jH4yQGWLGYib2fwtYnPRRUeAY0mrtSJsnTNnkg0/mt1+ho7?= =?us-ascii?Q?2TTQCUDNXXkV43hULer9nW/w0h7Bxe6tOiednzEq48904iWoxWSvV8Nmy8ZQ?= =?us-ascii?Q?FRnrZegjrGLxIgHcktxmKRUHcWBaPiU55q2c1enn9X0ppVXBAZstu2dOTOm0?= =?us-ascii?Q?XzH4GmOljzCojYTRF2G9feIs3Htl2RKR1orwNkU2fkKyVazrypdKHvHB5n5o?= =?us-ascii?Q?oAjLFJ+nWWHVhRFdgzYSba4qSXZDk3DfdpxNfSVqArIIFLPIm1h2BL39VhG1?= =?us-ascii?Q?SBWGqgZJtkkTjqK+yOItRGXroOdiqTE4Fg78f3T68/tm2UfYHcr35crtyh2B?= =?us-ascii?Q?K2iQ3MmDNxBnxhCh28hJGc6594TSyV0wQvVYNd/eOAhs+1twkP0aXTxJ+9oJ?= =?us-ascii?Q?6Z4KAoREo6vnCA5KAYu+Ucnqt0gpsCrY9GQuyYbFLUwd+MQJzX0MwLca1Jxw?= =?us-ascii?Q?CrPygbz+Psh5+5L8cmeIcI+Ec789fPibJ1FEKpbw++KbGZUAJKfvxMMkwSZc?= =?us-ascii?Q?DHge+PW8C9derwQ7bYqi0fVDyhg1pPyfXO7T/x7HK0p7PqpoTFID9LCJb/x9?= =?us-ascii?Q?ae5PRfGklO66NmGwRI+pfAQrmUn3iPR96juhqdJ61nvxwBMssJCk0QtNN2Fk?= =?us-ascii?Q?TVu6bksykcXNRH8RuD7AxULl/XubKV9dVtbvdNlF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: J+eeP1Juc7KWVKchOYWkGEGjct/vDHeE0ieVFynPWeD333Yl6esGF75HR9uECRAYwf29rS0ebswKqajlnGBDo6Al70QKxXPfTGuRw9bXwR1crE6RRawOT9ovxUotLLHfO/XXboGaGsW5v349ZNfvQQk4hRHmE9r2uxsCjRZY+JOqNOHzsXsomT91Kdtu2ocPBnUuuNAavnQNMIkDnyFF8I2E3DBoap80kZWT0lU00lTCC720ZkIER/8R6b738tjZKPQwyWqcA9a8sA2JHNhhPI4HKTMTFVTY4qOyoAev2NpBRQmnViD1Cnk/m4UwyUCWZer8AOwuuxIdaXym6xdFW0cTw8Z/qj5e4b2rCk9Sc9P+ccMCh1zX9QQbHTBADPIxBBi8Df3iy5oOfKeHdpASvjkCRAq3HAy+ECMAZ0QFmXfkAGEQYXew/e9ccnKl8NjXdk98BXBtp1AygqBQgI36oZCpGgmLEgRWDli7tST1IiiofmZ3YtrxADlb+FGXoUsW5v5pgRohdVPnU2IatdSu2+fillaVqKqrs1DiwiCAqv8u65M/v38HVP8HdwIyBH/KdDQVekmydWtJoqk7jkFt6VFjqw10w2dviTWS6jPw2Yk1JatWJBv2LXwOR5n3GIji6SKgHRnpkbnu0bXXXL0VTU/8gPbgZZjaLLo3eoacgOQJQzmtPxFp1O3jvL4lTuOynKfPNrpPvClnBSrI3xhnq6lsb1N9yodMUI0U4slckwSSj9qFbJzz6h+i3hyfSZHr44Pu15ufpQ1eaet3G7OF8GkjyFvTF0WU8LJV5tHGsFwzj9hiUWyr/NrxKcALGgRfKOLh1utyfvM3m/B/Fp4a6Ev591SVrQRWDByiw7rHynBI+6yxCAygRscbsKKx8gE07NvjnbtmdrnVY9nTjBIpIsvu3eTG1HxvbJzpKODFpeM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40d3c68f-afd0-4624-03e2-08db2fb3f5d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2023 17:43:37.3080 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x/RGKUTDG8u/cYQ7Fuq+ZtThUdnigSD73Ppb8nnJyTKNx2gG19WEoTScrpayK4bXNMevmAecW2rQvIG4Xhv5kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4635 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 malwarescore=0 mlxlogscore=655 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303280139 X-Proofpoint-ORIG-GUID: Xeu0yx5n-MGCAmLFqRNCj0umEYdlnoje X-Proofpoint-GUID: Xeu0yx5n-MGCAmLFqRNCj0umEYdlnoje X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , "50470@debbugs.gnu.org" <50470@debbugs.gnu.org>, John Wiegley , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Sorry, my thoughts have left the building, so just go ahead. Think I saw a few of them jumping over a fence next to University Ave. They looked to be having fun. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 15:35:12 2023 Received: (at 50470) by debbugs.gnu.org; 28 Mar 2023 19:35:12 +0000 Received: from localhost ([127.0.0.1]:50738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phF68-0004xG-3T for submit@debbugs.gnu.org; Tue, 28 Mar 2023 15:35:12 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:37533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phF66-0004x1-DF for 50470@debbugs.gnu.org; Tue, 28 Mar 2023 15:35:10 -0400 Received: by mail-pj1-f47.google.com with SMTP id e15-20020a17090ac20f00b0023d1b009f52so16239252pjt.2 for <50470@debbugs.gnu.org>; Tue, 28 Mar 2023 12:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680032104; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=thE6GyHtx80/rB/wFaEt7kKJpYNguwI1lrRc25UUrPU=; b=ZBIhLsQ7oLbGubDadkxFZLJO0T68iuh2lBxyWOpv1oxP3lrg0sD7QLmv37T2snrAYL PicgQzJ/KYXQzITuHjqqBQbF1bcpmQNV8j/4t8D2+3nS8ALmOqfVHlTG9PLvKLQLeMAM xDgcP0efzUivqv3GOgpO81RXjM2jAHlBkbQXQTQCtiAfo5IXaOXXue5m3m1MgIGjFLPT sm6fxm9U9q5//2FOv2yJmVZNixRNGL7RG0fF25rc1L348ztgrkloykLi1X86mW35QqpA 69E5mlvw2z9Jn5VnHDFOybFz69zMcTsfZa32l4KSr6/Cjvpv0tMEidQIU8Zhr/v47EcA GXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680032104; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=thE6GyHtx80/rB/wFaEt7kKJpYNguwI1lrRc25UUrPU=; b=J7U53L5bcg+fFuBfIfeqWnSDxTA6ToSsAVmL03iHUtmW6h9Bp4oHcGZS2QKS5Xkk9i ECW8NwrFUp4lHC93R0DmPdyFnWRMCvPH+m/qPBR8fZ7xG3dPaz//JVdDSxXYkqy0ZfdB 71vb8dj/3NoBcGiCNqlj09bkw8l7scVIoXBsh0J91zdGCxw/RLtTNg2mr+dGIUjZJs3Z qHcb0bTXpMu9M2RW9kDOM6ep5sBsYLVpPmWxBhaj1gqfcgWRt+gCS8BTTFwEUyS3iTdY P5NAwmJNlK7L8wK5BTIuJXq3n5TxVN94JiMqL3qiR/IfMJm4WV20mgqoT7z5+15tuXMd ISng== X-Gm-Message-State: AO0yUKVffSPhShVypGkbfH4DVPr/jkislCu16np73jFvm6MdQqRadqJB aT5TiNapI5rSQSUGgIQE8bk= X-Google-Smtp-Source: AK7set9owynO8p1a6zZ/4xSO+W6kpKUnw6Z7DPbBdJjJT2yxfPIRObziGj9CBIrx00SCb27FMHK3+A== X-Received: by 2002:a05:6a20:92a4:b0:da:38d2:c27a with SMTP id q36-20020a056a2092a400b000da38d2c27amr14737270pzg.1.1680032104151; Tue, 28 Mar 2023 12:35:04 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d18-20020aa78692000000b0062a515874b4sm10658662pfo.32.2023.03.28.12.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 12:35:02 -0700 (PDT) Message-ID: <3efc3868-72d9-90af-728d-3cfe58f17bb5@gmail.com> Date: Tue, 28 Mar 2023 12:35:01 -0700 MIME-Version: 1.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50470 Cc: Christophe , 50470@debbugs.gnu.org, John Wiegley , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/27/2023 11:10 PM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> Thanks for taking a look. I'll give it a couple more days in case Stefan has >> any thoughts, and if not, I'll merge the patches. > > Sorry, my thoughts have left the building, so just go ahead. Thanks. Pushed as cde38f0df3f. Is there anything left to do on this bug now? It seems to me that we could close it, but I came into this discussion pretty late, so I don't want to jump the gun... From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 17:21:20 2023 Received: (at 50470-done) by debbugs.gnu.org; 28 Mar 2023 21:21:20 +0000 Received: from localhost ([127.0.0.1]:50799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phGkq-00085z-5N for submit@debbugs.gnu.org; Tue, 28 Mar 2023 17:21:20 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:55163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phGko-00085m-EP for 50470-done@debbugs.gnu.org; Tue, 28 Mar 2023 17:21:18 -0400 Received: by mail-wm1-f41.google.com with SMTP id s13so7727013wmr.4 for <50470-done@debbugs.gnu.org>; Tue, 28 Mar 2023 14:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680038472; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=SimXgtQEMgKcuBe8HeENxiuQp8hD2eT6gBx8yOcyL54=; b=pRXvWFvMTqxang6G4hNbvU0YxjKYYjaN1cMVEp+J9wBWn9GxMLr3WGs6zYt06hXAiu 4Kl1BWDTG7nsFpGYj8DME6k790pQAf6GVI5hA6cDcoBZ8J0eIE0twb+vVTCyzvAKADW1 MrkVjox2MHu+yhpFuNS3yHJ6Kdl2llNSzuK3g01jPbzrua0F+8/mjJ+4jYGGfVzhooZH KmT7kO0QFYkRZlei3eVXz+WLIEojbUkxX1SpvZamsy/rKXboOPfZy1ZoEPdTn555Gmx9 vy31YNZq4OusFDDMs8SxpQes2owFZzaZPGnLci/JjH4YHrmkA5crXfXhqkcdBD9fD+xr b8Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680038472; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SimXgtQEMgKcuBe8HeENxiuQp8hD2eT6gBx8yOcyL54=; b=PaksQvnXUm59PMJV2HSti+IfeGEEYwMJi3GQ+kxq9T+0VolsJzCQ8NpD98YrahXWu5 dHnu3Jvle2IOx4uJAJFaMLx6VgtV0udEBOb4D959impeu8ZuIxiflwox/8Nw9g9aQe2A vAzrB7+WDXQRb62yGi015GxA30f7UFt0Osnk+Ks3K5mUpMMI6QSGOZBQLqXskYi4Wwa7 sJBHSf6NRe4ebqWpGrZRm7gRd1u7W107NAWdwDXNhPuTdRr8/TZvaQwEOHJ1E8T9dKPV hiBJoPC+7ALtBtTysmUzes1guByvFyZ2nbykvhaq+ARZgMf27vZC2pyR4Uh30PK2j9z+ ZirA== X-Gm-Message-State: AO0yUKWvBMzvd5pdvYLPCEJIF2CQN20Ir4Iv7w1ftvWQpUHIn9nA62m1 yaBs9TuigbwiCQo5zjEPbn8= X-Google-Smtp-Source: AK7set9q1PDsVHzOm+r68MDp0KDcV+O5Zf5uWIP5CjdL78d/Zivw1WugoS1LKsygl6SHkjyGbMe4dA== X-Received: by 2002:a7b:c4c6:0:b0:3ee:5754:f139 with SMTP id g6-20020a7bc4c6000000b003ee5754f139mr13383505wmk.13.1680038472519; Tue, 28 Mar 2023 14:21:12 -0700 (PDT) Received: from [192.168.1.2] ([31.216.80.60]) by smtp.googlemail.com with ESMTPSA id s15-20020a05600c45cf00b003eb2e33f327sm5297940wmo.2.2023.03.28.14.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 14:21:12 -0700 (PDT) Message-ID: <2a45b90d-2b1a-660c-f161-84970ad25c7e@yandex.ru> Date: Wed, 29 Mar 2023 00:21:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: bug#50470: 27.1; 'company-mode' 'eshell' Content-Language: en-US To: Jim Porter , Stefan Monnier References: <87h7evegav.fsf@debian-BULLSEYE-live-builder-AMD64> <0e8cc089-63ae-71b5-9617-ce76478d3ba4@yandex.ru> <602e2d92-7914-0e2b-b06e-0d47d0ac8c99@yandex.ru> <20ee85be-aafc-8942-14ea-b0c2a1abc2c9@yandex.ru> <00ad5c72-20c5-d27e-2bc8-6436858bbd8d@gmail.com> <5d0b85af-2cd0-bc7c-16ca-17ecd2cbf12c@yandex.ru> <0c63be3e-5c7d-bea4-e23d-606abe59a847@gmail.com> <48cd486a-c554-5bab-cd67-713e21732500@gmail.com> <3efc3868-72d9-90af-728d-3cfe58f17bb5@gmail.com> From: Dmitry Gutov In-Reply-To: <3efc3868-72d9-90af-728d-3cfe58f17bb5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 50470-done Cc: Christophe , John Wiegley , 50470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 28/03/2023 22:35, Jim Porter wrote: > On 3/27/2023 11:10 PM, Stefan Monnier via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >>> Thanks for taking a look. I'll give it a couple more days in case >>> Stefan has >>> any thoughts, and if not, I'll merge the patches. >> >> Sorry, my thoughts have left the building, so just go ahead. > > Thanks. Pushed as cde38f0df3f. > > Is there anything left to do on this bug now? It seems to me that we > could close it, but I came into this discussion pretty late, so I don't > want to jump the gun... Looks like there's not. Everything that I tried, has worked well. Thanks for the fixes! Closing. From unknown Fri Jun 20 05:26:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Apr 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator