GNU bug report logs - #50425
[PATCH] gnu: Add minetest-advtrains.

Previous Next

Full log

Message #38 received at 50425 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Xinglu Chen <public <at> yoctocell.xyz>, Maxime Devos
 <maximedevos <at> telenet.be>,  50425 <at> debbugs.gnu.org
Subject: Re: [bug#50425] [PATCH] gnu: Add minetest-advtrains.
Date: Thu, 16 Sep 2021 10:36:10 +0200

[Message part 1 (text/plain, inline)]

Hello,

Le jeudi 16 septembre 2021 à 10:03 +0200, Xinglu Chen a écrit :
> > +This modpack contains the trains which were the \"default\" trains
> in
> > +advtrains up to version 2.2.1.")
> 
> I would use ``default'', which is the correct Texinfo syntax,
> instead of "default".  See the Texinfo manual for more details:
> https://www.gnu.org/software/texinfo/manual/texinfo/html_node/Inserting-Quotation-Marks.html
> 
You are correct, I changed it. Guix lint does not like it that much,
because it thinks it is a lazy shortcut for @code{}, but I guess guix
lint can be wrong sometimes.

> > +(define-public minetest-advtrains
> > +  (package
> > +    (name "minetest-advtrains")
> > +    (version "2.3.1")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +             (url "https://git.bananach.space/advtrains.git")
> > +             (commit "release-2.3.1")))
> 
> This would preferably be (commit (string-append "release-" version)),
> that means that you only have to update the ‘version’ field and the
> hash
> when updating the package (assuming it doesn’t need additional
> dependencies or change build system, etc.).

This is a temporary fix because the contentdb importer (and future
updater) should get the commit ID from the minetest contentdb. For
minetest-advtrains, it is broken right now, so I had to guess which
commit it is, but it may be fixed soon. I added your change because it
makes more sense, but I don’t know if it will be relevant for long.

Vivien

[0004-gnu-add-minetest-basic-trains.patch (text/x-patch, attachment)]

[0003-gnu-add-minetest-advtrains.patch (text/x-patch, attachment)]

[0002-gnu-minetest-mesecons-Fix-indentation.patch (text/x-patch, attachment)]

[0001-gnu-minetest-data-Fix-indentation.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.