GNU bug report logs - #50425
[PATCH] gnu: Add minetest-advtrains.

Previous Next

Full log

View this message in rfc822 format

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxime Devos <maximedevos <at> telenet.be>, 50425 <at> debbugs.gnu.org
Subject: [bug#50425] [PATCH] gnu: Add minetest-advtrains.
Date: Fri, 10 Sep 2021 14:46:39 +0200

[Message part 1 (text/plain, inline)]

Hello Maxime,

Le vendredi 10 septembre 2021 à 12:25 +0200, Maxime Devos a écrit :
> minetest-advtrains and minetest-basic-trains are separate packages
> that
> can be added separately, so theoretically, they should be added in
> separate
> patches:
It seems like the least surprising thing to do, so let’s go with the
split patch.

> Maybe replace ‘realistic trains’ -> ‘realistic train system’,
I’m not sure. Upstream really likes to use "train" as a general term,
like in share/minetest/mods/advtrains/modpack.conf, the official
description, the wiki, ... so I think it’s better to use that.

> and note that minetest-basic-trains contains the actual train models.
This sentence was missing, and I added it.

> I think a linter will have something to say about long lines here
> (try "./pre-inst-env guix lint minetest-advtrains minetest-basic-
> trains").
You’re right, I fixed the long lines and other warnings. However, I
don’t know how to fix "no updater for minetest-xxx" for both minetest-
advtrains and minetest-basic-trains. I can’t see a meaningful
difference between my packages and the others.

Vivien

[0004-gnu-add-minetest-basic-trains.patch (text/x-patch, attachment)]

[0003-gnu-add-minetest-advtrains.patch (text/x-patch, attachment)]

[0002-gnu-minetest-mesecons-Fix-indentation.patch (text/x-patch, attachment)]

[0001-gnu-minetest-data-Fix-indentation.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.