Subject: Re: [bug#50425] [PATCH] gnu: Add minetest-advtrains.

From: Maxime Devos <[email-masked]>
Date: Fri, 10 Sep 2021 12:25:30 +0200

Hi,

Presuming minetest-advtrains and minetest-basic-trains build and actually
work, this largely LGTM.  I looked at the source code of advtrains and basic_trains
and didn't find anything ‘suspicious’ (e.g. malware, though mods are sandboxed
so they would have a hard time doing anything bad). 

minetest-advtrains and minetest-basic-trains are separate packages that
can be added separately, so theoretically, they should be added in separate
patches:

From (guix)Submitting Patches:
  11. Verify that your patch contains only one set of related changes.
     Bundling unrelated changes together makes reviewing harder and
     slower.

(minetest-advtrains seems rather useless without minetest-basic-trains though,
so maybe it's ok?)

Vivien Kraus schreef op di 07-09-2021 om 12:45 [+0200]:
> +(define-public minetest-advtrains
> +  (package
> +    (name "minetest-advtrains")
> +    (version "2.3.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.bananach.space/advtrains.git")
> +             (commit "release-2.3.1")))
> +       (sha256
> +        (base32 "1ijqlchh269jpvmgmdmdvy3nsnk0bszkvvcqk6vaysvxam695ggw"))
> +       (file-name (git-file-name name version))))
> +    (build-system minetest-mod-build-system)
> +    (home-page "http://advtrains.de/")
> +    (synopsis
> +     "Adds good-looking, realistic trains with realistic rails.")
> +    (description
> +     "This mod features realistic trains and various equipment for railways, with a focus on automated train operation.

Aren't the actual trains added with minetest-basic-trains?
Maybe replace ‘realistic trains’ -> ‘realistic train system’,
and note that minetest-basic-trains contains the actual train models.

I think a linter will have something to say about long lines here
(try "./pre-inst-env guix lint minetest-advtrains minetest-basic-trains").

> +
> +Main features:
> +
> +@itemize
> +@item
> +almost-realistic tracks with actual curves and switches;
> +@item
> +railway signals, controllable by various means;
> +@item
> +ATC: simple, command-like automatic train control;
> +@item
> +LuaATC: Powerful Lua-scripted automatic train operation (requires some programming knowledge);
> +@item
> +an interlocking system, featuring track sections, routes and automatic stopping before signals.
> +@end itemize")

Greetings,
Maxime.