GNU bug report logs - #50424
27.2; Tab bar button mouse face not clearing entirely

Previous Next

Package: emacs;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Mon, 6 Sep 2021 08:14:02 UTC

Severity: normal

Tags: fixed

Found in version 27.2

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #65 received at 50424 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: luangruo <at> yahoo.com, 50424 <at> debbugs.gnu.org, alan <at> idiocy.org
Subject: Re: bug#50424: 27.2; Tab bar button mouse face not clearing entirely
Date: Sun, 12 Sep 2021 06:50:30 +0300
> From: Juri Linkov <juri <at> linkov.net>
> Date: Sat, 11 Sep 2021 22:43:44 +0300
> Cc: luangruo <at> yahoo.com, 50424 <at> debbugs.gnu.org
> 
> > Thanks, I really appreciate your help.  After seeing the result
> > of your patch, one question that came up is whether it's possible
> > not to change the previously used dimensions?  With enlarged height
> > and width, now the buttons are not vertically aligned:
> 
> Sorry, actually this question was addressed to Eli
> for the commit with the same subject but different hash:
> db74a93659 that contains such changes:
> 
> - :margin (2 . 0)
> + :margin ,tab-bar-button-margin

This is to make the code do what the variable's documentation says.
Without that change, the images were sized using :margin '(2 . 0)',
but the C code used the value of tab-bar-button-margin, a simple
scalar, to place the image and clear its background.  The way to
affect the image dimensions is by changing the value of
tab-bar-button-margin, not by hard-coding the margin in the image
properties.




This bug report was last modified 3 years and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.