GNU bug report logs - #50393
[PATCH] gnu: Add wlsunset.

Previous Next

Full log

Message #8 received at 50393 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: raingloom <raingloom <at> riseup.net>
Cc: 50393 <at> debbugs.gnu.org
Subject: Re: [bug#50393] [PATCH] gnu: Add wlsunset.
Date: Mon, 06 Sep 2021 11:08:59 +0200

Hello,

raingloom <raingloom <at> riseup.net> writes:

> +(define-public wlsunset

Thank you. Some nits follow.

> +  (package
> +    (name "wlsunset")
> +    (version "0.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.sr.ht/~kennylevinsen/wlsunset/")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0hhsddh3rs066rbsjksr8kcwg8lvglbvs67dq0r5wx5c1xcwb51w"))))
> +    (build-system meson-build-system)
> +    (inputs
> +     `(("wayland-protocols" ,wayland-protocols)
> +       ("wayland" ,wayland)))

Could you order inputs alphabetically?

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (synopsis "Day/night gamma adjustments for Wayland compositors")
> +    (home-page "https://sr.ht/~kennylevinsen/wlsunset/")
> +    (description
> +     "Day/night gamma adjustments for Wayland compositors supporting
> +wlr-gamma-control-unstable-v1.  Also known as a blue light filter or
> night +light.")

Could you use complete sentences for the description? I suggest using
markup: @samp{wlr-gamma-control-unstable-v1}.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.