From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 00:37:10 2021 Received: (at submit) by debbugs.gnu.org; 5 Sep 2021 04:37:10 +0000 Received: from localhost ([127.0.0.1]:48955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMjtx-0005wT-T3 for submit@debbugs.gnu.org; Sun, 05 Sep 2021 00:37:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:53900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMjtv-0005wL-NQ for submit@debbugs.gnu.org; Sun, 05 Sep 2021 00:37:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMjtv-0004Kz-Fw for guix-patches@gnu.org; Sun, 05 Sep 2021 00:37:03 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:12649) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMjtr-0008L5-JG for guix-patches@gnu.org; Sun, 05 Sep 2021 00:37:03 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630816615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t9GiEDs8W5NUydcK2N6PnWk8/6zRIgzUQqcueWlyMIw=; b=DGea65uJDuAfS1zvekf7oat2EC1RMoqrLHNGv2LRT9/3rm+emEsU+t4anf9j2rIWjS5Rw/ kC+jrcT4s2mb03CtLfTq0nA7mEAygNMlMZxU4RHogoXvBMyHTHJa7r2NgXHKfyLYfn5rw9 kCzSxI/pKHbJN69Z8XPKAvLy3xTUgVk= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH core-updates-frozen] gnu: libappindicator: Fix build for GCC 10. Date: Sat, 4 Sep 2021 21:36:53 -0700 Message-Id: <8c337fd0c6a03ad07942a4aa1388e859c9b43af1.1630815574.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=iskarian@mgsn.dev; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/freedesktop.scm (libappindicator): Add snippet to prevent declaring _PyGObject_API twice. --- I'm not entirely sure this is the correct fix (I have no expertise with pygobject), but after reading pygobject.h it's my best guess. (I'm not sure if adding -fcommon to CFLAGS would cause issues with dependents not using -fcommon, since this is a library.) I've tested this to build on x86_64. gnu/packages/freedesktop.scm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm index a7766edf04..f7972695e5 100644 --- a/gnu/packages/freedesktop.scm +++ b/gnu/packages/freedesktop.scm @@ -24,6 +24,7 @@ ;;; Copyright © 2020 Raghav Gururajan ;;; Copyright © 2021 Brendan Tildesley ;;; Copyright © 2021 pineapples +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of GNU Guix. ;;; @@ -2210,6 +2211,13 @@ useful with system integration.") "https://launchpad.net/libappindicator/" (version-major+minor version) "/" version "/+download/libappindicator-" version ".tar.gz")) + (modules '((guix build utils))) + (snippet + '(begin + ;; Fix 'multiple definitions' error from GCC 10 + (substitute* "bindings/python/appindicatormodule.c" + (("^#include " all) + (string-append "#define NO_IMPORT_PYGOBJECT\n" all))))) (sha256 (base32 "17xlqd60v0zllrxp8bgq3k5a1jkj0svkqn8rzllcyjh8k0gpr46m")))) base-commit: 68dd6d809398297dc2ebef522186c9b9f2566739 -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 05:14:23 2021 Received: (at 50392-done) by debbugs.gnu.org; 5 Sep 2021 09:14:23 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMoEJ-0002tv-53 for submit@debbugs.gnu.org; Sun, 05 Sep 2021 05:14:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:51885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMoEH-0002tj-En for 50392-done@debbugs.gnu.org; Sun, 05 Sep 2021 05:14:21 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id C591F240029 for <50392-done@debbugs.gnu.org>; Sun, 5 Sep 2021 11:14:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1630833255; bh=DzrfI3wMXCfHpJAbl7WrmhM5F3PX/6zXDVeuhvTBjBw=; h=From:To:Cc:Subject:Date:From; b=ecSQA+fvfPi7yLKZKTWs02G7M6fgq+R63p+GWvP6yAmPs3VNNhuBYkm38njuSkr+Z XLGyGjlsJOtd+no/1JZuk0/ByWc9nnf6bN1z4D5ZNBArZOPO1UV4M4n5PL5z+jD2/i Q8CWynxsF3FfSi2EBMhvSzHEz7wgBW8z32fVf0vvsdlDvdcqKDIZThOuymWOHPOZ4O troqTzamuqx+Esla9AAJ2s4yULLIVIuYUqxmmYYWrGld5hRp4YGxvPpNxqhemWB2FD UIdBfoJE/gtKFddydDQRpebh5vtWk0cgLyO1BdBTV7vWY0skA/JNH8yD9BOKOc8CH9 PYChuGiP/KZRA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4H2Qnz0hHZz6tmG; Sun, 5 Sep 2021 11:14:14 +0200 (CEST) References: <8c337fd0c6a03ad07942a4aa1388e859c9b43af1.1630815574.git.iskarian@mgsn.dev> From: Guillaume Le Vaillant To: Sarah Morgensen Subject: Re: [bug#50392] [PATCH core-updates-frozen] gnu: libappindicator: Fix build for GCC 10. Date: Sun, 05 Sep 2021 09:13:38 +0000 In-reply-to: <8c337fd0c6a03ad07942a4aa1388e859c9b43af1.1630815574.git.iskarian@mgsn.dev> Message-ID: <87fsuj2xln.fsf@kitej> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50392-done Cc: 50392-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Patch pushed as cdb63b192c0756e2cfbe2cf4336ea3670409df57. Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYTSKZA8cZ2x2QHBvc3Rl by5uZXQACgkQa+ggit8h/j8flwEAnphTPkBpBNnAbKzXJgkSVWWcMzFHzkXdGvJJ sCtNCLIA/jZAvOSgQl2z0DwPyjyg6FbSTx+vRoHgfbLtq3wn1fy3 =GRj3 -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 17:56:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Oct 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator