GNU bug report logs - #50384
[PATCH] Optimise search-patch (reducing I/O)

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Sat, 4 Sep 2021 21:18:01 UTC

Severity: normal

Full log


Message #17 received at 50384 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 50384 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] Optimise search-patch (reducing I/O)
Date: Mon, 06 Sep 2021 00:40:25 +0200
[Message part 1 (text/plain, inline)]
Maxime Devos schreef op zo 05-09-2021 om 21:48 [+0200]:
> Ludovic Courtès schreef op zo 05-09-2021 om 00:04 [+0200]:
> > Maxime Devos <maximedevos <at> telenet.be> skribis:
> > 
[..]
> I added two patches adding (limited) dependency tracking to compile-all.scm.
> If a patch file is now modified or deleted, the corresponding package modules
> will be recompiled.  This should remove the ‘evilness’ I think.

Oops, I forgot to include the following change to build-aux/compile-all.scm:

     (or (not (file-exists? go))
         (file-mtime<? go file)
-        (any (cut file-mtime<? go <>) extra-dependencies))))
+        (any (lambda (dependency)
+               (or (not (file-exists? dependency))
+                   (file-mtime<? go dependency))) extra-dependencies))))

It will be included in the v3.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 246 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.