Subject: Re: [bug#50368] [PATCH 2/9] gnu: Add rust-multipart-0.18.

From: Xinglu Chen <[email-masked]>
Date: Sat, 04 Sep 2021 21:10:53 +0200

On Sat, Sep 04 2021, phodina via Guix-patches via wrote:

> * gnu/packages/crates-io.scm (rust-multipart-0.18): New variable.

‘rust-multipart-0.17’ should also be mentioned here.  Maybe

  (rust-multipart-0.17): Inherit from ‘rust-multipart-0.18’.

?

> diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
> index 605106f9fa..2cd07b513c 100644
> --- a/gnu/packages/crates-io.scm
> +++ b/gnu/packages/crates-io.scm
> @@ -27367,21 +27367,22 @@ which defines a default trait implementation, and @code{trait_impl} which uses
>  a default trait implementation you've defined.")
>      (license license:lgpl2.1+)))
>
> -(define-public rust-multipart-0.17
> +(define-public rust-multipart-0.18
>    (package
>      (name "rust-multipart")
> -    (version "0.17.1")
> +    (version "0.18.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (crate-uri "multipart" version))
> -       (file-name (string-append name "-" version ".tar.gz"))
> +       (file-name
> +        (string-append name "-" version ".tar.gz"))

Why is this necessary?

>         (sha256
> -        (base32 "1m3nrydgc56wjixsahipmvjgnxnw2cz7w8ryghsgahwjr3nswl6h"))))
> +        (base32
> +         "10libwfbazqcyxcpgpcdf1a66jnzghwlmxlxnffg4rrqhqrwdph0"))))
>      (build-system cargo-build-system)
>      (arguments
> -     `(#:skip-build? #t
> -       #:cargo-inputs
> +     `(#:cargo-inputs
>         (("rust-buf-redux" ,rust-buf-redux-0.8)
>          ("rust-clippy" ,rust-clippy-0.0)
>          ("rust-httparse" ,rust-httparse-1)
> @@ -27393,7 +27394,7 @@ a default trait implementation you've defined.")
>          ("rust-mime-guess" ,rust-mime-guess-2)
>          ("rust-nickel" ,rust-nickel-0.11)
>          ("rust-quick-error" ,rust-quick-error-1)
> -        ("rust-rand" ,rust-rand-0.7)
> +        ("rust-rand" ,rust-rand-0.8)
>          ("rust-rocket" ,rust-rocket-0.4)
>          ("rust-safemem" ,rust-safemem-0.3)
>          ("rust-tempfile" ,rust-tempfile-3)
> @@ -27401,7 +27402,8 @@ a default trait implementation you've defined.")
>          ("rust-twoway" ,rust-twoway-0.1))
>         #:cargo-development-inputs
>         (("rust-env-logger" ,rust-env-logger-0.5))))
> -    (home-page "https://github.com/abonander/multipart")
> +    (home-page
> +     "https://github.com/abonander/multipart")

Please avoid these kind of formatting changes.