GNU bug report logs - #50349
[PATCH] packages: Add 'define-package' syntax.

Previous Next

Package: guix;

Reported by: Sarah Morgensen <iskarian <at> mgsn.dev>

Date: Fri, 3 Sep 2021 04:07:02 UTC

Severity: wishlist

Tags: patch

Merged with 15284

Full log


View this message in rfc822 format

From: zimoun <zimon.toutoune <at> gmail.com>
To: Sarah Morgensen <iskarian <at> mgsn.dev>, 50349 <at> debbugs.gnu.org
Subject: [bug#50349] [PATCH] packages: Add 'define-package' syntax.
Date: Fri, 03 Sep 2021 07:41:18 +0200
Hi Sarah,

On Thu, 02 Sep 2021 at 21:06, Sarah Morgensen <iskarian <at> mgsn.dev> wrote:

> (define-package my-favorite-package
>   (name "my-favorite-package")
>   ...)
>
> The purpose is primarily to save the horizontal indent, but IMO it looks
> better, and is marginally more clear for newcomers.  I think ideally we could
> eventually transition to using this syntax as the primary syntax and only use
> 'define-public' when necessary.

On one hand, I think it is a good idea; especially for newcomers.  On
the other hand, it will break ’git-blame’, isn’t it?

Therefore, I am not convinced such change is worth for ’gnu/packages/’.
Instead it seems worth only for teaching custom packages.  Explaining to
people in my labs, they are often confused between ’define’ and
’define-public’.  But then, there is two “styles” and people could be
more confused.

Well, my feelings are mixed.  Thanks for opening the discussion. :-)


Cheers,
simon




This bug report was last modified 3 years and 281 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.