From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH] gnu: Add go-1.17. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Sep 2021 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50348@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163062059127818 (code B ref -1); Thu, 02 Sep 2021 22:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 22:09:51 +0000 Received: from localhost ([127.0.0.1]:42264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuu2-0007EY-S7 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 18:09:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:57344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuty-0007EP-UA for submit@debbugs.gnu.org; Thu, 02 Sep 2021 18:09:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLuty-0005nm-0c for guix-patches@gnu.org; Thu, 02 Sep 2021 18:09:42 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:47794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLutt-0005cD-8K for guix-patches@gnu.org; Thu, 02 Sep 2021 18:09:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630620570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mtFeGoko2xJrXQos+VNdcmICANgWZJAA6fTGyHdZzk0=; b=ePWvnrIw1ROTpA7QTLcV/BYkuIk7wWEmVkvu4mIBrKsINqzHvcZ/4REeX/DPUZAI2GtDCR ts+8fmNvwzYqJJnEq9dsHj4YL22v0kl8/sEjcy7nCqmmJhN+S7B9Yjkmtk0jmhMif1QUSq qwIwfBSW7/Oh0fJmI10qmynJ3ijCLTI= From: Sarah Morgensen Date: Thu, 2 Sep 2021 15:09:27 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages.golang.scm (go-1.17): New variable. --- Hello Guix, This patch (finally) adds Go 1.17, with some further improvements! Highlights: * 43% closure size compared to go-1.16 (~50% output size) * No longer dependent on single GCC version (fixes #36823, #39400)[0][1] * Many tests re-enabled * 'doc' output merged (makes docs usable with `godoc') * Installs in FHS paths rather than directly in $out/ * Builds nearly all our Go packages * Phases refactored For the few Guix Go packages which require an update or patch to build with Go 1.17, I will send those later. But I don't think those should be required to merge this, since go-1.17 won't be used to build Go packages by default. What do you think? (Details below the break, for those interested.) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This update removes Go's dependence on canonical-gcc by replacing the patch that hardcodes the gcc-lib runpath in Go's own linker with one that tells Go to use the host linker (which knows how to add runpaths) when linking against libraries (glibc, gcc-lib, etc). This removes GCC from Go's closure (fixing [0]), and allows users to build with any GCC library (fixing [1]). In the future, we may be able to drop this patch and instead use GO_EXTLINK_ENABLED=1 or similar when [2] or [3] is resolved. Removing the GCC dependency reduces closure size by ~107MiB. Properly stripping the binaries shaves off ~20MiB. No longer installing pre-compiled standard library archives shaves off another ~180MiB. Quoting my explanatory comment: > Notably, we do not install archives (180M), which Go will happily recompile > quickly (and cache) if needed, almost surely faster than they could be > substituted. > The main motivation for pre-compiled archives is to use libc-linked `net' or > `os' packages without a C compiler, but on Guix a C compiler is necessary to > properly link the final binaries anyway. Many build flags also invalidate > these pre-compiled archives, so in practice Go often recompiles them anyway. > Upstream is also planning to no longer install these archives: > > When necessary, a custom pre-compiled library package can be created > with `#:import-path "std"' and used with `-pkgdir'. That latter step should only be necessary when updating the build-system to use this Go. Finally, rather than installing directly in $out, Go now installs to /bin, /lib/go, /share/go, and /share/doc/go (albeit with symlinks to them from /lib/go). Also, the 'doc' output, with less than 1MB, was merged into 'out', which makes `godoc' work correctly for the standard library. [0] Go retains a reference to GCC. [1] https://issues.guix.gnu.org/39400 [2] cmd/go: spurious error message when external linking a pure Go program [3] cmd/link: provide a way to always use external linking if cgo is used -- Sarah gnu/packages/golang.scm | 182 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b6e8b84749..8da7c9bf85 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -608,6 +608,188 @@ (define-public go-1.16 (alist-replace "go" (list gccgo-10) (package-native-inputs go-1.14)) (package-native-inputs go-1.14)))))) +(define-public go-1.17 + (package + (inherit go-1.16) + (name "go") + (version "1.17") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/golang/go") + (commit (string-append "go" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1psra6j95ws38mx3scc1whky8cwk32mazqs0wzzdwbs8ppl8iwl5")))) + (outputs '("out" "tests")) ; 'tests' contains distribution tests. + (arguments + `(#:modules ((ice-9 match) + (guix build gnu-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((output (assoc-ref outputs "out")) + (loader (string-append (assoc-ref inputs "libc") + ,(glibc-dynamic-linker)))) + (setenv "GOOS" "linux") + (setenv "GO_LDSO" loader) + (setenv "GOROOT" (getcwd)) + (setenv "GOROOT_FINAL" (string-append output "/lib/go")) + (setenv "GOGC" "400") + (setenv "GOCACHE" "/tmp/go-cache")))) + (add-after 'unpack 'patch-source + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((net-base (assoc-ref inputs "net-base")) + (tzdata-path (string-append (assoc-ref inputs "tzdata") + "/share/zoneinfo"))) + ;; XXX: Remove when #49729 is merged? + (for-each make-file-writable (find-files "src")) + + ;; Having the patch in the 'patches' field of breaks + ;; the 'TestServeContent' test due to the fact that + ;; timestamps are reset. Thus, apply it from here. + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-skip-gc-test.patch")) + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-fix-script-tests.patch")) + + (substitute* "src/os/os_test.go" + (("/usr/bin") (getcwd)) + (("/bin/sh") (which "sh"))) + + (substitute* "src/cmd/go/testdata/script/cgo_path_space.txt" + (("/bin/sh") (which "sh"))) + + ;; fix shebang for testar script + ;; note the target script is generated at build time. + (substitute* "misc/cgo/testcarchive/carchive_test.go" + (("/usr/bin/env bash") (which "bash"))) + + (substitute* "src/net/lookup_unix.go" + (("/etc/protocols") + (string-append net-base "/etc/protocols"))) + (substitute* "src/net/port_unix.go" + (("/etc/services") + (string-append net-base "/etc/services"))) + (substitute* "src/time/zoneinfo_unix.go" + (("/usr/share/zoneinfo/") tzdata-path))))) + (add-after 'patch-source 'disable-failing-tests + (lambda _ + ;; Disable failing tests: these tests attempt to access + ;; commands or network resources which are neither available + ;; nor necessary for the build to succeed. + (for-each + (match-lambda + ((file test) + (let ((regex (string-append "^(func\\s+)(" test "\\()"))) + (substitute* file + ((regex all before test_name) + (string-append before "Disabled" test_name)))))) + '(("src/net/cgo_unix_test.go" "TestCgoLookupPort") + ("src/net/cgo_unix_test.go" "TestCgoLookupPortWithCancel") + ;; 127.0.0.1 doesn't exist + ("src/net/cgo_unix_test.go" "TestCgoLookupPTR") + ("src/net/cgo_unix_test.go" "TestCgoLookupPTRWithCancel") + ;; /etc/services doesn't exist + ("src/net/parse_test.go" "TestReadLine") + ;; The user's directory doesn't exist + ("src/os/os_test.go" "TestUserHomeDir"))) + + ;; These tests fail on aarch64-linux + (substitute* "src/cmd/dist/test.go" + (("t.registerHostTest\\(\"testsanitizers/msan.*") "")))) + (add-after 'patch-source 'enable-external-linking + (lambda _ + ;; Invoke GCC to link any archives created with GCC (that is, any + ;; packages built using 'cgo'), because Go doesn't know how to + ;; handle the runpaths but GCC does. Use substitute* rather than + ;; a patch since these files are liable to change often. + ;; + ;; XXX: Replace with GO_EXTLINK_ENABLED=1 or similar when + ;; and/or + ;; are resolved. + (substitute* "src/cmd/link/internal/ld/config.go" + (("iscgo && externalobj") "iscgo")) + (substitute* '("src/cmd/nm/nm_cgo_test.go" + "src/cmd/dist/test.go") + (("^func.*?nternalLink\\(\\).*" all) + (string-append all "\n\treturn false\n"))))) + (replace 'build + (lambda* (#:key (parallel-build? #t) #:allow-other-keys) + (let* ((njobs (if parallel-build? (parallel-job-count) 1))) + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "make.bash" "--no-banner"))))) + (replace 'check + (lambda* (#:key target (tests? (not target)) (parallel-tests? #t) + #:allow-other-keys) + (let* ((njobs (if parallel-tests? (parallel-job-count) 1))) + (when tests? + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "run.bash" "--no-rebuild")))))) + (add-before 'install 'unpatch-perl-shebangs + (lambda _ + ;; Avoid inclusion of perl in closure by rewriting references + ;; to perl input in sourcecode generators and test scripts + (substitute* (cons "src/net/http/cgi/testdata/test.cgi" + (find-files "src" "\\.pl$")) + (("^#!.*") "#!/usr/bin/env perl\n")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + ;; Notably, we do not install archives (180M), which Go will + ;; happily recompile quickly (and cache) if needed, almost + ;; surely faster than they could be substituted. + ;; + ;; The main motivation for pre-compiled archives is to use + ;; libc-linked `net' or `os' packages without a C compiler, + ;; but on Guix a C compiler is necessary to properly link the + ;; final binaries anyway. Many build flags also invalidate + ;; these pre-compiled archives, so in practice Go often + ;; recompiles them anyway. + ;; + ;; Upstream is also planning to no longer install these + ;; archives: + ;; + ;; When necessary, a custom pre-compiled library package can + ;; be created with `#:import-path "std"' and used with + ;; `-pkgdir'. + (let* ((out (assoc-ref outputs "out")) + (tests (assoc-ref outputs "tests"))) + (for-each + (lambda (file) + (copy-recursively file (string-append out "/lib/go/" file))) + '("lib" "VERSION" "pkg/include" "pkg/tool")) + + (for-each + (match-lambda + ((file dest output) + ;; Copy to output/dest and symlink from output/lib/go/file. + (let ((file* (string-append output "/lib/go/" file)) + (dest* (string-append output "/" dest))) + (copy-recursively file dest*) + (mkdir-p (dirname file*)) + (symlink (string-append "../../" dest) file*)))) + `(("bin" "bin" ,out) + ("src" "share/go/src" ,out) + ("misc" "share/go/misc" ,out) + ("doc" "share/doc/go/doc" ,out) + ("api" "share/go/api" ,tests) + ("test" "share/go/test" ,tests)))))) + (add-after 'install 'install-doc-files + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each + (lambda (file) + (install-file file (string-append out "/share/doc/go"))) + '("AUTHORS" "CONTRIBUTORS" "CONTRIBUTING.md" "PATENTS" + "README.md" "SECURITY.md")))))))) + (inputs (alist-delete "gcc:lib" (package-inputs go-1.16))))) + (define-public go go-1.14) (define-public go-0xacab-org-leap-shapeshifter base-commit: 95c29d2746943733cbe8df7013854d45bb0df413 -- 2.31.1 From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH v2] gnu: Add go-1.17. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Sep 2021 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50348@debbugs.gnu.org Received: via spool by 50348-submit@debbugs.gnu.org id=B50348.163121675024212 (code B ref 50348); Thu, 09 Sep 2021 19:46:01 +0000 Received: (at 50348) by debbugs.gnu.org; 9 Sep 2021 19:45:50 +0000 Received: from localhost ([127.0.0.1]:36302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOPza-0006IS-03 for submit@debbugs.gnu.org; Thu, 09 Sep 2021 15:45:50 -0400 Received: from out2.migadu.com ([188.165.223.204]:63294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOPzW-0006II-OB for 50348@debbugs.gnu.org; Thu, 09 Sep 2021 15:45:48 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631216745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEFaNjrcaBemnNHnYBrSagbN3sgvgfMNPP/Dy080++c=; b=Mlxwiy918nzoEpIMrzazNuuMqawGC0+uui+iwvjCDK8bKJ7tiVk0MxNiTbSj4RVCVmNScU 24/MiHGd05EdX3DNAhDsN1TXp69C8j4kAGxrSW36OqxW0E4Yo9yS3uS2mwlngY94XPt2dx Toe9zWpEE48uTzBiEnBGnBxdSEL0Wo0= From: Sarah Morgensen Date: Thu, 9 Sep 2021 12:45:42 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages.golang.scm (go-1.17): New variable. --- Rebased on current master and updated to use Go 1.17.1. gnu/packages/golang.scm | 182 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b6e8b84749..95cff83e9e 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -608,6 +608,188 @@ in the style of communicating sequential processes (@dfn{CSP}).") (alist-replace "go" (list gccgo-10) (package-native-inputs go-1.14)) (package-native-inputs go-1.14)))))) +(define-public go-1.17 + (package + (inherit go-1.16) + (name "go") + (version "1.17.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/golang/go") + (commit (string-append "go" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0wk99lwpzp4qwrksl932lm9vb70nyf4vgb5lxwh7gzjcbhlqj992")))) + (outputs '("out" "tests")) ; 'tests' contains distribution tests. + (arguments + `(#:modules ((ice-9 match) + (guix build gnu-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((output (assoc-ref outputs "out")) + (loader (string-append (assoc-ref inputs "libc") + ,(glibc-dynamic-linker)))) + (setenv "GOOS" "linux") + (setenv "GO_LDSO" loader) + (setenv "GOROOT" (getcwd)) + (setenv "GOROOT_FINAL" (string-append output "/lib/go")) + (setenv "GOGC" "400") + (setenv "GOCACHE" "/tmp/go-cache")))) + (add-after 'unpack 'patch-source + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((net-base (assoc-ref inputs "net-base")) + (tzdata-path (string-append (assoc-ref inputs "tzdata") + "/share/zoneinfo"))) + ;; XXX: Remove when #49729 is merged? + (for-each make-file-writable (find-files "src")) + + ;; Having the patch in the 'patches' field of breaks + ;; the 'TestServeContent' test due to the fact that + ;; timestamps are reset. Thus, apply it from here. + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-skip-gc-test.patch")) + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-fix-script-tests.patch")) + + (substitute* "src/os/os_test.go" + (("/usr/bin") (getcwd)) + (("/bin/sh") (which "sh"))) + + (substitute* "src/cmd/go/testdata/script/cgo_path_space.txt" + (("/bin/sh") (which "sh"))) + + ;; fix shebang for testar script + ;; note the target script is generated at build time. + (substitute* "misc/cgo/testcarchive/carchive_test.go" + (("/usr/bin/env bash") (which "bash"))) + + (substitute* "src/net/lookup_unix.go" + (("/etc/protocols") + (string-append net-base "/etc/protocols"))) + (substitute* "src/net/port_unix.go" + (("/etc/services") + (string-append net-base "/etc/services"))) + (substitute* "src/time/zoneinfo_unix.go" + (("/usr/share/zoneinfo/") tzdata-path))))) + (add-after 'patch-source 'disable-failing-tests + (lambda _ + ;; Disable failing tests: these tests attempt to access + ;; commands or network resources which are neither available + ;; nor necessary for the build to succeed. + (for-each + (match-lambda + ((file test) + (let ((regex (string-append "^(func\\s+)(" test "\\()"))) + (substitute* file + ((regex all before test_name) + (string-append before "Disabled" test_name)))))) + '(("src/net/cgo_unix_test.go" "TestCgoLookupPort") + ("src/net/cgo_unix_test.go" "TestCgoLookupPortWithCancel") + ;; 127.0.0.1 doesn't exist + ("src/net/cgo_unix_test.go" "TestCgoLookupPTR") + ("src/net/cgo_unix_test.go" "TestCgoLookupPTRWithCancel") + ;; /etc/services doesn't exist + ("src/net/parse_test.go" "TestReadLine") + ;; The user's directory doesn't exist + ("src/os/os_test.go" "TestUserHomeDir"))) + + ;; These tests fail on aarch64-linux + (substitute* "src/cmd/dist/test.go" + (("t.registerHostTest\\(\"testsanitizers/msan.*") "")))) + (add-after 'patch-source 'enable-external-linking + (lambda _ + ;; Invoke GCC to link any archives created with GCC (that is, any + ;; packages built using 'cgo'), because Go doesn't know how to + ;; handle the runpaths but GCC does. Use substitute* rather than + ;; a patch since these files are liable to change often. + ;; + ;; XXX: Replace with GO_EXTLINK_ENABLED=1 or similar when + ;; and/or + ;; are resolved. + (substitute* "src/cmd/link/internal/ld/config.go" + (("iscgo && externalobj") "iscgo")) + (substitute* '("src/cmd/nm/nm_cgo_test.go" + "src/cmd/dist/test.go") + (("^func.*?nternalLink\\(\\).*" all) + (string-append all "\n\treturn false\n"))))) + (replace 'build + (lambda* (#:key (parallel-build? #t) #:allow-other-keys) + (let* ((njobs (if parallel-build? (parallel-job-count) 1))) + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "make.bash" "--no-banner"))))) + (replace 'check + (lambda* (#:key target (tests? (not target)) (parallel-tests? #t) + #:allow-other-keys) + (let* ((njobs (if parallel-tests? (parallel-job-count) 1))) + (when tests? + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "run.bash" "--no-rebuild")))))) + (add-before 'install 'unpatch-perl-shebangs + (lambda _ + ;; Avoid inclusion of perl in closure by rewriting references + ;; to perl input in sourcecode generators and test scripts + (substitute* (cons "src/net/http/cgi/testdata/test.cgi" + (find-files "src" "\\.pl$")) + (("^#!.*") "#!/usr/bin/env perl\n")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + ;; Notably, we do not install archives (180M), which Go will + ;; happily recompile quickly (and cache) if needed, almost + ;; surely faster than they could be substituted. + ;; + ;; The main motivation for pre-compiled archives is to use + ;; libc-linked `net' or `os' packages without a C compiler, + ;; but on Guix a C compiler is necessary to properly link the + ;; final binaries anyway. Many build flags also invalidate + ;; these pre-compiled archives, so in practice Go often + ;; recompiles them anyway. + ;; + ;; Upstream is also planning to no longer install these + ;; archives: + ;; + ;; When necessary, a custom pre-compiled library package can + ;; be created with `#:import-path "std"' and used with + ;; `-pkgdir'. + (let* ((out (assoc-ref outputs "out")) + (tests (assoc-ref outputs "tests"))) + (for-each + (lambda (file) + (copy-recursively file (string-append out "/lib/go/" file))) + '("lib" "VERSION" "pkg/include" "pkg/tool")) + + (for-each + (match-lambda + ((file dest output) + ;; Copy to output/dest and symlink from output/lib/go/file. + (let ((file* (string-append output "/lib/go/" file)) + (dest* (string-append output "/" dest))) + (copy-recursively file dest*) + (mkdir-p (dirname file*)) + (symlink (string-append "../../" dest) file*)))) + `(("bin" "bin" ,out) + ("src" "share/go/src" ,out) + ("misc" "share/go/misc" ,out) + ("doc" "share/doc/go/doc" ,out) + ("api" "share/go/api" ,tests) + ("test" "share/go/test" ,tests)))))) + (add-after 'install 'install-doc-files + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each + (lambda (file) + (install-file file (string-append out "/share/doc/go"))) + '("AUTHORS" "CONTRIBUTORS" "CONTRIBUTING.md" "PATENTS" + "README.md" "SECURITY.md")))))))) + (inputs (alist-delete "gcc:lib" (package-inputs go-1.16))))) + (define-public go go-1.14) (define-public go-0xacab-org-leap-shapeshifter base-commit: bae57cc7d2917c4a67e9afb68ed61ad7117ea7ea -- 2.33.0 From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH] gnu: Add go-1.17. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Sep 2021 20:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50348@debbugs.gnu.org Received: via spool by 50348-submit@debbugs.gnu.org id=B50348.163121923728068 (code B ref 50348); Thu, 09 Sep 2021 20:28:02 +0000 Received: (at 50348) by debbugs.gnu.org; 9 Sep 2021 20:27:17 +0000 Received: from localhost ([127.0.0.1]:36318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOQdh-0007Ie-Fd for submit@debbugs.gnu.org; Thu, 09 Sep 2021 16:27:17 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOQdf-0007IR-38 for 50348@debbugs.gnu.org; Thu, 09 Sep 2021 16:27:15 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 754F45C00B3; Thu, 9 Sep 2021 16:27:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 09 Sep 2021 16:27:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=uLOaDGTj0A3p3Qy0EGcNgZYi o9rRsJ85KC2uEL+J8Kw=; b=Eqc6GzPubUdCsuuC7lP38MpaRTX/xs0QUn3+E9vG ANh5a++9SPR5yy3VZfeK/IB4WXOA5ncYj6pjq+PRuKzx0F+Eu92AZ3uWnOLriaAd gInraZWHAt/oPkWEDYcy9/mcBdCOOnq8c/BifgwBykaHgx17FHku9cMivpqitNig tuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=uLOaDG Tj0A3p3Qy0EGcNgZYio9rRsJ85KC2uEL+J8Kw=; b=SYKYlsXbqbaVv5gVy97Ay6 oC1PUtjE46xQPEaXsbOi4mqhq2jNlX3sfSr7F+hceUuWnd9GQlmJz5eVeKEpaH91 N4MlDC0MTEQiCDbyVpYFkxYbk5WJA1zK7Asl6qop4Si6LMHiKrN4FZHIVyokXjgi Bjh9cYbEN/SlsRD3mf/Q+AkWelGDTOBjq9nRCA9tzMhslSP9vAACB/tCWtXp3qYn zkU5RdrV3Z+5WrVSXtJKfZmy2mOQ0n1W9lbMtGrkvCE9LB/i+6nJJO3qkYI2On7L 2NYAbvVAJjlHxqYC62/tFLw3B5tMbIuK6zeTQfP01VWQKheTogiaA8Hkf1+KOrxQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 16:27:08 -0400 (EDT) Date: Thu, 9 Sep 2021 16:27:06 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 02, 2021 at 03:09:27PM -0700, Sarah Morgensen wrote: > * gnu/packages.golang.scm (go-1.17): New variable. [...] Wow, excellent! > That latter step should only be necessary when updating the build-system to > use this Go. Apologies if you've already answered this elsewhere, but what remains to be done in order to make go-build-system use Go 1.17? Can we just do it now? From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH v2] gnu: Add go-1.17. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Sep 2021 20:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50348@debbugs.gnu.org Received: via spool by 50348-submit@debbugs.gnu.org id=B50348.163122065530222 (code B ref 50348); Thu, 09 Sep 2021 20:51:02 +0000 Received: (at 50348) by debbugs.gnu.org; 9 Sep 2021 20:50:55 +0000 Received: from localhost ([127.0.0.1]:36332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR0Z-0007rO-Kv for submit@debbugs.gnu.org; Thu, 09 Sep 2021 16:50:55 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR0X-0007r9-OI for 50348@debbugs.gnu.org; Thu, 09 Sep 2021 16:50:54 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 552CD5C014E; Thu, 9 Sep 2021 16:50:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 09 Sep 2021 16:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=9smllEExm0vi+0oPl+dCkCn3 fHyvhiDM4UKPSfvZEaU=; b=DdbYpTuAwbHRiN4kLJdUj8kOp5V6/xBYGMLvXBLv RXOUuGGcDaYgnWE/FXEbfl9iHC6xJJwYaBMqqpw6PD8vAOkuhgn+tMSJtelvhyTM o5CQ+n7s1L9KVggSOhAimm8JOmdB3TJfTue0QqEUy+ZRqcynvAbZEHstvUej6qOU wU4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=9smllE Exm0vi+0oPl+dCkCn3fHyvhiDM4UKPSfvZEaU=; b=d/L4XcHdT7F8iFFY4YI+Rl xikc+/qxJIiHgwcZPqRnNI1TsKk4IVwMrw/sjbBeN8+c4TfBcd8uPBNPr3vukrUz A/SU5PZN7RTZAk1JPYkSv9E6cuziSPF/f3L6+Ja4/rdDiiMUXUFgnFx2obvvG2g0 ffOlt5ocY6IV9C8O4s1kbUviHW9z6Z/iBytm/rWOkrti0gTFOeb7136iwwVdcWXi cIpDv74N6n9rvo6pg8laknoPSzcVZNARNeFaNjfcVAMK0Ihx1QpqxmWcVMi77bzg /g6CS3ybiUYsKfIyBALveHIn6EpPtNo9bAb6NN0AAwzqQmLSjaAVUibEWQtn7VNA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 16:50:47 -0400 (EDT) Date: Thu, 9 Sep 2021 16:50:46 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 09, 2021 at 12:45:42PM -0700, Sarah Morgensen wrote: > * gnu/packages.golang.scm (go-1.17): New variable. Urgh, somehow I missed this and pushed 1.17. Now I'll build and push 1.17.1. From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH] gnu: Add go-1.17. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Sep 2021 20:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50348@debbugs.gnu.org Received: via spool by 50348-submit@debbugs.gnu.org id=B50348.163122085930630 (code B ref 50348); Thu, 09 Sep 2021 20:55:01 +0000 Received: (at 50348) by debbugs.gnu.org; 9 Sep 2021 20:54:19 +0000 Received: from localhost ([127.0.0.1]:36337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR3f-0007xo-2Y for submit@debbugs.gnu.org; Thu, 09 Sep 2021 16:54:18 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR3c-0007xJ-Eq for 50348@debbugs.gnu.org; Thu, 09 Sep 2021 16:54:05 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4B2085C017D; Thu, 9 Sep 2021 16:53:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 09 Sep 2021 16:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=lQ5MJBO7Nd+RIIkdpbUxQkEg Wzzt0OIYGH//NOANAfY=; b=dG4z+ItUnE/yN0x1xTOabphNerudcyl/u7TCso4F olpVfhnDe9ztop1lcvqIT7/l1hHXzQYGQCxW2fzRhnRipLmogjLnksMTpOx3b9Tf ZlonmAlmL4NYFERZchRKCMQJM2onViGWXb532NjZgE6oIItvUxItLNF8bQ38pBIo S+w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lQ5MJB O7Nd+RIIkdpbUxQkEgWzzt0OIYGH//NOANAfY=; b=oqhA5V7p1u/fqZr8y4F60r ECjBFQh6X7Vg1EUwRXM1gL4fvdM5HjmkngAZRbkr4kusKQEDdWCotsDMDint6SF2 9VmZgKD0NRb0hPDCeLa/bK1gym4jQWnvGr+T7vM/ffF0Vp5NLYrEMMVxAgH3fFdr J345Oh+ej6R9sXoYGHT2rVuNRDMUHMQ5wrhuXv0rrWSxt5nD4Omj4cUxx3w+TPZ+ g79K+DACVQ85MnZx3K+jchYAI7RvGqSOzWzjLuJvy05o+G6v2h+gfJifnSlljBuU tG7l25q9bbPe9P3DBDD/qriB/DlHdcMYGRtUgQnDvibwxkh2I5Mg/nFcxbX+ykHg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 16:53:58 -0400 (EDT) Date: Thu, 9 Sep 2021 16:53:57 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, Sep 02, 2021 at 03:09:27PM -0700, Sarah Morgensen wrote: > * gnu/packages.golang.scm (go-1.17): New variable. Pushed as d36c73b8a8f52732753c11125cfb4d8bf735f8b7 From unknown Fri Jun 13 11:18:35 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sarah Morgensen Subject: bug#50348: closed (Re: [bug#50348] [PATCH v2] gnu: Add go-1.17.) Message-ID: References: X-Gnu-PR-Message: they-closed 50348 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 50348@debbugs.gnu.org Date: Thu, 09 Sep 2021 20:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1631221022-30876-1" This is a multi-part message in MIME format... ------------=_1631221022-30876-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #50348: [PATCH] gnu: Add go-1.17. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 50348@debbugs.gnu.org. --=20 50348: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50348 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1631221022-30876-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 50348-done) by debbugs.gnu.org; 9 Sep 2021 20:56:04 +0000 Received: from localhost ([127.0.0.1]:36342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR5Y-00080n-4V for submit@debbugs.gnu.org; Thu, 09 Sep 2021 16:56:04 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:50915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOR5V-00080H-T0 for 50348-done@debbugs.gnu.org; Thu, 09 Sep 2021 16:56:02 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BA69E5C0156; Thu, 9 Sep 2021 16:55:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 09 Sep 2021 16:55:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=iYWk7a65LoBNp6Bcus/qtXUm d4lts3WPkvljcKao0B8=; b=fY1IHXKvcyOD0xT+FqjidSWFOxgjqguNSxGo0HX4 lIo1oV0pCak6geniRJAlfhH31VBZNnN9SL/XIEyXQQPG2g/MAOaT65MXDlG/pAGu 8DDeb8Od7t69nNGL9yfsDUq2q3xjuaKiuhsVyaMVHrkiyCYwA8WCrP7WlYdtc9Fn C4Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iYWk7a 65LoBNp6Bcus/qtXUmd4lts3WPkvljcKao0B8=; b=YByg1j8O0XCYiJ34rtX2hI qYYbqpDZDW0CDHXZrsrHz8Z+ePxfMkSoAZE7fyztZxl1EeHSOdUfKjLGbdrUQLll dF92Wwnr+UdRHOyFTMImTLXGoIVohtEaemzX7Af6UnJRVC/2Sbrx9YeSPf+gj+Kp fTWL+Ea+emMH9h28ymHvqFbwqJOJmo2FRyDs6gCFymZjFsah2l+9fHIiYff8a/S1 mUs1GGyAusTS06gH51DyovgH2L7thjOzowdpD86jXd18fG6uOizHtlcGaQRPxXey LB/CQ6glxx3fkkTRpt4/1FgxqwcwzbDjY/cjoYkgxS+36Ff3SneBxADb+qn/QL+Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudefledgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeeukeektdffvddtudegjeegtdevhf eufeeivdejiedtieegtdevjedvjeehffevgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Sep 2021 16:55:56 -0400 (EDT) Date: Thu, 9 Sep 2021 16:55:54 -0400 From: Leo Famulari To: Sarah Morgensen Subject: Re: [bug#50348] [PATCH v2] gnu: Add go-1.17. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50348-done Cc: 50348-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Sep 09, 2021 at 12:45:42PM -0700, Sarah Morgensen wrote: > * gnu/packages.golang.scm (go-1.17): New variable. I pushed the update as cf4ccde47d9df93569851e848c73a5c3d489a440 ------------=_1631221022-30876-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 22:09:51 +0000 Received: from localhost ([127.0.0.1]:42264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuu2-0007EY-S7 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 18:09:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:57344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuty-0007EP-UA for submit@debbugs.gnu.org; Thu, 02 Sep 2021 18:09:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLuty-0005nm-0c for guix-patches@gnu.org; Thu, 02 Sep 2021 18:09:42 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:47794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLutt-0005cD-8K for guix-patches@gnu.org; Thu, 02 Sep 2021 18:09:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1630620570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mtFeGoko2xJrXQos+VNdcmICANgWZJAA6fTGyHdZzk0=; b=ePWvnrIw1ROTpA7QTLcV/BYkuIk7wWEmVkvu4mIBrKsINqzHvcZ/4REeX/DPUZAI2GtDCR ts+8fmNvwzYqJJnEq9dsHj4YL22v0kl8/sEjcy7nCqmmJhN+S7B9Yjkmtk0jmhMif1QUSq qwIwfBSW7/Oh0fJmI10qmynJ3ijCLTI= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH] gnu: Add go-1.17. Date: Thu, 2 Sep 2021 15:09:27 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages.golang.scm (go-1.17): New variable. --- Hello Guix, This patch (finally) adds Go 1.17, with some further improvements! Highlights: * 43% closure size compared to go-1.16 (~50% output size) * No longer dependent on single GCC version (fixes #36823, #39400)[0][1] * Many tests re-enabled * 'doc' output merged (makes docs usable with `godoc') * Installs in FHS paths rather than directly in $out/ * Builds nearly all our Go packages * Phases refactored For the few Guix Go packages which require an update or patch to build with Go 1.17, I will send those later. But I don't think those should be required to merge this, since go-1.17 won't be used to build Go packages by default. What do you think? (Details below the break, for those interested.) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This update removes Go's dependence on canonical-gcc by replacing the patch that hardcodes the gcc-lib runpath in Go's own linker with one that tells Go to use the host linker (which knows how to add runpaths) when linking against libraries (glibc, gcc-lib, etc). This removes GCC from Go's closure (fixing [0]), and allows users to build with any GCC library (fixing [1]). In the future, we may be able to drop this patch and instead use GO_EXTLINK_ENABLED=1 or similar when [2] or [3] is resolved. Removing the GCC dependency reduces closure size by ~107MiB. Properly stripping the binaries shaves off ~20MiB. No longer installing pre-compiled standard library archives shaves off another ~180MiB. Quoting my explanatory comment: > Notably, we do not install archives (180M), which Go will happily recompile > quickly (and cache) if needed, almost surely faster than they could be > substituted. > The main motivation for pre-compiled archives is to use libc-linked `net' or > `os' packages without a C compiler, but on Guix a C compiler is necessary to > properly link the final binaries anyway. Many build flags also invalidate > these pre-compiled archives, so in practice Go often recompiles them anyway. > Upstream is also planning to no longer install these archives: > > When necessary, a custom pre-compiled library package can be created > with `#:import-path "std"' and used with `-pkgdir'. That latter step should only be necessary when updating the build-system to use this Go. Finally, rather than installing directly in $out, Go now installs to /bin, /lib/go, /share/go, and /share/doc/go (albeit with symlinks to them from /lib/go). Also, the 'doc' output, with less than 1MB, was merged into 'out', which makes `godoc' work correctly for the standard library. [0] Go retains a reference to GCC. [1] https://issues.guix.gnu.org/39400 [2] cmd/go: spurious error message when external linking a pure Go program [3] cmd/link: provide a way to always use external linking if cgo is used -- Sarah gnu/packages/golang.scm | 182 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index b6e8b84749..8da7c9bf85 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -608,6 +608,188 @@ (define-public go-1.16 (alist-replace "go" (list gccgo-10) (package-native-inputs go-1.14)) (package-native-inputs go-1.14)))))) +(define-public go-1.17 + (package + (inherit go-1.16) + (name "go") + (version "1.17") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/golang/go") + (commit (string-append "go" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1psra6j95ws38mx3scc1whky8cwk32mazqs0wzzdwbs8ppl8iwl5")))) + (outputs '("out" "tests")) ; 'tests' contains distribution tests. + (arguments + `(#:modules ((ice-9 match) + (guix build gnu-build-system) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((output (assoc-ref outputs "out")) + (loader (string-append (assoc-ref inputs "libc") + ,(glibc-dynamic-linker)))) + (setenv "GOOS" "linux") + (setenv "GO_LDSO" loader) + (setenv "GOROOT" (getcwd)) + (setenv "GOROOT_FINAL" (string-append output "/lib/go")) + (setenv "GOGC" "400") + (setenv "GOCACHE" "/tmp/go-cache")))) + (add-after 'unpack 'patch-source + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((net-base (assoc-ref inputs "net-base")) + (tzdata-path (string-append (assoc-ref inputs "tzdata") + "/share/zoneinfo"))) + ;; XXX: Remove when #49729 is merged? + (for-each make-file-writable (find-files "src")) + + ;; Having the patch in the 'patches' field of breaks + ;; the 'TestServeContent' test due to the fact that + ;; timestamps are reset. Thus, apply it from here. + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-skip-gc-test.patch")) + (invoke "patch" "-p1" "--force" "-i" + (assoc-ref inputs "go-fix-script-tests.patch")) + + (substitute* "src/os/os_test.go" + (("/usr/bin") (getcwd)) + (("/bin/sh") (which "sh"))) + + (substitute* "src/cmd/go/testdata/script/cgo_path_space.txt" + (("/bin/sh") (which "sh"))) + + ;; fix shebang for testar script + ;; note the target script is generated at build time. + (substitute* "misc/cgo/testcarchive/carchive_test.go" + (("/usr/bin/env bash") (which "bash"))) + + (substitute* "src/net/lookup_unix.go" + (("/etc/protocols") + (string-append net-base "/etc/protocols"))) + (substitute* "src/net/port_unix.go" + (("/etc/services") + (string-append net-base "/etc/services"))) + (substitute* "src/time/zoneinfo_unix.go" + (("/usr/share/zoneinfo/") tzdata-path))))) + (add-after 'patch-source 'disable-failing-tests + (lambda _ + ;; Disable failing tests: these tests attempt to access + ;; commands or network resources which are neither available + ;; nor necessary for the build to succeed. + (for-each + (match-lambda + ((file test) + (let ((regex (string-append "^(func\\s+)(" test "\\()"))) + (substitute* file + ((regex all before test_name) + (string-append before "Disabled" test_name)))))) + '(("src/net/cgo_unix_test.go" "TestCgoLookupPort") + ("src/net/cgo_unix_test.go" "TestCgoLookupPortWithCancel") + ;; 127.0.0.1 doesn't exist + ("src/net/cgo_unix_test.go" "TestCgoLookupPTR") + ("src/net/cgo_unix_test.go" "TestCgoLookupPTRWithCancel") + ;; /etc/services doesn't exist + ("src/net/parse_test.go" "TestReadLine") + ;; The user's directory doesn't exist + ("src/os/os_test.go" "TestUserHomeDir"))) + + ;; These tests fail on aarch64-linux + (substitute* "src/cmd/dist/test.go" + (("t.registerHostTest\\(\"testsanitizers/msan.*") "")))) + (add-after 'patch-source 'enable-external-linking + (lambda _ + ;; Invoke GCC to link any archives created with GCC (that is, any + ;; packages built using 'cgo'), because Go doesn't know how to + ;; handle the runpaths but GCC does. Use substitute* rather than + ;; a patch since these files are liable to change often. + ;; + ;; XXX: Replace with GO_EXTLINK_ENABLED=1 or similar when + ;; and/or + ;; are resolved. + (substitute* "src/cmd/link/internal/ld/config.go" + (("iscgo && externalobj") "iscgo")) + (substitute* '("src/cmd/nm/nm_cgo_test.go" + "src/cmd/dist/test.go") + (("^func.*?nternalLink\\(\\).*" all) + (string-append all "\n\treturn false\n"))))) + (replace 'build + (lambda* (#:key (parallel-build? #t) #:allow-other-keys) + (let* ((njobs (if parallel-build? (parallel-job-count) 1))) + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "make.bash" "--no-banner"))))) + (replace 'check + (lambda* (#:key target (tests? (not target)) (parallel-tests? #t) + #:allow-other-keys) + (let* ((njobs (if parallel-tests? (parallel-job-count) 1))) + (when tests? + (with-directory-excursion "src" + (setenv "GOMAXPROCS" (number->string njobs)) + (invoke "sh" "run.bash" "--no-rebuild")))))) + (add-before 'install 'unpatch-perl-shebangs + (lambda _ + ;; Avoid inclusion of perl in closure by rewriting references + ;; to perl input in sourcecode generators and test scripts + (substitute* (cons "src/net/http/cgi/testdata/test.cgi" + (find-files "src" "\\.pl$")) + (("^#!.*") "#!/usr/bin/env perl\n")))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + ;; Notably, we do not install archives (180M), which Go will + ;; happily recompile quickly (and cache) if needed, almost + ;; surely faster than they could be substituted. + ;; + ;; The main motivation for pre-compiled archives is to use + ;; libc-linked `net' or `os' packages without a C compiler, + ;; but on Guix a C compiler is necessary to properly link the + ;; final binaries anyway. Many build flags also invalidate + ;; these pre-compiled archives, so in practice Go often + ;; recompiles them anyway. + ;; + ;; Upstream is also planning to no longer install these + ;; archives: + ;; + ;; When necessary, a custom pre-compiled library package can + ;; be created with `#:import-path "std"' and used with + ;; `-pkgdir'. + (let* ((out (assoc-ref outputs "out")) + (tests (assoc-ref outputs "tests"))) + (for-each + (lambda (file) + (copy-recursively file (string-append out "/lib/go/" file))) + '("lib" "VERSION" "pkg/include" "pkg/tool")) + + (for-each + (match-lambda + ((file dest output) + ;; Copy to output/dest and symlink from output/lib/go/file. + (let ((file* (string-append output "/lib/go/" file)) + (dest* (string-append output "/" dest))) + (copy-recursively file dest*) + (mkdir-p (dirname file*)) + (symlink (string-append "../../" dest) file*)))) + `(("bin" "bin" ,out) + ("src" "share/go/src" ,out) + ("misc" "share/go/misc" ,out) + ("doc" "share/doc/go/doc" ,out) + ("api" "share/go/api" ,tests) + ("test" "share/go/test" ,tests)))))) + (add-after 'install 'install-doc-files + (lambda* (#:key outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each + (lambda (file) + (install-file file (string-append out "/share/doc/go"))) + '("AUTHORS" "CONTRIBUTORS" "CONTRIBUTING.md" "PATENTS" + "README.md" "SECURITY.md")))))))) + (inputs (alist-delete "gcc:lib" (package-inputs go-1.16))))) + (define-public go go-1.14) (define-public go-0xacab-org-leap-shapeshifter base-commit: 95c29d2746943733cbe8df7013854d45bb0df413 -- 2.31.1 ------------=_1631221022-30876-1-- From unknown Fri Jun 13 11:18:35 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50348] [PATCH] gnu: Add go-1.17. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Sep 2021 21:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 50348@debbugs.gnu.org Received: via spool by 50348-submit@debbugs.gnu.org id=B50348.16312234002088 (code B ref 50348); Thu, 09 Sep 2021 21:37:01 +0000 Received: (at 50348) by debbugs.gnu.org; 9 Sep 2021 21:36:40 +0000 Received: from localhost ([127.0.0.1]:36362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mORiq-0000Xc-KO for submit@debbugs.gnu.org; Thu, 09 Sep 2021 17:36:40 -0400 Received: from out0.migadu.com ([94.23.1.103]:52939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mORio-0000XS-0Z for 50348@debbugs.gnu.org; Thu, 09 Sep 2021 17:36:39 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631223395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bk9eAiR9U3yXnesJ0i3s0OatT1J+OzhyweZKtsu+tNI=; b=Zm8LtWo4jvrIh/uCEFOYqpA2eLTAEB/vhhhOt8zr2KuhGfsuRSNgdDNJu4gnRxggqVzU3u xetFNlBGr50dH4CVfofS2UkjxbwuWoqPwo0VrNgWsjeshcp2UYrkgs42SjiJomyQ2mLX9A lWmJVQv5hd00LlxDUeB6HYxH5My4bek= From: Sarah Morgensen References: Date: Thu, 09 Sep 2021 14:36:28 -0700 In-Reply-To: (Leo Famulari's message of "Thu, 9 Sep 2021 16:27:06 -0400 (5 minutes, 50 seconds ago)") Message-ID: <867dfpmnxf.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Leo, Thanks for taking a look at this (and pushing it)! Leo Famulari writes: >> That latter step should only be necessary when updating the build-system to >> use this Go. > > Apologies if you've already answered this elsewhere, but what remains to > be done in order to make go-build-system use Go 1.17? Can we just do it > now? We still have a few things to do. In fact, since I haven't really written this down anywhere, I'll just go ahead and open a tracking issue for the update with all of the info and CC you. -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:51:57 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:51:57 +0000 Received: from localhost ([127.0.0.1]:36482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUlp-0005NO-92 for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:51:57 -0400 Received: from out1.migadu.com ([91.121.223.63]:65390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUlm-0005NF-Tm for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:51:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=zAEO++7D49NDFq4TBJ09R0JxGnU8yxGjg1FrQ6u1ubY=; b=Di5eYYy75CyP2hbb5pjf4c/pGJ260KQHJBJdpKq/0osfhxRSeXxrebSKlDz/ACIlHhTf7x eTjspcEIRiUL/J1aF0COTBdAQw8EdlI0HFO5FUnqEVDuLo3R2kmQpU23feJXtZ4GYrmP9R zQ/MxRBzwGxvy4eSdKkmEbHG5b3CMfg= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50348 Date: Thu, 09 Sep 2021 17:51:50 -0700 Message-ID: <8635qdmevt.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) block 50348 by 50227 49921 50495 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 09 20:55:22 2021 Received: (at control) by debbugs.gnu.org; 10 Sep 2021 00:55:22 +0000 Received: from localhost ([127.0.0.1]:36488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUp8-0005V0-Lz for submit@debbugs.gnu.org; Thu, 09 Sep 2021 20:55:22 -0400 Received: from out2.migadu.com ([188.165.223.204]:30124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOUp6-0005Ur-Ni for control@debbugs.gnu.org; Thu, 09 Sep 2021 20:55:21 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631235318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=B/qPrTcJOdY5legLYdOLc+SiXtSfsheZybOp/nl8IQg=; b=L9EbR01uvAtvDBDjOI8aPpdMq0n5enPSqXobUB46adEv31mBoMCWc9rZWKpEjS6MSA/wQu /npKmZ7MKHnWM9qCvC/B2LOo0SxvuWNeBFY4KXGh2bHlSWojknNtRwyRjfI8R/OkqEVXOv AChTTArTAm/MSfAlw4+L9Ewx09yRKjg= From: Sarah Morgensen To: control@debbugs.gnu.org Subject: control message for bug #50348 Date: Thu, 09 Sep 2021 17:55:17 -0700 Message-ID: <861r5xmeq2.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unblock 50348 by 50227 49921 50495 thanks Oops, wrong bug #.