GNU bug report logs - #50346
core-updates-frozen: strace 5.13 fails "make check" on AArch64

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simon South <simon <at> simonsouth.net>
Subject: bug#50346: closed (Re: bug#50346: core-updates-frozen: strace
 5.13 fails "make check" on AArch64)
Date: Thu, 18 Nov 2021 13:14:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 50346 <at> debbugs.gnu.org.

-- 
50346: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50346
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon South <simon <at> simonsouth.net>
Cc: 50346-done <at> debbugs.gnu.org
Subject: Re: bug#50346: core-updates-frozen: strace 5.13 fails "make check"
 on AArch64
Date: Thu, 18 Nov 2021 14:13:36 +0100

Hi Simon,

Simon South <simon <at> simonsouth.net> skribis:

> Modify the invocation of strace's "readlink" and "readlinkat" tests to prevent
> them from failing due to an additional system call made by Guix's patched
> version of glibc.
>
> * gnu/packages/linux.scm (strace)[source]: Add patch.
> [arguments]<#:phases>: Do not disable the "readlink" test now that it can
> succeed.
> * gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

Good catch!  Pushed with a shortened patch file name as
b0eaa4f2d73cd7746a41d1f970b95243f2098458.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Simon South <simon <at> simonsouth.net>
To: bug-guix <at> gnu.org
Subject: core-updates-frozen: strace 5.13 fails "make check" on AArch64
Date: Thu, 02 Sep 2021 15:24:55 -0400

strace 5.13 in core-updates-frozen appears to build fine but fails its
"readlinkat" test for me on AArch64 (real hardware; a ROCK64).  This is
the only test that fails.

From the build directory, strace-5.13/tests/readlinkat.dir/exp contains

  readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory)
  readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22
  +++ exited with 0 +++

but strace-5.13/tests/readlinkat.dir/out shows

  readlinkat(AT_FDCWD, "\x2f\x70\x72\x6f\x63\x2f\x73\x65\x6c\x66\x2f\x65\x78\x65", "\x2f\x74\x6d\x70\x2f\x67\x75\x69\x78\x2d\x62\x75\x69\x6c\x64\x2d\x73\x74\x72\x61\x63\x65\x2d\x35\x2e\x31\x33\x2e\x64\x72\x76\x2d"..., 4096) = 62
  readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory)
  readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22
  +++ exited with 0 +++

The only difference is an additional line at the start of the generated
output.  I see this in the strace package definition
(gnu/packages/linux.scm:2256):

  ;; XXX: This test fails because an extra readlink call is made
  ;; by the glibc when using the ld.so cache.
  (("readlink.gen.test[^:]") " ")

Perhaps the same is true for readlinkat on AArch64?

-- 
Simon South
simon <at> simonsouth.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.