From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 02 Sep 2021 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 50346@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163061070612720 (code B ref -1); Thu, 02 Sep 2021 19:26:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 19:25:06 +0000 Received: from localhost ([127.0.0.1]:42079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLsKf-0003J5-Lj for submit@debbugs.gnu.org; Thu, 02 Sep 2021 15:25:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:44264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLsKb-0003Im-N5 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 15:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLsKb-0008Jm-DA for bug-guix@gnu.org; Thu, 02 Sep 2021 15:25:01 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLsKZ-0005E7-Bq for bug-guix@gnu.org; Thu, 02 Sep 2021 15:25:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 39B2C3262D for ; Thu, 2 Sep 2021 19:24:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z6AHaRApVA3V for ; Thu, 2 Sep 2021 19:24:56 +0000 (UTC) Received: from mars (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 00CBD3262A for ; Thu, 2 Sep 2021 19:24:55 +0000 (UTC) From: Simon South Date: Thu, 02 Sep 2021 15:24:55 -0400 Message-ID: <875yvi93w8.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) strace 5.13 in core-updates-frozen appears to build fine but fails its "readlinkat" test for me on AArch64 (real hardware; a ROCK64). This is the only test that fails. >From the build directory, strace-5.13/tests/readlinkat.dir/exp contains readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory) readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22 +++ exited with 0 +++ but strace-5.13/tests/readlinkat.dir/out shows readlinkat(AT_FDCWD, "\x2f\x70\x72\x6f\x63\x2f\x73\x65\x6c\x66\x2f\x65\x78\x65", "\x2f\x74\x6d\x70\x2f\x67\x75\x69\x78\x2d\x62\x75\x69\x6c\x64\x2d\x73\x74\x72\x61\x63\x65\x2d\x35\x2e\x31\x33\x2e\x64\x72\x76\x2d"..., 4096) = 62 readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory) readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22 +++ exited with 0 +++ The only difference is an additional line at the start of the generated output. I see this in the strace package definition (gnu/packages/linux.scm:2256): ;; XXX: This test fails because an extra readlink call is made ;; by the glibc when using the ld.so cache. (("readlink.gen.test[^:]") " ") Perhaps the same is true for readlinkat on AArch64? -- Simon South simon@simonsouth.net From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 References: <875yvi93w8.fsf@simonsouth.net> In-Reply-To: <875yvi93w8.fsf@simonsouth.net> Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 02 Sep 2021 22:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 50346@debbugs.gnu.org Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.16306224826677 (code B ref 50346); Thu, 02 Sep 2021 22:42:02 +0000 Received: (at 50346) by debbugs.gnu.org; 2 Sep 2021 22:41:22 +0000 Received: from localhost ([127.0.0.1]:42313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLvOc-0001jb-Ai for submit@debbugs.gnu.org; Thu, 02 Sep 2021 18:41:22 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:45360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLvOZ-0001jH-09 for 50346@debbugs.gnu.org; Thu, 02 Sep 2021 18:41:21 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 257443281D for <50346@debbugs.gnu.org>; Thu, 2 Sep 2021 22:41:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wTDm3IDimAVN for <50346@debbugs.gnu.org>; Thu, 2 Sep 2021 22:41:12 +0000 (UTC) Received: from mars (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id DE2BB32815 for <50346@debbugs.gnu.org>; Thu, 2 Sep 2021 22:41:12 +0000 (UTC) From: Simon South Date: Thu, 02 Sep 2021 18:41:12 -0400 Message-ID: <877dfy7g8n.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Patching strace to add a "--trace-path" parameter to the two tests' definitions as in the patch below seems to fix this issue on both AArch64 and x86-64, and is less drastic than disabling the tests altogether. The changes limit strace's output during testing to only calls affecting files in the test directory itself, effectively filtering out the 'readlink("/proc/self/exe")' call from glibc that is throwing the tests currently. You can see a number of other places in gen_tests.in where this is done, presumably for similar reasons. Does this seem reasonable? -- Simon South simon@simonsouth.net diff --git a/tests/gen_tests.in b/tests/gen_tests.in index 8b4e2e9..cc3ca63 100644 --- a/tests/gen_tests.in +++ b/tests/gen_tests.in @@ -623,8 +623,8 @@ quotactl-xfs-v -v -e trace=quotactl read-write -a15 -eread=0,5 -ewrite=1,4 -e trace=read,write -P read-write-tmpfile -P /dev/zero -P /dev/null readahead -a1 readdir -a16 -readlink -xx -readlinkat -xx +readlink -xx --trace-path=test.readlink.link +readlinkat -xx --trace-path=test.readlinkat.link reboot -s 256 recv-MSG_TRUNC -a26 -e trace=recv recvfrom -a35 From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Bengt Richter Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon South Cc: 50346@debbugs.gnu.org Reply-To: Bengt Richter Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.163067166524103 (code B ref 50346); Fri, 03 Sep 2021 12:22:01 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 12:21:05 +0000 Received: from localhost ([127.0.0.1]:43237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8Bs-0006Gh-Sm for submit@debbugs.gnu.org; Fri, 03 Sep 2021 08:21:05 -0400 Received: from imta-37.everyone.net ([216.200.145.37]:43378 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM8Bp-0006Fz-JX for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 08:21:03 -0400 Received: from pps.filterd (localhost.localdomain [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 183CDDxe028270; Fri, 3 Sep 2021 05:20:59 -0700 X-Eon-Originating-Account: Dr8LztROKqga6csNU72rRAFAC1pdfHBZWW6vSlL2H-0 X-Eon-Dm: m0116787.ppops.net Received: by m0116787.mta.everyone.net (EON-AUTHRELAY2 - 5a81c5e6) id m0116787.611f98ad.f7451; Fri, 3 Sep 2021 05:15:21 -0700 X-Eon-Sig: AQMHrIJhMhHZnpXIowIAAAAC,e4733b03bae20c8c84ac5c1169bc4de5 X-Eip: 3dKKpsUI-g4akfKJ-qQ69B89B80rRrbpGIP05VXqRpA Date: Fri, 3 Sep 2021 14:15:13 +0200 From: Bengt Richter Message-ID: <20210903121513.GA5202@LionPure> References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877dfy7g8n.fsf@simonsouth.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-GUID: T6Dx3OmtrMO7W1T6K8NplqR3ef9Bx9oy X-Proofpoint-ORIG-GUID: T6Dx3OmtrMO7W1T6K8NplqR3ef9Bx9oy X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-09-03_03:2021-09-03, 2021-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 clxscore=1034 priorityscore=1501 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030076 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi, On +2021-09-02 18:41:12 -0400, Simon South wrote: > Patching strace to add a "--trace-path" parameter to the two tests' > definitions as in the patch below seems to fix this issue on both > AArch64 and x86-64, and is less drastic than disabling the tests > altogether. > > The changes limit strace's output during testing to only calls affecting > files in the test directory itself, effectively filtering out the > 'readlink("/proc/self/exe")' call from glibc that is throwing the tests > currently. You can see a number of other places in gen_tests.in where > this is done, presumably for similar reasons. > > Does this seem reasonable? > I worry about disabling tests in too general a way, since it creates a hiding place which conceivably someone really clever may be able exploit. So I wonder whether what you are doing is making it possible to configure tests to have (narrow) context-sensitive expectations (e.g., in this case making the test handle the error as an expected one, as opposed to being made ignorant of it), or building in a static and probably too general configuration. A proper configurability, ISTM, would be preferable to any other form of more general filtering. Sorry if this is just noise from a lurker with insufficient knowledge of the issue and discussions. If so please ignore ;/ of13> definitions as in the patch below seems to fix this issue on both > -- > Simon South > simon@simonsouth.net > > > diff --git a/tests/gen_tests.in b/tests/gen_tests.in > index 8b4e2e9..cc3ca63 100644 > --- a/tests/gen_tests.in > +++ b/tests/gen_tests.in > @@ -623,8 +623,8 @@ quotactl-xfs-v -v -e trace=quotactl > read-write -a15 -eread=0,5 -ewrite=1,4 -e trace=read,write -P read-write-tmpfile -P /dev/zero -P /dev/null > readahead -a1 > readdir -a16 > -readlink -xx > -readlinkat -xx > +readlink -xx --trace-path=test.readlink.link > +readlinkat -xx --trace-path=test.readlinkat.link > reboot -s 256 > recv-MSG_TRUNC -a26 -e trace=recv > recvfrom -a35 > > > -- Regards, Bengt Richter From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bengt Richter Cc: 50346@debbugs.gnu.org Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.163067764111474 (code B ref 50346); Fri, 03 Sep 2021 14:01:02 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 14:00:41 +0000 Received: from localhost ([127.0.0.1]:45648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM9kH-0002z0-97 for submit@debbugs.gnu.org; Fri, 03 Sep 2021 10:00:41 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:33902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM9kG-0002yl-3y for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 10:00:40 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 30FB832A60; Fri, 3 Sep 2021 14:00:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8E3gFnqWXw6t; Fri, 3 Sep 2021 14:00:34 +0000 (UTC) Received: from mars (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id E58063219F; Fri, 3 Sep 2021 14:00:33 +0000 (UTC) From: Simon South References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> <20210903121513.GA5202@LionPure> Date: Fri, 03 Sep 2021 10:00:33 -0400 In-Reply-To: <20210903121513.GA5202@LionPure> (Bengt Richter's message of "Fri, 3 Sep 2021 14:15:13 +0200") Message-ID: <877dfxbvy6.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bengt Richter writes: > A proper configurability, ISTM, would be preferable to any other form > of more general filtering. I agree with you on the need to be cautious around modifying test cases but I'm not sure I follow you otherwise. What would "proper configurability" look like in this case? The change I'm proposing here narrows the two test cases so they test only what appears to have been intended, i.e. that strace can capture readlink(at) system calls and that it reports them in the format expected by the developers. It does not affect other test cases or the test suite as a whole. The obvious alternative would be to modify the test cases' expected output to match what is actually generated, but this could have the side effect of tying the package to Linux and perhaps to specific versions of glibc. That said I'm still not sure why this additional syscall is being made in the first place, only that it appears to originate from glibc's "_dl_get_origin" function[0]. If I build strace from source "manually" the tests complete fine without modification. I presume the extra call has to do with the fact Guix builds strace inside a container; does anyone know how this could be affecting the way programs are loaded? -- Simon South simon@simonsouth.net [0] See e.g. glibc's sysdeps/unix/sysv/linux/dl-origin.c for the x86-64 case, as well as "_dl_non_dynamic_init" in elf/dl-support.c, which seems to be the only place it is called. From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Bengt Richter Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Simon South Cc: 50346@debbugs.gnu.org Reply-To: Bengt Richter Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.16306880284134 (code B ref 50346); Fri, 03 Sep 2021 16:54:01 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 16:53:48 +0000 Received: from localhost ([127.0.0.1]:45840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMCRo-00014c-D1 for submit@debbugs.gnu.org; Fri, 03 Sep 2021 12:53:48 -0400 Received: from imta-37.everyone.net ([216.200.145.37]:57960 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMCRn-00014V-5o for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 12:53:47 -0400 Received: from pps.filterd (m0004962.ppops.net [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 183Gl7dc020867; Fri, 3 Sep 2021 09:53:46 -0700 X-Eon-Originating-Account: oaPLf34qVV4C3NT07fPBwpcx3c_0xMSfkBAp-8j_AYI X-Eon-Dm: m0116787.ppops.net Received: by m0116787.mta.everyone.net (EON-AUTHRELAY2 - 53b92e8b) id m0116787.611f98ad.fc47c; Fri, 3 Sep 2021 09:53:44 -0700 X-Eon-Sig: AQMHrIJhMlMYBv0e9AIAAAAC,f341fdcb756dd2e1d55c1ba8998338d9 X-Eip: o7JDIqqJ0PvuwmMCDWezEVfY9cXg7Jy6D85uVZ1Q_DQ Date: Fri, 3 Sep 2021 18:53:35 +0200 From: Bengt Richter Message-ID: <20210903165335.GA10190@LionPure> References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> <20210903121513.GA5202@LionPure> <877dfxbvy6.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <877dfxbvy6.fsf@simonsouth.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-GUID: K9zWgqgLmdg_-bTzzsQzD1X0MpaZUreF X-Proofpoint-ORIG-GUID: K9zWgqgLmdg_-bTzzsQzD1X0MpaZUreF X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-09-03_07:2021-09-03, 2021-09-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 clxscore=1034 spamscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030099 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On +2021-09-03 10:00:33 -0400, Simon South wrote: > Bengt Richter writes: > > A proper configurability, ISTM, would be preferable to any other form > > of more general filtering. > > I agree with you on the need to be cautious around modifying test cases > but I'm not sure I follow you otherwise. What would "proper > configurability" look like in this case? > > The change I'm proposing here narrows the two test cases so they test > only what appears to have been intended, i.e. that strace can capture > readlink(at) system calls and that it reports them in the format > expected by the developers. It does not affect other test cases or the > test suite as a whole. > > The obvious alternative would be to modify the test cases' expected > output to match what is actually generated, but this could have the side > effect of tying the package to Linux and perhaps to specific versions of > glibc. Well, that would be the point :) I.e., to move the customizations into .conf files and out of test-suite sources. > > That said I'm still not sure why this additional syscall is being made > in the first place, only that it appears to originate from glibc's > "_dl_get_origin" function[0]. If I build strace from source "manually" > the tests complete fine without modification. I presume the extra call > has to do with the fact Guix builds strace inside a container; does > anyone know how this could be affecting the way programs are loaded? > I did not realize there were mods to strace itself affecting this. I thought it was about somehow filtering its output to fool tests, sorry. With strace variants maybe "proper configurability" should have to consider strace versions also, to tune test expectations ;/ > -- > Simon South > simon@simonsouth.net > > [0] See e.g. glibc's sysdeps/unix/sysv/linux/dl-origin.c for the x86-64 > case, as well as "_dl_non_dynamic_init" in elf/dl-support.c, which > seems to be the only place it is called. -- Regards, Bengt Richter From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 03 Sep 2021 21:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bengt Richter Cc: 50346@debbugs.gnu.org Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.16307044704975 (code B ref 50346); Fri, 03 Sep 2021 21:28:02 +0000 Received: (at 50346) by debbugs.gnu.org; 3 Sep 2021 21:27:50 +0000 Received: from localhost ([127.0.0.1]:45969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMGj0-0001IB-2w for submit@debbugs.gnu.org; Fri, 03 Sep 2021 17:27:50 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:33316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMGiy-0001Hv-CC for 50346@debbugs.gnu.org; Fri, 03 Sep 2021 17:27:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 756E592563; Fri, 3 Sep 2021 21:27:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GFsJvu49d1Aj; Fri, 3 Sep 2021 21:27:42 +0000 (UTC) Received: from mars (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 356A392562; Fri, 3 Sep 2021 21:27:42 +0000 (UTC) From: Simon South References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> <20210903121513.GA5202@LionPure> <877dfxbvy6.fsf@simonsouth.net> <20210903165335.GA10190@LionPure> Date: Fri, 03 Sep 2021 17:27:41 -0400 In-Reply-To: <20210903165335.GA10190@LionPure> (Bengt Richter's message of "Fri, 3 Sep 2021 18:53:35 +0200") Message-ID: <87tuj1wdrm.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Bengt Richter writes: > Well, that would be the point :) > I.e., to move the customizations into .conf files and out of > test-suite sources. Given the limited flexibility of the test harness I'm not sure there's a solution that doesn't involve modifying the source, but on reflection you're right: We actually _do_ expect the test results to differ from what is provided in the source bundle, so a better solution would be to update the tests to reflect this rather than to change how they're run. I'll put together a patch that does that. Incidentally, the reason for the test failures appears to be the additional call to _dl_get_origin() added to glibc by the "glib-dl-cache" patch in commit 52564e9, which produces an additional readlink/readlinkat syscall strace's test driver isn't expecting. But this additional call _is_ expected on Guix systems, so the test cases ought to be modified to match. -- Simon South simon@simonsouth.net From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Sep 2021 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 50346@debbugs.gnu.org Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.163078509932009 (code B ref 50346); Sat, 04 Sep 2021 19:52:02 +0000 Received: (at 50346) by debbugs.gnu.org; 4 Sep 2021 19:51:39 +0000 Received: from localhost ([127.0.0.1]:48688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbhT-0008KC-DR for submit@debbugs.gnu.org; Sat, 04 Sep 2021 15:51:39 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:53772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbhQ-0008Jx-SJ for 50346@debbugs.gnu.org; Sat, 04 Sep 2021 15:51:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id BFF2B32BCD for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:51:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LLrFfy_6mGUX for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:51:30 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 80075315A0 for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:51:30 +0000 (UTC) From: Simon South References: <875yvi93w8.fsf@simonsouth.net> <877dfy7g8n.fsf@simonsouth.net> <20210903121513.GA5202@LionPure> <877dfxbvy6.fsf@simonsouth.net> <20210903165335.GA10190@LionPure> <87tuj1wdrm.fsf@simonsouth.net> Date: Sat, 04 Sep 2021 15:51:30 -0400 In-Reply-To: <87tuj1wdrm.fsf@simonsouth.net> (Simon South's message of "Fri, 03 Sep 2021 17:27:41 -0400") Message-ID: <87bl58w24d.fsf@simonsouth.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon South writes: > But this additional call _is_ expected on Guix systems, so the test > cases ought to be modified to match. Perhaps, but having looked into this it's complicated because - The expected output from the tests is not contained in the source bundle in a separate, easy-to-patch file but is actually generated by the C code under test as it runs; - Even if that weren't true, only one test must be patched for both to succeed, and the choice depends on the target architecture so there wouldn't be a single patch that could work in all cases; and - The additional output that needs to be generated by the C code actually embeds part of a store path, meaning this would need to be determined by the code at runtime (possibly yielding even more "readlink" calls that would need to be accounted for) in addition to truncating and formatting the output to match what strace itself produces... It's too much. I'm going to follow up with a patch that basically applies the diff above in a tidy manner, and I think that will be the best solution. It is a very limited change that does not alter the purpose of the tests; does not allow them to pass where they would normally fail; and will work equally well on all systems, even if a completely different glibc package is introduced. Certainly it is an improvement over simply disabling both tests. -- Simon South simon@simonsouth.net From unknown Sun Jun 22 07:49:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50346: [PATCH core-updates-frozen] gnu: strace: Allow readlink, readlinkat tests to pass. References: <875yvi93w8.fsf@simonsouth.net> In-Reply-To: <875yvi93w8.fsf@simonsouth.net> Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 04 Sep 2021 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50346 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 50346@debbugs.gnu.org Received: via spool by 50346-submit@debbugs.gnu.org id=B50346.163078551932616 (code B ref 50346); Sat, 04 Sep 2021 19:59:01 +0000 Received: (at 50346) by debbugs.gnu.org; 4 Sep 2021 19:58:39 +0000 Received: from localhost ([127.0.0.1]:48692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbo8-0008Tr-9p for submit@debbugs.gnu.org; Sat, 04 Sep 2021 15:58:39 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:33352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbo6-0008Td-8T for 50346@debbugs.gnu.org; Sat, 04 Sep 2021 15:58:31 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 517DE3327E for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:58:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9VyS0TkER8sN for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:58:24 +0000 (UTC) Received: from localhost.localdomain (unknown [108.162.141.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id E3F8633276 for <50346@debbugs.gnu.org>; Sat, 4 Sep 2021 19:58:23 +0000 (UTC) From: Simon South Date: Sat, 4 Sep 2021 15:58:21 -0400 Message-Id: <20210904195821.14743-1-simon@simonsouth.net> X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Modify the invocation of strace's "readlink" and "readlinkat" tests to prevent them from failing due to an additional system call made by Guix's patched version of glibc. * gnu/packages/linux.scm (strace)[source]: Add patch. [arguments]<#:phases>: Do not disable the "readlink" test now that it can succeed. * gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 1 + gnu/packages/linux.scm | 8 ++-- ...strace-fix-readlink-readlinkat-tests.patch | 46 +++++++++++++++++++ 3 files changed, 50 insertions(+), 5 deletions(-) create mode 100644 gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch diff --git a/gnu/local.mk b/gnu/local.mk index bb22e29caa..f9c8956568 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1547,6 +1547,7 @@ dist_patch_DATA = \ %D%/packages/patches/sdl-pango-sans-serif.patch \ %D%/packages/patches/smalltalk-multiplication-overflow.patch \ %D%/packages/patches/sqlite-hurd.patch \ + %D%/packages/patches/strace-fix-readlink-readlinkat-tests.patch \ %D%/packages/patches/sunxi-tools-remove-sys-io.patch \ %D%/packages/patches/patchutils-test-perms.patch \ %D%/packages/patches/patch-hurd-path-max.patch \ diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 63f0e4108c..99b7ce7066 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -2240,7 +2240,9 @@ Zerofree requires the file system to be unmounted or mounted read-only.") "/strace-" version ".tar.xz")) (sha256 (base32 - "0mmns22bjjvakxj29si0x4dcylcgy26llpcimkb0llcxif439k2s")))) + "0mmns22bjjvakxj29si0x4dcylcgy26llpcimkb0llcxif439k2s")) + (patches + (search-patches "strace-fix-readlink-readlinkat-tests.patch")))) (build-system gnu-build-system) (arguments '(#:phases @@ -2253,10 +2255,6 @@ Zerofree requires the file system to be unmounted or mounted read-only.") (add-after 'unpack 'disable-failing-tests (lambda _ (substitute* "tests/Makefile.in" - ;; XXX: This test fails because an extra readlink call is made - ;; by the glibc when using the ld.so cache. - (("readlink.gen.test[^:]") " ") - ;; XXX: These hang forever even if the test time-out is ;; extended. (("^\tstrace-DD?D?\\.test \\\\.*") "") diff --git a/gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch b/gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch new file mode 100644 index 0000000000..dd5ee98703 --- /dev/null +++ b/gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch @@ -0,0 +1,46 @@ +Prevent strace's "readlink" and "readlinkat" tests from failing due to the +additional system call made by glibc with the patch "glibc-dl-cache.patch" +applied (introduced in commit 52564e9). + +These changes cause strace to report during these tests only system calls on +files contained in the test directory, effectively filtering out the +additional readlink/readlinkat call on "/proc/self/exe" and allowing the tests +to complete as normal. + +diff --git a/tests/gen_tests.in b/tests/gen_tests.in +index 8b4e2e9..cc3ca63 100644 +--- a/tests/gen_tests.in ++++ b/tests/gen_tests.in +@@ -623,8 +623,8 @@ quotactl-xfs-v -v -e trace=quotactl + read-write -a15 -eread=0,5 -ewrite=1,4 -e trace=read,write -P read-write-tmpfile -P /dev/zero -P /dev/null + readahead -a1 + readdir -a16 +-readlink -xx +-readlinkat -xx ++readlink -xx --trace-path=test.readlink.link ++readlinkat -xx --trace-path=test.readlinkat.link + reboot -s 256 + recv-MSG_TRUNC -a26 -e trace=recv + recvfrom -a35 +diff --git a/tests/readlink.gen.test b/tests/readlink.gen.test +index 4263234..418691b 100755 +--- a/tests/readlink.gen.test ++++ b/tests/readlink.gen.test +@@ -1,4 +1,4 @@ + #!/bin/sh -efu +-# Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (readlink -xx ); do not edit. ++# Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (readlink -xx --trace-path=test.readlink.link); do not edit. + . "${srcdir=.}/init.sh" +-run_strace_match_diff -xx ++run_strace_match_diff -xx --trace-path=test.readlink.link +diff --git a/tests/readlinkat.gen.test b/tests/readlinkat.gen.test +index d7de993..a48d590 100755 +--- a/tests/readlinkat.gen.test ++++ b/tests/readlinkat.gen.test +@@ -1,4 +1,4 @@ + #!/bin/sh -efu +-# Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (readlinkat -xx ); do not edit. ++# Generated by ./tests/gen_tests.sh from ./tests/gen_tests.in (readlinkat -xx --trace-path=test.readlinkat.link); do not edit. + . "${srcdir=.}/init.sh" +-run_strace_match_diff -xx ++run_strace_match_diff -xx --trace-path=test.readlinkat.link -- 2.25.2 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 04 16:03:43 2021 Received: (at control) by debbugs.gnu.org; 4 Sep 2021 20:03:43 +0000 Received: from localhost ([127.0.0.1]:48700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbt9-0000B8-4R for submit@debbugs.gnu.org; Sat, 04 Sep 2021 16:03:43 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:44922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMbt7-0000Av-OK for control@debbugs.gnu.org; Sat, 04 Sep 2021 16:03:42 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id D21DE9290D for ; Sat, 4 Sep 2021 20:03:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo01-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo01-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qfjb7oL2i-MU for ; Sat, 4 Sep 2021 20:03:35 +0000 (UTC) Received: from laptop (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 774F592909 for ; Sat, 4 Sep 2021 20:03:35 +0000 (UTC) From: Simon South To: control@debbugs.gnu.org Subject: Re: [PATCH core-updates-frozen] gnu: strace: Allow readlink, readlinkat tests to pass. Date: Sat, 04 Sep 2021 16:03:35 -0400 Message-ID: <874kb0w1k8.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 50346 + patch thanks -- Simon South simon@simonsouth.net From unknown Sun Jun 22 07:49:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simon South Subject: bug#50346: closed (Re: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64) Message-ID: References: <875yspr4hr.fsf_-_@gnu.org> <875yvi93w8.fsf@simonsouth.net> X-Gnu-PR-Message: they-closed 50346 X-Gnu-PR-Package: guix X-Gnu-PR-Keywords: patch Reply-To: 50346@debbugs.gnu.org Date: Thu, 18 Nov 2021 13:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1637241242-10774-1" This is a multi-part message in MIME format... ------------=_1637241242-10774-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 50346@debbugs.gnu.org. --=20 50346: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50346 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1637241242-10774-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 50346-done) by debbugs.gnu.org; 18 Nov 2021 13:13:50 +0000 Received: from localhost ([127.0.0.1]:35094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnhEb-0002nB-Qj for submit@debbugs.gnu.org; Thu, 18 Nov 2021 08:13:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnhEW-0002ms-Rb for 50346-done@debbugs.gnu.org; Thu, 18 Nov 2021 08:13:48 -0500 Received: from [2001:470:142:3::e] (port=48748 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnhER-0007CO-7Y; Thu, 18 Nov 2021 08:13:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=Amj93T6iDYGthGjso+x0qQGWgIpvh36WKnt0ZQxc5Nw=; b=eLGgdT0NQ3Qd0ObgPcUw dGluV4tYz+2wYawQwsR7aH2pXe6g5Bkl7Z4xNEFgG7t9/p8JyyLsYzVr0VeDE9r1d0wEYuTp2Mdbu W/YbfXmuBPvTeXA1Ovx670I793WDcdUSKDzlE6sYcaMrbknU1MNW21FfMUtwFZ/INcfgNRcOcxOIa F5tC8dnZooRwuJtVnJC/Oiy/FDsyFtrL6GqsrrXhOeqdqDwZvUzMYESEy4Q+pn7rcxgsoLqXV6AyB uTLrrEO4kx9ho/KusCnTZ0SpRzJkTk5QgpFqV+64iUyxRhLLvu2z7/USsbtv36QEmIVmQLM10NHj7 xTIacjhEWZcyQQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:54213 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnhER-0006RB-0b; Thu, 18 Nov 2021 08:13:39 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon South Subject: Re: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 References: <875yvi93w8.fsf@simonsouth.net> <20210904195821.14743-1-simon@simonsouth.net> Date: Thu, 18 Nov 2021 14:13:36 +0100 In-Reply-To: <20210904195821.14743-1-simon@simonsouth.net> (Simon South's message of "Sat, 4 Sep 2021 15:58:21 -0400") Message-ID: <875yspr4hr.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50346-done Cc: 50346-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Simon, Simon South skribis: > Modify the invocation of strace's "readlink" and "readlinkat" tests to pr= event > them from failing due to an additional system call made by Guix's patched > version of glibc. > > * gnu/packages/linux.scm (strace)[source]: Add patch. > [arguments]<#:phases>: Do not disable the "readlink" test now that it can > succeed. > * gnu/packages/patches/strace-fix-readlink-readlinkat-tests.patch: New fi= le. > * gnu/local.mk (dist_patch_DATA): Add it. Good catch! Pushed with a shortened patch file name as b0eaa4f2d73cd7746a41d1f970b95243f2098458. Thanks, Ludo=E2=80=99. ------------=_1637241242-10774-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 19:25:06 +0000 Received: from localhost ([127.0.0.1]:42079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLsKf-0003J5-Lj for submit@debbugs.gnu.org; Thu, 02 Sep 2021 15:25:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:44264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLsKb-0003Im-N5 for submit@debbugs.gnu.org; Thu, 02 Sep 2021 15:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLsKb-0008Jm-DA for bug-guix@gnu.org; Thu, 02 Sep 2021 15:25:01 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:51884) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLsKZ-0005E7-Bq for bug-guix@gnu.org; Thu, 02 Sep 2021 15:25:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 39B2C3262D for ; Thu, 2 Sep 2021 19:24:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo03-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z6AHaRApVA3V for ; Thu, 2 Sep 2021 19:24:56 +0000 (UTC) Received: from mars (unknown [108.162.141.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 00CBD3262A for ; Thu, 2 Sep 2021 19:24:55 +0000 (UTC) From: Simon South To: bug-guix@gnu.org Subject: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Date: Thu, 02 Sep 2021 15:24:55 -0400 Message-ID: <875yvi93w8.fsf@simonsouth.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) strace 5.13 in core-updates-frozen appears to build fine but fails its "readlinkat" test for me on AArch64 (real hardware; a ROCK64). This is the only test that fails. >From the build directory, strace-5.13/tests/readlinkat.dir/exp contains readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory) readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22 +++ exited with 0 +++ but strace-5.13/tests/readlinkat.dir/out shows readlinkat(AT_FDCWD, "\x2f\x70\x72\x6f\x63\x2f\x73\x65\x6c\x66\x2f\x65\x78\x65", "\x2f\x74\x6d\x70\x2f\x67\x75\x69\x78\x2d\x62\x75\x69\x6c\x64\x2d\x73\x74\x72\x61\x63\x65\x2d\x35\x2e\x31\x33\x2e\x64\x72\x76\x2d"..., 4096) = 62 readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", 0xfffff7e2cfea, 22) = -1 ENOENT (No such file or directory) readlinkat(AT_FDCWD, "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x6c\x69\x6e\x6b", "\x74\x65\x73\x74\x2e\x72\x65\x61\x64\x6c\x69\x6e\x6b\x61\x74\x2e\x74\x61\x72\x67\x65\x74", 22) = 22 +++ exited with 0 +++ The only difference is an additional line at the start of the generated output. I see this in the strace package definition (gnu/packages/linux.scm:2256): ;; XXX: This test fails because an extra readlink call is made ;; by the glibc when using the ld.so cache. (("readlink.gen.test[^:]") " ") Perhaps the same is true for readlinkat on AArch64? -- Simon South simon@simonsouth.net ------------=_1637241242-10774-1--