GNU bug report logs - #50345
28.0.50; [PATCH] Filling holes in css-mode.el

Previous Next

Full log

View this message in rfc822 format

From: Simen Heggestøyl <simenheg <at> runbox.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 50345 <at> debbugs.gnu.org
Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el
Date: Fri, 03 Sep 2021 09:46:52 +0200

Hi Theodor,

Theodor Thornhill <theo <at> thornhill.no> <bug-gnu-emacs <at> gnu.org> writes:

> I took the liberty to add the keywords from [0].

Thanks!

> I see that some properties are extracted out into variables, but not
> sure what is standard practice here.

I've previously tried keeping them one-to-one with the property index
grammars (https://www.w3.org/TR/css-align-3/#property-index).

So for instance `place-content` would just refer back to `align-content`
and `justify-content` without the need to repeat their properties:

  ("place-content" align-content justify-content)

`align-content` is a bit more convoluted, with a mix of a literal value
and value classes in the grammar:

  ("align-content" "normal" baseline-position content-distribution
   overflow-position content-position)

The value classes aren't properties, so their values go into
`css-value-class-alist`. For instance, `baseline-position` can take
values:

  (baseline-position "first" "last" "baseline")

This can then be reused by other properties again.

Does this make sense? I should probably document this practice a bit
better. 😅

-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.