From unknown Sun Jun 22 11:45:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 50345@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16306083899169 (code B ref -1); Thu, 02 Sep 2021 18:47:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Sep 2021 18:46:29 +0000 Received: from localhost ([127.0.0.1]:42050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrjI-0002Np-TH for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:46:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:59414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLrjH-0002Ng-6c for submit@debbugs.gnu.org; Thu, 02 Sep 2021 14:46:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrjG-0005yt-4V for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:46:26 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:10812) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLrjA-0006gQ-0G for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 14:46:25 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630608374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MCWaruJGD6Ydx0EPC3PhNerVzlp6NoyfsD3/U1rkkIk=; b=MQ7dw+3CGN8KVRynNsYux45viJJ/TdtEI6sfNpaOVm1hOLZhuKolJg4+iuQNcIhe5+1MwY bbbqTz0PinZlNUg0XQ7ZjBFhciVWEYS+Wh4wK8KkthawJDv+fJpGvKFKxFnS+55gY8XjiK qjX5R0mBcPi1Bs8huiIe4EpqYiwqqLKxYppq7nvWn4WUpg19ro0hfKKSlMM/PogJW1Or+U XWgeyDjRQoNrxfQGc9YObcHruRS8BJfItFhl0P9KVXRgBk1G+IFW3yaDp8sFHss5tZMETf 0Ja7ypnUhYgwSHR9wic3ssCEIWYVm8dITlZ2eGOgEKncLD0IJwd1kdYwjJtG+g== From: Theodor Thornhill Date: Thu, 02 Sep 2021 20:46:12 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=theo@thornhill.no; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hello! In $DAYJOB, right now we are working on a larger redesign of our customer facing web app. As such I'm knee deep in css these days. I've noticed there are some holes in the completion keywords, and I'd like to start addressing those. Hence the first, simple starting-point patch. Before I continue adding patches, I'd like some pointers as to how I should structure them. For example - lots of keywords are now shared between grid and flex. An example is `align-content', which is now under a section devoted to flex. However, there are some newer, grid-related completion keywords that are not in this section, nor anywhere else. See line 306 in css-mode.el. I guess the solution here is to add `start' and `end' there, but I want to check first. Should I add several, smaller patches, or one big correction of most of the things I see at the moment? Best, Theodor Thornhill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-selection-to-css-pseudo-element-ids.patch >From b0a4ec120d3371982878e523f33c34bed59c1371 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Thu, 2 Sep 2021 20:27:19 +0200 Subject: [PATCH] Add selection to css-pseudo-element-ids * lisp/textmodes/css-mode.el (css-pseudo-element-ids): Add selection as an element id --- lisp/textmodes/css-mode.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 61a2f6b3bc..3bcd9c9766 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -57,7 +57,7 @@ "Identifiers for pseudo-classes.") (defconst css-pseudo-element-ids - '("after" "before" "first-letter" "first-line") + '("after" "before" "first-letter" "first-line" "selection") "Identifiers for pseudo-elements.") (defconst css-at-ids -- 2.30.1 (Apple Git-130) --=-=-=-- From unknown Sun Jun 22 11:45:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el References: In-Reply-To: Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 21:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 50345@debbugs.gnu.org Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163061774623508 (code B ref 50345); Thu, 02 Sep 2021 21:23:01 +0000 Received: (at 50345) by debbugs.gnu.org; 2 Sep 2021 21:22:26 +0000 Received: from localhost ([127.0.0.1]:42223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuAE-000676-3P for submit@debbugs.gnu.org; Thu, 02 Sep 2021 17:22:26 -0400 Received: from out2.migadu.com ([188.165.223.204]:37063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuA9-00066v-BX for 50345@debbugs.gnu.org; Thu, 02 Sep 2021 17:22:24 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630617739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=pAVB/qSrko3KsJaAp7PfupN471xb8AtFcaXYhV6cVJw=; b=jljuqLSCGxeSKVykE+gP5Wr1nXxDG8odRxny5sH15FhsCqNyVi9dmxVJ4UTCdvsnZ2d2kA aABWw7dHka23Pz2f7yx1ySfSD1PDsMDxXw36x6Jy+wopaojOIvs2szC0S/ZPtwUT9Yd7BP Aoitl4rSXbPv9o2xE4la0knLGanyQr9vAyo4PnTTqCJHQ4NxD5zwiLkgiY6TVJ/zea/6mv 1a9gD0gEx1uTv80K4b/HBImEosYtcyo4cKrDTROcEVOreNxf8lrpkO8IXuA5WyfQVHIIx7 RWIqykjcpXM5TbtLMDc23pxZo+2nC5k23xZHxSBD4ojD68Nl4ZQLmbq/d1wqVQ== From: Theodor Thornhill Date: Thu, 02 Sep 2021 23:22:17 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi again! I took the liberty to add the keywords from [0]. I moved the justify and align parts out from the flex block and into its own block. I also took the liberty to add the `place' variants as well. These are used a lot when using grid to set up your web page. I hope this is usable. I see that some properties are extracted out into variables, but not sure what is standard practice here. Good evening, Theodor [0]: https://www.w3.org/TR/css-align-3 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-CSS-Box-Alignment-Module-Level-3-to-css-mode.patch >From dccf92224cbe37805ae53edb49be4c098df47d0c Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Thu, 2 Sep 2021 23:13:02 +0200 Subject: [PATCH] Add CSS Box Alignment Module Level 3 to css-mode * lisp/textmodes/css-mode.el (css-property-alist): Consolidate `align-{contents, items, self}', as well as the corresponding values for `justify-{contents, items, self}' and `place-{contents, items, self}'. Values extracted from the flex part and into its own block. --- lisp/textmodes/css-mode.el | 38 ++++++++++++++++++++++++++++++-------- 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 3bcd9c9766..f406afb7b6 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -301,14 +301,38 @@ ("grid-template-columns" "none" track-list auto-track-list) ("grid-template-rows" "none" track-list auto-track-list) + ;; CSS Box Alignment Module Level 3 + ;; (https://www.w3.org/TR/css-align-3/#alignment-values) + ("align-content" "center" "start" "end" "flex-start" "flex-end" + "normal" "first" "last" "baseline" "space-between" "space-around" + "space-evenly" "stretch" "safe" "unsafe") + ("align-items" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "baseline" "first" "last" "baseline" + "safe" "unsafe") + ("align-self" "auto" "normal" "center" "start" "end" + "self-start" "self-end" "flex-start" "flex-end" + "baseline" "first" "last" "stretch" "safe" "unsafe") + ("justify-content" "center" "start" "end" "flex-start" "flex-end" + "left" "right" "normal" "space-between" "space-around" + "space-evenly" "stretch" "safe" "unsafe") + ("justify-items" "auto" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "self-start" "self-end" "left" "right" + "baseline" "first" "last" "legacy" "safe" "unsafe") + ("justify-self" "auto" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "self-start" "self-end" "left" "right" + "baseline" "first" "last" "safe" "unsafe") + ("place-content" "center" "start" "end" "left" "right" "flex-start" + "flex-end" "baseline" "first" "last" "space-evenly" "space-around" + "space-between") + ("place-items" "auto" "normal" "center" "start" "end" + "self-start" "self-end" "flex-start" "flex-end" + "left" "right" "baseline" "first" "last" "stretch") + ("place-self" "auto" "center" "start" "end" "self-start" "self-end" + "flex-start" "flex-end" "normal" "left" "right" "baseline" + "first" "last" "stretch") + ;; CSS Flexible Box Layout Module Level 1 ;; (https://www.w3.org/TR/css-flexbox-1/#property-index) - ("align-content" "flex-start" "flex-end" "center" "space-between" - "space-around" "stretch") - ("align-items" "flex-start" "flex-end" "center" "baseline" - "stretch") - ("align-self" "auto" "flex-start" "flex-end" "center" "baseline" - "stretch") ("flex" "none" flex-grow flex-shrink flex-basis) ("flex-basis" "auto" "content" width) ("flex-direction" "row" "row-reverse" "column" "column-reverse") @@ -316,8 +340,6 @@ ("flex-grow" number) ("flex-shrink" number) ("flex-wrap" "nowrap" "wrap" "wrap-reverse") - ("justify-content" "flex-start" "flex-end" "center" - "space-between" "space-around") ("order" integer) ;; CSS Fonts Module Level 3 -- 2.30.1 (Apple Git-130) --=-=-=-- From unknown Sun Jun 22 11:45:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 06:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Theodor Thornhill Cc: 50345@debbugs.gnu.org Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163064976024863 (code B ref 50345); Fri, 03 Sep 2021 06:16:01 +0000 Received: (at 50345) by debbugs.gnu.org; 3 Sep 2021 06:16:00 +0000 Received: from localhost ([127.0.0.1]:42596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2Ua-0006Sx-2W for submit@debbugs.gnu.org; Fri, 03 Sep 2021 02:16:00 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2UW-0006Si-3F for 50345@debbugs.gnu.org; Fri, 03 Sep 2021 02:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QJUJSbvAapdjhp3Ba02ViUUlVxqifywZxsdSbtkw+CU=; b=B/+f4VEABtwsG3LjTQN2FlWkEA 3GTgpUfVD9xQixpmPuWhFVcunBWYjU7NoSuCEJyCZ9HifY8rESjbfbGUWT6/Am9hsVsbqnLyemrf1 PErWxf/OsINQO1elORLw55FtR0BxN3HOCJZEsgQ3XjXbpmqvaTVGbyIGu2VT1InGRYG4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM2UM-0003Ay-J8; Fri, 03 Sep 2021 08:15:49 +0200 From: Lars Ingebrigtsen References: Date: Fri, 03 Sep 2021 08:15:46 +0200 In-Reply-To: (Theodor Thornhill's message of "Thu, 02 Sep 2021 20:46:12 +0200") Message-ID: <87v93i4225.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Theodor Thornhill writes: > Should I add several, smaller patches, or one big correction of most of > the things I see at the moment? Smaller patches are best, I think. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Theodor Thornhill writes: > Should I add several, smaller patches, or one big correction of most of > the things I see at the moment? Smaller patches are best, I think. Theodor Thornhill writes: > I moved the justify and align parts out from the flex block and into its > own block. I also took the liberty to add the `place' variants as well. > These are used a lot when using grid to set up your web page. I hope > this is usable. I see that some properties are extracted out into > variables, but not sure what is standard practice here. Both patches look good to me; pushed to Emacs 28 now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 03 02:16:07 2021 Received: (at control) by debbugs.gnu.org; 3 Sep 2021 06:16:07 +0000 Received: from localhost ([127.0.0.1]:42600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2Uh-0006Tt-9y for submit@debbugs.gnu.org; Fri, 03 Sep 2021 02:16:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM2Uf-0006T5-Jr for control@debbugs.gnu.org; Fri, 03 Sep 2021 02:16:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zl63Oczjv4XasxH8tZvy7BZdTg1L099qRAF74pAKZCA=; b=KFB8HcIpydg8U2aZK3YEDYoMfr Wh1vYcirgEcYKkK5Aflzpbnt5cp+hwc5dQ4MMgdKkcQPAAvvXTDMNxt18/ZrAQTbS6RtIj3TlpFoI 0DTGOkazlQ+9JIyxkDSmC4xN4sGvouu0PjxQe8cFNZOUaOGo+ZfDxw//MM7YsRMkGHUc=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM2UX-0003BV-NW for control@debbugs.gnu.org; Fri, 03 Sep 2021 08:15:59 +0200 Date: Fri, 03 Sep 2021 08:15:52 +0200 Message-Id: <87tuj2421z.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50345 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 50345 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 50345 28.1 quit From unknown Sun Jun 22 11:45:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Theodor Thornhill Cc: 50345@debbugs.gnu.org Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163065523511088 (code B ref 50345); Fri, 03 Sep 2021 07:48:02 +0000 Received: (at 50345) by debbugs.gnu.org; 3 Sep 2021 07:47:15 +0000 Received: from localhost ([127.0.0.1]:42758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM3ut-0002sm-AW for submit@debbugs.gnu.org; Fri, 03 Sep 2021 03:47:15 -0400 Received: from aibo.runbox.com ([91.220.196.211]:44518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM3uq-0002sV-1j for 50345@debbugs.gnu.org; Fri, 03 Sep 2021 03:47:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=VaJIkXv0ZA/X2mSKlpTalMKn3ELczHWm4692vVSoZlo=; b=l51uLqRykk6bKAtDz2Mv2wH+PN Zma89IgBeQnRtd3sPch+0Frib0W6wspf6xqoQ8Cq2eVue6Nfw1MHWaoVd4VDEk4q1o5O31ciQkDkX W0hHyLWDdUeOzZg1W6EYS9cfv6GbMMd0AnCSdXmaLyKtXDv0fKlafA7otP2zXfTTinBvQ7nTJHMOT I1yDDMPqmSmr97RX6ocNnF2jkgN4KQD8K8+MlU4ZG/lNfa4RRFEYkbkDALtwPpoWGNm659YaXQSh3 y1A5ZHG5Z+M9SUOj6FcbWUk3zoGSIL/jIjlHEfvhhZDkI0l41TmpnnogYGlxwkndK5VE2C04B4/eA QZTInfrg==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1mM3un-0000Hb-Hk; Fri, 03 Sep 2021 09:47:09 +0200 Received: by submission01.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1mM3uX-0007kx-2R; Fri, 03 Sep 2021 09:46:53 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= References: Date: Fri, 03 Sep 2021 09:46:52 +0200 In-Reply-To: (Theodor Thornhill via's message of "Thu, 02 Sep 2021 23:22:17 +0200") Message-ID: <87pmtqummr.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Theodor, Theodor Thornhill writes: > I took the liberty to add the keywords from [0]. Thanks! > I see that some properties are extracted out into variables, but not > sure what is standard practice here. I've previously tried keeping them one-to-one with the property index grammars (https://www.w3.org/TR/css-align-3/#property-index). So for instance `place-content` would just refer back to `align-content` and `justify-content` without the need to repeat their properties: ("place-content" align-content justify-content) `align-content` is a bit more convoluted, with a mix of a literal value and value classes in the grammar: ("align-content" "normal" baseline-position content-distribution overflow-position content-position) The value classes aren't properties, so their values go into `css-value-class-alist`. For instance, `baseline-position` can take values: (baseline-position "first" "last" "baseline") This can then be reused by other properties again. Does this make sense? I should probably document this practice a bit better. =F0=9F=98=85 -- Simen From unknown Sun Jun 22 11:45:11 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: 50345@debbugs.gnu.org Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163066009020203 (code B ref 50345); Fri, 03 Sep 2021 09:09:02 +0000 Received: (at 50345) by debbugs.gnu.org; 3 Sep 2021 09:08:10 +0000 Received: from localhost ([127.0.0.1]:42936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5BC-0005Fn-9k for submit@debbugs.gnu.org; Fri, 03 Sep 2021 05:08:10 -0400 Received: from out0.migadu.com ([94.23.1.103]:54176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5B9-0005Fa-N7 for 50345@debbugs.gnu.org; Fri, 03 Sep 2021 05:08:09 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630660084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YJRb/BP6G6v6xSBPE+jMQq/FQX+zi2mh3Mttlg1qVuw=; b=g/5KDoGWAI2JXPgP6/Yy7pgcxXdFp0jNnCJRP1TsK98txNtFOPJkdOEMCSd+1F85Lajppj YEYw9u6gVkg3vBxjB9KNMCplm/ffYwViPH/cmHr7SJRqDbCPJsgl/LLzh9hdoGEBxeHNM6 cCmp1JnBSB/FQ4iYBZA/5pVA31GgM0toF48xI5gq4McrSSVSbi/D5mzWCjlGGPyVWYhIzZ tbaeYdUvmO6BdoHXgbofQd6otnTSBx2ga/AlUhd5btisavskgAN1w3Ahip9IVPiU8spQ5K Tr22Pg36FoOgRbhL1LjDNr5VExYGWxBDHjoCWwrcoFDNvOWJmahvLz4QJYdF3w== From: Theodor Thornhill In-Reply-To: <87pmtqummr.fsf@runbox.com> References: <87pmtqummr.fsf@runbox.com> Date: Fri, 03 Sep 2021 11:08:02 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Simen! > > Thanks! My pleasure! > >> I see that some properties are extracted out into variables, but not >> sure what is standard practice here. > > I've previously tried keeping them one-to-one with the property index > grammars (https://www.w3.org/TR/css-align-3/#property-index). > > So for instance `place-content` would just refer back to `align-content` > and `justify-content` without the need to repeat their properties: > > ("place-content" align-content justify-content) > > `align-content` is a bit more convoluted, with a mix of a literal value > and value classes in the grammar: > > ("align-content" "normal" baseline-position content-distribution > overflow-position content-position) > > The value classes aren't properties, so their values go into > `css-value-class-alist`. For instance, `baseline-position` can take > values: > > (baseline-position "first" "last" "baseline") > > This can then be reused by other properties again. > > Does this make sense? I should probably document this practice a bit > better. =F0=9F=98=85 > Yeah, this is the answer I wanted. I'll look into doing this in the next patches I send. I think it would be nice to document this down the line as well, yes. I can see what I can do about that too :) Have a nice weekend! Theodor