GNU bug report logs - #50344
C-x v keybinding for vc-print-branch-log

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Filipp Gunbin <fgunbin <at> fastmail.fm>
Cc: 50344 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#50344: C-x v keybinding for vc-print-branch-log
Date: Thu, 07 Oct 2021 20:27:07 +0300

> Thanks, two very minor doc comments:
>
>> +;;;###autoload
>> +(defun vc-retrieve-tag (dir name &optional branchp)
>>    "For each file in or below DIR, retrieve their tagged version NAME.
>>  NAME can name a branch, in which case this command will switch to the
>>  named branch in the directory DIR.
>> @@ -2375,15 +2413,21 @@ vc-retrieve-tag
>>               (read-directory-name "Directory: " default-directory nil t))))
>>       (list
>>        dir
>> -      (vc-read-revision (format-prompt "Tag name to retrieve" "latest revisions")
>> +      (vc-read-revision (format-prompt
>> +                         (if current-prefix-arg
>> +                             "Branch name to retrieve"
>> +                           "Tag name to retrieve")
>> +                         "latest revisions")
>
> Mention prefix arg in the docstring?

Thanks for noticing, will be added in the next version of the patch.

>> +(defun vc-switch-branch (dir name)
>> +  "Switch to the branch NAME in the directory DIR.
>> +If NAME is empty, it refers to the latest revisions of the current branch.
>> +Uses `vc-retrieve-tag' with the non-nil arg `branchp'."
>
> "latest revision" instead of plural?

This text was copied from vc-retrieve-tag, and Robert explained why
it's plural.  But since this phrase is too confusing, maybe it would be
possible to rephrase it with a better text?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.