Subject: bug#50341: closed (Re: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 03 Sep 2021 14:29:02 +0000

Your bug report

#50341: [PATCH 0/1] emacs-org-roam include extensions

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
50341: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50341
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
From: "Collin J. Doering" <[email-masked]>
To: [email-masked]
Date: Fri, 03 Sep 2021 10:25:43 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

I realized this morning that this change, unlike
https://issues.guix.gnu.org/50333 does not copy extensions into the
load-path that will be used, which is certainly not favorable.

I think that longer term we likely want to have a separate package that
includes these org-roam extensions.

Closing this issue in preference of 50333.

On 02 Sep 2021 at 12:48, "Collin J. Doering" <[email-masked]> wrote:

> Noticed that this duplicates (https://issues.guix.gnu.org/50333),
> however in 50333, another build phase is added to copy over extensions
> which is not necessary give the #:include option (as used in the patchset).
>
> On 02 Sep 2021 at 12:36, "Collin J. Doering" <[email-masked]> wrote:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index c106e81fa5..bb6d0b0757 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
>>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
>>      (build-system emacs-build-system)
>>      (arguments
>> -     `(#:phases
>> +     `(#:include (cons "^extensions/" %default-include)
>> +       #:phases
>>         (modify-phases %standard-phases
>>           (add-after 'install 'install-image
>>             (lambda* (#:key outputs #:allow-other-keys)
>> -- 
>> 2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca

Subject: [PATCH 0/1] emacs-org-roam include extensions
From: "Collin J. Doering" <[email-masked]>
To: [email-masked]
Date: Thu, 02 Sep 2021 12:27:15 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

This resolves issues with the emacs-org-roam packages after the 2.0.0 ->
2.1.0 upgrade. Upstream, some parts of org-roam have been moved to an
extensions directory. This patch also includes these extensions.

In the future, we may want to provide these as a separate output.

Collin J. Doering (1):
  gnu: Update emacs-org-roam to include extensions

 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca