GNU bug report logs - #50340
Fix remote-location in vc-git-log-incoming

Previous Next

Package: emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Thu, 2 Sep 2021 16:18:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 50340 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 50340 <at> debbugs.gnu.org
Subject: Re: bug#50340: Fix remote-location in vc-git-log-incoming
Date: Fri, 03 Sep 2021 11:12:40 +0300
>> -  (vc-git-command nil 0 nil "fetch")
>> +  (vc-git-command nil 0 nil "fetch" (unless (string= remote-location "")
>> +                                      remote-location))
>
> I'm not sure which scenario this fixes (pressing RET after 'C-u C-x v I'
> works fine here), but it shouldn't hurt either.

It fixes the scenario with a non-default remote.  Could you try 'C-u C-x v I'
and typing the name of a non-default remote in a repo with two remotes?
I wonder if it already worked, and maybe I have some misconfiguration.

> So if you have a stable repro (some alternative completing-read-function?),
> you can go ahead and install.

Regarding the default completing-read-function, the prompt of 'C-u C-x v I'
doesn't provide completion on remote names.  Maybe this should be improved
as well.




This bug report was last modified 2 years and 310 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.