Subject: Re: bug#50327: [PATCH 0/2] Improved ‘free diskspace’ message + a question

From: Ludovic Courtès <[email-masked]>
Date: Sat, 18 Sep 2021 11:55:06 +0200

Hi,

Tobias Geerinckx-Rice <[email-masked]> skribis:

> This improves the warning given when free space looks sus.
>
> From:
>
>  note: build failure may have been caused by lack of free disk   space
>
> to:
>
>  note: only 0.01 MiB available in ‘/gnu/store’
>  note: only 5.00 MiB available in ‘/tmp/guix-build-foo.drv-0’
>  note: build failure may have been caused by lack of free disk   space
>
> It also raises the warning threshold from 8 to 64 MiB, which is a much
> prettier arbitrary integer.

LGTM.  :-)

Eventually we should i18n messages coming from the daemon.

> Question: shouldn't all of nix/ have licence headers added too? As it
> stands, there are two very lonely ones in
> nix/libstore/builtins.{cc,hh} and that's it.

Yeah well, they were taken as-is from Nix.  I wouldn’t bother,
especially since we wouldn’t what copyright holders to list in there.

Thanks!

Ludo’.