GNU bug report logs - #50320
28.0.50; Recent changes cause functions in sh-script-mode to be indented incorrectly

Previous Next

Full log

Message #11 received at 50320 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: Diego <dieggsy <at> pm.me>, 50320 <at> debbugs.gnu.org
Subject: Re: bug#50320: 28.0.50; Recent changes cause functions in
 sh-script-mode to be indented incorrectly
Date: Thu, 02 Sep 2021 08:44:54 +0200

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

>> I'm not quite sure when this behavior was introduced, but I suspect
>> commits 4bb70549 or 6392bc37a may be responsible:
>
> Seems to be 6392bc37a; reverting it makes your test case pass again.

I've now reverted the change and added a test.

> As things stand, I don't know enough about SMIE to understand what the
> correct fix is.  A plain revert might be the best immediate action,
> unless someone knowledgeable enough can reconcile my commit with Diego's
> example.

My understanding of SMIE is ... pretty vague.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.