From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 31 12:19:14 2021 Received: (at submit) by debbugs.gnu.org; 31 Aug 2021 16:19:14 +0000 Received: from localhost ([127.0.0.1]:35278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL6Te-0006zd-IB for submit@debbugs.gnu.org; Tue, 31 Aug 2021 12:19:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:35282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mL6MD-0006lo-5o for submit@debbugs.gnu.org; Tue, 31 Aug 2021 12:11:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL6MB-0006oE-Pj for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2021 12:11:29 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL6M9-0000ZU-Rr for bug-gnu-emacs@gnu.org; Tue, 31 Aug 2021 12:11:27 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 82EFB5C01CA; Tue, 31 Aug 2021 12:11:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 31 Aug 2021 12:11:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=z1k.dev; h=from :to:subject:date:message-id:mime-version:content-type; s=fm1; bh=68A9QJ/swaQ/DajS2CQm1A8krZg46v2zdlfyDuMK5Lg=; b=HHsbewciILB1 tzRnLs+8bMZXChY6kaAt0qI36tQjgsyaCofQT7MRCmYIIHhT2r43pfJKuyliygjI iXOkH1/PO+v08rV1gP6Nu8hiNy6SAxOxsI8twGn3kL+25sJ3/zfLU771JjSy8SCz z7A+Yj+hsfU2unKFwji/B+C0QJcz4aKLAI0l635srjePgFBpELz8JTHSfbMe6kE9 PC21NPG3qnAEPkf7fmPBjOJx658HHn7vWpDtWdEY62ZvVUrTx5Ve6LpRVuFsF4Zg gFT0MDuNKwuJljYbnVESAasHIYRBn4c5c6RjfBX3I5i+DQ30RIM4GARufDdtJnLn AqmdmuTGZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=68A9QJ/swaQ/DajS2CQm1A8krZg46 v2zdlfyDuMK5Lg=; b=AYdLLITyi5gWhEf+UHJ0qLJL1KJiO1ufKbkZMFTvZgs8f qy/d1ga+d8/HMElYYFfaqozEjl9Ce+ITlBeWoK3HDooI488cevMuZlCCPw+7Sy0Z unITuBZKewQ6gPL01oEFXpsryh+vzIid0fHAsDAS7w9XudO4afUxdrKfAHNXbAPn y8uGo7KxUGbtw73dCoj5N94biHFs4j2lDKKAZr9M5C5j55luv7B43PHFBS/J4qEV vVIOXBO1Nc6J3pLavYAQaEKKp+59z6mPIxj+Er5boHbh6auk5oE4uu2zyGUtMQ4x WmxJ/LNt1/ZLBr6Of8ONX5XNjpNsfXIgT+/dmNBiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvuddgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehmtderredttd dtnecuhfhrohhmpeihihhkrghiseiiudhkrdguvghvnecuggftrfgrthhtvghrnhepffeg geelffduieeghfdtudeiveeuudektdetkeevhffhtdduveekfeduffdtheefnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhephihikhgrihesiidu khdruggvvh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 31 Aug 2021 12:11:21 -0400 (EDT) From: yikai@z1k.dev To: bug-gnu-emacs@gnu.org Subject: [PATCH] memory-report: support calculating size for structures Date: Wed, 01 Sep 2021 00:11:18 +0800 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=66.111.4.26; envelope-from=yikai@z1k.dev; helo=out2-smtp.messagingengine.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_FMBLA_NEWDOM28=0.799, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 31 Aug 2021 12:19:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) --=-=-= Content-Type: text/plain Tags: patch Tags: patch (already sent to emacs-devel mailing list, re-submit using submit-emacs-patch) Here's another patch on memory-report package which fixes the object size calculation for structures (cl-defstruct types). Before this patch, memory-report--object-size will report empty size for structure objects, which results in incorrect report about "Largest Variables" in memory-report result. In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.17.4) of 2021-08-20 built on lilydjwg Repository revision: 657fe8b9d87dd17d9b50dd8e15bfd917c6c630b2 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Arch Linux Configured using: 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-sound=alsa --with-modules --without-gconf --without-gsettings --enable-link-time-optimization --with-native-compilation --with-x-toolkit=gtk3 --without-xaw3d --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -flto -fuse-linker-plugin' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-memory-report-support-calculating-size-for-structure.patch >From 6a851e089d0bd9ef61d9209c5d3eb3932c7a7a6c Mon Sep 17 00:00:00 2001 From: Yikai Zhao Date: Sun, 29 Aug 2021 21:47:12 +0800 Subject: [PATCH] memory-report: support calculating size for structures --- lisp/emacs-lisp/memory-report.el | 16 +++++++++++++++- test/lisp/emacs-lisp/memory-report-tests.el | 8 ++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/memory-report.el b/lisp/emacs-lisp/memory-report.el index aee2a0079c..cfa7010af4 100644 --- a/lisp/emacs-lisp/memory-report.el +++ b/lisp/emacs-lisp/memory-report.el @@ -29,7 +29,8 @@ (require 'seq) (require 'subr-x) -(eval-when-compile (require 'cl-lib)) +(require 'cl-lib) +(require 'cl-macs) (defvar memory-report--type-size (make-hash-table)) @@ -243,6 +244,19 @@ memory-report--object-size-1 value) total)) +;; for all cl-defstruct types +(cl-defmethod memory-report--object-size-1 (counted (value cl-structure-object)) + (let ((struct-type (type-of value))) + (apply '+ + (memory-report--size 'vector) + (mapcar (lambda (slot) + (if (eq (car slot) 'cl-tag-slot) + 0 + (memory-report--object-size + counted + (cl-struct-slot-value struct-type (car slot) value)))) + (cl-struct-slot-info struct-type))))) + (defun memory-report--format (bytes) (setq bytes (/ bytes 1024.0)) (let ((units '("KiB" "MiB" "GiB" "TiB"))) diff --git a/test/lisp/emacs-lisp/memory-report-tests.el b/test/lisp/emacs-lisp/memory-report-tests.el index 0c0297b5fc..e352dd165f 100644 --- a/test/lisp/emacs-lisp/memory-report-tests.el +++ b/test/lisp/emacs-lisp/memory-report-tests.el @@ -68,6 +68,14 @@ memory-report-sizes-vectors (vector string string)) 124)))) +(ert-deftest memory-report-sizes-structs () + (cl-defstruct memory-report-test-struct + (item0 nil) + (item1 nil)) + (let ((s (make-memory-report-test-struct :item0 "hello" :item1 "world"))) + (should (= (memory-report-object-size s) + 90)))) + (provide 'memory-report-tests) ;;; memory-report-tests.el ends here -- 2.33.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 01 04:17:02 2021 Received: (at control) by debbugs.gnu.org; 1 Sep 2021 08:17:02 +0000 Received: from localhost ([127.0.0.1]:36201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLLQc-0001mg-Ek for submit@debbugs.gnu.org; Wed, 01 Sep 2021 04:17:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLLQa-0001hF-Q2 for control@debbugs.gnu.org; Wed, 01 Sep 2021 04:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nRXbELdb/HiGIpx8QGs9n0zPDzp9xFiLpY93i8pZqR4=; b=o4wNEZ6nKj7/smnoR2EbIP04+/ x4NyC5qh/ZGz/YeGImlntWNRPcCKDh0MrKhVMkN9liZdiJ7yN+e9ERfiVrbZP/G0W0mgjei0/Eafe eEYBUXKDdtHb4HEmtur1AkxiH/syqjdhsY2E2pxUtal0NvH5+91WCaYZKGHd5KIyNB9M=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLLQT-0001JD-4G for control@debbugs.gnu.org; Wed, 01 Sep 2021 10:16:55 +0200 Date: Wed, 01 Sep 2021 10:16:52 +0200 Message-Id: <877dg0hfrf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50301 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 50301 + pending quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 50301 + pending quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 02 03:37:39 2021 Received: (at 50301) by debbugs.gnu.org; 2 Sep 2021 07:37:40 +0000 Received: from localhost ([127.0.0.1]:39559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhI3-0005pC-Om for submit@debbugs.gnu.org; Thu, 02 Sep 2021 03:37:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhI2-0005oy-8s for 50301@debbugs.gnu.org; Thu, 02 Sep 2021 03:37:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IxBwNdllBC0Q3n1EnyZZuO6hCc65vWUIFLrpFgwtEVA=; b=QgT7sRS/2KLWY1RtgxvfpaQQW2 17VfQDQEK531VaYwWI39OUUr+UZfoLWDiF5h471bXw9OkcimkvH6tw4Zc4oRctU+SXBe0b18vIwTN 4Grj8+cmFcp1vt/GXlyOgBNJ+fSXY6HzCWMZY2ynYTSYqO3oEj5KWvrwSFmQDXG9omvM=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLhHr-0004FG-7Z; Thu, 02 Sep 2021 09:37:31 +0200 From: Lars Ingebrigtsen To: yikai@z1k.dev Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: Date: Thu, 02 Sep 2021 09:37:26 +0200 In-Reply-To: (yikai@z1k.dev's message of "Wed, 01 Sep 2021 00:11:18 +0800") Message-ID: <87pmtrbf7t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: yikai@z1k.dev writes: > Here's another patch on memory-report package which fixes the object > size calculation for structures (cl-defstruct types). Before this patch, > memory-report--object-size will report empty size fo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) yikai@z1k.dev writes: > Here's another patch on memory-report package which fixes the object > size calculation for structures (cl-defstruct types). Before this patch, > memory-report--object-size will report empty size for structure objects, > which results in incorrect report about "Largest Variables" in > memory-report result. Thanks; applied to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 02 03:37:43 2021 Received: (at control) by debbugs.gnu.org; 2 Sep 2021 07:37:43 +0000 Received: from localhost ([127.0.0.1]:39562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhI6-0005pS-VM for submit@debbugs.gnu.org; Thu, 02 Sep 2021 03:37:43 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLhI5-0005p3-L9 for control@debbugs.gnu.org; Thu, 02 Sep 2021 03:37:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KYYCxYoouRNknZRsTXSOt91oZkfKkRXeVmoUxsGw7qo=; b=bKLJ0x47Tu1nHvxRXQzNZcMgYl xBF/6DsKU4Gc38qIRmATNG5SMHZgXD8Aeh9Qw17xqXhQJyCnIYB/LyoMhPkf02Egz/yRkgUOOuQZZ JvuZ3kMPRTMxDVa3dy7v6jSupIZ+m56mhAl9A3MWR592NNP2SwcSHDJC9jq+GUfWbzFI=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLhHx-0004I0-PL for control@debbugs.gnu.org; Thu, 02 Sep 2021 09:37:35 +0200 Date: Thu, 02 Sep 2021 09:37:33 +0200 Message-Id: <87o89bbf7m.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50301 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 50301 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 50301 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 02 19:49:11 2021 Received: (at 50301) by debbugs.gnu.org; 2 Sep 2021 23:49:11 +0000 Received: from localhost ([127.0.0.1]:42347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLwSF-0005Ty-GD for submit@debbugs.gnu.org; Thu, 02 Sep 2021 19:49:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLwSD-0005Tk-Mc for 50301@debbugs.gnu.org; Thu, 02 Sep 2021 19:49:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54972) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLwS7-0003fh-OE; Thu, 02 Sep 2021 19:49:03 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mLwS4-0000XZ-MT; Thu, 02 Sep 2021 19:49:00 -0400 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> X-Spook: Recruitment SGC Daisy BCCI ARC SAP ETA FARC X-Ran: =Z6VGJo^A\F/4Xq6dC1BqgJ/nee_@"Yd^pHl`%x1YYG$'}i1 (Lars Ingebrigtsen's message of "Thu, 02 Sep 2021 09:37:26 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, yikai@z1k.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) make lisp/emacs-lisp/memory-report-tests TEST_LOAD_EL=no fails with: void-function cl-struct-slot-info From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 03 01:47:52 2021 Received: (at 50301) by debbugs.gnu.org; 3 Sep 2021 05:47:52 +0000 Received: from localhost ([127.0.0.1]:42564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM23M-0005nl-IS for submit@debbugs.gnu.org; Fri, 03 Sep 2021 01:47:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM23K-0005nX-5a for 50301@debbugs.gnu.org; Fri, 03 Sep 2021 01:47:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AEqZMGjNYYcAOG8bvNT04W7z2iXiY/9+/DZvfAzTtv8=; b=MZdMNX8xtRCUIDE1EtIPC3dVPD ZIVmU8HuIs8AihAysDeaJSUjy0ahD/X/kjDJXPzEAwyWLL54Cr9ic9dmY0a/uPGCFJmuexm44BaLG 4B1q8ebxxFsZPD/QJzybOIcU6PC3Px+0gNgOYs8FW7AntoiTJcIN+lpfkft89n+v50YI=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM23A-0000CS-D8; Fri, 03 Sep 2021 07:47:42 +0200 From: Lars Ingebrigtsen To: Glenn Morris Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> Date: Fri, 03 Sep 2021 07:47:37 +0200 In-Reply-To: (Glenn Morris's message of "Thu, 02 Sep 2021 19:49:00 -0400") Message-ID: <87ilzi5hxi.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Glenn Morris writes: > make lisp/emacs-lisp/memory-report-tests TEST_LOAD_EL=no > > fails with: void-function cl-struct-slot-info Yup; now fixed. (I didn't notice, because it didn't fail with just "cd test; make".) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, yikai@z1k.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Glenn Morris writes: > make lisp/emacs-lisp/memory-report-tests TEST_LOAD_EL=no > > fails with: void-function cl-struct-slot-info Yup; now fixed. (I didn't notice, because it didn't fail with just "cd test; make".) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 04 12:38:45 2021 Received: (at 50301) by debbugs.gnu.org; 4 Sep 2021 16:38:45 +0000 Received: from localhost ([127.0.0.1]:48475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMYgn-0001By-KE for submit@debbugs.gnu.org; Sat, 04 Sep 2021 12:38:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMYgm-0001Bm-4O for 50301@debbugs.gnu.org; Sat, 04 Sep 2021 12:38:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37610) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMYgg-0001te-MC; Sat, 04 Sep 2021 12:38:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1mMYgf-0007OY-I0; Sat, 04 Sep 2021 12:38:37 -0400 From: Glenn Morris To: Lars Ingebrigtsen Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> X-Spook: USACIL SRI NSG secure shell FXR Jiang Zemin Keylogger X-Ran: 5.6A8}0UGJvNF977"ek`~77O6SkDi1ojdrG3$|-iK-}kc+xKQR,sO#a\gl|lq<|W56yW-, X-Hue: brightgreen X-Attribution: GM Date: Sat, 04 Sep 2021 12:38:37 -0400 In-Reply-To: (Glenn Morris's message of "Thu, 02 Sep 2021 19:49:00 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, yikai@z1k.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > make lisp/emacs-lisp/memory-report-tests TEST_LOAD_EL=no > > fails with: void-function cl-struct-slot-info And so does emacs -Q -f memory-report As cl-struct-slot-info is a non-autoloaded function in cl-macs (an internal cl-lib component), I don't see how it is supposed to be used by external packages. Yet it is documented in the cl-lib manual, and used in eg tramp... From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 04:06:24 2021 Received: (at 50301) by debbugs.gnu.org; 5 Sep 2021 08:06:24 +0000 Received: from localhost ([127.0.0.1]:49104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMnAV-0007D4-RQ for submit@debbugs.gnu.org; Sun, 05 Sep 2021 04:06:23 -0400 Received: from mout.gmx.net ([212.227.15.19]:51079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMnAU-0007Cq-C5 for 50301@debbugs.gnu.org; Sun, 05 Sep 2021 04:06:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630829173; bh=8bk6g5Fu1U3WmFyRfVDnZv+4kwUceOp1KQYFvvU32Mo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=DeaLbGxsXgc297goiCCtmgP4wEsf4klnq4q234jyhGlVw6IQsQUaAt8JhoKyBruyG tDjsvTJPtPS7CdxcJxt62lCv4ugLSvkD40gOY1roeUmSBjDrJmW/fO/gtS3mhOR6o5 3oT+tWTPSt11atqhKOq9M/tTF+Z/UZih2RnNoWn4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.157.141]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M42jK-1mMnAK424W-00013F; Sun, 05 Sep 2021 10:06:13 +0200 From: Michael Albinus To: Glenn Morris Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> Date: Sun, 05 Sep 2021 10:06:11 +0200 In-Reply-To: (Glenn Morris's message of "Sat, 04 Sep 2021 12:38:37 -0400") Message-ID: <87tuiz4fbg.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TgSjz70kO3FCo25+n3nkDi/M97iJLDc6yQsxdD2PHSnx9KzyoCB 4hAeGTNwg0PsLwmsxxyV6czlS6NxU4kTVdMezjR8OQFBjv/SaNWUdMOv0ZvySuMKR4tcbHi t3DdKwODjXyKYwOr1dY9kckN/3dQlvwYiJ+3RHLGCz6nSoVJPnMCWVWF/sF3UMBAqUPnOKl YIbk7Q+FTjinV24WZhFCg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:AkJg3a3MLJk=:+DizU0ZyvUO2FfPTjJ/cvu LvwiLvvNycnsct+T2Wj1tQGZolMjs+exCMNNnpEQAEPhy7Z9YhoG6ACHxJ7P+l63T0MZjV9zl gZPs6ftVXxrMqmtdY1/gh/kGrs+HZ5QOmTiWECaQJChaBOJ9sQ13jclGLGL5H0qQc/i0Xt2w5 m616sNFFxYXx+ZDLcumadK4WHa0xB6ebKkl/YNV3YHVOTNLRZT8+TMIVnl7mOxbI/t8xP/PRl 2ya66w4TKAndywemuHCjxmr+ppk3kDXfHh86EKC7O1MX6fQVgWmMCjgdA59G9MLpVzZY+TZmA fc8dengTrhC//srUE8xPFQh3NDJLnA74hj4Xj3XvYG6rtm8G/hzOPh3rU+BxeR2GLwVZ8Q1UV otOvEfIQ4bDRyg0n9l1ZHzW5zM6sLAIA6dyGlAzA0DsNqJX0jD61hKMpxrJfii+86iiOpnAXk fP4UFRZtsuUu1ni1bRa9Hl9GE+QEn9tO2eAS8j5PKbMJoCvZ3CLinEWCc3mir4XAZhq0TzvPY ngiHjZ8ME4uS0sYEp7Mcn4BiWZ0Ycl4gBIE33ZcJBTtskr+arllLsHqHHngYn+AbszlAZCJVv kgbeYCcCwWUMHd+GdLPxKaG3isr7N3JQm2fkQP4jJdfagH/JRUm7Tb3F4Qs4c2577X83IEkxi d/f+rQkPYdqIEsfX2KQnuwxZMFaRRfiaw3ToFk9Tzj3tuh7q8Ne39SNKCeI3B3s/Px55sozFw jPcnH66kq8ZOHWBUETI5DWmSovTBjtNSvPunHoxEFjLCWPnY1saDGDKkh1nQ2UZMjBSgaKReM FIHGea/pIhx4A6xcx39unNhPNCxSsy0isq22MLbDQHcRg/DQxgQIqhPkSBQ8Ej0wdEzON8JJz 8BwxQM1Wnmxj41//MbXsIfmcibfFhMqcFguNtcQHSXp45+V7mK8YxnZiQLLkBDBHdnxjiVSBR bwLdLe6rGGgimMHksWbv4t7Zw32j5Qv6Sd27s7l9anS5f5+ONE+S7pdOThvTOMG7LrLSbpX2c lFxyLZgokN4lAh0qOLeCIQnlJs33v4rWjetGYFQEp/L8k28jJqR25aDOMlVcbGKrM88vTjWOT /R9XTaEsdO8GqabOU1lgm7fL4cWZpxaBwbxjcSZbhRXaDlplLePjvu6EQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, Lars Ingebrigtsen , yikai@z1k.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Glenn Morris writes: Hi Glenn, > As cl-struct-slot-info is a non-autoloaded function in cl-macs > (an internal cl-lib component), I don't see how it is supposed to be > used by external packages. Yet it is documented in the cl-lib manual, > and used in eg tramp... So we shall autoload it? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 04:42:11 2021 Received: (at 50301) by debbugs.gnu.org; 5 Sep 2021 08:42:11 +0000 Received: from localhost ([127.0.0.1]:49156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMnj9-0001zN-Hd for submit@debbugs.gnu.org; Sun, 05 Sep 2021 04:42:11 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMnj7-0001z2-93 for 50301@debbugs.gnu.org; Sun, 05 Sep 2021 04:42:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T/d2dqbggqmSTm53GR/ct74rOWTD5TErar4a7owvYHI=; b=ObN9wm5RRbB25HsNTEZ9EIzZBA NJBXGR8u5zkvvNhyD4vkuY4lEnXwdunj74BK/QzFslTsG0upWB8f3KyQGwWasDJdW4Yo3pUwpD4jk rRiYxNzazhqEcgRv3iGD+M7og2pqhmotGMLMoPkjSyXBD/h+PiiGQyk8D7lIu98i30K4=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMniu-0003ZZ-R1; Sun, 05 Sep 2021 10:41:59 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> <87tuiz4fbg.fsf@gmx.de> Date: Sun, 05 Sep 2021 10:41:56 +0200 In-Reply-To: <87tuiz4fbg.fsf@gmx.de> (Michael Albinus's message of "Sun, 05 Sep 2021 10:06:11 +0200") Message-ID: <87mtoro1m3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: >> As cl-struct-slot-info is a non-autoloaded function in cl-macs >> (an internal cl-lib component), I don't see how it is supposed to be >> used by external packages. Yet it is documented in the cl-l [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, Glenn Morris , yikai@z1k.dev, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: >> As cl-struct-slot-info is a non-autoloaded function in cl-macs >> (an internal cl-lib component), I don't see how it is supposed to be >> used by external packages. Yet it is documented in the cl-lib manual, >> and used in eg tramp... > > So we shall autoload it? Well, that seems like the obvious fix here... and there's plenty of other autoloaded functions in cl-macs. But I've added Stefan to the CCs; perhaps he has comments here. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 10:43:56 2021 Received: (at 50301) by debbugs.gnu.org; 5 Sep 2021 14:43:56 +0000 Received: from localhost ([127.0.0.1]:50770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMtNE-0003Dj-8k for submit@debbugs.gnu.org; Sun, 05 Sep 2021 10:43:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMtNC-0003DV-GC for 50301@debbugs.gnu.org; Sun, 05 Sep 2021 10:43:55 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 75D7F100136; Sun, 5 Sep 2021 10:43:51 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 445E41000C4; Sun, 5 Sep 2021 10:43:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1630853030; bh=Bcs6CuTjWBccRnidnJcPXsqzeLpRbgJZUDK8jod9SSk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Vuo5j3f53jbzWC/Scbls433kNbCGDzE4Pf7UZ7KNU7mkb75HQUcS6cQkBXBBlZsML xPZjkztE00MD01BCO8TBsJ7WUo03h3Pj4fOm6SMFqcWwPmOeMFTA1XptvkXFm3cKXu niHgROt4e9NxPK1C585OmLYlZV9rTuwU3NldJzT6ZHwsH2XRptNtEAB6Jil6jxrwVr d9BJiqzMmD6DnIY/fhQ29v2bVx593Lj9wAQnK7r009ghxWFwaLft1WONLhaXKYy5e9 DkOagyNtxunxjIgUv1XFm7uetUWlKQMKMFiXA6/OD0TxHnLmkkibdssMYnJCNycYZ4 qgKjuSjQl2jGg== Received: from milanesa (unknown [104.247.244.135]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 77D7B12041A; Sun, 5 Sep 2021 10:43:47 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures Message-ID: References: <87pmtrbf7t.fsf@gnus.org> <87tuiz4fbg.fsf@gmx.de> <87mtoro1m3.fsf@gnus.org> Date: Sun, 05 Sep 2021 10:43:46 -0400 In-Reply-To: <87mtoro1m3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 05 Sep 2021 10:41:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, Glenn Morris , yikai@z1k.dev, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-09-05 10:41:56] wrote: > Michael Albinus writes: >>> As cl-struct-slot-info is a non-autoloaded function in cl-macs >>> (an internal cl-lib component), I don't see how it is supposed to be >>> used by external packages. Yet it is documented in the cl-lib manual, >>> and used in eg tramp... >> >> So we shall autoload it? > > Well, that seems like the obvious fix here... and there's plenty of > other autoloaded functions in cl-macs. But I've added Stefan to the > CCs; perhaps he has comments here. Autoload sounds like the correct fix. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 05 10:52:51 2021 Received: (at 50301) by debbugs.gnu.org; 5 Sep 2021 14:52:51 +0000 Received: from localhost ([127.0.0.1]:50788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMtVr-0003R7-Es for submit@debbugs.gnu.org; Sun, 05 Sep 2021 10:52:51 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMtVm-0003Qr-9H for 50301@debbugs.gnu.org; Sun, 05 Sep 2021 10:52:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QrNAYvbgC5swhO06y3iZF0qpI0v6Mh3J87dTkiYPk1c=; b=T5MgH1Zr5wKBkg1MC6SbKFOwwK i+MoSk6EIKNl9QwTJFmsp0t7oe1/qrsSFjRH4wKie71+4YgIdinDX338btLNvzScBpB9aRUmyG5o8 38CVgITyGP0yMibhkVHF+vyUtYPJwAapmYDxqgcPdKSGec1HB+rLfgKb6d84Rl6D8EHc=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMtVa-00074A-Vx; Sun, 05 Sep 2021 16:52:37 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#50301: [PATCH] memory-report: support calculating size for structures References: <87pmtrbf7t.fsf@gnus.org> <87tuiz4fbg.fsf@gmx.de> <87mtoro1m3.fsf@gnus.org> Date: Sun, 05 Sep 2021 16:52:34 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 05 Sep 2021 10:43:46 -0400") Message-ID: <87y28bkrbh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Autoload sounds like the correct fix. OK; now done (and removed that offending (require 'cl-macs).) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50301 Cc: 50301@debbugs.gnu.org, Glenn Morris , yikai@z1k.dev, Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > Autoload sounds like the correct fix. OK; now done (and removed that offending (require 'cl-macs).) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 13:39:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Oct 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator