GNU bug report logs - #50299
The check-tests-true lint check is incorrect for Emacs packages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#50299: closed (The check-tests-true lint check is incorrect
 for Emacs packages)
Date: Sat, 12 Mar 2022 04:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 11 Mar 2022 23:43:38 -0500
with message-id <87k0czsrut.fsf_-_ <at> gmail.com>
and subject line Re: bug#50299: The check-tests-true lint check is incorrect for Emacs packages
has caused the debbugs.gnu.org bug report #50299,
regarding The check-tests-true lint check is incorrect for Emacs packages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
50299: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50299
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Cc: Maxime Devos <maximedevos <at> telenet.be>
Subject: The check-tests-true lint check is incorrect for Emacs packages
Date: Tue, 31 Aug 2021 11:25:35 -0400

Hi,

The emacs-build-system has its #:tests? argument set to #f by default,
which means users must explicitly specify its value as #t to enable test
suites.

The check-tests-true lint check seems to ignore this and goes on to
recommend, for example:

--8<---------------cut here---------------start------------->8---
gnu/packages/emacs-xyz.scm:15998:7: emacs-groovy-modes <at> 2.0-0.99eaf70: #:tests? must not be explicitly set to #t
--8<---------------cut here---------------end--------------->8---

which is wrong.

Thanks,

Maxim

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 50299-done <at> debbugs.gnu.org
Subject: Re: bug#50299: The check-tests-true lint check is incorrect for
 Emacs packages
Date: Fri, 11 Mar 2022 23:43:38 -0500

Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> writes:

> This is the v4 patch, rebased.  No other changes.

I've tried to getting rid of as many lint warnings I could on each
package touched, got rid of the python2* packages touched, and squashed
many same-package/scope changes together.

Note that the latest available version of swi-prolog builds and test
fine, but fails to be cross-compiled, so I've left it as is; you may
want to investigate the upgrade.

Thank you,

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.