GNU bug report logs - #50299
The check-tests-true lint check is incorrect for Emacs packages

Previous Next

Full log

Message #185 received at 50299 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 50299 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: bug#50299: [PATCH v3 15/27] gnu: ecl: Don't pretend to enable
 tests when cross-compiling.
Date: Mon, 11 Oct 2021 14:13:19 +0200

Hi Maxime,

I was roaming on this series and the message:

    Don't pretend to enable tests when cross-compiling.

or elsewhere

    Don't run tests when cross-compiling.

appears to me misleading.  I would write:

    Remove unconditional tests.

or something along these lines which is what these commits are doing, IIUC.

On Thu, 30 Sept 2021 at 00:50, Maxime Devos <maximedevos <at> telenet.be> wrote:

> * gnu/packages/lisp.scm
>   (ecl)[arguments]<#:tests?>: Move comment about failing tests to ...
>   (ecl)[arguments]<#:phases>{check}: ... this deleted phase.
>   (ecl)[arguments]: Remove #:tests? instead of unconditionally setting it to
>   #t.

Thanks for working on that.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.