GNU bug report logs - #50296
[PATCH 0/2] Add 'guix home' command.

Previous Next

Full log

Message #40 received at 50296-done <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>
Cc: 50296-done <at> debbugs.gnu.org
Subject: Re: [bug#50296] [PATCH 0/2] Add 'guix home' command.
Date: Tue, 31 Aug 2021 17:23:39 +0300

[Message part 1 (text/plain, inline)]

Andrew Tropin <andrew <at> trop.in> writes:

[…]

> The functions from home-services-utils used by xdg now in home-services
> utils:
>
> From efd3ea79905c12e2c1c594fa6b54cf62d741f92f Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Tue, 31 Aug 2021 15:40:07 +0300
> Subject: [PATCH 2/2] home-services: configuration: Add
>  generic-serialize-alist.
>
> * gnu/home-services/configuration.scm (generic-serialize-alist)
> (generic-serialize-alist-entry): New variables.

As you said, no variables, but functions ;-)

Also, we could join those functions in Git commit message with comma.

Applied with changes above.

[…]

>> run-on-change service doesn't handle the case, where the previous
>> generation doesn't exists.  Fix should be pretty simple, will send a
>> patch once it done.  Thank you for catching this)
>>
>
> The fix:
>
> From a07541380d412b33c504e5811776062af4e38582 Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew <at> trop.in>
> Date: Tue, 31 Aug 2021 15:24:25 +0300
> Subject: [PATCH 1/2] home-services: run-on-change: Handle first generation
>  case.
>
> ---
>  gnu/home-services.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

[…]

Added Git changelog-like line.

Applied.

Pushed to wip-guix-home as 0c7bb26435513a61814d98af1c790e43a74afb6e.

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.