GNU bug report logs - #50296
[PATCH 0/2] Add 'guix home' command.

Previous Next

Package: guix-patches;

Reported by: Andrew Tropin <andrew <at> trop.in>

Date: Tue, 31 Aug 2021 09:31:01 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: zimoun <zimon.toutoune <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>, 50296 <at> debbugs.gnu.org
Subject: [bug#50296] [PATCH 1/2] scripts: Add 'guix home'.
Date: Tue, 31 Aug 2021 12:53:51 +0200
Hi,

On Tue, 31 Aug 2021 at 12:40, Andrew Tropin <andrew <at> trop.in> wrote:

> +(define-command (guix-home . args)
> +  (synopsis "build and deploy home environments")
> +
> +  (define (parse-sub-command arg result)
> +    ;; Parse sub-command ARG and augment RESULT accordingly.
> +    (if (assoc-ref result 'action)
> +        (alist-cons 'argument arg result)
> +        (let ((action (string->symbol arg)))
> +          (case action
> +            ((build
> +              reconfigure
> +              extension-graph shepherd-graph
> +              list-generations describe
> +              delete-generations roll-back
> +              switch-generation search
> +              import)
> +             (alist-cons 'action action result))
> +            (else (leave (G_ "~a: unknown action~%") action))))))

For parsing the actions, I would define elsewhere the list.  Then if the
action is unknown, you could use ’string-closest’ and so return an hint
if there is a typo.

Other said, this

  guix home recnfigure

would return

  guix home: error: recnfigure: unknown action
  hint: Did you mean `reconfigure'?

WDYT?

Cheers,
simon




This bug report was last modified 3 years and 339 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.