From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 13:39:57 2021 Received: (at submit) by debbugs.gnu.org; 30 Aug 2021 17:39:57 +0000 Received: from localhost ([127.0.0.1]:60186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKlGH-0003fQ-BR for submit@debbugs.gnu.org; Mon, 30 Aug 2021 13:39:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:33258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKlGD-0003fG-Dv for submit@debbugs.gnu.org; Mon, 30 Aug 2021 13:39:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33196) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKlGB-0005T3-HZ for guix-patches@gnu.org; Mon, 30 Aug 2021 13:39:53 -0400 Received: from michel.telenet-ops.be ([2a02:1800:110:4::f00:18]:46444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKlG9-00016k-56 for guix-patches@gnu.org; Mon, 30 Aug 2021 13:39:51 -0400 Received: from localhost.localdomain ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id ntfk2500E0mfAB406tfkVj; Mon, 30 Aug 2021 19:39:44 +0200 From: Maxime Devos To: guix-patches@gnu.org Subject: [RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx. Date: Mon, 30 Aug 2021 19:39:35 +0200 Message-Id: <20210830173935.31933-1-maximedevos@telenet.be> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1630345184; bh=ypW+PBTrXLxHc2QVpGrKKT3zPvjmRviGpXB8wHWzepE=; h=From:To:Cc:Subject:Date; b=nG7iqF4yXfNRSK0S2fTW8Uopt+H7nUQcpuWil2b2ongMZiYiB2ozh6SBxIVoq0k1L DQEuC5JVfJJFRyFUSoJlEILfNDnOq0LV8ywYMwzeQ2ACIv89gvKR3EOLsqsO5DpmQ5 DhDb0GcfHzxE7pYxSxASPpSM36gewK/OFHK2W/MvodVMeOdefkd+jig0dyjd5hV1zu LfIqAfwUzQ7UlH52FJucXDucykZxLSx/9xxuc9bQHSH40oWMk3LI6kzvzDwT5FE6tE V9D7SBIhxVhbCINn+zumqRcTtKsB1Uo5JTiS8oUH5GHU+rGyVD43QaxhLMA7aQ4y+v y197g5oDvF0vA== Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit Cc: Maxime Devos , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This broke compilation of Guix with guile@3.0.2 with: In procedure make-regexp: Invalid range end The fix is to replace [0-9A-f] with [0-9A-Fa-f]. TODO: were both uppercase and lowercase intended, or only one of the two? * gnu/build/jami-service.scm (account-fingerprint-rx): Correct regexp. --- gnu/build/jami-service.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm index d44e87387d..ddfc8cf937 100644 --- a/gnu/build/jami-service.scm +++ b/gnu/build/jami-service.scm @@ -96,7 +96,7 @@ before each retry." (list key value))) alist)) -(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}")) +(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}")) (define (account-fingerprint? val) "A Jami account fingerprint is 40 characters long and only contains -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 14:26:20 2021 Received: (at 50281-done) by debbugs.gnu.org; 30 Aug 2021 18:26:20 +0000 Received: from localhost ([127.0.0.1]:60216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKlzA-0004yo-Ko for submit@debbugs.gnu.org; Mon, 30 Aug 2021 14:26:20 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:46782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKlz8-0004yW-Pl for 50281-done@debbugs.gnu.org; Mon, 30 Aug 2021 14:26:19 -0400 Received: by mail-qt1-f173.google.com with SMTP id x5so12469784qtq.13 for <50281-done@debbugs.gnu.org>; Mon, 30 Aug 2021 11:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=yCVTchmswnzeN7olYzYrnFnES9kmgG71UVeLO9KoTgE=; b=gm5M7cI5KGz+P0MtjJ8yuX/6xwph2fqAYhZkcJMPiv5RXhN+Z0umbReyQBPE8+nzTb hmwYru3nppG/OIZW/ed9fNO7DaBXaHAvPskYlNH0TOgz973kp/YUw9dEJIZF2Y1xTpoO RKyLvZWg9wK7SgjVzlcFCYvxza+fMg76MPjG4m17qbebi01wRA1BXKWw75Mku0/RqA1X ADaCwKKo1Myme9/pqR+w35wa990klQvAsuOMYm/Gda7Y6MkrDU5OaAfujp2bopcrYjrU PgYqQdoug/38w6N4G/TySr0WbDlyTxC4ypIIFRH2rYB0CgE9FOWreTwTbiTQUrRh5Osx ILvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=yCVTchmswnzeN7olYzYrnFnES9kmgG71UVeLO9KoTgE=; b=FXgerXFwo0jbrTkzJH/j2T30dckMvAA2G409g5QCMtZLV02TKbuUY0J0hc81d0fR0b 54uPO+LaBv+L3+pmNunlTUl6eNWN23t/Jd3JERCmPVERTLGPjVuVtRhfc4xCNOrVPEBp hyJ6K/EFJ+3HCbldmsCrP6HYR+OOfFsLAG5CFXjYh3pInGvlHD95VLl6cXSkf/g49PDu zgREpsqbnKLQto0JirHfDZYqK/DIOLRV1anh7Z88yk4nfIRD8+4oKsYaFfk6uWrKvVtu gDoorg+f/Z6CMA+Bw15oY8sPPnXgEGHbOUhucNxSKsTN7hsmalvJu2/CR+hQTmOd6wnp 57UA== X-Gm-Message-State: AOAM532vZF2p/EbYDn55oIc8oeP+B+GzMRnRQUV/zaY1FO6LhIC7WrpM qPNs2XpyYiSUk/19tSBN/E7+fFDcjH4= X-Google-Smtp-Source: ABdhPJyMQgoiBudmTFUszSIvk05XZoB4NUzapR9gOTLyiFEyyB4luM6yAe6u/tNI/rYZSSNf2YE6yw== X-Received: by 2002:a05:622a:198e:: with SMTP id u14mr14780068qtc.47.1630347972936; Mon, 30 Aug 2021 11:26:12 -0700 (PDT) Received: from hurd (dsl-10-141-212.b2b2c.ca. [72.10.141.212]) by smtp.gmail.com with ESMTPSA id j3sm11579731qki.104.2021.08.30.11.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 11:26:12 -0700 (PDT) From: Maxim Cournoyer To: Maxime Devos Subject: Re: bug#50281: [RFC PATCH] build/jami-service: Fix range ends in account-fingerprint-rx. References: <20210830173935.31933-1-maximedevos@telenet.be> Date: Mon, 30 Aug 2021 14:26:11 -0400 In-Reply-To: <20210830173935.31933-1-maximedevos@telenet.be> (Maxime Devos's message of "Mon, 30 Aug 2021 19:39:35 +0200") Message-ID: <87k0k2n60s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50281-done Cc: 50281-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxime, Maxime Devos writes: > This broke compilation of Guix with guile@3.0.2 with: > > In procedure make-regexp: Invalid range end Uh, good catch! Makes me curious to know what was changed in 3.0.7! > The fix is to replace [0-9A-f] with [0-9A-Fa-f]. > TODO: were both uppercase and lowercase intended, or > only one of the two? Yes, Jami does not care about the case of the Jami account fingerprint (IIRC). I've now edited out the TODO. > * gnu/build/jami-service.scm > (account-fingerprint-rx): Correct regexp. > --- > gnu/build/jami-service.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gnu/build/jami-service.scm b/gnu/build/jami-service.scm > index d44e87387d..ddfc8cf937 100644 > --- a/gnu/build/jami-service.scm > +++ b/gnu/build/jami-service.scm > @@ -96,7 +96,7 @@ before each retry." > (list key value))) > alist)) > > -(define account-fingerprint-rx (make-regexp "[0-9A-f]{40}")) > +(define account-fingerprint-rx (make-regexp "[0-9A-Fa-f]{40}")) > > (define (account-fingerprint? val) > "A Jami account fingerprint is 40 characters long and only contains And pushed as a3bfe953d2. Thank you! Closing, Maxim From unknown Sun Jun 22 07:53:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Sep 2021 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator