GNU bug report logs - #50274
[PATCH] guix: git: Adds feature to download git repository to the store.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Mon, 30 Aug 2021 16:41:02 UTC

Severity: normal

Tags: patch

Full log


Message #23 received at 50274 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: Julien Lepiller <julien <at> lepiller.eu>, jgart <jgart <at> dismail.de>,
 50274 <at> debbugs.gnu.org
Subject: Re: [bug#50274] [PATCH] guix: git: Adds feature to download git
 repository to the store.
Date: Thu, 02 Sep 2021 18:37:10 -0700
Hi Maxime,

Maxime Devos <maximedevos <at> telenet.be> writes:

> Sarah Morgensen schreef op di 31-08-2021 om 11:50 [-0700]:
>> 
>> Your patch has a number of tabs in it; they should be converted to spaces.
>
> Is this documented somewhere?  I'm not aware of such a rule.

I cannot find it explicitly stated anywhere, but etc/indent-code.el does
replace tabs with spaces:

--8<---------------cut here---------------start------------->8---
     ;; Indent all of FILE-NAME.
     (find-file file-name)
     (let ((indent-tabs-mode nil))
       (untabify (point-min) (point-max))
       (indent-region (point-min) (point-max))
       (save-buffer)
       (message "Done!")))
--8<---------------cut here---------------end--------------->8---

So I assumed it's policy.  Perhaps the documentation should explicitly
note that spaces are Official Policy?

--
Sarah




This bug report was last modified 1 year and 300 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.