GNU bug report logs - #50274
[PATCH] guix: git: Adds feature to download git repository to the store.

Previous Next

Full log

Message #11 received at 50274 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: jgart <jgart <at> dismail.de>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 50274 <at> debbugs.gnu.org
Subject: Re: [bug#50274] [PATCH] guix: git: Adds feature to download git
 repository to the store.
Date: Tue, 31 Aug 2021 12:08:25 -0700

Hi again,

Sarah Morgensen <iskarian <at> mgsn.dev> writes:

>>             (fetch (assq-ref opts 'download-proc))
>> +           (git-fetch (assq-ref opts 'git-download-proc))
>> +	   (commit (assq-ref opts 'commit))
>>             (path  (parameterize ((current-terminal-columns
>>                                    (terminal-columns)))
>> -                    (fetch (uri->string uri)
>> -                           #:verify-certificate?
>> -                           (assq-ref opts 'verify-certificate?))))
>> -           (hash  (call-with-input-file
>> -                      (or path
>> -                          (leave (G_ "~a: download failed~%")
>> -                                 arg))
>> -                    (cute port-hash (assoc-ref opts 'hash-algorithm) <>)))
>> +		    (if commit
>> +		        (git-fetch (uri->string uri) commit)
>
> You don't actually seem to use the download-git-to-store procedure you
> wrote above.  An oversight?

Please disregard this comment.  I read too fast and didn't catch that
git-fetch took the value of 'git-download-proc :)

--
Sarah

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.