From unknown Sat Sep 20 13:01:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50273 <50273@debbugs.gnu.org> To: bug#50273 <50273@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add python-pyxel. Reply-To: bug#50273 <50273@debbugs.gnu.org> Date: Sat, 20 Sep 2025 20:01:00 +0000 retitle 50273 [PATCH] gnu: Add python-pyxel. reassign 50273 guix-patches submitter 50273 Leo Prikler severity 50273 normal tag 50273 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 11:31:08 2021 Received: (at submit) by debbugs.gnu.org; 30 Aug 2021 15:31:08 +0000 Received: from localhost ([127.0.0.1]:60009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKjFb-0008Cw-Qu for submit@debbugs.gnu.org; Mon, 30 Aug 2021 11:31:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:42104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKjFX-0008Ck-KB for submit@debbugs.gnu.org; Mon, 30 Aug 2021 11:31:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjFX-0002Gu-2K for guix-patches@gnu.org; Mon, 30 Aug 2021 11:31:03 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:38431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjFO-0001bY-V9 for guix-patches@gnu.org; Mon, 30 Aug 2021 11:31:02 -0400 Received: from localhost.localdomain (194-118-34-199.adsl.highway.telekom.at [194.118.34.199]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GyvR53CFYz3wHN for ; Mon, 30 Aug 2021 17:30:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1630337441; bh=MmEFEWH4Xw+vkdF7AA8GnbFfr5aeGbcOO8rxMKv918k=; h=From:To:Subject:Date; b=DVoPleZ1hh6QjRYwSUNn3jOciNMhgnHLtzJJzotAX2CNFaJ/MlMQkrs/vFomduK/F XgmSdt53Tru0Dk3aOmj+1IhcVTJ8Ypqvn5Y/UxyGxfPxTrP2py96gOqI+7EjOzl1dX /Ax31+JTbJ1wpABqhp5tG+MDb5isjXqUlNYP2CLo= From: Leo Prikler To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-pyxel. Date: Mon, 30 Aug 2021 17:30:03 +0200 Message-Id: <20210830153003.27134-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/game-development.scm (python-pyxel): New variable. --- gnu/packages/game-development.scm | 55 +++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 2a58848dce..3e21d411cf 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1484,6 +1484,61 @@ visual novels, while its Python scripting is enough for complex simulation games.") (license license:expat))) +(define-public python-pyxel + (package + (name "python-pyxel") + (version "1.4.3") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/kitao/pyxel") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9")) + (modules '((guix build utils))) + (snippet + '(begin + (delete-file-recursively "pyxel/core/bin"))))) + (build-system python-build-system) + (arguments + `(#:tests? #f ; "Tests" are actually example programs that never halt. + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-build-files + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "setup.py" + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch) + (if (string=? arch "linux") + all + ""))) + (let* ((sdl2 (assoc-ref inputs "sdl2"))) + (substitute* "pyxel/core/Makefile" + (("`sdl2-config --cflags`") + (string-append "-I" sdl2 "/include/SDL2 -D_REENTRANT")) + (("`sdl2-config --libs`") + (string-append "-L" sdl2 "/lib " + "-Wl,-rpath," sdl2 "/lib " + "-Wl,--enable-new-dtags -lSDL2")))))) + (add-before 'build 'prebuild + (lambda _ + (invoke "make" "-C" "pyxel/core")))))) + (inputs + `(("gifsicle" ,gifsicle) + ("sdl2" ,(sdl-union (list sdl2 sdl2-image))))) + (native-inputs + `(("gcc" ,gcc-10))) ; for std::filesystem + (home-page "https://github.com/kitao/pyxel") + (synopsis "Retro game engine for Python") + (description "Pyxel is a game engine inspired by retro gaming consoles. +It has a fixed 16-color palette, can hold up to 3 image banks and 8 tilemaps +(256x256 pixels each) and 4 sound channels with 64 definable sounds. It +also comes with a built-in image and sound editor.") + (license license:expat))) + (define-public grafx2 (package (name "grafx2") -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 14:40:43 2021 Received: (at 50273) by debbugs.gnu.org; 30 Aug 2021 18:40:43 +0000 Received: from localhost ([127.0.0.1]:60251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKmD5-0005Qp-GQ for submit@debbugs.gnu.org; Mon, 30 Aug 2021 14:40:43 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:43848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKmD3-0005QY-O6 for 50273@debbugs.gnu.org; Mon, 30 Aug 2021 14:40:42 -0400 Received: by mail-qk1-f169.google.com with SMTP id ay33so16724960qkb.10 for <50273@debbugs.gnu.org>; Mon, 30 Aug 2021 11:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=BL+tad8jVRjzTUeXXt3Jy2jQKjjYuWJ+Fyz6cKvquNc=; b=FGdnaFLBh0INRdoXfKTGvRrnZD/WRr8wjQ22q0i1OEmd1yV7yL8rWqRUtGRlnhJlG1 J+dxpLj38oNDU1aCCvB27xFwL/OHyZTc1DAOCQBjhVQdZh9Y5Urx1MX5WIRxJUW764Ho JN0GnaiLeadE7c/hh6wsRd5rs0H63RRnTpFdrnCXfoa62Z6OFtftmJXXqdFVew67d6rd Ari6xopaUdj1UphmND6GX8NQK5NhDTtBtfdHRepqcTgv3FslPvsazZVW/qvW8p8rgNNK LzrWzD9mgc5SS2idrHWl/flhb3f8amD4nxOhx/Vdad/NMVxOdZ9GlxgIKdhZ1nPAmUhA 0BfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=BL+tad8jVRjzTUeXXt3Jy2jQKjjYuWJ+Fyz6cKvquNc=; b=P29kgqZqlU34IMSpLw9CYa5ZMqxXD2n5zUb6wpQFqfuVFd8ys0WL0qO8KD9YCIGv0J 93UxD0Os6Ke5B9txx3DDBcwONy4qlpkqtdVP1w6YzRtGVYXaGX4aC0/rpiP8Yk/5DVFq pWoxdNryKMsFJDuCmgnduPptC82yjxfRc1IaMpCYVBnf3nqTwzLE9lnHdsQJNOEQ/ypB 4N82zNWktqQR/le0CNPbNQAnMr8QKB49FINuRyAs3Rl9Kn8E3EPw6+SdubFw+bRq2jej 5OdgFAYhTKaWZmsfo7VIu9C51cDsRjpLOAXC+lhEJ4hUn4sroRdRo7xl/jhYTZjWeLzb GEDw== X-Gm-Message-State: AOAM533kUQJ+dQiIocV0RQceoUg9g8nUCQMm1+GFkYFwZiVh2K8s/YaV 3aWZYeaMX6PqRhUemFfCJtRnQWPIO6U= X-Google-Smtp-Source: ABdhPJxfeuPIV76rQlKV5DIHMebgMSG5U4P78eHV73u5eTTfBfcbDbS4MgoskcH8t7x2fUBZ0RbA5A== X-Received: by 2002:a05:620a:2549:: with SMTP id s9mr23560581qko.256.1630348836083; Mon, 30 Aug 2021 11:40:36 -0700 (PDT) Received: from hurd (dsl-10-141-212.b2b2c.ca. [72.10.141.212]) by smtp.gmail.com with ESMTPSA id 62sm9124875qtg.58.2021.08.30.11.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 11:40:35 -0700 (PDT) From: Maxim Cournoyer To: Leo Prikler Subject: Re: bug#50273: [PATCH] gnu: Add python-pyxel. References: <20210830153003.27134-1-leo.prikler@student.tugraz.at> Date: Mon, 30 Aug 2021 14:40:23 -0400 In-Reply-To: <20210830153003.27134-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Mon, 30 Aug 2021 17:30:03 +0200") Message-ID: <878s0in5d4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50273 Cc: 50273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Leo, Leo Prikler writes: > * gnu/packages/game-development.scm (python-pyxel): New variable. > --- > gnu/packages/game-development.scm | 55 +++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm > index 2a58848dce..3e21d411cf 100644 > --- a/gnu/packages/game-development.scm > +++ b/gnu/packages/game-development.scm > @@ -1484,6 +1484,61 @@ visual novels, while its Python scripting is enough for complex simulation > games.") > (license license:expat))) > > +(define-public python-pyxel > + (package > + (name "python-pyxel") > + (version "1.4.3") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/kitao/pyxel") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9")) > + (modules '((guix build utils))) > + (snippet > + '(begin > + (delete-file-recursively "pyxel/core/bin"))))) > + (build-system python-build-system) > + (arguments > + `(#:tests? #f ; "Tests" are actually example programs that never halt. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-build-files > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "setup.py" > + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch) > + (if (string=? arch "linux") > + all > + ""))) > + (let* ((sdl2 (assoc-ref inputs "sdl2"))) > + (substitute* "pyxel/core/Makefile" > + (("`sdl2-config --cflags`") > + (string-append "-I" sdl2 "/include/SDL2 -D_REENTRANT")) > + (("`sdl2-config --libs`") > + (string-append "-L" sdl2 "/lib " > + "-Wl,-rpath," sdl2 "/lib " > + "-Wl,--enable-new-dtags -lSDL2")))))) The above could benefit from some extra commenting to explain the choice of linker options (--enable-new-dtags ?) or C preprocessor variables (-D_REENTRANT). I'd have to dig a bit deeper than I'd like to have an understanding of these. > + (add-before 'build 'prebuild > + (lambda _ > + (invoke "make" "-C" "pyxel/core")))))) > + (inputs > + `(("gifsicle" ,gifsicle) > + ("sdl2" ,(sdl-union (list sdl2 sdl2-image))))) > + (native-inputs > + `(("gcc" ,gcc-10))) ; for std::filesystem > + (home-page "https://github.com/kitao/pyxel") > + (synopsis "Retro game engine for Python") > + (description "Pyxel is a game engine inspired by retro gaming consoles. > +It has a fixed 16-color palette, can hold up to 3 image banks and 8 tilemaps > +(256x256 pixels each) and 4 sound channels with 64 definable sounds. It > +also comes with a built-in image and sound editor.") > + (license license:expat))) > + > (define-public grafx2 > (package > (name "grafx2") The rest LGTM! Feel free to push a revised version in which you explain a little bit the choice of linker/preprocessor options. Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 15:03:16 2021 Received: (at 50273) by debbugs.gnu.org; 30 Aug 2021 19:03:16 +0000 Received: from localhost ([127.0.0.1]:60274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKmYq-00065z-Fd for submit@debbugs.gnu.org; Mon, 30 Aug 2021 15:03:16 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:51594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKmYk-00065l-Rj for 50273@debbugs.gnu.org; Mon, 30 Aug 2021 15:03:11 -0400 Received: from localhost.localdomain (194-118-34-199.adsl.highway.telekom.at [194.118.34.199]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4Gz08304VDz1LB1y; Mon, 30 Aug 2021 21:02:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4Gz08304VDz1LB1y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1630350179; bh=enChCpXso9EHpNIhFJo57mJqaetrRvtpP6Zu98rpskI=; h=From:To:Cc:Subject:Date:From; b=quonGRvkTLoMaRt1XghdBQRaAF7DdB3BESYjMdoafhxM/bwPJfu5USnska/eZ0LCt VTUDX2JVMbfnJNbsdHP5z610H91yV4B/GgWRC6D3paufXnn4Nl4ypZ9lkxM9/vki9F xpijlBXYgDoTGj4cHAa3KJpb8/P9oO2k/H4aXAcw= From: Leo Prikler To: 50273@debbugs.gnu.org Subject: [PATCH v2] gnu: Add python-pyxel. Date: Mon, 30 Aug 2021 21:02:47 +0200 Message-Id: <20210830190246.3454-1-leo.prikler@student.tugraz.at> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50273 Cc: maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/game-development.scm (python-pyxel): New variable. --- Am Montag, den 30.08.2021, 14:40 -0400 schrieb Maxim Cournoyer: > > + (let* ((sdl2 (assoc-ref inputs "sdl2"))) > > + (substitute* "pyxel/core/Makefile" > > + (("`sdl2-config --cflags`") > > + (string-append "-I" sdl2 "/include/SDL2 > > -D_REENTRANT")) > > + (("`sdl2-config --libs`") > > + (string-append "-L" sdl2 "/lib " > > + "-Wl,-rpath," sdl2 "/lib " > > + "-Wl,--enable-new-dtags > > -lSDL2")))))) > > The above could benefit from some extra commenting to explain the > choice of linker options (--enable-new-dtags ?) or C preprocessor variables > (-D_REENTRANT). I'd have to dig a bit deeper than I'd like to have an > understanding of these. These were previously snarfed from a manual invocation of sdl2-config, but iskarian in IRC pointed out, that sdl2-config accepts --prefix, so the patch has been revised to use that. gnu/packages/game-development.scm | 51 +++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 2a58848dce..40807450ea 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1484,6 +1484,57 @@ visual novels, while its Python scripting is enough for complex simulation games.") (license license:expat))) +(define-public python-pyxel + (package + (name "python-pyxel") + (version "1.4.3") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/kitao/pyxel") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9")) + (modules '((guix build utils))) + (snippet + '(begin + (delete-file-recursively "pyxel/core/bin"))))) + (build-system python-build-system) + (arguments + `(#:tests? #f ; "Tests" are actually example programs that never halt. + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-build-files + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "setup.py" + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch) + (if (string=? arch "linux") + all + ""))) + (substitute* "pyxel/core/Makefile" + (("`sdl2-config") + (string-append "`sdl2-config --prefix=" + (assoc-ref inputs "sdl2")))))) + (add-before 'build 'prebuild + (lambda _ + (invoke "make" "-C" "pyxel/core")))))) + (inputs + `(("gifsicle" ,gifsicle) + ("sdl2" ,(sdl-union (list sdl2 sdl2-image))))) + (native-inputs + `(("gcc" ,gcc-10))) ; for std::filesystem + (home-page "https://github.com/kitao/pyxel") + (synopsis "Retro game engine for Python") + (description "Pyxel is a game engine inspired by retro gaming consoles. +It has a fixed 16-color palette, can hold up to 3 image banks and 8 tilemaps +(256x256 pixels each) and 4 sound channels with 64 definable sounds. It +also comes with a built-in image and sound editor.") + (license license:expat))) + (define-public grafx2 (package (name "grafx2") -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 30 16:27:23 2021 Received: (at 50273) by debbugs.gnu.org; 30 Aug 2021 20:27:23 +0000 Received: from localhost ([127.0.0.1]:60430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKnsJ-0002Mo-Gc for submit@debbugs.gnu.org; Mon, 30 Aug 2021 16:27:23 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:36678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKnsH-0002MZ-Vj for 50273@debbugs.gnu.org; Mon, 30 Aug 2021 16:27:22 -0400 Received: by mail-qv1-f53.google.com with SMTP id 4so2316884qvp.3 for <50273@debbugs.gnu.org>; Mon, 30 Aug 2021 13:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rqKXsMrCJsY+8C1m7Pm7HCDDQY1kyZ7CMUG0x3kQtGE=; b=kzdCqyoXQn/I/zWf1fBeJBd81tH/O7SaM1s7Ebqm3aAKEGa3N9zFc+Ivlqyldxul02 c94JlMuuo+3/fbtr5avIdq3oM9zSjzK1Wa3ZqTz8mWuMWwPno7oG7CJts247dOs6WjEK +OI8kr2jrHwn/5BzNpN60pE6atC4Tt3guHfieAjDR5tTeqTLYQ/fbNcAioHR356Zj0pa MQZ1e8uHlEzMMA7R9iVRRdAAEJEbljCvdYfFODbTJ2m47J7y5s/ybbTp/n9r0GZaM5oU gJaVm7aUI0OYm/RF7i+E7yjjWxrvnMusFIgyQoqpOrfE2yWTPYKYkahf/Sa8fvn8+Vy4 EYxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rqKXsMrCJsY+8C1m7Pm7HCDDQY1kyZ7CMUG0x3kQtGE=; b=RqEt3rGP484eoVfMcz8I5OwB/I9fVk4E6M4XdNJMlUVdrGYoLHNdm19ALCRNwlL0HI 5schwZgbtA1nggco56I9hrrKKBV7dH64W+GkQDdANGK4w0XT8FuanBOuEV/FaG++cyLL df/6QqSgGmIPdtR26SwtqlzAT9l7jLE7Wm4LFw1qwsSGGIb6J1VSoL5JfMPN3csLutYH 2PVXZ9e2m9SI8LwEt8ByXJBSDe/92O1o+VozBXMa8nN3euzrKKVAd0KirNRFXVoUoHMe N72anS9z004SE8m7i/73wy6sMPxzh4pvrJE42vRhzq2tsFLt+pWA7FBs8/mso/cEjIOC MGoQ== X-Gm-Message-State: AOAM531mX+eSzwv67pdOsm4i2oHbgct68cJ/4mk6s/EhiPkCKEGhUh/Q fOjvhe/iNQnodXR4b2dUqGFjLaUtO41C8A== X-Google-Smtp-Source: ABdhPJx86iZmO55IG1Qfy4ZjsQ4U4iFYCaICdabciOFMdwrKigV+fYhxDLREf46iETK3FINeuacrzQ== X-Received: by 2002:a0c:cc0e:: with SMTP id r14mr25198231qvk.17.1630355236351; Mon, 30 Aug 2021 13:27:16 -0700 (PDT) Received: from hurd (dsl-10-141-212.b2b2c.ca. [72.10.141.212]) by smtp.gmail.com with ESMTPSA id g7sm9198925qtj.28.2021.08.30.13.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 13:27:16 -0700 (PDT) From: Maxim Cournoyer To: Leo Prikler Subject: Re: [PATCH v2] gnu: Add python-pyxel. References: <20210830190246.3454-1-leo.prikler@student.tugraz.at> Date: Mon, 30 Aug 2021 16:27:15 -0400 In-Reply-To: <20210830190246.3454-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Mon, 30 Aug 2021 21:02:47 +0200") Message-ID: <87r1eak7a4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50273 Cc: 50273@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Leo, Leo Prikler writes: > * gnu/packages/game-development.scm (python-pyxel): New variable. > --- > Am Montag, den 30.08.2021, 14:40 -0400 schrieb Maxim Cournoyer: >> > + (let* ((sdl2 (assoc-ref inputs "sdl2"))) >> > + (substitute* "pyxel/core/Makefile" >> > + (("`sdl2-config --cflags`") >> > + (string-append "-I" sdl2 "/include/SDL2 >> > -D_REENTRANT")) >> > + (("`sdl2-config --libs`") >> > + (string-append "-L" sdl2 "/lib " >> > + "-Wl,-rpath," sdl2 "/lib " >> > + "-Wl,--enable-new-dtags >> > -lSDL2")))))) >> >> The above could benefit from some extra commenting to explain the >> choice of linker options (--enable-new-dtags ?) or C preprocessor variables >> (-D_REENTRANT). I'd have to dig a bit deeper than I'd like to have an >> understanding of these. > > These were previously snarfed from a manual invocation of sdl2-config, but > iskarian in IRC pointed out, that sdl2-config accepts --prefix, so the patch > has been revised to use that. Great! I'm glad that I asked :-) > gnu/packages/game-development.scm | 51 +++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm > index 2a58848dce..40807450ea 100644 > --- a/gnu/packages/game-development.scm > +++ b/gnu/packages/game-development.scm > @@ -1484,6 +1484,57 @@ visual novels, while its Python scripting is enough for complex simulation > games.") > (license license:expat))) > > +(define-public python-pyxel > + (package > + (name "python-pyxel") > + (version "1.4.3") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/kitao/pyxel") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9")) > + (modules '((guix build utils))) > + (snippet > + '(begin > + (delete-file-recursively "pyxel/core/bin"))))) > + (build-system python-build-system) > + (arguments > + `(#:tests? #f ; "Tests" are actually example programs that never halt. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-build-files > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "setup.py" > + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch) > + (if (string=? arch "linux") > + all > + ""))) > + (substitute* "pyxel/core/Makefile" > + (("`sdl2-config") > + (string-append "`sdl2-config --prefix=" > + (assoc-ref inputs "sdl2")))))) > + (add-before 'build 'prebuild > + (lambda _ > + (invoke "make" "-C" "pyxel/core")))))) > + (inputs > + `(("gifsicle" ,gifsicle) > + ("sdl2" ,(sdl-union (list sdl2 sdl2-image))))) > + (native-inputs > + `(("gcc" ,gcc-10))) ; for std::filesystem > + (home-page "https://github.com/kitao/pyxel") > + (synopsis "Retro game engine for Python") > + (description "Pyxel is a game engine inspired by retro gaming consoles. > +It has a fixed 16-color palette, can hold up to 3 image banks and 8 tilemaps > +(256x256 pixels each) and 4 sound channels with 64 definable sounds. It > +also comes with a built-in image and sound editor.") > + (license license:expat))) > + LGTM. Feel free to push (and then close this tracker)! Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 31 17:27:18 2021 Received: (at 50273-done) by debbugs.gnu.org; 31 Aug 2021 21:27:18 +0000 Received: from localhost ([127.0.0.1]:35558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLBHp-0004PI-PZ for submit@debbugs.gnu.org; Tue, 31 Aug 2021 17:27:18 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:48626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLBHk-0004P7-PC for 50273-done@debbugs.gnu.org; Tue, 31 Aug 2021 17:27:16 -0400 Received: from nijino.local (194-118-34-199.adsl.highway.telekom.at [194.118.34.199]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GzgHr2yRTz3wmD; Tue, 31 Aug 2021 23:27:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1630445224; bh=dX245Opym6xF8z0P1WAqNGlCqO+MH8T5hUI+MODf1pU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=UkTHqbLnFuXpv8UoasxVlGKXYK6FfRA0YeqSxsjQBrPkcOD4u8943qIPCwu6vaXOV 9IA4VaKjBFRF73P2CY3G75FVogZMakmG4eKHO+vX/cts7QWgjyfJ1hVHLruz5PUgLH x1P4ne/8kFxtdXl6UDkLSFpvic8g4UZf3JywcPwo= Message-ID: <44a347b0986ca73f95439d912bf8cb512316ee2a.camel@student.tugraz.at> Subject: Re: [PATCH v2] gnu: Add python-pyxel. From: Leo Prikler To: Maxim Cournoyer Date: Tue, 31 Aug 2021 23:27:02 +0200 In-Reply-To: <87r1eak7a4.fsf@gmail.com> References: <20210830190246.3454-1-leo.prikler@student.tugraz.at> <87r1eak7a4.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50273-done Cc: 50273-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Montag, den 30.08.2021, 16:27 -0400 schrieb Maxim Cournoyer: > Hey Leo, > > Leo Prikler writes: > > > * gnu/packages/game-development.scm (python-pyxel): New variable. > > --- > > Am Montag, den 30.08.2021, 14:40 -0400 schrieb Maxim Cournoyer: > > > > + (let* ((sdl2 (assoc-ref inputs "sdl2"))) > > > > + (substitute* "pyxel/core/Makefile" > > > > + (("`sdl2-config --cflags`") > > > > + (string-append "-I" sdl2 "/include/SDL2 > > > > -D_REENTRANT")) > > > > + (("`sdl2-config --libs`") > > > > + (string-append "-L" sdl2 "/lib " > > > > + "-Wl,-rpath," sdl2 "/lib " > > > > + "-Wl,--enable-new-dtags > > > > -lSDL2")))))) > > > > > > The above could benefit from some extra commenting to explain the > > > choice of linker options (--enable-new-dtags ?) or C preprocessor > > > variables > > > (-D_REENTRANT). I'd have to dig a bit deeper than I'd like to > > > have an > > > understanding of these. > > > > These were previously snarfed from a manual invocation of sdl2- > > config, but > > iskarian in IRC pointed out, that sdl2-config accepts --prefix, so > > the patch > > has been revised to use that. > > Great! I'm glad that I asked :-) > > > gnu/packages/game-development.scm | 51 > > +++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- > > development.scm > > index 2a58848dce..40807450ea 100644 > > --- a/gnu/packages/game-development.scm > > +++ b/gnu/packages/game-development.scm > > @@ -1484,6 +1484,57 @@ visual novels, while its Python scripting is > > enough for complex simulation > > games.") > > (license license:expat))) > > > > +(define-public python-pyxel > > + (package > > + (name "python-pyxel") > > + (version "1.4.3") > > + (source > > + (origin > > + (method git-fetch) > > + (uri > > + (git-reference > > + (url "https://github.com/kitao/pyxel") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > + "0bwsgb5yq5s479cnf046v379zsn5ybp5195kbfvzr9l11qbaicm9")) > > + (modules '((guix build utils))) > > + (snippet > > + '(begin > > + (delete-file-recursively "pyxel/core/bin"))))) > > + (build-system python-build-system) > > + (arguments > > + `(#:tests? #f ; "Tests" are actually example programs that > > never halt. > > + #:phases > > + (modify-phases %standard-phases > > + (add-after 'unpack 'patch-build-files > > + (lambda* (#:key inputs #:allow-other-keys) > > + (substitute* "setup.py" > > + (("\"pyxel\\.core\\.bin\\.(.*)\"," all arch) > > + (if (string=? arch "linux") > > + all > > + ""))) > > + (substitute* "pyxel/core/Makefile" > > + (("`sdl2-config") > > + (string-append "`sdl2-config --prefix=" > > + (assoc-ref inputs "sdl2")))))) > > + (add-before 'build 'prebuild > > + (lambda _ > > + (invoke "make" "-C" "pyxel/core")))))) > > + (inputs > > + `(("gifsicle" ,gifsicle) > > + ("sdl2" ,(sdl-union (list sdl2 sdl2-image))))) > > + (native-inputs > > + `(("gcc" ,gcc-10))) ; for std::filesystem > > + (home-page "https://github.com/kitao/pyxel") > > + (synopsis "Retro game engine for Python") > > + (description "Pyxel is a game engine inspired by retro gaming > > consoles. > > +It has a fixed 16-color palette, can hold up to 3 image banks and > > 8 tilemaps > > +(256x256 pixels each) and 4 sound channels with 64 definable > > sounds. It > > +also comes with a built-in image and sound editor.") > > + (license license:expat))) > > + > > LGTM. Feel free to push (and then close this tracker)! > > Maxim Aaaaand done :) From unknown Sat Sep 20 13:01:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 29 Sep 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator