Subject: Re: bug#50256: thing-at-mouse

From: Juri Linkov <[email-masked]>
Date: Thu, 02 Sep 2021 21:28:32 +0300

>> I mean that we needn't do that because pos_visible_p already does it.
>> So I'd just propose to do the trivial (line numbers are not trunk's);
>>
>> diff --git a/src/window.c b/src/window.c
>> index cb8fe5fcdb..bfbed01749 100644
>> --- a/src/window.c
>> +++ b/src/window.c
>> @@ -2199,8 +2199,6 @@ DEFUN ("pos-visible-in-window-p", Fpos_visible_in_window_p,
>>      posint = -1;
>>    else if (!NILP (pos))
>>      posint = fix_position (pos);
>> -  else if (w == XWINDOW (selected_window))
>> -    posint = PT;
>>    else
>>      posint = marker_position (w->pointm);
>
> I confirm this fixes the reported issues.

Actually, whereas it fixes the reported issue,
it breaks everything else: moving point up and down
always jumps to the fixed column like goal-column,
selecting a completion from the Completions buffer
always says "No completion here", 'C-c C-c' in diff-mode
jumps to the wrong hunk, etc.