From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Aug 2021 01:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 50245@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163019907426021 (code B ref -1); Sun, 29 Aug 2021 01:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Aug 2021 01:04:34 +0000 Received: from localhost ([127.0.0.1]:55189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK9FS-0006ld-JM for submit@debbugs.gnu.org; Sat, 28 Aug 2021 21:04:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:57766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK9FQ-0006lU-K5 for submit@debbugs.gnu.org; Sat, 28 Aug 2021 21:04:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK9FQ-00059e-5w for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 21:04:32 -0400 Received: from sonic302-19.consmr.mail.ir2.yahoo.com ([87.248.110.82]:35407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mK9FN-0005Tb-C8 for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 21:04:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1630199065; bh=Q1QYjnelyFclm6HplzDn9Or0NQdYMpOCCW96gZdzeQw=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=ka2jAghsiq+PmFeUCT0/xe841hohheLoHQ2o4ThPHhPq8zVm6EQzl8uUTjj9Fh/+IHws9vksTDIkD2JGhUEE5Cc+YT3Has20qWdY8H27g6o+DaEGlw5tBiaPAxI+/MsvL0QyJB56A742nehimbDRgCe5AjD8sAmcrsqAAyNocZZSRKR0ctJw5zz5d2u3lXKlq6PRlB6g9CFKHWj9ZQx3q6CcICuq/aIRsmMTLTiz/+XxTFoBpiqQCcN79i6YGg0ANQwmiF7QBgOEv/f76RwnyCGfgmcDCqlsc0Mcy7NJbaOd/SVtHQ+T/o61c3I4PeFrfQlyCHfC6Ckd9EUi2aNGlQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1630199065; bh=u8BoC4/aRntnOWdJcgnchPGY8xGzmfpkTRR5ks80hxs=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=LHUvzrBgVfsBfA6Rk7/Bi3UYtltKGO3sRH2bnnZZoVVWrwWusbtrWSBQg2IIxxXte8hcwoPUrABqlcYZOig/cdjYr6G3U9gJiBKlJtsqKnld/ptiejGQmkVgDX3u/rsIocj96YkdXoH/QA2ypveKefBQj9vhq0H8Cnm0as2d3z2ieUYu3ZjBVrHcvOTHb4Tte84Y8t70d09xs2vx3Ah6DiUOsyrrLpvjW8K5Px8kbxWsJn5gSera8VRagiMGP5u+OogOTL0qUkV0lC3kBlaJOaVz6qQWXr5wmJmcpPKgQN/dPxMlzmQmHAN37jb+hKMWDZmuooe9TV4L8TB7G/pfsQ== X-YMail-OSG: KrdcExwVM1lc5WgTcgzhCIoYEQuNoqNRArOcYIzR4ymMMx_IQL8GPvFDUN7dURi cFDcsPFaNfZwdzB5fOOZWpEnGEiKDAz94dn.eQ79FZoafAgg9D42Bsl.ovPL28Cw2CWMKgRhoP99 bNJtp7vPRpLsQP37q7DAJlLJur7ssUCit6NviONnIu8RscZ.0VuIbN.jonzrDXUT_r4Vq3R0poX1 qnoz9Np__HzSusNl3Byb9Q9MNEhkJEgEb4Z7Dn3nXdZr6ppha6YUgAFJc.E.4ZbJjLQ_kl_cTowB OzEQQ0idlCBAedIlKt9JQdQtGRWHArn_R3jCraXzE1pyoVApuZzDa_ASye3om7kAKenjHdfYZgAY iBvYEwru_FXgB8E92QO3YopM4pS_xjZ_AcGGOVnPr8XbIb8XNzG9GGywTwlua06PuzZ_51KWPOcc x1eTB.CJVL5EUha0xFq24H.wG2dv7K.AUalzsOK61fva4z7JUBVs0Nb68HfNsBu9O353bqXCF1ST LpyeuofoSgPq5J6Py355Wm88X0lx66EhyvGC2eEnZNpFyqvD2oIlsbDqZU_5AkaVw4dBxBCkUCRP iDExJJNYiZpGLdv0.cV63NMIQt4scLl_le2au9mlmo9VP1hIPchcx_8hhQhp8vhaQTS2T5tpULTQ MJcgXaDVtQjOpOLZX2p1A414He7lddxxBgMsDiH8tAombmwy.2YmDbf0OwRnkAcfyIVT7.QvSqpp uoYBQeL_v1Sb9a.Ga9Iv8flpbZiWIZLNuneZG.OA3xmMeTG7ZAJ7d1Um4Dh2G_QEWhIbtzYqXLED VT9CUSSNvOwiVV5jErF73HC7m3QtZeF0KMeDeHg9.HMY0.0VpXkF55pet2m5HTDOgWcc.X_Ww30z RfhEhHxIguJZjy6XKKY56sYQNGobOsF9fzmjaGUc66SmQeRUt4SGsVDYQoymrquurjjPAYhTCcBS 3ZFlr5qgvi_PpIH5IMSZ.n5m3YsJ9BeMAWDxixWvfXfUHT4Ub8ql4pyRGpppQBBNh9kEXqSDpML1 dFNvo0NqklmxNc9AzH4DL1.fr2exJY.sGldqjpJ9S6wEv2aRIFXa7_dT12WnkKRJtcjdYzPhusd8 yfQl4f4blYLl.JSXbqS683KicnERMF5hMEC3vaDUc_yak8ktMSNtey8fxNvWaq2v.9JKLddT5KfS UFRLizoWry5seh8_U25OS0EC7c3oK8T.Tq3DOfaaT1uAWh1tbaBxIJgzt5rk4SSZlgTjKaBu9yoy vzZcannqSFayXxsNO_Nj9u2EdshGq347EjzB2UGN9NYk1kSA.Jihfl37AO5tsBU9tIr3tjnB6CxX 64eDefCSGjxBGE8fQggytuVinYU6wOi.KtMLra3s3ndEZXdOTk.ERUjWAt03DADYYRrTrYa9uTdY OE6rZ032diaXLzrq8hnyWVXcmWhd8ulRc_oVCgp7odh.wWAPBGou6MIhKc_3yBwCbvwXfAmeyiAq hs.ttgYAdycOw1QOYsowHu_8WYwJTJmFxIsXB60sUAVBbT6uvmCuwnFBpICud48lZsizucMSCzk9 ubFtGJKk7vduWTDXMPBdciPfR4EJ49wKSBQ4jU_ofi0PdEo3a.T1SNSp_j2opG3KEFfYftuSN1yI 8FUWMsJsE88JUH5jcTgQKFh3hClmGTLsAf5w5kCT8RAF0t4a8zySnApJiCzMvqIx7ZWghcoDbDdC Vg4mcduyAjPoeuo3ks9gyiM1sPyFQ3e0QNgvDTU8IX.XB8ZQlPQ.JZXVjRCgqkIL09AjcqhjSy_l dG6oSORI4qWdRR4.aeKTHKBUdm90t6e2TpkCMvV.hVCeebDYNWSNsMCVdKYpVbsZLeRprf_07zhq P5idCkkoMzrNF05e9WjvrWRfONJBTtdyhnR3o20npusm3_PnVdcxViu1E3WldS7Y3q_u.ZIw9NOU PqVRxXGar073629qdWyd093s69BTkajWjfwuxQntTijkfA1U946gpV4iyYq8cDLg3qS__Ow_9bXL kEIIv6TX_ef_kawzpDVKY6PxhLWsINc7SOCq9WVjFdY2TIwv.n.3J__670GxIfvNjy9Obn8ZfUo5 erzm2.JK2PoeUHGk7cC9xUc6iZu8.KaqycCEcg6DQMp3PMjYkWsGCCATegumn4gfavCrnlwpDSI1 OP2Mb74gPRIoKFjM6svW92T6gRxfhchD9DT3taCRF4.HT3WY3eqZmPvy6ouKoYet.T22t0jMRSr1 dc48GDd6LnIXY7xFv5_.kyg7L9oN3KzNMOHSwr_YOZKoW2dVFIkcj.2By5HZbir0syxjsymEZCnG zEHYkFgWy4G6NShP_ X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Sun, 29 Aug 2021 01:04:25 +0000 Received: by kubenode514.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID bd07bb8f4a60caf19111d47d3eee4cfa; Sun, 29 Aug 2021 01:04:21 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Date: Sun, 29 Aug 2021 03:04:20 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain References: X-Mailer: WebService/1.1.18924 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 567 Received-SPF: pass client-ip=87.248.110.82; envelope-from=mardani29@yahoo.es; helo=sonic302-19.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a regression from Emacs 27.2. Steps to reproduce the problem: 1. emacs -Q 2. Place the point inside any Elisp function. 3. C-u C-M-x Expected result: "Edebug: " shows up in the echo area. Actual result: "" shows up in the echo area. That makes it difficult to know if the user evaluated or instrumented the function. If you open the *Messages* buffer, the reason why we don't see it in the echo area is because the "Edebug:" message is ovewritten by a subsequent message that prints the name of the defun. From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Aug 2021 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 50245@debbugs.gnu.org, Stefan Monnier Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.163026654621915 (code B ref 50245); Sun, 29 Aug 2021 19:50:01 +0000 Received: (at 50245) by debbugs.gnu.org; 29 Aug 2021 19:49:06 +0000 Received: from localhost ([127.0.0.1]:57444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKQni-0005hO-DD for submit@debbugs.gnu.org; Sun, 29 Aug 2021 15:49:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKQng-0005gt-KF for 50245@debbugs.gnu.org; Sun, 29 Aug 2021 15:49:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DDl0u44SzUgH+ledHtmgQyxDxWBeRMxtT13/2Edl+YI=; b=i1N14iRY9Frvk0IVKK93M77ukv dkOkvpYdeS4BK42dLwnel7qdqOjImA7i6DuhyrPo0sr/vByvg5nTAORj4wUnKkKAWs0WiyNMRXPBH 8B7Sc+zIsWY8GR5oYaucbBIwWhqSwF1EFfwi5cxC08nyeFPpSHofcqrB159+X8EuT6gc=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKQnV-0003Bf-He; Sun, 29 Aug 2021 21:48:57 +0200 From: Lars Ingebrigtsen References: Date: Sun, 29 Aug 2021 21:48:53 +0200 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sun, 29 Aug 2021 03:04:20 +0200") Message-ID: <87r1ecdobe.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel =?UTF-8?Q?Mart=C3=ADn?= writes: > This is a regression from Emacs 27.2. > > Steps to reproduce the problem: > > 1. emacs -Q > 2. Place the point inside any Elisp function. > 3. C-u C-M-x > > Expected result: > > "Edebug: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Mart=C3=ADn writes: > This is a regression from Emacs 27.2. > > Steps to reproduce the problem: > > 1. emacs -Q > 2. Place the point inside any Elisp function. > 3. C-u C-M-x > > Expected result: > > "Edebug: " shows up in the echo area. > > Actual result: > > "" shows up in the echo area. That makes it > difficult to know if the user evaluated or instrumented the function. > > If you open the *Messages* buffer, the reason why we don't see it in the > echo area is because the "Edebug:" message is ovewritten by a subsequent > message that prints the name of the defun. I'm having some problems following the logic in `edebug--eval-defun'/`eval-defun' -- perhaps Stefan can help here; added to the CCs.=20 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 50245@debbugs.gnu.org, Stefan Monnier Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.16331799756837 (code B ref 50245); Sat, 02 Oct 2021 13:07:02 +0000 Received: (at 50245) by debbugs.gnu.org; 2 Oct 2021 13:06:15 +0000 Received: from localhost ([127.0.0.1]:58226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWeiU-0001mC-R9 for submit@debbugs.gnu.org; Sat, 02 Oct 2021 09:06:15 -0400 Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:43331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWeiS-0001ly-Kb for 50245@debbugs.gnu.org; Sat, 02 Oct 2021 09:06:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1633179966; bh=AD84CGPaLCzaqv2cHS18jR75xfeen9uQh4sup/kJ0Jo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=WbmTl7RcIT7XGLm0RiVkTqpfDSTFVdgUHzkqeuxP0XGhAKKXjmP2NNa4AEmUqKIaUquc65gvDt7PyWH2efubpi3OQ9/DXYyPK3jmbj2f/rO2Gu3st8qUtxldrJDKpe+zL0oh4svdph132eTSgHm7mZzYXSLgMiGdTDU9s4Z6F5zrrvertwvrS40+pI5Nr8fAAZ3h/uJ/rAzsdvMmy20fHuJCI4MXKg4tnvpQB3l2oNquht/kBVDNTPRjgDE2xsP3OIJ0LG/kJ0bl4bbi+K26zp+Bywwwiv6MhlBCdh+F1fxGbrFSgaomSDlDJ49Jop4CrvjrHr2INS6vsAxKLbRUPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1633179966; bh=F0pjQdCvQOUju8kLF1lHW00AEx2EyW7D1A3oLTGfsLI=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=gBoTlG4s6ZDEl/Gxbz52uauCcHZ494O+qWZ1DlDNEBv1i3MvUYVjkXqTZqnwn1bkwSeCxHjFN8NX+DC7EiWsU97u36c1XdJ9aLqEgqp/wPWIpExNVhlGKxoHxzzumtubp9LSHHXk2uO7kszNUI3NF/EeQ1Sa47erXTljg6nr1HrJm7v/qC3evu4qtWZUfAtsHXjlz1UNdpnmvsDlwhZcuDdMw9T4q1iRMeFVCRk6/6qRWW5/0foDyYceNbaWd0PES/jyg2WC+UcZcXFVP8InQGFmH3tiiLQfMksQ9+r/KmUcKoJH/vw0J7nybLu17jpCxXCFqcfVZgnFx4vJNejbjw== X-YMail-OSG: mNgrn8sVM1lpQQHzOucZkl1QHFzgwoE0YXfIWq6VJ9UZTtmdNsA0d9cKq_L5RTH AoPbhSucz1PSDvVrYq4Vswyz3fAJD_H0bXr7.CX.V6vZwp4.02Vhom6m5p4dIa12GpoJYCNLLGrl xOpg0FQI4gioDS3W8bqm8k6WJ34K3GEQtzicUa95fJw3tpOtAcu41GMvoNXXRYIQa4M31RcHtUpU oqeN5_IXD_nwWc5MyDkEwAFvNwen6CTW7s65AOE_VlLe1CjD2PKsPE1cIQjwbiCWWcwPYf4I0lQi nib.LlL0iNHrOimWKdUrxNXnY48o2DTJb6SE1MQ1FMYZxc52mWOc3YEwa8MczfG4q2Dbx1cwTMGI vaQvuwu_hT5bkOF0mOU3mcroGjXHenB6SCn3sTSs5JMPwC7wzTDME.vH9zjsfIrcV96ohFg5W5Ld Toh5l5HQm43R1pocE1.GODoZimmSUwVU1QBXvWVW7hE_lLFirc8Q0lX2SPSVamhDG71mZz_Gui53 Lw9nbVylKDVi6VPVOOC.316S9s1lt1EnESPYwsHs2FegC5o0F1KEJVQugsoPW23Ih.52BDIhy1Zp aNC_QssgukkmMc9U6KgzOAkZwKbPpWToMUB2CLRowOY0pM2XJFKVUwVFRFOwCLMuy4NVtJDF_mLb XHf0OK4.AfkoHVe9s8ydkeYQBsQ1PxpzHD8.cczMoGXnQ_ZeX_0RQGWSLGLWifb6pV.kYElBnDLW 6aDszngkXUnFRbugTf962aJiD2MUf1PGWG1F58s_S_y6JLsEtTJplZqBHqgQy.vdHn_runG5hUu6 Y1LSzwJtIqt18NFcaJKDkcLG7g001_oDDYnd1N.1QrHYPEFTbCMk8xqnyKUpPLX5VdKolSeyEmfg XH7o1dSjzE_nQfUuWoDsFlAx09CBCH913sY8n4FX5iuNIak9IntEbRYq1cy30LIf2L_NB82wVDn6 OYxI95mp.VdHNrPkin_Doq4R0Za5hW3l_0cy8wztX7oXL8KNb.aBKVIoJOKvM2WRNxfFamHstKjV MHyiuLl_pSlPTReV_XKkD344x7RQA58GH9RA1pXPuIYrZrJVz5h_70TZOEiCVPRLaLW2uMpfVifb NSDBCJ55cp9Hnvv8AdbzIruWYCPLJsRU.s1zwhqeiUEWW1ph3_eZHguvU.YcUhVYOV3yQXjHEYFF DK6CSjQlpyah2wPZR4gJNwUF92JoLsniEIHQ2Zr.A_xbat9uzevhYaoSy6GF_U6JDKA6FMJtrEiP rN9e.40qLMV4FchOGtaTHG31vU8QQgBehSsPtxJtj1xceN7UI9UCQKKRIh0vWkZ4_nCh1OIyOPoK coThTJTjeZKKArSWvzim1.GIqskV6XClMTc1_9RXHdTE9Bmh7d.cqfuwx8pJVFY.oLDTL8rqzzBN s_E6KmpkTeubJhGoJNL9EU0urYEiB0CWpuhNx2wYCWgMzXF.RQDN6TnNykf67F6V8XZ2CVpD1ZoV gxk08hl6.RiAljitWJx8_r9_83U4JlZ_QVUkh3hSAaBD_urQ8htiF9.5C2UWgK3n0q3WjnCZvFB1 wzvz4_VHN96fKp6MJpm6oZf47Ve9f4HUuIw4I1K7eQSPnvlT0HD2jXGVhpLW3yuTeRXwqjVjiB.9 rmg88kVTRsxlVJkQ44A6qzbgTgibrA8rCm.8e_4Eyhg9o.TvlFpA9laNIn_wOZHG5TWXsX.3Irrk jlfC5c2j8g8lTSDHZevCRw0jWlMBJrRYbas_YTGtQINLjDhAi1Ix8DciO8xI6cHsFFFIiQADciCC 8BnnZzR0sumBkgisDM3p4IyMn5zQY1hunnSTPg.MROfSv92BmZiAB8emZn4eepe.7LaMrC3_bqIx Xv23c37rR0GpoTiBp8c8.KuibTlxaZ9ba8fEqDHsNAF36faiEABQRpf9WpCqMIdpb7_EhLvgxAUc PE1TxpNfVZAtwrtOCx6Jr9UFXRVRh0PFpKdifMUnRQszKnthkk1SCFBviONv1ZabCmaDH7CHAYd5 PDzEVXjNENzlvumwcoLW8qKv8U88tdv8e0e0GdqcD10CDk62Nhk5rzEowMDeUccq5SuaQufh0wsK BvcGm31H3RWLjrIpXcvj5t_ulVI_zUVmvQBxZcoRBD9FHlSqFQHDwO0BG_BNiiuwCWW8MMCq5l93 aQ.PMMc_9kRPF1N9zacxNkCHH_nubhFlLttxUE0wu6xpm9FmM.dRthtMDISMM9EmsEHJhH.Bb5PY ZBk5Z.h2hjXidRZA52DxmXAUWnvFOWNySyyCxkBLlYUvs4KiswsslBhF9YDuV X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Sat, 2 Oct 2021 13:06:06 +0000 Received: by kubenode527.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b34d2ed1792209361be4175313afed47; Sat, 02 Oct 2021 13:06:02 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <87r1ecdobe.fsf@gnus.org> Date: Sat, 02 Oct 2021 15:06:01 +0200 In-Reply-To: <87r1ecdobe.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 29 Aug 2021 21:48:53 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.19076 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3093 X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Lars Ingebrigtsen writes: > > I'm having some problems following the logic in > `edebug--eval-defun'/`eval-defun' -- perhaps Stefan can help here; added > to the CCs. I decided to familiarize myself with the Edebug code so that I can fix bugs and implement features. An automatic git bisect says that this is the commit that make the regression evident: commit bae2cfe63cbd11eaf348dfa7fbb2b9f7362fc747 Author: Stefan Monnier Date: Thu Feb 18 10:27:36 2021 -0500 * lisp/emacs-lisp/edebug.el (eval-defun): Simplify (edebug-all-defs, edebug-all-forms): Don't autoload since the problem it was working around has been fixed a while back. (edebug--eval-defun): Rename from `edebug-eval-defun` and simplify by making it an `:around` advice. (edebug-install-read-eval-functions) (edebug-uninstall-read-eval-functions): Adjust accordingly. (edebug-eval-defun): Redefine as an obsolete wrapper. * lisp/progmodes/elisp-mode.el (elisp--eval-defun): Use `load-read-function` so it obeys `edebug-all-(defs|forms)`. (elisp--eval-defun): Fix recent regression introduced with `elisp--eval-defun-result`. If I'm not mistaken, the first "Edebug: defun" message is printed in elisp--eval-defun, inside the call to load-read-function. The second one is printed by the call to eval-region. This code path is newly exercised because edebug--eval-defun is now an :around advice after bae2cfe63cbd11eaf348dfa7fbb2b9f7362fc747. I'm not sure, but I think that the author's intent was to reduce code duplication (with possibly other benefits). My proposed patch first checks if edebugging is active and then avoids that eval-region prints by setting it's PRINTFLAG argument to nil: diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index acf7123225..d1a4200df2 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1612,6 +1612,7 @@ elisp--eval-defun (let ((debug-on-error eval-expression-debug-on-error) (print-length eval-expression-print-length) (print-level eval-expression-print-level) + (edebugging edebug-all-defs) elisp--eval-defun-result) (save-excursion ;; Arrange for eval-region to "read" the (possibly) altered form. @@ -1629,8 +1630,9 @@ elisp--eval-defun ;; Alter the form if necessary. (let ((form (eval-sexp-add-defvars (elisp--eval-defun-1 - (macroexpand form))))) - (eval-region beg end standard-output + (macroexpand form)))) + (should-print (not edebugging))) + (eval-region beg end should-print (lambda (_ignore) ;; Skipping to the end of the specified region ;; will make eval-region return. This solves the problem and does not introduce any further regression. Any feedback on if this is TRT? If the patch looks good, I can accompany it with a comment that explains the reasoning, tests, etc. Thanks. From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.163318722022070 (code B ref 50245); Sat, 02 Oct 2021 15:07:01 +0000 Received: (at 50245) by debbugs.gnu.org; 2 Oct 2021 15:07:00 +0000 Received: from localhost ([127.0.0.1]:60250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWgbM-0005ju-GK for submit@debbugs.gnu.org; Sat, 02 Oct 2021 11:07:00 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWgbI-0005jf-Py for 50245@debbugs.gnu.org; Sat, 02 Oct 2021 11:06:58 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BBB968067B; Sat, 2 Oct 2021 11:06:50 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 41AFC80580; Sat, 2 Oct 2021 11:06:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1633187209; bh=14ODh6Vq+eyRe10vRZBtOyolhdUt/hgbx1CjbOzRvSc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Y/q8hu/ATGqKyB5CETyBgSyrIGYI48DN8R3AgGad0MmljEJpXfGWox3NL+E41+7y+ x8ZKmuT0UNQq9ZPE1z8kZgJ2rBpOJVP5G+F2gTW964KY729KIx06XxmRkU0WdytGPB Xdvk8pqkthOuqjK+r31P/EMnZWAsN4UwEueT3oY/xSemU4DowfQ7ZkL3hYhvFAJ/rG OFbI1obMVt6aVtYH694vfoMLcQPfUDQmZYLDxeM8fc7wyOcuN+41J+dlgyEx1dTI1v 8Z4qQT+oxloM4axHjBfONLjTMFEVpmWaiiJVkEfrYY/LR0ghg25/E/M67sGupc3Vqu ic4XGx+qesHrQ== Received: from pastel (unknown [45.72.241.23]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 117D1120191; Sat, 2 Oct 2021 11:06:49 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87r1ecdobe.fsf@gnus.org> Date: Sat, 02 Oct 2021 11:06:48 -0400 In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sat, 02 Oct 2021 15:06:01 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > bae2cfe63cbd11eaf348dfa7fbb2b9f7362fc747. I'm not sure, but I think > that the author's intent was to reduce code duplication Definitely. > (with possibly other benefits). This was a nasty case of duplication where the two versions worked quite differently, yet trying to mimic the other's result. The worst part is that depending on whether `edebug.el` was loaded either of the two codes could be used, so any difference in behavior in the "normal C-M-x case" was a bug, so the "mimicking" had to be as perfect as possible. > My proposed patch first checks if edebugging is active and then avoids > that eval-region prints by setting it's PRINTFLAG argument to nil: > > diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el > index acf7123225..d1a4200df2 100644 > --- a/lisp/progmodes/elisp-mode.el > +++ b/lisp/progmodes/elisp-mode.el > @@ -1612,6 +1612,7 @@ elisp--eval-defun > (let ((debug-on-error eval-expression-debug-on-error) > (print-length eval-expression-print-length) > (print-level eval-expression-print-level) > + (edebugging edebug-all-defs) > elisp--eval-defun-result) > (save-excursion > ;; Arrange for eval-region to "read" the (possibly) altered form. I think you'll need a (defvar edebug-all-defs) before that. > @@ -1629,8 +1630,9 @@ elisp--eval-defun > ;; Alter the form if necessary. > (let ((form (eval-sexp-add-defvars > (elisp--eval-defun-1 > - (macroexpand form))))) > - (eval-region beg end standard-output > + (macroexpand form)))) > + (should-print (not edebugging))) > + (eval-region beg end should-print > (lambda (_ignore) > ;; Skipping to the end of the specified region > ;; will make eval-region return. This replaces `standard-output` with t, which is probably OK in most cases, but just to be sure, I'd use (should-print (if (not edebugging) standard-output))) > This solves the problem and does not introduce any further regression. > Any feedback on if this is TRT? This kind of dependency on Edebug is undesirable, but it's OK. I can see 2 other approaches: - Refrain from emitting the message if some message was emitted already (i.e. checking `current-message`). This is likely brittle (and would definitely break when `standard-output` points elsewhere ;-) - Don't print here but print from within the `eval-region`, just like we do in the Edebug case. Arguably this would be the cleanest in terms of interaction between the Edebug and the non-Edebug case. But it likely requires significantly more changes and might introduce more problems elsewhere. > If the patch looks good, I can accompany it with a comment that > explains the reasoning, tests, etc. Please do and thank you. Stefan From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 50245@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166118276824469 (code B ref 50245); Mon, 22 Aug 2022 15:40:02 +0000 Received: (at 50245) by debbugs.gnu.org; 22 Aug 2022 15:39:28 +0000 Received: from localhost ([127.0.0.1]:41526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9WR-0006Ma-K9 for submit@debbugs.gnu.org; Mon, 22 Aug 2022 11:39:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ9WO-0006MN-P3 for 50245@debbugs.gnu.org; Mon, 22 Aug 2022 11:39:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bp2Z+HBTBe8TdIFa0OoJWnjJtXoIyt+fhuTxn5FJ8XE=; b=Fh9DnMsvRrCfssP5pI03ORycAd PiTBNem6cajButcB/l/G71TcJC/ir6Y5uXo3cnBXYESAUoKEcK6tpcz828kecarAHjqQzs3gQPqkk ZpPzBNQXHSrSLjAtFrdVt3wkbadRFKcQgxjWme+QyvHey13a/qN7HcfZcKXEOSoMnw6w=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ9WF-000703-HP; Mon, 22 Aug 2022 17:39:17 +0200 From: Lars Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Sat, 02 Oct 2021 11:06:48 -0400") References: <87r1ecdobe.fsf@gnus.org> X-Now-Playing: Mr Jukes's _Blue Note Re:imagined (2)_: "Maiden Voyage" Date: Mon, 22 Aug 2022 17:39:15 +0200 Message-ID: <87o7wc2spo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> If the patch looks good, I can accompany it with a comment that >> explains the reasoning, tests, etc. > > Please do and thank you. This was almost a year ago -- Daniel, did you do any further work here? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> If the patch looks good, I can accompany it with a comment that >> explains the reasoning, tests, etc. > > Please do and thank you. This was almost a year ago -- Daniel, did you do any further work here? From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2022 22:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 50245@debbugs.gnu.org, Stefan Monnier Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166138034711435 (code B ref 50245); Wed, 24 Aug 2022 22:33:01 +0000 Received: (at 50245) by debbugs.gnu.org; 24 Aug 2022 22:32:27 +0000 Received: from localhost ([127.0.0.1]:48405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQyvC-0002yM-N9 for submit@debbugs.gnu.org; Wed, 24 Aug 2022 18:32:27 -0400 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:32992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQyv9-0002y5-Ct for 50245@debbugs.gnu.org; Wed, 24 Aug 2022 18:32:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1661380336; bh=KJRAHR5in19ScP34TWVFPxazc+xK0GmBBRWWLZo2hgc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=MMPZDYH42d6dRrUs/IE5jQY35pk5bOotoyu+gZyk711FARHUNfTOAtNtPubXgbwN5KWCrLZ1Oywr3V2khw1nd65msf29engso9c+u682/bqKHtl6wVcc3a7VzAJsaw87wHXxtSTOFhQuORilTNvgfqQMQWwjNkeEzcIjCUbsiqt2vapEZMFh2rRHnNxtWH161Kjv2H0EyYPE8+MZrTTQZyyZ87HX+iEVe534gaOfQW/gwtbl6oGrpMfEPCdpIdIQOmTMDbhlebhyVyQOSnK6Tekw8Ilb6l63bKy1ZlrcV73UsUOJptIEa+k6ukKDpcaQKhaM2Mk3gxc2r1B6ZtGTUQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1661380336; bh=iekxuPrQvLXVKv3uOOAASGI6rAeFo5IfMbEMc5s5Cp0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Zyz0LgcA2hx2RAcal+mz6+MMkTgfxwf113xOhlH0WZl6apC8Ja3Q3QZZxw2ovWhuQOtcpXgpw3dPGBTywodbXnjuGeesjukjHLy587D4n81wa0YbT4q4hVx3ZN7NbS2/RogIMjbe+4Uss9vZUFPcZpz2QiEkBTL5T9ROXSKOpi10Ayz8pfQ8URc3+IAnMQoRwZlE1ebP8wFbGy69sLvuVRqNA4gChZecdIlU+aj7bO1dIh3U41OQ59XkcNge5PpSl3+VbhTJNiVGdk8CCDI1tN9z4JiCO4FNlzy7MZkqlX6BxCmXobYmfhHEdNRYDJklRkSYy9K0FNFcLVjH6IOugg== X-YMail-OSG: 1WyxHe0VM1lwBJFs2q75O8PpNkq6F0UpB.myf043KchJA_W8ncHOEt9yxOP3EjM JivN5cuENi8Gr3Yu7MMj_d28SLXJnpeFE4nJTqN72pXLeGB6aDArK2bkUmuCJWAVeZH21FBbCOET 4E6ZL3Fndoj.GsjmAxjQ2fNqn6L8VLdbQXXpeTMkmPwgqfFplkL06B8E8vvBsVANDI6hGF6CQvvS icotGVgJPte3Inqx56zgGboB.SjMmpw..j0lBv3..wsPrjOtcUTQRQSaxcK7ZX803dAnpw8gxMVl IwwQJvVbcHPVutJpEmchelHmtjAUp_oDUrmxOTo8xxq5gny42grKWaJ4x.Tibf9i19FxxWWyRF_2 vVLN1wPghfKsLphheZFxtT_Zyr7o.nQJDO.4OG9gH1XEiXsHgHaBTsh4Wc75GozitrzxqCrJQJVP ZvIIOorISdrxqvouzC6HRdSfoNP5jQCIdyOMF_7OjHo8Hf4pGckb47pkYjlJ157Kku1g34S5Bayc ZZdc9jVWRcBHrE9yPDkhFZnEozU.s5IrTLiI9R9uXWfonwycBGEpM_lIBWdujXscgwVkGHjbyMUP 3bXd7_.vZWQn_nHNoWQ9Zs2UxUgEE9mSfOnsCnoQc8iZilO258X9J3QPJu_eaxxsN4cx624eoeu. _DLhwr6vxuabKOQRF8qevxUoMQTeKiReHPmJy.xOiDBcMOFTpR4U.xT6zpI8zBHzNPz_7vB_40F2 euB4RRC73dV9IJRqIo.71Wmr7Vz0dfWeJR00gQGMS7R61evtYk8Nksb7IbNuXGaCUckD2wjUAjD1 PkpfmSpNJ2tJ7HYvEkvIc_P3cjMQnziQiQQAjFgONjvP5c9zBswd.nmEBaD5D04cVGJfEocRXfw_ ._HoO_fiRuskIJsoPH7JFB32TcYQiw32xW9L_jZzlqikmrWpga9S9QQ28d_O7NRAkOjDA9NgQTbr s9QxJZRntoo1CEXCtKr7hAmSQAHrAeWK08yfqYkJ1B0rA0coqM4_GR3jIH3.pQErGCX1_Z4E1FLH _7gnd.R0QtwM4WWaiysPyfy0G5651eWV8FWEveQQVDFxpyrSQIVc5g5KQGRZeO6kc8hS8exnwhjP C5bZePsHuzWOjwx9Vl15p06U0.OJXWDGG86uHrYE_SwciOastOTyvUlgp0BHMR1aV5GwKluZUh9u QRxjTgs2pCIt2CFucIqmhUk8jfC7ur8CAaE2opgxRoYGgfMotZLH56V6aYmynN.xJ5a_QKi1aixN SWhD5O219cwnBrK63RmcMfvlEJ5QwiteUzHs9FJLT.y89A111ZYen8_PArybRhOov8WDMMd07n6o fnSHMzo2gUbaEBTB7jmGtk0qJoX_1huWoV9MThQRbxWyCVZhjUjVM5IZWpoDYa1uCrLiBmkXzi51 vc2hhvAWN3X1CSYzoHcd7thhhllm5XYomaoId1v9NlkfhaFVSdVXh1EXjieBUVe8Td1JL_tsjzj2 uQRrA8xCSTbFu7Wt5sXtolQhOzRh5D1d0bxq8m3Pl_ilOS18PmNTeoh4fwUgE6ReOu1qSPHV7vsC t0HUWz.Or5PUzdzt3esDJjrUfvFMj_HdUzyIe38jNd.IfIviE4C3M.QU3l0JNt4jpO5S2YFtfGPa JtsuLcSuteKr.IB6WQKlWU_RWcatEB8z9GFIigIxzczGkc7NAB6euEcTAK63vnEpOkBAwzrrY5JH _xz1POmnhyIN8mTYuNrT8tHASJx0PRLzsNlYjmAq.5tcP30B6AcYlotWbUKesRCmIVOc29WMx9.S Eh3xGn1LkKh96qwwlCoguqkDz_rfgItVXJVURh6DGsy86xWAEKD5.w7ExClieO_mU1ivu6wUvO10 LQdsvKRQiPEEPKJXWSlNCwpnO.n3c0N6ZlQPbUGrf8Mcl4R8lWyF.9_bN6m3BTZ6_T55hLH.yIGo 1A6WsRPnscxI5wlRKFD.17Kxp3JILqiQYVbFoFUzt0N1J0jSkJ21lDhPMXvw8k8N.6NAZYQhZbYG s1El8AXNJjnabCOB2rTgA.k7PQltIC_vyAgGKgtOzlIsxhj29faPTN2nXUGvhiENDdMHxfPQZ6NR YhCZ1bO3l3cE2VjSMZ.zcCFKUInR6SfgS7PGt1Ih1ZQkXjl9q3WLCDhSgv6imAcH7Y4tFbphkLUY H1hEah11GOR7L6fXieUJhofpk6eU5bhGT_3JYA0blKjd2Bp6QF180bniqnWeZIki58Jthshiq60V E.zXUA5psBStXU5V9l0dTQVerF_CNJMB.LjW835LXNY7Rik1IS8Oxug-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Wed, 24 Aug 2022 22:32:16 +0000 Received: by hermes--canary-production-ir2-f74ffc99c-tc6tw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0d55123eed8ee62350dc2cd506f52bc0; Wed, 24 Aug 2022 22:32:11 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> Date: Thu, 25 Aug 2022 00:32:09 +0200 In-Reply-To: <87o7wc2spo.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 22 Aug 2022 17:39:15 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3603 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Stefan Monnier writes: > >>> If the patch looks good, I can accompany it with a comment that >>> explains the reasoning, tests, etc. >> >> Please do and thank you. > > This was almost a year ago -- Daniel, did you do any further work here? Here's a new version of the patch, which addresses Stefan's feedback. I've added a test because in the docstring of eval-defun we document that we print "Edebug: FUNCTION'" in the instrumented case, so I assume it's a behavior we'd like to keep working. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-instrumented-eval-defun-not-printing-Edebug-to-t.patch >From 7649176669fbe49260ec2a0cee1865c3f4cf5f2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Wed, 24 Aug 2022 23:34:18 +0200 Subject: [PATCH] Fix instrumented eval-defun not printing "Edebug:" to the echo area * lisp/progmodes/elisp-mode.el (elisp--eval-defun): Determine if we're instrumenting a function and call eval-region with PRINTFLAG set to nil if so. (Bug#50245) * test/lisp/progmodes/elisp-mode-tests.el (eval-defun-prints-edebug-when-instrumented): Add a new test. --- lisp/progmodes/elisp-mode.el | 8 ++++++-- test/lisp/progmodes/elisp-mode-tests.el | 10 ++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 0c4a9bfdbe..bc8833a693 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1643,7 +1643,10 @@ elisp--eval-defun ;; FIXME: the print-length/level bindings should only be applied while ;; printing, not while evaluating. (defvar elisp--eval-defun-result) + ;; FIXME: This Edebug dependency is undesirable. See bug#50245 + (defvar edebug-all-defs) (let ((debug-on-error eval-expression-debug-on-error) + (edebugging edebug-all-defs) elisp--eval-defun-result) (save-excursion ;; Arrange for eval-region to "read" the (possibly) altered form. @@ -1668,8 +1671,9 @@ elisp--eval-defun (elisp--eval-defun-1 (macroexpand form))))) (print-length eval-expression-print-length) - (print-level eval-expression-print-level)) - (eval-region beg end standard-output + (print-level eval-expression-print-level) + (should-print (if (not edebugging) standard-output))) + (eval-region beg end should-print (lambda (_ignore) ;; Skipping to the end of the specified region ;; will make eval-region return. diff --git a/test/lisp/progmodes/elisp-mode-tests.el b/test/lisp/progmodes/elisp-mode-tests.el index 8e4dfa8bb8..345e8880c8 100644 --- a/test/lisp/progmodes/elisp-mode-tests.el +++ b/test/lisp/progmodes/elisp-mode-tests.el @@ -183,6 +183,16 @@ eval-last-sexp-print-format-large-int-echo (call-interactively #'eval-last-sexp) (should (equal (current-message) "66 (#o102, #x42, ?B)")))))) +;;; eval-defun + +(ert-deftest eval-defun-prints-edebug-when-instrumented () + (skip-unless (not noninteractive)) + (with-temp-buffer + (let ((current-prefix-arg '(4))) + (erase-buffer) (insert "(defun foo ())") (message nil) + (call-interactively #'eval-defun) + (should (equal (current-message) "Edebug: foo"))))) + ;;; eldoc (defun elisp-mode-tests--face-propertized-string (string) -- 2.34.1 --=-=-=-- From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 02:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166139323132218 (code B ref 50245); Thu, 25 Aug 2022 02:08:02 +0000 Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 02:07:11 +0000 Received: from localhost ([127.0.0.1]:48484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oR2Gx-0008NW-T0 for submit@debbugs.gnu.org; Wed, 24 Aug 2022 22:07:11 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oR2Gs-0008Mx-6Z for 50245@debbugs.gnu.org; Wed, 24 Aug 2022 22:07:06 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4FBB54417DA; Wed, 24 Aug 2022 22:06:56 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1E2A54417F2; Wed, 24 Aug 2022 22:06:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661393215; bh=SHRvMuRYmQHkwOjoc3AsGBOlbvuvjLJrw44yWRxXaNM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VTZFpR4NRJLIVdACmNqrimBGPFM6DbjwLhZJU7ek3lPVKucULa4Sfzgj2UT3F8VEf bOVkcT9bhUriWNL5ZeGkTIkA32MlGXA/WBaIfTQIhfmwW8vF5jIW0gGI1Sz0UXK5ZN Tm9zsf6TPVjRPoOfActAeUOY27JfaVtgCDbdRtjeYNQvBRIFP71idOACrX8j3IvWRN AZZtux4A6av2sDwb1wH4O26iG6Zp5fmB4e7i5eBy4LsxX+NigsQQICQ6CIqOeoX9aG NSahkR8dEsXElNt6yWxtlDUD+TpBhv6IU1ffN9T3MGXF+Z4rvUz652nla1IIVBImr4 p9XAVEMv1DFYw== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E7233120306; Wed, 24 Aug 2022 22:06:54 -0400 (EDT) From: Stefan Monnier In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Thu, 25 Aug 2022 00:32:09 +0200") Message-ID: References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> Date: Wed, 24 Aug 2022 22:06:53 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Here's a new version of the patch, which addresses Stefan's feedback. Thanks. One question, tho: > @@ -1643,7 +1643,10 @@ elisp--eval-defun > ;; FIXME: the print-length/level bindings should only be applied while > ;; printing, not while evaluating. > (defvar elisp--eval-defun-result) > + ;; FIXME: This Edebug dependency is undesirable. See bug#50245 > + (defvar edebug-all-defs) > (let ((debug-on-error eval-expression-debug-on-error) > + (edebugging edebug-all-defs) > elisp--eval-defun-result) > (save-excursion > ;; Arrange for eval-region to "read" the (possibly) altered form. What makes us think that `edebug-all-defs` will always be defined when we get here? Doesn't this code signal an error if called before edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by a plain `C-M-x`)? Stefan From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 12:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 50245@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166143110617128 (code B ref 50245); Thu, 25 Aug 2022 12:39:01 +0000 Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 12:38:26 +0000 Received: from localhost ([127.0.0.1]:49289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRC7u-0004SC-7q for submit@debbugs.gnu.org; Thu, 25 Aug 2022 08:38:26 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRC7s-0004Rw-3R for 50245@debbugs.gnu.org; Thu, 25 Aug 2022 08:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N3Uerj5dGh2G+B2T+gjDgZrKd26RN3hRGAhHcA9alRI=; b=FwVszFEXQ6KBmFIG0yMS1MiHUK pJ7sBIHR/4wQNGxpzqsXYYlkJe0ls8wDC1mR6kVsMIGaIMsh85Gppp10S494N4t2p4z/BrKdlUWVB JQAK5Y7pS4kbDTJ4GIB9P7lmB5/BDj1WOQrR3oZfh9Q0RPzXxbYmjO3+gM5ZbghbEPP0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRC7i-0007ij-2g; Thu, 25 Aug 2022 14:38:16 +0200 From: Lars Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Wed, 24 Aug 2022 22:06:53 -0400") References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> X-Now-Playing: Two Nice Girls's _Chloe Liked Olivia_: "Eleven" Date: Thu, 25 Aug 2022 14:38:13 +0200 Message-ID: <87v8qgjy6i.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > What makes us think that `edebug-all-defs` will always be defined when > we get here? Doesn't this code signal an error if called before > edebug.el is loaded (e.g. in the case of `emacs -Q` soon fo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > What makes us think that `edebug-all-defs` will always be defined when > we get here? Doesn't this code signal an error if called before > edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by > a plain `C-M-x`)? edebug-all-defs is autoloaded, so it's safe to use here (and the (defvar isn't needed, so I removed it). From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 08:38:46 2022 Received: (at control) by debbugs.gnu.org; 25 Aug 2022 12:38:46 +0000 Received: from localhost ([127.0.0.1]:49292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRC7z-0004SU-JK for submit@debbugs.gnu.org; Thu, 25 Aug 2022 08:38:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:60014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRC7v-0004S2-Is for control@debbugs.gnu.org; Thu, 25 Aug 2022 08:38:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j21icv5dtLPBPRMa/4m1c0Wrhp8lODoZb8ixbMDjB2w=; b=C/aFLRoWdMqVy3IXbKHQQWAtdE wLGUFmqZ9y8HGMecyHH6YZmcG9pVyRKA6RtMXBXIY8nRd5i2gZ3qzwAIZ1dLT/GsvPeNjPOSnSH8k v3u9pjTVg/qQCgGOuRda6qZyXLmNTUbAlAN0on+vnrJg0Clw6rSB5DZa/E9S6FolYzGg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRC7n-0007is-Qf for control@debbugs.gnu.org; Thu, 25 Aug 2022 14:38:21 +0200 Date: Thu, 25 Aug 2022 14:38:19 +0200 Message-Id: <87tu60jy6c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50245 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 50245 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 50245 29.1 quit From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 12:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 50245@debbugs.gnu.org, Lars Ingebrigtsen Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166143168526523 (code B ref 50245); Thu, 25 Aug 2022 12:49:02 +0000 Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 12:48:05 +0000 Received: from localhost ([127.0.0.1]:49324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCHF-0006ti-9y for submit@debbugs.gnu.org; Thu, 25 Aug 2022 08:48:05 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCHC-0006sa-Pe for 50245@debbugs.gnu.org; Thu, 25 Aug 2022 08:48:03 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8D3D441000; Thu, 25 Aug 2022 08:47:56 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 295A5440FFD; Thu, 25 Aug 2022 08:47:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661431675; bh=GU0Mey4mfWyjLrgha4pggqJsiJwtVGBYN1t3h+huMgE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=UR/rW0qHJC3kNDtcqVyEhQy3hhHc+MvMYVo95thB0oGJ8/a9+NixgGDR8lW+WwcjL 4FfDZWyvhmTHM9PJLUNNYwIjHP7uNDOSoFO2of6V/vHwSs+DQUl89RB4qbNqY7ibzM wsE1WF/uscji5nVZF2TsNa5IwJ3OjTURXZtiLBy8LV9TLRWFi6+8Du8/FBtnnB6XGA PA7X4/t1omvOXzpWNfa3FZYKe9s2ZZrBoAEAoWnRlbJPpivh2cc0uknEZOadf+yoG1 7sWljv8adYqiB1fQ3TrXTtpiMMs3mWiqBw40N1Dy2ovkiGrDtPWMqITsGuUXgRFjv9 8/6hUtj3KmYkg== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 073BA1204EE; Thu, 25 Aug 2022 08:47:55 -0400 (EDT) From: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "Wed, 24 Aug 2022 22:06:53 -0400") Message-ID: References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> Date: Thu, 25 Aug 2022 08:47:54 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Here's a new version of the patch, which addresses Stefan's feedback. > > Thanks. One question, tho: > >> @@ -1643,7 +1643,10 @@ elisp--eval-defun >> ;; FIXME: the print-length/level bindings should only be applied while >> ;; printing, not while evaluating. >> (defvar elisp--eval-defun-result) >> + ;; FIXME: This Edebug dependency is undesirable. See bug#50245 >> + (defvar edebug-all-defs) >> (let ((debug-on-error eval-expression-debug-on-error) >> + (edebugging edebug-all-defs) >> elisp--eval-defun-result) >> (save-excursion >> ;; Arrange for eval-region to "read" the (possibly) altered form. > > What makes us think that `edebug-all-defs` will always be defined when > we get here? Doesn't this code signal an error if called before > edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by > a plain `C-M-x`)? IOW, I'd remove the `defvar` and use (bound-and-true-p edebug-all-defs) instead. Stefan From unknown Mon Aug 18 17:53:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50245: 28.0.50; Instrumenting a function does not show "Edebug:" in the echo area Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Aug 2022 13:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 50245@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= Received: via spool by 50245-submit@debbugs.gnu.org id=B50245.166143322029446 (code B ref 50245); Thu, 25 Aug 2022 13:14:01 +0000 Received: (at 50245) by debbugs.gnu.org; 25 Aug 2022 13:13:40 +0000 Received: from localhost ([127.0.0.1]:49434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCfz-0007er-JH for submit@debbugs.gnu.org; Thu, 25 Aug 2022 09:13:40 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:53260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRCfu-0007eZ-Ch for 50245@debbugs.gnu.org; Thu, 25 Aug 2022 09:13:38 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 76EDC8076B; Thu, 25 Aug 2022 09:13:28 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1FF988043C; Thu, 25 Aug 2022 09:13:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661433207; bh=JBtwNjH7oivZB7PbaMNhkvn/O6tWJwHZxBl3BqPh6tg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HW4gFdIJ6XecOWgvaVunOVAtlKKwyioq90DtaQ5TFZP+bGnMPBvy5baLL7EK3Km5L RPXwOXgQfIoutIjWKM6IHx0GO/b0e78DnLKzgCf1zcmJvFA4XqpTk4jqLmNQUNAvFp i6X/79is0KtiWJzG2G43iHax30twpOmU/OnHa1R3CP84b56QG+Prd008gPBNPl/ZPE G88RhYYPKmziWPEywsKnKwlVygP+zMYQKCT34tMBXZPfMPLV+yoYGD3oYKoZzhuGlv kiunCXkH/FtczcEVmnX235jeFG664LVUicZilHsxj+RgVKDL7y7YRbqwGb8cCXNmdF 8qo0P13rc++tA== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC0B71204ED; Thu, 25 Aug 2022 09:13:26 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87v8qgjy6i.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 25 Aug 2022 14:38:13 +0200") Message-ID: References: <87r1ecdobe.fsf@gnus.org> <87o7wc2spo.fsf@gnus.org> <87v8qgjy6i.fsf@gnus.org> Date: Thu, 25 Aug 2022 09:13:25 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2022-08-25 14:38:13] wrote: > Stefan Monnier writes: >> What makes us think that `edebug-all-defs` will always be defined when >> we get here? Doesn't this code signal an error if called before >> edebug.el is loaded (e.g. in the case of `emacs -Q` soon followed by >> a plain `C-M-x`)? > edebug-all-defs is autoloaded, so it's safe to use here (and the (defvar > isn't needed, so I removed it). Ah, even better, Stefan