GNU bug report logs - #50244
28.0.50; Support project-wide diagnostics reports in flymake.el

Previous Next

Full log

Message #32 received at 50244 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 50244 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#50244: 28.0.50; Support project-wide diagnostics reports in
 flymake.el
Date: Mon, 13 Sep 2021 21:04:01 +0100

Theodor Thornhill <theo <at> thornhill.no> writes:

> I will absolutely jump at this as quickly as possible.  I'm not exactly
> sure how fast I'll be, since I'm on parental leave right now.

Congrats And enjoy it (I enjoyed mine very much)! > 

> How would you want to receive the changes to eglot?  As part of this
> bug, or as a new issue over at GH? I'm fine with either. Considering
> both flymake and eglot may be affected, maybe this bug is a good
> place?

Yes, it is (but the PR also works).  I hope to transfer eglot.el to
Emacs core soon anyway.  

Earlier you said project-wide diagnostics is become a trend with LSP
servers.  Besides your elm-language-server where you most need this,
what other servers are doing this?  Maybe I can install one of those for
a language I know and start testing this.

> diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
> index 83c0b4dd99..543cfe64f4 100644
> --- a/lisp/progmodes/flymake.el
> +++ b/lisp/progmodes/flymake.el
> @@ -815,8 +815,6 @@ calling convention described in
>  to handle a report even if TOKEN was not expected.  REGION is
>  a (BEG . END) pair of buffer positions indicating that this
>  report applies to that region."
> -  (unless state
> -    (error "Can't find state for %s in `flymake--state'" backend))
>    (cond
>     ((null state)
>      (flymake-error

Nice catch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.