GNU bug report logs - #50231
[PATCH] gnu: emacs-desktop-environment: Include runtime dependencies

Previous Next

To reply to this bug, email your comments to 50231 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reily Siegel <mail <at> reilysiegel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-desktop-environment: Include runtime dependencies
Date: Fri, 27 Aug 2021 14:36:56 -0400

* gnu/packages/emacs-xyz.scm (emacs-desktop-environment): Include runtime
dependencies.
---
 gnu/packages/emacs-xyz.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7672168a0e..ed18692b29 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -160,6 +160,7 @@
   #:use-module (gnu packages networking)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages suckless)
   #:use-module (gnu packages telephony)
   #:use-module (gnu packages terminals)
   #:use-module (gnu packages tex)
@@ -20259,6 +20260,14 @@ autosuggestions with:
         (base32
          "0s33jncjg8c2xlr90qjk1ishwmwxm9yg0z6n3kzilawcilpxidsh"))))
     (build-system emacs-build-system)
+    (propagated-inputs
+     `(("alsa-utils" ,alsa-utils)
+       ("brightnessctl" ,brightnessctl)
+       ("scrot" ,scrot)
+       ("slock" ,slock)
+       ("upower" ,upower)
+       ("tlp" ,tlp)
+       ("playerctl" ,playerctl)))
     (home-page "https://gitlab.petton.fr/DamienCassou/desktop-environment")
     (synopsis "Control your GNU/Linux desktop environment from Emacs")
     (description
-- 
2.32.0

Message #8 received at 50231 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Reily Siegel <mail <at> reilysiegel.com>
Cc: 50231 <at> debbugs.gnu.org
Subject: Re: [bug#50231] [PATCH] gnu: emacs-desktop-environment: Include
 runtime dependencies
Date: Mon, 06 Sep 2021 11:17:35 +0200

Hello,

Reily Siegel <mail <at> reilysiegel.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-desktop-environment): Include runtime
> dependencies.

Thank you.
> +    (propagated-inputs
> +     `(("alsa-utils" ,alsa-utils)
> +       ("brightnessctl" ,brightnessctl)
> +       ("scrot" ,scrot)
> +       ("slock" ,slock)
> +       ("upower" ,upower)
> +       ("tlp" ,tlp)
> +       ("playerctl" ,playerctl)))

I don't think we should propagate all of them. It's up to the user to
provide its own tools, which are not necessarily those.

WDYT?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 50231 <at> debbugs.gnu.org (full text, mbox):

From: Reily Siegel <mail <at> reilysiegel.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 50231 <at> debbugs.gnu.org
Subject: Re: [bug#50231] [PATCH] gnu: emacs-desktop-environment: Include
 runtime dependencies
Date: Tue, 07 Sep 2021 15:19:07 -0400

Hello,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> I don't think we should propagate all of them. It's up to the user to
> provide its own tools, which are not necessarily those.

The emacs package can be configured to use other tools. However, unless
the package is specifically configured otherwise, it will not work when
installed. Without either these propagated inputs or special
configuration, this package cannot perform any of its functions. Perhaps
these could be included in a separate output?

Reily Siegel

Message #14 received at 50231 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Reily Siegel <mail <at> reilysiegel.com>
Cc: 50231 <at> debbugs.gnu.org
Subject: Re: [bug#50231] [PATCH] gnu: emacs-desktop-environment: Include
 runtime dependencies
Date: Tue, 07 Sep 2021 22:15:59 +0200

Hello,

Reily Siegel <mail <at> reilysiegel.com> writes:

> The emacs package can be configured to use other tools. However, unless
> the package is specifically configured otherwise, it will not work when
> installed. Without either these propagated inputs or special
> configuration, this package cannot perform any of its functions. 

I know, but this Emacs library is not supposed to provide the features
itself. I assume you use it on top of installed executables, as
explained in the package description:

  The package depends on the availability of shell commands to do the
  hard work for us.

Pulling all of them from an Emacs package sounds backward.

> Perhaps these could be included in a separate output?

Outputs are distinct part of the package output. Here, propagated
executables are not part of the Emacs library, so the suggestion does
not hold.

Maybe Guix is missing a "suggested depedencies" flag, somehow.

Anyhow, I think the status quo is fine. WDY (and others) T?

Regards,
-- 
Nicolas Goaziou

Message #17 received at 50231 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, Reily Siegel
 <mail <at> reilysiegel.com>
Cc: 50231 <at> debbugs.gnu.org
Subject: Re: [bug#50231] [PATCH] gnu: emacs-desktop-environment: Include
 runtime dependencies
Date: Wed, 08 Sep 2021 11:33:32 +0200

Hi,

On Tue, 07 Sep 2021 at 22:15, Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:

>> The emacs package can be configured to use other tools. However, unless
>> the package is specifically configured otherwise, it will not work when
>> installed. Without either these propagated inputs or special
>> configuration, this package cannot perform any of its functions. 

Indeed.  However, “guix install emacs-foo” does not install the package
’emacs’, i.e., ’emacs-foo’ cannot perform any of its functions. ;-)

> I know, but this Emacs library is not supposed to provide the features
> itself. I assume you use it on top of installed executables, as
> explained in the package description:
>
>   The package depends on the availability of shell commands to do the
>   hard work for us.
>
> Pulling all of them from an Emacs package sounds backward.

On the other side, I remember discussions about ’git’ as inputs in
’emacs-magit’.  Or ’the-silver-searcher’ for ’emacs-ag’.  Maybe it is
worth to improve section about Emacs packages in the manual.  Rough
draft:

«The external tools required by the package are not included as inputs,
except if they are required at compile or test time.»

Well, I am sure someone will find a better wording. ;-)



> Maybe Guix is missing a "suggested depedencies" flag, somehow.

Yeah, maybe.

One way should to add a ’properties’ as ’suggest’.  Well, from my
experience with Debian, I am not convinced that this suggest field
really helps.  Maybe for discovery.

The easiest way is to provide a sentence in the ’description’ field
about such.

Cheers,
simon

Message #20 received at 50231 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: Reily Siegel <mail <at> reilysiegel.com>, 50231 <at> debbugs.gnu.org
Subject: Re: bug#50231: [PATCH] gnu: emacs-desktop-environment: Include
 runtime dependencies
Date: Fri, 24 Sep 2021 13:56:17 +0200

Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> Reily Siegel <mail <at> reilysiegel.com> writes:
>
>> The emacs package can be configured to use other tools. However, unless
>> the package is specifically configured otherwise, it will not work when
>> installed. Without either these propagated inputs or special
>> configuration, this package cannot perform any of its functions. 
>
> I know, but this Emacs library is not supposed to provide the features
> itself. I assume you use it on top of installed executables, as
> explained in the package description:
>
>   The package depends on the availability of shell commands to do the
>   hard work for us.
>
> Pulling all of them from an Emacs package sounds backward.

How about:

  1. Providing only those tools for which there’s no choice, like
     ‘alsa-utils’ and ‘brightnessclt’.

  2. Patching file names instead of propagating.

Thoughts?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.