GNU bug report logs - #50217
[PATCH] gnu: Add c2ffi-11.0.0.

Previous Next

Package: guix-patches;

Reported by: muradm <mail <at> muradm.net>

Date: Thu, 26 Aug 2021 21:08:02 UTC

Severity: normal

Tags: moreinfo, patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

Full log

Message #28 received at 50217 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Attila Lendvai <attila <at> lendvai.name>, 50217 <at> debbugs.gnu.org
Subject: Re: [bug#50217] [PATCH v4] gnu: Add c2ffi.
Date: Mon, 14 Feb 2022 16:34:14 +0100

[Message part 1 (text/plain, inline)]
Attila Lendvai schreef op ma 14-02-2022 om 13:31 [+0100]:
> +  (let ((git-tag "12.0.0.0"))
> +    (package
> +      (name "c2ffi")
> +      (home-page "https://github.com/rpav/c2ffi")
> +      (version (string-append "v" git-tag))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url home-page)
> +               (commit version)))

Isn't it the other way around?  Looking at the git repo, the git tag is
v12.0.0.0, not 12.0.0.0, and Guix strips version prefixes like "v", "V"
and "version-".  Also, IIUC, the current consensus is that home pages
and source git repos are separate things, even if sometimes their URL
coincides, so the URL may need to be copied into the 'url' field.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 3 years and 131 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.