From unknown Sat Jun 21 03:20:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50214 <50214@debbugs.gnu.org> To: bug#50214 <50214@debbugs.gnu.org> Subject: Status: 28.0.50; cl-struct changes may affect user packages in the wild Reply-To: bug#50214 <50214@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:20:48 +0000 retitle 50214 28.0.50; cl-struct changes may affect user packages in the wi= ld reassign 50214 emacs submitter 50214 Adam Porter severity 50214 normal tag 50214 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 26 12:47:28 2021 Received: (at submit) by debbugs.gnu.org; 26 Aug 2021 16:47:28 +0000 Received: from localhost ([127.0.0.1]:50266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIXH-00080n-V9 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 12:47:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:56872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJIXF-0007zA-V3 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 12:47:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJIXF-0003bE-Mb for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:47:25 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:40777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJIXD-0005rB-Sv for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 12:47:25 -0400 Received: by mail-lf1-f46.google.com with SMTP id bq28so8182773lfb.7 for ; Thu, 26 Aug 2021 09:47:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T+SMzDdJb4KVdmGg8AwvJAIDkHD8kmUP7VL1hbSgtwc=; b=Kc2l5VVvYUDVMpfhuIPp1FWP2Y+qKsSRMliW7bBwVjGfaqXJQSM1wTQRRiYcZfLvdh W7K/RN3evhrq5fvBqv9OrD6TiwbsQZ2ly9fYWbCXtWZ31IpoSNsh1faGfS2SlbWYLsJL hnoCkiq1bBZZGKQ1srGaSYC/SVbQztKcuXJN+g4OwxGsAjQpKCaQMo+PVPSboZMSIMgK 452TRB+evO4phbLhg5EcCfrTdU+LGZc59kF/WmY7djRq4BHn8IkbPlwMHCdcaZYau2dM To5s0Z7HZ9ZEl14P2J5y1k5WsVmR7VFwUPsS9Kdik5N8c771oDNCXI+3oL1qufCR9XME Ajcw== X-Gm-Message-State: AOAM532VgTS2bXqoTD1NLdOUYSAtDLzVuHn08xyDmX8Zp02u1s2w0Y3T Nfqh9T6vleRjsv6kKDhN6llf6Epak+zaU2nLd6fjzERq9Ns= X-Google-Smtp-Source: ABdhPJwvWvX6O90iJtIPKmOwssDC0CYjRyOFfpr3n6akTAH/cUe53EvoI1Mxufpg56U+A/zkUH+77QlKdF5xP2M3ZNg= X-Received: by 2002:a05:6512:398b:: with SMTP id j11mr3528799lfu.102.1629996440689; Thu, 26 Aug 2021 09:47:20 -0700 (PDT) MIME-Version: 1.0 From: Adam Porter Date: Thu, 26 Aug 2021 11:47:09 -0500 Message-ID: Subject: 28.0.50; cl-struct changes may affect user packages in the wild To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.167.46; envelope-from=alphadeltapapa@gmail.com; helo=mail-lf1-f46.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Hi, A helpful user of my ts.el package discovered a change in Emacs 28 that breaks it: https://github.com/alphapapa/ts.el/issues/18 Specifically, this commit changes the internal struct constructor from a plist to an alist: https://github.com/emacs-mirror/emacs/commit/3788d2237d4c65b67b95e33d1aca8d8b41780429 For example: ;; Emacs 28.0.50 (nth 1 (cl-struct-slot-info 'ts)) ;; => ;; (hour ;; nil ;; :type integer ;; (:accessor-init string-to-number ;; (format-time-string ;; "%H" ;; (ts-unix struct))) ;; (:aliases H) ;; (:constructor . "%H")) ;; Emacs 27.2.50 (nth 1 (cl-struct-slot-info 'ts)) ;; => ;; (hour ;; nil ;; :type integer ;; :accessor-init (string-to-number ;; (format-time-string ;; "%H" ;; (ts-unix struct))) ;; :aliases (H) ;; :constructor "%H") Unfortunately this breaks how ts.el works. Of course, that can be worked around with a version check, but that means that users who upgrade to Emacs 28 without upgrading ts.el will encounter failures. I don't know if this is something you'd want to reconsider. I guess there was a good reason for the changes being made. And maybe what ts.el is doing is considered unsupported, which would seem like a not-unreasonable position. Anyway, I'm reporting this so the issue is officially documented and any decisions can be made accordingly. Thanks, Adam From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 26 13:52:10 2021 Received: (at 50214) by debbugs.gnu.org; 26 Aug 2021 17:52:10 +0000 Received: from localhost ([127.0.0.1]:50386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJJXf-0003qh-1P for submit@debbugs.gnu.org; Thu, 26 Aug 2021 13:52:10 -0400 Received: from mail-am6eur05olkn2083.outbound.protection.outlook.com ([40.92.91.83]:13601 helo=EUR05-AM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJJXX-0003qN-Qa for 50214@debbugs.gnu.org; Thu, 26 Aug 2021 13:51:54 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZMpmeMfx+z+wOGwhLTEJ/HDtsFjAtM5/LKvCBGQPxD3sW/Y1536HmT75Zgi4wCCKoi/i8o4104ZiUlmvHtW9ylnHm+JWEs+PYLBXNHefzN8Hm8xsetJTEUHoWOPvmTbtk32smqVCcWvHJl078WHuvHJsy8CYoiQJAvrqvYp64SG1TvQvZUQcx/ah/ceMcH+H0w1Kcb1JDmDSHaEB0ON+sESjwozuPO9Iw0e1aAZgO4HWwECkU+t5YSCvc0v/+Jg30sMalQ2m0yXZxPSwac53zi5hC5tzKB3lRNXqepBEJuaP4MoOGTIkol4dCMx0kN8gBMIwH/mp5oBjKtpryg9+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4TEfX1Vq8HV0aeePO8fZpu02W3ZVbRL9l5rQxLWj7tA=; b=Q1+EnO4iHhJyyFhjNRexp06xCjz7fmxvJ1ifTD9CHSCuSopOsUyJcOuMiZiNk6MmnF9yqkeI21bX3Kl8LFLCbC0MwE38PVLryHgcfWfsR4hjHiEa+syUSPzbKpK6qzghoez5xqkAOB6iiuHRQ6OuiquPtAjbNKH5d8rnSTjz1r8BXC9izOfilhmpPCuDd6rhdggc5qr/KMFamIddU/ZQpfD7yxNw8h86U4cn5tiquvX5/9eablmEMPPTnNSwkeu7dpQGxrx19lB3JIAGOHIhu87liJxxmOsXr0dGlvG+npJs2f7mOrNS2++8TEhocGdt4LuELQ+BSXdI1s6pzv3ZlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4TEfX1Vq8HV0aeePO8fZpu02W3ZVbRL9l5rQxLWj7tA=; b=f7/HZXluFpPab0i78cZBRw/gLFTKR9Sp+H067jWbKeyGuqtQkzEl9GvwTSVAOBjlMmFPSgNKNI7KYlH+EkwQgXWfdT9SxpM9+xyboegu0d727Aj2wlIQNo6K8+02lnfLwD2WR7fvS2Aep8vaBkHwbVKagtYlSgcgCFo5qtZ0UcBovNGqxta3lodbTq6wiP8Of3COIisJB6+ofVZsFe+7UqQbJlJH8kOey0ecNDp6QJpH5EW+LQLfXJ6gvvNXVL2OW9MWbE+zGpKkgs9XFaf+b4EHqBieqXKVyDx0Er7ZJVKY3fPA2Nyy5LfkSGqh21ag6KG/fa2BKJ/uJdCDYlinIg== Received: from DB8EUR05FT024.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::47) by DB8EUR05HT073.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 26 Aug 2021 17:50:40 +0000 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com (2a01:111:e400:fc0f::50) by DB8EUR05FT024.mail.protection.outlook.com (2a01:111:e400:fc0f::447) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Thu, 26 Aug 2021 17:50:40 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:97047A169A7C3DBA0DACDD62C46206FCE5195FCB63E24C1F39ECC3B16681267C; UpperCasedChecksum:45A6590522B51282F6343ED202F6E75599298582D3FC57DDD785DD22F6E867B2; SizeAsReceived:7497; Count:46 Received: from AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::b483:471e:6dc2:12ae]) by AM9PR09MB4977.eurprd09.prod.outlook.com ([fe80::b483:471e:6dc2:12ae%9]) with mapi id 15.20.4436.025; Thu, 26 Aug 2021 17:50:40 +0000 From: Arthur Miller To: Adam Porter Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild References: Date: Thu, 26 Aug 2021 19:50:38 +0200 In-Reply-To: (Adam Porter's message of "Thu, 26 Aug 2021 11:47:09 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-TMN: [FZxb1aCDtfKYR+o3D7BSzrJw2KwVAPBd] X-ClientProxiedBy: BE0P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::12) To AM9PR09MB4977.eurprd09.prod.outlook.com (2603:10a6:20b:304::20) X-Microsoft-Original-Message-ID: <875yvs5c41.fsf@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pascal.homepc (81.232.177.30) by BE0P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:14::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.6 via Frontend Transport; Thu, 26 Aug 2021 17:50:39 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: b7bd6da8-898f-4c1d-f4e7-08d968ba0463 X-MS-TrafficTypeDiagnostic: DB8EUR05HT073: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tpimfXyGVPoMXNU4t6F4xWDan5QJOAdU4asoqjAFqj7hE0Czfnw2oRvj9iyiGQlvPMYIlUY7VhitEuGEunDvhuO9qgmGkyICHbT0oGU47ZsywR52k0i3a4C3Ib449KV6sJFNThA37POTmZI5OYy7A4V2sRNYIBFrCTpL+DWTV8vZ6amGWBorfQ6T1hIKMUN9FbbvGJwEWlSPyyBsZ/0PIitwxVs/B/SFlrpObgrMXEj01WZ79muM0PW9NGLoLYwt9vpOJPy7g9/gESA8XACazuWnaUWFSV0KhAae0l8SnICjIvD345et9QKLzfGoV34q7Jv296SHQQ/c3+jUW5ySZkRZLJGmHxhQ7tfU/oEMAInPEUxDnNFOdxLhU/xHMJkXDQPigcX4wHeoDnXJfwtOP+8Zk1Fg/U6xHoG6apbvvJCaZ5l3norkDvuEVQIq1qBn2QwFYMEMZyVNS8c2QxaLKQx7bpoV4glAyfLnSlIi9W0= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xZ0A4Sm/v+YoTy0pCDjWqupVdfBqs+lcZgTUmlc4dgQjiejSyXWpFpnL0UD85uc3FOyufFQXLHPz9GNsjQVFbRJSEOleC6/utsQTmg+Aq3nYLSFiLe0sqsitcATXcyTbVf3AlhAznwcxDzhsJHtHHw== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7bd6da8-898f-4c1d-f4e7-08d968ba0463 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 17:50:39.9717 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT024.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR05HT073 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50214 Cc: 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Adam Porter writes: > Hi, > > A helpful user of my ts.el package discovered a change in Emacs 28 > that breaks it: > > https://github.com/alphapapa/ts.el/issues/18 > > Specifically, this commit changes the internal struct constructor from > a plist to an alist: > > https://github.com/emacs-mirror/emacs/commit/3788d2237d4c65b67b95e33d1aca8d8b41780429 > > For example: > > ;; Emacs 28.0.50 > (nth 1 (cl-struct-slot-info 'ts)) > ;; => > ;; (hour > ;; nil > ;; :type integer > ;; (:accessor-init string-to-number > ;; (format-time-string > ;; "%H" > ;; (ts-unix struct))) > ;; (:aliases H) > ;; (:constructor . "%H")) > > ;; Emacs 27.2.50 > (nth 1 (cl-struct-slot-info 'ts)) > ;; => > ;; (hour > ;; nil > ;; :type integer > ;; :accessor-init (string-to-number > ;; (format-time-string > ;; "%H" > ;; (ts-unix struct))) > ;; :aliases (H) > ;; :constructor "%H") > > Unfortunately this breaks how ts.el works. Of course, that can be > worked around with a version check, but that means that users who > upgrade to Emacs 28 without upgrading ts.el will encounter failures. > > I don't know if this is something you'd want to reconsider. I guess > there was a good reason for the changes being made. And maybe what > ts.el is doing is considered unsupported, which would seem like a > not-unreasonable position. > > Anyway, I'm reporting this so the issue is officially documented and > any decisions can be made accordingly. > > Thanks, > Adam So what do we learn for the future? Don't use internal representation in your apps, it is internal for a reason? :) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 26 15:37:16 2021 Received: (at 50214) by debbugs.gnu.org; 26 Aug 2021 19:37:16 +0000 Received: from localhost ([127.0.0.1]:50543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJLBc-0004br-90 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 15:37:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJLBa-0004bb-VU for 50214@debbugs.gnu.org; Thu, 26 Aug 2021 15:37:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BBsr6NAseouQxwyGEMSZxBMggtTJk5aV/Ad3bg+Iys4=; b=J/wA35Ablyo7U1E/IidQxwpZG/ dKnwos/3LiMOcu07O+rKzyrUNhgFyvze6fcHRlPwYuT71fLJu0p/eSgITlejvT2K54WDE9HfQ13zX 7bNhu6g33z9gFZEqxQIEYAIbJy7S9NBTzYrkgMEc4y7K9VeXAC3QcD7vPQodBFE25IWI=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJLBQ-0005IV-6G; Thu, 26 Aug 2021 21:37:08 +0200 From: Lars Ingebrigtsen To: Adam Porter Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild References: Date: Thu, 26 Aug 2021 21:37:03 +0200 In-Reply-To: (Adam Porter's message of "Thu, 26 Aug 2021 11:47:09 -0500") Message-ID: <87y28ot2u8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Adam Porter writes: > A helpful user of my ts.el package discovered a change in Emacs 28 > that breaks it: > > https://github.com/alphapapa/ts.el/issues/18 > > Specifically, this commit changes the internal struct constr [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50214 Cc: 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Adam Porter writes: > A helpful user of my ts.el package discovered a change in Emacs 28 > that breaks it: > > https://github.com/alphapapa/ts.el/issues/18 > > Specifically, this commit changes the internal struct constructor from > a plist to an alist: [...] > I don't know if this is something you'd want to reconsider. I guess > there was a good reason for the changes being made. And maybe what > ts.el is doing is considered unsupported, which would seem like a > not-unreasonable position. I'm not very familiar with the internals of cl-struct, but if I understand correctly, I think this is... well... an internal thing that package writers should expect to change, so they shouldn't rely on things like this. But I've added Stefan to the CCs; perhaps he has some comments. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 26 16:52:50 2021 Received: (at 50214) by debbugs.gnu.org; 26 Aug 2021 20:52:50 +0000 Received: from localhost ([127.0.0.1]:50605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJMMk-0000DL-93 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 16:52:50 -0400 Received: from mail-lf1-f54.google.com ([209.85.167.54]:45820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJMMh-0000D3-Om for 50214@debbugs.gnu.org; Thu, 26 Aug 2021 16:52:48 -0400 Received: by mail-lf1-f54.google.com with SMTP id g13so9561311lfj.12 for <50214@debbugs.gnu.org>; Thu, 26 Aug 2021 13:52:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i9SYoKokJAt4KDXmdwBf/GmmPujPgiRkj5srJV1y06g=; b=YOq6iy6+W1eFicXnDCHxFbwczyHkBcHAHsKDKOu4/ZusYiCM5+uI8VkjuBgVuA1LSx D38PDQnHgFSD6EK61fKHGbJFOPfNqutVeyogI81bDY23MKGHcqxXHE0kYoZJQNL4B7pI xVNBmBu2RPvHqFlpNxKGr3dkfM5oQueEJ6dP29IMhBU2qnb0WvOcNNnxEJGW/uZAGMPg OuWQfWFDJeEkjxPqiOxxmsNkvNpl4TtGYrNVg39NOkwGk+lMRhQd/zda1NB7nO1lqSKB BML3K1mPEAejP9OjMn5/5kStMzIGv+xUt+OlPsRVuU+Llok4TAwVPToxuOVRfAMtqo6n dYJg== X-Gm-Message-State: AOAM533C56L4daVJ9WyThuBCEYI3v3K15lTi1yUtQotQf5qw1Wv2iPC6 QhcP6jj0G9wDOV2ZBhkpgFvcwGMQVEPmlEG5x5Q= X-Google-Smtp-Source: ABdhPJzB3suDBFjhZFp/3spMtU56Yy62pQxrp4HHYfu0hzqEkEgC7pAtbz3cp4lrh5p3yrfE9Ry7YqCqWmQQRjG94Dc= X-Received: by 2002:ac2:4146:: with SMTP id c6mr4464868lfi.305.1630011161368; Thu, 26 Aug 2021 13:52:41 -0700 (PDT) MIME-Version: 1.0 References: <87y28ot2u8.fsf@gnus.org> In-Reply-To: <87y28ot2u8.fsf@gnus.org> From: Adam Porter Date: Thu, 26 Aug 2021 15:52:30 -0500 Message-ID: Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50214 Cc: 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Aug 26, 2021 at 2:37 PM Lars Ingebrigtsen wrote: > > I'm not very familiar with the internals of cl-struct, but if I > understand correctly, I think this is... well... an internal thing > that package writers should expect to change, so they shouldn't rely on > things like this. Unfortunately, I know of no other way to implement what ts.el does without modifying the accessors, which requires accessing the internal struct details after it is defined. Unless I've missed something, or something has changed, of course. Regardless, the library's been working well for the almost 3 years since I wrote it, and it's used in various packages now, even including a few not my own. :) Anyway, if I have to add an Emacs-version check, that's not a big deal. I'll just have to answer the inevitable "I upgraded to Emacs 28 and your package doesn't work anymore" reports. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 04 13:37:27 2021 Received: (at 50214) by debbugs.gnu.org; 4 Sep 2021 17:37:27 +0000 Received: from localhost ([127.0.0.1]:48532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMZba-0002hp-SS for submit@debbugs.gnu.org; Sat, 04 Sep 2021 13:37:27 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:34578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMZbZ-0002hc-Is for 50214@debbugs.gnu.org; Sat, 04 Sep 2021 13:37:25 -0400 Received: by mail-wm1-f42.google.com with SMTP id v20-20020a1cf714000000b002e71f4d2026so1342046wmh.1 for <50214@debbugs.gnu.org>; Sat, 04 Sep 2021 10:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=F9gDjUSX9Jd993ylq4Wok60Y50nVMnUUa58WBoyEu+A=; b=EnsPWPswP1+TFWwev+iK8b0P7e26xInmJnG+41+hmJCbZakSBJoYyCpVQBl8LhOo2a gZfGt/LulylSlRytuzSrkCQ4jEfKJTqOXbsevmUvvGZJrcXrcCdMswXTV9CpbjJGb3kY oHa/TcZluNsHLJtjx07sfv581eP4QtYIXofyriVKfeU8GS429z7V/1If2IKGRb5dFFlh PKq3KbgFeSfoEQTpt6uTAA1Na0MzZiuFkxcUOPCdjD6Gec//YiyB268q07ii547ZpjTo b5DparW4mXxW5QiBory5bKf6uxIaWWlxa1+IiR6ao/oQRkt+dOgTo08eUwPBIMHsFGks 797A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=F9gDjUSX9Jd993ylq4Wok60Y50nVMnUUa58WBoyEu+A=; b=PLT/fCn8dfIkx2F34dQur0E4HDPmBljXmkXMmB2HlSoviSTcrqSJ/JpGq7NZlBmLrX A2nysinEWdL6vs5nQNVLgBO24YF6t7G8+Uniq0TyF84DMAY689TM0BEeuoS8puHoBRfo f/Fp8EvnLVkNy4qyJueKyIxBpm9Qfk7bTNs5TmZyR35GwKrzQzXYMjnjLF7lnk/CeH22 y/5Gfg/A5q2G4DXrVN417FshI0ZCPVX2xOGNYEGQ2frK+ju2Azr0MwqL+Mosn09HTUEX BDpeBXC1X1ocEKAM7SkhBB4/OvuJN2ht7/lhHdd2lD7at+stH3T0X8nD/wz6p32DZQ0u LKwA== X-Gm-Message-State: AOAM530nMwy/H7NBDWsdgR3CrtIhfXWdgvCKeliLUuGEaYBsdXKntg29 ro5w+tCHcQHNKzZC9HKvVcc= X-Google-Smtp-Source: ABdhPJw7Wdu7z7bHQSvM3GP2HQ/573QG47ZKYzNGblgpCI/0kDVxdYMikppZmKhjbrv6kxNpYzLG7w== X-Received: by 2002:a7b:cb44:: with SMTP id v4mr3925430wmj.169.1630777039517; Sat, 04 Sep 2021 10:37:19 -0700 (PDT) Received: from smtpclient.apple ([46.128.209.111]) by smtp.gmail.com with ESMTPSA id w9sm2742776wrs.7.2021.09.04.10.37.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Sep 2021 10:37:18 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild From: Philipp In-Reply-To: Date: Sat, 4 Sep 2021 19:37:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> References: <87y28ot2u8.fsf@gnus.org> To: Adam Porter X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 50214 Cc: Lars Ingebrigtsen , 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) > Am 26.08.2021 um 22:52 schrieb Adam Porter : >=20 > On Thu, Aug 26, 2021 at 2:37 PM Lars Ingebrigtsen = wrote: >>=20 >> I'm not very familiar with the internals of cl-struct, but if I >> understand correctly, I think this is... well... an internal thing >> that package writers should expect to change, so they shouldn't rely = on >> things like this. >=20 > Unfortunately, I know of no other way to implement what ts.el does > without modifying the accessors, which requires accessing the internal > struct details after it is defined. I haven't checked the code in detail, but AIUI ts.el tries to initialize = structure members lazily? Why not just use a wrapper function for that? (defun ts-hour (ts) (or (ts--hour ts) (setf (ts--hour ts) (string-to-number (format-time-string "%H" = (ts-unix ts))))) Here ts--hour is the actual accessor, which is private and shouldn't be = used outside of ts.el. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:35:44 2022 Received: (at 50214) by debbugs.gnu.org; 22 Aug 2022 14:35:44 +0000 Received: from localhost ([127.0.0.1]:41427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wm-0000MI-Hq for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wk-0000M3-RV for 50214@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U8bm9hV612jhufmHG28G+yiuqZHhI5MqEai1Jxrwd4Y=; b=dHROoWaAxIYY2nfqibPQ9Evhj2 8piuJg8bLymzO0wU5QHK2z5MSLGrI2go83IYDj+knhr/rvezQ0Z/0d17h2lpHDIiB5VJrvn75S1IP JEaZAqORL+wqSgMlpcMS5f+iRjV44TUYOW9KWuKASEIjxclowpy9Bg/4GgXQfkBCMPSM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8Wb-0006Mk-3P; Mon, 22 Aug 2022 16:35:35 +0200 From: Lars Ingebrigtsen To: Philipp Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild In-Reply-To: <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> (Philipp's message of "Sat, 4 Sep 2021 19:37:18 +0200") References: <87y28ot2u8.fsf@gnus.org> <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> X-Now-Playing: Jorja Smith's _Blue Note Re:imagined (1)_: "Rose Rouge" Date: Mon, 22 Aug 2022 16:35:30 +0200 Message-ID: <87ilmk4a8d.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philipp writes: >> Unfortunately, I know of no other way to implement what ts.el does >> without modifying the accessors, which requires accessing the internal >> struct details after it is defined. > > I haven't che [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50214 Cc: Adam Porter , 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philipp writes: >> Unfortunately, I know of no other way to implement what ts.el does >> without modifying the accessors, which requires accessing the internal >> struct details after it is defined. > > I haven't checked the code in detail, but AIUI ts.el tries to initialize structure members lazily? Why not just use a wrapper function for that? > > (defun ts-hour (ts) > (or (ts--hour ts) > (setf (ts--hour ts) (string-to-number (format-time-string "%H" (ts-unix ts))))) > > Here ts--hour is the actual accessor, which is private and shouldn't be used outside of ts.el. Adam, does this suggestion work for you? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 10:35:48 2022 Received: (at control) by debbugs.gnu.org; 22 Aug 2022 14:35:48 +0000 Received: from localhost ([127.0.0.1]:41430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wp-0000MX-PL for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8Wo-0000M7-10 for control@debbugs.gnu.org; Mon, 22 Aug 2022 10:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fAkcWP1i+zy3KTFOxC0WnZF3R5CqjuKeQFlTwyqp/6M=; b=m58Ws/Pj9/pFgdz3lc5/clPV58 l3wZVCh+225vlw1pDZBaSqdPoLYa9vUx7OvuNabivmoWOxSGzfkfSD7hrTK5sExaG/uwveB57pjYX z6cpPrkcpF8XkyzEQyF4ZP9/lzMrauV/B/LrU2nAaWVns1j8A9zKDftS57OT4NmMZdyc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8Wg-0006Mv-Bn for control@debbugs.gnu.org; Mon, 22 Aug 2022 16:35:40 +0200 Date: Mon, 22 Aug 2022 16:35:37 +0200 Message-Id: <87h7244a86.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50214 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 50214 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 50214 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 17:24:40 2022 Received: (at 50214) by debbugs.gnu.org; 22 Aug 2022 21:24:40 +0000 Received: from localhost ([127.0.0.1]:41941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEuW-0007DK-3f for submit@debbugs.gnu.org; Mon, 22 Aug 2022 17:24:40 -0400 Received: from poodle.tulip.relay.mailchannels.net ([23.83.218.249]:5331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEuM-0007D1-Pd for 50214@debbugs.gnu.org; Mon, 22 Aug 2022 17:24:39 -0400 X-Sender-Id: dreamhost|x-authsender|inbox@alphapapa.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0686A4C1AA6; Mon, 22 Aug 2022 21:24:27 +0000 (UTC) Received: from pdx1-sub0-mail-a291.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7847A4C1D90; Mon, 22 Aug 2022 21:24:26 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1661203466; a=rsa-sha256; cv=none; b=pYTZXF9boHPr9OXZNl8eESMaZLHDO4H7ry8xeGj4EYwZ6kVkrNfQdlNagx6oXIkxmwqC8v BYABTUz4+8/7+I+u+HVFNw4WqK0FSB5IVU9Tjm09GYBUKGrCT44OGhxirnKMuFBIwXvKlW E5erz3gIE/PmwuWa0EXeob4WJUvLXX4NXIo3Yi63X8yCg+pTDGCT3iChbA/MpxZmUejDHw pxurUFAITrNBCPsLw6PuVoFRXIE0bEP0b+vdIiTxv/sebC4EH0HpKzXjVBT30g1RvcpPFw MHW6Cu3E+Rjz9ys5zulZvABET76OYUv/roC/t4ZLTMWMrRtitTHnTnyO89IJCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1661203466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVSXIQKo6YxP+bTstNX7V9lqmKHyjKhlXD9u7O8h28Y=; b=pXH7njtQgRyR9PDpQRP8MaZOC4I6nf74wGyk7mdfG/p7W9kjDYdKAX7h67zFARlf6mLta8 3ydrHab1jfXBP8aXllNDnWRbPJO3/i3nvL1H8B/hC5nEhPhtZse3tHh4AVMMYMBbOT1ImL BzB8fIGMxc+26uugP/mXu/AHRqSDHwIiqTtSxZrWTtBtvyAGOcq24d7m5kZqP8rI+zir2y novFT+mDew3B3+Zc5uL0RXt4kPourIt+1TEjY92OdJh1XDoeo1hyAwTcym1gSA8aVsbPIc vXsL6JIU4gyHH3CeEnsj3s1z1End73tp9cVNyxHs3s3OL6c+g0naufgbEr/BIg== ARC-Authentication-Results: i=1; rspamd-79945fd77c-b4gsd; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|inbox@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|inbox@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Tasty-Supply: 373011f30bd686f3_1661203466835_2921339402 X-MC-Loop-Signature: 1661203466835:1981257489 X-MC-Ingress-Time: 1661203466835 Received: from pdx1-sub0-mail-a291.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.55.195 (trex/6.7.1); Mon, 22 Aug 2022 21:24:26 +0000 Received: from [10.12.0.110] (unknown [154.6.28.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: inbox@alphapapa.net) by pdx1-sub0-mail-a291.dreamhost.com (Postfix) with ESMTPSA id 4MBQNT5Qxnz2S; Mon, 22 Aug 2022 14:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1661203466; bh=aVSXIQKo6YxP+bTstNX7V9lqmKHyjKhlXD9u7O8h28Y=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=QA7gPlTfProRRmIAZnV3S3OnDGWT+aEvTnEMNwK/SDabFSz241OeAnKIzP6WOBEhT c2P9+9DqdyZ+Apl4VJHxKKmNtKuMn/yalRZSa8ZixZcVssgBLVeXH/FZXUNsHQsD6M gZzfElMNn9SdUyRPgZaEhv76yelzufsQAeS85ZQJ2ZOVU/96pywgcBl6WhP+AO3nna j2q7il6STfyyNjje16pVQ2+2iJyFJhA/pw+kJ4mKd1mT78ISvw6vCukO1vsGZp/q1y ly3Z5oOquAzFcUen71Sbeej3IXMqeJ828sOLGW4L2lSFh9j/KpNALLk/chCE5qyWoL tCvFicaNLWDWg== Message-ID: <14be763f-95f6-23c2-7f92-8e4eacb30de4@alphapapa.net> Date: Mon, 22 Aug 2022 16:24:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild Content-Language: en-US To: Lars Ingebrigtsen , Philipp References: <87y28ot2u8.fsf@gnus.org> <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> <87ilmk4a8d.fsf@gnus.org> From: Adam Porter In-Reply-To: <87ilmk4a8d.fsf@gnus.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 50214 Cc: 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi Lars, Thanks for following up on this report. On 8/22/22 09:35, Lars Ingebrigtsen wrote: > Philipp writes: > >>> Unfortunately, I know of no other way to implement what ts.el does >>> without modifying the accessors, which requires accessing the internal >>> struct details after it is defined. >> >> I haven't checked the code in detail, but AIUI ts.el tries to initialize structure members lazily? Why not just use a wrapper function for that? >> >> (defun ts-hour (ts) >> (or (ts--hour ts) >> (setf (ts--hour ts) (string-to-number (format-time-string "%H" (ts-unix ts))))) >> >> Here ts--hour is the actual accessor, which is private and shouldn't be used outside of ts.el. > > Adam, does this suggestion work for you? That seems like a good idea to me. I guess if I define it as an inline function, it should have a similar optimization as the current code. And the implementation would be much simpler and future-proof as well. In hindsight, I should probably have tried that first. :) I'll see if I can implement this in ts.el soon and release a new version accordingly. In the meantime, I guess this bug report should be closed. Thanks to all for your help. Adam From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 06:08:39 2022 Received: (at 50214) by debbugs.gnu.org; 23 Aug 2022 10:08:40 +0000 Received: from localhost ([127.0.0.1]:42682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQpr-0005gX-LV for submit@debbugs.gnu.org; Tue, 23 Aug 2022 06:08:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQpp-0005gF-Hw for 50214@debbugs.gnu.org; Tue, 23 Aug 2022 06:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xjWhQcM5uHy+4vTrNcZEIXPQNt0/xzdtZ1X1VBbZO3Q=; b=Olhi76x5EwKQhKaft6zdCNH14l dT/cyKGhY4+fyhruAlpQFoNzNTtNMgyw2stQVjRF0wwwkY129dpe8rrZP+NQ/Mhx4tmhkW7SsDbcI r7VnePgFhUBhaBwIrPMonYhOJMObs8Q2Mxnob0tl3SPrQ37e9tRs+P8z5PX5god/fgEM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQQpg-0007Gg-51; Tue, 23 Aug 2022 12:08:30 +0200 From: Lars Ingebrigtsen To: Adam Porter Subject: Re: bug#50214: 28.0.50; cl-struct changes may affect user packages in the wild In-Reply-To: <14be763f-95f6-23c2-7f92-8e4eacb30de4@alphapapa.net> (Adam Porter's message of "Mon, 22 Aug 2022 16:24:24 -0500") References: <87y28ot2u8.fsf@gnus.org> <24A8FD47-339C-4E1D-9F32-BFE97C60C0B6@gmail.com> <87ilmk4a8d.fsf@gnus.org> <14be763f-95f6-23c2-7f92-8e4eacb30de4@alphapapa.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEXaZTP7lUnrWBDM NAWjJAV7EgL72cL///8JScQPAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YIFwoIDtOBVAEAAAGBSURB VDjLlZPbbcMwDEWZxwBOAuTboTwBqQGKSt4gGSAokP1HKB+iLaftRy9iOdIxSZGUAFQn14CwGxBx 1H+9sFNb2tskkTzMjPKA/JZPuRPUwr8KqikvOD5sQCQLMuRa30HNbehAXimXNcZ8r70OAe7zY40j QcJiXkEhLmXaU2rgEa4oUS4TpQA1QEmUavKqMDzE4jg7sDXyyoAGGMIXYi4ewvIoDj7VhNWEIsHh qEnSVEh8iVmAfDn6pgqSAW2Mgo8vKwZLORAn24KDcrEtpaxBJiuigwpScPk428DE1vPIjpHUjDO1 w6CLWi2ZW6AFAHg3iMnLuoKWNSfvUQpw8B5KIxz4OSIATc7PQFk8JbWoDbRm4wZwbmcjQgswT5zq dllAdtD56RKUFdukpEI9WNqpzmgtSTHf3GdnoFjQ0bvQxWhB7e68A7UHT2vRLW7ZqLdwPHdgH6Y6 O2GMt81tvp3Ouq4jxt1Xwc5eZyM92Aher3VyfT2vHfip519A9X/wDbU84Ai1SWu2AAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIyLTA4LTIzVDEwOjA4OjE0KzAwOjAwYKQTzQAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMi0wOC0yM1QxMDowODoxNCswMDowMBH5q3EAAAAASUVORK5CYII= X-Now-Playing: David Allred's _Smells Like Everyone's Watching_: "Borderline Art" Date: Tue, 23 Aug 2022 12:08:27 +0200 Message-ID: <87lerftgpw.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Adam Porter writes: > I'll see if I can implement this in ts.el soon and release a new > version accordingly. In the meantime, I guess this bug report should > be closed. Thanks to all for your help. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50214 Cc: Philipp , 50214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Adam Porter writes: > I'll see if I can implement this in ts.el soon and release a new > version accordingly. In the meantime, I guess this bug report should > be closed. Thanks to all for your help. No problem; closing this bug report, then. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 06:08:49 2022 Received: (at control) by debbugs.gnu.org; 23 Aug 2022 10:08:49 +0000 Received: from localhost ([127.0.0.1]:42685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQq0-0005gt-VE for submit@debbugs.gnu.org; Tue, 23 Aug 2022 06:08:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQq0-0005gg-0A for control@debbugs.gnu.org; Tue, 23 Aug 2022 06:08:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/93vBGz8B9DzGKkCIr0Tp/MTP7AR7oqCSuD+lWDqr3o=; b=pN/TLIohilUdT9LSSv4OSz8scj 9pTM0LyU+xDRBZoDQ0K7d5srvDjuy4nkKrW4RJSDAljh29fjJNxeAE+vnTMJA6lJBJOz0esvs/eqG 2mK8obuvUTyu6kzq+iv21b5GqcY9D5nlJO+HQDISdxxT+BxrKr53iDcUlcv4WkacIppk=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQQps-0007Gt-3O for control@debbugs.gnu.org; Tue, 23 Aug 2022 12:08:42 +0200 Date: Tue, 23 Aug 2022 12:08:39 +0200 Message-Id: <87k06ztgpk.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50214 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 50214 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 50214 quit From unknown Sat Jun 21 03:20:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Sep 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator