Subject: bug#50204: "Success" seen in failed copy message

From: 積丹尼 Dan Jacobson <[email-masked]>
Date: Fri, 27 Aug 2021 00:53:04 +0800

>>>>> "EZ" == Eli Zaretskii <[email-masked]> writes:
>> I did
>> $ ln -s ~/mapping/aiyongxian/aiyongxian.kml /tmp/
>> 
>> Then in emacs I did
>> C			 ;; dired-do-copy
>> Overwrite ‘/tmp/aiyongxian.kml’? [Type yn!q or C-h] y
>> Copy: ‘/home/jidanni/mapping/aiyongxian/aiyongxian.kml’ to ‘/tmp/aiyongxian.kml’ failed:
>> (file-error Input and output files are the same Success /home/jidanni/mapping/aiyongxian/aiyongxian.kml /tmp/aiyongxian.kml)
>> 
>> OK, but why the word "Success"?!

EZ> Because that's not really a "failure": the file was already there.

OK, but, the shell says 1, not 0:

$ ln -s ~/mln -s ~/mapping/aiyongxian/aiyongxian.kml /tmp/
$ cp ~/mapping/aiyongxian/aiyongxian.kml /tmp/; echo $?
cp: '/home/jidanni/mapping/aiyongxian/aiyongxian.kml' and '/tmp/aiyongxian.kml' are the same file
1

Also
>> (file-error Input and output files are the same Success /home/jidanni/mapping/aiyongxian/aiyongxian.kml /tmp/aiyongxian.kml)
should be
>> (file-error Input and output files are the same. Success. /home/jidanni/mapping/aiyongxian/aiyongxian.kml /tmp/aiyongxian.kml)
But that doesn't make sense either.
Obviously the word Success has been stuck in the middle, and should be
moved to the front or back. And in fact changed to Failure.