GNU bug report logs - #50201
[PATCH core-updates-frozen 0/52] Support cross-compilation in glib-or-gtk-build-system and fix cross-compilation errors

Previous Next

Full log

Message #191 received at 50201 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 50201 <at> debbugs.gnu.org
Subject: Re: bug#50201: [PATCH core-updates-frozen 0/52] Support
 cross-compilation in glib-or-gtk-build-system and fix cross-compilation
 errors
Date: Thu, 02 Sep 2021 16:53:00 +0200

[Message part 1 (text/plain, inline)]

Mathieu Othacehe schreef op ma 30-08-2021 om 15:13 [+0200]:
> Hey,
> 
> > +    (native-search-paths
> > +     (list (search-path-specification
> > +            (variable "PKG_CONFIG_PATH_FOR_BUILD")
> > +            (files '("lib/pkgconfig" "lib64/pkgconfig" "share/pkgconfig")))))))
> 
> You could maybe extract the files list from the %pkg-config definition
> not to duplicate it?

Done in local checkout.  Also, the package inherits from %pkg-config instead
of pkg-config now (doesn't change the derivations but seems more proper).

Let me now when I should send a v2 (I'll look into the cpython-39 issue first).

Greetings,
Maxime

[0001-SQUASH-pkg-config-Inherit-pkg-config-search-path-spe.patch (text/x-patch, inline)]

From 8403f97eac354a02efa92f0a3ced7c95523fad12 Mon Sep 17 00:00:00 2001
From: Maxime Devos <maximedevos <at> telenet.be>
Date: Thu, 2 Sep 2021 15:18:54 +0200
Subject: [PATCH] SQUASH! pkg-config! Inherit %pkg-config & search-path-spec

---
 gnu/packages/pkg-config.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/pkg-config.scm b/gnu/packages/pkg-config.scm
index 9d1588338e..2b4173a7db 100644
--- a/gnu/packages/pkg-config.scm
+++ b/gnu/packages/pkg-config.scm
@@ -139,7 +139,7 @@ build, or a GNU triplet."
 ;; work because they both use the "PKG_CONFIG_PATH" environment variable.
 (define-public pkg-config-for-build
   (package
-    (inherit (hidden-package pkg-config))
+    (inherit (hidden-package %pkg-config))
     (name "pkg-config-for-build")
     (version "0")
     (source #f)
@@ -163,6 +163,8 @@ exec ~a \"$@\""
                         (search-input-file %build-inputs "bin/pkg-config"))))
             (chmod where #o500))))
     (native-search-paths
-     (list (search-path-specification
-            (variable "PKG_CONFIG_PATH_FOR_BUILD")
-            (files '("lib/pkgconfig" "lib64/pkgconfig" "share/pkgconfig")))))))
+     (map (lambda (original)
+            (search-path-specification
+             (inherit original)
+             (variable "PKG_CONFIG_FOR_BUILD")))
+          (package-native-search-paths %pkg-config)))))
-- 
2.33.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.