GNU bug report logs - #50195
[PATCH] Adding diary-offset, a diary-sexp offsetting another diary-sexp.

Previous Next

Package: emacs;

Reported by: Yuchen Pei <hi <at> ypei.me>

Date: Wed, 25 Aug 2021 05:57:01 UTC

Severity: wishlist

Tags: patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 50195 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, hi <at> ypei.me, 50195 <at> debbugs.gnu.org
Subject: Re: bug#50195: [PATCH] Adding diary-offset, a diary-sexp offsetting
 another diary-sexp.
Date: Wed, 25 Aug 2021 17:22:04 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> > It's how all these functions in diary-lib are defined after the lexical
> > rewrite -- the `eval' depends on those dynamic variables.
>
> Ugh!  Is it worth it?  If we cannot convert these functions to use
> lexical-binding, maybe we should say lexical-binding: nil in the first
> line of the file, and remove all those gross kludges?

That would not work, you would still get warnings about free variables.

This case is a bit special and not directly related to lexical-binding
because these variables are just not declared with `defvar' (and I think
we don't want to introduce global variables like `date').

Michael.




This bug report was last modified 3 years and 319 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.