From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 23 18:30:48 2021 Received: (at submit) by debbugs.gnu.org; 23 Aug 2021 22:30:48 +0000 Received: from localhost ([127.0.0.1]:42731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIISu-0002ri-15 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:30:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:34560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIISr-0002rX-N4 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:30:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIISr-0005E2-Fq for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:30:45 -0400 Received: from mail-bn8nam12olkn2080e.outbound.protection.outlook.com ([2a01:111:f400:fe5b::80e]:26816 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIISm-00025T-SD for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:30:44 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ltT9AgWEJ7GmtJYCaxQZ73wy55BO2kho50p8xQD+WZwyAY8p5Rz85MARih8rvkBGgUyhLFBueP2eC3JLDZJNg719Le9OZ7tAyBFirZKGEGuYTJjNr3W/sAXD0KI6DQhw8sUbg/a5zzj7E8Qf0Le43nhsIQoIrFMloTEzZsZ0yeGvDcF2IXQbXX1NR9GdQU2KkReWIwhYbcQ3fhyZG3PWFl7gLlvj6DyTVByWfLqUiWmQeRzagOrenzK3klotl63v5RoriM4fIwC5fyh/wUyG864cGvyYA6brr41KArl/+M7/2izSFdG8FgPPF029iSgO9yv2E4kr7e6SbBg6P+GMfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ5VuEmzeDFhoe3Z56jniaDYiQshMOa4kA3eXvUcbfE=; b=VfOlS/Hv+kD6m2gzYPKYhJ1/fydD6BLFzdp9E2hGW6sDjm9xkyp9Q2omMiQ/8uAue6zpyNH7Rt0VRu2+De2WMoEQiXCTne4OfhEfKvlpP3xkGSnLuif4MKc8adfoj5H/pgFh/GHdaHESRcAdKl89er+CH7sB2AjlY9X8AEEcK7KJHyzlNnMWQWmELbMhjbakMCtWlmmnR1HtSID/3YuXmo7U4xiuAwVyOUfc7ttKgaqkf94K7B5PFwLsY6jagwR3QFvw9j+acz8QYT+uVa0VK2uFDKDtKTo7B678bsPsdv/+HKCtYByWf2bduTVFNeLuyKF0AOD4+bfUAr3xqRR/RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xQ5VuEmzeDFhoe3Z56jniaDYiQshMOa4kA3eXvUcbfE=; b=iG2mACDad3jBbP8Oa0JhTCCPFLH3jHuGf32MLYTNDe216hEHl0x6Z31EdLwzktv4J09knMpByi23Yc+TI8wcLunpo6MEFgAVAK2J9zAQFZN9boX4CIQfWUW6HLBSY0U47lCtIFyUXEFZW7qx0JLFPuzcLY9iUvcvSQ6GjCEXtnO8BQKMpAn+xObYerCyvk3o+SxrxxSAUL14mMoR3T89XdzBWqo1QrTtuSZlbm/8SjubU7nm+kHNNUy3C3QaDFPFGP90PB2dqqCpoXkS/sCNMj9jFvFTUVnYPAn8BubRxvFL0hQ9+JWxN+rWELXl/t/2pxwAdilu9haIgvup3PPj6Q== Received: from CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) by CH0PR01MB6921.prod.exchangelabs.com (2603:10b6:610:102::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 22:25:35 +0000 Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182%2]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 22:25:35 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Date: Mon, 23 Aug 2021 19:25:30 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [7o4HPzDsYmnpzaA7Qpt7kRVYIlcWL0zozkhaGM38lqRWzd4Q+p+vfFrsH7PBu5DH] X-ClientProxiedBy: CP2P215CA0024.LAMP215.PROD.OUTLOOK.COM (2603:10d6:102:1::34) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87fsuz4x45.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from desktop (2804:431:c7f2:c40e:2a3a:aa3e:7959:7f66) by CP2P215CA0024.LAMP215.PROD.OUTLOOK.COM (2603:10d6:102:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 22:25:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5cfbecf5-11ab-48df-d9ec-08d96684ed2e X-MS-TrafficTypeDiagnostic: CH0PR01MB6921: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yYgs1RIIoyijxyPfh45Kzzw1F0KoeDigtIiEGIPQPdV5tNRf0b8Pn4i/AGzrX3FxxqLpmfVBT8DDntKUm/VTXSyimjapJMxk+djNgIMwNpKO2M6l58e7tyEPUINuBL05Z/St9JZv5mf6sz4lkWbYYROfXTyCrqy7a/aK2O4tYWMeY/un9IVYvHdmGewB1LPBY5evkNWNmXpk+OZWEgqvsbSYkbP3/Zyi6cNHwTKKj5VjK14k/PQClgDZZ4j+THPs16ySR+IiwNiNJ9tJ056RK+0XLT8VGHaKqliTydvzaUEzrIs/pzw1ujwSvAvPm/vmGAakiCPeG9s7SXCrY2ntq8h+kvzUq3ByURhybJf1nsbJ7VI7iPNNbO6PG9YYpkjo3nS1/60nIa7PtPsjnxgMcwXcV2rxzHFZRsco+veB19gh71YjB+J7mFv6L7X4GsGc X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: LXWsoxZF+PmpIkSGwwwf+5PpPrLsJ1fSqAcXqpKfIEJ1aIITddtuoX9UcoyQUjsk2lmbTweNZnxPl2LurFpd2/1L7nWbrBmrTlezvlW2+9xjwZ80RzHSLgr0gT4Jfffih3mhYeY8X0gs5BuqIsN5r/6wGQ0mOq//LsPojTMhv3fXuRDFAJJdi3PZlLZNoGCwcI8iy+F918AqnaX+/eGFXQ== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-48c30.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5cfbecf5-11ab-48df-d9ec-08d96684ed2e X-MS-Exchange-CrossTenant-AuthSource: CH2PR01MB5879.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 22:25:35.8128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB6921 Received-SPF: pass client-ip=2a01:111:f400:fe5b::80e; envelope-from=gabriel376@hotmail.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Description: When repeat-mode is enabled and a repeat-exit-timeout is set, the echo-area is not cleared in case the echo-area has some content and a single repeat-command is executed. Steps: 1) emacs -Q (from master branch) 2) eval (setq repeat-exit-timeout 1) (repeat-mode 1) 3) create some windows with 'C-x 2' and 'C-x 3' 4) 'C-x' 5) wait prefix "C-x" to appear on echo-area 6) 'o' (echo-area will now contain "C-x o [Repeat with o, O]") 7) wait a few seconds so 'repeat-exit-timeout' takes effect Expected: the echo-area is cleared Actual: the echo-area is not cleared If 'o' is pressed again, it will run 'self-insert-command' even though the echo-area is still showing "C-x o [Repeat with o, O]". Now repeat steps 1-5 but press 'o' quickly to invoke the repeat command multiple times (which will trigger other-window multiple times). The echo-area changes to "Repeat o, O" and is properly cleaned after 'repeat-exit-timeout' seconds. Patch: I created a simple patch that seems to fix this probem. The 'string-prefix-p' was replaced with 'string-match-p' to handle cases where echo-area contains some other message. This check seems very poor, though, so any better approach is welcome. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-to-clear-echo-area-after-repeat-exit-timeout.patch >From e6de15337bf4516740c0e790f6a2bfb3deaf9b5b Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Mon, 23 Aug 2021 19:05:58 -0300 Subject: [PATCH] Fix to clear echo-area after repeat-exit-timeout. * lisp/repeat.el (repeat-echo-message): Use 'string-match-p' to handle cases where echo-area contains other messages. --- lisp/repeat.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index cec3cb643a..054eacf8ec 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -474,7 +474,7 @@ repeat-echo-message (if (current-message) (message "%s [%s]" (current-message) mess) (message mess))) - (when (string-prefix-p "Repeat with " (current-message)) + (when (string-match-p "Repeat with " (current-message)) (message nil)))) (defvar repeat-echo-mode-line-string -- 2.32.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 24 02:48:03 2021 Received: (at 50176) by debbugs.gnu.org; 24 Aug 2021 06:48:03 +0000 Received: from localhost ([127.0.0.1]:42972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIQE6-0002aF-SF for submit@debbugs.gnu.org; Tue, 24 Aug 2021 02:48:03 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:49191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIQE4-0002Za-OM; Tue, 24 Aug 2021 02:48:01 -0400 Received: (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 1D1DB100008; Tue, 24 Aug 2021 06:47:52 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Organization: LINKOV.NET References: Date: Tue, 24 Aug 2021 09:44:44 +0300 In-Reply-To: (Gabriel's message of "Mon, 23 Aug 2021 19:25:30 -0300") Message-ID: <87o89nxrxf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50176 Cc: 50176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 50176 fixed close 50176 28.0.50 thanks > Patch: > I created a simple patch that seems to fix this probem. The > 'string-prefix-p' was replaced with 'string-match-p' to handle cases > where echo-area contains some other message. This check seems very poor, > though, so any better approach is welcome. Thanks for the patch. This is a known problem without a good solution. But your patch handles the case much better than before, so pushed now. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 24 10:32:06 2021 Received: (at submit) by debbugs.gnu.org; 24 Aug 2021 14:32:06 +0000 Received: from localhost ([127.0.0.1]:44961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIXT7-0002rk-Cp for submit@debbugs.gnu.org; Tue, 24 Aug 2021 10:32:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:50800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIXT5-0002rZ-7r for submit@debbugs.gnu.org; Tue, 24 Aug 2021 10:31:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIXT4-00056m-Uf for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2021 10:31:59 -0400 Received: from mail-mw2nam10olkn2082.outbound.protection.outlook.com ([40.92.42.82]:38239 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIXT2-00022D-2F for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2021 10:31:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJFbhKq8yaJpQKmMpIH8r9bPio7mK4+ol/JyyJikRPbUEOrIwjDq6PyLTxeOZ3H7SeR/L9qcz1xXjtEX28XA4xKU/J5qm0r7EVn1oPPdwBdjLX7Oxs5Jb+Z/j4SCr072yIUV+3IEPbuU93wb6spQWRQfZ/K2TxKeK9xIa1iXZTx5eS8dfswRcJJF2lNjK39TlC7YwdN7vl5WDqVacZdX5wo8WfDnT7byu68emfKys3jl5dCsgS6l8X3VTrmdFEMb2X/SPEj1oDUH8qumDlFuNpe3CuZnw4XN8XrhoNKOQ7plK94KR6SII1mJ40BSkdpiaaZlFAi+rzhSId3/cXs9vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+QHnpFkV9YXWV4pcjikrOeit1A4PxOBN9ez3ffoM8M=; b=SQ01VwXaEK+zUqWhiEcepsW7dt4pOtQXVTPbHlVrWk5nY6WZiyN+dT7tuu/fhe7oHiRuNV4qjKiWS2jr32F4tLaMWYmbO/Y6uODtmat/KDowQ0vGIvJwTdjGAZSqSNjvHUss1lNXaR8+nfRtmYSI58r7sbYf5sQq/C2oZnc5jrejA3rA5wTghuzyqEhk0gtMxh8L8jByioqnY5ZjP+Urprsf6uniPMQOtEVbuqgyIUtwyAkz2ik4uhrvu/0ZZND1s63WL4OctElsZj5Gt8lCFGdJLeK5izOK9/c3XWcVq9HfgEhYF9/XqSJMbxBovzthbKz+/nPX0IdXkzn2JhKfIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+QHnpFkV9YXWV4pcjikrOeit1A4PxOBN9ez3ffoM8M=; b=ZE9XHjF0ysy0YtmAjJiB7NtxfSWJvskYkdcUeZ3ktpqcTUm2IVroIjhSXG244wLgWjdiN1jUc5rBH1eDbgjljM20I8aLI5UhtQRXuHbTmd+4NO4Gi4+Z1WMMYlVXNYpXL/WXK3u/GXULdPU551mFD5qeDujlRFW9/sANs1eno5Oo9RdTTE071H+C7A+4CLhOLc3AopcVfo5rN2iJV5gQDcbOpNzgboEPX/2NqTFevXvE658MplgPXHv0oELVjSkydKKHJRwEu3h2oiRQslwOTYA7ApgMf1LWkmKQzeLOT1pWuLqeWLKMfAtbSxnv/wNTr3+nFbx7g70YZBrZDYK/cQ== Received: from CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) by CH0PR01MB7020.prod.exchangelabs.com (2603:10b6:610:109::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Tue, 24 Aug 2021 14:31:53 +0000 Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::5c64:1750:c3c7:c182%2]) with mapi id 15.20.4436.024; Tue, 24 Aug 2021 14:31:53 +0000 From: Gabriel To: bug-gnu-emacs@gnu.org Subject: Re: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout References: <87o89nxrxf.fsf@mail.linkov.net> Date: Tue, 24 Aug 2021 11:31:30 -0300 In-Reply-To: <87o89nxrxf.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 24 Aug 2021 09:44:44 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [TPYRnw5tre2YDFEoE5m0PAHQjsCw1Trv] X-ClientProxiedBy: CP4P284CA0043.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:127::13) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from 8c85906fe631.ant.amazon.com (177.215.64.63) by CP4P284CA0043.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:127::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22 via Frontend Transport; Tue, 24 Aug 2021 14:31:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 558d8879-1c93-43fc-1509-08d9670bea97 X-MS-TrafficTypeDiagnostic: CH0PR01MB7020: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kPrx43bokzWaA/DNK/3gVmBImuAGRlYIQkxToP3AQ2OltnZn8FGPtfxe7fNXbK5jpFGc1ANavGGbXzhVjKgH49Bk2Ldh6aEEEy/f7rQdkld1eIlBoWJX/1molCxK5uH49a69N91C/UVibZ7CpT9YI9aZxNplfJ7s3/gc3YwNMd9ux0jrLBxsLio/428zTZKMKFJ3jYv1f4iVXyzOKZu34f9SW2oS5CwFidsQ6K5YN9qrrmYZL6A8pMud4oT17XOzhfcZlNYFMB1MFdGCpktI7LbX0w+mMbrZmO4IOf7JVV8Ncp8mImz+6Ex07QqH3vywE37tNlR3tX6fONh9+hKzKp8WPaEMZUayH0mmR84Nr4zN1xxJFNvMJKTWzoiUri9wz//XM4Lt0QvoU07yaSgVIraHHmUcmQYAevqTAHTjezERuuWn/JISjxTrMbdwoTFx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e7Noj6Ffx4CDQ8zKwDBohhtV4q5Wm7xD54pTIAldNxSAuxic+Md6xiyCL63PcMNnnox4KHzDNxahkAz2COeeL2NMbR4nKg6YeZ5L8kjgO7LaT7UVEzzYMsZSl1t/NiajSY792+gy4YFIxJFjpTyUcQ== X-OriginatorOrg: sct-15-20-3174-20-msonline-outlook-48c30.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 558d8879-1c93-43fc-1509-08d9670bea97 X-MS-Exchange-CrossTenant-AuthSource: CH2PR01MB5879.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2021 14:31:53.4912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB7020 Received-SPF: pass client-ip=40.92.42.82; envelope-from=gabriel376@hotmail.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) --=-=-= Content-Type: text/plain Juri Linkov writes: > > Thanks for the patch. This is a known problem without a good solution. > But your patch handles the case much better than before, so pushed now. Thank you, Juri Perhaps we could store in a defvar the last message echoed by repeat-mode to make easier this check? Today I caught a small problem with the patch I sent. The 'string-prefix-p' and 'string-match-p' handle nil inputs differently: (string-prefix-p "Repeat with " nil) ;; returns nil (string-match-p "Repeat with " nil) ;; throws an error The problem can be reproduced by writing some elisp code in *scratch* buffer, putting the cursor in the function definition and invoking the 'other-window' with 'repeat-mode' using my original steps. The 'eldoc-mode' will echo the function name and '(current-message)' will return nil. A simple patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Handle-nil-messages-in-repeat-echo-message.patch >From 4e67546e2a9a878418d9dd766d234699fd58da34 Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro Date: Tue, 24 Aug 2021 11:23:49 -0300 Subject: [PATCH] Handle nil messages in repeat-echo-message. * lisp/repeat.el (repeat-echo-message): Handle cases where 'current-message' is nil (bug#50176). --- lisp/repeat.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/repeat.el b/lisp/repeat.el index e3e7a7568e..3b30ba2a60 100644 --- a/lisp/repeat.el +++ b/lisp/repeat.el @@ -474,8 +474,9 @@ repeat-echo-message (if (current-message) (message "%s [%s]" (current-message) mess) (message mess))) - (when (string-match-p "Repeat with " (or (current-message) "")) - (message nil)))) + (and (current-message) + (string-match-p "Repeat with " (current-message)) + (message nil)))) (defvar repeat-echo-mode-line-string (propertize "[Repeating...] " 'face 'mode-line-emphasis) -- 2.32.0 --=-=-= Content-Type: text/plain (The call to '(current-message)' does not seem to be expensive; otherwise, we could store it into a variable to avoid duplicated calls) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 24 14:21:09 2021 Received: (at 50176) by debbugs.gnu.org; 24 Aug 2021 18:21:09 +0000 Received: from localhost ([127.0.0.1]:45187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIb2r-0004sd-3A for submit@debbugs.gnu.org; Tue, 24 Aug 2021 14:21:09 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIb2q-0004sE-0x for 50176@debbugs.gnu.org; Tue, 24 Aug 2021 14:21:08 -0400 Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E81C7E0007; Tue, 24 Aug 2021 18:21:00 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Organization: LINKOV.NET References: <87o89nxrxf.fsf@mail.linkov.net> Date: Tue, 24 Aug 2021 21:20:13 +0300 In-Reply-To: (Gabriel's message of "Tue, 24 Aug 2021 11:31:30 -0300") Message-ID: <87a6l6k8ma.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50176 Cc: 50176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Today I caught a small problem with the patch I sent. The > 'string-prefix-p' and 'string-match-p' handle nil inputs differently: > > (string-prefix-p "Repeat with " nil) ;; returns nil > (string-match-p "Repeat with " nil) ;; throws an error > > The problem can be reproduced by writing some elisp code in *scratch* > buffer, putting the cursor in the function definition and invoking the > 'other-window' with 'repeat-mode' using my original steps. The > 'eldoc-mode' will echo the function name and '(current-message)' will > return nil. Please look in the repo that Mattias already changed string-match-p to string-search. But (string-search "Repeat with " nil) still throws an error. I wonder why string-search is different from string-prefix-p is its argument handling? They both operate on the strings. Also the name 'string-search' is too confusing since it is too similar to 'search-forward' that searches in the buffer. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 13:12:01 2021 Received: (at 50176) by debbugs.gnu.org; 25 Aug 2021 17:12:01 +0000 Received: from localhost ([127.0.0.1]:47540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIwRU-0001PM-Qc for submit@debbugs.gnu.org; Wed, 25 Aug 2021 13:12:00 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:52957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIwRS-0001P6-G8 for 50176@debbugs.gnu.org; Wed, 25 Aug 2021 13:11:59 -0400 Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1644A40006; Wed, 25 Aug 2021 17:11:50 +0000 (UTC) From: Juri Linkov To: Mattias =?iso-8859-1?Q?Engdeg=E5rd?= Subject: Re: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Organization: LINKOV.NET References: Date: Wed, 25 Aug 2021 20:06:07 +0300 In-Reply-To: ("Mattias =?iso-8859-1?Q?Engdeg=E5rd=22's?= message of "Tue, 24 Aug 2021 21:25:21 +0200") Message-ID: <87r1ehtpxc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50176 Cc: 50176@debbugs.gnu.org, Gabriel X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Also the name 'string-search' is too confusing since it is too >> similar to 'search-forward' that searches in the buffer. > > Well, maybe could give it the alias `is-substring-of` when used in a Boolean context... Some languages use the name `include?`, other use the name `contains?`, so actually I see no better name than the current `string-search`. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 13:12:05 2021 Received: (at 50176) by debbugs.gnu.org; 25 Aug 2021 17:12:05 +0000 Received: from localhost ([127.0.0.1]:47544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIwRY-0001Pz-Vv for submit@debbugs.gnu.org; Wed, 25 Aug 2021 13:12:05 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:45807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIwRV-0001PB-A8 for 50176@debbugs.gnu.org; Wed, 25 Aug 2021 13:12:02 -0400 Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 9F1EE20004; Wed, 25 Aug 2021 17:11:54 +0000 (UTC) From: Juri Linkov To: Gabriel Subject: Re: bug#50176: [PATCH] 28.0.50; repeat-mode does not clear echo-area after timeout Organization: LINKOV.NET References: <87o89nxrxf.fsf@mail.linkov.net> Date: Wed, 25 Aug 2021 20:11:10 +0300 In-Reply-To: (Gabriel's message of "Tue, 24 Aug 2021 11:31:30 -0300") Message-ID: <87h7fdtpox.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50176 Cc: 50176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > A simple patch: > > @@ -474,8 +474,9 @@ repeat-echo-message > (if (current-message) > (message "%s [%s]" (current-message) mess) > (message mess))) > - (when (string-match-p "Repeat with " (or (current-message) "")) > - (message nil)))) > + (and (current-message) > + (string-match-p "Repeat with " (current-message)) > + (message nil)))) Thanks, pushed with small changes. From unknown Sun Jun 22 20:57:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Sep 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator