From unknown Mon Jun 23 02:24:24 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#50175 <50175@debbugs.gnu.org> To: bug#50175 <50175@debbugs.gnu.org> Subject: Status: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) Reply-To: bug#50175 <50175@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:24:24 +0000 retitle 50175 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x =3D = (vc-doff) reassign 50175 emacs submitter 50175 sds@gnu.org severity 50175 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 23 18:22:08 2021 Received: (at submit) by debbugs.gnu.org; 23 Aug 2021 22:22:08 +0000 Received: from localhost ([127.0.0.1]:42724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIIKO-0002cZ-Rt for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:22:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:59072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIIKI-0002cL-US for submit@debbugs.gnu.org; Mon, 23 Aug 2021 18:21:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIIKI-0002I4-Nj for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 18:21:54 -0400 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]:38478) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIIK6-0003ON-Ul; Mon, 23 Aug 2021 18:21:52 -0400 Received: by mail-io1-xd2d.google.com with SMTP id a13so23795450iol.5; Mon, 23 Aug 2021 15:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:return-receipt-to:reply-to:date:message-id :mime-version; bh=v8IKXvmLV3odC15hwuy0IyZMpBa+YndxfkJUQLjZAk8=; b=Vzp6pbG4edyDNHH8cbiqyNB7P5RqWpXvvNARdgyOy7TpS8ydCJKs+dUP8B9CbQRE01 pKhTjJAOknyg9VAS3wGMKU+YyTvycOtUrlhzYo0a0Y907JWVVIfqDUN1eXf3Z9udjfOg cn1/oNvq42ynUlOtdfT84J+Z3Fj8R64/S3ARiSWF+mvNJCh1Q6giC2vEZ34Z0bC/Hn8c 2T7MCB9J5GbqQ2FjmV+jzGquRth2IUJ/6jO/HcCJNLsdgYGsmEdMhSdqNf0sKBnF9uRx 08E8+WuiEu0sPT/0zB+001FNq1GZm0fzOqPLylG+GDFL1Ea9n65IO7bYnO6jmHGNiPHM bXNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:return-receipt-to :reply-to:date:message-id:mime-version; bh=v8IKXvmLV3odC15hwuy0IyZMpBa+YndxfkJUQLjZAk8=; b=KPBLNNB7/1oroBzdXBe2xA+m8NZKsu4SOezRd3ytdZqrpeQ1Dv38BZH8AKxnshllTn iak7TecXLz6NB1z3Qs7j5QIjcBsAhX2A9EOXFLxnliCiLmRWOltdXHXaj8vLf2UMxC5M 29H+AYSTBpcXNzLueIAMAz/WU82w6sZKFjhR0ANh9NdzAEsJEyU0vQuMfmSM9YOvgrwh EatSbfWK5dUFgKRuMR2gmmHcvG3V5kOGH6zzSQY2ZZ8HBlIsvAMgsLUe/NgfeZrdtfZG J0z2RGtwNmgSl4U1TQawAiest84Pf6LfNDCU06s0xoFSBOehKnqRpCyK3f8C7gux6NSg GCQA== X-Gm-Message-State: AOAM530aH2caP2/e3pNT4CLtB+1gn+MgEe6NKXPFPwtMBPbIe+GjusOe KXAiMckcegARhSA8EaGMt33mJQZiFA== X-Google-Smtp-Source: ABdhPJwglHHDysA6pn5zW6nKg0+EHhBg0AEH20uFpkez3TgCyCyfpxoHCvdzWvXNoSyrrdOLZFOSRA== X-Received: by 2002:a37:9606:: with SMTP id y6mr23345666qkd.13.1629756556174; Mon, 23 Aug 2021 15:09:16 -0700 (PDT) Received: from 3c22fb11fdab.ant.amazon.com (pool-108-30-23-113.nycmny.fios.verizon.net. [108.30.23.113]) by smtp.gmail.com with ESMTPSA id w19sm8951027qki.21.2021.08.23.15.09.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Aug 2021 15:09:15 -0700 (PDT) From: Steingold To: bug-gnu-emacs@gnu.org Subject: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Date: Mon, 23 Aug 2021 18:09:14 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d2d; envelope-from=sam.steingold@gmail.com; helo=mail-io1-xd2d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sds@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) when editing a remote file, vc-dir shows the *vc-dir* buffer correctly, but vc-diff in the same buffer fails: --8<---------------cut here---------------start------------->8--- Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py")) error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--") apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--")) vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" "-p" "HEAD" nil "--") apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" ("-p" "HEAD" nil "--")) vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)) vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t) vc-diff(nil t) funcall-interactively(vc-diff nil t) call-interactively(vc-diff nil nil) command-execute(vc-diff) --8<---------------cut here---------------end--------------->8--- Same error on = (vc-diff) in the *vc-dir* buffer. I am pretty sure this is a regression from about 2-3 weeks ago. (vc-next-action also fails) In GNU Emacs 28.0.50 (build 5, x86_64-apple-darwin19.6.0, NS appkit-1894.60 Version 10.15.7 (Build 19H1323)) of 2021-08-23 built on 3c22fb11fdab.ant.amazon.com Repository revision: 00edc8329a6277f2e5b5204efbe503e2b7957006 Repository branch: master Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.7 Configured using: 'configure --with-imagemagick --with-mailutils --with-ns PKG_CONFIG_PATH=/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/imagemagick/lib/pkgconfig:/usr/local/opt/gnutls/lib/pkgconfig:/usr/local/opt/jansson/lib/pkgconfig:/usr/local/opt/libtiff/lib/pkgconfig:/usr/local/opt/libpng/lib/pkgconfig:/usr/local/opt/libjpeg/lib/pkgconfig:/usr/local/opt/freetype/lib/pkgconfig' Configured features: ACL GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG THREADS TIFF TOOLKIT_SCROLL_BARS ZLIB Important settings: value of $LC_MESSAGES: C value of $LANG: C locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: pyvenv-mode: t shell-dirtrack-mode: t flyspell-mode: t global-edit-server-edit-mode: t winner-mode: t which-function-mode: t url-handler-mode: t show-paren-mode: t desktop-save-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: org-auto-fill-function abbrev-mode: t Load-path shadows: None found. Features: (shadow sort bbdb-message mailalias cookie1 mail-extr gnus-msg emacsbug sendmail vc-mtn vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir ewoc cl-print debug backtrace dabbrev skeleton misearch multi-isearch rx color autoload lisp-mnt mm-archive gnutls network-stream url-http url-gw nsm url-cache url-auth finder-inf package add-log vc-hg vc-bzr tramp-cache remember vc cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs bug-reference conf-mode company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-template company-cmake company-bbdb yasnippet-snippets yasnippet flymake-proc flymake company-capf company pcase help-fns radix-tree elpy edmacro kmacro elpy-rpc pyvenv eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util elpy-shell elpy-profile elpy-django s elpy-refactor ido grep compile etags fileloop xref project cus-edit pp cus-start python tramp-sh tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell ls-lisp flyspell ispell org-element avl-tree generator ol-eww eww xdg url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt cl-extra help-mode speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec epa derived epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 gmm-utils mailheader gnus-win ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex iso8601 ol-bbdb ol-w3m org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs format-spec find-func cal-x view cal-china cal-bahai cal-islam holidays hol-loaddefs bbdb-anniv cal-iso cal-hebrew lunar cal-julian solar cal-dst vc-git diff-mode easy-mmode vc-dispatcher appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs dired-aux dired dired-loaddefs midnight warnings gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums text-property-search time-date mail-utils mm-util mail-prsvr wid-edit bbdb-mua bbdb-com crm mailabbrev bbdb bbdb-site timezone edit-server advice server winner ring which-func imenu url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map seq byte-opt gv bytecomp byte-compile cconv url-vars paren help-at-pt desktop frameset cl-loaddefs cl-lib cus-load info iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 1730297 264010) (symbols 48 39892 1) (strings 32 397217 56034) (string-bytes 1 11710856) (vectors 16 113387) (vector-slots 8 1439079 162214) (floats 8 943 538) (intervals 56 172493 3877) (buffers 992 62)) -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1894 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://jij.org https://jihadwatch.org http://think-israel.org If you do not move, you will not feel the shackles. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 09:26:53 2021 Received: (at 50175) by debbugs.gnu.org; 25 Aug 2021 13:26:53 +0000 Received: from localhost ([127.0.0.1]:46152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIsvY-0007rd-Jd for submit@debbugs.gnu.org; Wed, 25 Aug 2021 09:26:52 -0400 Received: from smtp1.axis.com ([195.60.68.17]:30543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIsvS-0007rK-F6 for 50175@debbugs.gnu.org; Wed, 25 Aug 2021 09:26:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1629898002; x=1661434002; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=KqxvuFnYLjNGoiZhJWgTDtFqMU1I+Jp3xqzcaBGtypI=; b=iKO1ONYICt94vXyHVtGAq/p+BG4EkbsiJCMFxiDre01evtaVq9JmLZd/ pMasbTFK2QSw1Z+AUNpKJI2eQ2EBYsBYeW8y0k30WpJrmw08dk4Q7HRI/ KVZpgaxMNgWjeIhgZl61zDqxHIp9oLmQ2t0B8f+0gjhQv9Oj5BrARdKT8 8nwpmf3awCh7TEW3XSiTVyh8i75mI+peddvTODqfE8BeQfrzxwpt+rUPv Z36sSJ+3xg308Ee4QD/6O6asFzI1wc8/sCfQ+lI1NoLINHojSP0kvvEpL FO6MnGn1LvKdplFrz1WIWDkDWHV6hFsbUjQH0l0sgPLE07S0ak9ipEbPh w==; From: Ola x Nilsson To: Subject: Re: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) References: Date: Wed, 25 Aug 2021 15:26:34 +0200 In-Reply-To: (Steingold's message of "Mon, 23 Aug 2021 18:09:14 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50175 Cc: larsi@gnus.org, 50175@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Mon, Aug 23 2021, Steingold wrote: > when editing a remote file, vc-dir shows the *vc-dir* buffer correctly, > but vc-diff in the same buffer fails: > > Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") > signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py")) > error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- :(literal)/scp:remote:/path/file.py") > vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--") > apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" "diff-index" "--exit-code" "-p" "HEAD" nil "--")) > vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" "-p" "HEAD" nil "--") > apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" ("-p" "HEAD" nil "--")) > vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) > apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)) > vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) > vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t) > vc-diff(nil t) > funcall-interactively(vc-diff nil t) > call-interactively(vc-diff nil nil) > command-execute(vc-diff) > > Same error on = (vc-diff) in the *vc-dir* buffer. > > I am pretty sure this is a regression from about 2-3 weeks ago. > > (vc-next-action also fails) This is the result of the git literal pathspec prefix being added in a non-tramp-aware way. See bug #39452. The commits in question are 3502321403 Fix regressions in the last change 3572613550 Fix vc-git-state for filenames with wildcards -- Ola Nilsson From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 11:45:23 2021 Received: (at 50175) by debbugs.gnu.org; 25 Aug 2021 15:45:23 +0000 Received: from localhost ([127.0.0.1]:47390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIv5X-0001Of-Qx for submit@debbugs.gnu.org; Wed, 25 Aug 2021 11:45:23 -0400 Received: from mail-qv1-f44.google.com ([209.85.219.44]:35594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIv5W-0001He-DH for 50175@debbugs.gnu.org; Wed, 25 Aug 2021 11:45:14 -0400 Received: by mail-qv1-f44.google.com with SMTP id g11so156800qvd.2 for <50175@debbugs.gnu.org>; Wed, 25 Aug 2021 08:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:user-agent :return-receipt-to:reply-to:date:message-id:mime-version; bh=o40cYAutuvSDEwaNDw5mtMqbCIAc7q2Btp0xrL6hnQ4=; b=Q3/pgPLtM6QEyA89RjWyj+U9Dbxli1awA8sJDGG2mdgAgACTfbFO1MqOMD+6wwL3zl RkEWWSrPEOcdfO1r1yGtwhwn9uQWMKUTQFrBeQarmV8ftgWCjHlOnm4mE5RbMIz0ElkX rbgPNjzvFIav/sDeNr3G8Rt0kcQUO8788MS+82RVtwuIa2AoRu7czPzSb9XEnmHZ5MKk 6UWqar9iQr1Ta2kf/sKQAyM86LAxRmXgeyrFqcxGt+FJyKSlxth1wzobms5wx56Dcz+V V/bTbcReiDe95ghm6hSUdz5IjnDIa8gYMhEtqvhvKG1cHuD6rtw/jv4ObmfmlZXA0xd9 /AyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :user-agent:return-receipt-to:reply-to:date:message-id:mime-version; bh=o40cYAutuvSDEwaNDw5mtMqbCIAc7q2Btp0xrL6hnQ4=; b=IHWQu6tIZ27sifvb3w4zzxQOg5gG3EnSwoZ6XsyazmISJSzE8r7EWpHvSXZaYCf/eZ O7rSNv3sM6JGtsLBpdKcorhL8yJCCWvxK/AH0NmHbWdFXvBM6CsKcy0Jl3zYNPkzukB8 JNyAbjYJ6ru7v5vkHURkvlIj79haamagmaxGjascgBzmMBmkahw07WSk1H9B/T0kF+eT K0yiiSWLZUWtQjY4rklQluW2q/3II1HeVHXgh8s4LyZl1M7hrRBYP0CgejF1cxlc63WF Zn6MOaLh9Qxq/3eRFwIZuObGeedEJc1Y4LIrOSw0hu6EL6qhCt0+qPlysYKf7lYVjg/1 4RNQ== X-Gm-Message-State: AOAM533UnIH9L8DA/MwDGBgAqWsO0KCYOp7pW0M92ER5kRN/Qf6A+lRD ec9VUHZEW7heNtxkbVC34Q== X-Google-Smtp-Source: ABdhPJybuzc5+NbR6asbwDqH9i0uBhG93JpcJGUTIJd+CmAwPS5ZuyzfYaAGfU3xIrxc5K4zsZtv/A== X-Received: by 2002:a05:6214:98a:: with SMTP id dt10mr14420765qvb.31.1629906308762; Wed, 25 Aug 2021 08:45:08 -0700 (PDT) Received: from 3c22fb11fdab.ant.amazon.com (pool-108-30-23-113.nycmny.fios.verizon.net. [108.30.23.113]) by smtp.gmail.com with ESMTPSA id h4sm224395qkp.86.2021.08.25.08.45.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Aug 2021 08:45:08 -0700 (PDT) From: Steingold To: Ola x Nilsson Subject: Re: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) In-Reply-To: (Ola x. Nilsson's message of "Wed, 25 Aug 2021 15:26:34 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) X-Attribution: Sam X-Disclaimer: You should not expect anyone to agree with me. Date: Wed, 25 Aug 2021 11:45:07 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50175 Cc: larsi@gnus.org, 50175@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sds@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Ola, Lars, Dmitry, > * Ola x Nilsson [2021-08-25 15:26:34 +0200]: > > On Mon, Aug 23 2021, Steingold wrote: > >> when editing a remote file, vc-dir shows the *vc-dir* buffer correctly, >> but vc-diff in the same buffer fails: >> >> Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code >> -p HEAD -- :(literal)/scp:remote:/path/file.py") >> signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- >> :(literal)/scp:remote:/path/file.py")) >> error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- >> :(literal)/scp:remote:/path/file.py") >> vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" >> "diff-index" "--exit-code" "-p" "HEAD" nil "--") >> apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" >> "diff-index" "--exit-code" "-p" "HEAD" nil "--")) >> vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" >> "-p" "HEAD" nil "--") >> apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" >> "--exit-code" ("-p" "HEAD" nil "--")) >> vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) >> apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)) >> vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) >> vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t) >> vc-diff(nil t) >> funcall-interactively(vc-diff nil t) >> call-interactively(vc-diff nil nil) >> command-execute(vc-diff) >> >> Same error on = (vc-diff) in the *vc-dir* buffer. >> >> I am pretty sure this is a regression from about 2-3 weeks ago. >> >> (vc-next-action also fails) > > This is the result of the git literal pathspec prefix being added in a > non-tramp-aware way. See bug #39452. The commits in question are > > 3502321403 Fix regressions in the last change > 3572613550 Fix vc-git-state for filenames with wildcards I do have all these patches, but, alas, I still see the bug. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39452 has no messages for 10 days, I hope it is being worked on... Thank you! -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1894 http://childpsy.net http://calmchildstories.com http://steingoldpsychology.com https://thereligionofpeace.com https://memri.org https://honestreporting.com Modern man is the missing link between apes and human beings. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 21:52:15 2021 Received: (at 50175-done) by debbugs.gnu.org; 26 Aug 2021 01:52:15 +0000 Received: from localhost ([127.0.0.1]:48026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ4Yt-0001Km-8v for submit@debbugs.gnu.org; Wed, 25 Aug 2021 21:52:15 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ4Ym-0001KB-PW for 50175-done@debbugs.gnu.org; Wed, 25 Aug 2021 21:52:09 -0400 Received: by mail-wr1-f52.google.com with SMTP id q14so2380359wrp.3 for <50175-done@debbugs.gnu.org>; Wed, 25 Aug 2021 18:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8epHh6rxCHc0WJMxpzhR6I770DJMFwCD2M3xKZ6Zi3M=; b=g2PTZvE2NOkLVYo2Qe2n5rvX4bbR152c9LHJSwnFUNbKuScKuIomm1eEykV9vIm/9k rfXiFrSh5wuChqqN9ZUSczpKPZhCrxc+QkcxklRZpASy5c/LNvK2PFXqyOqaSVddWd6h 8gPxrfrHjpUaWj//B28S7YACywnqOF21YYLpEckFhzwShgjDOZdVmozYjkinXP2Q+tuH 6iIX8EjNvBftw4rkmKpPYdsE+ZQCfo0vwgTPjtikjX3RYQHygRaScq5yBIiGjQC8HXuA +Tyz/9B3cC6b5HQmYujD8HDhUNqWgu6OBLE9VdZexDtY4izALbvrJHhuw4GlzcA529nx fRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8epHh6rxCHc0WJMxpzhR6I770DJMFwCD2M3xKZ6Zi3M=; b=Obq50T8R7F3MLIRkiwXgl2eoXOBsSlkYX5M5U6CaJQ1W6DlAxwJ1hhg+G4avdiG+48 jfsNOHHxokWc5ehi98rt4IOWEuz+/2Tv6Q2VSLxeEwMxQyvEusu+5VFg6hsEWr4kLMDK 0cdkQTD2qdVwyzyGV/5C2HqupySbYLm1Mw9y6mYVU+RAsFiEHM+g/Xq8ogzc52XZJ1AY YySN7AtyM0TuHjGCNCx26m+2v8b897CRkfJwmItPqMm7kjmUhOi21E1atZXVsnnlvBjU c7dNGi/WHAT7hFPKiP+lQu1YoiYy7HRH8iO13yh+qWDYlYQAQVW1Is//J4xJZNcoT5Uv fJ0w== X-Gm-Message-State: AOAM533vhcKhUaNpaLE1lqiFXlDl1RkQbVQVHdI4MNDqPV40JkSQLxee vm1znYELCtKg9V3MUOONO5w= X-Google-Smtp-Source: ABdhPJzBJ3Cwm9+2qVlgg1XKfcMiYTd2lXgGQ6M8uZFBNuwjqBhYaUpVMCpNc8PMkwrebZ1K9JARng== X-Received: by 2002:adf:f645:: with SMTP id x5mr950327wrp.353.1629942718769; Wed, 25 Aug 2021 18:51:58 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n8sm1525858wra.24.2021.08.25.18.51.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Aug 2021 18:51:57 -0700 (PDT) Subject: Re: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) To: sds@gnu.org, Ola x Nilsson References: From: Dmitry Gutov Message-ID: <9109d282-192c-22ec-6010-4e1f3cc97d9e@yandex.ru> Date: Thu, 26 Aug 2021 04:51:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 50175-done Cc: larsi@gnus.org, 50175-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Hi! On 25.08.2021 18:45, Steingold wrote: > Hi Ola, Lars, Dmitry, > >> * Ola x Nilsson [2021-08-25 15:26:34 +0200]: >> >> On Mon, Aug 23 2021, Steingold wrote: >> >>> when editing a remote file, vc-dir shows the*vc-dir* buffer correctly, >>> but vc-diff in the same buffer fails: >>> >>> Debugger entered--Lisp error: (error "Failed (status 128): git --no-pager diff-index --exit-code >>> -p HEAD -- :(literal)/scp:remote:/path/file.py") >>> signal(error ("Failed (status 128): git --no-pager diff-index --exit-code -p HEAD -- >>> :(literal)/scp:remote:/path/file.py")) >>> error("Failed (%s): %s" "status 128" "git --no-pager diff-index --exit-code -p HEAD -- >>> :(literal)/scp:remote:/path/file.py") >>> vc-do-command("*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") "--no-pager" >>> "diff-index" "--exit-code" "-p" "HEAD" nil "--") >>> apply(vc-do-command "*vc-diff*" 1 "git" (":(literal)/scp:remote:/path/file.py") ("--no-pager" >>> "diff-index" "--exit-code" "-p" "HEAD" nil "--")) >>> vc-git-command("*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" "--exit-code" >>> "-p" "HEAD" nil "--") >>> apply(vc-git-command "*vc-diff*" 1 (":(literal)/scp:remote:/path/file.py") "diff-index" >>> "--exit-code" ("-p" "HEAD" nil "--")) >>> vc-git-diff(("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) >>> apply(vc-git-diff (("/scp:remote:/path/file.py") nil nil "*vc-diff*" t)) >>> vc-call-backend(Git diff ("/scp:remote:/path/file.py") nil nil "*vc-diff*" t) >>> vc-diff-internal(t (Git ("/scp:remote:/path/file.py")) nil nil t) >>> vc-diff(nil t) >>> funcall-interactively(vc-diff nil t) >>> call-interactively(vc-diff nil nil) >>> command-execute(vc-diff) >>> >>> Same error on = (vc-diff) in the*vc-dir* buffer. >>> >>> I am pretty sure this is a regression from about 2-3 weeks ago. >>> >>> (vc-next-action also fails) >> This is the result of the git literal pathspec prefix being added in a >> non-tramp-aware way. See bug #39452. The commits in question are >> >> 3502321403 Fix regressions in the last change >> 3572613550 Fix vc-git-state for filenames with wildcards > I do have all these patches, but, alas, I still see the bug. > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39452 > has no messages for 10 days, I hope it is being worked on... We indeed applied a patch that's been lying around for a while and keep finding regressions. Now I was curious to see how we generally avoid passing remote file names (in Tramp syntax) to Git and other VCS, and it turns out vc-do-command, which almost all calls go though, converts all file names to relative ones. Which the new literal-pathspecs approach in vc-git conflicts with. I'm still not loving the idea of a dynamic variable to enable/disable the use of env var (fix for the problem we/I have met with the other approach), but it's becoming increasingly attractive. That said, I've just pushed a fix (commit 2b62b2a019), please see how it works for you. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 26 02:14:40 2021 Received: (at 50175-done) by debbugs.gnu.org; 26 Aug 2021 06:14:40 +0000 Received: from localhost ([127.0.0.1]:48179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ8eq-0008Cd-7e for submit@debbugs.gnu.org; Thu, 26 Aug 2021 02:14:40 -0400 Received: from smtp2.axis.com ([195.60.68.18]:53720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJ8ek-0008CK-Pr for 50175-done@debbugs.gnu.org; Thu, 26 Aug 2021 02:14:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1629958471; x=1661494471; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=H30Db4btAKF3NbB3aV8n2sivYn++QO8zFLf7OTof+E0=; b=kO5uE7kBJCBgUIvZHpvR3TpDkKjD0xikOCJwYM9xvExz2yxUhRNpHgnZ WcJFHKvZvDPfgpC8xF/z8ySA/2Ir5/MNv5yUHB+qZ7jOprxM0lF/3wNp+ i0z3FQL/tBtchx8es2kCQTPtsnT2P6p+iFcgqdQV+42KMqmAOLKmxISm5 kwvJXIYQs911S1VRZI6prgv9MqziU1HOCbgvWAUEzI9C4cZoBVkPcgx27 muhGquEVfaGvcwq1QVpEtOhiOo2H0nc9QdlNite6Gw+yKh7yd5xX0kccG ylxRIyUCj/u9O2T4tVPJ+hhSZPXbmLRH1gbKNKCjn8331nctpHyWHAUs4 g==; References: <9109d282-192c-22ec-6010-4e1f3cc97d9e@yandex.ru> User-agent: mu4e 1.4.8; emacs 28.0.50 From: Ola x Nilsson To: Dmitry Gutov Subject: Re: bug#50175: 28.0.50; tramp is hooked into C-x d (vc-dir) but not C-x = (vc-doff) In-Reply-To: <9109d282-192c-22ec-6010-4e1f3cc97d9e@yandex.ru> Date: Thu, 26 Aug 2021 08:14:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50175-done Cc: "larsi@gnus.org" , "sds@gnu.org" , "50175-done@debbugs.gnu.org" <50175-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Thu, Aug 26 2021, Dmitry Gutov wrote: > Hi! > > On 25.08.2021 18:45, Steingold wrote: >> Hi Ola, Lars, Dmitry, >> >>> * Ola x Nilsson [2021-08-25 15:26:34 +0200]: >>> >>> On Mon, Aug 23 2021, Steingold wrote: >>> >>>> when editing a remote file, vc-dir shows the*vc-dir* buffer correctly, >>>> but vc-diff in the same buffer fails: >>>> >>>> >>>> Same error on = (vc-diff) in the*vc-dir* buffer. >>>> >>>> I am pretty sure this is a regression from about 2-3 weeks ago. >>>> >>>> (vc-next-action also fails) >>> This is the result of the git literal pathspec prefix being added in a >>> non-tramp-aware way. See bug #39452. The commits in question are >>> >>> 3502321403 Fix regressions in the last change >>> 3572613550 Fix vc-git-state for filenames with wildcards >> I do have all these patches, but, alas, I still see the bug. >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39452 >> has no messages for 10 days, I hope it is being worked on... Sorry, I was not as clear as I should have been. The two commits above introduced the problem. Reverting them made vc-git work over tramp for me again. > We indeed applied a patch that's been lying around for a while and keep > finding regressions. > > Now I was curious to see how we generally avoid passing remote file > names (in Tramp syntax) to Git and other VCS, and it turns out > vc-do-command, which almost all calls go though, converts all file names > to relative ones. > > Which the new literal-pathspecs approach in vc-git conflicts with. I'm > still not loving the idea of a dynamic variable to enable/disable the > use of env var (fix for the problem we/I have met with the other > approach), but it's becoming increasingly attractive. > > That said, I've just pushed a fix (commit 2b62b2a019), please see how it > works for you. I did some light testing, and vc-diff and vc-annotate work for me now with git over tramp. -- Ola Nilsson From unknown Mon Jun 23 02:24:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Sep 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator