Subject: Re: bug#50162: [PATCH] gnu: global: Add ctags support.

From: Maxim Cournoyer <[email-masked]>
Date: Tue, 31 Aug 2021 10:31:20 -0400

Hello Efraim,

Efraim Flashner <[email-masked]> writes:

> On Mon, Aug 30, 2021 at 03:57:39PM -0400, Maxim Cournoyer wrote:
>> Hello!
>> 
>> Efraim Flashner <[email-masked]> writes:
>> 
>> > * gnu/packages/code.scm (global)[inputs]: Add bash-minimal,
>> > universal-ctags, python-pygments.
>> > [arguments]: Add configure-flags to find ctags. Add phases to install
>> > plugins and to wrap python script with PYTHONPATH.
>> > ---
>> >
>> > I've been using this variant of global for a couple of weeks now to get
>> > global to work with Guix.
>> >
>> > ---
>> >
>> >  gnu/packages/code.scm | 34 +++++++++++++++++++++++++++++-----
>> >  1 file changed, 29 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
>> > index a414cde3de..04b354b71e 100644
>> > --- a/gnu/packages/code.scm
>> > +++ b/gnu/packages/code.scm
>> > @@ -64,6 +64,7 @@
>> >    #:use-module (gnu packages perl-compression)
>> >    #:use-module (gnu packages pkg-config)
>> >    #:use-module (gnu packages python)
>> > +  #:use-module (gnu packages python-xyz)
>> >    #:use-module (gnu packages serialization)
>> >    #:use-module (gnu packages sqlite)
>> >    #:use-module (gnu packages texinfo)
>> > @@ -137,17 +138,26 @@ highlighting your own code that seemed comprehensible when you wrote it.")
>> >                (base32
>> >                 "0g4aslm2zajq605py11s4rs1wdnzcqhkh7bc2xl5az42adzzg839"))))
>> >      (build-system gnu-build-system)
>> > -    (inputs `(("coreutils" ,coreutils)
>> > -              ("ncurses" ,ncurses)
>> > -              ("libltdl" ,libltdl)
>> > -              ("sqlite" ,sqlite)
>> > -              ("python-wrapper" ,python-wrapper)))
>> > +    (inputs
>> > +      `(("bash" ,bash-minimal)                    ; for wrap-program
>> 
>> This is news to me; must we now provide bash-minimal every time
>> wrap-program is used?
>
> Its new, I think the aim was to make sure that even if a package is
> cross compiled it uses the correct bash when wrapping the
> program/script.

I see.  It's good that it's explicit, but on the other hand, it's a bit
tedious or error prone to have to remember to do so everywhere.  I'll
give it some time!

Thank you,

Maxim